virtualbox 0.4.3 → 0.5.0

data/test/virtualbox/attached_device_test.rb

@@ -17,6 +17,9 @@ class AttachedDeviceTest < Test::Unit::TestCase
 
     # Stub execute to make sure nothing actually happens
     VirtualBox::Command.stubs(:execute).returns('')
+
+    # Stub the config
+    VirtualBox::Global.stubs(:config).returns(mock_xml_doc)
   end
 
   context "validations" do
@@ -71,7 +74,7 @@ class AttachedDeviceTest < Test::Unit::TestCase
 
   context "saving an existing device" do
     setup do
-      @value = VirtualBox::AttachedDevice.populate_relationship(@caller, @data)
+      @value = VirtualBox::AttachedDevice.populate_relationship(@caller, mock_xml_doc)
       @value = @value[0]
       @value.image = VirtualBox::DVD.empty_drive
       assert @value.changed?
@@ -210,7 +213,7 @@ class AttachedDeviceTest < Test::Unit::TestCase
 
   context "destroying" do
     setup do
-      @value = VirtualBox::AttachedDevice.populate_relationship(@caller, @data)
+      @value = VirtualBox::AttachedDevice.populate_relationship(@caller, mock_xml_doc)
       @value = @value[0]
 
       @image = mock("image")
@@ -278,7 +281,7 @@ class AttachedDeviceTest < Test::Unit::TestCase
 
   context "populating relationships" do
     setup do
-      @value = VirtualBox::AttachedDevice.populate_relationship(@caller, @data)
+      @value = VirtualBox::AttachedDevice.populate_relationship(@caller, mock_xml_doc)
     end
 
     should "create the correct amount of objects" do
@@ -288,13 +291,13 @@ class AttachedDeviceTest < Test::Unit::TestCase
     should "create objects with proper values" do
       obj = @value[0]
       assert_equal "none", obj.medium
-      assert_equal "322f79fd-7da6-416f-a16f-e70066ccf165", obj.uuid
-      assert_equal 0, obj.port
+      assert_equal "2c16dd48-4cf1-497e-98fa-84ed55cfe71f", obj.uuid
+      assert_equal "0", obj.port
 
       obj = @value[1]
-      assert_equal "none", obj.medium
+      assert_equal "emptydrive", obj.medium
       assert_nil obj.uuid
-      assert_equal 1, obj.port
+      assert_equal "1", obj.port
     end
   end
 end

data/test/virtualbox/command_test.rb

@@ -1,6 +1,19 @@
 require File.join(File.dirname(__FILE__), '..', 'test_helper')
 
 class CommandTest < Test::Unit::TestCase
+  context "parsing XML" do
+    should "open the file, parse it, and close the file" do
+      arg = "foo"
+      file = mock("file")
+      seq = sequence("seq")
+      File.expects(:open).with(arg, "r").returns(file).in_sequence(seq)
+      Nokogiri.expects(:XML).in_sequence(seq)
+      file.expects(:close).in_sequence(seq)
+
+      VirtualBox::Command.parse_xml(arg)
+    end
+  end
+
   context "shell escaping" do
     should "convert value to string" do
       assert_nothing_raised do

data/test/virtualbox/dvd_test.rb

@@ -8,6 +8,7 @@ class DVDTest < Test::Unit::TestCase
   context "destroying a dvd" do
     setup do
       @dvd = VirtualBox::DVD.new
+      VirtualBox::DVD.reloaded!
     end
 
     should "return false if attempting to destroy an empty drive" do
@@ -30,6 +31,11 @@ class DVDTest < Test::Unit::TestCase
         @dvd.destroy(true)
       }
     end
+
+    should "mark the global class for reloading" do
+      VirtualBox::Global.expects(:reload!)
+      assert @dvd.destroy
+    end
   end
 
   context "empty drive" do
@@ -46,19 +52,34 @@ class DVDTest < Test::Unit::TestCase
 
   context "retrieving all dvds" do
     setup do
-      @expectations = {
-        "d3252617-8176-4f8c-9d73-1c9c82b23960" => {
-          :location   => "/Users/mitchellh/Downloads/jeos-8.04.3-jeos-i386.iso",
-          :accessible => "yes"
-        },
-
-        "4a08f52c-bca3-4908-8da4-4f48aaa4ebba" => {
-          :location   => "/Applications/VirtualBox.app/Contents/MacOS/VBoxGuestAdditions.iso",
-          :accessible => "yes"
+      @media = mock("media")
+      @media.expects(:dvds).returns([])
+      @global = mock("global")
+      @global.expects(:media).returns(@media)
+    end
+
+    should "return an array of DVD objects" do
+      VirtualBox::Global.expects(:global).returns(@global)
+      result = VirtualBox::DVD.all
+      assert result.is_a?(Array)
+    end
+  end
+
+  context "retrieving all dvds by command" do
+      setup do
+        @expectations = {
+          "d3252617-8176-4f8c-9d73-1c9c82b23960" => {
+            :location   => "/Users/mitchellh/Downloads/jeos-8.04.3-jeos-i386.iso",
+            :accessible => "yes"
+          },
+
+          "4a08f52c-bca3-4908-8da4-4f48aaa4ebba" => {
+            :location   => "/Applications/VirtualBox.app/Contents/MacOS/VBoxGuestAdditions.iso",
+            :accessible => "yes"
+          }
         }
-      }
 
-      @valid = <<-valid
+        @valid = <<-valid
 UUID:       d3252617-8176-4f8c-9d73-1c9c82b23960
 Path:       /Users/mitchellh/Downloads/jeos-8.04.3-jeos-i386.iso
 Accessible: yes
@@ -69,29 +90,30 @@ Accessible: yes
 Usage:      TestJeOS (UUID: 3d0f87b4-50f7-4fc5-ad89-93375b1b32a3)
 valid
 
-      VirtualBox::Command.expects(:vboxmanage).with("list", "dvds").returns(@valid)
-    end
+        VirtualBox::Command.expects(:vboxmanage).with("list", "dvds").returns(@valid).once
+      end
 
-    should "return an array of DVD objects" do
-      result = VirtualBox::DVD.all
-      assert result.is_a?(Array)
+      should "return an array of DVD objects" do
+        result = VirtualBox::DVD.all_from_command
+        assert result.is_a?(Array)
+        assert_equal @expectations.length, result.length
 
-      result.each { |v| assert v.is_a?(VirtualBox::DVD) }
-    end
+        result.each { |v| assert v.is_a?(VirtualBox::DVD) }
+      end
 
-    should "return the proper results" do
-      result = VirtualBox::DVD.all
-      assert result.is_a?(Array)
-      assert_equal @expectations.length, result.length
+      should "return the proper results" do
+        result = VirtualBox::DVD.all_from_command
+        assert result.is_a?(Array)
+        assert_equal @expectations.length, result.length
 
-      result.each do |image|
-        expected_image = @expectations[image.uuid]
-        assert expected_image
+        result.each do |image|
+          expected_image = @expectations[image.uuid]
+          assert expected_image
 
-        expected_image.each do |k,v|
-          assert_equal v, image.read_attribute(k)
+          expected_image.each do |k,v|
+            assert_equal v, image.read_attribute(k)
+          end
         end
       end
     end
-  end
 end

data/test/virtualbox/extra_data_test.rb

@@ -38,23 +38,11 @@ raw
     setup do
       @caller = mock("caller")
       @caller.stubs(:name).returns("foocaller")
-
-      VirtualBox::Command.stubs(:vboxmanage).returns(@raw)
     end
 
     context "populating" do
-      should "call VBoxManage for the caller" do
-        VirtualBox::Command.expects(:vboxmanage).with("getextradata", @caller.name, "enumerate").returns(@raw)
-        VirtualBox::ExtraData.populate_relationship(@caller, {})
-      end
-
-      should "call pairs_to_objects with parent set to the caller" do
-        VirtualBox::ExtraData.expects(:parse_kv_pairs).with(@raw, @caller).once
-        VirtualBox::ExtraData.populate_relationship(@caller, {})
-      end
-
-      should "return an array of ExtraData objects" do
-        result = VirtualBox::ExtraData.populate_relationship(@caller, {})
+      should "return a ExtraData object" do
+        result = VirtualBox::ExtraData.populate_relationship(@caller, mock_xml_doc)
         assert result.is_a?(VirtualBox::ExtraData)
       end
     end
@@ -153,24 +141,25 @@ raw
 
   context "global extra data" do
     setup do
-      get_seq = sequence("get_seq")
-      VirtualBox::Command.expects(:vboxmanage).with("getextradata", "global", "enumerate").once.in_sequence(get_seq)
-      VirtualBox::ExtraData.expects(:parse_kv_pairs).returns(@ed).once.in_sequence(get_seq)
+      global = mock("global")
+      global.expects(:extra_data).once.returns("foo")
+      VirtualBox::Global.expects(:global).returns(global)
       @global = VirtualBox::ExtraData.global(true)
     end
 
-    should "call the command, parse it, then turn it into objects" do
-      assert_equal "bar", @global["foo"]
+    should "call the global extra data if it has never been loaded" do
+      assert_equal "foo", VirtualBox::ExtraData.global
     end
 
     should "return the same object if it exists for global data, rather than recreating it" do
-      VirtualBox::Command.expects(:vboxmanage).never
+      VirtualBox::Global.expects(:global).never
       assert_equal @global, VirtualBox::ExtraData.global
     end
 
     should "return a new object if reload is true" do
-      VirtualBox::Command.expects(:vboxmanage).once
-      VirtualBox::ExtraData.expects(:parse_kv_pairs).returns(@ed.dup).once
+      global = mock("global")
+      global.expects(:extra_data).once.returns("bar")
+      VirtualBox::Global.expects(:global).returns(global)
       assert !@global.equal?(VirtualBox::ExtraData.global(true))
     end
   end
@@ -186,33 +175,4 @@ raw
       assert_equal "global", ed.parent
     end
   end
-
-  context "parsing KV pairs" do
-    setup do
-      @data = VirtualBox::ExtraData.parse_kv_pairs(@raw)
-    end
-
-    should "return the proper number of items" do
-      # Shows that it skips over non-matching lines as well
-      assert_equal 6, @data.length
-    end
-
-    should "return as an ExtraData Hash" do
-      assert @data.is_a?(Hash)
-      assert @data.is_a?(VirtualBox::ExtraData)
-    end
-
-    should "return proper values, trimmed" do
-      assert_equal "1 d, 2010-01-29, stable", @data["GUI/UpdateDate"]
-    end
-
-    should  "send the 2nd param as the parent to the ED object" do
-      @data = VirtualBox::ExtraData.parse_kv_pairs(@raw, "FOO")
-      assert_equal "FOO", @data.parent
-    end
-
-    should "return an unchanged ED object" do
-      assert !@data.changed?
-    end
-  end
 end

data/test/virtualbox/global_test.rb

@@ -0,0 +1,78 @@
+require File.join(File.dirname(__FILE__), '..', 'test_helper')
+
+class GlobalTest < Test::Unit::TestCase
+  context "getting the global config" do
+    should "only get it once, then cache" do
+      VirtualBox::Global.expects(:config).returns(mock_xml_doc).once
+      result = VirtualBox::Global.global(true)
+      assert result
+      assert result.equal?(VirtualBox::Global.global)
+    end
+
+    should "reload if reload is true" do
+      VirtualBox::Global.expects(:config).returns(mock_xml_doc).twice
+      result = VirtualBox::Global.global(true)
+      assert result
+      assert !result.equal?(VirtualBox::Global.global(true))
+    end
+
+    should "reload if global reload flag is set" do
+      VirtualBox::Global.reload!
+      VirtualBox::Global.expects(:config).returns(mock_xml_doc).once
+      VirtualBox::Global.global
+      assert !VirtualBox::Global.reload?
+    end
+  end
+
+  context "parsing configuration XML" do
+    setup do
+      File.stubs(:exist?).returns(true)
+      VirtualBox::Command.stubs(:parse_xml)
+    end
+
+    should "check the file with the expanded path" do
+      File.stubs(:expand_path).returns("FOO")
+      File.expects(:exist?).with("FOO").returns(true)
+      VirtualBox::Global.config
+    end
+
+    should "raise an error if the config XML doesn't exist" do
+      File.expects(:exist?).returns(false)
+      assert_raises(VirtualBox::Exceptions::ConfigurationException) do
+        VirtualBox::Global.config
+      end
+    end
+
+    should "use Command.parse_xml to parse" do
+      VirtualBox::Command.expects(:parse_xml).with(anything).once
+      VirtualBox::Global.config
+    end
+
+    should "use the set vboxconfig to parse xml" do
+      VirtualBox::Global.vboxconfig = "/foo"
+      VirtualBox::Command.expects(:parse_xml).with("/foo").once
+      VirtualBox::Global.config
+    end
+
+    should "file expand path the vboxconfig path" do
+      VirtualBox::Global.vboxconfig = "foo"
+      VirtualBox::Command.expects(:parse_xml).with(File.expand_path("foo")).once
+      VirtualBox::Global.config
+    end
+  end
+
+  context "expanding path" do
+    setup do
+      VirtualBox::Global.vboxconfig = "/foo/bar/baz.rb"
+    end
+
+    should "expand the path properly" do
+      assert_equal "/foo/bar/vroom/rawr.bak", VirtualBox::Global.expand_path("vroom/rawr.bak")
+    end
+
+    should "expand the path relative to the vboxconfig directory" do
+      File.expects(:expand_path).with("foo", "/foo/bar").once
+      VirtualBox::Global.expand_path("foo")
+    end
+  end
+end

data/test/virtualbox/hard_drive_test.rb

@@ -19,6 +19,34 @@ raw
     VirtualBox::Command.stubs(:vboxmanage).with("showhdinfo", @name).returns(@find_raw)
   end
 
+  context "populating relationship" do
+    setup do
+      @xml = <<-xml
+<MediaRegistry>
+  <HardDisks>
+    <HardDisk uuid="{9d2e4353-d1e9-466c-ac58-f2249264147b}" location="HardDisks/TestJeOS.vdi" format="VDI" type="Normal"/>
+    <HardDisk uuid="{5f7ccd06-78ef-47e9-b2bc-515aedd2f288}" location="HardDisks/hobobase.vdi" format="VDI" type="Normal"/>
+  </HardDisks>
+</MediaRegistry>
+xml
+      @doc = Nokogiri::XML(@xml)
+    end
+
+    should "create an object for each hard disk entry" do
+      result = VirtualBox::HardDrive.populate_relationship(nil, @doc)
+      assert_equal 2, result.length
+    end
+
+    should "properly extract uuid, location, and format" do
+      VirtualBox::Global.vboxconfig = "/foo/rawr.rb"
+      result = VirtualBox::HardDrive.populate_relationship(nil, @doc)
+      result = result[0]
+      assert_equal "9d2e4353-d1e9-466c-ac58-f2249264147b", result.uuid
+      assert_equal "VDI", result.format
+      assert_equal "/foo/HardDisks/TestJeOS.vdi", result.location
+    end
+  end
+
   context "validations" do
     setup do
       @hd = VirtualBox::HardDrive.new
@@ -206,64 +234,13 @@ raw
   end
 
   context "retrieving all hard drives" do
-    setup do
-      @valid = <<-valid
-UUID:       9d2e4353-d1e9-466c-ac58-f2249264147b
-Format:     VDI
-Location:   /Users/mitchellh/Library/VirtualBox/HardDisks/foo.vdi
-Accessible: yes
-Type:       normal
-Usage:      TestJeOS (UUID: 3d0f87b4-50f7-4fc5-ad89-93375b1b32a3)
-
-UUID:       11dedd14-57a1-4bdb-adeb-dd1d67f066e1
-Format:     VDI
-Location:   /Users/mitchellh/Library/VirtualBox/HardDisks/bar.vdi
-Accessible: yes
-Type:       normal
-Usage:      HoboBase (UUID: 696249ad-00b6-4087-b47f-9b82629efc31)
-
-UUID:       5e090af6-7d71-4f40-8b03-33aa665f9ecf
-Format:     VMDK
-Location:   /Users/mitchellh/Library/VirtualBox/HardDisks/baz.vmdk
-Accessible: yes
-Type:       normal
-Usage:      foo (UUID: 8710d3db-d96a-46ed-9004-59fa891fda90)
-valid
-
-      VirtualBox::Command.stubs(:vboxmanage).with("list", "hdds").returns(@valid)
-
-      @hd = mock("hd")
-      @hd.stubs(:is_a?).with(VirtualBox::HardDrive).returns(true)
-      VirtualBox::HardDrive.expects(:find).at_least(0).returns(@hd)
-    end
-
     should "return an array of HardDrive objects" do
-      result = VirtualBox::HardDrive.all
-      assert result.is_a?(Array)
-
-      result.each { |v| assert v.is_a?(VirtualBox::HardDrive) }
-    end
-
-    should "forward the raise_error flag to find" do
-      VirtualBox::HardDrive.expects(:find).with(anything, true).raises(VirtualBox::Exceptions::CommandFailedException)
-      assert_raises(VirtualBox::Exceptions::CommandFailedException) {
-        VirtualBox::HardDrive.all(true)
-      }
-    end
-
-    should "return false if an error occured" do
-      VirtualBox::Command.stubs(:vboxmanage).raises(VirtualBox::Exceptions::CommandFailedException)
-
-      assert_nothing_raised do
-        assert !VirtualBox::HardDrive.all
-      end
-    end
-
-    should "raise an exception if flag is set" do
-      VirtualBox::Command.stubs(:vboxmanage).raises(VirtualBox::Exceptions::CommandFailedException)
-      assert_raises(VirtualBox::Exceptions::CommandFailedException) {
-        VirtualBox::HardDrive.all(true)
-      }
+      media = mock("media")
+      media.expects(:hard_drives).returns("foo")
+      global = mock("global")
+      global.expects(:media).returns(media)
+      VirtualBox::Global.expects(:global).returns(global)
+      assert_equal "foo", VirtualBox::HardDrive.all
     end
   end
 end