vendor 0.0.4 → 0.1

data/spec/lib/vendor/vendor_file/library/remote_spec.rb

@@ -2,12 +2,162 @@ require 'spec_helper'
 
 describe Vendor::VendorFile::Library::Remote do
 
-  let(:lib) { Vendor::VendorFile::Library::Remote.new }
+  let(:lib) { Vendor::VendorFile::Library::Remote.new(:name => "DKBenchmark", :version => "0.1") }
 
-  it "should have a version attribute" do
-    lib.version = "3.0.5"
+  context "#download" do
+
+    before :each do
+      Vendor.stub(:library_path).and_return Dir.mktmpdir("spec")
+    end
+
+    it "should find the correct version if one isn't set on the lib" do
+      lib.version = nil
+
+      lib.matched_version.should == "0.2"
+    end
+
+    it "should download the lib if its not cached locally" do
+      Vendor::API.should_receive(:download).with(lib.name, lib.version).and_return(File.open(File.join(PACKAGED_VENDOR_PATH, "DKBenchmark-0.1.vendor")))
+
+      lib.download
+    end
+
+    it "should not download the lib if it already exists" do
+      File.should_receive(:exist?).with(lib.cache_path).and_return(true)
+      Vendor::API.should_not_receive(:download).with(lib.name, lib.version)
+
+      lib.download
+    end
+
+    it "should unzip the file" do
+      lib.download
+
+      File.exist?(File.join(lib.cache_path, "vendor.json"))
+      File.exist?(File.join(lib.cache_path, "data/DKBenchmark.h"))
+      File.exist?(File.join(lib.cache_path, "data/DKBenchmark.m"))
+    end
+
+  end
+
+  context "#cache_path" do
+
+    it "should contain the name of the vendor and the version" do
+      lib.cache_path.should =~ /DKBenchmark\/0.1$/
+    end
+
+  end
+
+  context "#matched_version" do
+
+    it "should just return the version if there is no equality matche" do
+      lib.version = "3.0.5"
+      lib.matched_version.should == "3.0.5"
+    end
+
+    it "should just return the correct version if no version is passed" do
+      lib.version = nil
+      # The DKBenchmark FakeWeb call returns 0.2 as the latest release
+      lib.matched_version.should == "0.2"
+    end
+
+    context "when finding the correct library" do
+
+      before :each do
+        lib.stub!('meta').and_return({ "versions" => [ [ "0.1"] , [ "0.1.1" ], [ "0.1.2.alpha" ], [ "0.2"] , [ "0.5" ], [ "0.6.1" ], [ "0.6.2" ], [ "0.6.8" ] ] })
+      end
+
+      it "should match <=" do
+        lib.version = "<= 0.5"
+        lib.matched_version.to_s.should == "0.6.8"
+      end
+
+      it "should match >=" do
+        lib.version = ">= 0.2"
+        lib.matched_version.to_s.should == "0.2"
+      end
+
+      it "should match >" do
+        lib.version = "> 0.2"
+        lib.matched_version.to_s.should == "0.1.1"
+      end
+
+      it "should match <" do
+        lib.version = "< 0.2"
+        lib.matched_version.to_s.should == "0.6.8"
+      end
+
+      it "should match ~>" do
+        lib.version = "~> 0.6"
+        lib.matched_version.to_s.should == "0.6.8"
+      end
+
+      it "should not return pre-releases" do
+        lib.version = "~> 0.1"
+        lib.matched_version.to_s.should == "0.1.1"
+      end
+
+      it "should return pre-releases if specified specifically" do
+        lib.version = "~> 0.1.2.alpha"
+        lib.matched_version.to_s.should == "0.1.2.alpha"
+      end
+
+    end
+
+  end
+
+  context "#==" do
+
+    it "should return true if the libs match" do
+      x = Vendor::VendorFile::Library::Remote.new(:name => "DKRest", :version => "1.0", :equality => "~>")
+      y = Vendor::VendorFile::Library::Remote.new(:name => "DKRest", :version => "1.0", :equality => "~>")
+
+      x.should == y
+    end
+
+    it "should return false if the libs don't match" do
+      x = Vendor::VendorFile::Library::Remote.new(:name => "DKRest", :version => "1.0", :equality => "~>")
+      y = Vendor::VendorFile::Library::Remote.new(:name => "DKRest", :version => "1.1", :equality => "~>")
+
+      x.should_not == y
+    end
+
+  end
+
+  context "#version=" do
+
+    it "should have a version attribute" do
+      lib.version = "3.0.5"
+
+      lib.version.should == "3.0.5"
+    end
+
+    it "should handle versions with an equality matcher" do
+      lib.version = "<= 3.0"
+      lib.equality.should == "<="
+      lib.version.should == "3.0"
+
+      lib.version = ">= 3.1"
+      lib.equality.should == ">="
+      lib.version.should == "3.1"
+
+      lib.version = "~> 3.2"
+      lib.equality.should == "~>"
+      lib.version.should == "3.2"
+    end
+
+    it "should clear the version and the equality if you pass nil" do
+      lib.version = nil
+      lib.equality.should be_nil
+      lib.version.should be_nil
+    end
+
+    it "should exit if you pass something silly to it" do
+      expect do
+        Vendor.ui.should_receive(:error).with("Invalid version format '+ .5' for 'DKBenchmark'")
+        lib.version = "+ .5"
+      end.should raise_error(SystemExit)
+    end
 
-    lib.version.should == "3.0.5"
   end
 
 end

data/spec/lib/vendor/vendor_file/loader_spec.rb

@@ -39,11 +39,13 @@ describe Vendor::VendorFile::Loader do
       @libs[1].should be_kind_of(Vendor::VendorFile::Library::Remote)
 
       @libs[2].name.should == "LibWithGreaterThanVersion"
-      @libs[2].version.should == ">=1.0"
+      @libs[2].version.should == "1.0"
+      @libs[2].equality.should == ">="
       @libs[2].should be_kind_of(Vendor::VendorFile::Library::Remote)
 
       @libs[3].name.should == "LibWithApproxVersionAndTarget"
-      @libs[3].version.should == "~>1.0"
+      @libs[3].version.should == "1.0"
+      @libs[3].equality.should == "~>"
       @libs[3].targets.should == [ "something" ]
       @libs[3].should be_kind_of(Vendor::VendorFile::Library::Remote)
     end

data/spec/lib/vendor/vendor_spec/builder_spec.rb

@@ -9,7 +9,7 @@ describe Vendor::VendorSpec::Builder do
       let (:builder) { Vendor::VendorSpec::Builder.new(File.join(VENDOR_RESOURCE_PATH, "DKBenchmark", "DKBenchmark.vendorspec")) }
 
       it "should load in the vendor spec" do
-        builder.vendor_spec[:name].should == "DKBenchmark"
+        builder.vendor_spec.name.should == "DKBenchmark"
       end
 
       it "should load the name of the vendor" do
@@ -31,7 +31,7 @@ describe Vendor::VendorSpec::Builder do
       let (:builder) { Vendor::VendorSpec::Builder.new(File.join(VENDOR_RESOURCE_PATH, "DKBenchmarkUnsafe", "DKBenchmark.vendorspec")) }
 
       it "should load in the vendor spec" do
-        builder.vendor_spec[:name].should == "DKBen!/asdf535chmark"
+        builder.vendor_spec.name.should == "DKBen!/asdf535chmark"
       end
 
       it "should load the name of the vendor" do

data/spec/lib/vendor/version_spec.rb

@@ -0,0 +1,168 @@
+require 'spec_helper'
+
+describe Vendor::Version do
+
+  describe "#bump" do
+
+    it "should incement versions" do
+      v("5.2.4").bump.should == v("5.3")
+    end
+
+    it "should bump from an alpha" do
+      v("5.2.4.a").bump.should == v("5.3")
+    end
+
+    it "should bump from an alpha numberic extension" do
+      v("5.2.4.a10").bump.should == v("5.3")
+    end
+
+    it "should bump with trailing zeros" do
+      v("5.0.0").bump.should == v("5.1")
+    end
+
+    it "should bump from one level" do
+      v("5").bump.should == v("6")
+    end
+
+  end
+
+  describe "#create" do
+
+    it "should return itself when passing in a version object" do
+      Vendor::Version.create(v("1.0")).should == v("1.0")
+    end
+
+    it "should return nil when passing nil" do
+      Vendor::Version.create(nil).should be_nil
+    end
+
+    it "should allow you to create a version from a string" do
+      Vendor::Version.create("5.1").should == v("5.1")
+    end
+
+  end
+
+  describe "#==" do
+
+    it "should equal versions if the versions are the same" do
+      v("1.2").should == v("1.2")
+      v("1.2.b1").should == v("1.2.b.1")
+    end
+
+    it "should not equal if the versions are different" do
+      v("1.2").should_not == v("1.2.3")
+    end
+
+  end
+
+  describe "#eql?" do
+
+    it "should equal versions if the versions are the same" do
+      v("1.2").should == v("1.2")
+    end
+
+    it "should not equal if the versions are different" do
+      v("1.2").eql?(v("1.2.3")).should be_false
+      v("1.2.0").eql?(v("1.2")).should be_false
+      v("1.2.b1").eql?(v("1.2.b.1")).should be_false
+    end
+
+  end
+
+  describe "#initialize" do
+
+    ["1.0", "1.0 ", " 1.0 ", "1.0\n", "\n1.0\n"].each do |good|
+      it "should handle different input formats (#{good.inspect})" do
+        Vendor::Version.new(good).should == v("1.0")
+      end
+    end
+
+    it "should handle integers" do
+      Vendor::Version.new("1").should == v(1)
+    end
+
+    ["junk", "1.0\n2.0"].each do |bad|
+      it "should raise argument errors for bad version formats (#{bad.inspect})" do
+
+        expect do
+          Vendor::Version.new(bad)
+        end.should raise_error(ArgumentError, "Malformed version number string #{bad}")
+
+      end
+    end
+
+  end
+
+  describe "#prerelease" do
+
+    it "should return true if the version is a prerelease" do
+      v("1.2.0.a").should be_prerelease
+      v("2.9.b").should be_prerelease
+      v("22.1.50.0.d").should be_prerelease
+      v("1.2.d.42").should be_prerelease
+      v('1.A').should be_prerelease
+    end
+
+    it "should return false if the version is not a prerelease" do
+      v("1.2.0").should_not be_prerelease
+      v("2.9").should_not be_prerelease
+      v("22.1.50.0").should_not be_prerelease
+    end
+
+  end
+
+  describe "#release" do
+
+    it "should return the release version" do
+      v("1.2.0.a").release.should == v("1.2.0")
+      v("1.1.rc10").release.should == v("1.1")
+      v("1.9.3.alpha.5").release.should == v("1.9.3")
+      v("1.9.3").release.should == v("1.9.3")
+    end
+
+  end
+
+  describe "<=>" do
+
+    it "should return the correct value from the spaceship operator" do
+      (v("1.0") <=> v("1.0.0")).should == 0
+      (v("1.0") <=> v("1.0.a")).should == 1
+      (v("1.8.2") <=> v("0.0.0")).should == 1
+      (v("1.8.2") <=> v("1.8.2.a")).should == 1
+      (v("1.8.2.b") <=> v("1.8.2.a")).should == 1
+      (v("1.8.2.a") <=> v("1.8.2")).should == -1
+      (v("1.8.2.a10") <=> v("1.8.2.a9")).should == 1
+      (v("") <=> v("0")).should == 0
+
+    end
+
+  end
+
+  describe "#spermy_recommendation" do
+
+    it "should return the correct recomendation" do
+      v("1").spermy_recommendation.should == "~> 1.0"
+      v("1.0").spermy_recommendation.should == "~> 1.0"
+      v("1.2").spermy_recommendation.should == "~> 1.2"
+      v("1.2.0").spermy_recommendation.should == "~> 1.2"
+      v("1.2.3").spermy_recommendation.should == "~> 1.2"
+      v("1.2.3.a.4").spermy_recommendation.should == "~> 1.2"
+    end
+
+  end
+
+  describe "#to_s" do
+
+    it "should return a string represenation of the version" do
+      v("5.2.4").to_s.should == "5.2.4"
+    end
+
+  end
+
+  private
+
+    def v(version)
+      Vendor::Version.create(version)
+    end
+
+end

data/spec/lib/vendor/xcode/project_spec.rb

@@ -42,6 +42,16 @@ describe Vendor::XCode::Project do
 
     end
 
+    context "RestKitProject.xcodeproj" do
+
+      it "should parse and load all the objects" do
+        project = Vendor::XCode::Project.new(File.join(PROJECT_RESOURCE_PATH, "RestKitProject/RestKitProject.xcodeproj"))
+
+        project.objects.length.should == 69
+      end
+
+    end
+
   end
 
   context "#name" do
@@ -188,7 +198,18 @@ describe Vendor::XCode::Project do
         File.exist?(file).should be_false
       end
 
-      it "should remove the files from the build targets"
+      it "should remove the files from all the targets" do
+        ids = @temp_project.find_group("UtilityApplication/Classes").children.map(&:id)
+        @temp_project.remove_group("UtilityApplication/Classes")
+
+        @temp_project.root_object.targets.each do |target|
+          ids.each do |id|
+            target.build_phases.each do |phase|
+              phase.files.map(&:file_ref).map(&:id).should_not include(id)
+            end
+          end
+        end
+      end
 
       private
 
@@ -210,7 +231,85 @@ describe Vendor::XCode::Project do
 
   end
 
-  context "#remove_file"
+  context "#add_framework" do
+
+    before :each do
+      @temp_path = TempProject.create(File.join(PROJECT_RESOURCE_PATH, "MultipleTargets"))
+      @temp_project = Vendor::XCode::Project.new(File.join(@temp_path, "MultipleTargets.xcodeproj"))
+    end
+
+    it "should add the framework to the right targets" do
+      @temp_project.should_receive(:add_file).with({ :targets => @temp_project.find_target("Integration"),
+                                                     :file => "System/Library/Frameworks/KeithPitt.framework",
+                                                     :path => "Frameworks",
+                                                     :source_tree => :sdkroot })
+
+      @temp_project.add_framework "KeithPitt.framework", :targets => "Integration"
+    end
+
+    it "shouldn't add the framework if it already exists" do
+      @temp_project.should_not_receive(:add_file)
+
+      @temp_project.add_framework "Foundation.framework", :targets => "Integration"
+    end
+
+  end
+
+  context "#add_build_setting" do
+
+    before :each do
+      @temp_path = TempProject.create(File.join(PROJECT_RESOURCE_PATH, "MultipleTargets"))
+      @temp_project = Vendor::XCode::Project.new(File.join(@temp_path, "MultipleTargets.xcodeproj"))
+      @target = @temp_project.find_target("Specs")
+    end
+
+    it "should add build settings if they are not there" do
+      @temp_project.add_build_setting "SOMETHING", "YES", :targets => "Specs", :changer => "SomeLib"
+
+      @target.build_configuration_list.build_configurations.each do |config|
+        config.build_settings.keys.should include("SOMETHING")
+        config.build_settings["SOMETHING"].should == "YES"
+      end
+    end
+
+    it "should create an array of options if the setting is known to be a selection" do
+      @temp_project.add_build_setting "OTHER_LDFLAGS", "-ObjC", :targets => "Specs", :changer => "SomeLib"
+      @temp_project.add_build_setting "OTHER_LDFLAGS", "-Something", :targets => "Specs", :changer => "SomeLib"
+
+      @target.build_configuration_list.build_configurations.each do |config|
+        config.build_settings["OTHER_LDFLAGS"].should == [ "-ObjC", "-Something" ]
+      end
+    end
+
+    it "should not duplicate build settings" do
+      @temp_project.add_build_setting "OTHER_LDFLAGS", "-ObjC", :targets => "Specs", :changer => "SomeLib"
+      @temp_project.add_build_setting "OTHER_LDFLAGS", "-ObjC", :targets => "Specs", :changer => "SomeLib"
+
+      @target.build_configuration_list.build_configurations.each do |config|
+        config.build_settings["OTHER_LDFLAGS"].should == "-ObjC"
+      end
+    end
+
+    it "shouldn't change a build setting if it already exists" do
+      @temp_project.add_build_setting "SOMETHING", "YES", :targets => "Specs", :changer => "SomeLib"
+
+      Vendor.ui.should_receive(:warn).with("  Build setting \"SOMETHING\" wanted to change to \"NO\", but it was already \"YES\" in \"Specs/Debug\"").ordered
+      Vendor.ui.should_receive(:warn).with("  Build setting \"SOMETHING\" wanted to change to \"NO\", but it was already \"YES\" in \"Specs/Release\"").ordered
+      @temp_project.add_build_setting "SOMETHING", "NO", :targets => "Specs", :changer => "SomeLib"
+
+      @target.build_configuration_list.build_configurations.each do |config|
+        config.build_settings.keys.should include("SOMETHING")
+        config.build_settings["SOMETHING"].should == "YES"
+      end
+    end
+
+    it "should mark the project as dirty" do
+      @temp_project.add_build_setting "SOMETHING", "YES", :targets => "Specs", :changer => "SomeLib"
+
+      @temp_project.dirty?.should be_true
+    end
+
+  end
 
   context '#add_file' do
 
@@ -280,7 +379,72 @@ describe Vendor::XCode::Project do
         @temp_project.save
       end
 
-      it 'should add it to the build targets specified'
+      it 'should add it to the build targets specified' do
+        build_phase = @target.build_phases.first
+
+        build_phase.files[-2].file_ref.should_not == @first_file_added
+
+        build_phase.files[-1].isa.should == "PBXBuildFile"
+        build_phase.files[-1].should be_kind_of(Vendor::XCode::Proxy::PBXBuildFile)
+        build_phase.files[-1].file_ref.should == @second_file_added
+      end
+
+      it "should throw an error if you try and add to a target that doesn't exist" do
+        expect do
+          @temp_project.add_file :targets => [ "Blah" ], :file => first_file,
+                                 :path => "Controllers/SecondViewController", :source_tree => :group
+        end.should raise_error(StandardError, "Could not find target 'Blah' in project 'ProjectWithSpecs'")
+      end
+
+    end
+
+    context "with a source tree of :sdkroot" do
+
+      before :each do
+        @first_file_added = @temp_project.add_file :targets => [ @target ], :file => "System/Library/Frameworks/Foundation.framework",
+                                                   :path => "Frameworks", :source_tree => :sdkroot
+        @second_file_added = @temp_project.add_file :targets => [ @target ], :file => "System/Library/Frameworks/CoreGraphics.framework",
+                                                    :path => "Frameworks", :source_tree => :sdkroot
+      end
+
+      it "should mark the project as dirty" do
+        @temp_project.dirty.should be_true
+      end
+
+      it 'should add it as the correct file type' do
+        @first_file_added.last_known_file_type.should == "wrapper.framework"
+        @second_file_added.last_known_file_type.should == "wrapper.framework"
+      end
+
+      it 'should add the files with the correct path' do
+        @first_file_added.path.should == "System/Library/Frameworks/Foundation.framework"
+        @second_file_added.path.should == "System/Library/Frameworks/CoreGraphics.framework"
+      end
+
+      it 'should have an ID' do
+        @first_file_added.id.should_not be_nil
+        @second_file_added.id.should_not be_nil
+      end
+
+      it 'should add it to the correct group' do
+        group = @temp_project.create_group("Frameworks")
+
+        group.children[-2].should == @first_file_added
+        group.children[-1].should == @second_file_added
+      end
+
+      it 'should still save' do
+        @temp_project.save
+      end
+
+      it 'should add it to the build targets specified' do
+        build_phase = @target.build_phases[1]
+
+        build_phase.files[-2].should be_kind_of(Vendor::XCode::Proxy::PBXBuildFile)
+        build_phase.files[-2].file_ref.should == @first_file_added
+        build_phase.files[-1].should be_kind_of(Vendor::XCode::Proxy::PBXBuildFile)
+        build_phase.files[-1].file_ref.should == @second_file_added
+      end
 
     end
 
@@ -334,7 +498,14 @@ describe Vendor::XCode::Project do
         @temp_project.save
       end
 
-      it 'should add it to the build targets specified'
+      it 'should add it to the build targets specified' do
+        build_phase = @target.build_phases.first
+
+        build_phase.files[-2].file_ref.should_not == @first_file_added
+
+        build_phase.files[-1].should be_kind_of(Vendor::XCode::Proxy::PBXBuildFile)
+        build_phase.files[-1].file_ref.should == @second_file_added
+      end
 
     end