vendor 0.0.4 → 0.1

data/lib/vendor/xcode/proxy.rb

@@ -17,6 +17,7 @@ module Vendor
       autoload :PBXTargetDependency,       "vendor/xcode/proxy/pbx_target_dependency"
       autoload :PBXVariantGroup,           "vendor/xcode/proxy/pbx_variant_group"
       autoload :PBXShellScriptBuildPhase,  "vendor/xcode/proxy/pbx_shell_script_build_phase"
+      autoload :PBXReferenceProxy,         "vendor/xcode/proxy/pbx_reference_proxy"
       autoload :XCBuildConfiguration,      "vendor/xcode/proxy/xc_build_configuration"
       autoload :XCConfigurationList,       "vendor/xcode/proxy/xc_configuration_list"
       autoload :XCVersionGroup,            "vendor/xcode/proxy/xc_version_group"

data/lib/vendor/xcode/proxy/pbx_frameworks_build_phase.rb

@@ -4,6 +4,12 @@ module Vendor::XCode::Proxy
 
     reference :files
 
+    private
+
+      def after_initialize
+        files.each { |child| child.parent = self }
+      end
+
   end
 
 end

data/lib/vendor/xcode/proxy/pbx_reference_proxy.rb

@@ -0,0 +1,7 @@
+module Vendor::XCode::Proxy
+
+  class PBXReferenceProxy < Vendor::XCode::Proxy::Base
+
+  end
+
+end

data/lib/vendor/xcode/proxy/pbx_resources_build_phase.rb

@@ -2,6 +2,14 @@ module Vendor::XCode::Proxy
 
   class PBXResourcesBuildPhase < Vendor::XCode::Proxy::Base
 
+    reference :files
+
+    private
+
+      def after_initialize
+        files.each { |child| child.parent = self }
+      end
+
   end
 
 end

data/lib/vendor/xcode/proxy/pbx_shell_script_build_phase.rb

@@ -2,6 +2,14 @@ module Vendor::XCode::Proxy
 
   class PBXShellScriptBuildPhase < Vendor::XCode::Proxy::Base
 
+    reference :files
+
+    private
+
+      def after_initialize
+        files.each { |child| child.parent = self }
+      end
+
   end
 
 end

data/lib/vendor/xcode/proxy/pbx_sources_build_phase.rb

@@ -4,6 +4,12 @@ module Vendor::XCode::Proxy
 
     reference :files
 
+    private
+
+      def after_initialize
+        files.each { |child| child.parent = self }
+      end
+
   end
 
 end

data/spec/lib/vendor/api_spec.rb

@@ -22,4 +22,58 @@ describe Vendor::API do
 
   end
 
+  context "#meta" do
+
+    it "should download information about the vendor in JSON format" do
+      json = Vendor::API.meta("DKBenchmark")
+
+      json["name"].should == "DKBenchmark"
+      json["description"].should == "Easy benchmarking in Objective-C using blocks"
+      json["release"].should == "0.2"
+      json["versions"].first[0].should == "0.3.alpha1"
+    end
+
+    it "should download information with vendors that had odd names" do
+      json = Vendor::API.meta("DKBenchmark!! With Some Crazy #Number Name!")
+
+      json["name"].should == "DKBenchmark!! With Some Crazy #Number Name!"
+    end
+
+    it "should raise an error if the server returns a non 200" do
+      expect do
+        Vendor::API.meta("WithAnError")
+      end.should raise_error(Vendor::API::Error, "Could not complete request. Server returned a status code of 500")
+    end
+
+    it "should raise an error if the vendor cannot be found" do
+      expect do
+        Vendor::API.meta("DoesNotExist")
+      end.should raise_error(Vendor::API::Error, "Could not find a valid vendor 'DoesNotExist'")
+    end
+
+  end
+
+  context "#download" do
+
+    it "should return a file with the downloaded contents" do
+      file = Vendor::API.download("DKBenchmark", "0.1")
+
+      file.should be_kind_of(File)
+      File.read(file.path).should == File.read(File.join(PACKAGED_VENDOR_PATH, "DKBenchmark-0.1.vendor"))
+    end
+
+    it "should raise an error if the server returns a non 200" do
+      expect do
+        Vendor::API.download("LibWithError", "0.1")
+      end.should raise_error(Vendor::API::Error, "Could not complete request. Server returned a status code of 500")
+    end
+
+    it "should raise an error if the vendor cannot be found" do
+      expect do
+        Vendor::API.download("DKBenchmark", "0.does.not.exist")
+      end.should raise_error(Vendor::API::Error, "Could not find a valid version for 'DKBenchmark' that matches '0.does.not.exist'")
+    end
+
+  end
+
 end

data/spec/lib/vendor/spec_spec.rb

@@ -0,0 +1,121 @@
+require 'spec_helper'
+
+describe Vendor::Spec do
+
+  let! (:spec) { Vendor::Spec.new }
+
+  context "#load" do
+
+    let(:spec_file) { File.join(VENDOR_RESOURCE_PATH, "DKBenchmark", "DKBenchmark.vendorspec") }
+
+    it "should return the loaded spec" do
+      Vendor::Spec.load(spec_file).should be_kind_of(Vendor::Spec)
+    end
+
+    it "should switch back in and out of the current directory using Dir.chdir while evaling the spec" do
+      current_dir = Dir.pwd
+      Dir.should_receive(:chdir).with(File.join(VENDOR_RESOURCE_PATH, "DKBenchmark")).ordered
+      Dir.should_receive(:chdir).with(current_dir).ordered
+
+      Vendor::Spec.load(spec_file).should be_kind_of(Vendor::Spec)
+    end
+
+  end
+
+  context '#validate' do
+
+    before :each do
+      spec.name = "Vendor"
+      spec.files = "Something"
+      spec.email = "foo@bar.com"
+      spec.version = "0.1"
+    end
+
+    it 'should thorw an error if no name is defined' do
+      expect do
+        spec.name = nil
+        spec.validate!
+      end.should raise_error("Specification is missing the `name` option")
+    end
+
+    it 'should thorw an error if no email is defined' do
+      expect do
+        spec.email = nil
+        spec.validate!
+      end.should raise_error("Specification is missing the `email` option")
+    end
+
+    it 'should thorw an error if no version is defined' do
+      expect do
+        spec.version = nil
+        spec.validate!
+      end.should raise_error("Specification is missing the `version` option")
+    end
+
+    it 'should thorw an error if no files are defined' do
+      expect do
+        spec.files = nil
+        spec.validate!
+      end.should raise_error("Specification is missing the `files` option")
+    end
+
+  end
+
+  context "#framework" do
+
+    it "should add the framework to the frameworks property" do
+      spec.framework "Foundation.framework"
+
+      spec.frameworks.should == [ "Foundation.framework" ]
+    end
+
+  end
+
+  context "#build_setting" do
+
+    it "should set a build setting" do
+      spec.build_setting "SOMETHING", "else"
+
+      spec.build_settings.should == [ [ "SOMETHING", "else" ] ]
+    end
+
+    it "should allow you to remap names with a symbol" do
+      spec.build_setting :other_linker_flags, "-ObjC"
+
+      spec.build_settings.should == [ [ "OTHER_LDFLAGS", "-ObjC" ] ]
+    end
+
+    it "should raise an error if a mapping for the symbol doesn't exist" do
+      expect do
+        spec.build_setting :blah, "-ObjC"
+      end.should raise_error(StandardError)
+    end
+
+    it "should turn the value to YES if you pass true" do
+      spec.build_setting :other_linker_flags, true
+      spec.build_setting :other_linker_flags, false
+
+      spec.build_settings.should == [ [ "OTHER_LDFLAGS", "YES" ], [ "OTHER_LDFLAGS", "NO" ] ]
+    end
+
+  end
+
+  context '#to_json' do
+
+    it 'should return the vendor spec as a JSON string' do
+      spec.name = "foo"
+      spec.framework "Foundation.framework"
+      spec.build_setting :other_linker_flags, true
+      spec.dependency "JSONKit", "0.5"
+
+      json = JSON.parse(spec.to_json)
+
+      json["name"].should == "foo"
+      json["dependencies"].should == [ [ "JSONKit", "0.5" ] ]
+      json["frameworks"].should == [ "Foundation.framework" ]
+      json["build_settings"].should == [ [ "OTHER_LDFLAGS", "YES" ] ]
+    end
+
+  end
+
+end

data/spec/lib/vendor/vendor_file/dependency_graph_spec.rb

@@ -0,0 +1,129 @@
+require 'spec_helper'
+
+describe Vendor::VendorFile::DependencyGraph do
+
+  let(:graph)             { Vendor::VendorFile::DependencyGraph.new }
+
+  let(:asihttprequest)    { Vendor::VendorFile::Library::Remote.new(:name => "ASIHTTPRequest", :version => "0.5") }
+  let(:dksupport)         { Vendor::VendorFile::Library::Local.new(:name => "DKSupport", :version => "0.2") }
+  let(:dkapirequest)      { Vendor::VendorFile::Library::Remote.new(:name => "DKAPIRequest", :version => "0.3") }
+  let(:dkcoredata)        { Vendor::VendorFile::Library::Remote.new(:name => "DKCoreData", :version => "~> 1.5") }
+  let(:dkcoredata_local)  { Vendor::VendorFile::Library::Local.new(:name => "DKCoreData", :version => "1.5.3") }
+  let(:dkrest)            { Vendor::VendorFile::Library::Remote.new(:name => "DKRest", :version => "~> 0.1") }
+  let(:versionless_git)   { Vendor::VendorFile::Library::Git.new(:name => "VersionlessGit") }
+  let(:versionless_local) { Vendor::VendorFile::Library::Local.new(:name => "VersionlessLocal") }
+
+  let(:dkbenchmark1)      { Vendor::VendorFile::Library::Remote.new(:name => "DKBenchmark", :version => "~> 0.1") }
+  let(:dkbenchmark2)      { Vendor::VendorFile::Library::Remote.new(:name => "DKBenchmark", :version => "<= 0.1") }
+  let(:dkbenchmark3)      { Vendor::VendorFile::Library::Remote.new(:name => "DKBenchmark", :version => "<= 0.0.1") }
+
+  before :each do
+    asihttprequest.parent = dkapirequest
+    asihttprequest.stub!(:dependencies).and_return([ dkapirequest, dkbenchmark1 ])
+    dksupport.stub!(:dependencies).and_return([ dkapirequest ])
+    dkapirequest.stub!(:dependencies).and_return([ asihttprequest, dkbenchmark2 ])
+    dkcoredata.stub!(:dependencies).and_return([ dksupport, dkbenchmark3 ])
+    dkrest.stub!(:dependencies).and_return([ dksupport, dkapirequest, dkcoredata ])
+    dkcoredata_local.stub!(:dependencies).and_return([ ])
+    versionless_git.stub!(:dependencies).and_return([ ])
+    versionless_local.stub!(:dependencies).and_return([ ])
+    dkbenchmark1.stub!(:dependencies).and_return([ ])
+    dkbenchmark2.stub!(:dependencies).and_return([ ])
+    dkbenchmark3.stub!(:dependencies).and_return([ ])
+  end
+
+  context 'with a valid graph' do
+
+    before :each do
+      graph.libraries = [ dkrest, versionless_local, versionless_git, dkcoredata_local ]
+    end
+
+    context "#version_conflicts?" do
+
+      it "should return false" do
+        graph.version_conflicts?.should be_false
+      end
+
+      it "should poplate the list libraries_to_install property" do
+        graph.libraries_to_install.should be_nil
+        graph.version_conflicts?
+
+        libraries_to_install = graph.libraries_to_install
+
+        libraries_to_install.first[0].name.should == "ASIHTTPRequest"
+        libraries_to_install.first[0].version.should == "0.5"
+        libraries_to_install.first[1].should == [ :all ]
+
+        all = libraries_to_install.map { |x| x[0].name }
+        all.should == ["ASIHTTPRequest", "DKAPIRequest", "DKBenchmark", "DKCoreData", "DKRest", "DKSupport", "VersionlessGit", "VersionlessLocal"]
+      end
+
+    end
+
+    context "#dependency_graph" do
+
+      before :each do
+        @graph, @map = graph.dependency_graph
+      end
+
+      it "should return a graph" do
+        @graph.should == [
+          ["DKRest ~> 0.1", [
+            ["DKSupport 0.2", [
+              ["DKAPIRequest 0.3", [
+                ["ASIHTTPRequest 0.5", [
+                    ["DKBenchmark ~> 0.1", []]
+                  ]
+                ],
+                ["DKBenchmark <= 0.1", []]
+              ]]
+            ]],
+            ["DKCoreData ~> 1.5", [
+              ["DKBenchmark <= 0.0.1", []]
+            ]]
+          ]],
+          ["VersionlessLocal", []],
+          ["VersionlessGit", []],
+          ["DKCoreData 1.5.3", []],
+        ]
+      end
+
+      it "should return a map" do
+        @map.keys.sort.should == ["ASIHTTPRequest", "DKAPIRequest", "DKBenchmark", "DKCoreData", "DKRest", "DKSupport", "VersionlessGit", "VersionlessLocal"]
+      end
+
+      it "should return each version present in the map" do
+        @map["ASIHTTPRequest"].map(&:version).should == [ "0.5" ]
+        @map["DKAPIRequest"].map(&:version).should == [ "0.3" ]
+        @map["DKCoreData"].map(&:version).should == [ "1.5", "1.5.3" ]
+        @map["DKRest"].map(&:version).should == [ "0.1" ]
+        @map["DKSupport"].map(&:version).should == [ "0.2" ]
+      end
+
+    end
+
+  end
+
+  context 'with an invalid graph' do
+
+    let(:new_asihttprequest)  { Vendor::VendorFile::Library::Remote.new(:name => "ASIHTTPRequest", :version => "0.6") }
+
+    before :each do
+      new_asihttprequest.stub!(:dependencies).and_return([ dkapirequest ])
+
+      graph.libraries = [ dkrest, new_asihttprequest ]
+    end
+
+    it "should raise an error and exit" do
+      Vendor.ui.should_receive(:error).with("Multiple versions detected for ASIHTTPRequest (0.6, 0.5)").once.ordered
+      Vendor.ui.should_receive(:error).with("  ASIHTTPRequest 0.5 is required by DKAPIRequest 0.3").once.ordered
+      Vendor.ui.should_receive(:error).with("  ASIHTTPRequest 0.6 is required in the Vendorfile").once.ordered
+
+      expect do
+        graph.version_conflicts?
+      end.should raise_error(SystemExit)
+    end
+
+  end
+
+end

data/spec/lib/vendor/vendor_file/library/base_spec.rb

@@ -2,14 +2,15 @@ require 'spec_helper'
 
 describe Vendor::VendorFile::Library::Base do
 
-  let(:lib) { Vendor::VendorFile::Library::Base.new(:name => "ExampleLib") }
+  let(:temp_path) { TempProject.create(File.join(PROJECT_RESOURCE_PATH, "MultipleTargets")) }
+  let(:project) { Vendor::XCode::Project.new(File.join(temp_path, "MultipleTargets.xcodeproj")) }
 
-  let(:temp_path) { TempProject.create(File.join(PROJECT_RESOURCE_PATH, "UtilityApplication")) }
-  let(:project) { Vendor::XCode::Project.new(File.join(temp_path, "UtilityApplication.xcodeproj")) }
+  let(:lib) { Vendor::VendorFile::Library::Base.new(:name => "ExampleLib") }
 
-  let(:lib_with_no_manifest_or_vendorspec) { Vendor::VendorFile::Library::Base.new(:name => "BingMapsIOS", :require => "MapControl") }
-  let(:lib_with_manifest) { Vendor::VendorFile::Library::Base.new(:name => "DKBenchmark-Manifest") }
-  let(:lib_with_vendorspec) { Vendor::VendorFile::Library::Base.new(:name => "DKBenchmark-Vendorspec") }
+  let(:lib_with_no_manifest_or_vendorspec) { Vendor::VendorFile::Library::Base.new(:name => "BingMapsIOS", :require => "MapControl", :target => "MultipleTargets") }
+  let(:lib_with_manifest) { Vendor::VendorFile::Library::Base.new(:name => "DKBenchmark-0.1-Manifest", :targets => [ "MultipleTargets", "Specs" ]) }
+  let(:lib_with_vendorspec) { Vendor::VendorFile::Library::Base.new(:name => "DKBenchmark-0.1-Vendorspec", :target => "MultipleTargets") }
+  let(:lib_with_nothing) { Vendor::VendorFile::Library::Base.new(:name => "DKBenchmark-0.1-Nothing", :target => "MultipleTargets") }
 
   it "should have a name attribute" do
     lib.name = "lib"
@@ -27,24 +28,24 @@ describe Vendor::VendorFile::Library::Base do
 
     before :each do
       Vendor.stub(:library_path).and_return CACHED_VENDOR_RESOURCE_PATH
-
-      lib_with_manifest.install project
     end
 
     context "with an existing installation" do
 
       before :each do
+        lib_with_manifest.install project
+
         # Install it again
         lib_with_manifest.install project
       end
 
       it "should add the group to the project" do
-        group = project.find_group("Vendor/DKBenchmark-Manifest")
+        group = project.find_group("Vendor/DKBenchmark-0.1-Manifest")
         group.should_not be_nil
       end
 
       it "should add the files to the project" do
-        children = project.find_group("Vendor/DKBenchmark-Manifest").children
+        children = project.find_group("Vendor/DKBenchmark-0.1-Manifest").children
         children.length.should == 2
       end
 
@@ -52,13 +53,18 @@ describe Vendor::VendorFile::Library::Base do
 
     context "with a fresh installation" do
 
+      before :each do
+        # Install it again
+        lib_with_manifest.install project
+      end
+
       it "should add the group to the project" do
-        group = project.find_group("Vendor/DKBenchmark-Manifest")
+        group = project.find_group("Vendor/DKBenchmark-0.1-Manifest")
         group.should_not be_nil
       end
 
       it "should add the files to the project" do
-        children = project.find_group("Vendor/DKBenchmark-Manifest").children
+        children = project.find_group("Vendor/DKBenchmark-0.1-Manifest").children
         children.length.should == 2
       end
 
@@ -74,6 +80,160 @@ describe Vendor::VendorFile::Library::Base do
 
   end
 
+  describe "#dependencies" do
+
+    before :each do
+      Vendor.stub(:library_path).and_return CACHED_VENDOR_RESOURCE_PATH
+    end
+
+    context "with no manifest or vendorspec" do
+
+      it "should return no dependencies" do
+        lib_with_no_manifest_or_vendorspec.dependencies.should be_empty
+      end
+
+    end
+
+    context "with a vendorspec" do
+
+      let(:dependencies) { lib_with_vendorspec.dependencies }
+
+      it "should return the correct dependencies" do
+        dependencies[0].name.should == "JSONKit"
+        dependencies[0].version.should == "0.5"
+        dependencies[0].parent.should == lib_with_vendorspec
+        dependencies[0].targets.should == [ "MultipleTargets" ]
+
+        dependencies[1].name.should == "ASIHTTPRequest"
+        dependencies[1].equality.should == "~>"
+        dependencies[1].version.should == "4.2"
+        dependencies[1].targets.should == [ "MultipleTargets" ]
+
+        dependencies[2].name.should == "AFINetworking"
+        dependencies[2].equality.should == "<="
+        dependencies[2].version.should == "2.5.a"
+        dependencies[2].parent.should == lib_with_vendorspec
+        dependencies[2].targets.should == [ "MultipleTargets" ]
+      end
+
+    end
+
+    context "with a manifest" do
+
+      let(:dependencies) { lib_with_manifest.dependencies }
+
+      it "should return the correct dependencies" do
+        dependencies[0].name.should == "JSONKit"
+        dependencies[0].version.should == "0.3"
+        dependencies[0].parent.should == lib_with_manifest
+        dependencies[0].targets.should == [ "MultipleTargets", "Specs" ]
+
+        dependencies[1].name.should == "ASIHTTPRequest"
+        dependencies[1].equality.should == "~>"
+        dependencies[1].version.should == "4.3"
+        dependencies[1].parent.should == lib_with_manifest
+        dependencies[1].targets.should == [ "MultipleTargets", "Specs" ]
+
+        dependencies[2].name.should == "AFINetworking"
+        dependencies[2].equality.should == "<="
+        dependencies[2].version.should == "2.5.b"
+        dependencies[2].parent.should == lib_with_manifest
+        dependencies[2].targets.should == [ "MultipleTargets", "Specs" ]
+
+      end
+
+    end
+
+    context "with no dependencies" do
+
+      it "should return an empty array" do
+        lib_with_nothing.dependencies.should == []
+      end
+
+    end
+
+  end
+
+  describe "#frameworks" do
+
+    before :each do
+      Vendor.stub(:library_path).and_return CACHED_VENDOR_RESOURCE_PATH
+    end
+
+    context "with no manifest or vendorspec" do
+
+      it "should have no frameworks" do
+        lib_with_no_manifest_or_vendorspec.frameworks.should be_empty
+      end
+
+    end
+
+    context "with a vendorspec" do
+
+      it "should have frameworks" do
+        lib_with_vendorspec.frameworks.should == [ "Foundation.framework" ]
+      end
+
+    end
+
+    context "with a manifest" do
+
+      it "should have frameworks" do
+        lib_with_manifest.frameworks.should == [ "CoreData.framework" ]
+      end
+
+    end
+
+    context "with no frameworks" do
+
+      it "should return an empty array" do
+        lib_with_nothing.frameworks.should == []
+      end
+
+    end
+
+  end
+
+  describe "#build_settings" do
+
+    before :each do
+      Vendor.stub(:library_path).and_return CACHED_VENDOR_RESOURCE_PATH
+    end
+
+    context "with no manifest or vendorspec" do
+
+      it "should have no build_settings" do
+        lib_with_no_manifest_or_vendorspec.build_settings.should be_empty
+      end
+
+    end
+
+    context "with a vendorspec" do
+
+      it "should have build_settings" do
+        lib_with_vendorspec.build_settings.should == [ [ "OTHER_LDFLAGS", "-ObjC" ] ]
+      end
+
+    end
+
+    context "with a manifest" do
+
+      it "should have build_settings" do
+        lib_with_manifest.build_settings.should == [ [ "CLANG_WARN_OBJCPP_ARC_ABI", "NO" ] ]
+      end
+
+    end
+
+    context "with no build settings" do
+
+      it "should return an empty array" do
+        lib_with_nothing.build_settings.should == []
+      end
+
+    end
+
+  end
+
   describe "#files" do
 
     before :each do
@@ -124,7 +284,7 @@ describe Vendor::VendorFile::Library::Base do
       end
 
       it "should return files in the correct location" do
-        path = File.join(CACHED_VENDOR_RESOURCE_PATH, "base/DKBenchmark-Vendorspec/")
+        path = File.join(CACHED_VENDOR_RESOURCE_PATH, "base/DKBenchmark-0.1-Vendorspec/")
         regex_path = /^#{path}.+$/
 
         files.each do |file|
@@ -152,7 +312,7 @@ describe Vendor::VendorFile::Library::Base do
       end
 
       it "should return files in the correct location" do
-        path = File.join(CACHED_VENDOR_RESOURCE_PATH, "base/DKBenchmark-Manifest/data/")
+        path = File.join(CACHED_VENDOR_RESOURCE_PATH, "base/DKBenchmark-0.1-Manifest/data/")
         regex_path = /^#{path}.+$/
 
         files.each do |file|