vagrant-proxmox 0.0.3 → 0.0.5

data/spec/actions/sync_folders_action_spec.rb

@@ -8,27 +8,27 @@ module VagrantPlugins::Proxmox
 		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
 		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox), ui: double('ui').as_null_object} }
 
-		subject { described_class.new(-> (_) {}, environment) }
+		subject(:action) { described_class.new(-> (_) {}, environment) }
 
 		describe '#call' do
 
 			before do
-				env[:machine].stub(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: 'key'} }
-				env[:machine].communicate.stub :sudo
-				Vagrant::Util::Subprocess.stub(:execute).and_return Vagrant::Util::Subprocess::Result.new 0, nil, nil
+				allow(env[:machine]).to receive(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: ['key']} }
+				allow(env[:machine].communicate).to receive :sudo
+				allow(Vagrant::Util::Subprocess).to receive_messages :execute => Vagrant::Util::Subprocess::Result.new(0, nil, nil)
 			end
 
 			it_behaves_like 'a proxmox action call'
 
 			it 'should print a message to the user interface' do
 				expect(env[:ui]).to receive(:info).with("Rsyncing folder: #{Dir.pwd}/ => /vagrant")
-				subject.call env
+				action.call env
 			end
 
 			it 'should create a directory on the vm with the predefined ownership' do
 				expect(env[:machine].communicate).to receive(:sudo).with("mkdir -p '/vagrant'")
 				expect(env[:machine].communicate).to receive(:sudo).with("chown vagrant '/vagrant'")
-				subject.call env
+				action.call env
 			end
 
 			it 'should rsync the directory with the vm' do
@@ -36,12 +36,12 @@ module VagrantPlugins::Proxmox
 																								 'rsync', '--verbose', '--archive', '--compress', '--delete',
 																								 '-e', "ssh -p 22 -i 'key' -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null",
 																								 "#{Dir.pwd}/", 'vagrant@127.0.0.1:/vagrant')
-				subject.call env
+				action.call env
 			end
 
 			it 'should raise an error if the rsync fails' do
-				allow(Vagrant::Util::Subprocess).to receive(:execute).and_return(Vagrant::Util::Subprocess::Result.new 1, nil, nil)
-				expect { subject.call(env) }.to raise_error Errors::RsyncError
+				allow(Vagrant::Util::Subprocess).to receive_messages :execute  => Vagrant::Util::Subprocess::Result.new(1, nil, nil)
+				expect { action.call(env) }.to raise_error Errors::RsyncError
 			end
 
 		end

data/spec/actions/upload_iso_file_action_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'actions/proxmox_action_shared'
+
+module VagrantPlugins::Proxmox
+
+	describe Action::UploadIsoFile do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile_qemu' }
+		let(:connection) { Connection.new 'https://your.proxmox.server/api2/json' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox),
+								 proxmox_connection: connection, proxmox_selected_node: node} }
+		let(:iso_file) { 'some_iso.iso' }
+		let(:iso_file_exists) { true }
+		let(:node) { 'node1' }
+
+		subject(:action) { described_class.new(-> (_) {}, environment) }
+
+		before do
+			env[:machine].provider_config.qemu_iso_file = iso_file
+			allow(File).to receive(:exist?).with(iso_file).and_return(iso_file_exists)
+		end
+
+		context 'with a specified iso file' do
+
+			it 'should upload the iso file into the local storage of the selected node' do
+				expect(connection).to receive(:upload_file).with(iso_file, content_type: 'iso', node: node, storage: 'local')
+				action.call env
+			end
+		end
+
+		it 'should return :ok after a successful upload' do
+			allow(connection).to receive(:upload_file).with(iso_file, content_type: 'iso', node: node, storage: 'local')
+			action.call env
+			expect(env[:result]).to eq(:ok)
+		end
+
+		context 'when a server error occurs' do
+
+			before do
+				allow(connection).to receive(:upload_file).and_raise ApiError::ServerError
+			end
+
+			it 'should return :server_error' do
+				action.call env
+				expect(env[:result]).to eq(:server_upload_error)
+			end
+		end
+
+		context 'without a specified iso file' do
+
+			let(:iso_file) { nil }
+
+			it 'does nothing and returns OK' do
+				expect(connection).not_to receive(:upload_file)
+				action.call env
+				expect(env[:result]).to eq(:ok)
+			end
+		end
+
+		context 'the specified iso file does not exist' do
+
+			let (:iso_file_exists) { false }
+
+			it 'should return :file_not_found' do
+				action.call env
+				expect(env[:result]).to eq(:file_not_found)
+			end
+		end
+	end
+end

data/spec/actions/upload_template_file_action_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'actions/proxmox_action_shared'
+
+module VagrantPlugins::Proxmox
+
+	describe Action::UploadTemplateFile do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:connection) { Connection.new 'https://your.proxmox.server/api2/json' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox),
+								 proxmox_connection: connection, proxmox_selected_node: node} }
+		let(:template_file) { 'template.tar.gz' }
+		let(:template_file_exists) { true }
+		let(:node) { 'node1' }
+
+		subject(:action) { described_class.new(-> (_) {}, environment) }
+
+		before do
+			env[:machine].provider_config.openvz_template_file = template_file
+			allow(File).to receive(:exist?).with(template_file).and_return(template_file_exists)
+		end
+
+		context 'with a specified template file' do
+
+			it 'should upload the template file into the local storage of the selected node' do
+				expect(connection).to receive(:upload_file).with(template_file, content_type: 'vztmpl', node: node, storage: 'local')
+				action.call env
+			end
+		end
+
+		it 'should return :ok after a successful upload' do
+			allow(connection).to receive(:upload_file).with(template_file, content_type: 'vztmpl', node: node, storage: 'local')
+			action.call env
+			expect(env[:result]).to eq(:ok)
+		end
+
+		context 'when a server error occurs' do
+
+			before do
+				allow(connection).to receive(:upload_file).and_raise ApiError::ServerError
+			end
+
+			it 'should return :server_error' do
+				action.call env
+				expect(env[:result]).to eq(:server_upload_error)
+			end
+		end
+
+		context 'without a specified template file' do
+
+			let(:template_file) { nil }
+
+			it 'does nothing and returns OK' do
+				expect(connection).not_to receive(:upload_file)
+				action.call env
+				expect(env[:result]).to eq(:ok)
+			end
+		end
+
+		context 'the specified template file does not exist' do
+
+			let (:template_file_exists) { false }
+
+			it 'should return :file_not_found' do
+				action.call env
+				expect(env[:result]).to eq(:file_not_found)
+			end
+		end
+	end
+end

data/spec/commands/destroy_command_spec.rb

@@ -10,10 +10,10 @@ module VagrantPlugins::Proxmox
 
 		context 'the vm is not created on the proxmox server' do
 			it 'should call the appropriate actions to print a ui message that the vm is not created' do
-				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
-				Action::IsCreated.should be_called { |env| env[:result] = false }
-				Action::MessageNotCreated.should be_called
-				Action::DestroyVm.should be_ommited
+				expect(Action::ConnectProxmox).to be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = false }
+				expect(Action::MessageNotCreated).to be_called
+				expect(Action::DestroyVm).to be_omitted
 				execute_vagrant_command environment, :destroy
 			end
 		end
@@ -22,11 +22,11 @@ module VagrantPlugins::Proxmox
 
 			context 'the destroy command is not confirmed' do
 				it 'should call the appropriate actions to print a ui message that the vm will not be destroyed' do
-					Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
-					Action::IsCreated.should be_called { |env| env[:result] = true }
-					::Vagrant::Action::Builtin::DestroyConfirm.should be_called { |env| env[:result] = false }
-					::VagrantPlugins::ProviderVirtualBox::Action::MessageWillNotDestroy.should be_called
-					Action::DestroyVm.should be_ommited
+					expect(Action::ConnectProxmox).to be_called
+					expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+					expect(::Vagrant::Action::Builtin::DestroyConfirm).to be_called { |env| env[:result] = false }
+					expect(::VagrantPlugins::ProviderVirtualBox::Action::MessageWillNotDestroy).to be_called
+					expect(Action::DestroyVm).to be_omitted
 					execute_vagrant_command environment, :destroy
 				end
 			end
@@ -34,28 +34,28 @@ module VagrantPlugins::Proxmox
 			context 'the destroy command is confirmed' do
 				context 'the vm is running' do
 					it 'should call the appropriate actions to destroy the vm' do
-						Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
-						Action::IsCreated.should be_called { |env| env[:result] = true }
-						::Vagrant::Action::Builtin::DestroyConfirm.should be_called { |env| env[:result] = true }
-						Action::IsStopped.should be_called { |env| env[:result] = false }
-						Action::ShutdownVm.should be_called
-						Action::DestroyVm.should be_called
-						::Vagrant::Action::Builtin::ProvisionerCleanup.should be_called
-						Action::CleanupAfterDestroy.should be_called
+						expect(Action::ConnectProxmox).to be_called
+						expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+						expect(::Vagrant::Action::Builtin::DestroyConfirm).to be_called { |env| env[:result] = true }
+						expect(Action::IsStopped).to be_called { |env| env[:result] = false }
+						expect(Action::ShutdownVm).to be_called
+						expect(Action::DestroyVm).to be_called
+						expect(::Vagrant::Action::Builtin::ProvisionerCleanup).to be_called
+						expect(Action::CleanupAfterDestroy).to be_called
 						execute_vagrant_command environment, :destroy
 					end
 				end
 
 				context 'the vm is stopped' do
 					it 'should call the appropriate actions to destroy the vm' do
-						Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
-						Action::IsCreated.should be_called { |env| env[:result] = true }
-						Action::DestroyConfirm.should be_called { |env| env[:result] = true }
-						Action::IsStopped.should be_called { |env| env[:result] = true }
-						Action::DestroyVm.should be_called
-						::Vagrant::Action::Builtin::ProvisionerCleanup.should be_called
-						Action::CleanupAfterDestroy.should be_called
-						Action::ShutdownVm.should be_ommited
+						expect(Action::ConnectProxmox).to be_called
+						expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+						expect(Action::DestroyConfirm).to be_called { |env| env[:result] = true }
+						expect(Action::IsStopped).to be_called { |env| env[:result] = true }
+						expect(Action::DestroyVm).to be_called
+						expect(::Vagrant::Action::Builtin::ProvisionerCleanup).to be_called
+						expect(Action::CleanupAfterDestroy).to be_called
+						expect(Action::ShutdownVm).to be_omitted
 						execute_vagrant_command environment, :destroy
 					end
 				end

data/spec/commands/halt_command_spec.rb

@@ -9,34 +9,34 @@ module VagrantPlugins::Proxmox
 
 		context 'the vm is not created on the proxmox server' do
 			it 'should call the appropriate actions and print a ui message that the vm is not created' do
-				Action::ConfigValidate.should be_called
-				Action::IsCreated.should be_called { |env| env[:result] = false }
-				Action::MessageNotCreated.should be_called
-				Action::ConnectProxmox.should be_ommited
-				Action::ShutdownVm.should be_ommited
+				expect(Action::ConfigValidate).to be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = false }
+				expect(Action::MessageNotCreated).to be_called
+				expect(Action::ConnectProxmox).to be_omitted
+				expect(Action::ShutdownVm).to be_omitted
 				execute_vagrant_command environment, :halt
 			end
 		end
 
 		context 'the vm is stopped' do
-			it 'should call the appropriate actions to shut down the vm' do
-				Action::ConfigValidate.should be_called
-				Action::IsCreated.should be_called { |env| env[:result] = true }
-				Action::IsStopped.should be_called { |env| env[:result] = true }
-				Action::MessageAlreadyStopped.should be_called
-				Action::ConnectProxmox.should be_ommited
-				Action::ShutdownVm.should be_ommited
+			it 'should not shut down the vm and print a vm message that the vm is already stopped' do
+				expect(Action::ConfigValidate).to be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = true }
+				expect(Action::MessageAlreadyStopped).to be_called
+				expect(Action::ConnectProxmox).to be_omitted
+				expect(Action::ShutdownVm).to be_omitted
 				execute_vagrant_command environment, :halt
 			end
 		end
 
 		context 'the vm is running' do
 			it 'should call the appropriate actions to shut down the vm' do
-				Action::ConfigValidate.should be_called
-				Action::IsCreated.should be_called { |env| env[:result] = true }
-				Action::IsStopped.should be_called { |env| env[:result] = false }
-				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
-				Action::ShutdownVm.should be_called
+				expect(Action::ConfigValidate).to be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = false }
+				expect(Action::ConnectProxmox).to be_called
+				expect(Action::ShutdownVm).to be_called
 				execute_vagrant_command environment, :halt
 			end
 		end

data/spec/commands/provision_command_spec.rb

@@ -9,25 +9,38 @@ module VagrantPlugins::Proxmox
 
 		context 'the vm is not created on the proxmox server' do
 			it 'should call the appropriate actions and print a ui message that the vm is not created' do
-				Action::ConfigValidate.should be_called
-				Action::IsCreated.should be_called { |env| env[:result] = false }
-				Action::MessageNotCreated.should be_called
-				Action::Provision.should be_ommited
-				Action::SyncFolders.should be_ommited
+				expect(Action::ConfigValidate).to be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = false }
+				expect(Action::MessageNotCreated).to be_called
+				expect(Action::Provision).to be_omitted
+				expect(Action::SyncFolders).to be_omitted
 				execute_vagrant_command environment, :provision
 			end
 		end
 
 		context 'the vm exists on the proxmox server' do
 			it 'should call the appropriate actions and provision the vm' do
-				Action::ConfigValidate.should be_called
-				Action::IsCreated.should be_called { |env| env[:result] = true }
-				Action::Provision.should be_called
-				Action::SyncFolders.should be_called
+				expect(Action::ConfigValidate).to be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = false }
+				expect(Action::Provision).to be_called
+				expect(Action::SyncFolders).to be_called
 				execute_vagrant_command environment, :provision
 			end
 		end
 
+		context 'the vm exists on the proxmox server but is not running' do
+
+			it 'should state that the machine is not currently running' do
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = true }
+				expect(Action::MessageNotRunning).to be_called
+				expect(Action::Provision).to be_omitted
+				execute_vagrant_command environment, :provision
+			end
+
+		end
+
 	end
 
 end

data/spec/commands/ssh_command_spec.rb

@@ -9,9 +9,9 @@ module VagrantPlugins::Proxmox
 
 		context 'the vm is not created on the proxmox server' do
 			it 'should call the appropriate actions and print a ui message that the vm is not created' do
-				Action::IsCreated.should be_called { |env| env[:result] = false }
-				Action::MessageNotCreated.should be_called
-				Action::SSHExec.should be_ommited
+				expect(Action::IsCreated).to be_called { |env| env[:result] = false }
+				expect(Action::MessageNotCreated).to be_called
+				expect(Action::SSHExec).to be_omitted
 				execute_vagrant_command environment, :ssh
 			end
 		end
@@ -19,8 +19,21 @@ module VagrantPlugins::Proxmox
 		context 'the vm exists on the proxmox server' do
 
 			it 'should call the appropriate actions to open a ssh connection' do
-				Action::IsCreated.should be_called { |env| env[:result] = true }
-				Action::SSHExec.should be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = false }
+				expect(Action::SSHExec).to be_called
+				execute_vagrant_command environment, :ssh
+			end
+
+		end
+
+		context 'the vm exists on the proxmox server but is not running' do
+
+			it 'should state that the machine is not currently running' do
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = true }
+				expect(Action::MessageNotRunning).to be_called
+				expect(Action::SSHExec).to be_omitted
 				execute_vagrant_command environment, :ssh
 			end
 

data/spec/commands/ssh_run_command_spec.rb

@@ -10,19 +10,32 @@ module VagrantPlugins::Proxmox
 
 		context 'the vm is not created on the proxmox server' do
 			it 'should call the appropriate actions and print a ui message that the vm is not created' do
-				Action::IsCreated.should be_called { |env| env[:result] = false }
-				Action::MessageNotCreated.should be_called
-				Action::SSHRun.should be_ommited
+				expect(Action::IsCreated).to be_called { |env| env[:result] = false }
+				expect(Action::MessageNotCreated).to be_called
+				expect(Action::SSHRun).to be_omitted
 				execute_vagrant_command environment, :ssh, '--command', 'foo'
 			end
 		end
 
 		context 'the vm exists on the proxmox server' do
-			before { env[:machine].stub(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: 'key'} } }
+			before { allow(env[:machine]).to receive(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: 'key'} } }
 
 			it 'should call the appropriate actions to execute a command via ssh on the vm' do
-				Action::IsCreated.should be_called { |env| env[:result] = true }
-				Action::SSHRun.should be_called
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = false }
+				expect(Action::SSHRun).to be_called
+				execute_vagrant_command environment, :ssh, '--command', 'foo'
+			end
+		end
+
+		context 'the vm exists on the proxmox server and is not running' do
+			before { allow(env[:machine]).to receive(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: 'key'} } }
+
+			it 'should call the appropriate actions to execute a command via ssh on the vm' do
+				expect(Action::IsCreated).to be_called { |env| env[:result] = true }
+				expect(Action::IsStopped).to be_called { |env| env[:result] = true }
+				expect(Action::MessageNotRunning).to be_called
+				expect(Action::SSHRun).to be_omitted
 				execute_vagrant_command environment, :ssh, '--command', 'foo'
 			end
 		end