vagrant-proxmox 0.0.3 → 0.0.5

data/spec/actions/destroy_vm_action_spec.rb

@@ -1,37 +1,64 @@
 require 'spec_helper'
 require 'actions/proxmox_action_shared'
 
-describe VagrantPlugins::Proxmox::Action::DestroyVm do
+module VagrantPlugins::Proxmox
 
-	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
-	let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox),
-							 proxmox_nodes: [{node: 'localhost'}],
-							 ui: double('ui').as_null_object} }
+	describe Action::DestroyVm do
 
-	subject { described_class.new(-> (_) {}, environment) }
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:connection) { Connection.new 'https://proxmox.example.com/api2/json' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox),
+								 ui: double('ui').as_null_object,
+								 proxmox_connection: connection} }
 
-	describe '#call' do
+		subject(:action) { described_class.new(-> (_) {}, environment) }
 
-		before do
-			env[:machine].id = 'localhost/100'
-			allow(RestClient).to receive(:delete).and_return({data: 'task_id'}.to_json)
-			allow(RestClient).to receive(:get).and_return({data: {exitstatus: 'OK'}}.to_json)
-		end
+		describe '#call' do
 
-		it_behaves_like 'a proxmox action call'
-		it_behaves_like 'a blocking proxmox action'
+			before do
+				env[:machine].id = 'localhost/100'
+				allow(connection).to receive_messages :delete_vm => 'OK'
+			end
 
-		it 'should send a post request that deletes the openvz container' do
-			RestClient.should_receive(:delete).with('https://your.proxmox.server/api2/json/nodes/localhost/openvz/100', anything)
-			subject.call env
-		end
+			it_behaves_like 'a proxmox action call'
+
+			it 'should call the delete_vm function of connection' do
+				expect(connection).to receive(:delete_vm).with '100'
+				action.call env
+			end
+
+			it 'should print a message to the user interface' do
+				expect(env[:ui]).to receive(:info).with 'Destroying the virtual machine...'
+				expect(env[:ui]).to receive(:info).with 'Done!'
+				action.call env
+			end
+
+			context 'when the proxmox server responds with an error to the destroy request' do
+
+				context 'when the proxmox server replies with an internal server error to the destroy request' do
+					it 'should raise a VMDestroyError' do
+						allow(connection).to receive(:delete_vm).and_raise ApiError::ServerError
+						expect { action.send :call, env }.to raise_error Errors::VMDestroyError
+					end
+				end
+
+				context 'when the proxmox server replies with an internal server error to the task status request' do
+					it 'should raise a VMDestroyError' do
+						allow(connection).to receive(:delete_vm).and_raise ApiError::ServerError
+						expect { action.send :call, env }.to raise_error Errors::VMDestroyError
+					end
+				end
+
+				context 'when the proxmox server does not reply the task status request with OK' do
+					it 'should raise a VMDestroyError' do
+						allow(connection).to receive_messages :delete_vm => 'destroy vm error'
+						expect { action.send :call, env }.to raise_error Errors::VMDestroyError, /destroy vm error/
+					end
+				end
+
+			end
 
-		it 'should print a message to the user interface' do
-			env[:ui].should_receive(:info).with 'Destroying the virtual machine...'
-			env[:ui].should_receive(:info).with 'Done!'
-			subject.call env
 		end
 
 	end
-
 end

data/spec/actions/get_node_list_action_spec.rb

@@ -1,25 +1,38 @@
 require 'spec_helper'
 require 'actions/proxmox_action_shared'
 
-describe VagrantPlugins::Proxmox::Action::GetNodeList do
+module VagrantPlugins::Proxmox
 
-	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
-	let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox)} }
+	describe Action::GetNodeList do
 
-	subject { described_class.new(-> (_) {}, environment) }
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:connection) { Connection.new 'https://proxmox.example.com/api2/json' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox), proxmox_connection: connection} }
 
-	describe '#call' do
+		subject(:action) { described_class.new(-> (_) {}, environment) }
 
-		before {allow(RestClient).to receive(:get).and_return({data: [{node: 'localhost'}]}.to_json)}
+		describe '#call' do
 
-		it_behaves_like 'a proxmox action call'
+			describe 'proxmox action call' do
+				before { allow(connection).to receive_messages get_node_list: [] }
+				it_behaves_like 'a proxmox action call'
+			end
+
+			it 'should store the node list in env[:proxmox_nodes]' do
+				expect(connection).to receive(:get_node_list).and_return ['node1', 'node2']
+				action.call env
+				expect(env[:proxmox_nodes]).to eq(['node1', 'node2'])
+			end
+
+			context 'when the server communication fails' do
+				before { allow(connection).to receive(:get_node_list).and_raise ApiError::ConnectionError }
+				it 'should raise an error' do
+					expect { action.call env }.to raise_error Errors::CommunicationError
+				end
+			end
 
-		it 'should store the node list in env[:proxmox_nodes]' do
-			RestClient.should_receive(:get).with('https://your.proxmox.server/api2/json/nodes', anything)
-			subject.call env
-			env[:proxmox_nodes].should == [{node: 'localhost'}]
 		end
 
 	end
 
-end
+end

data/spec/actions/is_created_action_spec.rb

@@ -6,28 +6,28 @@ describe VagrantPlugins::Proxmox::Action::IsCreated do
 	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
 	let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox)} }
 
-	subject { described_class.new(-> (_) {}, environment) }
+	subject(:action) { described_class.new(-> (_) {}, environment) }
 
 	describe '#call' do
 
-		before{allow(env[:machine].provider).to receive(:state).and_return(Vagrant::MachineState.new nil, nil, nil)}
+		before { allow(env[:machine].provider).to receive_messages :state => Vagrant::MachineState.new(nil, nil, nil) }
 
 		it_behaves_like 'a proxmox action call'
 
 		context 'when the machine is stopped' do
 			before do
-				allow(env[:machine].provider).to receive(:state).and_return(Vagrant::MachineState.new :stopped, '', '')
-				subject.call env
+				allow(env[:machine].provider).to receive_messages :state  => Vagrant::MachineState.new(:stopped, '', '')
+				action.call env
 			end
-			specify { env[:result].should == true }
+			specify { expect(env[:result]).to eq(true) }
 		end
 
 		context 'when the machine is not created' do
 			before do
-				allow(env[:machine].provider).to receive(:state).and_return(Vagrant::MachineState.new :not_created, '', '')
-				subject.call env
+				allow(env[:machine].provider).to receive_messages  :state => Vagrant::MachineState.new(:not_created, '', '')
+				action.call env
 			end
-			specify { env[:result].should == false }
+			specify { expect(env[:result]).to eq(false) }
 		end
 
 	end

data/spec/actions/is_stopped_action_spec.rb

@@ -6,28 +6,28 @@ describe VagrantPlugins::Proxmox::Action::IsStopped do
 	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
 	let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox)} }
 
-	subject { described_class.new(-> (_) {}, environment) }
+	subject(:action) { described_class.new(-> (_) {}, environment) }
 
 	describe '#call' do
 
-		before { allow(env[:machine].provider).to receive(:state).and_return(Vagrant::MachineState.new nil, nil, nil) }
+		before { allow(env[:machine].provider).to receive_messages :state => Vagrant::MachineState.new(nil, nil, nil) }
 
 		it_behaves_like 'a proxmox action call'
 
 		context 'when the machine is stopped' do
 			before do
-				allow(env[:machine].provider).to receive(:state).and_return(Vagrant::MachineState.new :stopped, '', '')
-				subject.call env
+				allow(env[:machine].provider).to receive_messages :state => Vagrant::MachineState.new(:stopped, '', '')
+				action.call env
 			end
-			specify { env[:result].should == true }
+			specify { expect(env[:result]).to eq(true) }
 		end
 
 		context 'when the machine is running' do
 			before do
-				allow(env[:machine].provider).to receive(:state).and_return(Vagrant::MachineState.new :running, '', '')
-				subject.call env
+				allow(env[:machine].provider).to receive_messages :state => Vagrant::MachineState.new(:running, '', '')
+				action.call env
 			end
-			specify { env[:result].should == false }
+			specify { expect(env[:result]).to eq(false) }
 		end
 	end
 

data/spec/actions/message_already_running_action_spec.rb

@@ -6,7 +6,7 @@ describe VagrantPlugins::Proxmox::Action::MessageAlreadyRunning do
 	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
 	let(:env) { {ui: double('ui').as_null_object} }
 
-	subject { described_class.new(-> (_) {}, environment) }
+	subject(:action) { described_class.new(-> (_) {}, environment) }
 
 	before { VagrantPlugins::Proxmox::Plugin.setup_i18n }
 
@@ -16,7 +16,7 @@ describe VagrantPlugins::Proxmox::Action::MessageAlreadyRunning do
 
 		specify do
 			expect(env[:ui]).to receive(:info).with 'The virtual machine is already up and running'
-			subject.call env
+			action.call env
 		end
 	end
 

data/spec/actions/message_already_stopped_action_spec.rb

@@ -6,7 +6,7 @@ describe VagrantPlugins::Proxmox::Action::MessageAlreadyStopped do
 	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
 	let(:env) { {ui: double('ui').as_null_object} }
 
-	subject { described_class.new(-> (_) {}, environment) }
+	subject(:action) { described_class.new(-> (_) {}, environment) }
 
 	before { VagrantPlugins::Proxmox::Plugin.setup_i18n }
 
@@ -16,7 +16,7 @@ describe VagrantPlugins::Proxmox::Action::MessageAlreadyStopped do
 
 		specify do
 			expect(env[:ui]).to receive(:info).with 'The virtual machine is already stopped'
-			subject.call env
+			action.call env
 		end
 	end
 

data/spec/actions/message_file_not_found_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require 'actions/proxmox_action_shared'
+
+describe VagrantPlugins::Proxmox::Action::MessageFileNotFound do
+
+	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+	let(:env) { {ui: double('ui').as_null_object} }
+
+	subject(:action) { described_class.new(-> (_) {}, environment) }
+
+	before { VagrantPlugins::Proxmox::Plugin.setup_i18n }
+
+	describe '#call' do
+
+		it_behaves_like 'a proxmox action call'
+
+		specify do
+			expect(env[:ui]).to receive(:info).with /File for upload not found/
+			action.call env
+		end
+	end
+
+end

data/spec/actions/message_not_created_action_spec.rb

@@ -6,7 +6,7 @@ describe VagrantPlugins::Proxmox::Action::MessageNotCreated do
 	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
 	let(:env) { {ui: double('ui').as_null_object} }
 
-	subject { described_class.new(-> (_) {}, environment) }
+	subject(:action) { described_class.new(-> (_) {}, environment) }
 
 	before { VagrantPlugins::Proxmox::Plugin.setup_i18n }
 
@@ -16,7 +16,7 @@ describe VagrantPlugins::Proxmox::Action::MessageNotCreated do
 
 		specify do
 			expect(env[:ui]).to receive(:info).with 'The virtual machine is not created on the server!'
-			subject.call env
+			action.call env
 		end
 	end
 

data/spec/actions/message_not_running_action_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require 'actions/proxmox_action_shared'
+
+describe VagrantPlugins::Proxmox::Action::MessageNotRunning do
+
+	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+	let(:env) { {ui: double('ui').as_null_object} }
+
+	subject(:action) { described_class.new(-> (_) {}, environment) }
+
+	before { VagrantPlugins::Proxmox::Plugin.setup_i18n }
+
+	describe '#call' do
+
+		it_behaves_like 'a proxmox action call'
+
+		specify do
+			expect(env[:ui]).to receive(:info).with /VM must be running to execute this command/
+			action.call env
+		end
+	end
+
+end

data/spec/actions/message_upload_server_error_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require 'actions/proxmox_action_shared'
+
+describe VagrantPlugins::Proxmox::Action::MessageUploadServerError do
+
+	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+	let(:env) { {ui: double('ui').as_null_object} }
+
+	subject(:action) { described_class.new(-> (_) {}, environment) }
+
+	before { VagrantPlugins::Proxmox::Plugin.setup_i18n }
+
+	describe '#call' do
+
+		it_behaves_like 'a proxmox action call'
+
+		specify do
+			expect(env[:ui]).to receive(:info).with /Error during upload/
+			action.call env
+		end
+	end
+
+end

data/spec/actions/proxmox_action_shared.rb

@@ -1,58 +1,3 @@
-shared_examples VagrantPlugins::Proxmox::Action::ProxmoxAction do
-
-	let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile'}
-	let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox),
-							 proxmox_nodes: [{node: 'localhost'}]} }
-	let(:task_upid) { 'UPID:localhost:0000F6ED:00F8E25F:5268CD3B:vzcreate:100:vagrant@pve:' }
-
-	describe '#wait_for_completion' do
-
-		context 'when the task is completed' do
-			before { allow(subject).to receive(:get_task_exitstatus).and_return('OK') }
-			it 'should return the tasks exit status' do
-				subject.send(:wait_for_completion, task_upid, 'localhost', env, '').should == 'OK'
-			end
-		end
-
-		context 'when the task times out' do
-			before do
-				allow(subject).to receive(:get_task_exitstatus).and_return(nil)
-				Retryable.disable
-			end
-			it 'should raise an timeout error' do
-				expect { subject.send(:wait_for_completion, task_upid, 'localhost', env, '') }.to raise_error VagrantPlugins::Proxmox::Errors::Timeout
-			end
-			after { Retryable.enable }
-		end
-
-	end
-
-	describe '#get_task_exitstatus' do
-
-		it 'should request the task state from the proxmox server' do
-			RestClient.should_receive(:get).with("https://your.proxmox.server/api2/json/nodes/localhost/tasks/#{task_upid}/status", anything).
-					and_return({data: {}}.to_json)
-			subject.send(:get_task_exitstatus, task_upid, 'localhost', env)
-		end
-
-		context 'the task has exited' do
-			it 'should return the exit status' do
-				allow(RestClient).to receive(:get).and_return({data: {upid: task_upid, status: 'stopped', exitstatus: 'OK'}}.to_json)
-				subject.send(:get_task_exitstatus, task_upid, 'localhost', env).should == 'OK'
-			end
-		end
-
-		context 'the task is still running' do
-			it 'should return nil' do
-				allow(RestClient).to receive(:get).and_return({data: {upid: task_upid, status: 'running'}}.to_json)
-				subject.send(:get_task_exitstatus, task_upid, 'localhost', env).should == nil
-			end
-		end
-
-	end
-
-end
-
 shared_examples 'a proxmox action call' do
 
 	describe 'when done' do
@@ -63,12 +8,3 @@ shared_examples 'a proxmox action call' do
 	end
 
 end
-
-shared_examples 'a blocking proxmox action' do
-
-	it 'waits for completion of the server task' do
-		subject.should receive(:wait_for_completion)
-		subject.call env
-	end
-
-end

data/spec/actions/proxmox_action_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe Action::ProxmoxAction do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:connection) { Connection.new 'https://proxmox.example.com/api2/json' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox),
+								 proxmox_connection: connection} }
+
+		let (:action) { subject }
+
+		describe '#next_action' do
+
+			let(:app) { double('app') }
+			before { action.instance_variable_set(:@app, app) }
+
+			it 'should call @app' do
+				expect(app).to receive(:call)
+				action.send(:next_action, env)
+			end
+		end
+
+		describe '#get_machine_ip_address' do
+
+			before do
+				allow(env[:machine].config.vm).to receive_messages networks: [[:private_network, {ip: '4.3.2.1'}], [:public_network, {ip: '1.2.3.4'}]]
+			end
+
+			it 'should return the first public ip address from the configuration' do
+				expect(action.send(:get_machine_ip_address, env)).to eq('1.2.3.4')
+			end
+
+			context 'no network configuration exists' do
+
+				before do
+					allow(env[:machine].config.vm).to receive_messages networks: nil
+				end
+
+				it 'should return nil' do
+					expect(action.send(:get_machine_ip_address, env)).to be_nil
+				end
+
+			end
+
+		end
+
+		describe '#connection' do
+			it 'should retrieve the connection from the environment' do
+				expect(action.send(:connection, env)).to eq(connection)
+			end
+		end
+
+	end
+
+end