upgrow 0.0.2 → 0.0.3

data/test/upgrow/result_test.rb

@@ -13,83 +13,38 @@ module Upgrow
       assert_equal([:user, :errors], result_class.members)
     end
 
+    test '.new allows defining errors explicitly' do
+      result_class = Result.new(:user, :errors)
+      assert_equal([:user, :errors], result_class.members)
+    end
+
     test '.new returns a Result class with only errors when called without arguments' do
       result_class = Result.new
       assert_equal([:errors], result_class.members)
     end
 
-    test '.success returns a Result populated with the given values' do
-      result = Result.new(:user).success(user: 'volmer')
-      assert_equal 'volmer', result.user
-      assert_empty result.errors
-    end
-
-    test '.failure returns a Result populated with the given errors' do
-      result = Result.new(:user).failure(@errors)
-      assert_nil result.user
-      assert_equal @errors, result.errors
-    end
-
-    test '#and_then calls the given block and returns self for a successful Result' do
-      called = false
-
-      success = Result.new.success
-
-      returned_value = success.and_then { called = true }
-
-      assert called
-      assert_same success, returned_value
-    end
-
-    test '#or_else passes the Result values as an argument to the given block' do
-      success = Result.new(:user, :post)
-        .success(user: 'volmer', post: 'hello!')
-
-      success.and_then do |user:, post:|
-        assert_equal 'volmer', user
-        assert_equal 'hello!', post
+    test '.new does not accept duplicate members' do
+      error = assert_raises(ArgumentError) do
+        Result.new(:user, :user)
       end
-    end
-
-    test '#and_then does not call the given block and returns self for a failure Result' do
-      called = false
-
-      failure = Result.new.failure(@errors)
-
-      returned_value = failure.and_then { called = true }
 
-      refute called
-      assert_same failure, returned_value
+      assert_equal 'duplicate member: user', error.message
     end
 
-    test '#or_else does not call the given block and returns self for a successful Result' do
-      called = false
-
-      success = Result.new.success
-
-      returned_value = success.or_else { called = true }
-
-      refute called
-      assert_same success, returned_value
+    test '.new.new returns a Result populated with the given values' do
+      result = Result.new(:user).new(user: 'volmer')
+      assert_equal 'volmer', result.user
+      assert_empty result.errors
     end
 
-    test '#or_else calls the given block and returns self for a failure Result' do
-      called = false
-
-      failure = Result.new.failure(@errors)
-
-      returned_value = failure.or_else { called = true }
-
-      assert called
-      assert_same failure, returned_value
+    test '#success? is true when there are no errors' do
+      result = Result.new.new
+      assert_predicate result, :success?
     end
 
-    test '#or_else passes the errors as an argument to the given block' do
-      failure = Result.new.failure(@errors)
-
-      failure.or_else do |errors|
-        assert_equal @errors, errors
-      end
+    test '#success? is false when there are errors' do
+      result = Result.new.new(errors: @errors)
+      refute_predicate result, :success?
     end
   end
 end

data/test/upgrow/schema_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Upgrow
+  class SchemaTest < ActiveSupport::TestCase
+    setup do
+      @schema = Schema.new(:name, :email)
+    end
+
+    test '#attribute_names is empty by default' do
+      assert_empty Schema.new.attribute_names
+    end
+
+    test '#attribute_names returns the values from the Schema initialization' do
+      assert_equal [:name, :email], @schema.attribute_names
+    end
+
+    test '#attribute_names ignores duplicates' do
+      schema = Schema.new(:name, :email, :name)
+      assert_equal [:name, :email], schema.attribute_names
+    end
+
+    test '#attribute defines an extra attribute' do
+      @schema.attribute(:phone)
+
+      assert_equal [:name, :email, :phone], @schema.attribute_names
+    end
+
+    test '#attribute does not define the same attribute twice' do
+      @schema.attribute(:name)
+
+      assert_equal [:name, :email], @schema.attribute_names
+    end
+
+    test '#dup creates a Schema with independent attribute names' do
+      new_schema = @schema.dup
+      new_schema.attribute(:phone)
+
+      assert_equal [:name, :email], @schema.attribute_names
+      assert_equal [:name, :email, :phone], new_schema.attribute_names
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: upgrow
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Shopify Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-17 00:00:00.000000000 Z
+date: 2021-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -24,7 +24,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.1'
-description: 
+description:
 email: gems@shopify.com
 executables: []
 extensions: []
@@ -34,33 +34,63 @@ files:
 - Rakefile
 - lib/upgrow.rb
 - lib/upgrow/action.rb
+- lib/upgrow/actions.rb
 - lib/upgrow/active_record_adapter.rb
+- lib/upgrow/active_record_schema.rb
+- lib/upgrow/basic_model.rb
 - lib/upgrow/basic_repository.rb
+- lib/upgrow/error.rb
 - lib/upgrow/immutable_object.rb
 - lib/upgrow/immutable_struct.rb
 - lib/upgrow/input.rb
 - lib/upgrow/model.rb
+- lib/upgrow/model_schema.rb
 - lib/upgrow/repository.rb
 - lib/upgrow/result.rb
+- lib/upgrow/schema.rb
 - test/application_system_test_case.rb
-- test/dummy/app/actions/create_article_action.rb
-- test/dummy/app/actions/delete_article_action.rb
-- test/dummy/app/actions/edit_article_action.rb
-- test/dummy/app/actions/list_articles_action.rb
-- test/dummy/app/actions/show_article_action.rb
-- test/dummy/app/actions/update_article_action.rb
+- test/dummy/app/actions/application_action.rb
+- test/dummy/app/actions/articles/create_action.rb
+- test/dummy/app/actions/articles/destroy_action.rb
+- test/dummy/app/actions/articles/edit_action.rb
+- test/dummy/app/actions/articles/index_action.rb
+- test/dummy/app/actions/articles/new_action.rb
+- test/dummy/app/actions/articles/show_action.rb
+- test/dummy/app/actions/articles/update_action.rb
+- test/dummy/app/actions/comments/create_action.rb
+- test/dummy/app/actions/comments/destroy_action.rb
+- test/dummy/app/actions/comments/new_action.rb
+- test/dummy/app/actions/sessions/create_action.rb
+- test/dummy/app/actions/sessions/destroy_action.rb
+- test/dummy/app/actions/sessions/new_action.rb
+- test/dummy/app/actions/user_action.rb
+- test/dummy/app/actions/users/create_action.rb
+- test/dummy/app/actions/users/new_action.rb
 - test/dummy/app/channels/application_cable/channel.rb
 - test/dummy/app/channels/application_cable/connection.rb
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/controllers/articles_controller.rb
+- test/dummy/app/controllers/comments_controller.rb
+- test/dummy/app/controllers/sessions_controller.rb
+- test/dummy/app/controllers/users_controller.rb
 - test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/helpers/users_helper.rb
 - test/dummy/app/inputs/article_input.rb
+- test/dummy/app/inputs/comment_input.rb
+- test/dummy/app/inputs/session_input.rb
+- test/dummy/app/inputs/user_input.rb
 - test/dummy/app/jobs/application_job.rb
 - test/dummy/app/mailers/application_mailer.rb
 - test/dummy/app/models/article.rb
+- test/dummy/app/models/comment.rb
+- test/dummy/app/models/user.rb
 - test/dummy/app/records/application_record.rb
 - test/dummy/app/records/article_record.rb
+- test/dummy/app/records/comment_record.rb
+- test/dummy/app/records/user_record.rb
 - test/dummy/app/repositories/article_repository.rb
+- test/dummy/app/repositories/comment_repository.rb
+- test/dummy/app/repositories/user_repository.rb
 - test/dummy/config/application.rb
 - test/dummy/config/boot.rb
 - test/dummy/config/environment.rb
@@ -80,26 +110,38 @@ files:
 - test/dummy/config/puma.rb
 - test/dummy/config/routes.rb
 - test/dummy/db/migrate/20210219211631_create_articles.rb
+- test/dummy/db/migrate/20210320140432_create_comments.rb
+- test/dummy/db/migrate/20210409164927_create_users.rb
 - test/dummy/db/schema.rb
 - test/rails_helper.rb
 - test/system/articles_test.rb
+- test/system/comments_test.rb
+- test/system/guest_user_test.rb
+- test/system/sign_in_test.rb
+- test/system/sign_out_test.rb
+- test/system/sign_up_test.rb
 - test/test_helper.rb
 - test/upgrow/action_test.rb
+- test/upgrow/actions_test.rb
 - test/upgrow/active_record_adapter_test.rb
+- test/upgrow/active_record_schema_test.rb
+- test/upgrow/basic_model_test.rb
 - test/upgrow/basic_repository_test.rb
 - test/upgrow/documentation_test.rb
 - test/upgrow/immutable_object_test.rb
 - test/upgrow/immutable_struct_test.rb
 - test/upgrow/input_test.rb
+- test/upgrow/model_schema_test.rb
 - test/upgrow/model_test.rb
 - test/upgrow/result_test.rb
+- test/upgrow/schema_test.rb
 homepage: https://github.com/Shopify/upgrow
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/Shopify/upgrow/tree/v0.0.2
+  source_code_uri: https://github.com/Shopify/upgrow/tree/v0.0.3
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -114,59 +156,95 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.15
+signing_key:
 specification_version: 4
 summary: A sustainable architecture for Ruby on Rails.
 test_files:
-- test/dummy/db/migrate/20210219211631_create_articles.rb
-- test/dummy/db/schema.rb
-- test/dummy/app/mailers/application_mailer.rb
-- test/dummy/app/inputs/article_input.rb
-- test/dummy/app/controllers/articles_controller.rb
+- test/application_system_test_case.rb
+- test/dummy/app/actions/application_action.rb
+- test/dummy/app/actions/articles/create_action.rb
+- test/dummy/app/actions/articles/destroy_action.rb
+- test/dummy/app/actions/articles/edit_action.rb
+- test/dummy/app/actions/articles/index_action.rb
+- test/dummy/app/actions/articles/new_action.rb
+- test/dummy/app/actions/articles/show_action.rb
+- test/dummy/app/actions/articles/update_action.rb
+- test/dummy/app/actions/comments/create_action.rb
+- test/dummy/app/actions/comments/destroy_action.rb
+- test/dummy/app/actions/comments/new_action.rb
+- test/dummy/app/actions/sessions/create_action.rb
+- test/dummy/app/actions/sessions/destroy_action.rb
+- test/dummy/app/actions/sessions/new_action.rb
+- test/dummy/app/actions/user_action.rb
+- test/dummy/app/actions/users/create_action.rb
+- test/dummy/app/actions/users/new_action.rb
+- test/dummy/app/channels/application_cable/channel.rb
+- test/dummy/app/channels/application_cable/connection.rb
 - test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/articles_controller.rb
+- test/dummy/app/controllers/comments_controller.rb
+- test/dummy/app/controllers/sessions_controller.rb
+- test/dummy/app/controllers/users_controller.rb
+- test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/helpers/users_helper.rb
+- test/dummy/app/inputs/article_input.rb
+- test/dummy/app/inputs/comment_input.rb
+- test/dummy/app/inputs/session_input.rb
+- test/dummy/app/inputs/user_input.rb
 - test/dummy/app/jobs/application_job.rb
+- test/dummy/app/mailers/application_mailer.rb
+- test/dummy/app/models/article.rb
+- test/dummy/app/models/comment.rb
+- test/dummy/app/models/user.rb
 - test/dummy/app/records/application_record.rb
 - test/dummy/app/records/article_record.rb
-- test/dummy/app/helpers/application_helper.rb
-- test/dummy/app/actions/create_article_action.rb
-- test/dummy/app/actions/delete_article_action.rb
-- test/dummy/app/actions/update_article_action.rb
-- test/dummy/app/actions/list_articles_action.rb
-- test/dummy/app/actions/edit_article_action.rb
-- test/dummy/app/actions/show_article_action.rb
-- test/dummy/app/models/article.rb
-- test/dummy/app/channels/application_cable/channel.rb
-- test/dummy/app/channels/application_cable/connection.rb
+- test/dummy/app/records/comment_record.rb
+- test/dummy/app/records/user_record.rb
 - test/dummy/app/repositories/article_repository.rb
+- test/dummy/app/repositories/comment_repository.rb
+- test/dummy/app/repositories/user_repository.rb
+- test/dummy/config/application.rb
+- test/dummy/config/boot.rb
+- test/dummy/config/environment.rb
+- test/dummy/config/environments/development.rb
+- test/dummy/config/environments/production.rb
+- test/dummy/config/environments/test.rb
+- test/dummy/config/initializers/application_controller_renderer.rb
 - test/dummy/config/initializers/assets.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
+- test/dummy/config/initializers/backtrace_silencers.rb
 - test/dummy/config/initializers/content_security_policy.rb
-- test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/initializers/application_controller_renderer.rb
-- test/dummy/config/initializers/permissions_policy.rb
 - test/dummy/config/initializers/cookies_serializer.rb
-- test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
+- test/dummy/config/initializers/filter_parameter_logging.rb
 - test/dummy/config/initializers/inflections.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/routes.rb
+- test/dummy/config/initializers/mime_types.rb
+- test/dummy/config/initializers/permissions_policy.rb
+- test/dummy/config/initializers/wrap_parameters.rb
 - test/dummy/config/puma.rb
-- test/dummy/config/application.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/environments/production.rb
-- test/dummy/config/environment.rb
+- test/dummy/config/routes.rb
+- test/dummy/db/migrate/20210219211631_create_articles.rb
+- test/dummy/db/migrate/20210320140432_create_comments.rb
+- test/dummy/db/migrate/20210409164927_create_users.rb
+- test/dummy/db/schema.rb
 - test/rails_helper.rb
-- test/application_system_test_case.rb
 - test/system/articles_test.rb
-- test/upgrow/immutable_object_test.rb
-- test/upgrow/immutable_struct_test.rb
-- test/upgrow/result_test.rb
-- test/upgrow/basic_repository_test.rb
+- test/system/comments_test.rb
+- test/system/guest_user_test.rb
+- test/system/sign_in_test.rb
+- test/system/sign_out_test.rb
+- test/system/sign_up_test.rb
+- test/test_helper.rb
 - test/upgrow/action_test.rb
+- test/upgrow/actions_test.rb
+- test/upgrow/active_record_adapter_test.rb
+- test/upgrow/active_record_schema_test.rb
+- test/upgrow/basic_model_test.rb
+- test/upgrow/basic_repository_test.rb
 - test/upgrow/documentation_test.rb
-- test/upgrow/model_test.rb
+- test/upgrow/immutable_object_test.rb
+- test/upgrow/immutable_struct_test.rb
 - test/upgrow/input_test.rb
-- test/upgrow/active_record_adapter_test.rb
-- test/test_helper.rb
+- test/upgrow/model_schema_test.rb
+- test/upgrow/model_test.rb
+- test/upgrow/result_test.rb
+- test/upgrow/schema_test.rb

data/test/dummy/app/actions/create_article_action.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-class CreateArticleAction < Upgrow::Action
-  result :article
-
-  def perform(input)
-    if input.valid?
-      article = ArticleRepository.new.create(input)
-      result.success(article: article)
-    else
-      result.failure(input.errors)
-    end
-  end
-end

data/test/dummy/app/actions/delete_article_action.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-class DeleteArticleAction < Upgrow::Action
-  def perform(id)
-    ArticleRepository.new.delete(id)
-    result.success
-  end
-end

data/test/dummy/app/actions/edit_article_action.rb

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-class EditArticleAction < Upgrow::Action
-  result :article
-
-  def perform(id)
-    article = ArticleRepository.new.find(id)
-
-    result.success(article: article)
-  end
-end