upgrow 0.0.2 → 0.0.3

data/test/dummy/app/models/article.rb

@@ -1,6 +1,4 @@
 # frozen_string_literal: true
 
 class Article < Upgrow::Model
-  attribute :title
-  attribute :body
 end

data/test/dummy/app/models/comment.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class Comment < Upgrow::Model
+end

data/test/dummy/app/models/user.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class User < Upgrow::Model
+end

data/test/dummy/app/records/article_record.rb

@@ -2,4 +2,6 @@
 
 class ArticleRecord < ApplicationRecord
   self.table_name = 'articles'
+  has_many :comment_records, foreign_key: :article_id, dependent: :destroy
+  belongs_to :user_record, foreign_key: :user_id
 end

data/test/dummy/app/records/comment_record.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class CommentRecord < ApplicationRecord
+  self.table_name = 'comments'
+  belongs_to :user_record, foreign_key: :user_id
+  belongs_to :article_record, foreign_key: :article_id
+end

data/test/dummy/app/records/user_record.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+class UserRecord < ApplicationRecord
+  self.table_name = 'users'
+
+  has_secure_password
+
+  has_many :article_records, foreign_key: :user_id, dependent: :destroy
+  has_many :comment_records, foreign_key: :user_id, dependent: :destroy
+end

data/test/dummy/app/repositories/article_repository.rb

@@ -1,4 +1,30 @@
 # frozen_string_literal: true
 
 class ArticleRepository < Upgrow::Repository
+  def all
+    base.all.includes(:user_record).map do |record|
+      user = to_model(User, record.user_record.attributes)
+      to_model(record.attributes.merge(user: user))
+    end
+  end
+
+  def find_with_comments(id)
+    record = ArticleRecord.find(id)
+
+    comment_records = record.comment_records.includes(:user_record)
+
+    comments = comment_records.map do |comment_record|
+      user = to_model(User, comment_record.user_record.attributes)
+      to_model(Comment, comment_record.attributes.merge(user: user))
+    end
+
+    user = to_model(User, record.user_record.attributes)
+
+    to_model(record.attributes.merge(comments: comments, user: user))
+  end
+
+  def find_for_user(id, user:)
+    record = base.find_by(id: id, user_id: user.id)
+    to_model(record.attributes) if record
+  end
 end

data/test/dummy/app/repositories/comment_repository.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+class CommentRepository < Upgrow::Repository
+end

data/test/dummy/app/repositories/user_repository.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class UserRepository < Upgrow::Repository
+  def find_for_authentication(input)
+    record = UserRecord.find_by(email: input.email)
+    to_model(record.attributes) if record&.authenticate(input.password)
+  end
+
+  def find_from_context(id)
+    UserRecord.find_by(id: id)
+  end
+end

data/test/dummy/config/routes.rb

@@ -1,7 +1,12 @@
 # frozen_string_literal: true
 
 Rails.application.routes.draw do
-  resources :articles
+  resources :articles do
+    resources :comments, only: [:new, :create, :destroy]
+  end
+
+  resource :session, only: [:new, :create, :destroy]
+  resource :user, only: [:new, :create]
 
   root 'articles#index'
 end

data/test/dummy/db/migrate/20210320140432_create_comments.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+class CreateComments < ActiveRecord::Migration[6.1]
+  def change
+    create_table(:comments) do |t|
+      t.references(:article, null: false, foreign_key: true)
+      t.string(:author, null: false)
+      t.text(:body, null: false)
+
+      t.timestamps
+    end
+  end
+end

data/test/dummy/db/migrate/20210409164927_create_users.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+class CreateUsers < ActiveRecord::Migration[6.1]
+  def change
+    create_table(:users) do |t|
+      t.string(:email, null: false)
+      t.string(:password_digest, null: false)
+
+      t.timestamps
+
+      t.index(:email, unique: true)
+    end
+
+    change_table(:articles) do |t|
+      t.references(:user, null: false, foreign_key: true)
+    end
+
+    change_table(:comments) do |t|
+      t.remove(:author, type: :string, null: false)
+      t.references(:user, null: false, foreign_key: true)
+    end
+  end
+end

data/test/dummy/db/schema.rb

@@ -10,13 +10,36 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2021_02_19_211631) do
+ActiveRecord::Schema.define(version: 2021_04_09_164927) do
 
   create_table "articles", force: :cascade do |t|
     t.string "title", null: false
     t.text "body", null: false
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.integer "user_id", null: false
+    t.index ["user_id"], name: "index_articles_on_user_id"
   end
 
+  create_table "comments", force: :cascade do |t|
+    t.integer "article_id", null: false
+    t.text "body", null: false
+    t.datetime "created_at", precision: 6, null: false
+    t.datetime "updated_at", precision: 6, null: false
+    t.integer "user_id", null: false
+    t.index ["article_id"], name: "index_comments_on_article_id"
+    t.index ["user_id"], name: "index_comments_on_user_id"
+  end
+
+  create_table "users", force: :cascade do |t|
+    t.string "email", null: false
+    t.string "password_digest", null: false
+    t.datetime "created_at", precision: 6, null: false
+    t.datetime "updated_at", precision: 6, null: false
+    t.index ["email"], name: "index_users_on_email", unique: true
+  end
+
+  add_foreign_key "articles", "users"
+  add_foreign_key "comments", "articles"
+  add_foreign_key "comments", "users"
 end

data/test/system/articles_test.rb

@@ -3,15 +3,28 @@
 require 'application_system_test_case'
 
 class ArticlesTest < ApplicationSystemTestCase
-  test 'a message is shown when there are no Articles' do
+  setup do
     visit root_path
-    assert_title 'Articles'
-    assert_text 'There are no Articles just yet.'
+  end
+
+  test 'a guest User cannot see the new Article link' do
+    assert_no_link 'New Article'
+  end
+
+  test 'a guest User cannot see the new Article page' do
+    visit new_article_path
+    assert_title 'Sign In'
+  end
+
+  test 'signed in User can see the new Article link' do
+    sign_in
+    assert_link 'New Article'
   end
 
   test 'Article can be created' do
-    visit root_path
-    click_on 'New Article'
+    sign_in
+
+    click_link 'New Article'
     assert_title 'New Article'
 
     fill_in 'Title', with: 'My title'
@@ -20,11 +33,13 @@ class ArticlesTest < ApplicationSystemTestCase
 
     assert_text 'Article was successfully created.'
     assert_title 'My title'
+    assert_text 'Author: existing@example.com'
     assert_text 'My long body'
   end
 
   test 'validation errors are shown' do
-    visit root_path
+    sign_in
+
     click_on 'New Article'
     click_on 'Create'
 
@@ -34,8 +49,9 @@ class ArticlesTest < ApplicationSystemTestCase
   end
 
   test 'previously entered data is shown' do
-    visit root_path
-    click_on 'New Article'
+    sign_in
+
+    click_link 'New Article'
     fill_in 'Body', with: 'Short'
     click_on 'Create'
 
@@ -44,29 +60,31 @@ class ArticlesTest < ApplicationSystemTestCase
   end
 
   test 'new Article is listed in the index page' do
-    visit root_path
-    click_on 'New Article'
+    sign_in
+
+    click_link 'New Article'
     fill_in 'Title', with: 'My title'
     fill_in 'Body', with: 'My long body'
     click_on 'Create'
-    click_on 'Back'
 
+    visit root_path
     assert_link 'My title'
+    assert_text 'Author: existing@example.com'
     assert_text 'My long body'
   end
 
   test 'Article can be edited' do
-    visit root_path
-    click_on 'New Article'
-    fill_in 'Title', with: 'My title'
-    fill_in 'Body', with: 'My long body'
-    click_on 'Create'
+    sign_in
+
+    click_link 'Lorem Barnak'
     click_on 'Edit'
 
     assert_title 'Edit Article'
 
-    assert_field 'Title', with: 'My title'
-    assert_field 'Body', with: 'My long body'
+    assert_field 'Title', with: 'Lorem Barnak'
+    assert_field 'Body', with: 'Cimonaque de sacristi de colon de câlique de '\
+      "batèche de p'tit Jésus de charogne de marde de patente à gosse de " \
+      "sainte-viarge de bout d'crisse de cibouleau de bâtard."
 
     fill_in 'Title', with: 'Edited title'
     fill_in 'Body', with: 'Edited body'
@@ -74,15 +92,14 @@ class ArticlesTest < ApplicationSystemTestCase
 
     assert_text 'Article was successfully updated.'
     assert_title 'Edited title'
+    assert_text 'Author: existing@example.com'
     assert_text 'Edited body'
   end
 
   test 'validation errors are shown when editing Article' do
-    visit root_path
-    click_on 'New Article'
-    fill_in 'Title', with: 'My title'
-    fill_in 'Body', with: 'My long body'
-    click_on 'Create'
+    sign_in
+
+    click_on 'Lorem Barnak'
     click_on 'Edit'
 
     fill_in 'Title', with: ''
@@ -95,15 +112,56 @@ class ArticlesTest < ApplicationSystemTestCase
     assert_field 'Body', with: 'Short'
   end
 
+  test 'guest User cannot see the edit link' do
+    click_link 'Lorem Barnak'
+    assert_no_link 'Edit'
+  end
+
+  test 'guest User cannot access the edit page directly' do
+    click_link 'Lorem Barnak'
+
+    visit current_path + '/edit'
+
+    assert_title 'Sign In'
+  end
+
+  test 'User who is not the author of the Article cannot see its edit link' do
+    sign_in
+
+    click_on 'The Hobbit'
+    assert_no_link 'Edit'
+  end
+
+  test 'User who is not the author of the Article cannot access the edit page directly' do
+    sign_in
+
+    click_link 'The Hobbit'
+
+    visit current_path + '/edit'
+
+    assert_title 'Sign In'
+  end
+
   test 'Article can be deleted' do
-    visit root_path
-    click_on 'New Article'
-    fill_in 'Title', with: 'My title'
-    fill_in 'Body', with: 'My long body'
-    click_on 'Create'
+    sign_in
+
+    click_on 'Lorem Barnak'
     click_on 'Destroy'
 
+    assert_title 'Articles'
     assert_text 'Article was successfully destroyed'
-    assert_text 'There are no Articles just yet.'
+    assert_no_link 'Lorem Barnak'
+  end
+
+  test 'guest User cannot see the delete button' do
+    click_on 'Lorem Barnak'
+    assert_no_button 'Destroy'
+  end
+
+  test 'User who is not the author of the Article cannot see its delete link' do
+    sign_in
+
+    click_on 'The Hobbit'
+    assert_no_button 'Destroy'
   end
 end

data/test/system/comments_test.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+require 'application_system_test_case'
+
+class CommentsTest < ApplicationSystemTestCase
+  setup do
+    visit root_path
+  end
+
+  test 'a message is shown when there are no Comments' do
+    click_on 'Lorem Barnak'
+    assert_text 'There are no Comments just yet.'
+  end
+
+  test 'guest can see existing Comment' do
+    click_on 'The Hobbit'
+    assert_text 'existing@example.com says:'
+    assert_text 'I hate everything about this article.'
+  end
+
+  test 'Comment can be created' do
+    sign_in
+    click_on 'The Hobbit'
+
+    click_on 'Create Comment'
+    fill_in 'Body', with: 'My long comment'
+    click_on 'Create'
+
+    assert_title 'The Hobbit'
+    assert_text 'existing@example.com says:'
+    assert_text 'My long comment'
+  end
+
+  test 'validation errors are shown' do
+    sign_in
+    click_on 'The Hobbit'
+
+    click_on 'Create Comment'
+    fill_in 'Body', with: 'Short'
+    click_on 'Create'
+
+    assert_title 'New Comment'
+    assert_field 'Body', with: 'Short'
+    assert_text 'Body is too short (minimum is 10 characters)'
+  end
+
+  test 'guest cannot see the Create Comment link' do
+    click_on 'The Hobbit'
+    assert_no_link 'Create Comment'
+  end
+
+  test 'Comment can be deleted' do
+    sign_in
+    click_on 'The Hobbit'
+
+    within('.comments') do
+      click_on 'Delete'
+    end
+
+    assert_title 'The Hobbit'
+    assert_text 'Comment was successfully destroyed'
+    assert_text 'There are no Comments just yet.'
+  end
+
+  test 'guest cannot see the delete button' do
+    click_on 'The Hobbit'
+
+    within('.comments') do
+      assert_no_button 'Delete'
+    end
+  end
+
+  test 'User who is not the author of the comment cannot see the delete button' do
+    sign_in(email: 'jrr_tolkien@example.com', password: 'abc345')
+    click_on 'The Hobbit'
+
+    within('.comments') do
+      assert_no_button 'Delete'
+    end
+  end
+end