update_request 0.0.6 → 0.1.0

data/spec/factories/admin_users.rb

@@ -0,0 +1,5 @@
+FactoryBot.define do
+  factory :admin_user do
+
+  end
+end

data/spec/factories/posts.rb

@@ -0,0 +1,11 @@
+FactoryBot.define do
+  factory :post do
+    sequence :title do |n|
+      "Post #{n}"
+    end
+
+    sequence :body do |n|
+      "body #{n}"
+    end
+  end
+end

data/spec/factories/users.rb

@@ -0,0 +1,11 @@
+FactoryBot.define do
+  factory :user do
+    sequence :username do |n|
+      "username #{n}"
+    end
+
+    sequence :email do |n|
+      "email@#{n}address.com"
+    end
+  end
+end

data/spec/models/update_request/request/apply_bang_spec.rb

@@ -0,0 +1,97 @@
+RSpec.describe "UpdateRequest::Request#apply!:", type: :model do
+  let(:user) { create(:user) }
+  let(:post) { create(:post) }
+  let(:admin_user) { create(:admin_user) }
+
+  context "when a simple update" do
+    let(:changes) do
+      {
+          title: 'new title'
+      }
+    end
+
+    context "is applied WITHOUT an approver" do
+
+      it "then correctly applies the update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+        update_request.save!
+
+        expect(update_request.apply!).to eql(true)
+
+        expect(post.title).to eql(changes[:title])
+        expect(update_request.applied).to eql(true)
+      end
+
+    end
+
+    context "is applied with an approver" do
+
+      it "then correctly applies the update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+        update_request.save!
+
+        expect(update_request.apply!(admin_user)).to eql(true)
+
+        expect(post.title).to eql(changes[:title])
+        expect(update_request.approver).to eql(admin_user)
+        expect(update_request.applied).to eql(true)
+      end
+
+    end
+
+  end
+
+  context "when an update containing a file" do
+    let(:avatar) { Rack::Test::UploadedFile.new('spec/support/image.png', 'image/png') }
+
+    let(:changes) do
+      {
+          avatar: avatar,
+      }
+    end
+
+    context "is created" do
+      it "then correctly saves but does not apply that update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: user, update_schema: changes)
+
+        # Creates correct update_request
+        expect{ update_request.save }.to change{ UpdateRequest::Request.count }.by(1)
+
+        expect(update_request.apply(admin_user)).to eql(true)
+
+        expect(user.avatar_file_name).to eql(avatar.original_filename)
+        expect(user.avatar_content_type).to eql(avatar.content_type)
+        expect(user.avatar_file_size).to eql(avatar.tempfile.size)
+      end
+    end
+
+  end
+
+  context "when an update can't be applied due to validation errors" do
+    let(:changes) do
+      {
+          title: ''
+      }
+    end
+
+    it "then returns false and does not apply the changes" do
+      update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+      update_request.save!
+
+      title_before = post.title
+
+      expect { update_request.apply!(admin_user) }.to raise_error(ActiveRecord::RecordInvalid)
+
+      expect(update_request.updateable.errors.messages).to eql({ title: ["is too short (minimum is 3 characters)"] })
+
+      expect(post.reload.title).to eql(title_before)
+      expect(update_request.approver).to eql(nil)
+      expect(update_request.applied).to eql(false)
+    end
+
+  end
+
+end

data/spec/models/update_request/request/apply_spec.rb

@@ -0,0 +1,97 @@
+RSpec.describe "UpdateRequest::Request#apply:", type: :model do
+  let(:user) { create(:user) }
+  let(:post) { create(:post) }
+  let(:admin_user) { create(:admin_user) }
+
+  context "when a simple update" do
+    let(:changes) do
+      {
+          title: 'new title'
+      }
+    end
+
+    context "is applied WITHOUT an approver" do
+
+      it "then correctly applies the update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+        update_request.save!
+
+        expect(update_request.apply).to eql(true)
+
+        expect(post.title).to eql(changes[:title])
+        expect(update_request.applied).to eql(true)
+      end
+
+    end
+
+    context "is applied with an approver" do
+
+      it "then correctly applies the update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+        update_request.save!
+
+        expect(update_request.apply(admin_user)).to eql(true)
+
+        expect(post.title).to eql(changes[:title])
+        expect(update_request.approver).to eql(admin_user)
+        expect(update_request.applied).to eql(true)
+      end
+
+    end
+
+  end
+
+  context "when an update containing a file" do
+    let(:avatar) { Rack::Test::UploadedFile.new('spec/support/image.png', 'image/png') }
+
+    let(:changes) do
+      {
+          avatar: avatar,
+      }
+    end
+
+    context "is created" do
+      it "then correctly saves but does not apply that update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: user, update_schema: changes)
+
+        # Creates correct update_request
+        expect{ update_request.save }.to change{ UpdateRequest::Request.count }.by(1)
+
+        expect(update_request.apply(admin_user)).to eql(true)
+
+        expect(user.avatar_file_name).to eql(avatar.original_filename)
+        expect(user.avatar_content_type).to eql(avatar.content_type)
+        expect(user.avatar_file_size).to eql(avatar.tempfile.size)
+      end
+    end
+
+  end
+
+  context "when an update can't be applied due to validation errors" do
+    let(:changes) do
+      {
+          title: ''
+      }
+    end
+
+    it "then returns false and does not apply the changes" do
+      update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+      update_request.save!
+
+      title_before = post.title
+
+      expect(update_request.apply(admin_user)).to eql(false)
+
+      expect(update_request.updateable.errors.messages).to eql({ title: ["is too short (minimum is 3 characters)"] })
+
+      expect(post.reload.title).to eql(title_before)
+      expect(update_request.approver).to eql(nil)
+      expect(update_request.applied).to eql(false)
+    end
+
+  end
+
+end

data/spec/models/update_request/request/save_spec.rb

@@ -0,0 +1,104 @@
+RSpec.describe "UpdateRequest::Request#save:", type: :model do
+  let(:user) { create(:user) }
+  let(:post) { create(:post) }
+  let(:admin_user) { create(:admin_user) }
+
+  context "when a simple update" do
+    let(:changes) do
+      {
+          title: 'new title'
+      }
+    end
+
+    context "is created" do
+      it "then correctly saves but does not apply that update" do
+        post_title_before = post.title
+
+        update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+        # Creates correct update_request
+        expect{ update_request.save }.to change{ UpdateRequest::Request.count }.by(1)
+
+        expect(update_request.requester).to eql(user)
+        expect(update_request.updateable).to eql(post)
+        expect(update_request.update_schema).to eql(changes)
+        expect(update_request.applied).to eql(false)
+
+        # Does not apply update
+        expect(post.reload.title).to eql(post_title_before)
+      end
+    end
+
+  end
+
+  context "when an update contains characters outside of yaml's support" do
+    let(:changes) do
+      {
+          title: "\u0092",
+      }
+    end
+
+    context "is created" do
+      it "then correctly saves but does not apply that update" do
+        post_title_before = post.title
+
+        update_request = UpdateRequest::Request.new(requester: user, updateable: post, update_schema: changes)
+
+        # Creates correct update_request
+        expect{ update_request.save }.to change{ UpdateRequest::Request.count }.by(1)
+
+        expect(update_request.requester).to eql(user)
+        expect(update_request.updateable).to eql(post)
+        expect(update_request.update_schema).to eql(changes)
+        expect(update_request.applied).to eql(false)
+
+        # Does not apply update
+        expect(post.reload.title).to eql(post_title_before)
+
+        begin
+          UpdateRequest::Request.last.update_schema
+        rescue Psych::SyntaxError
+          fail
+        end
+      end
+    end
+
+  end
+
+  context "when an update containing a file" do
+    let(:avatar) { Rack::Test::UploadedFile.new('spec/support/image.png', 'image/png') }
+
+    let(:changes) do
+      {
+          avatar: avatar,
+      }
+    end
+
+    context "is created" do
+      it "then correctly saves but does not apply that update" do
+        update_request = UpdateRequest::Request.new(requester: user, updateable: user, update_schema: changes)
+
+        user_avatar_before = user.avatar
+
+        # Creates correct update_request
+        expect{ update_request.save }.to change{ UpdateRequest::Request.count }.by(1)
+
+        expect(update_request.requester).to eql(user)
+        expect(update_request.updateable).to eql(user)
+
+        expect(update_request.applied).to eql(false)
+
+        uploaded_file = update_request.update_schema['avatar'].instance
+
+        expect(uploaded_file.attachment_file_name).to eql(avatar.original_filename)
+        expect(uploaded_file.attachment_content_type).to eql(avatar.content_type)
+        expect(uploaded_file.attachment_file_size).to eql(avatar.tempfile.size)
+
+        # Does not apply update
+        expect(user.reload.avatar).to eql(user_avatar_before)
+      end
+    end
+
+  end
+
+end

data/spec/rails_helper.rb

@@ -0,0 +1,20 @@
+ENV["RAILS_ENV"] ||= "test"
+
+require "spec_helper"
+
+# Add this to load your dummy app's environment file. This file will require
+# the application.rb file in the dummy directory, and initialise the dummy app.
+# Very simple, now you have your dummy application in memory for your specs.
+require File.expand_path("../dummy/config/environment", __FILE__)
+
+require "rspec/rails"
+
+ActiveRecord::Migration.maintain_test_schema!
+
+RSpec.configure do |config|
+
+  config.use_transactional_fixtures = true
+
+  config.infer_spec_type_from_file_location!
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,33 @@
+require 'awesome_print'
+require 'factory_bot_rails'
+
+ENV['RAILS_ENV'] ||= 'test'
+
+require File.expand_path("../dummy/config/environment.rb", __FILE__)
+
+Rails.backtrace_cleaner.remove_silencers!
+
+# Load support files
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+Dir["#{File.dirname(__FILE__)}/factories/**/*.rb"].each { |f| require f }
+
+RSpec.configure do |config|
+  config.order = "random"
+
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.disable_monkey_patching!
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Include FactoryBot methods so you can use build instead of FactoryBot.build
+  config.include FactoryBot::Syntax::Methods
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: update_request
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Aleck Greenham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2018-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,20 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Rails engine for allowing approvable resource updates that support file
   uploads
 email:
@@ -70,42 +56,62 @@ files:
 - lib/update_request.rb
 - lib/update_request/engine.rb
 - lib/update_request/version.rb
-- test/dummy/README.rdoc
-- test/dummy/Rakefile
-- test/dummy/app/assets/javascripts/application.js
-- test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/controllers/application_controller.rb
-- test/dummy/app/helpers/application_helper.rb
-- test/dummy/app/views/layouts/application.html.erb
-- test/dummy/bin/bundle
-- test/dummy/bin/rails
-- test/dummy/bin/rake
-- test/dummy/config.ru
-- test/dummy/config/application.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/database.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/config/environments/production.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/initializers/assets.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
-- test/dummy/config/initializers/cookies_serializer.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
-- test/dummy/config/initializers/inflections.rb
-- test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/session_store.rb
-- test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/locales/en.yml
-- test/dummy/config/routes.rb
-- test/dummy/config/secrets.yml
-- test/dummy/public/404.html
-- test/dummy/public/422.html
-- test/dummy/public/500.html
-- test/dummy/public/favicon.ico
-- test/integration/navigation_test.rb
-- test/test_helper.rb
-- test/update_request_test.rb
+- spec/dummy/README.rdoc
+- spec/dummy/Rakefile
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/models/admin_user.rb
+- spec/dummy/app/models/post.rb
+- spec/dummy/app/models/user.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/bin/setup
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/assets.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/cookies_serializer.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config/secrets.yml
+- spec/dummy/db/migrate/20180301065842_create_users.rb
+- spec/dummy/db/migrate/20180301070148_create_posts.rb
+- spec/dummy/db/migrate/20180301070316_create_admin_users.rb
+- spec/dummy/db/schema.rb
+- spec/dummy/db/test.sqlite3
+- spec/dummy/log/test.log
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/dummy/public/system/update_request/updated_files/attachments/000/000/001/original/image.png
+- spec/dummy/public/system/update_request/updated_files/attachments/000/000/002/original/image.png
+- spec/dummy/public/system/users/avatars/000/000/001/original/image.png
+- spec/factories/admin_users.rb
+- spec/factories/posts.rb
+- spec/factories/users.rb
+- spec/integration/navigation_test.rb
+- spec/models/update_request/request/apply_bang_spec.rb
+- spec/models/update_request/request/apply_spec.rb
+- spec/models/update_request/request/save_spec.rb
+- spec/rails_helper.rb
+- spec/spec_helper.rb
+- spec/support/image.png
 homepage: https://github.com/greena13/update_request
 licenses:
 - MIT
@@ -126,44 +132,64 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.2.1
 signing_key: 
 specification_version: 4
 summary: Rails engine for approvable resource updates
 test_files:
-- test/dummy/app/assets/javascripts/application.js
-- test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/controllers/application_controller.rb
-- test/dummy/app/helpers/application_helper.rb
-- test/dummy/app/views/layouts/application.html.erb
-- test/dummy/bin/bundle
-- test/dummy/bin/rails
-- test/dummy/bin/rake
-- test/dummy/config/application.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/database.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/config/environments/production.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/initializers/assets.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
-- test/dummy/config/initializers/cookies_serializer.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
-- test/dummy/config/initializers/inflections.rb
-- test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/session_store.rb
-- test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/locales/en.yml
-- test/dummy/config/routes.rb
-- test/dummy/config/secrets.yml
-- test/dummy/config.ru
-- test/dummy/public/404.html
-- test/dummy/public/422.html
-- test/dummy/public/500.html
-- test/dummy/public/favicon.ico
-- test/dummy/Rakefile
-- test/dummy/README.rdoc
-- test/integration/navigation_test.rb
-- test/test_helper.rb
-- test/update_request_test.rb
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/models/admin_user.rb
+- spec/dummy/app/models/post.rb
+- spec/dummy/app/models/user.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/bin/setup
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/assets.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/cookies_serializer.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config/secrets.yml
+- spec/dummy/config.ru
+- spec/dummy/db/migrate/20180301065842_create_users.rb
+- spec/dummy/db/migrate/20180301070148_create_posts.rb
+- spec/dummy/db/migrate/20180301070316_create_admin_users.rb
+- spec/dummy/db/schema.rb
+- spec/dummy/db/test.sqlite3
+- spec/dummy/log/test.log
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/dummy/public/system/update_request/updated_files/attachments/000/000/001/original/image.png
+- spec/dummy/public/system/update_request/updated_files/attachments/000/000/002/original/image.png
+- spec/dummy/public/system/users/avatars/000/000/001/original/image.png
+- spec/dummy/Rakefile
+- spec/dummy/README.rdoc
+- spec/factories/admin_users.rb
+- spec/factories/posts.rb
+- spec/factories/users.rb
+- spec/integration/navigation_test.rb
+- spec/models/update_request/request/apply_bang_spec.rb
+- spec/models/update_request/request/apply_spec.rb
+- spec/models/update_request/request/save_spec.rb
+- spec/rails_helper.rb
+- spec/spec_helper.rb
+- spec/support/image.png