update_request 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: be092aa3e9b5e0a0a88f17975b7ff1ca1537c2b5
-  data.tar.gz: 518a37e5ede83060ab5f5182a5d7d154030b0bc8
+  metadata.gz: de148be73c7e21ac6f8e09ff56f35bc82ff4e39e
+  data.tar.gz: e4f813bcc2e7fb1c5509448831ac85169ef74f3f
 SHA512:
-  metadata.gz: 25240b4b9d29df0c262cbcb33a447f3e504f9fded2f4fda481b92caf5e6cb003f2dc2a5907e9d09a3c3c24c266c4a78eaf4d207c44599c2ad589cab85c5cea52
-  data.tar.gz: 57d5e27415a27f54d1e6973eee017aab44035d19bc7e15b7ea7fb6d6f45a02a62bd51bb046e03117202275cd48190237dffa832ef3ac4e53754c7c8294cfa2dd
+  metadata.gz: 48702591d6805220f5aabcb524560ff67617d36af577b98f5d9589d48cdd2bfceec734d2f9efe8a904ae75d6955ff1377f010690d4b6a8c6428b7b2cc6ac7a10
+  data.tar.gz: a2e9f876d0a5207a1c3ea8895e889f352af39f0e54a8bf273e4266f17af36a24bdf25956db3615e8e45807dd96392d8735d07843d2ce6b567069fa09ead2d4ba

data/Rakefile

@@ -14,21 +14,17 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../test/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
 load 'rails/tasks/engine.rake'
 
-
-
 Bundler::GemHelper.install_tasks
 
-require 'rake/testtask'
+Dir[File.join(File.dirname(__FILE__), 'tasks/**/*.rake')].each {|f| load f }
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = false
-end
+require 'rspec/core'
+require 'rspec/core/rake_task'
 
+desc "Run all specs in spec directory (excluding plugin specs)"
+RSpec::Core::RakeTask.new(:spec => 'app:db:test:prepare')
 
-task default: :test
+task :default => :spec

data/app/models/update_request/request.rb

@@ -7,8 +7,6 @@ class UpdateRequest::Request < ActiveRecord::Base
 
   scope :outstanding, -> { where(applied: false) }
 
-  before_save :extract_files_from_schema
-
   after_save :reinsert_files_into_schema
   after_initialize :reinsert_files_into_schema
 
@@ -35,12 +33,21 @@ class UpdateRequest::Request < ActiveRecord::Base
     applied
   end
 
+  def assign_attributes(attributes)
+    if attributes[:update_schema]
+      super(attributes.merge(update_schema: extract_files_from(attributes[:update_schema])))
+    else
+      super(attributes)
+    end
+  end
+
   private
 
   # Because the methods included in Paperclip::Attachment from the
   # Paperclip::Storage::Filesystem module are somehow lost in assigning the update
   # schema to the ActiveRecord::Base instance attribute, we need to re-include them
-  def reinclude_modules_in_attachments(update_schema)
+
+  def reinclude_modules_in_attachments(update_schema = {})
     update_schema.reduce({}) do |memo, key_and_value|
       key, value = key_and_value
 
@@ -66,10 +73,6 @@ class UpdateRequest::Request < ActiveRecord::Base
 
   end
 
-  def extract_files_from_schema
-    self.update_schema = extract_files_from(update_schema)
-  end
-
   def extract_files_from(schema, prefix = '')
     schema.inject({}) do |memo, key_and_value|
       key, value = key_and_value
@@ -78,27 +81,27 @@ class UpdateRequest::Request < ActiveRecord::Base
         updated_files.build(attachment: value, attribute_reference: stringify_reference(prefix, key))
       else
         memo[key] =
-            case value
-
-              when Hash
-                extract_files_from(value, stringify_reference(prefix, key))
+          case value
 
-              when Array
+            when Hash
+              extract_files_from(value, stringify_reference(prefix, key))
 
-                value.each_with_index.map do |value_item, index|
-                  reference = stringify_reference(stringify_reference(prefix, key), index)
+            when Array
 
-                  if value_item.kind_of?(Hash) || value_item.kind_of?(Array)
-                    extract_files_from(value_item, reference)
-                  else
-                    value_item
-                  end
+              value.each_with_index.map do |value_item, index|
+                reference = stringify_reference(stringify_reference(prefix, key), index)
 
+                if value_item.kind_of?(Hash) || value_item.kind_of?(Array)
+                  extract_files_from(value_item, reference)
+                else
+                  value_item
                 end
 
-              else
-                value
-            end
+              end
+
+            else
+              value
+          end
       end
 
       memo

data/db/migrate/20160105123605_create_requests.rb

@@ -1,4 +1,4 @@
-class CreateRequests < ActiveRecord::Migration
+class CreateRequests < ActiveRecord::Migration[4.2]
   def change
     create_table :update_request_requests do |t|
       t.belongs_to :updateable, polymorphic: true

data/db/migrate/20160105123721_create_updated_files.rb

@@ -1,4 +1,6 @@
-class CreateUpdatedFiles < ActiveRecord::Migration
+class CreateUpdatedFiles < ActiveRecord::Migration[4.2]
+  include Paperclip::Schema
+
   def change
     create_table :update_request_updated_files do |t|
       t.belongs_to :request

data/lib/update_request/engine.rb

@@ -1,5 +1,14 @@
+require 'paperclip'
+
 module UpdateRequest
   class Engine < ::Rails::Engine
     isolate_namespace UpdateRequest
+
+    config.generators do |g|
+      g.test_framework :rspec, :fixture => false
+      g.fixture_replacement :factory_girl, :dir => 'spec/factories'
+      g.assets false
+      g.helper false
+    end
   end
 end

data/lib/update_request/version.rb

@@ -1,3 +1,3 @@
 module UpdateRequest
-  VERSION = "0.0.6"
+  VERSION = "0.1.0"
 end

data/{test → spec}/dummy/app/assets/javascripts/application.js

@@ -2,7 +2,7 @@
 // listed below.
 //
 // Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
-// or vendor/assets/javascripts of plugins, if any, can be referenced here using a relative path.
+// or any plugin's vendor/assets/javascripts directory can be referenced here using a relative path.
 //
 // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
 // compiled file.

data/{test → spec}/dummy/app/assets/stylesheets/application.css

@@ -3,7 +3,7 @@
  * listed below.
  *
  * Any CSS and SCSS file within this directory, lib/assets/stylesheets, vendor/assets/stylesheets,
- * or vendor/assets/stylesheets of plugins, if any, can be referenced here using a relative path.
+ * or any plugin's vendor/assets/stylesheets directory can be referenced here using a relative path.
  *
  * You're free to add application-wide styles to this file and they'll appear at the bottom of the
  * compiled file so the styles you add here take precedence over styles defined in any styles

data/spec/dummy/app/models/admin_user.rb

@@ -0,0 +1,3 @@
+class AdminUser < ActiveRecord::Base
+
+end

data/spec/dummy/app/models/post.rb

@@ -0,0 +1,4 @@
+class Post < ActiveRecord::Base
+  validates :title, length: { minimum: 3 }
+
+end

data/spec/dummy/app/models/user.rb

@@ -0,0 +1,5 @@
+class User < ActiveRecord::Base
+  has_attached_file :avatar
+
+  do_not_validate_attachment_file_type :avatar
+end

data/{test → spec}/dummy/bin/rails

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

data/spec/dummy/bin/setup

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+require 'pathname'
+
+# path to your application root.
+APP_ROOT = Pathname.new File.expand_path('../../',  __FILE__)
+
+Dir.chdir APP_ROOT do
+  # This script is a starting point to setup your application.
+  # Add necessary setup steps to this file:
+
+  puts "== Installing dependencies =="
+  system "gem install bundler --conservative"
+  system "bundle check || bundle install"
+
+  # puts "\n== Copying sample files =="
+  # unless File.exist?("config/database.yml")
+  #   system "cp config/database.yml.sample config/database.yml"
+  # end
+
+  puts "\n== Preparing database =="
+  system "bin/rake db:setup"
+
+  puts "\n== Removing old logs and tempfiles =="
+  system "rm -f log/*"
+  system "rm -rf tmp/cache"
+
+  puts "\n== Restarting application server =="
+  system "touch tmp/restart.txt"
+end

data/{test → spec}/dummy/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Rails.application

data/{test → spec}/dummy/config/application.rb

@@ -3,6 +3,7 @@ require File.expand_path('../boot', __FILE__)
 require 'rails/all'
 
 Bundler.require(*Rails.groups)
+
 require "update_request"
 
 module Dummy

data/{test → spec}/dummy/config/environments/development.rb

@@ -27,6 +27,10 @@ Rails.application.configure do
   # number of complex assets.
   config.assets.debug = true
 
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
+  config.assets.digest = true
+
   # Adds additional error checking when serving assets at runtime.
   # Checks for improperly declared sprockets dependencies.
   # Raises helpful error messages.

data/{test → spec}/dummy/config/environments/production.rb

@@ -16,11 +16,13 @@ Rails.application.configure do
 
   # Enable Rack::Cache to put a simple HTTP cache in front of your application
   # Add `rack-cache` to your Gemfile before enabling this.
-  # For large-scale production use, consider using a caching reverse proxy like nginx, varnish or squid.
+  # For large-scale production use, consider using a caching reverse proxy like
+  # NGINX, varnish or squid.
   # config.action_dispatch.rack_cache = true
 
-  # Disable Rails's static asset server (Apache or nginx will already do this).
-  config.serve_static_assets = false
+  # Disable serving static files from the `/public` folder by default since
+  # Apache or NGINX already handles this.
+  config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
 
   # Compress JavaScripts and CSS.
   config.assets.js_compressor = :uglifier
@@ -29,20 +31,22 @@ Rails.application.configure do
   # Do not fallback to assets pipeline if a precompiled asset is missed.
   config.assets.compile = false
 
-  # Generate digests for assets URLs.
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
   config.assets.digest = true
 
   # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
 
   # Specifies the header that your server uses for sending files.
-  # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
-  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
+  # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
+  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   # config.force_ssl = true
 
-  # Set to :debug to see everything in the log.
-  config.log_level = :info
+  # Use the lowest log level to ensure availability of diagnostic information
+  # when problems arise.
+  config.log_level = :debug
 
   # Prepend all log lines with the following tags.
   # config.log_tags = [ :subdomain, :uuid ]
@@ -54,7 +58,7 @@ Rails.application.configure do
   # config.cache_store = :mem_cache_store
 
   # Enable serving of images, stylesheets, and JavaScripts from an asset server.
-  # config.action_controller.asset_host = "http://assets.example.com"
+  # config.action_controller.asset_host = 'http://assets.example.com'
 
   # Ignore bad email addresses and do not raise email delivery errors.
   # Set this to true and configure the email server for immediate delivery to raise delivery errors.
@@ -67,9 +71,6 @@ Rails.application.configure do
   # Send deprecation notices to registered listeners.
   config.active_support.deprecation = :notify
 
-  # Disable automatic flushing of the log to improve performance.
-  # config.autoflush_log = false
-
   # Use default logging formatter so that PID and timestamp are not suppressed.
   config.log_formatter = ::Logger::Formatter.new
 

data/{test → spec}/dummy/config/environments/test.rb

@@ -12,8 +12,8 @@ Rails.application.configure do
   # preloads Rails for running tests, you may have to set it to true.
   config.eager_load = false
 
-  # Configure static asset server for tests with Cache-Control for performance.
-  config.serve_static_assets  = true
+  # Configure static file server for tests with Cache-Control for performance.
+  config.serve_static_files   = true
   config.static_cache_control = 'public, max-age=3600'
 
   # Show full error reports and disable caching.
@@ -31,6 +31,9 @@ Rails.application.configure do
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
+  # Randomize the order test cases are executed.
+  config.active_support.test_order = :random
+
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 

data/{test → spec}/dummy/config/initializers/assets.rb

@@ -3,6 +3,9 @@
 # Version of your assets, change this if you want to expire all your assets.
 Rails.application.config.assets.version = '1.0'
 
+# Add additional assets to the asset load path
+# Rails.application.config.assets.paths << Emoji.images_path
+
 # Precompile additional assets.
 # application.js, application.css, and all non-JS/CSS in app/assets folder are already added.
 # Rails.application.config.assets.precompile += %w( search.js )

data/{test → spec}/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,3 @@
 # Be sure to restart your server when you modify this file.
 
-Rails.application.config.action_dispatch.cookies_serializer = :json
+Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/dummy/config/routes.rb

@@ -0,0 +1,3 @@
+Rails.application.routes.draw do
+
+end

data/{test → spec}/dummy/config/secrets.yml

@@ -11,10 +11,10 @@
 # if you're sharing your code publicly.
 
 development:
-  secret_key_base: b88e2f2d2079ffd381564618206fdd3c78c0bd1e9e403bc0fabf8c775a1785862bc7ca9266c9164c61d355cd91e93d6b7b6fe05bcc02d041f5a36f5e9c44df8e
+  secret_key_base: 7ab11f4a8f684a3d082ba2719f0c1f0494bbd44f9ec75ff9b812a35dfa8c73f24018d3ec4ef6a35ac03f190f00b936f110e54ecbf577ebdf3bb54b4f7e7c4bd0
 
 test:
-  secret_key_base: f79609d63928af412fae0aafe3a5e12a618dfc1eab8f509f4a7395b204be1fc2f5825d08696623e2fb1af42772d094ccb4366f64a9a01d149de66fa6511bcb40
+  secret_key_base: 12ebd56756159d5f0ac658647f46559e6cccd24423070cca858056077a0a84f6c58ec9687a9f827cf8766854bb6c03c08c44dd3d2c081ce7ba87905412064a3d
 
 # Do not keep production secrets in the repository,
 # instead read values from the environment.

data/spec/dummy/db/migrate/20180301065842_create_users.rb

@@ -0,0 +1,9 @@
+class CreateUsers < ActiveRecord::Migration[5.1]
+  def change
+    create_table :users do |t|
+      t.string :username
+      t.string :email
+      t.attachment :avatar
+    end
+  end
+end