unparser 0.2.8 → 0.3.0

data/config/rubocop.yml

@@ -2,10 +2,11 @@ inherit_from: ../.rubocop.yml
 
 AllCops:
   Include:
+    - 'lib/unparser.rb'
+    - 'lib/unparser/**/*.rb'
     - '**/*.rake'
     - 'Gemfile'
     - 'Gemfile.triage'
-  TargetRubyVersion: 2.1
 
 # Avoid parameter lists longer than five parameters.
 ParameterLists:
@@ -103,3 +104,15 @@ EmptyLinesAroundModuleBody:
 # I like my style more
 AccessModifierIndentation:
   Enabled: false
+
+Style/CommentedKeyword:
+  Enabled: false
+
+Style/MixinGrouping:
+  Enabled: false
+
+Lint/BooleanSymbol:
+  Enabled: false
+
+Style/AccessModifierDeclarations:
+  Enabled: false

data/lib/unparser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'set'
 require 'abstract_type'
 require 'procto'

data/lib/unparser/ast.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   # Namespace for AST processing tools
   # :reek:TooManyConstants
@@ -6,7 +8,7 @@ module Unparser
     FIRST_CHILD = ->(node) { node.children.first }.freeze
     TAUTOLOGY   = ->(_node) { true }.freeze
 
-    RESET_NODES   = [:module, :class, :sclass, :def, :defs].freeze
+    RESET_NODES   = %i[module class sclass def defs].freeze
     INHERIT_NODES = [:block].freeze
     CLOSE_NODES   = (RESET_NODES + INHERIT_NODES).freeze
 
@@ -14,7 +16,7 @@ module Unparser
     #
     # FIXME: Kwargs are missing.
     #
-    ASSIGN_NODES = [:lvasgn, :arg, :optarg, :restarg].freeze
+    ASSIGN_NODES = %i[lvasgn arg optarg restarg].freeze
 
     # Test for local variable inherited scope reset
     #
@@ -98,7 +100,6 @@ module Unparser
       # @api private
       #
       def each(&block)
-        return to_enum unless block_given?
         Walker.call(node, controller, &block)
       end
 
@@ -176,18 +177,19 @@ module Unparser
       #
       # @param [Parser::AST::Node] node
       #
-      # @return [self]
+      # @return [undefined]
       #
       # @api private
       #
       def call(node)
         return unless controller.call(node)
+
         block.call(node)
         node.children.each do |child|
-          next unless child.is_a?(Parser::AST::Node)
+          break unless child.instance_of?(Parser::AST::Node)
+
           call(child)
         end
-        self
       end
 
     end # Walker

data/lib/unparser/ast/local_variable_scope.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   module AST
 
@@ -130,7 +132,6 @@ module Unparser
       # @api private
       #
       def each(node, &block)
-        return to_enum(__method__, node) unless block_given?
         visit(node, &block)
       end
 
@@ -154,6 +155,7 @@ module Unparser
       #
       # @api private
       #
+      # ignore :reek:LongYieldList
       def visit(node, &block)
         before = current.dup
         enter(node)

data/lib/unparser/buffer.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 module Unparser
 
   # Buffer used to emit into
+  #
+  # ignore :reek:TooManyMethods
   class Buffer
 
     NL = "\n".freeze
@@ -12,7 +16,7 @@ module Unparser
     # @api private
     #
     def initialize
-      @content = ''
+      @content = +''
       @indent = 0
     end
 

data/lib/unparser/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'unparser'
 require 'optparse'
 require 'diff/lcs'
@@ -11,6 +13,7 @@ module Unparser
   # Unparser CLI implementation
   #
   # :reek:InstanceVariableAssumption
+  # :reek:TooManyInstanceVariables
   class CLI
 
     EXIT_SUCCESS = 0
@@ -37,6 +40,7 @@ module Unparser
     #
     # @api private
     #
+    # ignore :reek:TooManyStatements
     def initialize(arguments)
       @sources = []
       @ignore = Set.new
@@ -56,12 +60,13 @@ module Unparser
 
     # Add options
     #
-    # @param [Optparse::Builder] builder
+    # @param [OptionParser] builder
     #
     # @return [undefined]
     #
     # @api private
     #
+    # ignore :reek:TooManyStatements
     def add_options(builder)
       builder.banner = 'usage: unparse [options] FILE [FILE]'
       builder.separator('')
@@ -91,6 +96,7 @@ module Unparser
     def exit_status
       effective_sources.each do |source|
         next if @ignore.include?(source)
+
         process_source(source)
         break if @fail_fast && !@success
       end
@@ -148,6 +154,7 @@ module Unparser
     #
     # @api private
     #
+    # ignore :reek:UtilityFunction
     def sources(file_name)
       files =
         if File.directory?(file_name)

data/lib/unparser/cli/color.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   # Class to colorize strings
   class Color

data/lib/unparser/cli/differ.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   class CLI
     # Class to create diffs from source code

data/lib/unparser/cli/source.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 module Unparser
   class CLI
     # Source representation for CLI sources
+    #
+    # ignore :reek:TooManyMethods
     class Source
       include AbstractType, Adamantium::Flat, NodeHelpers
 
@@ -27,7 +31,7 @@ module Unparser
         def self.build(ast)
           source = Unparser.unparse(ast)
           new(source, ast, nil)
-        rescue => exception
+        rescue StandardError => exception
           new(nil, ast, exception)
         end
       end
@@ -84,6 +88,7 @@ module Unparser
       #
       # @api private
       #
+      # ignore :reek:UtilityFunction
       def strip(source)
         source = source.rstrip
         indent = source.scan(/^\s*/).first
@@ -204,6 +209,7 @@ module Unparser
       #
       # @api private
       #
+      # ignore :reek:UtilityFunction
       def parse(source)
         Parser::CurrentRuby.parse(source)
       end

data/lib/unparser/comments.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 module Unparser
 
   # Holds the comments that remain to be emitted
+  #
+  # ignore :reek:RepeatedConditional
   class Comments
 
     # Proxy to singleton
@@ -52,6 +56,7 @@ module Unparser
     #
     def take_eol_comments
       return EMPTY_ARRAY unless @last_range_consumed
+
       comments = take_up_to_line(@last_range_consumed.end.line)
       unshift_documents(comments)
     end

data/lib/unparser/constants.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 module Unparser
   # All unparser constants maybe included in other libraries.
   #
-  # rubocop:disable MutableConstant
   # False positive since constants are frozen dynamically
   # to avoid duplication of `.freeze` calls
   #
@@ -22,16 +23,16 @@ module Unparser
     private_class_method :symbol_set
 
     # All unary operators of the ruby language
-    UNARY_OPERATORS = symbol_set %w(
+    UNARY_OPERATORS = symbol_set %w[
       ! ~ -@ +@
-    )
+    ]
 
     # All binary operators of the ruby language
-    BINARY_OPERATORS = symbol_set %w(
+    BINARY_OPERATORS = symbol_set %w[
       + - * / & | && || << >> ==
       === != <= < <=> > >= =~ !~ ^
       ** %
-    )
+    ]
 
     COMMENT = '#'
 
@@ -104,11 +105,12 @@ module Unparser
 
     DEFAULT_DELIMITER = ', '.freeze
 
-    CURLY_BRACKETS = IceNine.deep_freeze(%w({ }))
+    CURLY_BRACKETS = IceNine.deep_freeze(%w[{ }])
 
     KEYWORDS = constants.each_with_object([]) do |name, keywords|
       value = const_get(name).freeze
       next unless name.to_s.start_with?('K_')
+
       keywords << value.to_sym
     end.to_set.freeze
 

data/lib/unparser/dsl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   # DSL to help defining emitters
   module DSL

data/lib/unparser/emitter.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 module Unparser
 
   # Emitter base class
   #
   # buggy, argument values are sends to self
-  # rubocop:disable CircularArgumentReference
+  #
+  # ignore :reek:TooManyMethods
   class Emitter
     include Adamantium::Flat, AbstractType, Constants, NodeHelpers
     include Concord.new(:node, :parent)
@@ -12,11 +15,11 @@ module Unparser
     # Registry for node emitters
     REGISTRY = {} # rubocop:disable MutableConstant
 
-    NOINDENT = [:rescue, :ensure].to_set.freeze
+    NOINDENT = %i[rescue ensure].to_set.freeze
 
     DEFAULT_DELIMITER = ', '.freeze
 
-    CURLY_BRACKETS = IceNine.deep_freeze(%w({ }))
+    CURLY_BRACKETS = IceNine.deep_freeze(%w[{ }])
 
     module Unterminated
       def terminated?
@@ -236,6 +239,7 @@ module Unparser
     #
     # @api private
     #
+    # ignore :reek:ControlParameter
     def conditional_parentheses(flag)
       if flag
         parentheses { yield }
@@ -265,8 +269,8 @@ module Unparser
     #
     # @api private
     #
-    def delimited_plain(nodes, delimiter = DEFAULT_DELIMITER)
-      delimited(nodes, delimiter, &method(:visit_plain))
+    def delimited_plain(nodes)
+      delimited(nodes, &method(:visit_plain))
     end
 
     # Emit delimited body
@@ -278,13 +282,14 @@ module Unparser
     #
     # @api private
     #
-    def delimited(nodes, delimiter = DEFAULT_DELIMITER, &block)
+    def delimited(nodes, &block)
       return if nodes.empty?
+
       block ||= method(:visit)
       head, *tail = nodes
       block.call(head)
       tail.each do |node|
-        write(delimiter)
+        write(DEFAULT_DELIMITER)
         block.call(node)
       end
     end
@@ -321,6 +326,7 @@ module Unparser
     def emit_comments_before(source_part = :expression)
       comments_before = comments.take_before(node, source_part)
       return if comments_before.empty?
+
       emit_comments(comments_before)
       buffer.nl
     end
@@ -347,6 +353,7 @@ module Unparser
       emit_eol_comments
       comments_left = comments.take_all
       return if comments_left.empty?
+
       buffer.nl
       emit_comments(comments_left)
     end
@@ -428,8 +435,6 @@ module Unparser
     #
     # False positive:
     #
-    # rubocop:disable MethodCallWithoutArgsParentheses
-    #
     def indented
       buffer = buffer()
       buffer.indent
@@ -447,6 +452,7 @@ module Unparser
     #
     # @api private
     #
+    # rubocop:disable MethodCallWithoutArgsParentheses
     def emit_body(body = body())
       unless body
         buffer.indent
@@ -456,6 +462,7 @@ module Unparser
       end
       visit_indented(body)
     end
+    # rubocop:enable MethodCallWithoutArgsParentheses
 
     # Visit indented node
     #
@@ -495,9 +502,11 @@ module Unparser
     #
     # @api private
     #
+    # rubocop:disable MethodCallWithoutArgsParentheses
     def run(emitter, node = node())
       emitter.new(node, self).write_to_buffer
     end
+    # rubocop:enable MethodCallWithoutArgsParentheses
 
   end # Emitter
 end # Unparser

data/lib/unparser/emitter/alias.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   class Emitter
     # Emitter for alias nodes

data/lib/unparser/emitter/argument.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   class Emitter
 
@@ -40,6 +42,7 @@ module Unparser
       def dispatch
         delimited(normal_arguments)
         return if shadowargs.empty?
+
         write('; ')
         delimited(shadowargs)
       end

data/lib/unparser/emitter/assignment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Unparser
   class Emitter
 
@@ -41,6 +43,7 @@ module Unparser
         def emit_right
           right = right_node
           return unless right
+
           write(WS, T_ASN, WS)
           visit(right)
         end
@@ -144,8 +147,8 @@ module Unparser
 
       private
 
-        NO_COMMA = [:splat, :restarg].to_set.freeze
-        PARENT_MLHS = [:mlhs, :masgn].freeze
+        NO_COMMA = %i[splat restarg].to_set.freeze
+        PARENT_MLHS = %i[mlhs masgn].freeze
 
         # Perform dispatch
         #