unparser 0.2.8 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89eae693b0b2b09ebd3fcb9ade1e24b126c68afaa05ac5d2fa635c33c8b25229
-  data.tar.gz: 1c04a551559a58cebb43475e3a43cb8100ae68d5f6ff0a8fea78e7a7e92d55e2
+  metadata.gz: 96674256a364b20d34279b13821b1885615189db24c4ec229405b8305936fa4d
+  data.tar.gz: 1c5484ef44c86310837ad8626635228e56bf3227e11e3d4190f0159cb52dfc58
 SHA512:
-  metadata.gz: 6236052606af0a610cd6819ad2b19bf47877428057dc53d7c16cc1c7bef91cbb9d169ad62f402c2113bb211275588041443242c179c9fa5233b1938fce4ffd84
-  data.tar.gz: e7b4b900464471d40e2f0f385d992c20cf3fec04b6ba7f560b3c784c6d677d652ac9364c62fca6a70990f0e88c113f107bac05adec02c073f480cc371b3fff1b
+  metadata.gz: f5784148f66b8283b4b56a48f7b93c116b069a947ee3196012444bade8f02a67fb080cd52d6011068c8cdcf7ac82efe07bf1b3c2e7aa7215d66313369aa5e469
+  data.tar.gz: ce7223635f503a065e8d4826d6967817d9165adf76c424105bfc690f9c1b5dfee6c87dbb320c4ccb72af9ebcb78eb4b3fa2319977d89f0eb892e940bfd6b5eb6

data/.circleci/config.yml

@@ -0,0 +1,17 @@
+defaults: &defaults
+  working_directory: ~/unparser
+  steps:
+    - checkout
+    - run: bundle install
+    - run: bundle exec rake ci
+version: 2
+jobs:
+  ruby_2_5:
+    <<: *defaults
+    docker:
+      - image: circleci/ruby:2.5.3
+workflows:
+  version: 2
+  test:
+    jobs:
+      - ruby_2_5

data/.rubocop.yml

@@ -6,3 +6,4 @@ AllCops:
     - 'vendor/**/*'
     - 'benchmarks/**/*'
     - 'tmp/**/*'
+  TargetRubyVersion: 2.5

data/Changelog.md

@@ -1,3 +1,7 @@
+# v0.3.0 2018-11-16
+
+* Drop support for Ruby < 2.5
+
 # v0.2.7 2018-07-18
 
 * Add emitters for `__FILE__` and `__LINE__`

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    unparser (0.2.6)
+    unparser (0.2.9)
       abstract_type (~> 0.0.7)
       adamantium (~> 0.2.0)
       concord (~> 0.1.5)
@@ -21,12 +21,12 @@ GEM
       abstract_type (~> 0.0.7)
       adamantium (~> 0.2)
       equalizer (~> 0.0.11)
-    ast (2.3.0)
+    ast (2.4.0)
     axiom-types (0.1.1)
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    codeclimate-engine-rb (0.4.0)
+    codeclimate-engine-rb (0.4.1)
       virtus (~> 1.0)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
@@ -35,39 +35,42 @@ GEM
       equalizer (~> 0.0.9)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    devtools (0.1.16)
+    devtools (0.1.21)
+      abstract_type (~> 0.0.7)
       adamantium (~> 0.2.0)
       anima (~> 0.3.0)
       concord (~> 0.1.5)
-      flay (~> 2.8.1)
-      flog (~> 4.4.0)
-      mutant (~> 0.8.11)
-      mutant-rspec (~> 0.8.11)
+      flay (~> 2.10.0)
+      flog (~> 4.6.1)
+      mutant (~> 0.8.16)
+      mutant-rspec (~> 0.8.16)
       procto (~> 0.0.3)
-      rake (~> 11.3.0)
-      reek (~> 4.5.0)
-      rspec (~> 3.5.0)
-      rspec-core (~> 3.5.4)
+      rake (~> 12.3.0)
+      reek (~> 5.0.2)
+      rspec (~> 3.8.0)
+      rspec-core (~> 3.8.0)
       rspec-its (~> 1.2.0)
-      rubocop (~> 0.47.0)
-      simplecov (~> 0.12.0)
-      yard (~> 0.9.1)
+      rubocop (~> 0.59.0)
+      simplecov (~> 0.16.1)
+      yard (~> 0.9.16)
       yardstick (~> 0.9.9)
     diff-lcs (1.3)
-    docile (1.1.5)
+    docile (1.3.1)
     equalizer (0.0.11)
     erubis (2.7.0)
-    flay (2.8.1)
+    flay (2.10.0)
       erubis (~> 2.7.0)
       path_expander (~> 1.0)
       ruby_parser (~> 3.0)
       sexp_processor (~> 4.0)
-    flog (4.4.1)
+    flog (4.6.2)
       path_expander (~> 1.0)
       ruby_parser (~> 3.1, > 3.1.0)
-      sexp_processor (~> 4.4)
+      sexp_processor (~> 4.8)
     ice_nine (0.11.2)
-    json (2.0.3)
+    jaro_winkler (1.5.1)
+    json (2.1.0)
+    kwalify (0.7.2)
     memoizable (0.4.2)
       thread_safe (~> 0.3, >= 0.3.1)
     morpher (0.2.6)
@@ -79,77 +82,80 @@ GEM
       equalizer (~> 0.0.9)
       ice_nine (~> 0.11.0)
       procto (~> 0.0.2)
-    mutant (0.8.12)
+    mutant (0.8.19)
       abstract_type (~> 0.0.7)
       adamantium (~> 0.2.0)
       anima (~> 0.3.0)
       ast (~> 2.2)
       concord (~> 0.1.5)
-      diff-lcs (~> 1.2)
+      diff-lcs (~> 1.3)
       equalizer (~> 0.0.9)
       ice_nine (~> 0.11.1)
       memoizable (~> 0.4.2)
       morpher (~> 0.2.6)
       parallel (~> 1.3)
-      parser (~> 2.3.1, >= 2.3.1.4)
+      parser (~> 2.5.1)
       procto (~> 0.0.2)
-      regexp_parser (~> 0.3.6)
+      regexp_parser (~> 1.2)
       unparser (~> 0.2.5)
-    mutant-rspec (0.8.11)
-      mutant (~> 0.8.11)
-      rspec-core (>= 3.4.0, < 3.6.0)
-    parallel (1.10.0)
-    parser (2.3.3.1)
-      ast (~> 2.2)
-    path_expander (1.0.1)
-    powerpack (0.1.1)
+    mutant-rspec (0.8.19)
+      mutant (~> 0.8.19)
+      rspec-core (>= 3.4.0, < 4.0.0)
+    parallel (1.12.1)
+    parser (2.5.3.0)
+      ast (~> 2.4.0)
+    path_expander (1.0.3)
+    powerpack (0.1.2)
     procto (0.0.3)
-    rainbow (2.2.1)
-    rake (11.3.0)
-    reek (4.5.4)
+    rainbow (3.0.0)
+    rake (12.3.1)
+    reek (5.0.2)
       codeclimate-engine-rb (~> 0.4.0)
-      parser (~> 2.3.1, >= 2.3.1.2)
-      rainbow (~> 2.0)
-    regexp_parser (0.3.6)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+      kwalify (~> 0.7.0)
+      parser (>= 2.5.0.0, < 2.6, != 2.5.1.1)
+      rainbow (>= 2.0, < 4.0)
+    regexp_parser (1.3.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.0)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
+      rspec-support (~> 3.8.0)
     rspec-its (1.2.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.5.0)
+    rspec-mocks (3.8.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.47.1)
-      parser (>= 2.3.3.1, < 3.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.0)
+    rubocop (0.59.2)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    ruby_parser (3.8.4)
-      sexp_processor (~> 4.1)
-    sexp_processor (4.7.0)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
+    ruby-progressbar (1.10.0)
+    ruby_parser (3.11.0)
+      sexp_processor (~> 4.9)
+    sexp_processor (4.11.0)
+    simplecov (0.16.1)
+      docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    thread_safe (0.3.5)
-    unicode-display_width (1.1.3)
+    simplecov-html (0.10.2)
+    thread_safe (0.3.6)
+    unicode-display_width (1.4.0)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
       descendants_tracker (~> 0.0, >= 0.0.3)
       equalizer (~> 0.0, >= 0.0.9)
-    yard (0.9.8)
+    yard (0.9.16)
     yardstick (0.9.9)
       yard (~> 0.8, >= 0.8.7.2)
 
@@ -158,9 +164,9 @@ PLATFORMS
 
 DEPENDENCIES
   anima (~> 0.3.0)
-  devtools (~> 0.1.3)
+  devtools (~> 0.1.21)
   morpher (~> 0.2.6)
   unparser!
 
 BUNDLED WITH
-   1.13.7
+   1.17.1

data/Rakefile

@@ -8,6 +8,7 @@ namespace :metrics do
   task mutant: :coverage do
     args = %w[
       bundle exec mutant
+      --ignore-subject Unparser::Buffer#initialize
       --include lib
       --require unparser
       --use rspec

data/bin/unparser

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 trap('INT') do |status|
   exit! 128 + status
 end

data/config/devtools.yml

@@ -1,2 +1,2 @@
 ---
-unit_test_timeout: 0.1
+unit_test_timeout: 1.0

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 13
-total_score: 659
+total_score: 632

data/config/reek.yml

@@ -1,137 +1,137 @@
 ---
-UnusedParameters:
-  exclude: []
-UncommunicativeParameterName:
-  accept: []
-  exclude: []
-  enabled: true
-  reject:
-  - !ruby/regexp /^.$/
-  - !ruby/regexp /[0-9]$/
-  - !ruby/regexp /[A-Z]/
-TooManyInstanceVariables:
-  exclude:
-  - Unparser::CLI
-  enabled: true
-  max_instance_variables: 3
-TooManyMethods:
-  exclude:
-  - Unparser::Emitter # TODO: 13 methods, mostly helpers for deduplicate sublcasses
-  - Unparser::Buffer  # 11 methods
-  - Unparser::CLI::Source # 11 methods
-  enabled: true
-  max_methods: 10
-UncommunicativeMethodName:
-  accept:
-  - s
-  - n
-  exclude: []
-  enabled: true
-  reject:
-  - !ruby/regexp /^[a-z]$/
-  - !ruby/regexp /[0-9]$/
-  - !ruby/regexp /[A-Z]/
-LongParameterList:
-  max_params: 3
-  exclude:
-  - Unparser#self.transquote
-  enabled: true
-  overrides: {}
-FeatureEnvy:
-  exclude:
-  # False positives
-  - Unparser::CLI::Differ#collapsed_hunks
-  - Unparser::Emitter::Send::Arguments#effective_arguments
-  # Helper methods, false positive
-  - Unparser::CLI::Source#strip
-  - Unparser::CLI::Source#report_unparser
-  - Unparser::CLI#sources
-  enabled: true
-ClassVariable:
-  exclude: []
-  enabled: true
-BooleanParameter:
-  exclude: []
-  enabled: true
-IrresponsibleModule:
-  exclude: []
-  enabled: false # buggy / broken
-UncommunicativeModuleName:
-  accept: []
-  exclude: []
-  enabled: true
-  reject:
-  - !ruby/regexp /^.$/
-  - !ruby/regexp /[0-9]$/
-NestedIterators:
-  ignore_iterators: []
-  exclude:
-  # Acceptable cases:
-  - Unparser::Emitter::Literal::Regexp#dispatch
-  - Unparser::CLI::Preprocessor::Dstr#collapsed_children
-  - Unparser::Preprocessor::CollapseStrChildren#collapsed_children
-  enabled: true
-  max_allowed_nesting: 1
-TooManyStatements:
-  max_statements: 6
-  enabled: true
-  exclude:
-  - Unparser::CLI#add_options
-  - Unparser::CLI#initialize
-  - Unparser::CLI::Source#report_unparser
-  - Unparser::Emitter#delimited
-DuplicateMethodCall:
-  allow_calls: []
-  exclude: []
-  enabled: false
-  max_calls: 1
-UtilityFunction:
-  max_helper_calls: 1
-  exclude:
-  # Intent to be helper methods
-  - Unparser::CLI::Source#strip
-  - Unparser::CLI::Source#parse
-  - Unparser::NodeHelpers#n
-  - Unparser::NodeHelpers#s
-  - Unparser::CLI#sources
-  enabled: true
-Attribute:
-  exclude: []
-  enabled: false
-UncommunicativeVariableName:
-  accept: []
-  exclude: []
-  enabled: true
-  reject:
-  - !ruby/regexp /^.$/
-  - !ruby/regexp /[0-9]$/
-  - !ruby/regexp /[A-Z]/
-RepeatedConditional:
-  exclude:
-  # TODO:
-  - Unparser::Comments
-  # False positives
-  - Unparser::Emitter::If
-  - Unparser::CLI
-  enabled: true
-  max_ifs: 1
-DataClump:
-  exclude: []
-  enabled: true
-  max_copies: 1
-  min_clump_size: 3
-ControlParameter:
-  exclude:
-    # False positive:
-    - Unparser::Emitter#emit_body
-    - Unparser::Emitter#conditional_parentheses
-    - Unparser::AST::LocalVariableScope#match
-  enabled: true
-NilCheck:
-  enabled: false
-LongYieldList:
-  max_params: 1
-  exclude:
-  - Unparser::AST::LocalVariableScopeEnumerator#visit
-  - Unparser::AST::LocalVariableScope#match
-  enabled: true
+detectors:
+  Attribute:
+    enabled: false
+    exclude: []
+  BooleanParameter:
+    enabled: true
+    exclude: []
+  ClassVariable:
+    enabled: true
+    exclude: []
+  ControlParameter:
+    enabled: true
+    exclude:
+    - Mutant::Expression#match_length
+  DataClump:
+    enabled: true
+    exclude: []
+    max_copies: 2
+    min_clump_size: 2
+  DuplicateMethodCall:
+    enabled: false
+    exclude: []
+    max_calls: 1
+    allow_calls: []
+  FeatureEnvy:
+    enabled: false
+  # Buggy smell detector
+  IrresponsibleModule:
+    enabled: false
+    exclude: []
+  LongParameterList:
+    enabled: true
+    exclude:
+    - Mutant::Matcher::Method::Instance#self.build
+    - Mutant::Meta::Example::DSL # 3 vars
+    max_params: 2
+  LongYieldList:
+    enabled: true
+    exclude: []
+    max_params: 2
+  NestedIterators:
+    enabled: true
+    exclude:
+    - Mutant#self.singleton_subclass_instance
+    - Mutant::CLI#parse
+    - Mutant::Mutator::Node::Arguments#emit_argument_mutations
+    - Mutant::Mutator::Node::Resbody#mutate_captures
+    - Mutant::Mutator::Util::Array::Element#dispatch
+    - Mutant::Parallel::Master#run
+    - Mutant::RequireHighjack#self.call
+    - Mutant::Selector::Expression#call
+    - Parser::Lexer#self.new
+    max_allowed_nesting: 1
+    ignore_iterators: []
+  NilCheck:
+    enabled: false
+  RepeatedConditional:
+    enabled: true
+    exclude:
+    - Mutant::Mutator
+    - Mutant::Meta::Example::DSL
+    max_ifs: 1
+  TooManyInstanceVariables:
+    enabled: true
+    exclude:
+    - Mutant::Mutator # 4 vars
+    - Mutant::Parallel::Master # 4 vars
+    - Mutant::Meta::Example::DSL # 4 vars
+    max_instance_variables: 3
+  TooManyMethods:
+    enabled: true
+    exclude:
+    - Mutant::CLI
+    - Mutant::Mutator::Node
+    - Mutant::Parallel::Master
+    max_methods: 10
+  TooManyStatements:
+    enabled: true
+    exclude:
+    - Mutant::CLI#add_debug_options
+    - Mutant::CLI#add_environment_options
+    - Mutant::Reporter::CLI::Printer::Config#run
+    - Mutant::Reporter::CLI::Printer::EnvProgress#run
+    - Mutant::Runner#run_driver
+    - Mutant::Zombifier::File#self.find
+    max_statements: 7
+  UncommunicativeMethodName:
+    enabled: true
+    exclude:
+    - Mutant::AST::Sexp#s
+    - Mutant::Mutation#sha1
+    reject:
+    - '/^[a-z]$/'
+    - '/[0-9]$/'
+    - '/[A-Z]/'
+    accept: []
+  UncommunicativeModuleName:
+    enabled: true
+    exclude: []
+    reject:
+    - '/^.$/'
+    - '/[0-9]$/'
+    accept: []
+  UncommunicativeParameterName:
+    enabled: true
+    exclude: []
+    reject:
+    - '/^.$/'
+    - '/[0-9]$/'
+    - '/[A-Z]/'
+    accept: []
+  UncommunicativeVariableName:
+    enabled: true
+    exclude: []
+    reject:
+    - '/^.$/'
+    - '/[0-9]$/'
+    - '/[A-Z]/'
+    accept: ['force_utf32']
+  UnusedParameters:
+    enabled: true
+    exclude: []
+  UtilityFunction:
+    enabled: true
+    exclude:
+    - Mutant::AST::Sexp#s
+    - Mutant::Actor::Env#new_mailbox
+    - Mutant::CLI#reporter
+    - Mutant::Integration::Null#call
+    - Mutant::Integration::Rspec#parse_example
+    - Mutant::Integration::Rspec#parse_expression # intentional, private
+    - Mutant::Meta::Example::Verification#format_mutations # intentional, private
+    - Mutant::Reporter::CLI::Format::Progressive#new_buffer
+    - Mutant::Reporter::CLI::Printer::StatusProgressive#object # False positive calls super
+    - Mutant::Repository::Diff#tracks? # intentional, private
+    - Mutant::Repository::Diff#within_working_directory? # intentional, private