umlaut 4.0.0.beta3 → 4.0.0.beta4

data/test/unit/permalink_test.rb

@@ -1,17 +0,0 @@
-require 'test_helper'
-class PermalinkTest < ActiveSupport::TestCase
-  fixtures :referents, :referent_values
-  test "new with values" do    
-    request  = fake_umlaut_request("/resolve?format=journal&issn=0362-4331&jtitle=The+New+York+times&sid=info%3Asid%2Fsfxit.com%3Acitation")
-    referent = request.referent
-
-    permalink = nil
-    assert_difference('Permalink.count') {
-      permalink = Permalink.new_with_values!(referent, "info:sid/sfxit.com:citation")
-    }
-    assert_equal(referent.id, permalink.referent_id)
-    assert_equal("info:sid/sfxit.com:citation", permalink.orig_rfr_id)
-    assert_not_nil(permalink.context_obj_serialized)
-    assert_equal("The New York times", permalink.restore_context_object.referent.jtitle)
-  end
-end

data/test/unit/referent_test.rb

@@ -1,68 +0,0 @@
-require 'test_helper'
-
-
-class ReferentTest < ActiveSupport::TestCase
-
-
-  def test_enhance_referent
-    referent = Referent.new
-    referent.build_referent_value("title", "this is a title")  
-    referent.save!
-
-    another_reference = Referent.find(referent.id)
-    refute_same referent, another_reference
-
-    Rails.logger.info("----ENHANCE BEGIN----")
-
-    another_reference.enhance_referent("title", "new title")
-
-    Rails.logger.info("----ENHANCE END----")
-
-    # Make sure there's only one referent_value with key 'title', and it has
-    # our new value
-    rvs = another_reference.referent_values(true)
-
-    assert_length 1, rvs
-
-    assert_equal "title", rvs.first.key_name
-    assert_equal "new title", rvs.first.value
-  end
-
-  def test_add_identifier
-    referent = Referent.new
-    referent.save
-
-    referent.add_identifier("urn:isbn:123")
-    assert referent.identifiers.any? { |i| i == "urn:isbn:123" }
-  end
-
-  def test_create_by_context_object
-    url = "url_ver=Z39.88-2004&url_ctx_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Actx&ctx_ver=Z39.88-2004&ctx_tim=2014-09-03T09%3A56%3A22-04%3A00&ctx_id=&ctx_enc=info%3Aofi%2Fenc%3AUTF-8&rft.genre=article&rft.au=Chen%2C+Yu-Hui&rft.date=2009-05-01&rft.volume=60&rft.issue=5&rft.spage=953&rft.jtitle=Journal+of+the+American+Society+for+Information+Science+%26+Technology&rft.issn=15322882&rft.pub=Wiley-Blackwell&rft.atitle=An+exploration+into+the+practices+of+library+Web+usability+in+ARL+academic+libraries.&rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Ajournal&rft_id=info%3Adoi%2F10.1002%2Fasi.21032&rfr_id=http%3A%2F%2Fcatalyst.library.jhu.edu%2Fsearch%2Farticles"
-    co  = OpenURL::ContextObject.new_from_kev(url)    
-    rft = Referent.create_by_context_object(co)
-
-    assert rft.persisted?
-
-    rft_values = rft.referent_values
-    assert rft_values.all? {|rv| rv.persisted?}
-
-    [
-      ["atitle", "An exploration into the practices of library Web usability in ARL academic libraries."],
-      ['au', 'Chen, Yu-Hui'],
-      ['date', '2009-05-01'],
-      ['format', 'journal'],
-      ['genre', 'article'],
-      ['identifier', 'info:doi/10.1002/asi.21032'],
-      ['issn', '15322882'],
-      ['issue', '5'],
-      ['jtitle', 'Journal of the American Society for Information Science & Technology'],
-      ['pub', 'Wiley-Blackwell'],
-      ['spage', '953'],
-      ['volume', '60'],
-    ].each do |key, value|
-      assert (rft_values.find {|rv| rv.key_name == key && rv.value == value}), "Missing expected referent_value with key #{key}"
-    end
-  end
-
-
-end

data/test/unit/referent_to_citation_test.rb

@@ -1,72 +0,0 @@
-require 'test_helper'
-
-# Some basic tests for referent.to_citation, which returns a hash of various citation
-# information. 
-class ReferentToCitationTest < ActiveSupport::TestCase
-  # referent = make_test_referent("title=foo&au=bar&genre=book")
-  def make_test_referent(openurl_kev)
-    co = OpenURL::ContextObject.new_from_kev( openurl_kev )
-    ref = Referent.create_by_context_object( co )
-
-    return ref
-  end
-
-  def test_simple_book
-    # an exmaple from Borrow Direct as it happens
-    ref = make_test_referent("genre=Book&sid=BD&rft.title=The%20monk&rft.aufirst=%20M.%20G.&rft.aulast=Lewis&rft.date=1797&rft.pub=Printed%20by%20William%20Porter&rft.place=Dublin&umlaut.force_new_request=true")
-    cit_hash = ref.to_citation
-
-    assert_equal "The monk",      cit_hash[:title]
-    assert_equal "1797",          cit_hash[:date]
-    assert_equal "Lewis, M. G.",  cit_hash[:author]
-    assert_equal "Book Title",    cit_hash[:title_label]
-    assert_equal "Printed by William Porter", cit_hash[:pub]
-  end
-
-  def test_article
-    # an article from Google Scholar
-    ref = make_test_referent("sid=google&auinit=S&aulast=Madsbad&atitle=Mechanisms+of+changes+in+glucose+metabolism+and+bodyweight+after+bariatric+surgery&id=doi:10.1016/S2213-8587(13)70218-3&title=The+Lancet+Diabetes+%26+Endocrinology&volume=2&issue=2&date=2014&spage=152&issn=2213-8587")
-    cit_hash = ref.to_citation
-
-    assert_equal "Mechanisms of changes in glucose metabolism and bodyweight after bariatric surgery",
-      cit_hash[:title]
-    assert_equal "Article Title", cit_hash[:title_label]
-    assert_equal "The Lancet Diabetes & Endocrinology", cit_hash[:container_title]
-    assert_equal "Journal", cit_hash[:container_label]
-    assert_equal "22138587", cit_hash[:issn]
-    assert_equal "2", cit_hash[:volume]
-    assert_equal "2", cit_hash[:issue]
-    assert_equal "2014", cit_hash[:date]
-    assert_equal "Madsbad, S", cit_hash[:author]
-    assert_equal "152", cit_hash[:page]
-    assert_equal ["info:doi/10.1016/S2213-8587(13)70218-3"], cit_hash[:identifiers]
-  end
-
-  def test_type_of_thing
-    I18n.locale = "en"
-
-    ref = make_test_referent("&genre=dissertation&title=Foo&au=Smith")
-    assert_equal I18n.t("umlaut.citation.genre.dissertation"), ref.type_of_thing
-    assert_equal I18n.t("umlaut.citation.genre.dissertation"), ref.container_type_of_thing
-
-    ref = make_test_referent("rft_val_fmt=info:ofi/fmt:kev:mtx:dissertation&title=Foo")
-    assert_equal I18n.t("umlaut.citation.genre.dissertation"), ref.type_of_thing
-
-    ref = make_test_referent("sid=google&auinit=S&aulast=Madsbad&atitle=Mechanisms+of+changes+in+glucose+metabolism+and+bodyweight+after+bariatric+surgery&id=doi:10.1016/S2213-8587(13)70218-3&title=The+Lancet+Diabetes+%26+Endocrinology&volume=2&issue=2&date=2014&spage=152&issn=2213-8587")
-    assert_equal I18n.t("umlaut.citation.genre.article"), ref.type_of_thing
-    assert_equal I18n.t("umlaut.citation.genre.journal"), ref.container_type_of_thing
-
-    ref = make_test_referent("genre=bookitem&atitle=a+chapter&title=a+book")
-    assert_equal I18n.t("umlaut.citation.genre.bookitem"), ref.type_of_thing
-    assert_equal I18n.t("umlaut.citation.genre.book"), ref.container_type_of_thing
-
-    ref = make_test_referent("genre=unknown&atitle=a+chapter&title=a+book")
-    assert_nil ref.type_of_thing
-    assert_nil ref.container_type_of_thing
-
-    ref = make_test_referent("genre=invalid_made_up&atitle=a+chapter&title=a+book")
-    assert_nil ref.type_of_thing
-    assert_nil ref.container_type_of_thing
-  end
-
-end

data/test/unit/request_test.rb

@@ -1,48 +0,0 @@
-require 'test_helper'
-
-# Some basic tests for referent.to_citation, which returns a hash of various citation
-# information. 
-class RequestTest < ActiveSupport::TestCase
-
-  test "add_service_response" do
-    request = fake_umlaut_request("/resolve?title=foo&author=bar")
-    request.service_responses.to_a
-    service = DummyService.new("priority" => 3, "service_id" => "DummyService")
-
-    request.add_service_response(
-      :service=>service, 
-      :url=>"http://example.com",
-      :display_text=>"something",      
-      :service_type_value => :highlighted_link
-    )
-
-    assert_length 1, request.service_responses
-
-    response = request.service_responses.first
-
-    assert_equal service.service_id, response.service_id
-
-    assert_equal request.id,           response.request.id
-    assert_equal ServiceTypeValue[:highlighted_link], response.service_type_value
-
-    assert_equal "http://example.com", response.view_data[:url]
-    assert_equal "something",          response.view_data[:display_text]
-
-  end
-
-  test "get_service_type_with_bum_response" do
-    request = fake_umlaut_request("/resolve?title=foo&author=bar")
-    request.add_service_response(
-      :service => Service.new('service_id' => "NO_SUCH", "priority" => 3),      
-      :service_type_value => :highlighted_link
-    )
-    request.add_service_response(
-      :service => ServiceStore.instantiate_service!('DummyService', request),
-      :service_type_value => :highlighted_link
-    )
-
-    assert_length 1, request.get_service_type(:highlighted_link)
-
-  end
-
-end

data/test/unit/scopus2_test.rb

@@ -1,147 +0,0 @@
-require 'test_helper'
-require 'uri'
-
-class Scopus2Test < ActiveSupport::TestCase
-  extend TestWithCassette
-
-  # Set shell env SCOPUS_KEY to your api key to test fresh http
-  # connections, if you can't use the ones cached by VCR. 
-
-  # Filter API key out of VCR cache for tag :scopus, which we'll use
-  # in this test. 
-  @@api_key = (ENV["SCOPUS_KEY"] || "DUMMY_API_KEY")
-  VCR.configure do |c|
-    c.filter_sensitive_data("DUMMY_API_KEY", :scopus) { @@api_key }
-  end
-
-  def setup
-    @service       = Scopus2.new('service_id' => 'test_scopus2', 'api_key' => @@api_key, 'priority' => 0)
-  end
-
-  def make_rails_request(umlaut_url)  
-    # hard to figure out how to mock a request, this seems to work
-    ActionController::TestRequest.new(Rack::MockRequest.env_for(umlaut_url))    
-  end
-
-  def make_umlaut_request(umlaut_url)
-    rails_request = make_rails_request(umlaut_url)
-    Request.find_or_create(rails_request.params, {}, rails_request)
-  end
-
-  
-  # Actual openurl sent by google scholar, including a doi. 
-  # Do we correctly create a scopus doi query?  
-  def test_doi_query  
-    doi = '10.1007/s10350-006-0578-2'
-    umlaut_request = make_umlaut_request("/resolve?sid=google&auinit=J&aulast=Rafferty&atitle=Practice+parameters+for+sigmoid+diverticulitis&id=doi:#{CGI.escape doi}&title=Diseases+of+the+colon+%26+rectum&volume=49&issue=7&date=2006&spage=939&issn=0012-3706")
-    
-    scopus_query = @service.scopus_query(umlaut_request)
-
-    assert_equal %Q{DOI("#{doi}")}, scopus_query
-  end
-
-  # No doi, but full citation. scopus query?
-  def test_non_doi_query
-    umlaut_request = make_umlaut_request("/resolve?sid=google&auinit=J&aulast=Rafferty&atitle=Practice+parameters+for+sigmoid+diverticulitis&title=Diseases+of+the+colon+%26+rectum&volume=49&issue=7&date=2006&spage=939&issn=0012-3706")
-
-    scopus_query = @service.scopus_query(umlaut_request)
-
-    expected_query = "VOLUME(\"49\") AND ISSUE(\"7\") AND PAGEFIRST(\"939\")  AND (ISSN(\"00123706\") OR EISSN(\"00123706\"))"
-    assert_equal expected_query, scopus_query
-  end
-
-  # journal title but no issn
-  def test_no_issn_query
-    umlaut_request = make_umlaut_request("/resolve?sid=google&auinit=J&aulast=Rafferty&atitle=Practice+parameters+for+sigmoid+diverticulitis&title=Diseases+of+the+colon+%26+rectum&volume=49&issue=7&date=2006&spage=939&jtitle=Diseases+of+the+colon+%26+rectum")
-
-    scopus_query = @service.scopus_query(umlaut_request)
-
-    expected_query = "VOLUME(\"49\") AND ISSUE(\"7\") AND PAGEFIRST(\"939\")  AND EXACTSRCTITLE(\"Diseases of the colon & rectum\")"
-    assert_equal expected_query, scopus_query
-  end
-
-  # Not enough to make a query, no journal title or issn
-  def test_insufficient_metadata_query
-    umlaut_request = make_umlaut_request("/resolve?sid=google&auinit=J&aulast=Rafferty&atitle=Practice+parameters+for+sigmoid+diverticulitis&title=Diseases+of+the+colon+%26+rectum&volume=49&issue=7&date=2006&spage=939")
-
-    scopus_query = @service.scopus_query(umlaut_request)
-
-    assert_nil scopus_query    
-  end
-
-  def test_pmid_query
-    umlaut_request = make_umlaut_request("/resolve?sid=google&pmid=123456&atitle=ignore&aulast=ignore&issn=12345678")
-
-    scopus_query = @service.scopus_query(umlaut_request)
-
-    assert_equal "PMID(\"123456\")", scopus_query
-  end
-
-  def test_isbn_query
-    umlaut_request = make_umlaut_request("/resolve?sid=google&isbn=1234567890&title=ignore&aulast=ignore")
-
-    scopus_query = @service.scopus_query(umlaut_request)
-
-    assert_equal "ISBN(\"1234567890\")", scopus_query
-  end
-
-  # Live test, with VCR recording
-  test_with_cassette("live test with result", :scopus) do    
-    umlaut_request = make_umlaut_request("/resolve?sid=google&auinit=J&aulast=Rafferty&atitle=Practice+parameters+for+sigmoid+diverticulitis&title=Diseases+of+the+colon+%26+rectum&volume=49&issue=7&date=2006&spage=939&issn=0012-3706")
-      
-    @service.handle_wrapper(umlaut_request)
-
-    cited_by_responses = umlaut_request.service_responses.find_all {|r| r.service_type_value_name == "cited_by"}
-    assert_length 1, cited_by_responses
-    
-    cited_by_response = cited_by_responses.first
-    assert_match URI::regexp, cited_by_response.url, "cited_by has valid url"
-    assert_present cited_by_response.display_text
-
-    similar_responses = umlaut_request.service_responses.find_all {|r| r.service_type_value_name == "similar"}
-    assert_length 2, similar_responses
-
-    similar_responses.each do |similar_response|
-      assert_match URI::regexp, similar_response.url, "similar-type response has valid url"
-      assert_present similar_response.display_text, "similar-type response has display_text"
-    end
-
-    dispatch = umlaut_request.dispatched_services.find {|ds| ds.service_id == @service.service_id}
-    assert_present dispatch
-    assert_equal DispatchedService::Successful, dispatch.status
-  end
-
-  test_with_cassette("live test with no hits", :scopus) do
-    umlaut_request = make_umlaut_request("/resolve?sid=google&atitle=adfadfadf&title=adfadf&volume=4900&issue=700&date=1900&spage=93900&issn=0012-3706")
-
-    @service.handle_wrapper(umlaut_request)
-
-    assert_length 0, umlaut_request.service_responses
-
-    dispatch = umlaut_request.dispatched_services.find {|ds| ds.service_id == @service.service_id}
-    assert_present dispatch
-    assert_equal DispatchedService::Successful, dispatch.status
-  end
-
-  test_with_cassette("live trigger scopus error", :scopus) do
-    # Make a new service object that we mock to send a back request to Scopus, so
-    # we can verify our error handling
-    service = Scopus2.new('service_id' => 'test_scopus2', 'api_key' => @@api_key, 'priority' => 0)
-    service.extend( Module.new do 
-      def scopus_query(request)
-        # malformed query meant to trigger an error from scopus
-        "DOI("
-      end
-    end)
-
-    umlaut_request = make_umlaut_request("/resolve?sid=google&atitle=adfadfadf&title=adfadf&volume=4900&issue=700&date=1900&spage=93900&issn=0012-3706")
-    service.handle_wrapper(umlaut_request)
-
-    assert_empty umlaut_request.service_responses
-
-    dispatch = umlaut_request.dispatched_services.find {|ds| ds.service_id == service.service_id}
-    assert_present dispatch
-    assert_equal DispatchedService::FailedFatal, dispatch.status
-  end
-
-end

data/test/unit/service_response_test.rb

@@ -1,68 +0,0 @@
-require File.dirname(__FILE__) + '/../test_helper'
-
-class ServiceResponseTest < ActiveSupport::TestCase
-
-  def test_view_data
-    sr = ServiceResponse.new
-    sr.take_key_values(
-      :service_id => "DummyService",
-      :display_text => "Display text",
-      :notes => "notes",
-      :my_own_key => "my_own_key",
-      :service_type_value => :fulltext
-    )
-
-    assert_equal "Display text", sr.view_data[:display_text]
-    assert_equal "Display text", sr.view_data['display_text']
-
-    assert_equal "notes", sr.view_data[:notes]
-    assert_equal "notes", sr.view_data["notes"]
-
-    assert_equal "my_own_key", sr.view_data[:my_own_key]
-    assert_equal "my_own_key", sr.view_data['my_own_key']
-
-    assert sr.view_data[:service_type_value].present?
-    assert_equal "fulltext", sr.view_data[:service_type_value]
-  end
-
-  # A service that does nothing!
-  class DummyService < Service
-    def handle(request)
-      return request.dispatched(self, true)
-    end
-
-    # Optional method for display-time transformations
-    # of view_datahash
-    def transform_view_data(hash)
-      hash[:added_by_transform_view_data] = "added by transform"
-      return hash
-    end
-  end
-
-  def test_view_data_i18n
-    I18n.backend.store_translations("en", 
-        {"umlaut" => 
-          {"services" => 
-            { "service_response_test/dummy_service" => 
-                {"localized_text" => "localized text value"},
-            }
-          }
-        }
-      )
-
-    I18n.with_locale("en") do
-      sr = ServiceResponse.new
-      sr.instance_variable_set("@service", DummyService.new({'service_id' => "dummy", 'priority' => '3'}))      
-      sr.take_key_values(:display_text => "raw text", :display_text_i18n => "localized_text")
-
-      assert_equal "localized text value", sr.view_data[:display_text]
-    end
-  end
-
-  def test_transform_view_data
-    sr = ServiceResponse.new
-    sr.instance_variable_set("@service", DummyService.new({'service_id' => "dummy", 'priority' => '3'}))      
-    assert_equal "added by transform", sr.view_data[:added_by_transform_view_data]      
-  end
-
-end

data/test/unit/service_store_test.rb

@@ -1,47 +0,0 @@
-require 'test_helper'
-class ServiceStoreTest < ActiveSupport::TestCase
-  setup :reset_service_store
-  teardown :reset_service_store, :force_lazy_load_service_store
-  
-
-  test "missing umlaut services yaml" do
-    FileUtils.mv(File.join(Rails.root, "config", "umlaut_services.yml"), File.join(Rails.root, "config", "umlaut_services.yml.moved"))
-    assert_nothing_raised{ ServiceStore.config }
-    FileUtils.mv(File.join(Rails.root, "config", "umlaut_services.yml.moved"), File.join(Rails.root, "config", "umlaut_services.yml"))
-  end
-
-  test "group added to service" do
-    sfx_definition = ServiceStore.service_definition_for("SFX")
-    assert_equal("default", sfx_definition["group"])
-    assert_equal("default", ServiceStore.instantiate_service!(sfx_definition, nil).group)
-  end
-
-  test "manually set services" do
-    # force original from disk  to load
-    ServiceStore.config 
-    ServiceStore.service_definitions
-
-    # But then set our own instead
-    ServiceStore.config = {
-      "default" => {
-        "services" => {
-          "dummy" => {"type" => "DummyService", "priority" => 3}
-        }
-      }
-    }
-
-    assert_length 1, ServiceStore.service_definitions
-    assert_present ServiceStore.service_definition_for("dummy")
-  end
-
-  
-  def reset_service_store
-    ServiceStore.reset!    
-  end
-  def force_lazy_load_service_store
-    ServiceStore.config
-    ServiceStore.service_definitions
-  end
-
-
-end