umlaut 4.0.0.beta3 → 4.0.0.beta4

data/test/unit/dispatched_service_test.rb

@@ -1,16 +0,0 @@
-require 'test_helper'
-
-class DispatchedServiceTest < ActiveSupport::TestCase
-
-  def test_can_generate_service_types
-    request = fake_umlaut_request("?title=foo")
-    ds      = DispatchedService.new(:service_id => "Ulrichs")
-    assert_equal ServiceStore.instantiate_service!("Ulrichs", request).service_types_generated, ds.can_generate_service_types
-  end
-
-  def test_can_generate_service_types_with_bum_service
-    ds = DispatchedService.new(:service_id => "no_such_service")
-    assert_equal [], ds.can_generate_service_types
-  end
-
-end

data/test/unit/dissertation_catch_test.rb

@@ -1,21 +0,0 @@
-require 'test_helper'
-
-require 'referent'
-require 'dissertation_catch'
-
-
-class DissertationCatchTest <  ActiveSupport::TestCase
-  # this was a regression
-  def test_blank_atitle
-    context_object = OpenURL::ContextObject.new_from_kev("atitle=&title=Between+Us+and+Artistic+Appreciation%3a+Nabokov+and+the+Problem+of+Distortion&issn=04194209")
-
-    referent       = Referent.new
-    referent.set_values_from_context_object(context_object)
-    referent.save!
-    referent.referent_values(true) # reload
-
-    DissertationCatch.new.filter(referent)
-
-    assert_equal "Between Us and Artistic Appreciation: Nabokov and the Problem of Distortion", referent.metadata['title']    
-  end
-end

data/test/unit/feedback_mailer_test.rb

@@ -1,57 +0,0 @@
-
-
-require 'test_helper'
- 
-class FeedbackMailerTest < ActionMailer::TestCase
-  setup do 
-    ActionMailer::Base.deliveries.clear
-
-    @host       = "umlaut.example.org"
-    @to_email   = "librarian@example.org"
-  end
-
-  test "feedback" do
-    umlaut_request = fake_umlaut_request("/resolve?sid=google&auinit=S&aulast=Madsbad&atitle=Mechanisms+of+changes+in+glucose+metabolism+and+bodyweight+after+bariatric+surgery&id=doi:10.1016/S2213-8587(13)70218-3&title=The+Lancet+Diabetes+%26+Endocrinology&volume=2&issue=2&date=2014&spage=152&issn=2213-8587")
-
-    feedback_name  = "Joe Example"
-    feedback_email = "joe@example.org"
-    feedback_text = "This is my feedback, yes it is"
-
-    email = FeedbackMailer.feedback(@host, @to_email, :umlaut_request => umlaut_request, :name => feedback_name, :email => feedback_email, :feedback => feedback_text).deliver
-
-    assert ActionMailer::Base.deliveries.present?
-    assert_equal [UmlautController.umlaut_config.from_email_addr], email.from
-    assert_equal [feedback_email],           email.reply_to
-    assert_equal [@to_email],       email.to
-    assert_equal "#{UmlautController.umlaut_config.app_name} Feedback: #{feedback_name}", email.subject
-
-    assert_includes email.body, feedback_text
-
-    assert_includes email.body, "#{feedback_name} <#{feedback_email}>"
-    # citation
-    assert_includes email.body, "Mechanisms of changes in glucose metabolism and bodyweight"
-    assert_includes email.body, "Madsbad"
-    assert_includes email.body, "The Lancet Diabetes & Endocrinology"
-    assert_includes email.body, "Published: 2014  Vol: 2  Iss: 2  p. 152"
-    assert_includes email.body, "ISSN: 22138587"
-    assert_includes email.body, "10.1016/S2213-8587(13)70218-3" # doi
-
-    assert_includes email.body, "Original Source: #{umlaut_request.referrer_id}"
-
-    # Permalink properly generated and included
-    assert_present umlaut_request.referent.permalinks
-    assert_includes email.body, "Permalink: http"
-  end
-
-  test "feedback with no umlaut_request" do
-    feedback_name  = "Joe Example"
-    feedback_email = "joe@example.org"
-    feedback_text = "This is my feedback, yes it is"
-
-    email = FeedbackMailer.feedback(@host, @to_email, :name => feedback_name, :email => feedback_email, :feedback => feedback_text).deliver
-    # just no raise is good enough for this test for now, mostly
-
-    assert_includes email.body, "No citation supplied"
-  end
-
-end

data/test/unit/google_book_search_test.rb

@@ -1,56 +0,0 @@
-# tests for google book search service
-# Only the the simplest of tests are done so far. To do more advanced tests,
-# request fixtures for more cases should be created.
-require 'test_helper'
-class GoogleBookSearchTest < ActiveSupport::TestCase  
-  extend TestWithCassette
-  
-  def setup    
-    @gbs_default = ServiceStore.instantiate_service!("GoogleBookSearch", nil)
-    
-    @data_frankenstein = 
-      {"totalItems"=>1, "kind"=>"books#volumes", "items"=>[{"accessInfo"=>{"embeddable"=>true, "webReaderLink"=>"http://books.google.com/books/reader?id=QKgVAAAAYAAJ&as_pt=BOOKS&printsec=frontcover&output=reader&source=gbs_api", "epub"=>{"isAvailable"=>true, "downloadLink"=>"http://books.google.com/books/download/Frankenstein.epub?id=QKgVAAAAYAAJ&output=epub&source=gbs_api"}, "viewability"=>"ALL_PAGES", "publicDomain"=>true, "country"=>"US", "pdf"=>{"isAvailable"=>true, "downloadLink"=>"http://books.google.com/books/download/Frankenstein.pdf?id=QKgVAAAAYAAJ&output=pdf&sig=ACfU3U3nhOFhUroWh_b-nMaAulaAV6kjlw&source=gbs_api"}, "textToSpeechPermission"=>"ALLOWED", "accessViewStatus"=>"FULL_PUBLIC_DOMAIN"}, "searchInfo"=>{"textSnippet"=>"FRANKENSTEIN or The Modern Prometheus CHAPTER I. I Am by birth a Genevese; and <br>  my family is one of the most distinguished of that republic. My ancestors had <br>  been for many years counselors and syndics; and my father had filled several <b>...</b>"}, "etag"=>"TUqYf+e+c9k", "kind"=>"books#volume", "volumeInfo"=>{"infoLink"=>"http://books.google.com/books?id=QKgVAAAAYAAJ&dq=OCLC2364071&as_pt=BOOKS&source=gbs_api", "contentVersion"=>"0.0.1.0.full.3", "categories"=>["Fiction"], "title"=>"Frankenstein", "printType"=>"BOOK", "ratingsCount"=>279, "subtitle"=>"or, the Modern Prometheus", "previewLink"=>"http://books.google.com/books?id=QKgVAAAAYAAJ&printsec=frontcover&dq=OCLC2364071&as_pt=BOOKS&cd=1&source=gbs_api", "imageLinks"=>{"smallThumbnail"=>"http://bks6.books.google.com/books?id=QKgVAAAAYAAJ&printsec=frontcover&img=1&zoom=5&edge=curl&source=gbs_api", "thumbnail"=>"http://bks6.books.google.com/books?id=QKgVAAAAYAAJ&printsec=frontcover&img=1&zoom=1&edge=curl&source=gbs_api"}, "pageCount"=>332, "language"=>"en", "canonicalVolumeLink"=>"http://books.google.com/books/about/Frankenstein.html?id=QKgVAAAAYAAJ", "averageRating"=>4.0, "authors"=>["Mary Wollstonecraft Shelley"], "industryIdentifiers"=>[{"type"=>"OTHER", "identifier"=>"PRNC:32101064790353"}], "publishedDate"=>"1922"}, "saleInfo"=>{"isEbook"=>true, "saleability"=>"FREE", "country"=>"US"}, "id"=>"QKgVAAAAYAAJ", "selfLink"=>"https://www.googleapis.com/books/v1/volumes/QKgVAAAAYAAJ"}]}      
-    
-    @frankenstein_request = fake_umlaut_request("/resolve?isbn=9780393964585&oclcnum=33045872&aufirst=Mary&auinitm=Wollstonecraft&aulast=Shelley&btitle=Frankenstein+%3A+the+1818+text%2C+contexts%2C+nineteenth-century+responses%2C+modern+criticism&date=1997&edition=1st+ed.&genre=book&place=New+York&pub=W.W.+Norton")
-  end
-
-  def test_initialize_minimum
-    gbs = GoogleBookSearch.new({"priority"=>1})
-    assert_equal(1, gbs.priority)    
-    assert_equal('Google Books', gbs.display_name)
-    assert_equal(1, gbs.num_full_views)
-    assert_equal(1, gbs.priority)
-    assert_equal('standard', gbs.task)
-  end
-  
-  def test_get_bibkeys    
-    keys = @gbs_default.get_bibkeys(@frankenstein_request.referent)
-    expected = CGI.escape('isbn:9780393964585 OR "OCLC33045872"')
-    assert_equal(expected, keys)
-  end
-
-  # Actually a live test of GBS server, not great, but oh well. 
-  # This doesn't check much of the response, but just enough to know we got
-  # something back. The server for the thumbnail changes, so we can't do a 
-  # simple match and a huge regexp was making my head hurt.
-  # UPDATE: Use VCR to provide a deterministic GBS search.
-  # TODO: Check more of the response
-  test_with_cassette("frankenstein by OCLC number", :google_book_search) do
-    hashified_response = @gbs_default.do_query('OCLC2364071', @frankenstein_request)
-    assert_not_nil hashified_response
-    assert_not_nil hashified_response["totalItems"]
-    assert_operator hashified_response["totalItems"], :>, 0 
-  end
-
-  def test_create_fulltext_service_response
-    # frankenstein's got fulltext now.     
-    fulltext_shown = 
-      @gbs_default.create_fulltext_service_response(@frankenstein_request, @data_frankenstein)
-    assert(fulltext_shown)
-  end
-
-  def test_find_thumbnail_url
-    url = @gbs_default.find_thumbnail_url(@data_frankenstein)
-    assert_not_nil url
-  end
-end

data/test/unit/google_scholar_link_test.rb

@@ -1,81 +0,0 @@
-require 'test_helper'
-
-
-class GoogleScholarLinkTest < ActiveSupport::TestCase
-  extend TestWithCassette
-  
-  # TODO: Fix up umlaut to make it easier to create request/referent
-  # objects for testing!  
-  def build_request(format, hash = {})
-    context_object = OpenURL::ContextObject.new
-    context_object.referent.set_format(format) if format
-    
-    hash.each_pair do |key, value|    
-      context_object.referent.set_metadata(key.to_s, value.to_s)
-    end
-    
-    rft = Referent.create_by_context_object(context_object)
-    
-    req = Request.new
-    req.referent = rft
-    req.save!
-    
-    return req
-  end
-  
-  def setup
-    @service = GoogleScholarLink.new({"priority" => 3, "service_id" => "GoogleScholarLink"})
-  end
-  
-  def test_insufficient_metadata
-    title_level = build_request("journal", :jtitle => "foo", :issn => "12345678")
-    
-    assert ! @service.should_link_out_to?(title_level)
-        
-    no_author = build_request("article", :issn => "12345678", :spage => "12", :volume => "2", :issue => "2", :atitle => "Some Article")
-    
-    assert ! @service.should_link_out_to?(no_author)        
-  end
-  
-  def test_sufficient_metadata
-    proceeding = build_request("journal", :atitle => "Human-Machine Collaborative Planning",
-      :au => "Allen, James F.", :aufirst => "James", :auinitm => "F", :aulast => "Allen",
-      :epage => "29", :genre => "proceeding", :spage => "27")    
-    assert @service.should_link_out_to?(proceeding)
-    
-    article_little_metadata = build_request("journal", :genre => "article", :atitle => "Foo", :au => "Smith")    
-    assert @service.should_link_out_to?(article_little_metadata)
-
-    generic_with_article_level = build_request("journal", :atitle => "foo", 
-      :au => "Smith", :issn => "12345678", :volume => "2", :issue => "2", :spage => "12")
-    assert @service.should_link_out_to?(generic_with_article_level)    
-  end
-  
-  def test_query
-    aulast = build_request("journal", :atitle => "Human-Machine Collaborative Planning",
-      :aulast => "Allen", :au => "Ignore this", :genre => "article")    
-    assert_equal "allintitle: \"Human-Machine Collaborative Planning\" author:Allen", @service.construct_query(aulast)
-    
-    au_only = build_request("journal", :atitle => "Human-Machine Collaborative Planning",
-      :au => "Allen, James P.", :genre => "article")
-    assert_equal "allintitle: \"Human-Machine Collaborative Planning\" author:Allen author:James", @service.construct_query(au_only)        
-  end
-  
-  test_with_cassette("live make a link", :google_scholar_link) do
-    request = build_request("journal", :atitle => "Human-Machine Collaborative Planning",
-      :aulast => "Allen", :au => "Ignore this", :genre => "article")
-    
-    @service.handle(request)
-    
-    assert_present request.service_responses    
-  end
-  
-  test_with_cassette("live no link", :google_scholar_link) do
-    request = build_request("journal", :jtitle => "foo", :issn => "12345678")
-
-    @service.handle(request)
-    
-    assert_blank request.service_responses
-  end
-  
-end

data/test/unit/illiad_test.rb

@@ -1,146 +0,0 @@
-require 'test_helper'
-require 'uri'
-
-class IlliadTest < ActiveSupport::TestCase
-
-  def setup
-    @service       = Illiad.new('service_id' => 'test_illiad', 'base_url' => 'http://example.org/illiad.dll/OpenURL', 'priority' => 0)
-  end
-
-  def make_test_request(params)  
-    # hard to figure out how to mock a request, this seems to work
-    ActionController::TestRequest.new(Rack::MockRequest.env_for("?#{params.to_query}"))    
-  end
-
-  def execute_service(params)
-    rails_request = make_test_request(params)
-    umlaut_request = Request.find_or_create(params, {}, rails_request)
-    @service.handle_wrapper(umlaut_request)
-    return umlaut_request
-  end
-
-  def parsed_params_from_first_response(umlaut_request)
-    response = umlaut_request.service_responses.first
-    target_url = response.url
-    target_url =~ %r{\Ahttp://example.org/illiad.dll/OpenURL\?(.*)\Z}
-    query_string = $1
-    out_params = CGI.parse(query_string)
-
-    return out_params
-  end
-
-  def test_basic_case
-    params = {
-      'sid'     => 'SomeSource',
-      'genre'   => 'article',
-      'aulast'  => 'Smith',
-      'aufirst' => 'John',
-      'au'      => 'Smith, Johnny, Jr., Esq.',
-      'volume'  => '100',
-      'issue'   => '1',
-      'spage'   => '500',
-      'epage'   => '505',
-      'pages'   => 'do not use',
-      'issn'    => '12345678',
-      'jtitle'  => 'Journal Of Lots Of Things',
-      'stitle'  => 'J L Things',
-      'atitle'  => 'Article Title',
-      'date'    => '2011-05-12',
-      'pub'     => 'Johnson Publishing',
-      'place'   => 'Baltimore, MD',
-      'edition' => '1st ed.'
-    }
-
-    umlaut_request = execute_service(params)
-    
-
-    assert_length 1, umlaut_request.service_responses
-
-    response = umlaut_request.service_responses.first
-
-    assert_equal "document_delivery", response.service_type_value_name
-
-    target_url = response.url
-    assert_present target_url
-    assert_match %r{\Ahttp://example.org/illiad.dll/OpenURL\?(.*)\Z}, target_url
-
-
-    target_url =~ %r{\Ahttp://example.org/illiad.dll/OpenURL\?(.*)\Z}
-    query_string = $1
-    out_params = CGI.parse(query_string)
-    
-    assert_equal ['SomeSource (via Umlaut)'], out_params['sid']
-
-    # Ones that just get passed through
-    ['genre', 'aulast', 'aufirst', 'volume', 'issue', 'spage', 'epage', 
-      'issn', 'stitle', 'atitle'].each do |key|
-        assert_equal [params[key]], out_params[key]
-    end
-
-    assert_equal ['2011'], out_params['year']
-    assert_equal ['05'], out_params['month']
-
-    assert_equal [params['jtitle']], out_params['title']
-
-    assert_equal [params['pub']], out_params['rft.pub']
-    assert_equal [params['place']], out_params['rft.place']
-    assert_equal [params['edition']], out_params['rft.edition']
-
-    assert_empty out_params['au']
-  end
-
-  def test_genre_dissertation_normalize    
-    params = {
-      'rft_val_fmt'=> 'info:ofi/fmt:kev:mtx:dissertation',
-      'title' => 'our title',
-      'au' => 'our author'
-    }
-    umlaut_request = execute_service(params)
-    out_params = parsed_params_from_first_response(umlaut_request)  
-
-    assert_equal ['dissertation'], out_params['genre']
-    assert_equal ['our title'], out_params['title']
-    assert_equal ['our author'], out_params['au']
-  end
-
-  def test_genre_bookitem_normalize
-    params = {
-      'genre' => 'book',
-      'atitle' => 'Chapter Title',
-      'title' => 'Book Title',
-      'isbn'  => '978-3-16-148410-0'
-    }
-    umlaut_request = execute_service(params)
-    out_params = parsed_params_from_first_response(umlaut_request)  
-
-    assert_equal ['bookitem'], out_params['genre']
-    assert_equal [params['atitle']], out_params['atitle']
-    assert_equal [params['title']], out_params['title']
-    assert_equal [params['isbn']], out_params['isbn']
-  end
-
-  def test_genre_force_issn_article
-    params = {
-      'atitle' => "A title",
-      'jtitle' => 'Journal Title',
-      'issn'  => '12345678'
-    }
-
-    umlaut_request = execute_service(params)
-    out_params = parsed_params_from_first_response(umlaut_request)  
-
-    assert_equal ['article'], out_params['genre']
-  end
-
-  def test_genre_force_book
-    params = {
-      'title' => 'DVD Title?',
-      'genre' => 'unknown',
-      'isbn' => '978-3-16-148410-0'
-    }
-    umlaut_request = execute_service(params)
-    out_params = parsed_params_from_first_response(umlaut_request)  
-
-    assert_equal ['book'], out_params['genre']
-  end
-end

data/test/unit/internet_archive_test.rb

@@ -1,34 +0,0 @@
-# tests for internet archive service
-# Only the the simplest of tests are done so far. To do more advanced tests,
-# request fixtures for more cases should be created.
-require 'test_helper'
-class InternetArchiveTest < ActiveSupport::TestCase  
-  extend TestWithCassette
-
-  def setup    
-    @ia_default = ServiceStore.instantiate_service!("InternetArchive", nil)
-  end
-
-  test_with_cassette("momo by title author", :internet_archive) do    
-    request = fake_umlaut_request("/resolve?isbn=038519093X&aufirst=Michael&aulast=Ende&btitle=Momo&genre=book&isbn=038519093X&pub=Doubleday")
-    
-    # Clear out the current responses.
-    request.service_responses.each do |service_response|
-      service_response.destroy
-    end
-    @ia_default.handle(request)
-    request.referent.referent_values.reset
-    request.dispatched_services.reset
-    request.service_responses.reset
-    fulltexts = request.get_service_type('fulltext')
-    assert((not fulltexts.empty?), "IA didn't return any fulltext")
-    assert_equal(1, fulltexts.length, "IA returned an unexpected number of fulltexts")
-    fulltext = fulltexts.first
-    assert_equal("http://archive.org/details/MomoOvveroLarcanaStoriaDeiLadriDiTempoEDellaBambinaCheRestitu", 
-      fulltext.url, "IA Service constructed an unexpected URL")
-    view_data = fulltext.view_data
-    assert((not view_data.nil?), "IA full text view data is nil")
-
-    assert_equal("the Internet Archive: Open Source Books", view_data[:display_text], "IA display text is unexpected")
-  end
-end

data/test/unit/metadata_helper_test.rb

@@ -1,49 +0,0 @@
-# Doesn't yet cover everything, but started it to cover new func we wrote at least
-
-require 'test_helper'
-class MetadataHelperTest < ActiveSupport::TestCase  
-  include MetadataHelper
-
-  ContextObject = OpenURL::ContextObject
-
-
-  def test_get_month    
-    co = ContextObject.new_from_kev("date=2012-9-01&foo=bar")
-    assert_equal "9", get_month(co.referent)
-
-    co = ContextObject.new_from_kev("date=2012-10-01&foo=bar")
-    assert_equal "10", get_month(co.referent)
-
-    co = ContextObject.new_from_kev("date=2012-10&foo=bar")
-    assert_equal "10", get_month(co.referent)
-
-    co = ContextObject.new_from_kev("date=2012-10-01&month=9")
-    assert_equal "10", get_month(co.referent)
-
-    # If no date, try non-standard month
-    co = ContextObject.new_from_kev("month=9&foo=bar")
-    assert_equal "9", get_month(co.referent)
-  end
-
-  def test_get_spage
-    co = ContextObject.new_from_kev("spage=20&epage=22&pages=unused&foo=bar")
-    assert_equal "20", get_spage(co.referent)
-
-    co = ContextObject.new_from_kev("pages=20+-+22&foo=bar")
-    assert_equal "20", get_spage(co.referent)
-
-    co = ContextObject.new_from_kev("pages=20&foo=bar")
-    assert_equal "20", get_spage(co.referent)
-  end
-
-  def test_get_epage
-    co = ContextObject.new_from_kev("spage=20&epage=22&pages=unused&foo=bar")
-    assert_equal "22", get_epage(co.referent)
-
-    co = ContextObject.new_from_kev("pages=20+-+22&foo=bar")
-    assert_equal "22", get_epage(co.referent)
-
-    co = ContextObject.new_from_kev("pages=20&foo=bar")
-    assert_equal "20", get_epage(co.referent)
-  end
-end