twitter 4.8.1 → 5.0.0.rc.1

data/spec/twitter/media_factory_spec.rb

@@ -4,11 +4,11 @@ describe Twitter::MediaFactory do
 
   describe ".new" do
     it "generates a Photo" do
-      media = Twitter::MediaFactory.fetch_or_new(:id => 1, :type => 'photo')
+      media = Twitter::MediaFactory.new(:id => 1, :type => "photo")
       expect(media).to be_a Twitter::Media::Photo
     end
     it "raises an ArgumentError when type is not specified" do
-      expect{Twitter::MediaFactory.fetch_or_new}.to raise_error ArgumentError
+      expect{Twitter::MediaFactory.new}.to raise_error ArgumentError
     end
   end
 

data/spec/twitter/null_object_spec.rb

@@ -0,0 +1,26 @@
+require 'helper'
+
+describe Twitter::NullObject do
+
+  describe "#nil?" do
+    it "returns true" do
+      null_object = Twitter::NullObject.instance
+      expect(null_object.null?).to be_true
+    end
+  end
+
+  describe "calling any method" do
+    it "returns self" do
+      null_object = Twitter::NullObject.instance
+      expect(null_object.any).to equal null_object
+    end
+  end
+
+  describe "#respond_to?" do
+    it "returns true" do
+      null_object = Twitter::NullObject.instance
+      expect(null_object.respond_to?(:any)).to be_true
+    end
+  end
+
+end

data/spec/twitter/oembed_spec.rb

@@ -2,24 +2,34 @@ require 'helper'
 
 describe Twitter::OEmbed do
 
-  describe "#author_url" do
-    it "returns the author's url" do
-      oembed = Twitter::OEmbed.new(:author_url => 'https://twitter.com/sferik')
-      expect(oembed.author_url).to eq "https://twitter.com/sferik"
+  describe "#author_uri" do
+    it "returns a URI when the author_url is set" do
+      oembed = Twitter::OEmbed.new(:author_url => "https://twitter.com/sferik")
+      expect(oembed.author_uri).to be_a URI
+      expect(oembed.author_uri.to_s).to eq("https://twitter.com/sferik")
     end
+    it "returns nil when the author_uri is not set" do
+      oembed = Twitter::OEmbed.new
+      expect(oembed.author_uri).to be_nil
+    end
+  end
 
-    it "returns nil when not set" do
-      author_url = Twitter::OEmbed.new.author_url
-      expect(author_url).to be_nil
+  describe "#author_uri?" do
+    it "returns true when the author_url is set" do
+      oembed = Twitter::OEmbed.new(:author_url => "https://twitter.com/sferik")
+      expect(oembed.author_uri?).to be_true
+    end
+    it "returns false when the author_uri is not set" do
+      oembed = Twitter::OEmbed.new
+      expect(oembed.author_uri?).to be_false
     end
   end
 
   describe "#author_name" do
     it "returns the author's name" do
-      oembed = Twitter::OEmbed.new(:author_name => 'Erik Michaels-Ober')
-      expect(oembed.author_name).to eq "Erik Michaels-Ober"
+      oembed = Twitter::OEmbed.new(:author_name => "Erik Michaels-Ober")
+      expect(oembed.author_name).to eq("Erik Michaels-Ober")
     end
-
     it "returns nil when not set" do
       author_name = Twitter::OEmbed.new.author_name
       expect(author_name).to be_nil
@@ -28,10 +38,9 @@ describe Twitter::OEmbed do
 
   describe "#cache_age" do
     it "returns the cache_age" do
-      oembed = Twitter::OEmbed.new(:cache_age => '31536000000')
-      expect(oembed.cache_age).to eq "31536000000"
+      oembed = Twitter::OEmbed.new(:cache_age => "31536000000")
+      expect(oembed.cache_age).to eq("31536000000")
     end
-
     it "returns nil when not set" do
       cache_age = Twitter::OEmbed.new.cache_age
       expect(cache_age).to be_nil
@@ -41,14 +50,12 @@ describe Twitter::OEmbed do
   describe "#height" do
     it "returns the height" do
       oembed = Twitter::OEmbed.new(:height => 200)
-      expect(oembed.height).to eq 200
+      expect(oembed.height).to eq(200)
     end
-
     it "returns it as an Integer" do
       oembed = Twitter::OEmbed.new(:height => 200)
       expect(oembed.height).to be_an Integer
     end
-
     it "returns nil when not set" do
       height = Twitter::OEmbed.new.height
       expect(height).to be_nil
@@ -57,10 +64,9 @@ describe Twitter::OEmbed do
 
   describe "#html" do
     it "returns the html" do
-      oembed = Twitter::OEmbed.new(:html => '<blockquote>all my <b>witty tweet</b> stuff here</blockquote>')
-      expect(oembed.html).to eq "<blockquote>all my <b>witty tweet</b> stuff here</blockquote>"
+      oembed = Twitter::OEmbed.new(:html => "<blockquote>all my <b>witty tweet</b> stuff here</blockquote>")
+      expect(oembed.html).to eq("<blockquote>all my <b>witty tweet</b> stuff here</blockquote>")
     end
-
     it "returns nil when not set" do
       html = Twitter::OEmbed.new.html
       expect(html).to be_nil
@@ -69,34 +75,43 @@ describe Twitter::OEmbed do
 
   describe "#provider_name" do
     it "returns the provider_name" do
-      oembed = Twitter::OEmbed.new(:provider_name => 'Twitter')
-      expect(oembed.provider_name).to eq "Twitter"
+      oembed = Twitter::OEmbed.new(:provider_name => "Twitter")
+      expect(oembed.provider_name).to eq("Twitter")
     end
-
     it "returns nil when not set" do
       provider_name = Twitter::OEmbed.new.provider_name
       expect(provider_name).to be_nil
     end
   end
 
-  describe "#provider_url" do
-    it "returns the provider_url" do
-      oembed = Twitter::OEmbed.new(:provider_url => 'http://twitter.com')
-      expect(oembed.provider_url).to eq "http://twitter.com"
+  describe "#provider_uri" do
+    it "returns a URI when the provider_url is set" do
+      oembed = Twitter::OEmbed.new(:provider_url => "http://twitter.com")
+      expect(oembed.provider_uri).to be_a URI
+      expect(oembed.provider_uri.to_s).to eq("http://twitter.com")
+    end
+    it "returns nil when the provider_uri is not set" do
+      oembed = Twitter::OEmbed.new
+      expect(oembed.provider_uri).to be_nil
     end
+  end
 
-    it "returns nil when not set" do
-      provider_url = Twitter::OEmbed.new.provider_url
-      expect(provider_url).to be_nil
+  describe "#provider_uri?" do
+    it "returns true when the provider_url is set" do
+      oembed = Twitter::OEmbed.new(:provider_url => "https://twitter.com/sferik")
+      expect(oembed.provider_uri?).to be_true
+    end
+    it "returns false when the provider_uri is not set" do
+      oembed = Twitter::OEmbed.new
+      expect(oembed.provider_uri?).to be_false
     end
   end
 
   describe "#type" do
     it "returns the type" do
-      oembed = Twitter::OEmbed.new(:type => 'rich')
-      expect(oembed.type).to eq "rich"
+      oembed = Twitter::OEmbed.new(:type => "rich")
+      expect(oembed.type).to eq("rich")
     end
-
     it "returns nil when not set" do
       type = Twitter::OEmbed.new.type
       expect(type).to be_nil
@@ -106,41 +121,50 @@ describe Twitter::OEmbed do
   describe "#width" do
     it "returns the width" do
       oembed = Twitter::OEmbed.new(:width => 550)
-      expect(oembed.width).to eq 550
+      expect(oembed.width).to eq(550)
     end
-
     it "returns it as an Integer" do
       oembed = Twitter::OEmbed.new(:width => 550)
       expect(oembed.width).to be_an Integer
     end
-
     it "returns nil when not set" do
       width = Twitter::OEmbed.new.width
       expect(width).to be_nil
     end
   end
 
-  describe "#url" do
-    it "returns the url" do
-      oembed = Twitter::OEmbed.new(:url => 'https://twitter.com/twitterapi/status/133640144317198338')
-      expect(oembed.url).to eq "https://twitter.com/twitterapi/status/133640144317198338"
+  describe "#uri" do
+    it "returns a URI when the url is set" do
+      oembed = Twitter::OEmbed.new(:url => "https://twitter.com/twitterapi/status/133640144317198338")
+      expect(oembed.uri).to be_a URI
+      expect(oembed.uri.to_s).to eq("https://twitter.com/twitterapi/status/133640144317198338")
+    end
+    it "returns nil when the url is not set" do
+      oembed = Twitter::OEmbed.new
+      expect(oembed.uri).to be_nil
     end
+  end
 
-    it "returns nil when not set" do
-      url = Twitter::OEmbed.new.url
-      expect(url).to be_nil
+  describe "#uri?" do
+    it "returns true when the url is set" do
+      oembed = Twitter::OEmbed.new(:url => "https://twitter.com/twitterapi/status/133640144317198338")
+      expect(oembed.uri?).to be_true
+    end
+    it "returns false when the url is not set" do
+      oembed = Twitter::OEmbed.new
+      expect(oembed.uri?).to be_false
     end
   end
 
   describe "#version" do
     it "returns the version" do
-      oembed = Twitter::OEmbed.new(:version => '1.0')
-      expect(oembed.version).to eq "1.0"
+      oembed = Twitter::OEmbed.new(:version => "1.0")
+      expect(oembed.version).to eq("1.0")
     end
-
     it "returns nil when not set" do
       version = Twitter::OEmbed.new.version
       expect(version).to be_nil
     end
   end
+
 end

data/spec/twitter/place_spec.rb

@@ -21,24 +21,57 @@ describe Twitter::Place do
   end
 
   describe "#bounding_box" do
-    it "returns a Twitter::Place when set" do
-      place = Twitter::Place.new(:id => "247f43d441defc03", :bounding_box => {:type => 'Polygon', :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
+    it "returns a Twitter::Geo when bounding_box is set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03", :bounding_box => {:type => "Polygon", :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
       expect(place.bounding_box).to be_a Twitter::Geo::Polygon
     end
-    it "returns nil when not set" do
+    it "returns nil when not bounding_box is not set" do
       place = Twitter::Place.new(:id => "247f43d441defc03")
       expect(place.bounding_box).to be_nil
     end
   end
 
+  describe "#bounding_box?" do
+    it "returns true when bounding_box is set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03", :bounding_box => {:type => "Polygon", :coordinates => [[[-122.40348192, 37.77752898], [-122.387436, 37.77752898], [-122.387436, 37.79448597], [-122.40348192, 37.79448597]]]})
+      expect(place.bounding_box?).to be_true
+    end
+    it "returns false when bounding_box is not set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03")
+      expect(place.bounding_box?).to be_false
+    end
+  end
+
+  describe "#contained_within" do
+    it "returns a Twitter::Place when contained_within is set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03", :contained_within => {:id => "247f43d441defc04"})
+      expect(place.contained_within).to be_a Twitter::Place
+    end
+    it "returns nil when not contained_within is not set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03")
+      expect(place.contained_within).to be_nil
+    end
+  end
+
+  describe "#contained_within?" do
+    it "returns true when contained_within is set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03", :contained_within => {:id => "247f43d441defc04"})
+      expect(place.contained?).to be_true
+    end
+    it "returns false when contained_within is not set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03")
+      expect(place.contained?).to be_false
+    end
+  end
+
   describe "#country_code" do
     it "returns a country code when set with country_code" do
-      place = Twitter::Place.new(:id => "247f43d441defc03", :country_code => 'US')
-      expect(place.country_code).to eq 'US'
+      place = Twitter::Place.new(:id => "247f43d441defc03", :country_code => "US")
+      expect(place.country_code).to eq("US")
     end
     it "returns a country code when set with countryCode" do
-      place = Twitter::Place.new(:id => "247f43d441defc03", :countryCode => 'US')
-      expect(place.country_code).to eq 'US'
+      place = Twitter::Place.new(:id => "247f43d441defc03", :countryCode => "US")
+      expect(place.country_code).to eq("US")
     end
     it "returns nil when not set" do
       place = Twitter::Place.new(:id => "247f43d441defc03")
@@ -49,7 +82,7 @@ describe Twitter::Place do
   describe "#parent_id" do
     it "returns a parent ID when set with parentid" do
       place = Twitter::Place.new(:id => "247f43d441defc03", :parentid => 1)
-      expect(place.parent_id).to eq 1
+      expect(place.parent_id).to eq(1)
     end
     it "returns nil when not set" do
       place = Twitter::Place.new(:id => "247f43d441defc03")
@@ -59,12 +92,12 @@ describe Twitter::Place do
 
   describe "#place_type" do
     it "returns a place type when set with place_type" do
-      place = Twitter::Place.new(:id => "247f43d441defc03", :place_type => 'city')
-      expect(place.place_type).to eq 'city'
+      place = Twitter::Place.new(:id => "247f43d441defc03", :place_type => "city")
+      expect(place.place_type).to eq("city")
     end
     it "returns a place type when set with placeType[name]" do
-      place = Twitter::Place.new(:id => "247f43d441defc03", :placeType => {:name => 'Town'})
-      expect(place.place_type).to eq 'Town'
+      place = Twitter::Place.new(:id => "247f43d441defc03", :placeType => {:name => "Town"})
+      expect(place.place_type).to eq("Town")
     end
     it "returns nil when not set" do
       place = Twitter::Place.new(:id => "247f43d441defc03")
@@ -72,4 +105,27 @@ describe Twitter::Place do
     end
   end
 
+  describe "#uri" do
+    it "returns a URI when the url is set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03", :url => "https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
+      expect(place.uri).to be_a URI
+      expect(place.uri.to_s).to eq("https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
+    end
+    it "returns nil when the url is not set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03")
+      expect(place.uri).to be_nil
+    end
+  end
+
+  describe "#uri?" do
+    it "returns true when the url is set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03", :url => "https://api.twitter.com/1.1/geo/id/247f43d441defc03.json")
+      expect(place.uri).to be_true
+    end
+    it "returns false when the url is not set" do
+      place = Twitter::Place.new(:id => "247f43d441defc03")
+      expect(place.uri).to be_false
+    end
+  end
+
 end

data/spec/twitter/profile_banner_spec.rb

@@ -4,7 +4,7 @@ describe Twitter::ProfileBanner do
 
   describe "#sizes" do
     it "returns a hash of Sizes when sizes is set" do
-      sizes = Twitter::ProfileBanner.new(:sizes => {:small => {:h => 226, :w => 340, :resize => 'fit'}, :large => {:h => 466, :w => 700, :resize => 'fit'}, :medium => {:h => 399, :w => 600, :resize => 'fit'}, :thumb => {:h => 150, :w => 150, :resize => 'crop'}}).sizes
+      sizes = Twitter::ProfileBanner.new(:sizes => {:small => {:h => 226, :w => 340, :resize => "fit"}, :large => {:h => 466, :w => 700, :resize => "fit"}, :medium => {:h => 399, :w => 600, :resize => "fit"}, :thumb => {:h => 150, :w => 150, :resize => "crop"}}).sizes
       expect(sizes).to be_a Hash
       expect(sizes[:small]).to be_a Twitter::Size
     end

data/spec/twitter/rate_limit_spec.rb

@@ -4,9 +4,9 @@ describe Twitter::RateLimit do
 
   describe "#limit" do
     it "returns an Integer when x-rate-limit-limit header is set" do
-      rate_limit = Twitter::RateLimit.new('x-rate-limit-limit' => "150")
+      rate_limit = Twitter::RateLimit.new("x-rate-limit-limit" => "150")
       expect(rate_limit.limit).to be_an Integer
-      expect(rate_limit.limit).to eq 150
+      expect(rate_limit.limit).to eq(150)
     end
     it "returns nil when x-rate-limit-limit header is not set" do
       rate_limit = Twitter::RateLimit.new
@@ -16,9 +16,9 @@ describe Twitter::RateLimit do
 
   describe "#remaining" do
     it "returns an Integer when x-rate-limit-remaining header is set" do
-      rate_limit = Twitter::RateLimit.new('x-rate-limit-remaining' => "149")
+      rate_limit = Twitter::RateLimit.new("x-rate-limit-remaining" => "149")
       expect(rate_limit.remaining).to be_an Integer
-      expect(rate_limit.remaining).to eq 149
+      expect(rate_limit.remaining).to eq(149)
     end
     it "returns nil when x-rate-limit-remaining header is not set" do
       rate_limit = Twitter::RateLimit.new
@@ -28,9 +28,9 @@ describe Twitter::RateLimit do
 
   describe "#reset_at" do
     it "returns a Time when x-rate-limit-reset header is set" do
-      rate_limit = Twitter::RateLimit.new('x-rate-limit-reset' => "1339019097")
+      rate_limit = Twitter::RateLimit.new("x-rate-limit-reset" => "1339019097")
       expect(rate_limit.reset_at).to be_a Time
-      expect(rate_limit.reset_at).to eq Time.at(1339019097)
+      expect(rate_limit.reset_at).to eq(Time.at(1339019097))
     end
     it "returns nil when x-rate-limit-reset header is not set" do
       rate_limit = Twitter::RateLimit.new
@@ -46,9 +46,9 @@ describe Twitter::RateLimit do
       Timecop.return
     end
     it "returns an Integer when x-rate-limit-reset header is set" do
-      rate_limit = Twitter::RateLimit.new('x-rate-limit-reset' => "1339019097")
+      rate_limit = Twitter::RateLimit.new("x-rate-limit-reset" => "1339019097")
       expect(rate_limit.reset_in).to be_an Integer
-      expect(rate_limit.reset_in).to eq 15777
+      expect(rate_limit.reset_in).to eq(15777)
     end
     it "returns nil when x-rate-limit-reset header is not set" do
       rate_limit = Twitter::RateLimit.new
@@ -64,12 +64,12 @@ describe Twitter::RateLimit do
       Timecop.return
     end
     it "updates a rate limit" do
-      rate_limit = Twitter::RateLimit.new('x-rate-limit-reset' => "1339019097")
+      rate_limit = Twitter::RateLimit.new("x-rate-limit-reset" => "1339019097")
       expect(rate_limit.reset_in).to be_an Integer
-      expect(rate_limit.reset_in).to eq 15777
-      rate_limit.update({'x-rate-limit-reset' => "1339019098"})
+      expect(rate_limit.reset_in).to eq(15777)
+      rate_limit.update({"x-rate-limit-reset" => "1339019098"})
       expect(rate_limit.reset_in).to be_an Integer
-      expect(rate_limit.reset_in).to eq 15778
+      expect(rate_limit.reset_in).to eq(15778)
     end
   end
 

data/spec/twitter/relationship_spec.rb

@@ -4,23 +4,45 @@ describe Twitter::Relationship do
 
   describe "#source" do
     it "returns a User when source is set" do
-      source = Twitter::Relationship.new(:relationship => {:source => {:id => 7505382}}).source
-      expect(source).to be_a Twitter::SourceUser
+      relationship = Twitter::Relationship.new(:relationship => {:source => {:id => 7505382}})
+      expect(relationship.source).to be_a Twitter::SourceUser
     end
     it "returns nil when source is not set" do
-      source = Twitter::Relationship.new(:relationship => {}).source
-      expect(source).to be_nil
+      relationship = Twitter::Relationship.new(:relationship => {})
+      expect(relationship.source).to be_nil
+    end
+  end
+
+  describe "#source?" do
+    it "returns true when source is set" do
+      relationship = Twitter::Relationship.new(:relationship => {:source => {:id => 7505382}})
+      expect(relationship.source?).to be_true
+    end
+    it "returns false when source is not set" do
+      relationship = Twitter::Relationship.new(:relationship => {})
+      expect(relationship.source?).to be_false
     end
   end
 
   describe "#target" do
     it "returns a User when target is set" do
-      target = Twitter::Relationship.new(:relationship => {:target => {:id => 7505382}}).target
-      expect(target).to be_a Twitter::TargetUser
+      relationship = Twitter::Relationship.new(:relationship => {:target => {:id => 7505382}})
+      expect(relationship.target).to be_a Twitter::TargetUser
     end
     it "returns nil when target is not set" do
-      target = Twitter::Relationship.new(:relationship => {}).target
-      expect(target).to be_nil
+      relationship = Twitter::Relationship.new(:relationship => {})
+      expect(relationship.target).to be_nil
+    end
+  end
+
+  describe "#target?" do
+    it "returns true when target is set" do
+      relationship = Twitter::Relationship.new(:relationship => {:target => {:id => 7505382}})
+      expect(relationship.target?).to be_true
+    end
+    it "returns false when target is not set" do
+      relationship = Twitter::Relationship.new(:relationship => {})
+      expect(relationship.target?).to be_false
     end
   end
 
@@ -28,7 +50,7 @@ describe Twitter::Relationship do
     it "updates a relationship" do
       relationship = Twitter::Relationship.new(:relationship => {:target => {:id => 7505382}})
       relationship.update(:relationship => {:target => {:id => 14100886}})
-      expect(relationship.target.id).to eq 14100886
+      expect(relationship.target.id).to eq(14100886)
     end
   end