twitter 4.8.1 → 5.0.0.rc.1

data/spec/twitter/direct_message_spec.rb

@@ -31,25 +31,58 @@ describe Twitter::DirectMessage do
     end
   end
 
+  describe "#created?" do
+    it "returns true when created_at is set" do
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345, :created_at => "Mon Jul 16 12:59:01 +0000 2007")
+      expect(direct_message.created?).to be_true
+    end
+    it "returns false when created_at is not set" do
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345)
+      expect(direct_message.created?).to be_false
+    end
+  end
+
   describe "#recipient" do
     it "returns a User when recipient is set" do
-      recipient = Twitter::DirectMessage.new(:id => 1825786345, :recipient => {:id => 7505382}).recipient
-      expect(recipient).to be_a Twitter::User
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345, :recipient => {:id => 7505382})
+      expect(direct_message.recipient).to be_a Twitter::User
     end
     it "returns nil when recipient is not set" do
-      recipient = Twitter::DirectMessage.new(:id => 1825786345).recipient
-      expect(recipient).to be_nil
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345)
+      expect(direct_message.recipient).to be_nil
+    end
+  end
+
+  describe "#recipient?" do
+    it "returns true when recipient is set" do
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345, :recipient => {:id => 7505382})
+      expect(direct_message.recipient?).to be_true
+    end
+    it "returns false when recipient is not set" do
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345)
+      expect(direct_message.recipient?).to be_false
     end
   end
 
   describe "#sender" do
     it "returns a User when sender is set" do
-      sender = Twitter::DirectMessage.new(:id => 1825786345, :sender => {:id => 7505382}).sender
-      expect(sender).to be_a Twitter::User
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345, :sender => {:id => 7505382})
+      expect(direct_message.sender).to be_a Twitter::User
     end
     it "returns nil when sender is not set" do
-      sender = Twitter::DirectMessage.new(:id => 1825786345).sender
-      expect(sender).to be_nil
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345)
+      expect(direct_message.sender).to be_nil
+    end
+  end
+
+  describe "#sender?" do
+    it "returns true when sender is set" do
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345, :sender => {:id => 7505382})
+      expect(direct_message.sender?).to be_true
+    end
+    it "returns false when sender is not set" do
+      direct_message = Twitter::DirectMessage.new(:id => 1825786345)
+      expect(direct_message.sender?).to be_false
     end
   end
 

data/spec/twitter/entity/uri_spec.rb

@@ -0,0 +1,74 @@
+require 'helper'
+
+describe Twitter::Entity::URI do
+
+  describe "#display_uri" do
+    it "returns a URI when the display_url is set" do
+      uri = Twitter::Entity::URI.new(:display_url => "https://github.com/sferik")
+      expect(uri.display_uri).to be_a URI
+      expect(uri.display_uri.to_s).to eq("https://github.com/sferik")
+    end
+    it "returns nil when the display_url is not set" do
+      uri = Twitter::Entity::URI.new
+      expect(uri.display_uri).to be_nil
+    end
+  end
+
+  describe "#display_uri?" do
+    it "returns true when the display_url is set" do
+      uri = Twitter::Entity::URI.new(:display_url => "https://github.com/sferik")
+      expect(uri.display_uri).to be_true
+    end
+    it "returns false when the display_url is not set" do
+      uri = Twitter::Entity::URI.new
+      expect(uri.display_uri).to be_false
+    end
+  end
+
+  describe "#expanded_uri" do
+    it "returns a URI when the expanded_url is set" do
+      uri = Twitter::Entity::URI.new(:expanded_url => "https://github.com/sferik")
+      expect(uri.expanded_uri).to be_a URI
+      expect(uri.expanded_uri.to_s).to eq("https://github.com/sferik")
+    end
+    it "returns nil when the expanded_url is not set" do
+      uri = Twitter::Entity::URI.new
+      expect(uri.expanded_uri).to be_nil
+    end
+  end
+
+  describe "#expanded_uri?" do
+    it "returns true when the expanded_url is set" do
+      uri = Twitter::Entity::URI.new(:expanded_url => "https://github.com/sferik")
+      expect(uri.expanded_uri).to be_true
+    end
+    it "returns false when the expanded_url is not set" do
+      uri = Twitter::Entity::URI.new
+      expect(uri.expanded_uri).to be_false
+    end
+  end
+
+  describe "#uri" do
+    it "returns a URI when the url is set" do
+      uri = Twitter::Entity::URI.new(:url => "https://github.com/sferik")
+      expect(uri.uri).to be_a URI
+      expect(uri.uri.to_s).to eq("https://github.com/sferik")
+    end
+    it "returns nil when the url is not set" do
+      uri = Twitter::Entity::URI.new
+      expect(uri.uri).to be_nil
+    end
+  end
+
+  describe "#uri?" do
+    it "returns true when the url is set" do
+      uri = Twitter::Entity::URI.new(:url => "https://github.com/sferik")
+      expect(uri.uri).to be_true
+    end
+    it "returns false when the url is not set" do
+      uri = Twitter::Entity::URI.new
+      expect(uri.uri).to be_false
+    end
+  end
+
+end

data/spec/twitter/error_spec.rb

@@ -2,19 +2,67 @@ require 'helper'
 
 describe Twitter::Error do
 
-  describe "#initialize" do
-    it "wraps another error class" do
-      begin
-        raise Faraday::Error::ClientError.new("Oops")
-      rescue Faraday::Error::ClientError
-        begin
-          raise Twitter::Error
-        rescue Twitter::Error => error
-          expect(error.message).to eq "Oops"
-          expect(error.wrapped_exception.class).to eq Faraday::Error::ClientError
+  before do
+    @client = Twitter::REST::Client.new(:consumer_key => "CK", :consumer_secret => "CS", :access_token => "AT", :access_token_secret => "AS")
+  end
+
+  describe "#message" do
+    it "returns the message of the wrapped exception" do
+      error = Twitter::Error.new(Faraday::Error::ClientError.new("Oops"))
+      expect(error.message).to eq("Oops")
+    end
+  end
+
+  describe "#rate_limit" do
+    it "returns the wrapped exception" do
+      error = Twitter::Error.new(Faraday::Error::ClientError.new("Oops"))
+      expect(error.rate_limit).to be_a Twitter::RateLimit
+    end
+  end
+
+  describe "#wrapped_exception" do
+    it "returns the wrapped exception" do
+      error = Twitter::Error.new(Faraday::Error::ClientError.new("Oops"))
+      expect(error.wrapped_exception.class).to eq(Faraday::Error::ClientError)
+    end
+  end
+
+  Twitter::Error.errors.each do |status, exception|
+
+    [nil, "error", "errors"].each do |body|
+      context "when HTTP status is #{status} and body is #{body.inspect}" do
+        before do
+          body_message = '{"' + body + '":"Client Error"}' unless body.nil?
+          stub_get("/1.1/statuses/user_timeline.json").with(:query => {:screen_name => "sferik"}).to_return(:status => status, :body => body_message)
+        end
+        it "raises #{exception.name}" do
+          expect{@client.user_timeline("sferik")}.to raise_error exception
         end
       end
     end
-  end
 
+    context "when HTTP status is #{status} and body is errors" do
+      context "when errors is an array of hashes" do
+        context "when error code is nil" do
+          before do
+            body_message = '{"errors":[{"message":"Client Error"}]}'
+            stub_get("/1.1/statuses/user_timeline.json").with(:query => {:screen_name => "sferik"}).to_return(:status => status, :body => body_message)
+          end
+          it "raises #{exception.name}" do
+            expect{@client.user_timeline("sferik")}.to raise_error{|error| expect(error.code).to be_nil}
+          end
+          context "when error code is 187" do
+            before do
+              body_message = '{"errors":[{"message":"Client Error","code":187}]}'
+              stub_get("/1.1/statuses/user_timeline.json").with(:query => {:screen_name => "sferik"}).to_return(:status => status, :body => body_message)
+            end
+            it "raises #{exception.name}" do
+              expect{@client.user_timeline("sferik")}.to raise_error{|error| expect(error.code).to eq(187)}
+            end
+          end
+        end
+      end
+    end
+
+  end
 end

data/spec/twitter/geo/point_spec.rb

@@ -34,7 +34,7 @@ describe Twitter::Geo::Point do
 
   describe "#longitude" do
     it "returns the longitude" do
-      expect(@point.longitude).to eq 37.788299
+      expect(@point.longitude).to eq(37.788299)
     end
   end
 

data/spec/twitter/geo_factory_spec.rb

@@ -4,15 +4,15 @@ describe Twitter::GeoFactory do
 
   describe ".new" do
     it "generates a Point" do
-      geo = Twitter::GeoFactory.fetch_or_new(:type => 'Point')
+      geo = Twitter::GeoFactory.new(:type => "Point")
       expect(geo).to be_a Twitter::Geo::Point
     end
     it "generates a Polygon" do
-      geo = Twitter::GeoFactory.fetch_or_new(:type => 'Polygon')
+      geo = Twitter::GeoFactory.new(:type => "Polygon")
       expect(geo).to be_a Twitter::Geo::Polygon
     end
     it "raises an ArgumentError when type is not specified" do
-      expect{Twitter::GeoFactory.fetch_or_new}.to raise_error ArgumentError
+      expect{Twitter::GeoFactory.new}.to raise_error ArgumentError
     end
   end
 

data/spec/twitter/geo_results_spec.rb

@@ -0,0 +1,35 @@
+require 'helper'
+
+describe Twitter::GeoResults do
+
+  describe "#each" do
+    before do
+      @geo_results = Twitter::GeoResults.new(:result => {:places => [{:id => 1}, {:id => 2}, {:id => 3}, {:id => 4}, {:id => 5}, {:id => 6}]})
+    end
+    it "iterates" do
+      count = 0
+      @geo_results.each{count += 1}
+      expect(count).to eq(6)
+    end
+    context "with start" do
+      it "iterates" do
+        count = 0
+        @geo_results.each(5){count += 1}
+        expect(count).to eq(1)
+      end
+    end
+  end
+
+  describe "#token" do
+    it "returns a String when token is set" do
+      geo_results = Twitter::GeoResults.new(:result => {}, :token => "abc123")
+      expect(geo_results.token).to be_a String
+      expect(geo_results.token).to eq("abc123")
+    end
+    it "returns nil when token is not set" do
+      geo_results = Twitter::GeoResults.new(:result => {})
+      expect(geo_results.token).to be_nil
+    end
+  end
+
+end

data/spec/twitter/identifiable_spec.rb

@@ -8,27 +8,6 @@ describe Twitter::Identity do
     end
   end
 
-  context "identity map enabled" do
-    before do
-      Twitter.identity_map = Twitter::IdentityMap
-    end
-
-    after do
-      Twitter.identity_map = false
-    end
-
-    describe ".fetch" do
-      it "returns existing objects" do
-        Twitter::Identity.store(Twitter::Identity.new(:id => 1))
-        expect(Twitter::Identity.fetch(:id => 1)).to be
-      end
-
-      it "raises an error on objects that don't exist" do
-        expect{Twitter::Identity.fetch(:id => 6)}.to raise_error Twitter::Error::IdentityMapKeyError
-      end
-    end
-  end
-
   describe "#==" do
     it "returns true when objects IDs are the same" do
       one = Twitter::Identity.new(:id => 1, :screen_name => "sferik")

data/spec/twitter/list_spec.rb

@@ -22,23 +22,66 @@ describe Twitter::List do
 
   describe "#created_at" do
     it "returns a Time when created_at is set" do
-      user = Twitter::List.new(:id => 8863586, :created_at => "Mon Jul 16 12:59:01 +0000 2007")
-      expect(user.created_at).to be_a Time
+      list = Twitter::List.new(:id => 8863586, :created_at => "Mon Jul 16 12:59:01 +0000 2007")
+      expect(list.created_at).to be_a Time
     end
     it "returns nil when created_at is not set" do
-      user = Twitter::List.new(:id => 8863586)
-      expect(user.created_at).to be_nil
+      list = Twitter::List.new(:id => 8863586)
+      expect(list.created_at).to be_nil
+    end
+  end
+
+  describe "#created?" do
+    it "returns true when created_at is set" do
+      list = Twitter::List.new(:id => 8863586, :created_at => "Mon Jul 16 12:59:01 +0000 2007")
+      expect(list.created?).to be_true
+    end
+    it "returns false when created_at is not set" do
+      list = Twitter::List.new(:id => 8863586)
+      expect(list.created?).to be_false
+    end
+  end
+
+  describe "#members_uri" do
+    it "returns the URI to the list members" do
+      list = Twitter::List.new(:id => 8863586, :slug => "presidents", :user => {:id => 7505382, :screen_name => "sferik"})
+      expect(list.members_uri.to_s).to eq("https://twitter.com/sferik/presidents/members")
+    end
+  end
+
+  describe "#subscribers_uri" do
+    it "returns the URI to the list subscribers" do
+      list = Twitter::List.new(:id => 8863586, :slug => "presidents", :user => {:id => 7505382, :screen_name => "sferik"})
+      expect(list.subscribers_uri.to_s).to eq("https://twitter.com/sferik/presidents/subscribers")
+    end
+  end
+
+  describe "#uri" do
+    it "returns the URI to the list" do
+      list = Twitter::List.new(:id => 8863586, :slug => "presidents", :user => {:id => 7505382, :screen_name => "sferik"})
+      expect(list.uri.to_s).to eq("https://twitter.com/sferik/presidents")
     end
   end
 
   describe "#user" do
     it "returns a User when user is set" do
-      user = Twitter::List.new(:id => 8863586, :user => {:id => 7505382}).user
-      expect(user).to be_a Twitter::User
+      list = Twitter::List.new(:id => 8863586, :user => {:id => 7505382})
+      expect(list.user).to be_a Twitter::User
     end
     it "returns nil when status is not set" do
-      user = Twitter::List.new(:id => 8863586).user
-      expect(user).to be_nil
+      list = Twitter::List.new(:id => 8863586)
+      expect(list.user).to be_nil
+    end
+  end
+
+  describe "#user?" do
+    it "returns true when user is set" do
+      list = Twitter::List.new(:id => 8863586, :user => {:id => 7505382})
+      expect(list.user?).to be_true
+    end
+    it "returns false when user is not set" do
+      list = Twitter::List.new(:id => 8863586)
+      expect(list.user?).to be_false
     end
   end
 

data/spec/twitter/media/photo_spec.rb

@@ -4,8 +4,8 @@ describe Twitter::Media::Photo do
 
   describe "#==" do
     it "returns true when objects IDs are the same" do
-      photo = Twitter::Media::Photo.new(:id => 1, :url => "foo")
-      other = Twitter::Media::Photo.new(:id => 1, :url => "bar")
+      photo = Twitter::Media::Photo.new(:id => 1)
+      other = Twitter::Media::Photo.new(:id => 1)
       expect(photo == other).to be_true
     end
     it "returns false when objects IDs are different" do
@@ -22,7 +22,7 @@ describe Twitter::Media::Photo do
 
   describe "#sizes" do
     it "returns a hash of Sizes when sizes is set" do
-      sizes = Twitter::Media::Photo.new(:id => 110102452988157952, :sizes => {:small => {:h => 226, :w => 340, :resize => 'fit'}, :large => {:h => 466, :w => 700, :resize => 'fit'}, :medium => {:h => 399, :w => 600, :resize => 'fit'}, :thumb => {:h => 150, :w => 150, :resize => 'crop'}}).sizes
+      sizes = Twitter::Media::Photo.new(:id => 110102452988157952, :sizes => {:small => {:h => 226, :w => 340, :resize => "fit"}, :large => {:h => 466, :w => 700, :resize => "fit"}, :medium => {:h => 399, :w => 600, :resize => "fit"}, :thumb => {:h => 150, :w => 150, :resize => "crop"}}).sizes
       expect(sizes).to be_a Hash
       expect(sizes[:small]).to be_a Twitter::Size
     end
@@ -32,4 +32,119 @@ describe Twitter::Media::Photo do
     end
   end
 
+  describe "#display_uri" do
+    it "returns a URI when the display_url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :display_url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.display_uri).to be_a URI
+      expect(photo.display_uri.to_s).to eq("http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+    end
+    it "returns nil when the display_url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.display_uri).to be_nil
+    end
+  end
+
+  describe "#display_uri?" do
+    it "returns true when the display_url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :display_url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.display_uri).to be_true
+    end
+    it "returns false when the display_url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.display_uri).to be_false
+    end
+  end
+
+  describe "#expanded_uri" do
+    it "returns a URI when the expanded_url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :expanded_url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.expanded_uri).to be_a URI
+      expect(photo.expanded_uri.to_s).to eq("http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+    end
+    it "returns nil when the expanded_url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.expanded_uri).to be_nil
+    end
+  end
+
+  describe "#expanded_uri?" do
+    it "returns true when the expanded_url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :expanded_url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.expanded_uri).to be_true
+    end
+    it "returns false when the expanded_url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.expanded_uri).to be_false
+    end
+  end
+
+  describe "#media_uri" do
+    it "returns a URI when the media_url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :media_url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.media_uri).to be_a URI
+      expect(photo.media_uri.to_s).to eq("http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+    end
+    it "returns nil when the media_url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.media_uri).to be_nil
+    end
+  end
+
+  describe "#media_uri?" do
+    it "returns true when the media_url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :media_url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.media_uri).to be_true
+    end
+    it "returns false when the media_url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.media_uri).to be_false
+    end
+  end
+
+  describe "#media_uri_https" do
+    it "returns a URI when the media_url_https is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :media_url_https => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.media_uri_https).to be_a URI
+      expect(photo.media_uri_https.to_s).to eq("http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+    end
+    it "returns nil when the media_url_https is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.media_uri_https).to be_nil
+    end
+  end
+
+  describe "#media_uri_https?" do
+    it "returns true when the media_url_https is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :media_url_https => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.media_uri_https).to be_true
+    end
+    it "returns false when the media_url_https is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.media_uri_https).to be_false
+    end
+  end
+
+  describe "#uri" do
+    it "returns a URI when the url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.uri).to be_a URI
+      expect(photo.uri.to_s).to eq("http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+    end
+    it "returns nil when the url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.uri).to be_nil
+    end
+  end
+
+  describe "#uri?" do
+    it "returns true when the url is set" do
+      photo = Twitter::Media::Photo.new(:id => 1, :url => "http://pbs.twimg.com/media/BQD6MPOCEAAbCH0.png")
+      expect(photo.uri).to be_true
+    end
+    it "returns false when the url is not set" do
+      photo = Twitter::Media::Photo.new(:id => 1)
+      expect(photo.uri).to be_false
+    end
+  end
+
 end