trollolo 0.1.1 → 0.2.0

data/spec/unit/settings_spec.rb

@@ -4,58 +4,58 @@ describe Settings do
 
   include GivenFilesystemSpecHelpers
 
-  context "given config file" do
+  context 'given config file' do
     before(:each) do
       @settings = Settings.new( File.expand_path('../../data/trollolorc', __FILE__) )
     end
 
-    it "is not verbose by default" do
+    it 'is not verbose by default' do
       expect(@settings.verbose).to be false
     end
 
-    it "reads config file" do
-      expect(@settings.developer_public_key).to eq "mykey"
-      expect(@settings.member_token).to eq "mytoken"
+    it 'reads config file' do
+      expect(@settings.developer_public_key).to eq 'mykey'
+      expect(@settings.member_token).to eq 'mytoken'
     end
 
-    context "#scrum" do
-      context "when setting is missing" do
+    context '#scrum' do
+      context 'when setting is missing' do
         before do
           @settings = Settings.new( File.expand_path('../../data/trollolorc_with_board_aliases', __FILE__) )
         end
-        it "returns default settings" do
-          expect(@settings.scrum["board_names"]).to eq({"planning" => "Planning Board", "sprint" => "Sprint Board"})
+        it 'returns default settings' do
+          expect(@settings.scrum['board_names']).to eq('planning' => 'Planning Board', 'sprint' => 'Sprint Board')
         end
       end
 
-      context "when setting does exist" do
-        it "returns name" do
-          expect(@settings.scrum["board_names"]["sprint"]).to eq("Sprint Board")
-          expect(@settings.scrum.board_names["planning"]).to eq("Planning Board")
+      context 'when setting does exist' do
+        it 'returns name' do
+          expect(@settings.scrum['board_names']['sprint']).to eq('Sprint Board')
+          expect(@settings.scrum.board_names['planning']).to eq('Planning Board')
         end
       end
     end
 
-    context "#board_aliases" do
-      context "when aliases do not exist" do
-        it "returns an empty Hash" do
+    context '#board_aliases' do
+      context 'when aliases do not exist' do
+        it 'returns an empty Hash' do
           expect(@settings.board_aliases).to eq({})
         end
       end
 
-      context "when mapping exists" do
+      context 'when mapping exists' do
         before do
           @settings = Settings.new( File.expand_path('../../data/trollolorc_with_board_aliases', __FILE__) )
         end
 
-        it "returns the mapping" do
-          expect(@settings.board_aliases).to eq({"MyTrelloBoard" => "53186e8391ef8671265eba9d"})
+        it 'returns the mapping' do
+          expect(@settings.board_aliases).to eq('MyTrelloBoard' => '53186e8391ef8671265eba9d')
         end
       end
     end
   end
 
-  context "non-existent config file" do
+  context 'non-existent config file' do
     use_given_filesystem
 
     before(:each) do
@@ -63,9 +63,9 @@ describe Settings do
       @settings = Settings.new(@config_file)
     end
 
-    it "saves config file" do
-      @settings.developer_public_key = "mypublickey"
-      @settings.member_token = "mymembertoken"
+    it 'saves config file' do
+      @settings.developer_public_key = 'mypublickey'
+      @settings.member_token = 'mymembertoken'
       @settings.save_config
 
       expect(File.read(@config_file)).to eq "---\ndeveloper_public_key: mypublickey\nmember_token: mymembertoken\n"

data/spec/unit/spec_helper.rb

@@ -1,13 +1,13 @@
-require "simplecov"
+require 'simplecov'
 SimpleCov.start
 require_relative '../../lib/trollolo'
 require 'given_filesystem/spec_helpers'
 require 'webmock/rspec'
 require 'byebug'
 require 'pry'
-WebMock.disable_net_connect!(:allow => "codeclimate.com")
+WebMock.disable_net_connect!(allow: 'codeclimate.com')
 
-bin_path = File.expand_path( "../../../bin/", __FILE__ )
+bin_path = File.expand_path( '../../../bin/', __FILE__ )
 
 if ENV['PATH'] !~ /#{bin_path}/
   ENV['PATH'] = bin_path + File::PATH_SEPARATOR + ENV['PATH']

data/spec/unit/support/test_data_operations.rb

@@ -5,3 +5,7 @@ end
 def dummy_settings
   Settings.new(File.expand_path('../../../data/trollolorc', __FILE__))
 end
+
+def dummy_card_json
+  JSON.parse(File.read(File.expand_path('../../../data/card.json', __FILE__)))
+end

data/spec/unit/support/update_webmock_data

@@ -1,24 +1,22 @@
 #!/usr/bin/env ruby
 
-require "json"
+require 'json'
 
-require_relative "webmocks"
+require_relative 'webmocks'
 
-trollolo_bin = File.expand_path("../../../../bin/trollolo", __FILE__)
-spec_data_dir = File.expand_path("../../../data", __FILE__)
+trollolo_bin = File.expand_path('../../../../bin/trollolo', __FILE__)
+spec_data_dir = File.expand_path('../../../data', __FILE__)
 
-STDERR.puts "Updating web mock data"
+STDERR.puts 'Updating web mock data'
 
 def scrub_file(file)
   json = JSON.parse(File.read(file))
-  if json.is_a?(Hash) && json.has_key?("cards")
-    json["cards"].each do |card|
-      if card.has_key?("email")
-        card["email"] = "trello@example.com"
-      end
+  if json.is_a?(Hash) && json.key?('cards')
+    json['cards'].each do |card|
+      card['email'] = 'trello@example.com' if card.key?('email')
     end
   end
-  File.open(file, "w") do |f|
+  File.open(file, 'w') do |f|
     f.write(JSON.pretty_generate(json))
   end
 end

data/spec/unit/support/vcr.rb

@@ -1,12 +1,12 @@
 require 'vcr'
 VCR.configure do |config|
-  config.cassette_library_dir = "spec/data/vcr"
+  config.cassette_library_dir = 'spec/data/vcr'
   config.hook_into :webmock
 end
 
 # example needs to use real_settings if vcr_record: true is used
 def real_settings
-  config_path = ENV["TROLLOLO_CONFIG_PATH"] || File.expand_path("~/.trollolorc")
+  config_path = ENV['TROLLOLO_CONFIG_PATH'] || File.expand_path('~/.trollolorc')
   Settings.new(config_path)
 end
 
@@ -40,7 +40,7 @@ end
 RSpec.configure do |c|
   c.around do |example|
     if (cassette = example.metadata[:vcr])
-      fail "you need to use real_settings to re-record vcr data" if real_settings_needed?(example)
+      raise 'you need to use real_settings to re-record vcr data' if real_settings_needed?(example)
       VCR.use_cassette(cassette, record: vcr_record_mode(example)) do
         example.run
       end

data/spec/unit/support/webmocks.rb

@@ -7,27 +7,36 @@ def webmock_mapping
     {
       path: 'boards/53186e8391ef8671265eba9d/lists',
       parameters: {
-        "filter" => "open"
+        'filter' => 'open'
       },
       file: 'lists.json'
     },
     {
       path: 'boards/53186e8391ef8671265eba9d',
       parameters: {
-        "cards" => "open",
-        "lists" => "open",
-        "card_checklists" => "all"
+        'cards' => 'open',
+        'lists' => 'open',
+        'card_checklists' => 'all'
       },
       file: 'full-board.json'
     },
     {
       path: 'boards/P4kJA4bE',
       parameters: {
-        "cards" => "open",
-        "lists" => "open",
-        "card_checklists" => "all"
+        'cards' => 'open',
+        'lists' => 'open',
+        'card_checklists' => 'all'
       },
       file: 'full-board-with-accepted.json'
+    },
+    {
+      path: 'boards/7Zar7bNm',
+      parameters: {
+        'cards' => 'open',
+        'lists' => 'open',
+        'card_checklists' => 'all'
+      },
+      file: 'full-board.json'
     }
   ]
 end
@@ -40,22 +49,22 @@ def parameters_as_string(mapping, parameters = nil)
     end
   end
   if !parameters.empty?
-    parameters_string = "?" + parameters.join("&")
+    parameters_string = '?' + parameters.join('&')
   else
-    parameters_string = ""
+    parameters_string = ''
   end
   parameters_string
 end
 
 def mapping_url(mapping, parameters = nil)
-  url = "https://api.trello.com/1/" + mapping[:path]
+  url = 'https://api.trello.com/1/' + mapping[:path]
   url += parameters_as_string(mapping, parameters)
 end
 
 def full_board_mock
   webmock_mapping.each do |mapping|
-    url = mapping_url(mapping, [ "key=mykey", "token=mytoken" ])
+    url = mapping_url(mapping, [ 'key=mykey', 'token=mytoken' ])
     stub_request(:get, url)
-      .to_return(:status => 200, :body => load_test_file(mapping[:file]))
+      .to_return(status: 200, body: load_test_file(mapping[:file]))
   end
 end

data/spec/unit/trello_wrapper_spec.rb

@@ -4,12 +4,12 @@ include GivenFilesystemSpecHelpers
 
 describe TrelloWrapper do
 
-  let!(:settings){ double('settings', developer_public_key: "mykey", member_token: "mytoken") }
+  let!(:settings){ double('settings', developer_public_key: 'mykey', member_token: 'mytoken') }
   subject { described_class.new(settings) }
 
   before do
-    stub_request(:get, "https://api.trello.com/1/boards/myboard?cards=open&key=mykey&lists=open&token=mytoken").
-        to_return(:status => 200, :body => load_test_file("board.json"), :headers => {})
+    stub_request(:get, 'https://api.trello.com/1/boards/myboard?cards=open&key=mykey&lists=open&token=mytoken').
+        to_return(status: 200, body: load_test_file('board.json'), headers: {})
     full_board_mock
   end
 
@@ -30,26 +30,26 @@ describe TrelloWrapper do
     end
 
     it 'finds board via Trello' do
-      subject.board("myboard")
+      subject.board('myboard')
     end
 
     it 'instantiate ScrumBoard with trello board and settings' do
       expect(ScrumBoard).to receive(:new).with(:board, subject.instance_variable_get(:@settings))
-      subject.board("myboard")
+      subject.board('myboard')
     end
 
     it 'returns instance of a ScrumBoard' do
-      expect(subject.board("myboard")).to be_instance_of(ScrumBoard)
+      expect(subject.board('myboard')).to be_instance_of(ScrumBoard)
     end
 
     it 'memoize board object' do
-      expect(subject.board("myboard")).to be subject.board("myboard")
+      expect(subject.board('myboard')).to be subject.board('myboard')
     end
   end
 
   describe '#backup' do
     it 'raises an error for empty board id' do
-      expect { subject.backup("") }.to raise_error(TrolloloError)
+      expect { subject.backup('') }.to raise_error(TrolloloError)
     end
 
     it 'raises an error for nil board id' do
@@ -70,7 +70,7 @@ describe TrelloWrapper do
   describe '#add_attachment' do
     use_given_filesystem
 
-    it "uploads attachment" do
+    it 'uploads attachment' do
       srand(1) # Make sure multipart boundary is always the same
 
       card_body = <<EOT
@@ -80,26 +80,31 @@ describe TrelloWrapper do
 }
 EOT
 
-      stub_request(:get, "https://api.trello.com/1/cards/123?key=mykey&token=mytoken").
-        with(:headers => {'Accept' => '*/*; q=0.5, application/xml', 'Accept-Encoding' => 'gzip, deflate', 'User-Agent' => 'Ruby'}).
-          to_return(:status => 200, :body => card_body, :headers => {})
+      stub_request(:get, 'https://api.trello.com/1/cards/123?key=mykey&token=mytoken').
+        with(headers: {'Accept' => '*/*; q=0.5, application/xml', 'Accept-Encoding' => 'gzip, deflate', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: card_body, headers: {})
 
-      stub_request(:post, "https://api.trello.com/1/cards/123/attachments?key=mykey&token=mytoken").
-          with(:headers => {'Accept' => '*/*; q=0.5, application/xml', 'Accept-Encoding' => 'gzip, deflate', 'Content-Length' => '188', 'Content-Type' => 'multipart/form-data; boundary=470924', 'User-Agent' => 'Ruby'}).
-            to_return(:status => 200, :body => "", :headers => {})
+      headers = {'Accept' => '*/*; q=0.5, application/xml',
+                 'Accept-Encoding' => 'gzip, deflate',
+                 'Content-Length' => '188',
+                 'Content-Type' => 'multipart/form-data; boundary=470924',
+                 'User-Agent' => 'Ruby'}
 
-      path = given_file("attachment-data")
+      stub_request(:post, 'https://api.trello.com/1/cards/123/attachments?key=mykey&token=mytoken').
+          with(headers: headers).to_return(status: 200, body: '', headers: {})
 
-      subject.add_attachment("123", path)
+      path = given_file('attachment-data')
+
+      subject.add_attachment('123', path)
     end
   end
 
-  describe "#make_cover" do
-    let(:card_id) { "c133a484cff21c7a33ff031f" }
-    let(:image_id) { "484cff21c7a33ff031f997a" }
-    let(:image_name) { "passed.jpg" }
+  describe '#make_cover' do
+    let(:card_id) { 'c133a484cff21c7a33ff031f' }
+    let(:image_id) { '484cff21c7a33ff031f997a' }
+    let(:image_name) { 'passed.jpg' }
     let(:client) { double }
-    let(:card_attachments_body) { <<-EOF
+    let(:card_attachments_body) do <<-EOF
       [
         {
           "id":"78d86ae7f25c748559b37ca",
@@ -111,23 +116,29 @@ EOT
         }
       ]
 EOF
-    }
+    end
 
     before(:each) do
       stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/attachments?fields=name&key=mykey&token=mytoken").
-        with(:headers => {'Accept' => '*/*; q=0.5, application/xml', 'Accept-Encoding' => 'gzip, deflate', 'User-Agent' => 'Ruby'}).
-          to_return(:status => 200, :body => card_attachments_body, :headers => {})
+        with(headers: {'Accept' => '*/*; q=0.5, application/xml', 'Accept-Encoding' => 'gzip, deflate', 'User-Agent' => 'Ruby'}).
+          to_return(status: 200, body: card_attachments_body, headers: {})
+      headers = {'Accept' => '*/*; q=0.5, application/xml',
+                 'Accept-Encoding' => 'gzip, deflate',
+                 'Content-Length' => '0',
+                 'Content-Type' => 'application/x-www-form-urlencoded',
+                 'User-Agent' => 'Ruby'}
+
       stub_request(:put, "https://api.trello.com/1/cards/#{card_id}/idAttachmentCover?key=mykey&token=mytoken&value=#{image_id}").
-                 with(:headers => {'Accept' => '*/*; q=0.5, application/xml', 'Accept-Encoding' => 'gzip, deflate', 'Content-Length' => '0', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => 'Ruby'})
+                 with(headers: headers)
     end
 
-    it "make the attachment with the file name passed.jpg the cover" do
+    it 'make the attachment with the file name passed.jpg the cover' do
      subject.make_cover(card_id, image_name)
      expect(WebMock).to have_requested(:put, "https://api.trello.com/1/cards/#{card_id}/idAttachmentCover?key=mykey&token=mytoken&value=#{image_id}")
     end
 
-    it "shows an error if the file was not found in the attachment list" do
-      expect { subject.make_cover(card_id, "non_existing_file.jpg") }.to raise_error(/non_existing_file.jpg/)
+    it 'shows an error if the file was not found in the attachment list' do
+      expect { subject.make_cover(card_id, 'non_existing_file.jpg') }.to raise_error(/non_existing_file.jpg/)
     end
   end
 end

data/trollolo.gemspec

@@ -4,7 +4,7 @@ require File.expand_path('../lib/version', __FILE__)
 Gem::Specification.new do |s|
   s.name        = 'trollolo'
   s.version     = Trollolo::VERSION
-  s.license     = 'GPL-3'
+  s.license     = 'GPL-3.0'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Cornelius Schumacher']
   s.email       = ['cschum@suse.de']
@@ -12,7 +12,7 @@ Gem::Specification.new do |s|
   s.summary     = 'Trello command line client'
   s.description = 'Trollolo is a command line tool to access Trello and support tasks like generation of burndown charts.'
 
-  s.required_ruby_version = '>= 2.2'
+  s.required_ruby_version = ['>= 2.2.0', '< 2.4.2']
   s.required_rubygems_version = '>= 1.3.6'
   s.rubyforge_project         = 'trollolo'
 
@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'ruby-trello', '~> 1.5.0'
 
   s.files        = `git ls-files`.split("\n")
-  s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact
+  s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? Regexp.last_match(1) : nil}.compact
   s.require_path = 'lib'
 
   s.files += Dir['man/*.?']              # UNIX man pages

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trollolo
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Cornelius Schumacher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-06 00:00:00.000000000 Z
+date: 2018-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -171,7 +171,7 @@ files:
 - yes_ship_it.conf
 homepage: https://github.com/openSUSE/trollolo
 licenses:
-- GPL-3
+- GPL-3.0
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -181,7 +181,10 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: 2.2.0
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: 2.4.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -189,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: trollolo
-rubygems_version: 2.6.13
+rubygems_version: 2.5.2.1
 signing_key: 
 specification_version: 4
 summary: Trello command line client