trollolo 0.1.1 → 0.2.0

data/spec/unit/burndown_data_spec.rb

@@ -5,12 +5,12 @@ include GivenFilesystemSpecHelpers
 describe BurndownData do
   before(:each) do
     @burndown = BurndownData.new(dummy_settings)
-    @burndown.board_id = "53186e8391ef8671265eba9d"
+    @burndown.board_id = '53186e8391ef8671265eba9d'
     full_board_mock
   end
 
   describe BurndownData::Result do
-    it "calculates total" do
+    it 'calculates total' do
       r = described_class.new
       r.open = 7
       r.done = 4
@@ -19,83 +19,81 @@ describe BurndownData do
     end
   end
 
-  describe "setters" do
-    it "sets open story points" do
+  describe 'setters' do
+    it 'sets open story points' do
       @burndown.story_points.open = 13
       expect(@burndown.story_points.open).to eq 13
     end
 
-    it "sets open tasks" do
+    it 'sets open tasks' do
       @burndown.tasks.open = 42
       expect(@burndown.tasks.open).to eq 42
     end
   end
 
-  describe "#fetch" do
-    context "with meta data on sprint card" do
+  describe '#fetch' do
+    context 'with meta data on sprint card' do
       before do
         @burndown.fetch
       end
 
-      it "returns story points" do
+      it 'returns story points' do
         expect( @burndown.story_points.total ).to eq 16
         expect( @burndown.story_points.open ).to eq 13
         expect( @burndown.story_points.done ).to eq 3
       end
 
-      it "returns extra story points" do
+      it 'returns extra story points' do
         expect( @burndown.extra_story_points.total ).to eq 8
         expect( @burndown.extra_story_points.open ).to eq 8
         expect( @burndown.extra_story_points.done ).to eq 0
       end
 
-      it "returns unplanned story points" do
+      it 'returns unplanned story points' do
         expect( @burndown.unplanned_story_points.total ).to eq 3
         expect( @burndown.unplanned_story_points.open ).to eq 1
         expect( @burndown.unplanned_story_points.done ).to eq 2
       end
 
-      it "returns tasks" do
+      it 'returns tasks' do
         expect( @burndown.tasks.total ).to eq 13
         expect( @burndown.tasks.open ).to eq 9
         expect( @burndown.tasks.done ).to eq 4
       end
 
-      it "returns extra tasks" do
+      it 'returns extra tasks' do
         expect( @burndown.extra_tasks.total ).to eq 1
         expect( @burndown.extra_tasks.open ).to eq 1
         expect( @burndown.extra_tasks.done ).to eq 0
       end
 
-      it "returns unplanned tasks" do
+      it 'returns unplanned tasks' do
         expect( @burndown.unplanned_tasks.total ).to eq 2
         expect( @burndown.unplanned_tasks.open ).to eq 1
         expect( @burndown.unplanned_tasks.done ).to eq 1
       end
 
-      it "returns meta data" do
-        expect( @burndown.meta ).to eq({
-          "sprint" => 10,
-          "total_days" => 18,
-          "weekend_lines" => [1.5, 6.5, 11.5, 16.5]
-        })
+      it 'returns meta data' do
+        expect( @burndown.meta ).to eq( 'sprint' => 10,
+                                        'total_days' => 18,
+                                        'weekend_lines' => [1.5, 6.5, 11.5, 16.5])
       end
 
-      it "saves date and time" do
-        expected_date_time = DateTime.parse("2015-01-12T13:57:16+01:00")
+      it 'saves date and time' do
+        expected_date_time = DateTime.parse('2015-01-12T13:57:16+01:00')
         allow(DateTime).to receive(:now).and_return(expected_date_time)
         @burndown.fetch
         expect(@burndown.date_time).to eq(expected_date_time)
       end
     end
 
-    context "without meta data on sprint card" do
+    context 'without meta data on sprint card' do
       before do
         allow(Card).to receive(:parse_yaml_from_description).and_return(nil)
         @burndown.fetch
       end
 
-      it "does not fail" do
+      it 'does not fail' do
         expect(@burndown.meta).to be(nil)
       end
     end

data/spec/unit/card_spec.rb

@@ -1,36 +1,50 @@
-require_relative "spec_helper"
+require_relative 'spec_helper'
 
 describe Card do
 
-  describe "parses name" do
+  describe 'parses name' do
     before(:each) do
       allow_any_instance_of(Card).to receive(:init_data)
-      @card = Card.new(double, double)
+      @card = Card.new(double, double, dummy_settings)
     end
 
-    it "extracts single digit story point value from card name" do
-      allow(@card).to receive(:name).and_return("(3) P1: Refactor cards")
+    it 'extracts single digit story point value from card name' do
+      allow(@card).to receive(:name).and_return('(3) P1: Refactor cards')
       expect(@card.story_points).to eq(3)
     end
 
-    it "extracts double digit story point value from card name" do
-      allow(@card).to receive(:name).and_return "(13) P1: Refactor cards"
+    it 'extracts double digit story point value from card name' do
+      allow(@card).to receive(:name).and_return '(13) P1: Refactor cards'
       expect(@card.story_points).to eq(13)
     end
 
-    it "extracts fractional story point value from card name" do
-      allow(@card).to receive(:name).and_return "(0.5) P1: Refactor cards"
+    it 'extracts fractional story point value from card name' do
+      allow(@card).to receive(:name).and_return '(0.5) P1: Refactor cards'
       expect(@card.story_points).to eq(0.5)
     end
 
-    it "extracts story points when value is not at beginning of card name" do
-      allow(@card).to receive(:name).and_return "P01: (3) Refactor cards"
+    it 'extracts story points when value is not at beginning of card name' do
+      allow(@card).to receive(:name).and_return 'P01: (3) Refactor cards'
       expect(@card.story_points).to eq(3)
     end
   end
 
-  describe "#parse_yaml_from_description" do
-    it "parses description only having YAML" do
+  describe 'counts checklists' do
+    before(:each) do
+      @card = Card.new({ 'cards' => [dummy_card_json] }, '5319c0409a567dc62b68aa6b', dummy_settings)
+    end
+
+    it 'counts all checklist items that are marked as no_task_checklists' do
+      expect(@card.tasks).to eq(3)
+    end
+
+    it 'counts all closed checklist items that are marked as no_task_checklists' do
+      expect(@card.done_tasks).to eq(1)
+    end
+  end
+
+  describe '#parse_yaml_from_description' do
+    it 'parses description only having YAML' do
       description = <<EOT
 ```yaml
 total_days: 18
@@ -40,11 +54,11 @@ weekend_lines:
 ```
 EOT
       meta = Card.parse_yaml_from_description(description)
-      expect(meta["total_days"]).to eq(18)
-      expect(meta["weekend_lines"]).to eq([1.5, 6.5])
+      expect(meta['total_days']).to eq(18)
+      expect(meta['weekend_lines']).to eq([1.5, 6.5])
     end
 
-    it "parses description only having unmarked YAML" do
+    it 'parses description only having unmarked YAML' do
       description = <<EOT
 ```
 total_days: 18
@@ -54,11 +68,11 @@ weekend_lines:
 ```
 EOT
       meta = Card.parse_yaml_from_description(description)
-      expect(meta["total_days"]).to eq(18)
-      expect(meta["weekend_lines"]).to eq([1.5, 6.5])
+      expect(meta['total_days']).to eq(18)
+      expect(meta['weekend_lines']).to eq([1.5, 6.5])
     end
 
-    it "parses description having YAML and text" do
+    it 'parses description having YAML and text' do
       description = <<EOT
 This is some text
 
@@ -72,18 +86,18 @@ weekend_lines:
 And more text.
 EOT
       meta = Card.parse_yaml_from_description(description)
-      expect(meta["total_days"]).to eq(18)
-      expect(meta["weekend_lines"]).to eq([1.5, 6.5])
+      expect(meta['total_days']).to eq(18)
+      expect(meta['weekend_lines']).to eq([1.5, 6.5])
     end
   end
 
-  describe "gets raw JSON" do
-    it "for cards" do
+  describe 'gets raw JSON' do
+    it 'for cards' do
       @settings = dummy_settings
       full_board_mock
 
       trello = TrelloWrapper.new(@settings)
-      board = trello.board("53186e8391ef8671265eba9d")
+      board = trello.board('53186e8391ef8671265eba9d')
 
       expected_json = <<EOT
 {

data/spec/unit/cli_spec.rb

@@ -11,31 +11,31 @@ describe Cli do
     @cli = Cli.new
   end
 
-  it "fetches burndown data from board-list" do
+  it 'fetches burndown data from board-list' do
     full_board_mock
     dir = given_directory
-    @cli.options = {"board-list" => "spec/data/board-list.yaml",
-                    "output" => dir}
+    @cli.options = {'board-list' => 'spec/data/board-list.yaml',
+                    'output' => dir}
     @cli.burndowns
-    expect(File.exist?(File.join(dir, "orange/burndown-data-01.yaml")))
-    expect(File.exist?(File.join(dir, "blue/burndown-data-01.yaml")))
+    expect(File.exist?(File.join(dir, 'orange/burndown-data-01.yaml')))
+    expect(File.exist?(File.join(dir, 'blue/burndown-data-01.yaml')))
   end
 
-  it "backups board" do
+  it 'backups board' do
     expect_any_instance_of(Backup).to receive(:backup)
-    @cli.options = {"board-id" => "1234"}
+    @cli.options = {'board-id' => '1234'}
     @cli.backup
   end
 
-  it "backups board using an alias" do
+  it 'backups board using an alias' do
     expect_any_instance_of(Backup).to receive(:backup)
-    @cli.options = {"board-id" => "MyTrelloBoard"}
+    @cli.options = {'board-id' => 'MyTrelloBoard'}
     @cli.backup
   end
 
-  it "gets lists" do
+  it 'gets lists' do
     full_board_mock
-    @cli.options = {"board-id" => "53186e8391ef8671265eba9d"}
+    @cli.options = {'board-id' => '53186e8391ef8671265eba9d'}
     expected_output = <<EOT
 Sprint Backlog
 Doing
@@ -44,21 +44,21 @@ Done Sprint 9
 Done Sprint 8
 Legend
 EOT
-    expect {
+    expect do
       @cli.get_lists
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
 
 
     # Using an alias
-    @cli.options = {"board-id" => "MyTrelloBoard"}
-    expect {
+    @cli.options = {'board-id' => 'MyTrelloBoard'}
+    expect do
       @cli.get_lists
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
   end
 
-  it "gets cards" do
+  it 'gets cards' do
     full_board_mock
-    @cli.options = {"board-id" => "53186e8391ef8671265eba9d"}
+    @cli.options = {'board-id' => '53186e8391ef8671265eba9d'}
     expected_output = <<EOT
 Sprint 3
 (3) P1: Fill Backlog column
@@ -84,20 +84,20 @@ Sprint 8
 Purpose
 Background image
 EOT
-    expect {
+    expect do
       @cli.get_cards
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
 
     # Using an alias
-    @cli.options = {"board-id" => "MyTrelloBoard"}
-    expect {
+    @cli.options = {'board-id' => 'MyTrelloBoard'}
+    expect do
       @cli.get_cards
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
   end
 
-  it "gets checklists" do
+  it 'gets checklists' do
     full_board_mock
-    @cli.options = {"board-id" => "53186e8391ef8671265eba9d"}
+    @cli.options = {'board-id' => '53186e8391ef8671265eba9d'}
     expected_output = <<EOT
 Tasks
 Tasks
@@ -112,18 +112,18 @@ Tasks
 Tasks
 Tasks
 EOT
-    expect {
+    expect do
       @cli.get_checklists
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
 
     # Using an alias
-    @cli.options = {"board-id" => "MyTrelloBoard"}
-    expect {
+    @cli.options = {'board-id' => 'MyTrelloBoard'}
+    expect do
       @cli.get_checklists
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
   end
 
-  it "gets description" do
+  it 'gets description' do
     body = <<-EOT
 {
   "id": "54ae8485221b1cc5b173e713",
@@ -131,41 +131,41 @@ EOT
 }
 EOT
     stub_request(
-      :get, "https://api.trello.com/1/cards/54ae8485221b1cc5b173e713?key=mykey&token=mytoken"
+      :get, 'https://api.trello.com/1/cards/54ae8485221b1cc5b173e713?key=mykey&token=mytoken'
     ).with(
-      :headers => {
+      headers: {
         'Accept' => '*/*; q=0.5, application/xml',
         'Accept-Encoding' => 'gzip, deflate',
         'User-Agent' => 'Ruby'
       }
-    ).to_return(:status => 200, :body => body, :headers => {})
-    @cli.options = {"card-id" => "54ae8485221b1cc5b173e713"}
+    ).to_return(status: 200, body: body, headers: {})
+    @cli.options = {'card-id' => '54ae8485221b1cc5b173e713'}
     expected_output = "haml\n"
-    expect {
+    expect do
       @cli.get_description
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
   end
 
-  it "sets description" do
-    expect(STDIN).to receive(:read).and_return("My description")
+  it 'sets description' do
+    expect(STDIN).to receive(:read).and_return('My description')
     stub_request(
-      :put, "https://api.trello.com/1/cards/54ae8485221b1cc5b173e713/desc?key=mykey&token=mytoken&value=My%20description"
+      :put, 'https://api.trello.com/1/cards/54ae8485221b1cc5b173e713/desc?key=mykey&token=mytoken&value=My%20description'
     ).with(
-      :headers => {
+      headers: {
         'Accept' => '*/*; q=0.5, application/xml',
         'Accept-Encoding' => 'gzip, deflate',
         'Content-Length' => '0',
         'Content-Type' => 'application/x-www-form-urlencoded',
         'User-Agent' => 'Ruby'
       }
-    ).to_return(:status => 200, :body => "", :headers => {})
-    @cli.options = {"card-id" => "54ae8485221b1cc5b173e713"}
+    ).to_return(status: 200, body: '', headers: {})
+    @cli.options = {'card-id' => '54ae8485221b1cc5b173e713'}
     @cli.set_description
-    expect(WebMock).to have_requested(:put, "https://api.trello.com/1/cards/54ae8485221b1cc5b173e713/desc?key=mykey&token=mytoken&value=My%20description")
+    expect(WebMock).to have_requested(:put, 'https://api.trello.com/1/cards/54ae8485221b1cc5b173e713/desc?key=mykey&token=mytoken&value=My%20description')
   end
 
-  it "sets priorities for default planning list", vcr: "prioritize_backlog_list", vcr_record: false do
-    @cli.options = {"board-id" => "neUHHzDo"}
+  it 'sets priorities for default planning list', vcr: 'prioritize_backlog_list', vcr_record: false do
+    @cli.options = {'board-id' => 'neUHHzDo'}
 
     expected_output = <<-EOT
 set priority to 1 for "P1: (2) Document how to run cf-openstack-validator on SUSE"
@@ -182,32 +182,32 @@ set priority to 11 for "P11: (3) Set up Concourse pipeline for BATs"
 set priority to 12 for "P12: Bike Shedding Feature"
 set priority to 13 for "P13: (3) Set up Concourse pipeline for os image building"
 EOT
-    expect {
+    expect do
       @cli.set_priorities
-    }.to output(expected_output).to_stdout
+    end.to output(expected_output).to_stdout
   end
 
-  it "sets priorities for specified planning list", vcr: "prioritize_backlog_list", vcr_record: false do
-    @cli.options = {"board-id" => "neUHHzDo", "backlog-list-name" => "Nonexisting List"}
+  it 'sets priorities for specified planning list', vcr: 'prioritize_backlog_list', vcr_record: false do
+    @cli.options = {'board-id' => 'neUHHzDo', 'backlog-list-name' => 'Nonexisting List'}
 
-    expect {
+    expect do
       @cli.set_priorities
-    }.to raise_error /'Nonexisting List' not found/
+    end.to raise_error /'Nonexisting List' not found/
   end
 
-  context "#board_id" do
+  context '#board_id' do
     before do
       Cli.settings = Settings.new(
         File.expand_path('../../data/trollolorc_with_board_aliases', __FILE__))
       @cli = Cli.new
     end
 
-    it "returns the id when no alias exists" do
-      expect(@cli.send(:board_id, "1234")).to eq("1234")
+    it 'returns the id when no alias exists' do
+      expect(@cli.send(:board_id, '1234')).to eq('1234')
     end
 
-    it "return the id when an alias exists" do
-      expect(@cli.send(:board_id, "MyTrelloBoard")).to eq("53186e8391ef8671265eba9d")
+    it 'return the id when an alias exists' do
+      expect(@cli.send(:board_id, 'MyTrelloBoard')).to eq('53186e8391ef8671265eba9d')
     end
   end
 end