transpec 0.2.6 → 1.0.0

data/spec/transpec/cli_spec.rb

@@ -17,22 +17,6 @@ module Transpec
       end
     end
 
-    describe '#forced?' do
-      subject { cli.forced? }
-
-      context 'by default' do
-        it { should be_false }
-      end
-    end
-
-    describe '#generates_commit_message?' do
-      subject { cli.generates_commit_message? }
-
-      context 'by default' do
-        it { should be_false }
-      end
-    end
-
     describe '#run' do
       include_context 'isolated environment'
 
@@ -53,12 +37,13 @@ module Transpec
       before do
         cli.stub(:puts)
         cli.stub(:warn)
+        DynamicAnalyzer.any_instance.stub(:analyze).and_return(DynamicAnalyzer::RuntimeData.new)
         create_file(file_path, file_content)
       end
 
       shared_examples 'rewrites files' do
         it 'rewrites files' do
-          cli.should_receive(:process_file)
+          cli.should_receive(:convert_file)
           cli.run(args)
         end
 
@@ -76,11 +61,9 @@ module Transpec
           context 'and the repository is not clean' do
             before { Git.stub(:clean?).and_return(false) }
 
-            context '#forced? is false' do
-              before { cli.stub(:forced?).and_return(false) }
-
+            context '--force option is not specified' do
               it 'aborts processing' do
-                cli.should_not_receive(:process_file)
+                cli.should_not_receive(:convert_file)
                 cli.run(args).should be_false
               end
 
@@ -94,7 +77,7 @@ module Transpec
             end
 
             context '#forced? is true' do
-              before { cli.stub(:forced?).and_return(true) }
+              before { args << '--force' }
               include_examples 'rewrites files'
             end
           end
@@ -135,8 +118,8 @@ module Transpec
         end
 
         it 'continues processing files' do
-          cli.should_receive(:puts).with("Processing #{invalid_syntax_file_path}")
-          cli.should_receive(:puts).with("Processing #{valid_syntax_file_path}")
+          cli.should_receive(:puts).with("Converting #{invalid_syntax_file_path}")
+          cli.should_receive(:puts).with("Converting #{valid_syntax_file_path}")
           cli.run(args)
         end
       end
@@ -144,41 +127,25 @@ module Transpec
       context 'when any other error is raised while running' do
         let(:args) { ['non-existent-file'] }
 
-        it 'return false' do
-          should be_false
-        end
-
-        it 'prints message of the exception' do
-          cli.should_receive(:warn).with(/No such file or directory/)
-          cli.run(args)
+        it 'does not catch the error' do
+          -> { cli.run(args) }.should raise_error
         end
       end
 
-      context 'when no target paths are specified' do
-        let(:args) { [] }
+      context 'when -s/--skip-dynamic-analysis option is specified' do
+        let(:args) { ['--skip-dynamic-analysis', file_path] }
 
-        context 'and there is "spec" directory' do
-          let(:file_path) { 'spec/example_spec.rb' }
-
-          it 'targets files in the "spec" directoy' do
-            cli.should_receive(:target_files).with(['spec'])
-            cli.run(args)
-          end
-        end
-
-        context 'and there is not "spec" directory' do
-          let(:file_path) { 'example_spec.rb' }
-
-          it 'aborts' do
-            should be_false
-          end
+        it 'skips dynamic analysis' do
+          DynamicAnalyzer.any_instance.should_not_receive(:analysis)
+          cli.should_receive(:convert_file)
+          cli.run(args)
         end
       end
 
-      context 'when -m/--commit-message option is specified' do
+      context 'when -m/--generate-commit-message option is specified' do
         include_context 'inside of git repository'
 
-        let(:args) { ['--force', '--commit-message', file_path] }
+        let(:args) { ['--force', '--generate-commit-message', file_path] }
 
         context 'and any conversion is done' do
           it 'writes commit message to .git/COMMIT_EDITMSG' do
@@ -196,9 +163,23 @@ module Transpec
           end
         end
       end
+
+      context 'when -c/--rspec-command option is specified' do
+        include_context 'inside of git repository'
+
+        let(:args) { ['--force', '--rspec-command', 'rspec --profile'] }
+
+        it 'passes the command to DynamicAnalyzer' do
+          DynamicAnalyzer.should_receive(:new) do |arg|
+            arg[:rspec_command].should == 'rspec --profile'
+          end.and_call_original
+
+          cli.run(args)
+        end
+      end
     end
 
-    describe '#process_file' do
+    describe '#convert_file' do
       include_context 'isolated environment'
 
       let(:file_path) { 'example.rb' }
@@ -231,197 +212,7 @@ module Transpec
             message.should =~ /context/i
           end
 
-          cli.process_file(file_path)
-        end
-      end
-    end
-
-    describe '#parse_options' do
-      subject { cli.parse_options(args) }
-      let(:args) { ['some_file', '--negative-form', 'to_not', 'some_dir'] }
-
-      it 'return non-option arguments' do
-        should == ['some_file', 'some_dir']
-      end
-
-      it 'does not mutate the passed array' do
-        cli.parse_options(args)
-        args.should == ['some_file', '--negative-form', 'to_not', 'some_dir']
-      end
-
-      describe '-f/--force option' do
-        let(:args) { ['--force'] }
-
-        it 'sets #forced? true' do
-          cli.parse_options(args)
-          cli.should be_forced
-        end
-      end
-
-      describe '-m/--commit-message option' do
-        include_context 'isolated environment'
-
-        let(:args) { ['--commit-message'] }
-
-        context 'when inside of git repository' do
-          include_context 'inside of git repository'
-
-          it 'sets #generates_commit_message? true' do
-            cli.parse_options(args)
-            cli.generates_commit_message?.should be_true
-          end
-        end
-
-        context 'when not inside of git repository' do
-          it 'raises error' do
-            -> { cli.parse_options(args) }.should raise_error(/not in a Git repository/)
-          end
-        end
-      end
-
-      describe '-d/--disable option' do
-        [
-          ['expect_to_matcher', :convert_to_expect_to_matcher?],
-          ['expect_to_receive', :convert_to_expect_to_receive?],
-          ['allow_to_receive',  :convert_to_allow_to_receive?],
-          ['deprecated',        :replace_deprecated_method?]
-        ].each do |cli_type, config_attr|
-          context "when #{cli_type.inspect} is specified" do
-            let(:args) { ['--disable', cli_type] }
-
-            it "sets Configuration##{config_attr} false" do
-              cli.parse_options(args)
-              cli.configuration.send(config_attr).should be_false
-            end
-          end
-        end
-
-        context 'when multiple types are specified with comma' do
-          let(:args) { ['--disable', 'allow_to_receive,deprecated'] }
-
-          it 'handles all of them' do
-            cli.parse_options(args)
-            cli.configuration.convert_to_allow_to_receive?.should be_false
-            cli.configuration.replace_deprecated_method?.should be_false
-          end
-        end
-
-        context 'when unknown type is specified' do
-          let(:args) { ['--disable', 'unknown'] }
-
-          it 'raises error' do
-            -> { cli.parse_options(args) }.should raise_error(ArgumentError) { |error|
-              error.message.should == 'Unknown conversion type "unknown"'
-            }
-          end
-        end
-      end
-
-      describe '-n/--negative-form option' do
-        ['not_to', 'to_not'].each do |form|
-          context "when #{form.inspect} is specified" do
-            let(:args) { ['--negative-form', form] }
-
-            it "sets Configuration#negative_form_of_to? #{form.inspect}" do
-              cli.parse_options(args)
-              cli.configuration.negative_form_of_to.should == form
-            end
-          end
-        end
-      end
-
-      describe '-p/--no-parentheses-matcher-arg option' do
-        let(:args) { ['--no-parentheses-matcher-arg'] }
-
-        it 'sets Configuration#parenthesize_matcher_arg? false' do
-          cli.parse_options(args)
-          cli.configuration.parenthesize_matcher_arg.should be_false
-        end
-      end
-
-      describe '--no-color option' do
-        before do
-          Sickill::Rainbow.enabled = true
-        end
-
-        let(:args) { ['--no-color'] }
-
-        it 'disables color in the output' do
-          cli.parse_options(args)
-          Sickill::Rainbow.enabled.should be_false
-        end
-      end
-
-      describe '--version option' do
-        before do
-          cli.stub(:puts)
-          cli.stub(:exit)
-        end
-
-        let(:args) { ['--version'] }
-
-        it 'shows version' do
-          cli.should_receive(:puts).with(Version.to_s)
-          cli.parse_options(args)
-        end
-
-        it 'exits' do
-          cli.should_receive(:exit)
-          cli.parse_options(args)
-        end
-      end
-    end
-
-    describe '#target_files' do
-      include_context 'isolated environment'
-
-      before do
-        ['file', 'file.rb', 'dir/file', 'dir/file.rb'].each do |path|
-          create_file(path, '')
-        end
-      end
-
-      subject(:target_files) { cli.target_files(paths) }
-
-      context 'when no path is passed' do
-        let(:paths) { [] }
-
-        it 'returns empty array' do
-          should be_empty
-        end
-      end
-
-      context 'when a file path with .rb extension is passed' do
-        let(:paths) { ['file.rb'] }
-
-        it 'returns the path' do
-          should == ['file.rb']
-        end
-      end
-
-      context 'when a file path without extension is passed' do
-        let(:paths) { ['file'] }
-
-        it 'returns the path' do
-          should == ['file']
-        end
-      end
-
-      context 'when a non-existent path is passed' do
-        let(:paths) { ['non-existent-file'] }
-
-        it 'raises error' do
-          -> { target_files }.should raise_error(ArgumentError) { |error|
-            error.message.should == 'No such file or directory "non-existent-file"'
-          }
-        end
-      end
-
-      context 'when a directory path is passed' do
-        let(:paths) { ['dir'] }
-
-        it 'returns file paths with .rb extension in the directory recursively' do
-          should == ['dir/file.rb']
+          cli.convert_file(file_path)
         end
       end
     end

data/spec/transpec/commit_message_spec.rb

@@ -9,7 +9,7 @@ module Transpec
   describe CommitMessage do
     subject(:commit_message) { CommitMessage.new(report, cli_args) }
     let(:report) { Report.new }
-    let(:cli_args) { %w(--force --commit-message) }
+    let(:cli_args) { %w(--force --generate-commit-message) }
 
     before do
       report.records << Record.new('obj.stub(:message)', 'allow(obj).to receive(:message)')
@@ -40,7 +40,7 @@ module Transpec
         body_lines[0].chomp
           .should match(/^This conversion is done by Transpec \d+\.\d+\.\d+ with the following command:$/)
         body_lines[1].chomp
-          .should ==     '    transpec --force --commit-message'
+          .should ==     '    transpec --force --generate-commit-message'
       end
 
       it 'has blank line after the preface in the body' do

data/spec/transpec/configuration_spec.rb

@@ -9,17 +9,21 @@ module Transpec
 
     context 'by default' do
       [
-        :convert_to_expect_to_matcher?,
-        :convert_to_expect_to_receive?,
-        :convert_to_allow_to_receive?,
-        :replace_deprecated_method?,
-        :parenthesize_matcher_arg?
-      ].each do |attribute|
+        [:convert_should?,            true],
+        [:convert_should_receive?,    true],
+        [:convert_stub?,              true],
+        [:convert_have_items?,        true],
+        [:convert_deprecated_method?, true],
+        [:parenthesize_matcher_arg?,  true],
+        [:forced?,                    false],
+        [:skip_dynamic_analysis?,     false],
+        [:generate_commit_message?,   false]
+      ].each do |attribute, value|
         describe "##{attribute}" do
           subject { configuration.send(attribute) }
 
-          it 'is true' do
-            should be_true
+          it "is #{value}" do
+            should == value
           end
         end
       end