transpec 0.2.6 → 1.0.0

data/spec/transpec/syntax/method_stub_spec.rb

@@ -14,12 +14,15 @@ module Transpec
           return MethodStub.new(
             node,
             ancestor_nodes,
-            source_rewriter
+            source_rewriter,
+            runtime_data
           )
         end
         fail 'No method stub node is found!'
       end
 
+      let(:runtime_data) { nil }
+
       let(:record) { method_stub_object.report.records.first }
 
       describe '.target_node?' do
@@ -36,8 +39,10 @@ module Transpec
         context 'when #stub node is passed' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo)
+                end
               end
             END
           end
@@ -47,31 +52,44 @@ module Transpec
           end
         end
 
-        context 'when #stub node with Typhoeus receiver is passed' do
-          let(:source) do
-            <<-END
-              it "is not RSpec's #stub" do
-                ::Typhoeus.stub(url, :method => method).and_return(response)
-              end
-            END
-          end
+        context 'with runtime information' do
+          include_context 'dynamic analysis objects'
 
-          it 'returns false' do
-            MethodStub.target_node?(send_node).should be_false
-          end
-        end
+          context "when RSpec's #stub node is passed" do
+            let(:source) do
+              <<-END
+                describe 'example' do
+                  it 'responds to #foo' do
+                    subject.stub(:foo)
+                  end
+                end
+              END
+            end
 
-        context 'when #stub node with Excon receiver is passed' do
-          let(:source) do
-            <<-END
-              it "is not RSpec's #stub" do
-                ::Excon.stub({}, {:body => 'body', :status => 200})
-              end
-            END
+            it 'returns true' do
+              MethodStub.target_node?(send_node, runtime_data).should be_true
+            end
           end
 
-          it 'returns false' do
-            MethodStub.target_node?(send_node).should be_false
+          context 'when another #stub node is passed' do
+            let(:source) do
+              <<-END
+                module AnotherStubProvider
+                  def self.stub(*args)
+                  end
+                end
+
+                describe 'example' do
+                  it "is not RSpec's #stub" do
+                    AnotherStubProvider.stub(:something)
+                  end
+                end
+              END
+            end
+
+            it 'returns false' do
+              MethodStub.target_node?(send_node, runtime_data).should be_false
+            end
           end
         end
       end
@@ -79,8 +97,10 @@ module Transpec
       describe '#method_name' do
         let(:source) do
           <<-END
-            it 'responds to #foo' do
-              subject.stub(:foo)
+            describe 'example' do
+              it 'responds to #foo' do
+                subject.stub(:foo)
+              end
             end
           END
         end
@@ -91,57 +111,127 @@ module Transpec
       end
 
       describe '#allowize!' do
-        before do
-          method_stub_object.context.stub(:allow_to_receive_available?).and_return(true)
-          method_stub_object.allowize!
-        end
-
         [:stub, :stub!].each do |method|
           context "when it is `subject.#{method}(:method)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo' do
-                  subject.#{method}(:foo)
+                describe 'example' do
+                  it 'responds to #foo' do
+                    subject.#{method}(:foo)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo' do
-                  allow(subject).to receive(:foo)
+                describe 'example' do
+                  it 'responds to #foo' do
+                    allow(subject).to receive(:foo)
+                  end
                 end
               END
             end
 
             it 'converts into `allow(subject).to receive(:method)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
 
             it "adds record \"`obj.#{method}(:message)` -> `allow(obj).to receive(:message)`\"" do
+              method_stub_object.allowize!
               record.original_syntax.should  == "obj.#{method}(:message)"
               record.converted_syntax.should == 'allow(obj).to receive(:message)'
             end
+
+            context 'and #allow and #receive are not available in the context' do
+              context 'and the context is determinable statically' do
+                let(:source) do
+                  <<-END
+                    describe 'example' do
+                      class TestRunner
+                        def run
+                          'something'.#{method}(:foo)
+                        end
+                      end
+
+                      it 'responds to #foo' do
+                        TestRunner.new.run
+                      end
+                    end
+                  END
+                end
+
+                context 'with runtime information' do
+                  include_context 'dynamic analysis objects'
+
+                  it 'raises InvalidContextError' do
+                    -> { method_stub_object.allowize! }.should raise_error(InvalidContextError)
+                  end
+                end
+
+                context 'without runtime information' do
+                  it 'raises InvalidContextError' do
+                    -> { method_stub_object.allowize! }.should raise_error(InvalidContextError)
+                  end
+                end
+              end
+
+              context 'and the context is not determinable statically' do
+                let(:source) do
+                  <<-END
+                    def my_eval(&block)
+                      Object.new.instance_eval(&block)
+                    end
+
+                    describe 'example' do
+                      it 'responds to #foo' do
+                        my_eval { 'something'.#{method}(:foo) }
+                      end
+                    end
+                  END
+                end
+
+                context 'with runtime information' do
+                  include_context 'dynamic analysis objects'
+
+                  it 'raises InvalidContextError' do
+                    -> { method_stub_object.allowize! }.should raise_error(InvalidContextError)
+                  end
+                end
+
+                context 'without runtime information' do
+                  it 'does not raise InvalidContextError' do
+                    -> { method_stub_object.allowize! }.should_not raise_error
+                  end
+                end
+              end
+            end
           end
 
           context "when it is `subject.#{method}(:method).and_return(value)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  subject.#{method}(:foo).and_return(1)
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    subject.#{method}(:foo).and_return(1)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  allow(subject).to receive(:foo).and_return(1)
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    allow(subject).to receive(:foo).and_return(1)
+                  end
                 end
               END
             end
 
             it 'converts into `allow(subject).to receive(:method).and_return(value)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
           end
@@ -149,21 +239,26 @@ module Transpec
           context "when it is `subject.#{method}(:method).and_raise(RuntimeError)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo and raises RuntimeError' do
-                  subject.#{method}(:foo).and_raise(RuntimeError)
+                describe 'example' do
+                  it 'responds to #foo and raises RuntimeError' do
+                    subject.#{method}(:foo).and_raise(RuntimeError)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo and raises RuntimeError' do
-                  allow(subject).to receive(:foo).and_raise(RuntimeError)
+                describe 'example' do
+                  it 'responds to #foo and raises RuntimeError' do
+                    allow(subject).to receive(:foo).and_raise(RuntimeError)
+                  end
                 end
               END
             end
 
             it 'converts into `allow(subject).to receive(:method).and_raise(RuntimeError)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
           end
@@ -171,31 +266,36 @@ module Transpec
           context 'when the statement continues over multi lines' do
             let(:source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  subject.#{method}(
-                      :foo
-                    ).
-                    and_return(
-                      1
-                    )
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    subject.#{method}(
+                        :foo
+                      ).
+                      and_return(
+                        1
+                      )
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  allow(subject).to receive(
-                      :foo
-                    ).
-                    and_return(
-                      1
-                    )
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    allow(subject).to receive(
+                        :foo
+                      ).
+                      and_return(
+                        1
+                      )
+                  end
                 end
               END
             end
 
             it 'keeps the style as far as possible' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
           end
@@ -203,26 +303,32 @@ module Transpec
           context "when it is `subject.#{method}(:method => value)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  subject.#{method}(:foo => 1)
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    subject.#{method}(:foo => 1)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  allow(subject).to receive(:foo).and_return(1)
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    allow(subject).to receive(:foo).and_return(1)
+                  end
                 end
               END
             end
 
             it 'converts into `allow(subject).to receive(:method).and_return(value)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
 
             it 'adds record ' +
                "\"`obj.#{method}(:message => value)` -> `allow(obj).to receive(:message).and_return(value)`\"" do
+              method_stub_object.allowize!
               record.original_syntax.should  == "obj.#{method}(:message => value)"
               record.converted_syntax.should == 'allow(obj).to receive(:message).and_return(value)'
             end
@@ -231,26 +337,32 @@ module Transpec
           context "when it is `subject.#{method}(method: value)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  subject.#{method}(foo: 1)
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    subject.#{method}(foo: 1)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo and returns 1' do
-                  allow(subject).to receive(:foo).and_return(1)
+                describe 'example' do
+                  it 'responds to #foo and returns 1' do
+                    allow(subject).to receive(:foo).and_return(1)
+                  end
                 end
               END
             end
 
             it 'converts into `allow(subject).to receive(:method).and_return(value)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
 
             it 'adds record ' +
                "\"`obj.#{method}(:message => value)` -> `allow(obj).to receive(:message).and_return(value)`\"" do
+              method_stub_object.allowize!
               record.original_syntax.should  == "obj.#{method}(:message => value)"
               record.converted_syntax.should == 'allow(obj).to receive(:message).and_return(value)'
             end
@@ -259,28 +371,34 @@ module Transpec
           context "when it is `subject.#{method}(:a_method => a_value, b_method => b_value)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
-                  subject.#{method}(:foo => 1, :bar => 2)
+                describe 'example' do
+                  it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
+                    subject.#{method}(:foo => 1, :bar => 2)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
-                  allow(subject).to receive(:foo).and_return(1)
-                  allow(subject).to receive(:bar).and_return(2)
+                describe 'example' do
+                  it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
+                    allow(subject).to receive(:foo).and_return(1)
+                    allow(subject).to receive(:bar).and_return(2)
+                  end
                 end
               END
             end
 
             it 'converts into `allow(subject).to receive(:a_method).and_return(a_value)` ' +
                'and `allow(subject).to receive(:b_method).and_return(b_value)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
 
             it 'adds record ' +
                "\"`obj.#{method}(:message => value)` -> `allow(obj).to receive(:message).and_return(value)`\"" do
+              method_stub_object.allowize!
               record.original_syntax.should  == "obj.#{method}(:message => value)"
               record.converted_syntax.should == 'allow(obj).to receive(:message).and_return(value)'
             end
@@ -288,28 +406,33 @@ module Transpec
             context 'when the statement continues over multi lines' do
               let(:source) do
                 <<-END
-                  it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
-                    subject
-                      .#{method}(
-                        :foo => 1,
-                        :bar => 2
-                      )
+                  describe 'example' do
+                    it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
+                      subject
+                        .#{method}(
+                          :foo => 1,
+                          :bar => 2
+                        )
+                    end
                   end
                 END
               end
 
               let(:expected_source) do
                 <<-END
-                  it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
-                    allow(subject)
-                      .to receive(:foo).and_return(1)
-                    allow(subject)
-                      .to receive(:bar).and_return(2)
+                  describe 'example' do
+                    it 'responds to #foo and returns 1, and responds to #bar and returns 2' do
+                      allow(subject)
+                        .to receive(:foo).and_return(1)
+                      allow(subject)
+                        .to receive(:bar).and_return(2)
+                    end
                   end
                 END
               end
 
               it 'keeps the style except around the hash' do
+                method_stub_object.allowize!
                 rewritten_source.should == expected_source
               end
             end
@@ -320,17 +443,21 @@ module Transpec
           context "when it is `subject.#{method}(:method)` form" do
             let(:source) do
               <<-END
-                it 'does not respond to #foo' do
-                  subject.#{method}(:foo)
+                describe 'example' do
+                  it 'does not respond to #foo' do
+                    subject.#{method}(:foo)
+                  end
                 end
               END
             end
 
             it 'does nothing' do
+              method_stub_object.allowize!
               rewritten_source.should == source
             end
 
             it 'reports nothing' do
+              method_stub_object.allowize!
               method_stub_object.report.records.should be_empty
             end
           end
@@ -340,26 +467,32 @@ module Transpec
           context "when it is `SomeClass.any_instance.#{method}(:method)` form" do
             let(:source) do
               <<-END
-                it 'responds to #foo' do
-                  SomeClass.any_instance.#{method}(:foo)
+                describe 'example' do
+                  it 'responds to #foo' do
+                    SomeClass.any_instance.#{method}(:foo)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it 'responds to #foo' do
-                  allow_any_instance_of(SomeClass).to receive(:foo)
+                describe 'example' do
+                  it 'responds to #foo' do
+                    allow_any_instance_of(SomeClass).to receive(:foo)
+                  end
                 end
               END
             end
 
             it 'converts into `allow_any_instance_of(SomeClass).to receive(:method)` form' do
+              method_stub_object.allowize!
               rewritten_source.should == expected_source
             end
 
             it "adds record \"`SomeClass.any_instance.#{method}(:message)` " +
                '-> `allow_any_instance_of(obj).to receive(:message)`"' do
+              method_stub_object.allowize!
               record.original_syntax.should  == "SomeClass.any_instance.#{method}(:message)"
               record.converted_syntax.should == 'allow_any_instance_of(SomeClass).to receive(:message)'
             end
@@ -370,26 +503,30 @@ module Transpec
           context "when it is `SomeClass.any_instance.#{method}(:method)` form" do
             let(:source) do
               <<-END
-                it 'does not respond to #foo' do
-                  SomeClass.any_instance.#{method}(:foo)
+                describe 'example' do
+                  it 'does not respond to #foo' do
+                    SomeClass.any_instance.#{method}(:foo)
+                  end
                 end
               END
             end
 
             it 'does nothing' do
+              method_stub_object.allowize!
               rewritten_source.should == source
             end
 
             it 'reports nothing' do
+              method_stub_object.allowize!
               method_stub_object.report.records.should be_empty
             end
           end
         end
       end
 
-      describe '#replace_deprecated_method!' do
+      describe '#convert_deprecated_method!' do
         before do
-          method_stub_object.replace_deprecated_method!
+          method_stub_object.convert_deprecated_method!
         end
 
         [
@@ -399,16 +536,20 @@ module Transpec
           context "when it is ##{method}" do
             let(:source) do
               <<-END
-                it '#{description} #foo' do
-                  subject.#{method}(:foo)
+                describe 'example' do
+                  it '#{description} #foo' do
+                    subject.#{method}(:foo)
+                  end
                 end
               END
             end
 
             let(:expected_source) do
               <<-END
-                it '#{description} #foo' do
-                  subject.#{replacement_method}(:foo)
+                describe 'example' do
+                  it '#{description} #foo' do
+                    subject.#{replacement_method}(:foo)
+                  end
                 end
               END
             end
@@ -432,8 +573,10 @@ module Transpec
           context "when it is ##{method}" do
             let(:source) do
               <<-END
-                it '#{description} #foo' do
-                  subject.#{method}(:foo)
+                describe 'example' do
+                  it '#{description} #foo' do
+                    subject.#{method}(:foo)
+                  end
                 end
               END
             end
@@ -455,8 +598,10 @@ module Transpec
         context 'when it is `subject.stub(:method).any_number_of_times` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo).any_number_of_times
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo).any_number_of_times
+                end
               end
             END
           end
@@ -467,8 +612,10 @@ module Transpec
         context 'when it is `subject.stub(:method).with(arg).any_number_of_times` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo with 1' do
-                subject.stub(:foo).with(1).any_number_of_times
+              describe 'example' do
+                it 'responds to #foo with 1' do
+                  subject.stub(:foo).with(1).any_number_of_times
+                end
               end
             END
           end
@@ -479,8 +626,10 @@ module Transpec
         context 'when it is `subject.stub(:method).at_least(0)` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo).at_least(0)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo).at_least(0)
+                end
               end
             END
           end
@@ -491,8 +640,10 @@ module Transpec
         context 'when it is `subject.stub(:method)` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo)
+                end
               end
             END
           end
@@ -509,16 +660,20 @@ module Transpec
         context 'when it is `subject.stub(:method).any_number_of_times` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo).any_number_of_times
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo).any_number_of_times
+                end
               end
             END
           end
 
           let(:expected_source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo)
+                end
               end
             END
           end
@@ -531,16 +686,20 @@ module Transpec
         context 'when it is `subject.stub(:method).at_least(0)` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo).at_least(0)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo).at_least(0)
+                end
               end
             END
           end
 
           let(:expected_source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo)
+                end
               end
             END
           end
@@ -553,8 +712,10 @@ module Transpec
         context 'when it is `subject.stub(:method)` form' do
           let(:source) do
             <<-END
-              it 'responds to #foo' do
-                subject.stub(:foo)
+              describe 'example' do
+                it 'responds to #foo' do
+                  subject.stub(:foo)
+                end
               end
             END
           end