trackler 2.2.1.24 → 2.2.1.25

data/tracks/javascript/config/maintainers.json

@@ -1,85 +1,85 @@
 {
+  "docs_url": "https://github.com/exercism/docs/blob/master/maintaining-a-track/maintainer-configuration.md",
   "maintainers": [
     {
-      "github_username": "ireddick",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "ireddick",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "rchavarria",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "rchavarria",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "joelwallis",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "joelwallis",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "drueck",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "drueck",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "tejasbubane",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "tejasbubane",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "matthewmorgan",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "matthewmorgan",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "mixolidia",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "mixolidia",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     },
     {
-      "github_username": "ZacharyRSmith",
-      "show_on_website": false,
       "alumnus": false,
-      "name": null,
+      "avatar_url": null,
       "bio": null,
+      "github_username": "ZacharyRSmith",
       "link_text": null,
       "link_url": null,
-      "avatar_url": null
+      "name": null,
+      "show_on_website": false
     }
-  ],
-  "docs_url": "https://github.com/exercism/docs/blob/master/maintaining-a-track/maintainer-configuration.md"
-}
+  ]
+}

data/tracks/javascript/exercises/simple-cipher/simple-cipher.spec.js

@@ -4,7 +4,7 @@ describe('Random key cipher', function () {
   var cipher = new Cipher();
 
   it('has a key made of letters', function () {
-    expect(cipher.key).toMatch(/[a-z]+/);
+    expect(cipher.key).toMatch(/^[a-z]+$/);
   });
 
   // Here we take advantage of the fact that plaintext of "aaa..."
@@ -69,10 +69,14 @@ describe('Substitution cipher', function () {
       .toEqual('qayaeaagaciai');
   });
 
-  xit('can wrap', function () {
+  xit('can wrap on encode', function () {
     expect(cipher.encode('zzzzzzzzzz')).toEqual('zabcdefghi');
   });
-  
+
+  xit('can wrap on decode', () => {
+    expect(cipher.decode('zabcdefghi')).toEqual('zzzzzzzzzz');
+  });
+
   xit('can handle messages longer than the key', function() {
     expect(new Cipher('abc').encode('iamapandabear'))
       .toEqual('iboaqcnecbfcr');

data/tracks/plsql/config.json

@@ -1,110 +1,96 @@
 {
-  "language": "PL/SQL",
   "active": true,
-  "test_pattern": "ut.*plsql",
-  "foregone": [
-
-  ],
   "exercises": [
     {
-      "uuid": "b779f211-ecec-45cc-8641-e7cf87ff66ce",
-      "slug": "hamming",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "hello-world",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "53156fc9-0945-f080-08a9-ce269bfc9121a5d2c5c"
     },
     {
-      "uuid": "6722fe30-30d2-4e99-87de-03b1a6eee0d6",
-      "slug": "gigasecond",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "hamming",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "b779f211-ecec-45cc-8641-e7cf87ff66ce"
     },
     {
-      "uuid": "eec6c29b-fbbb-48d5-a0e9-4c902281390e",
-      "slug": "rna-transcription",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "gigasecond",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "6722fe30-30d2-4e99-87de-03b1a6eee0d6"
     },
     {
-      "uuid": "2eaf11fe-e56e-4512-b8af-8fb637582a5e",
-      "slug": "raindrops",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "rna-transcription",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "eec6c29b-fbbb-48d5-a0e9-4c902281390e"
     },
     {
-      "uuid": "f630b17b-59c1-448b-8880-85bb0c72ba5a",
-      "slug": "difference-of-squares",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "raindrops",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "2eaf11fe-e56e-4512-b8af-8fb637582a5e"
     },
     {
-      "uuid": "fc75b71e-e3e6-43b2-940b-65c06a6f9bc5",
-      "slug": "roman-numerals",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "difference-of-squares",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "f630b17b-59c1-448b-8880-85bb0c72ba5a"
     },
     {
-      "uuid": "bede5fe0-43bf-4483-9fc3-7030df042515",
-      "slug": "nth-prime",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "roman-numerals",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "fc75b71e-e3e6-43b2-940b-65c06a6f9bc5"
     },
     {
-      "uuid": "50e2a7c5-3f71-448d-b203-65b7c0e3d6d5",
-      "slug": "leap",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "nth-prime",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "bede5fe0-43bf-4483-9fc3-7030df042515"
     },
     {
-      "uuid": "1d661c32-c75d-4c0b-bf88-ed0112bb1ab2",
-      "slug": "grains",
       "core": false,
-      "unlocked_by": null,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "leap",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "50e2a7c5-3f71-448d-b203-65b7c0e3d6d5"
     },
     {
-      "uuid": "6277f225-5d28-45f1-b020-9b821150ecfe",
-      "slug": "binary",
       "core": false,
+      "difficulty": 1,
+      "slug": "grains",
+      "topics": null,
       "unlocked_by": null,
+      "uuid": "1d661c32-c75d-4c0b-bf88-ed0112bb1ab2"
+    },
+    {
+      "core": false,
       "difficulty": 1,
-      "topics": [
-
-      ]
+      "slug": "binary",
+      "topics": null,
+      "unlocked_by": null,
+      "uuid": "6277f225-5d28-45f1-b020-9b821150ecfe"
     }
-  ]
-}
+  ],
+  "foregone": [],
+  "language": "PL/SQL",
+  "test_pattern": "ut.*plsql"
+}

data/tracks/plsql/docs/SNIPPET.txt

@@ -0,0 +1,6 @@
+DECLARE
+   message varchar2(20):= 'Hello, World!';
+BEGIN
+   dbms_output.put_line(message);
+END;
+/

data/tracks/plsql/exercises/hello-world/example.plsql

@@ -0,0 +1,20 @@
+CREATE OR REPLACE PACKAGE hello_world# IS
+   FUNCTION hello(
+      i_name                                        varchar2 := 'World'
+   ) 
+      RETURN varchar2;
+
+END hello_world#;
+/
+
+CREATE OR REPLACE PACKAGE BODY hello_world# IS
+   FUNCTION hello(
+      i_name                                        varchar2 := 'World'
+   ) 
+      RETURN varchar2
+   AS
+   BEGIN
+      RETURN 'Hello, ' || i_name || '!';
+   END hello;
+END hello_world#;
+/

data/tracks/plsql/exercises/hello-world/hello_world#.plsql

@@ -0,0 +1,20 @@
+CREATE OR REPLACE PACKAGE hello_world# IS
+   FUNCTION hello(
+      i_name                                        varchar2 := ''
+   ) 
+      RETURN varchar2;
+
+END hello_world#;
+/
+
+CREATE OR REPLACE PACKAGE BODY hello_world# IS
+   FUNCTION hello(
+      i_name                                        varchar2 := ''
+   ) 
+      RETURN varchar2
+   AS
+   BEGIN
+      RETURN NULL;
+   END hello;
+END hello_world#;
+/

data/tracks/plsql/exercises/hello-world/ut_hello_world#.plsql

@@ -0,0 +1,60 @@
+CREATE OR REPLACE PACKAGE ut_hello_world#
+IS
+   PROCEDURE run;
+END ut_hello_world#;
+/
+
+CREATE OR REPLACE PACKAGE BODY ut_hello_world#
+IS
+
+   PROCEDURE TEST (
+      i_descn     varchar2,
+      i_exp       varchar2,
+      i_act       varchar2
+   )
+   IS
+   BEGIN
+      IF i_exp = i_act THEN
+         dbms_output.put_line('SUCCESS: ' || i_descn);
+      ELSE
+         dbms_output.put_line(
+            'FAILURE: '   || i_descn || 
+            ': expected ''' || NVL('' || i_exp, 'NULL') || 
+            ''', but got '''  || NVL('' || i_act, 'null') || '''!'
+         );
+      END IF;
+   END TEST;
+
+   PROCEDURE run
+   IS
+   BEGIN
+      TEST(
+         i_descn  => 'no name',
+         i_exp    => 'Hello, World!',
+         i_act    => hello_world#.hello()
+      );
+      
+      TEST(
+         i_descn  => 'sample name',
+         i_exp    => 'Hello, Alice!',
+         i_act    => hello_world#.hello('Alice')
+      );
+      
+      TEST(
+         i_descn  => 'other sample name',
+         i_exp    => 'Hello, Bob!',
+         i_act    => hello_world#.hello('Bob')
+      );
+   EXCEPTION
+      WHEN others THEN
+         dbms_output.put_line('Test execution failed.');
+         dbms_output.put_line(sqlerrm);
+   END run;
+
+END ut_hello_world#;
+/
+
+BEGIN
+   ut_hello_world#.run;
+END;
+/

data/tracks/sml/Makefile

@@ -36,6 +36,11 @@ test-%:
 	$(eval exercise := $(patsubst test-%, %, $@))
 	@echo
 	@ls ./exercises/$(exercise)/README.md > /dev/null
+	@# check stub type
+	@cd ./exercises/$(exercise) && \
+		poly -q --use test | grep 'error: Type error' | \
+		wc -l | xargs -I @ expr @ = 0 > /dev/null || \
+		{ echo '$(exercise).sml is faulty'; exit 1; }
 	@cd ./exercises/$(exercise) && cat test.sml | sed 's/$(exercise).sml/example.sml/' | poly -q
 	@echo
 

data/tracks/sml/bin/generate

@@ -21,7 +21,7 @@ def fetch(exercise):
             return json.loads(response.read().decode('utf8'))
     except HTTPError as e:
         if e.status == HTTPStatus.NOT_FOUND.value:
-            msg = "Exercise '%s' doesn't exist." % exercise
+            msg = "canonical-data.json was not found."
         else:
             msg = 'Unexpected error, please try again later.'
         raise Exception(msg)
@@ -96,18 +96,17 @@ def sml_value(value, smltype=''):
 
 
 def get_fn_args(case):
-    ignored_keys = {'property', 'expected', 'description', 'comments'}
+    reserved_keys = {'property', 'expected', 'description', 'comments'}
     return OrderedDict(
         (k, case[k])
         for k in sorted(case.keys())
-        if k not in ignored_keys
+        if k not in reserved_keys
     )
 
 
 def extract_signatures(data):
     funcs = OrderedDict()
     exercise = data['exercise']
-    ignored_keys = {'property', 'expected', 'description', 'comments'}
 
     def type_aux(values):
         s = {sml_type(val) for val in values}