tomato_power 0.0.5 → 0.0.7

data/spec/unit_specs/{api_spec.rb → api/api_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module TomatoPower 
-  describe TomatoPower::API , :vcr => {:record => :new_episodes} do
+  describe API , :vcr => {:record => :new_episodes} do
     before do
       @api = TomatoPower::API.new TestHelpers::api_key
     end
@@ -37,43 +37,19 @@ module TomatoPower
       end
     end
 
-    describe "API options validation" do
-
-      describe "valid options" do
-
-        it "should not raise error" do
-          expect {@api.movies_search({:q => "jack",:page => 1,
-                                     :page_limit => 2})}.not_to raise_error
-        end
-
-        it "should consider 0 options valid" do
-          expect {@api.box_office_movies}.not_to raise_error
-          expect {@api.movies_search}.not_to raise_error
-        end
-
-      end
-
-      describe "invalid options" do
-        it "should raise error" do
-          expect {@api.movies_search({:invalid => "jack",:invalid => 1,
-                                     :invalid => 2})}.to raise_error
-        end
-      end
-    end
-
     describe "List request" do
 
       describe "searching by title" do
         it "should return a list of movie objects" do
           movies = @api.movies_search({:q => "jack", :page_limit => 2})
           movies.should be_kind_of(Array)
-          movies[0].should be_kind_of(TomatoPower::Movie)
+          movies[0].should be_kind_of(Movie)
         end
 
         it "should url encode search string before sending" do
           movies = @api.movies_search({:q => "Mission Impossible", :page_limit => 2})
           movies.should be_kind_of(Array)
-          movies[0].should be_kind_of(TomatoPower::Movie)
+          movies[0].should be_kind_of(Movie)
         end
       end
     end

data/spec/unit_specs/helpers/helpers.rb

@@ -0,0 +1,53 @@
+module TestHelpers
+  String.class_eval do
+    def is_valid_url?
+      uri = URI.parse self
+      uri.kind_of? URI::HTTP
+    rescue URI::InvalidURIError
+      false
+    end
+  end
+
+  def self.api_key
+    begin
+      api_key = ENV.fetch("ROTTEN_TOMATOES_API_KEY")
+    rescue
+      api_key_file = File.join(File.expand_path(File.dirname(__FILE__)),
+                               '../../config', 'tomato_power_config.yaml')
+      raise "tomato_power_config not found" unless File.exists?(api_key_file)
+      ENV["ROTTEN_TOMATOES_API_KEY"] = 
+        YAML::load(File.open(api_key_file))["ROTTEN_TOMATOES_API_KEY"]
+    end
+  end
+
+  def self.sample sample_type 
+    sample_data_path = "../../support/sample_data/"
+    case sample_type
+    when :movie
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_movie')
+    when :movies
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_movies')
+    when :actor
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_actor')
+    when :actors
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_actors')
+    when :clip
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_clip')
+    when :clips
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_clips')
+    when :review
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_review')
+    when :reviews
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_reviews')
+    when :poster
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_posters')
+    when :alias
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'sample_alias')
+    when :no_results
+      file = File.join(File.dirname(__FILE__), sample_data_path, 'no_results')
+    else
+      raise ArgumentError.new("Unrecognized type: #{type}")
+    end
+    JSON.parse(File.open(file).read)
+  end
+end

data/spec/unit_specs/{parsers_spec.rb → helpers/parsers_spec.rb}

@@ -3,7 +3,7 @@ require 'json'
 
 module TomatoPower
   module Parser
-    describe TomatoPower::Parser do
+    describe Parser do
       describe "parse" do
         before do
           @movies = TestHelpers::sample :movies 
@@ -15,37 +15,37 @@ module TomatoPower
         end
         describe "movies" do
           it "should return correct payload" do
-            payload = TomatoPower::Parser::parse @movies
-            payload.first.should be_kind_of(TomatoPower::Movie)
+            payload = Parser::parse @movies
+            payload.first.should be_kind_of(Movie)
           end
         end
         describe "actors" do
           it "should return correct payload" do
-            payload = TomatoPower::Parser::parse @actors
-            payload.first.should be_kind_of(TomatoPower::Actor)
+            payload = Parser::parse @actors
+            payload.first.should be_kind_of(Actor)
           end
         end
         describe "clips" do
           it "should return correct payload" do
-            payload = TomatoPower::Parser::parse @clips
-            payload.first.should be_kind_of(TomatoPower::Clip)
+            payload = Parser::parse @clips
+            payload.first.should be_kind_of(Clip)
           end
         end
         describe "reviews" do
           it "should return correct payload" do
-            payload = TomatoPower::Parser::parse @reviews
-            payload.first.should be_kind_of(TomatoPower::Review)
+            payload = Parser::parse @reviews
+            payload.first.should be_kind_of(Review)
           end
         end
         describe "alias" do
           it "should return correct payload" do
-            payload = TomatoPower::Parser::parse @alias
-            payload.first.should be_kind_of(TomatoPower::Movie)
+            payload = Parser::parse @alias
+            payload.first.should be_kind_of(Movie)
           end
         end
         describe "No results" do
           it "should return payload with no results string" do
-            payload = TomatoPower::Parser::parse @no_results
+            payload = Parser::parse @no_results
             payload.first.include?("No Results").should be_true
           end
         end

data/spec/unit_specs/helpers_spec.rb

@@ -1,4 +1,2 @@
-require_relative 'helpers'
-
 describe "Helpers" do
 end

data/spec/unit_specs/{actor_spec.rb → movie/actor_spec.rb}

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'json'
 
 module TomatoPower
-  describe TomatoPower::Actor do
+  describe Actor do
     before do
       actor = Actor.new TestHelpers::sample :actor 
       subject { actor }

data/spec/unit_specs/{client_spec.rb → movie/client_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module TomatoPower 
-  describe TomatoPower::Client, :vcr => {:record => :new_episodes} do
+  describe Client, :vcr => {:record => :new_episodes} do
     before do
       @client = TomatoPower.new TestHelpers::api_key
     end

data/spec/unit_specs/{clip_spec.rb → movie/clip_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module TomatoPower
-  describe TomatoPower::Clip do
+  describe Clip do
     before do
       @clip = Clip.new TestHelpers::sample :clip 
     end

data/spec/unit_specs/{movie_spec.rb → movie/movie_spec.rb}

@@ -2,9 +2,9 @@ require 'spec_helper'
 require 'json'
 
 module TomatoPower 
-  describe TomatoPower::Movie, :vcr => { :record => :new_episodes} do
+  describe Movie, :vcr => { :record => :new_episodes} do
     before do
-      TomatoPower::api = TomatoPower::API.new TestHelpers::api_key
+      TomatoPower::api = API.new TestHelpers::api_key
       @movie = Movie.new TestHelpers::sample :movie
       subject { @movie }
     end
@@ -12,14 +12,12 @@ module TomatoPower
     describe "attributes" do
       it { should respond_to(:id)}
       it { should respond_to(:info)}
-      it { should respond_to(:abridged_cast)}
       it { should respond_to(:title)}
       it { should respond_to(:ratings)}
       it { should respond_to(:mpaa_rating)}
       it { should respond_to(:runtime)}
       it { should respond_to(:release_dates)}
       it { should respond_to(:synopsis)}
-      it { should respond_to(:posters)}
       it { should respond_to(:alternate_ids)}
       it { should respond_to(:links)}
       it { should respond_to(:abridged_directors)}
@@ -34,6 +32,7 @@ module TomatoPower
         end
       end
     end
+
     describe "invalid methods" do
       it "should not respond" do
         invalid_api_methods = [:invalid_method, :invalid_clips, :invalid_reviews]
@@ -42,6 +41,15 @@ module TomatoPower
         end
       end
     end
+
+    describe "cast" do
+      it "should return abridged_cast" do
+        cast = @movie.cast
+        cast.should be_kind_of(Array)
+        cast[0].should be_kind_of(Actor)
+      end
+    end
+
     describe "full_cast" do
       it "should return cast" do
         cast = @movie.full_cast
@@ -49,6 +57,13 @@ module TomatoPower
         cast[0].should be_kind_of(Actor)
       end
     end
+
+    describe "posters" do
+      it "should return posters" do
+        @movie.posters.should be_kind_of(Poster)
+      end
+    end
+
     describe "clips" do
       it "should return clips" do
         clips = @movie.clips
@@ -58,8 +73,8 @@ module TomatoPower
     end
     describe "reviews" do
       it "should return reviews" do
-        reviews = @movie.reviews({:review_type => "all", :page => 1,
-                                 :country => 'us'})
+        options = {:review_type => "all", :page => 1,:country => 'us'}
+        reviews = @movie.reviews(options)
         reviews.should be_kind_of(Array)
         reviews[0].should be_kind_of(Review)
       end

data/spec/unit_specs/movie/poster_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+module TomatoPower 
+  describe Poster do
+    before do
+      @poster = Poster.new TestHelpers::sample :poster
+      subject { @poster }
+    end
+
+    describe "Attributes" do
+      it { should respond_to(:thumbnail)}
+      it { should respond_to(:profile)}
+      it { should respond_to(:detailed)}
+      it { should respond_to(:original)}
+    end
+  end
+end

data/spec/unit_specs/{review_spec.rb → movie/review_spec.rb}

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
 module TomatoPower
-  describe TomatoPower::Review do
+  describe Review do
     before do
-      @review = TomatoPower::Review.new TestHelpers::sample :review
+      @review = Review.new TestHelpers::sample :review
     end
     describe "attributes" do
       it { should respond_to(:critic)}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tomato_power
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-21 00:00:00.000000000 Z
+date: 2013-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_support
@@ -157,6 +157,7 @@ files:
 - Rakefile
 - lib/tomato_power.rb
 - lib/tomato_power/api/api.rb
+- lib/tomato_power/api/api_service.rb
 - lib/tomato_power/api/tomato_methods.rb
 - lib/tomato_power/client.rb
 - lib/tomato_power/helpers/helpers.rb
@@ -164,6 +165,7 @@ files:
 - lib/tomato_power/movie/actor.rb
 - lib/tomato_power/movie/clip.rb
 - lib/tomato_power/movie/movie.rb
+- lib/tomato_power/movie/poster.rb
 - lib/tomato_power/movie/review.rb
 - lib/tomato_power/version.rb
 - spec/spec_helper.rb
@@ -175,46 +177,21 @@ files:
 - spec/support/sample_data/sample_clips
 - spec/support/sample_data/sample_movie
 - spec/support/sample_data/sample_movies
+- spec/support/sample_data/sample_posters
 - spec/support/sample_data/sample_review
 - spec/support/sample_data/sample_reviews
 - spec/support/vcr.rb
-- spec/support/vcr/TomatoPower_API/API_Methods/valid_methods/should_create_methods.yml
-- spec/support/vcr/TomatoPower_API/API_options_validation/valid_options/should_consider_0_options_valid.yml
-- spec/support/vcr/TomatoPower_API/API_options_validation/valid_options/should_not_raise_error.yml
-- spec/support/vcr/TomatoPower_API/List_request/searching_by_title/should_return_a_list_of_movie_objects.yml
-- spec/support/vcr/TomatoPower_API/List_request/searching_by_title/should_url_encode_search_string_before_sending.yml
-- spec/support/vcr/TomatoPower_API/List_request/should_return_a_list_of_movie_objects.yml
-- spec/support/vcr/TomatoPower_API/List_request/should_url_encode_search_string_before_sending.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/cast/should_return_cast_of_movie.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/clips/should_return_clips_of_movie.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/no_results/should_return_error_string_if_no_results_are_found.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/reviews/should_return_reviews.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/should_return_single_movie.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/similar/should_return_similar_movies.yml
-- spec/support/vcr/TomatoPower_Client/box_office_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/current_release_dvds/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/in_theaters_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/new_release_dvds/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/opening_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/search_by_id/should_return_list_of_movies_by_id.yml
-- spec/support/vcr/TomatoPower_Client/search_by_title/should_return_list_of_movies_by_title.yml
-- spec/support/vcr/TomatoPower_Client/top_rentals/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/upcoming_dvds/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/upcoming_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Movie/clips/should_return_clips.yml
-- spec/support/vcr/TomatoPower_Movie/full_cast/should_return_cast.yml
-- spec/support/vcr/TomatoPower_Movie/reviews/should_return_reviews.yml
-- spec/support/vcr/TomatoPower_Movie/similar/should_return_similar_movies.yml
-- spec/support/vcr/TomatoPower_Movie/similar/should_return_similars.yml
-- spec/unit_specs/actor_spec.rb
-- spec/unit_specs/api_spec.rb
-- spec/unit_specs/client_spec.rb
-- spec/unit_specs/clip_spec.rb
-- spec/unit_specs/helpers.rb
+- spec/unit_specs/api/api_services_spec.rb
+- spec/unit_specs/api/api_spec.rb
+- spec/unit_specs/helpers/helpers.rb
+- spec/unit_specs/helpers/parsers_spec.rb
 - spec/unit_specs/helpers_spec.rb
-- spec/unit_specs/movie_spec.rb
-- spec/unit_specs/parsers_spec.rb
-- spec/unit_specs/review_spec.rb
+- spec/unit_specs/movie/actor_spec.rb
+- spec/unit_specs/movie/client_spec.rb
+- spec/unit_specs/movie/clip_spec.rb
+- spec/unit_specs/movie/movie_spec.rb
+- spec/unit_specs/movie/poster_spec.rb
+- spec/unit_specs/movie/review_spec.rb
 - spec/unit_specs/tomato_power_spec.rb
 - tomato_power.gemspec
 homepage: ''
@@ -251,45 +228,20 @@ test_files:
 - spec/support/sample_data/sample_clips
 - spec/support/sample_data/sample_movie
 - spec/support/sample_data/sample_movies
+- spec/support/sample_data/sample_posters
 - spec/support/sample_data/sample_review
 - spec/support/sample_data/sample_reviews
 - spec/support/vcr.rb
-- spec/support/vcr/TomatoPower_API/API_Methods/valid_methods/should_create_methods.yml
-- spec/support/vcr/TomatoPower_API/API_options_validation/valid_options/should_consider_0_options_valid.yml
-- spec/support/vcr/TomatoPower_API/API_options_validation/valid_options/should_not_raise_error.yml
-- spec/support/vcr/TomatoPower_API/List_request/searching_by_title/should_return_a_list_of_movie_objects.yml
-- spec/support/vcr/TomatoPower_API/List_request/searching_by_title/should_url_encode_search_string_before_sending.yml
-- spec/support/vcr/TomatoPower_API/List_request/should_return_a_list_of_movie_objects.yml
-- spec/support/vcr/TomatoPower_API/List_request/should_url_encode_search_string_before_sending.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/cast/should_return_cast_of_movie.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/clips/should_return_clips_of_movie.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/no_results/should_return_error_string_if_no_results_are_found.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/reviews/should_return_reviews.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/should_return_single_movie.yml
-- spec/support/vcr/TomatoPower_API/Movie_request/similar/should_return_similar_movies.yml
-- spec/support/vcr/TomatoPower_Client/box_office_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/current_release_dvds/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/in_theaters_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/new_release_dvds/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/opening_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/search_by_id/should_return_list_of_movies_by_id.yml
-- spec/support/vcr/TomatoPower_Client/search_by_title/should_return_list_of_movies_by_title.yml
-- spec/support/vcr/TomatoPower_Client/top_rentals/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/upcoming_dvds/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Client/upcoming_movies/should_return_list_of_movies.yml
-- spec/support/vcr/TomatoPower_Movie/clips/should_return_clips.yml
-- spec/support/vcr/TomatoPower_Movie/full_cast/should_return_cast.yml
-- spec/support/vcr/TomatoPower_Movie/reviews/should_return_reviews.yml
-- spec/support/vcr/TomatoPower_Movie/similar/should_return_similar_movies.yml
-- spec/support/vcr/TomatoPower_Movie/similar/should_return_similars.yml
-- spec/unit_specs/actor_spec.rb
-- spec/unit_specs/api_spec.rb
-- spec/unit_specs/client_spec.rb
-- spec/unit_specs/clip_spec.rb
-- spec/unit_specs/helpers.rb
+- spec/unit_specs/api/api_services_spec.rb
+- spec/unit_specs/api/api_spec.rb
+- spec/unit_specs/helpers/helpers.rb
+- spec/unit_specs/helpers/parsers_spec.rb
 - spec/unit_specs/helpers_spec.rb
-- spec/unit_specs/movie_spec.rb
-- spec/unit_specs/parsers_spec.rb
-- spec/unit_specs/review_spec.rb
+- spec/unit_specs/movie/actor_spec.rb
+- spec/unit_specs/movie/client_spec.rb
+- spec/unit_specs/movie/clip_spec.rb
+- spec/unit_specs/movie/movie_spec.rb
+- spec/unit_specs/movie/poster_spec.rb
+- spec/unit_specs/movie/review_spec.rb
 - spec/unit_specs/tomato_power_spec.rb
 has_rdoc: