tinybucket 0.1.7 → 1.0.0

data/spec/lib/tinybucket/model/profile_spec.rb

@@ -35,18 +35,18 @@ RSpec.describe Tinybucket::Model::Profile do
   describe 'followers' do
     let(:request_path) { "/users/#{username}/followers" }
     subject { model.followers() }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe 'following' do
     let(:request_path) { "/users/#{username}/following" }
     subject { model.following }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe 'repos' do
     let(:request_path) { "/repositories/#{username}" }
     subject { model.repos }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 end

data/spec/lib/tinybucket/model/pull_request_spec.rb

@@ -94,7 +94,7 @@ RSpec.describe Tinybucket::Model::PullRequest do
 
     subject { model.commits() }
 
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe 'comments' do
@@ -104,9 +104,15 @@ RSpec.describe Tinybucket::Model::PullRequest do
 
     subject { model.comments }
 
-    it 'return comment list' do
-      expect(subject).to be_an_instance_of(Tinybucket::Model::Page)
-      subject.items.each do |comment|
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return comments which associate with this pull request' do
+      # extract iterator from enumerator.
+      iterator = subject.instance_variable_get(:@iterator)
+      # extract values from iterator.
+      values = iterator.instance_variable_get(:@values)
+
+      values.each do |comment|
+        expect(comment).to be_an_instance_of(Tinybucket::Model::Comment)
         expect(comment.commented_to).to eq(model)
       end
     end
@@ -144,4 +150,4 @@ RSpec.describe Tinybucket::Model::PullRequest do
 
     it { expect(subject).to be_truthy }
   end
-end
+end

data/spec/lib/tinybucket/model/repository_spec.rb

@@ -52,7 +52,7 @@ RSpec.describe Tinybucket::Model::Repository do
 
     subject { model.pull_requests() }
 
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#pull_request' do
@@ -80,19 +80,19 @@ RSpec.describe Tinybucket::Model::Repository do
   describe '#watchers' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/watchers" }
     subject { model.watchers }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#forks' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/forks" }
     subject { model.forks }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#commits' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/commits" }
     subject { model.commits }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#commit' do
@@ -105,7 +105,7 @@ RSpec.describe Tinybucket::Model::Repository do
   describe '#branch_restrictions' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/branch-restrictions" }
     subject { model.branch_restrictions }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#branch_restriction' do

data/spec/lib/tinybucket/model/team_spec.rb

@@ -35,24 +35,24 @@ RSpec.describe Tinybucket::Model::Team do
   describe '#members' do
     let(:request_path) { "/teams/#{teamname}/members" }
     subject { model.members }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#followers' do
     let(:request_path) { "/teams/#{teamname}/followers" }
     subject { model.followers() }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#following' do
     let(:request_path) { "/teams/#{teamname}/following" }
     subject { model.following }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#repos' do
     let(:request_path) { "/teams/#{teamname}/repositories" }
     subject { model.repos }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 end

data/spec/lib/tinybucket_spec.rb

@@ -3,31 +3,8 @@ require 'spec_helper'
 RSpec.describe Tinybucket do
 
   describe 'new' do
-    let(:options) { { key: 'value' } }
-
-    shared_examples_for 'return client which configured with options' do
-      it 'return client instance which configured with options' do
-        expect(subject).to be_instance_of(Tinybucket::Client)
-        expect(subject.config).to eq(options)
-      end
-    end
-
-    context 'when options passed' do
-      subject { Tinybucket.new(options) }
-      it_behaves_like 'return client which configured with options'
-    end
-
-    context 'when block given' do
-      subject { Tinybucket.new(&block) }
-      let(:block) do
-        lambda do |config|
-          options.each_pair do |key, value|
-            config.send("#{key}=", value)
-          end
-        end
-      end
-      it_behaves_like 'return client which configured with options'
-    end
+    subject { Tinybucket.new }
+    it { expect(subject).to be_instance_of(Tinybucket::Client) }
   end
 
   describe 'config' do
@@ -38,19 +15,25 @@ RSpec.describe Tinybucket do
   describe 'configure' do
     subject(:config) { Tinybucket.config }
     let(:logger) { Logger.new($stdout) }
+    let(:oauth_token) { 'test_oauth_token' }
+    let(:oauth_secret) { 'test_oauth_secret' }
 
-    it 'can configurable logger' do
+    it 'is configurable' do
       expect(config.logger).to be_nil
 
       expect do
         Tinybucket.configure do |config|
           config.logger = logger
+          config.oauth_token = oauth_token
+          config.oauth_secret = oauth_secret
         end
       end.not_to raise_error
 
       expect(config.logger).to eq(logger)
+      expect(config.oauth_token).to eq(oauth_token)
+      expect(config.oauth_secret).to eq(oauth_secret)
     end
 
-    after { Tinybucket.configure { |config| config.logger = nil } }
+    after { Tinybucket.instance_variable_set(:@config, nil) }
   end
 end

data/spec/spec_helper.rb

@@ -10,13 +10,14 @@ require 'coveralls'
 require 'simplecov'
 Coveralls.wear!
 
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
   SimpleCov::Formatter::HTMLFormatter,
   Coveralls::SimpleCov::Formatter
-]
+])
 SimpleCov.start do
   add_filter '.bundle/'
   add_filter 'spec'
+  add_filter 'features'
 end
 
 if ENV['CODECLIMATE_REPORT']

data/spec/support/api_response_macros.rb

@@ -10,8 +10,8 @@ module ApiResponseMacros
 
     stub_request(method, 'https://bitbucket.org/api/2.0' + path)
       .to_return(
-        status: 200,
-        body: fixture_json(method, path, ext),
+        status: (options[:status_code] || 200),
+        body: (options[:message] || fixture_json(method, path, ext)),
         headers: response_headers)
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tinybucket
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 1.0.0
 platform: ruby
 authors:
 - hirakiuc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-12 00:00:00.000000000 Z
+date: 2016-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -140,9 +140,13 @@ files:
 - lib/tinybucket/config.rb
 - lib/tinybucket/connection.rb
 - lib/tinybucket/constants.rb
+- lib/tinybucket/enumerator.rb
 - lib/tinybucket/error.rb
 - lib/tinybucket/error/base_error.rb
+- lib/tinybucket/error/conflict.rb
+- lib/tinybucket/error/not_found.rb
 - lib/tinybucket/error/service_error.rb
+- lib/tinybucket/iterator.rb
 - lib/tinybucket/model.rb
 - lib/tinybucket/model/base.rb
 - lib/tinybucket/model/branch_restriction.rb
@@ -150,6 +154,7 @@ files:
 - lib/tinybucket/model/commit.rb
 - lib/tinybucket/model/concerns.rb
 - lib/tinybucket/model/concerns/acceptable_attributes.rb
+- lib/tinybucket/model/concerns/enumerable.rb
 - lib/tinybucket/model/concerns/reloadable.rb
 - lib/tinybucket/model/concerns/repository_keys.rb
 - lib/tinybucket/model/error_response.rb
@@ -177,7 +182,7 @@ files:
 - lib/tinybucket/parser/teams_parser.rb
 - lib/tinybucket/request.rb
 - lib/tinybucket/response.rb
-- lib/tinybucket/response/error_handler.rb
+- lib/tinybucket/response/handler.rb
 - lib/tinybucket/version.rb
 - spec/fixtures/branch_restriction.json
 - spec/fixtures/comment.json
@@ -188,6 +193,7 @@ files:
 - spec/fixtures/repositories/test_owner/get.json
 - spec/fixtures/repositories/test_owner/test_repo/branch-restrictions/1/get.json
 - spec/fixtures/repositories/test_owner/test_repo/branch-restrictions/get.json
+- spec/fixtures/repositories/test_owner/test_repo/commit/1/approve/post.json
 - spec/fixtures/repositories/test_owner/test_repo/commit/1/comments/1/get.json
 - spec/fixtures/repositories/test_owner/test_repo/commit/1/comments/get.json
 - spec/fixtures/repositories/test_owner/test_repo/commit/1/get.json
@@ -232,6 +238,7 @@ files:
 - spec/lib/tinybucket/api_factory_spec.rb
 - spec/lib/tinybucket/client_spec.rb
 - spec/lib/tinybucket/connection_spec.rb
+- spec/lib/tinybucket/error/service_error_spec.rb
 - spec/lib/tinybucket/model/branch_restriction_spec.rb
 - spec/lib/tinybucket/model/comment_spec.rb
 - spec/lib/tinybucket/model/commit_spec.rb
@@ -281,6 +288,7 @@ test_files:
 - spec/fixtures/repositories/test_owner/get.json
 - spec/fixtures/repositories/test_owner/test_repo/branch-restrictions/1/get.json
 - spec/fixtures/repositories/test_owner/test_repo/branch-restrictions/get.json
+- spec/fixtures/repositories/test_owner/test_repo/commit/1/approve/post.json
 - spec/fixtures/repositories/test_owner/test_repo/commit/1/comments/1/get.json
 - spec/fixtures/repositories/test_owner/test_repo/commit/1/comments/get.json
 - spec/fixtures/repositories/test_owner/test_repo/commit/1/get.json
@@ -325,6 +333,7 @@ test_files:
 - spec/lib/tinybucket/api_factory_spec.rb
 - spec/lib/tinybucket/client_spec.rb
 - spec/lib/tinybucket/connection_spec.rb
+- spec/lib/tinybucket/error/service_error_spec.rb
 - spec/lib/tinybucket/model/branch_restriction_spec.rb
 - spec/lib/tinybucket/model/comment_spec.rb
 - spec/lib/tinybucket/model/commit_spec.rb

data/lib/tinybucket/response/error_handler.rb

@@ -1,14 +0,0 @@
-module Tinybucket
-  module Response
-    class ErrorHandler < Faraday::Response::Middleware
-      def on_complete(env)
-        status_code = env[:status].to_i
-
-        return if status_code < 400
-
-        Tinybucket.logger.error "Invalid response code:#{status_code}"
-        raise Tinybucket::Error::ServiceError.new(env)
-      end
-    end
-  end
-end