tinybucket 0.1.7 → 1.0.0

data/spec/lib/tinybucket/api/comments_api_spec.rb

@@ -27,9 +27,8 @@ RSpec.describe Tinybucket::Api::CommentsApi do
   end
 
   let(:commented_to) { nil }
-  let(:api_config) { {} }
   let(:api) do
-    api = Tinybucket::Api::CommentsApi.new(api_config)
+    api = Tinybucket::Api::CommentsApi.new
     api.repo_owner = owner
     api.repo_slug = slug
     api.commented_to = commented_to if commented_to.present?

data/spec/lib/tinybucket/api/commits_api_spec.rb

@@ -8,9 +8,8 @@ RSpec.describe Tinybucket::Api::CommitsApi do
   let(:slug)  { 'test_repo' }
   let(:options) { {} }
 
-  let(:api_config) { {} }
   let(:api) do
-    api = Tinybucket::Api::CommitsApi.new(api_config)
+    api = Tinybucket::Api::CommitsApi.new
     api.repo_owner = owner
     api.repo_slug  = slug
     api
@@ -18,7 +17,15 @@ RSpec.describe Tinybucket::Api::CommitsApi do
 
   it { expect(api).to be_a_kind_of(Tinybucket::Api::BaseApi) }
 
-  before { stub_apiresponse(:get, request_path) if request_path }
+  let(:request_method) { :get }
+  let(:stub_options) { nil }
+
+  before do
+    if request_path
+      opts = stub_options.present? ? stub_options : {}
+      stub_apiresponse(request_method, request_path, opts)
+    end
+  end
 
   describe 'list' do
     subject { api.list(options) }
@@ -60,4 +67,86 @@ RSpec.describe Tinybucket::Api::CommitsApi do
       it { expect(subject).to be_instance_of(Tinybucket::Model::Commit) }
     end
   end
+
+  describe 'approve' do
+    let(:revision) { '1' }
+    let(:request_method) { :post }
+
+    subject { api.approve(revision, options) }
+
+    context 'without owner' do
+      let(:owner) { nil }
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context 'without slug' do
+      let(:slug) { nil }
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context 'when pull request is not yet approved' do
+      let(:request_path) do
+        "/repositories/#{owner}/#{slug}/commit/#{revision}/approve"
+      end
+
+      it { expect(subject).to be_truthy }
+    end
+
+    context 'when pull request is already approved.' do
+      let(:request_path) do
+        "/repositories/#{owner}/#{slug}/commit/#{revision}/approve"
+      end
+
+      let(:stub_options) do
+        {
+          status_code: 409,
+          message: JSON.generate(
+            error: { message: 'You already approved this pull request.' }
+          )
+        }
+      end
+      it { expect(subject).to be_truthy }
+    end
+  end
+
+  describe 'unapprove' do
+    let(:revision) { '1' }
+    let(:request_method) { :delete }
+    subject { api.unapprove(revision) }
+
+    context 'without owner' do
+      let(:owner) { nil }
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context 'without slug' do
+      let(:slug) { nil }
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context 'when commit is not yet approved' do
+      let(:request_path) do
+        "/repositories/#{owner}/#{slug}/commit/#{revision}/approve"
+      end
+
+      let(:stub_options) do
+        {
+          status_code: 404,
+          message: JSON.generate(
+            error: { message: 'You haven\'t approve this pull request.' }
+          )
+        }
+      end
+      it { expect(subject).to be_truthy }
+    end
+
+    context 'when commit is already approved' do
+      let(:request_path) do
+        "/repositories/#{owner}/#{slug}/commit/#{revision}/approve"
+      end
+      let(:stub_options) { { status_code: 204, message: '' } }
+
+      it { expect(subject).to be_truthy }
+    end
+  end
 end

data/spec/lib/tinybucket/api/pull_requests_api_spec.rb

@@ -3,9 +3,8 @@ require 'spec_helper'
 RSpec.describe Tinybucket::Api::PullRequestsApi do
   include ApiResponseMacros
 
-  let(:api_config) { {} }
   let(:api) do
-    api = Tinybucket::Api::PullRequestsApi.new(api_config)
+    api = Tinybucket::Api::PullRequestsApi.new
     api.repo_owner = owner
     api.repo_slug = slug
     api
@@ -163,7 +162,20 @@ RSpec.describe Tinybucket::Api::PullRequestsApi do
       let(:request_path) do
         "/repositories/#{owner}/#{slug}/pullrequests/1/approve"
       end
-      it { expect(subject).to be_truthy }
+      context 'when pull request is not yet approved.' do
+        it { expect(subject).to be_truthy }
+      end
+      context 'when pull request is already approved.' do
+        let(:stub_options) do
+          {
+            status_code: 409,
+            message: JSON.generate(
+              error: { message: 'You already approved this pull request.' }
+            )
+          }
+        end
+        it { expect(subject).to be_truthy }
+      end
     end
   end
 
@@ -192,7 +204,25 @@ RSpec.describe Tinybucket::Api::PullRequestsApi do
       let(:request_path) do
         "/repositories/#{owner}/#{slug}/pullrequests/1/approve"
       end
-      it { expect(subject).to be_truthy }
+
+      context 'when pull request is approved' do
+        # In this case, bitbucket api respond '204 No content'.
+        let(:stub_options) { { status_code: 204, message: '' } }
+        it { expect(subject).to be_truthy }
+      end
+
+      context 'when pull request is not approved yet.' do
+        # In this case, bitbucket api respond '404 NotFound'.
+        let(:stub_options) do
+          {
+            status_code: 404,
+            message: JSON.generate(
+              error: { message: 'You haven\'t approve this pull request.' }
+            )
+          }
+        end
+        it { expect(subject).to be_truthy }
+      end
     end
   end
 

data/spec/lib/tinybucket/api/repo_api_spec.rb

@@ -7,9 +7,8 @@ RSpec.describe Tinybucket::Api::RepoApi do
   let(:repo_slug) { 'test_repo' }
   let(:request_path) { nil }
 
-  let(:api_config) { {} }
   let(:api) do
-    api = Tinybucket::Api::RepoApi.new(api_config)
+    api = Tinybucket::Api::RepoApi.new
     api.repo_owner = repo_owner
     api.repo_slug  = repo_slug
     api

data/spec/lib/tinybucket/api/repos_api_spec.rb

@@ -3,8 +3,7 @@ require 'spec_helper.rb'
 RSpec.describe Tinybucket::Api::ReposApi do
   include ApiResponseMacros
 
-  let(:api_config) { {} }
-  let(:api) { Tinybucket::Api::ReposApi.new(api_config) }
+  let(:api) { Tinybucket::Api::ReposApi.new }
 
   it { expect(api).to be_a_kind_of(Tinybucket::Api::BaseApi) }
 

data/spec/lib/tinybucket/api/team_api_spec.rb

@@ -3,11 +3,7 @@ require 'spec_helper'
 RSpec.describe Tinybucket::Api::TeamApi do
   include ApiResponseMacros
 
-  let(:api_config) { {} }
-  let(:api) do
-    Tinybucket::Api::TeamApi.new(api_config)
-  end
-
+  let(:api) { Tinybucket::Api::TeamApi.new }
   let(:teamname) { 'test_team' }
   let(:request_path) { nil }
   before { stub_apiresponse(:get, request_path) if request_path }
@@ -83,5 +79,4 @@ RSpec.describe Tinybucket::Api::TeamApi do
       it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
     end
   end
-
 end

data/spec/lib/tinybucket/api/user_api_spec.rb

@@ -3,9 +3,8 @@ require 'spec_helper'
 RSpec.describe Tinybucket::Api::UserApi do
   include ApiResponseMacros
 
-  let(:api_config) { {} }
   let(:api) do
-    api = Tinybucket::Api::UserApi.new(api_config)
+    api = Tinybucket::Api::UserApi.new
     api.username = user
     api
   end
@@ -57,4 +56,18 @@ RSpec.describe Tinybucket::Api::UserApi do
       it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
     end
   end
+
+  describe 'repos' do
+    subject { api.repos }
+
+    context 'when without username' do
+      let(:user) { nil }
+      it { expect { subject }.to raise_error(ArgumentError) }
+    end
+
+    context 'when with username' do
+      let(:request_path) { "/repositories/#{user}" }
+      it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    end
+  end
 end

data/spec/lib/tinybucket/api_factory_spec.rb

@@ -3,15 +3,10 @@ require 'spec_helper'
 RSpec.describe Tinybucket::ApiFactory do
 
   describe 'create_instance' do
-    let(:klass_name) { 'PullRequests' }
-    let(:config) { {} }
-    let(:options) { {} }
-
-    subject do
-      Tinybucket::ApiFactory.create_instance(klass_name, config, options)
-    end
+    subject { Tinybucket::ApiFactory.create_instance(klass_name) }
 
     context 'with valid klass_name' do
+      let(:klass_name) { 'PullRequests' }
       it { expect(subject).to be_a_kind_of(Tinybucket::Api::BaseApi) }
     end
 

data/spec/lib/tinybucket/client_spec.rb

@@ -3,26 +3,11 @@ require 'spec_helper.rb'
 RSpec.describe Tinybucket::Client do
   include ApiResponseMacros
 
-  let(:client) { Tinybucket::Client.new({}) }
+  let(:client) { Tinybucket::Client.new }
 
   describe 'new' do
-    let(:options) { {} }
-
-    context 'without block' do
-      subject { Tinybucket::Client.new(options) }
-      it { expect(subject.config).to eq(options) }
-    end
-
-    context 'with block' do
-      subject do
-        Tinybucket::Client.new do |config|
-          options.each_pair do |key, value|
-            config.send("#{key}=", value)
-          end
-        end
-      end
-      it { expect(subject.config).to eq(options) }
-    end
+    subject { Tinybucket::Client.new }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Client) }
   end
 
   describe 'repos' do
@@ -31,12 +16,12 @@ RSpec.describe Tinybucket::Client do
 
       context 'without options' do
         subject { client.repos }
-        it { expect(subject).to be_instance_of(Tinybucket::Model::Page) }
+        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
       end
       context 'with options' do
         subject { client.repos(options) }
         let(:options) { {} }
-        it { expect(subject).to be_instance_of(Tinybucket::Model::Page) }
+        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
       end
     end
 
@@ -47,30 +32,30 @@ RSpec.describe Tinybucket::Client do
       context 'without options' do
         let(:request_path) { "/repositories/#{owner}" }
         subject { client.repos(owner) }
-        it { expect(subject).to be_instance_of(Tinybucket::Model::Page) }
+        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
       end
       context 'with options' do
         let(:request_path) { "/repositories/#{owner}" }
         subject { client.repos(owner, options) }
         let(:options) { {} }
-        it { expect(subject).to be_instance_of(Tinybucket::Model::Page) }
+        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
       end
     end
 
     context 'when invalid argument passed' do
       context 'with a integer' do
         subject { client.repos(20) }
-        it { expect { subject }.to raise_error }
+        it { expect { subject }.to raise_error(ArgumentError) }
       end
 
       context 'with a string and string' do
         subject { client.repos('test_owner', 'test_repository') }
-        it { expect { subject }.to raise_error }
+        it { expect { subject }.to raise_error(ArgumentError) }
       end
 
       context 'with three arguments' do
         subject { client.repos('a', 'b', 'c') }
-        it { expect { subject }.to raise_error }
+        it { expect { subject }.to raise_error(ArgumentError) }
       end
     end
   end

data/spec/lib/tinybucket/error/service_error_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+RSpec.describe Tinybucket::Error::ServiceError do
+  context 'initialize' do
+    let(:env) do
+      {
+        response_headers: [],
+        method: 'POST',
+        url: 'https://api.example.org/path/to',
+        status: 500,
+        body: 'Internal Server Error'
+      }
+    end
+
+    subject { Tinybucket::Error::ServiceError.new(env) }
+
+    it { expect(subject).to be_an_instance_of(Tinybucket::Error::ServiceError) }
+    it { expect(subject.http_method).to eq(env[:method]) }
+    it { expect(subject.request_url).to eq(env[:url]) }
+    it { expect(subject.status_code).to eq(env[:status]) }
+    it { expect(subject.response_body).to eq(env[:body]) }
+  end
+end

data/spec/lib/tinybucket/model/commit_spec.rb

@@ -20,7 +20,15 @@ RSpec.describe Tinybucket::Model::Commit do
     m
   end
 
-  before { stub_apiresponse(:get, request_path) if request_path }
+  let(:request_method) { :get }
+  let(:stub_options) { nil }
+
+  before do
+    if request_path
+      opts = stub_options.present? ? stub_options : {}
+      stub_apiresponse(request_method, request_path, opts)
+    end
+  end
 
   it_behaves_like 'model has acceptable_attributes',
                   Tinybucket::Model::Commit,
@@ -43,7 +51,7 @@ RSpec.describe Tinybucket::Model::Commit do
       "/repositories/#{owner}/#{slug}/commit/1/comments"
     end
     subject { model.comments }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Page) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
   end
 
   describe '#comment' do
@@ -58,10 +66,25 @@ RSpec.describe Tinybucket::Model::Commit do
   end
 
   describe '#approve' do
-    pending 'TODO implement method'
+    let(:request_method) { :post }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/1/approve"
+    end
+
+    subject { model.approve }
+
+    it { expect(subject).to be_truthy }
   end
 
   describe '#unapprove' do
-    pending 'TODO implement method'
+    let(:request_method) { :delete }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/1/approve"
+    end
+    let(:stub_options) { { status_code: 204, message: '' } }
+
+    subject { model.unapprove }
+
+    it { expect(subject).to be_truthy }
   end
 end

data/spec/lib/tinybucket/model/page_spec.rb

@@ -25,34 +25,4 @@ RSpec.describe Tinybucket::Model::Page do
       expect(subject.items.size).to eq(json['values'].size)
     end
   end
-
-  describe 'size' do
-    subject { model.size }
-
-    let(:base_json) do
-      text = File.read('spec/fixtures/repositories/get.json')
-      JSON.parse(text)
-    end
-
-    context 'when json contains size = nil' do
-      let(:json) do
-        base_json['size'] = nil
-        base_json
-      end
-      it { expect(subject).to be_nil }
-    end
-
-    context 'when json contains size' do
-      let(:size) { 1000 }
-      let(:json) do
-        base_json['size'] = size
-        base_json
-      end
-      it { expect(subject).to eq(size) }
-    end
-  end
-
-  describe 'each' do
-    pending 'TODO add specs'
-  end
 end