test_hyrax 0.0.1.alpha

data/spec/controllers/hyrax/contact_form_controller_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+
+describe Hyrax::ContactFormController do
+  let(:user) { create(:user) }
+  let(:required_params) do
+    {
+      category: "Depositing content",
+      name: "Rose Tyler",
+      email: "rose@timetraveler.org",
+      subject: "The Doctor",
+      message: "Run."
+    }
+  end
+
+  before { sign_in(user) }
+
+  describe "#new" do
+    subject { response }
+    before { get :new }
+    it { is_expected.to be_success }
+  end
+
+  describe "#create" do
+    subject { flash }
+    before { post :create, params: { contact_form: params } }
+    context "with the required parameters" do
+      let(:params) { required_params }
+      its(:notice) { is_expected.to eq("Thank you for your message!") }
+    end
+
+    context "without a category" do
+      let(:params)  { required_params.except(:category) }
+      its([:error]) { is_expected.to eq("Sorry, this message was not sent successfully. Category can't be blank") }
+    end
+
+    context "without a name" do
+      let(:params)  { required_params.except(:name) }
+      its([:error]) { is_expected.to eq("Sorry, this message was not sent successfully. Name can't be blank") }
+    end
+
+    context "without an email" do
+      let(:params)  { required_params.except(:email) }
+      its([:error]) { is_expected.to eq("Sorry, this message was not sent successfully. Email can't be blank") }
+    end
+
+    context "without a subject" do
+      let(:params)  { required_params.except(:subject) }
+      its([:error]) { is_expected.to eq("Sorry, this message was not sent successfully. Subject can't be blank") }
+    end
+
+    context "without a message" do
+      let(:params)  { required_params.except(:message) }
+      its([:error]) { is_expected.to eq("Sorry, this message was not sent successfully. Message can't be blank") }
+    end
+
+    context "with an invalid email" do
+      let(:params)  { required_params.merge(email: "bad-wolf") }
+      its([:error]) { is_expected.to eq("Sorry, this message was not sent successfully. Email is invalid") }
+    end
+  end
+
+  describe "#after_deliver" do
+    context "with a successful email" do
+      it "calls #after_deliver" do
+        expect(controller).to receive(:after_deliver)
+        post :create, params: { contact_form: required_params }
+      end
+    end
+    context "with an unsuccessful email" do
+      it "does not call #after_deliver" do
+        expect(controller).not_to receive(:after_deliver)
+        post :create, params: { contact_form: required_params.except(:email) }
+      end
+    end
+  end
+
+  context "when encoutering a RuntimeError" do
+    let(:logger) { double(info?: true) }
+    before do
+      allow(controller).to receive(:logger).and_return(logger)
+      allow(Hyrax::ContactMailer).to receive(:contact).and_raise(RuntimeError)
+    end
+    it "is logged via Rails" do
+      expect(logger).to receive(:error).with("Contact form failed to send: #<RuntimeError: RuntimeError>")
+      post :create, params: { contact_form: required_params }
+    end
+  end
+end

data/spec/controllers/hyrax/content_blocks_controller_spec.rb

@@ -0,0 +1,71 @@
+describe Hyrax::ContentBlocksController, type: :controller do
+  describe "#update" do
+    let(:content_block) { FactoryGirl.create(:content_block) }
+    before { request.env["HTTP_REFERER"] = "whence_i_came" }
+
+    context "when not logged in" do
+      it "UPDATE should redirect to sign_in path" do
+        patch :update, params: { id: content_block, content_block: { value: 'foo' } }
+        expect(response).to redirect_to main_app.new_user_session_path(locale: 'en')
+      end
+
+      it "CREATE should redirect to sign_in path" do
+        post :create, params: { content_block: { name: 'NNN', value: 'VVV' } }
+        expect(response).to redirect_to main_app.new_user_session_path(locale: 'en')
+      end
+
+      context "get INDEX" do
+        let!(:current_researcher) { ContentBlock.create(name: ContentBlock::RESEARCHER, created_at: Time.zone.now) }
+        let!(:old_researcher) { ContentBlock.create(name: ContentBlock::RESEARCHER, created_at: 2.hours.ago) }
+        let!(:market_text) { ContentBlock.create(name: ContentBlock::MARKETING) }
+
+        before { get :index }
+
+        it "displays the list of featured researchers" do
+          expect(response).to be_successful
+          expect(response).to render_template(:index)
+          expect(assigns(:content_blocks)).to eq [current_researcher, old_researcher]
+        end
+      end
+    end
+
+    context "when logged in" do
+      let(:user) { FactoryGirl.create(:user) }
+      before { allow(controller).to receive_messages(current_user: user) }
+
+      context "as a user in the admin group" do
+        before { expect(user).to receive(:groups).and_return(['admin', 'registered']) }
+
+        it "UPDATE should save" do
+          patch :update, params: { id: content_block, content_block: { value: 'foo' } }
+          expect(response).to redirect_to "whence_i_came"
+          expect(assigns[:content_block].value).to eq 'foo'
+        end
+
+        it "CREATE should save" do
+          expect do
+            post :create, params: { content_block: { name: 'NNN', value: 'VVV', external_key: 'key' } }
+          end.to change { ContentBlock.count }.by(1)
+          expect(response).to redirect_to "whence_i_came"
+          expect(assigns[:content_block].name).to eq 'NNN'
+          expect(assigns[:content_block].value).to eq 'VVV'
+          expect(assigns[:content_block].external_key).to eq 'key'
+        end
+      end
+
+      context "as a user without permission" do
+        it "UPDATE is unauthorized" do
+          patch :update, params: { id: content_block, content_block: { value: 'foo' } }
+          expect(response.code).to eq '401'
+          expect(response).to render_template(:unauthorized)
+        end
+
+        it "CREATE should redirect to root path" do
+          post :create, params: { content_block: { name: 'NNN', value: 'VVV' } }
+          expect(response.code).to eq '401'
+          expect(response).to render_template(:unauthorized)
+        end
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/dashboard_controller_spec.rb

@@ -0,0 +1,81 @@
+describe Hyrax::DashboardController, type: :controller do
+  context "with an unauthenticated user" do
+    it "redirects to sign-in page" do
+      get :index
+      expect(response).to be_redirect
+      expect(flash[:alert]).to eq("You need to sign in or sign up before continuing.")
+    end
+  end
+
+  context "with an authenticated user" do
+    let(:user) { create(:user_with_mail) }
+
+    before do
+      sign_in user
+    end
+
+    it "renders the dashboard with the user's info" do
+      get :index
+      expect(response).to be_successful
+      expect(assigns(:user)).to eq(user)
+      expect(assigns(:activity)).to be_empty
+      expect(assigns(:notifications)).to be_truthy
+    end
+
+    context 'with transfers' do
+      let(:another_user) { create(:user) }
+      context 'when incoming' do
+        let!(:incoming_work) do
+          GenericWork.new(title: ['incoming']) do |w|
+            w.apply_depositor_metadata(another_user.user_key)
+            w.save!
+            w.request_transfer_to(user)
+          end
+        end
+
+        it 'assigns an instance variable' do
+          get :index
+          expect(response).to be_success
+          expect(assigns[:incoming].first).to be_kind_of ProxyDepositRequest
+          expect(assigns[:incoming].first.work_id).to eq(incoming_work.id)
+        end
+      end
+
+      context 'when outgoing' do
+        let!(:outgoing_work) do
+          GenericWork.new(title: ['outgoing']) do |w|
+            w.apply_depositor_metadata(user.user_key)
+            w.save!
+            w.request_transfer_to(another_user)
+          end
+        end
+
+        it 'assigns an instance variable' do
+          get :index
+          expect(response).to be_success
+          expect(assigns[:outgoing].first).to be_kind_of ProxyDepositRequest
+          expect(assigns[:outgoing].first.work_id).to eq(outgoing_work.id)
+        end
+      end
+    end
+
+    context "with activities" do
+      let(:activity) { double }
+
+      before do
+        allow(activity).to receive(:map).and_return(activity)
+        allow_any_instance_of(User).to receive(:all_user_activity).and_return(activity)
+      end
+
+      it "gathers the user's recent activity within the default amount of time" do
+        get :index
+        expect(assigns(:activity)).to eq activity
+      end
+
+      it "returns results in JSON" do
+        get :activity
+        expect(response).to be_successful
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/depositors_controller_spec.rb

@@ -0,0 +1,94 @@
+describe Hyrax::DepositorsController do
+  let(:user) { create(:user) }
+  let(:grantee) { create(:user) }
+
+  let(:grant_proxy_params) do
+    {
+      user_id: user.user_key,
+      grantee_id: grantee.user_key,
+      format: 'json'
+    }
+  end
+
+  let(:revoke_proxy_params) do
+    {
+      user_id: user.user_key,
+      id: grantee.user_key,
+      format: 'json'
+    }
+  end
+
+  context "as a logged in user" do
+    before do
+      sign_in user
+    end
+
+    describe "#create" do
+      context 'when the grantee has not yet been designated as a depositor' do
+        let(:request_to_grant_proxy) { post :create, params: grant_proxy_params }
+
+        it 'is successful' do
+          expect { request_to_grant_proxy }.to change { ProxyDepositRights.count }.by(1)
+          expect(response).to be_success
+        end
+
+        it 'sends a message to the grantor' do
+          expect { request_to_grant_proxy }.to change { user.mailbox.inbox.count }.by(1)
+        end
+
+        it 'sends a message to the grantee' do
+          expect { request_to_grant_proxy }.to change { grantee.mailbox.inbox.count }.by(1)
+        end
+      end
+
+      context 'when the grantee is already an allowed depositor' do
+        # For this test we just set the grantor to be eq to grantee.
+        let(:redundant_request_to_grant_proxy) do
+          post :create, params: grant_proxy_params.merge(grantee_id: user.user_key)
+        end
+
+        it 'does not add the user, and returns a 200, with empty response body' do
+          expect { redundant_request_to_grant_proxy }.to change { ProxyDepositRights.count }.by(0)
+          expect(response).to be_success
+          expect(response.body).to be_blank
+        end
+
+        it 'does not send a message to the user' do
+          expect { redundant_request_to_grant_proxy }.not_to change { user.mailbox.inbox.count }
+        end
+      end
+    end
+
+    describe "destroy" do
+      before do
+        user.can_receive_deposits_from << grantee
+      end
+
+      it "is successful" do
+        expect { delete :destroy, params: revoke_proxy_params }.to change { ProxyDepositRights.count }.by(-1)
+      end
+    end
+  end
+
+  context "as a user without access" do
+    before do
+      sign_in create(:user)
+    end
+
+    describe "create" do
+      it "is not successful" do
+        post :create, params: grant_proxy_params
+        expect(response).to redirect_to root_path
+        expect(flash[:alert]).to eq "You are not authorized to access this page."
+      end
+    end
+
+    describe "destroy" do
+      it "is not successful" do
+        delete :destroy, params: revoke_proxy_params
+        expect(response).to redirect_to root_path
+        expect(flash[:alert]).to eq "You are not authorized to access this page."
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/downloads_controller_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+describe Hyrax::DownloadsController do
+  routes { Hyrax::Engine.routes }
+
+  describe '#show' do
+    let(:user) { FactoryGirl.create(:user) }
+    let(:file_set) do
+      FactoryGirl.create(:file_with_work, user: user, content: File.open(fixture_path + '/image.png'))
+    end
+    let(:default_image) { ActionController::Base.helpers.image_path 'default.png' }
+    it 'calls render_404 if the object does not exist' do
+      expect(controller).to receive(:render_404) { controller.render body: nil }
+      get :show, params: { id: '8675309' }
+    end
+
+    context "when user doesn't have access" do
+      let(:another_user) { FactoryGirl.create(:user) }
+      before { sign_in another_user }
+
+      it 'redirects to the default image' do
+        get :show, params: { id: file_set.to_param }
+        expect(response).to redirect_to default_image
+      end
+    end
+
+    context "when user isn't logged in" do
+      it 'redirects to the default image' do
+        get :show, params: { id: file_set.to_param }
+        expect(response).to redirect_to default_image
+      end
+
+      it 'authorizes the resource using only the id' do
+        expect(controller).to receive(:authorize!).with(:read, file_set.id)
+        get :show, params: { id: file_set.to_param }
+      end
+    end
+
+    context "when the user has access" do
+      before { sign_in user }
+
+      it 'sends the original file' do
+        get :show, params: { id: file_set }
+        expect(response.body).to eq file_set.original_file.content
+      end
+
+      context "with an alternative file" do
+        context "that is persisted" do
+          let(:file) { File.open(fixture_path + '/world.png', 'rb') }
+          let(:content) { file.read }
+
+          before do
+            allow(Hyrax::DerivativePath).to receive(:derivative_path_for_reference).and_return(fixture_path + '/world.png')
+          end
+
+          it 'sends requested file content' do
+            get :show, params: { id: file_set, file: 'thumbnail' }
+            expect(response.body).to eq content
+            expect(response.headers['Content-Length']).to eq "4218"
+            expect(response.headers['Accept-Ranges']).to eq "bytes"
+          end
+
+          it 'retrieves the thumbnail without contacting Fedora' do
+            expect(ActiveFedora::Base).not_to receive(:find).with(file_set.id)
+            get :show, params: { id: file_set, file: 'thumbnail' }
+          end
+        end
+
+        context "that isn't persisted" do
+          it "returns 404 if the requested file does not exist" do
+            expect(controller).to receive(:render_404) { controller.render body: nil }
+            get :show, params: { id: file_set, file: 'thumbnail' }
+          end
+        end
+      end
+
+      it "returns 404 if the requested association does not exist" do
+        expect(controller).to receive(:render_404) { controller.render body: nil }
+        get :show, params: { id: file_set, file: 'non-existant' }
+      end
+    end
+  end
+
+  describe "derivative_download_options" do
+    before do
+      allow(controller).to receive(:default_file).and_return 'world.png'
+    end
+    subject { controller.send(:derivative_download_options) }
+    it { is_expected.to eq(disposition: 'inline', type: 'image/png') }
+  end
+end

data/spec/controllers/hyrax/featured_work_lists_controller_spec.rb

@@ -0,0 +1,20 @@
+describe Hyrax::FeaturedWorkListsController, type: :controller do
+  describe "#create" do
+    before do
+      expect(controller).to receive(:authorize!).with(:update, FeaturedWork)
+    end
+
+    let(:feature1) { FactoryGirl.create(:featured_work) }
+    let(:feature2) { FactoryGirl.create(:featured_work) }
+
+    it "is successful" do
+      post :create, params: {
+        format: :json,
+        featured_work_list: {
+          featured_works_attributes: [{ id: feature1.id, order: "2" }, { id: feature2.id, order: "1" }]
+        }
+      }
+      expect(feature1.reload.order).to eq 2
+    end
+  end
+end