test-kitchen 1.3.1 → 1.4.0.beta.1

data/spec/kitchen/provisioner/chef_zero_spec.rb

@@ -25,17 +25,20 @@ describe Kitchen::Provisioner::ChefZero do
 
   let(:logged_output)   { StringIO.new }
   let(:logger)          { Logger.new(logged_output) }
+  let(:platform)        { stub(:os_type => nil) }
+  let(:suite)           { stub(:name => "fries") }
 
   let(:config) do
     { :test_base_path => "/b", :kitchen_root => "/r", :log_level => :info }
   end
 
-  let(:suite) do
-    stub(:name => "fries")
-  end
-
   let(:instance) do
-    stub(:name => "coolbeans", :logger => logger, :suite => suite)
+    stub(
+      :name => "coolbeans",
+      :logger => logger,
+      :suite => suite,
+      :platform => platform
+    )
   end
 
   let(:provisioner) do
@@ -44,18 +47,44 @@ describe Kitchen::Provisioner::ChefZero do
 
   describe "default config" do
 
-    it "sets :client_rb to an empty Hash" do
-      provisioner[:client_rb].must_equal Hash.new
+    describe "for unix operating systems" do
+
+      before { platform.stubs(:os_type).returns("unix") }
+
+      it "sets :chef_client_path to a path using :chef_omnibus_root" do
+        config[:chef_omnibus_root] = "/nice/place"
+
+        provisioner[:chef_client_path].
+          must_equal "/nice/place/bin/chef-client"
+      end
+
+      it "sets :ruby_bindir to use an Omnibus Ruby" do
+        config[:chef_omnibus_root] = "/nice"
+
+        provisioner[:ruby_bindir].must_equal "/nice/embedded/bin"
+      end
     end
 
-    it "sets :chef_client_path to a path using :chef_omnibus_root" do
-      config[:chef_omnibus_root] = "/nice/place"
+    describe "for windows operating systems" do
+
+      before { platform.stubs(:os_type).returns("windows") }
+
+      it "sets :chef_client_path to a path using :chef_omnibus_root" do
+        config[:chef_omnibus_root] = "$env:systemdrive\\nice\\place"
+
+        provisioner[:chef_client_path].
+          must_equal "$env:systemdrive\\nice\\place\\bin\\chef-client.bat"
+      end
+
+      it "sets :ruby_bindir to use an Omnibus Ruby" do
+        config[:chef_omnibus_root] = "c:\\nice"
 
-      provisioner[:chef_client_path].must_equal "/nice/place/bin/chef-client"
+        provisioner[:ruby_bindir].must_equal "c:\\nice\\embedded\\bin"
+      end
     end
 
-    it "sets :ruby_bindir to use an Omnibus Ruby" do
-      provisioner[:ruby_bindir].must_equal "/opt/chef/embedded/bin"
+    it "sets :client_rb to an empty Hash" do
+      provisioner[:client_rb].must_equal Hash.new
     end
 
     it "sets :json_attributes to true" do
@@ -113,64 +142,104 @@ describe Kitchen::Provisioner::ChefZero do
 
       describe "defaults" do
 
-        before { provisioner.create_sandbox }
-
-        it "sets node_name to the instance name" do
-          file.must_include %{node_name "#{instance.name}"}
+        # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+        def self.common_client_rb_specs
+          it "sets node_name to the instance name" do
+            file.must_include %{node_name "#{instance.name}"}
+          end
+
+          it "sets checksum_path" do
+            file.must_include %{checksum_path "#{base}checksums"}
+          end
+
+          it "sets file_backup_path" do
+            file.must_include %{file_backup_path "#{base}backup"}
+          end
+
+          it "sets cookbook_path" do
+            file.must_include %{cookbook_path } +
+              %{["#{base}cookbooks", "#{base}site-cookbooks"]}
+          end
+
+          it "sets data_bag_path" do
+            file.must_include %{data_bag_path "#{base}data_bags"}
+          end
+
+          it "sets environment_path" do
+            file.must_include %{environment_path "#{base}environments"}
+          end
+
+          it "sets node_path" do
+            file.must_include %{node_path "#{base}nodes"}
+          end
+
+          it "sets role_path" do
+            file.must_include %{role_path "#{base}roles"}
+          end
+
+          it "sets client_path" do
+            file.must_include %{client_path "#{base}clients"}
+          end
+
+          it "sets user_path" do
+            file.must_include %{user_path "#{base}users"}
+          end
+
+          it "sets validation_key" do
+            file.must_include %{validation_key "#{base}validation.pem"}
+          end
+
+          it "sets client_key" do
+            file.must_include %{client_key "#{base}client.pem"}
+          end
+
+          it "sets chef_server_url" do
+            file.must_include %{chef_server_url "http://127.0.0.1:8889"}
+          end
+
+          it "sets encrypted_data_bag_secret" do
+            file.must_include %{encrypted_data_bag_secret } +
+              %{"#{base}encrypted_data_bag_secret"}
+          end
         end
+        # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
-        it "sets checksum_path" do
-          file.must_include %{checksum_path "/tmp/kitchen/checksums"}
-        end
-
-        it "sets file_backup_path" do
-          file.must_include %{file_backup_path "/tmp/kitchen/backup"}
-        end
+        describe "for unix os types" do
 
-        it "sets cookbook_path" do
-          file.must_include %{cookbook_path } +
-            %{["/tmp/kitchen/cookbooks", "/tmp/kitchen/site-cookbooks"]}
-        end
+          before do
+            platform.stubs(:os_type).returns("unix")
+            provisioner.create_sandbox
+          end
 
-        it "sets data_bag_path" do
-          file.must_include %{data_bag_path "/tmp/kitchen/data_bags"}
-        end
+          let(:base) { "/tmp/kitchen/" }
 
-        it "sets environment_path" do
-          file.must_include %{environment_path "/tmp/kitchen/environments"}
+          common_client_rb_specs
         end
 
-        it "sets node_path" do
-          file.must_include %{node_path "/tmp/kitchen/nodes"}
-        end
+        describe "for windows os types with full path" do
 
-        it "sets role_path" do
-          file.must_include %{role_path "/tmp/kitchen/roles"}
-        end
+          before do
+            platform.stubs(:os_type).returns("windows")
+            config[:root_path] = "\\a\\b"
+            provisioner.create_sandbox
+          end
 
-        it "sets client_path" do
-          file.must_include %{client_path "/tmp/kitchen/clients"}
-        end
+          let(:base) { "\\\\a\\\\b\\\\" }
 
-        it "sets user_path" do
-          file.must_include %{user_path "/tmp/kitchen/users"}
+          common_client_rb_specs
         end
 
-        it "sets validation_key" do
-          file.must_include %{validation_key "/tmp/kitchen/validation.pem"}
-        end
+        describe "for windows os types with $env:TEMP prefixed paths" do
 
-        it "sets client_key" do
-          file.must_include %{client_key "/tmp/kitchen/client.pem"}
-        end
+          before do
+            platform.stubs(:os_type).returns("windows")
+            config[:root_path] = "$env:TEMP\\a"
+            provisioner.create_sandbox
+          end
 
-        it "sets chef_server_url" do
-          file.must_include %{chef_server_url "http://127.0.0.1:8889"}
-        end
+          let(:base) { "\#{ENV['TEMP']}\\\\a\\\\" }
 
-        it "sets encrypted_data_bag_secret" do
-          file.must_include %{encrypted_data_bag_secret } +
-            %{"/tmp/kitchen/encrypted_data_bag_secret"}
+          common_client_rb_specs
         end
       end
 
@@ -316,101 +385,185 @@ describe Kitchen::Provisioner::ChefZero do
 
     describe "for old Chef versions" do
 
-      before do
-        config[:require_chef_omnibus] = "10.20"
-        config[:ruby_bindir] = "/rbd"
-      end
+      before { config[:require_chef_omnibus] = "10.20" }
 
-      it "uses bourne shell" do
-        cmd.must_match(/\Ash -c '$/)
-        cmd.must_match(/'\Z/)
-      end
+      describe "for bourne shells" do
 
-      it "sets the CHEF_REPO_PATH environment variable" do
-        config[:root_path] = "/r"
+        before do
+          platform.stubs(:shell_type).returns("bourne")
+          config[:ruby_bindir] = "/rbd"
+        end
 
-        cmd.must_match regexify(%{CHEF_REPO_PATH="/r" }, :partial_line)
-      end
+        it "uses bourne shell" do
+          cmd.must_match(/\Ash -c '$/)
+          cmd.must_match(/'\Z/)
+        end
 
-      it "sets the GEM_HOME environment variable" do
-        config[:root_path] = "/r"
+        it "ends with a single quote" do
+          cmd.must_match(/'\Z/)
+        end
 
-        cmd.must_match regexify(
-          %{GEM_HOME="/r/chef-client-zero-gems" }, :partial_line)
-      end
+        it "exports http_proxy & HTTP_PROXY when :http_proxy is set" do
+          config[:http_proxy] = "http://proxy"
 
-      it "sets the GEM_PATH environment variable" do
-        config[:root_path] = "/r"
+          cmd.lines.to_a[1..2].must_equal([
+            %{http_proxy="http://proxy"; export http_proxy\n},
+            %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n}
+          ])
+        end
 
-        cmd.must_match regexify(
-          %{GEM_PATH="/r/chef-client-zero-gems" }, :partial_line)
-      end
+        it "exports https_proxy & HTTPS_PROXY when :https_proxy is set" do
+          config[:https_proxy] = "https://proxy"
 
-      it "sets the GEM_CACHE environment variable" do
-        config[:root_path] = "/r"
+          cmd.lines.to_a[1..2].must_equal([
+            %{https_proxy="https://proxy"; export https_proxy\n},
+            %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+          ])
+        end
 
-        cmd.must_match regexify(
-          %{GEM_CACHE="/r/chef-client-zero-gems/cache" }, :partial_line)
-      end
+        it "exports all http proxy variables when both are set" do
+          config[:http_proxy] = "http://proxy"
+          config[:https_proxy] = "https://proxy"
 
-      it "exports all the environment variables" do
-        cmd.must_match regexify(
-          "export CHEF_REPO_PATH GEM_HOME GEM_PATH GEM_CACHE;", :partial_line)
-      end
+          cmd.lines.to_a[1..4].must_equal([
+            %{http_proxy="http://proxy"; export http_proxy\n},
+            %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n},
+            %{https_proxy="https://proxy"; export https_proxy\n},
+            %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+          ])
+        end
 
-      it "checks if chef-zero is installed" do
-        cmd.must_match regexify(
-          %{if ! sudo -E /rbd/gem list chef-zero -i >/dev/null; then})
-      end
+        it "sets the CHEF_REPO_PATH environment variable" do
+          config[:root_path] = "/r"
 
-      it "installs the chef gem" do
-        cmd.must_match regexify(
-          %{sudo -E /rbd/gem install chef --no-ri --no-rdoc --conservative})
-      end
-    end
-  end
+          cmd.must_match regexify(
+            %{CHEF_REPO_PATH="/r"; export CHEF_REPO_PATH})
+        end
 
-  describe "#run_command" do
+        it "sets the GEM_HOME environment variable" do
+          config[:root_path] = "/r"
 
-    let(:cmd) { provisioner.run_command }
+          cmd.must_match regexify(
+            %{GEM_HOME="/r/chef-client-zero-gems"; export GEM_HOME})
+        end
 
-    describe "for modern Chef versions" do
+        it "sets the GEM_PATH environment variable" do
+          config[:root_path] = "/r"
 
-      before { config[:require_chef_omnibus] = "11.10" }
+          cmd.must_match regexify(
+            %{GEM_PATH="/r/chef-client-zero-gems"; export GEM_PATH})
+        end
 
-      it "uses bourne shell" do
-        cmd.must_match(/\Ash -c '$/)
-        cmd.must_match(/'\Z/)
-      end
+        it "sets the GEM_CACHE environment variable" do
+          config[:root_path] = "/r"
 
-      it "uses sudo for chef-client when configured" do
-        config[:chef_omnibus_root] = "/c"
-        config[:sudo] = true
+          cmd.must_match regexify(
+            %{GEM_CACHE="/r/chef-client-zero-gems/cache"; export GEM_CACHE})
+        end
 
-        cmd.must_match regexify("sudo -E /c/bin/chef-client ", :partial_line)
-      end
+        it "prepends sudo for gem command when :sudo is set" do
+          config[:sudo] = true
+
+          cmd.must_match regexify(%{gem="sudo -E /rbd/gem"})
+        end
 
-      it "does not use sudo for chef-client when configured" do
-        config[:chef_omnibus_root] = "/c"
-        config[:sudo] = false
+        it "does not sudo for gem commands when :sudo is falsey" do
+          config[:sudo] = false
 
-        cmd.must_match regexify("/c/bin/chef-client ", :partial_line)
-        cmd.wont_match regexify("sudo -E /c/bin/chef-client ", :partial_line)
+          cmd.must_match regexify(%{gem="/rbd/gem"})
+        end
       end
 
-      it "sets local mode flag on chef-client" do
-        cmd.must_match regexify(" --local-mode", :partial_line)
+      describe "for powershell shells on windows os types" do
+
+        before do
+          platform.stubs(:shell_type).returns("powershell")
+          platform.stubs(:os_type).returns("windows")
+          config[:root_path] = "\\r"
+          config[:ruby_bindir] = "\\rbd"
+        end
+
+        it "exports http_proxy & HTTP_PROXY when :http_proxy is set" do
+          config[:http_proxy] = "http://proxy"
+
+          cmd.lines.to_a[0..1].must_equal([
+            %{$env:http_proxy = "http://proxy"\n},
+            %{$env:HTTP_PROXY = "http://proxy"\n}
+          ])
+        end
+
+        it "exports https_proxy & HTTPS_PROXY when :https_proxy is set" do
+          config[:https_proxy] = "https://proxy"
+
+          cmd.lines.to_a[0..1].must_equal([
+            %{$env:https_proxy = "https://proxy"\n},
+            %{$env:HTTPS_PROXY = "https://proxy"\n}
+          ])
+        end
+
+        it "exports all http proxy variables when both are set" do
+          config[:http_proxy] = "http://proxy"
+          config[:https_proxy] = "https://proxy"
+
+          cmd.lines.to_a[0..3].must_equal([
+            %{$env:http_proxy = "http://proxy"\n},
+            %{$env:HTTP_PROXY = "http://proxy"\n},
+            %{$env:https_proxy = "https://proxy"\n},
+            %{$env:HTTPS_PROXY = "https://proxy"\n}
+          ])
+        end
+
+        it "sets the CHEF_REPO_PATH environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:CHEF_REPO_PATH = "\\r"})
+        end
+
+        it "sets the GEM_HOME environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:GEM_HOME = "\\r\\chef-client-zero-gems"})
+        end
+
+        it "sets the GEM_PATH environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:GEM_PATH = "\\r\\chef-client-zero-gems"})
+        end
+
+        it "sets the GEM_CACHE environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:GEM_CACHE = "\\r\\chef-client-zero-gems\\cache"})
+        end
+
+        it "sets the path to the gem command" do
+          cmd.must_match regexify(%{$gem = "\\rbd\\gem.bat"})
+        end
       end
+    end
+  end
 
+  describe "#run_command" do
+
+    let(:cmd) { provisioner.run_command }
+
+    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+    def self.common_shell_specs
       it "sets config flag on chef-client" do
         cmd.must_match regexify(
-          " --config /tmp/kitchen/client.rb", :partial_line)
+          " --config #{base}client.rb", :partial_line)
       end
 
       it "sets config flag for custom root_path" do
-        config[:root_path] = "/a/b"
+        config[:root_path] = custom_root
 
-        cmd.must_match regexify(" --config /a/b/client.rb", :partial_line)
+        cmd.must_match regexify(
+          " --config #{custom_base}client.rb", :partial_line)
       end
 
       it "sets log level flag on chef-client to auto by default" do
@@ -431,60 +584,201 @@ describe Kitchen::Provisioner::ChefZero do
         cmd.must_match regexify(" --no-color", :partial_line)
       end
 
-      it "sets chef zero port flag on chef-client" do
-        cmd.must_match regexify(" --chef-zero-port 8889", :partial_line)
+      it "sets json attributes flag on chef-client" do
+        cmd.must_match regexify(
+          " --json-attributes #{base}dna.json", :partial_line)
       end
 
-      it "sets chef zero host flag for custom host" do
-        config[:chef_zero_host] = "192.168.0.1"
+      it "sets json attribtes flag for custom root_path" do
+        config[:root_path] = custom_root
 
-        cmd.must_match regexify(" --chef-zero-host 192.168.0.1", :partial_line)
+        cmd.must_match regexify(
+          " --json-attributes #{custom_base}dna.json", :partial_line)
       end
 
-      it "sets chef zero port flag for custom port" do
-        config[:chef_zero_port] = 123
+      it "does not set json attributes flag if config is falsey" do
+        config[:json_attributes] = false
 
-        cmd.must_match regexify(" --chef-zero-port 123", :partial_line)
+        cmd.wont_match regexify(" --json-attributes ", :partial_line)
       end
 
-      it "does not set chef zero host flag when value is falsey" do
-        config[:chef_zero_host] = nil
+      it "sets logfile flag for custom value" do
+        config[:log_file] = "#{custom_base}out.log"
 
-        cmd.wont_match regexify(" --chef-zero-host ", :partial_line)
+        cmd.must_match regexify(
+          " --logfile #{custom_base}out.log", :partial_line)
       end
 
-      it "does not set chef zero port flag when value is falsey" do
-        config[:chef_zero_port] = nil
-
-        cmd.wont_match regexify(" --chef-zero-port ", :partial_line)
+      it "does not set logfile flag by default" do
+        cmd.wont_match regexify(" --logfile ", :partial_line)
       end
+    end
+    # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
-      it "sets json attributes flag on chef-client" do
-        cmd.must_match regexify(
-          " --json-attributes /tmp/kitchen/dna.json", :partial_line)
-      end
+    describe "for modern Chef versions" do
 
-      it "sets json attribtes flag for custom root_path" do
-        config[:root_path] = "/booyah"
+      before { config[:require_chef_omnibus] = "11.10" }
 
-        cmd.must_match regexify(
-          " --json-attributes /booyah/dna.json", :partial_line)
-      end
+      # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+      def self.common_modern_shell_specs
+        it "sets local mode flag on chef-client" do
+          cmd.must_match regexify(" --local-mode", :partial_line)
+        end
 
-      it "does not set json attributes flag if config is falsey" do
-        config[:json_attributes] = false
+        it "sets chef zero port flag on chef-client" do
+          cmd.must_match regexify(" --chef-zero-port 8889", :partial_line)
+        end
 
-        cmd.wont_match regexify(" --json-attributes ", :partial_line)
+        it "sets chef zero host flag for custom host" do
+          config[:chef_zero_host] = "192.168.0.1"
+
+          cmd.must_match regexify(" --chef-zero-host 192.168.0.1", :partial_line)
+        end
+
+        it "sets chef zero port flag for custom port" do
+          config[:chef_zero_port] = 123
+
+          cmd.must_match regexify(" --chef-zero-port 123", :partial_line)
+        end
+
+        it "does not set chef zero host flag when value is falsey" do
+          config[:chef_zero_host] = nil
+
+          cmd.wont_match regexify(" --chef-zero-host ", :partial_line)
+        end
+
+        it "does not set chef zero port flag when value is falsey" do
+          config[:chef_zero_port] = nil
+
+          cmd.wont_match regexify(" --chef-zero-port ", :partial_line)
+        end
       end
+      # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
-      it "does not set logfile flag by default" do
-        cmd.wont_match regexify(" --logfile ", :partial_line)
+      describe "for bourne shells" do
+
+        before { platform.stubs(:shell_type).returns("bourne") }
+
+        let(:base) { "/tmp/kitchen/" }
+        let(:custom_base) { "/a/b/" }
+        let(:custom_root) { "/a/b" }
+
+        common_shell_specs
+        common_modern_shell_specs
+
+        it "uses bourne shell" do
+          cmd.must_match(/\Ash -c '$/)
+          cmd.must_match(/'\Z/)
+        end
+
+        it "ends with a single quote" do
+          cmd.must_match(/'\Z/)
+        end
+
+        it "exports http_proxy & HTTP_PROXY when :http_proxy is set" do
+          config[:http_proxy] = "http://proxy"
+
+          cmd.lines.to_a[1..2].must_equal([
+            %{http_proxy="http://proxy"; export http_proxy\n},
+            %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n}
+          ])
+        end
+
+        it "exports https_proxy & HTTPS_PROXY when :https_proxy is set" do
+          config[:https_proxy] = "https://proxy"
+
+          cmd.lines.to_a[1..2].must_equal([
+            %{https_proxy="https://proxy"; export https_proxy\n},
+            %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+          ])
+        end
+
+        it "exports all http proxy variables when both are set" do
+          config[:http_proxy] = "http://proxy"
+          config[:https_proxy] = "https://proxy"
+
+          cmd.lines.to_a[1..4].must_equal([
+            %{http_proxy="http://proxy"; export http_proxy\n},
+            %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n},
+            %{https_proxy="https://proxy"; export https_proxy\n},
+            %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+          ])
+        end
+
+        it "does no powershell PATH reloading for older chef omnibus packages" do
+          cmd.wont_match regexify(%{[System.Environment]::})
+        end
+
+        it "uses sudo for chef-client when configured" do
+          config[:chef_omnibus_root] = "/c"
+          config[:sudo] = true
+
+          cmd.must_match regexify("sudo -E /c/bin/chef-client ", :partial_line)
+        end
+
+        it "does not use sudo for chef-client when configured" do
+          config[:chef_omnibus_root] = "/c"
+          config[:sudo] = false
+
+          cmd.must_match regexify("/c/bin/chef-client ", :partial_line)
+          cmd.wont_match regexify("sudo -E /c/bin/chef-client ", :partial_line)
+        end
       end
 
-      it "sets logfile flag for custom value" do
-        config[:log_file] = "/a/out.log"
+      describe "for powershell shells on windows os types" do
+
+        before do
+          platform.stubs(:shell_type).returns("powershell")
+          platform.stubs(:os_type).returns("windows")
+        end
+
+        let(:base) { "$env:TEMP\\kitchen\\" }
+        let(:custom_base) { "\\a\\b\\" }
+        let(:custom_root) { "\\a\\b" }
+
+        common_shell_specs
+        common_modern_shell_specs
+
+        it "exports http_proxy & HTTP_PROXY when :http_proxy is set" do
+          config[:http_proxy] = "http://proxy"
+
+          cmd.lines.to_a[0..1].must_equal([
+            %{$env:http_proxy = "http://proxy"\n},
+            %{$env:HTTP_PROXY = "http://proxy"\n}
+          ])
+        end
+
+        it "exports https_proxy & HTTPS_PROXY when :https_proxy is set" do
+          config[:https_proxy] = "https://proxy"
+
+          cmd.lines.to_a[0..1].must_equal([
+            %{$env:https_proxy = "https://proxy"\n},
+            %{$env:HTTPS_PROXY = "https://proxy"\n}
+          ])
+        end
 
-        cmd.must_match regexify(" --logfile /a/out.log", :partial_line)
+        it "exports all http proxy variables when both are set" do
+          config[:http_proxy] = "http://proxy"
+          config[:https_proxy] = "https://proxy"
+
+          cmd.lines.to_a[0..3].must_equal([
+            %{$env:http_proxy = "http://proxy"\n},
+            %{$env:HTTP_PROXY = "http://proxy"\n},
+            %{$env:https_proxy = "https://proxy"\n},
+            %{$env:HTTPS_PROXY = "https://proxy"\n}
+          ])
+        end
+
+        it "reloads PATH for older chef omnibus packages" do
+          cmd.must_match regexify("$env:PATH = " +
+            %{[System.Environment]::GetEnvironmentVariable("PATH","Machine")})
+        end
+
+        it "calls the chef-client command from :chef_client_path" do
+          config[:chef_client_path] = "\\r\\chef-client.bat"
+
+          cmd.must_match regexify("& \\r\\chef-client.bat ", :partial_line)
+        end
       end
     end
 
@@ -492,118 +786,155 @@ describe Kitchen::Provisioner::ChefZero do
 
       before do
         config[:require_chef_omnibus] = "10.20"
-        config[:ruby_bindir] = "/r/bin"
       end
 
-      it "uses bourne shell" do
-        cmd.must_match(/\Ash -c '$/)
-        cmd.must_match(/'\Z/)
-      end
+      # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+      def self.common_old_shell_specs
+        it "does not set local mode flag" do
+          cmd.wont_match regexify(" --local-mode", :partial_line)
+        end
 
-      it "uses sudo for ruby when configured" do
-        config[:root_path] = "/x"
-        config[:sudo] = true
+        it "does not set chef zero host flag for custom host" do
+          config[:chef_zero_host] = "192.168.0.1"
 
-        cmd.must_match regexify(
-          "sudo -E /r/bin/ruby /x/chef-client-zero.rb ", :partial_line)
-      end
+          cmd.wont_match regexify(" --chef-zero-host 192.168.0.1", :partial_line)
+        end
 
-      it "does not use sudo for ruby when configured" do
-        config[:root_path] = "/x"
-        config[:sudo] = false
+        it "does not set chef zero port flag for custom port" do
+          config[:chef_zero_port] = 123
 
-        cmd.must_match regexify(
-          "/r/bin/ruby /x/chef-client-zero.rb ", :partial_line)
-        cmd.wont_match regexify(
-          "sudo -E /r/bin/ruby /x/chef-client-zero.rb ", :partial_line)
+          cmd.wont_match regexify(" --chef-zero-port 123", :partial_line)
+        end
       end
 
-      it "does not set local mode flag" do
-        cmd.wont_match regexify(" --local-mode", :partial_line)
-      end
+      describe "for bourne shells" do
 
-      it "sets config flag on chef-client" do
-        cmd.must_match regexify(
-          " --config /tmp/kitchen/client.rb", :partial_line)
-      end
+        before do
+          platform.stubs(:shell_type).returns("bourne")
+          config[:ruby_bindir] = "/r/bin"
+        end
 
-      it "sets config flag for custom root_path" do
-        config[:root_path] = "/a/b"
+        let(:base) { "/tmp/kitchen/" }
+        let(:custom_base) { "/a/b/" }
+        let(:custom_root) { "/a/b" }
 
-        cmd.must_match regexify(" --config /a/b/client.rb", :partial_line)
-      end
+        common_shell_specs
+        common_old_shell_specs
 
-      it "sets log level flag on chef-client to auto by default" do
-        cmd.must_match regexify(" --log_level auto", :partial_line)
-      end
+        it "uses bourne shell" do
+          cmd.must_match(/\Ash -c '$/)
+          cmd.must_match(/'\Z/)
+        end
 
-      it "set log level flag for custom level" do
-        config[:log_level] = :extreme
+        it "ends with a single quote" do
+          cmd.must_match(/'\Z/)
+        end
 
-        cmd.must_match regexify(" --log_level extreme", :partial_line)
-      end
+        it "uses sudo for ruby when configured" do
+          config[:root_path] = "/x"
+          config[:sudo] = true
 
-      it "sets force formatter flag on chef-solo" do
-        cmd.must_match regexify(" --force-formatter", :partial_line)
-      end
+          cmd.must_match regexify(
+            "sudo -E /r/bin/ruby /x/chef-client-zero.rb ", :partial_line)
+        end
 
-      it "sets no color flag on chef-solo" do
-        cmd.must_match regexify(" --no-color", :partial_line)
-      end
+        it "does not use sudo for ruby when configured" do
+          config[:root_path] = "/x"
+          config[:sudo] = false
 
-      it "sets json attributes flag on chef-client" do
-        cmd.must_match regexify(
-          " --json-attributes /tmp/kitchen/dna.json", :partial_line)
-      end
+          cmd.must_match regexify(
+            "/r/bin/ruby /x/chef-client-zero.rb ", :partial_line)
+          cmd.wont_match regexify(
+            "sudo -E /r/bin/ruby /x/chef-client-zero.rb ", :partial_line)
+        end
 
-      it "sets json attribtes flag for custom root_path" do
-        config[:root_path] = "/booyah"
+        it "sets the CHEF_REPO_PATH environment variable" do
+          config[:root_path] = "/r"
 
-        cmd.must_match regexify(
-          " --json-attributes /booyah/dna.json", :partial_line)
-      end
+          cmd.must_match regexify(
+            %{CHEF_REPO_PATH="/r"; export CHEF_REPO_PATH})
+        end
 
-      it "does not set json attributes flag if config is falsey" do
-        config[:json_attributes] = false
+        it "sets the GEM_HOME environment variable" do
+          config[:root_path] = "/r"
 
-        cmd.wont_match regexify(" --json-attributes ", :partial_line)
-      end
+          cmd.must_match regexify(
+            %{GEM_HOME="/r/chef-client-zero-gems"; export GEM_HOME})
+        end
 
-      it "does not set logfile flag by default" do
-        cmd.wont_match regexify(" --logfile ", :partial_line)
-      end
+        it "sets the GEM_PATH environment variable" do
+          config[:root_path] = "/r"
 
-      it "sets logfile flag for custom value" do
-        config[:log_file] = "/a/out.log"
+          cmd.must_match regexify(
+            %{GEM_PATH="/r/chef-client-zero-gems"; export GEM_PATH})
+        end
 
-        cmd.must_match regexify(" --logfile /a/out.log", :partial_line)
-      end
+        it "sets the GEM_CACHE environment variable" do
+          config[:root_path] = "/r"
 
-      it "sets the CHEF_REPO_PATH environment variable" do
-        config[:root_path] = "/r"
+          cmd.must_match regexify(
+            %{GEM_CACHE="/r/chef-client-zero-gems/cache"; export GEM_CACHE})
+        end
 
-        cmd.must_match regexify(%{CHEF_REPO_PATH="/r" }, :partial_line)
+        it "does no powershell PATH reloading for older chef omnibus packages" do
+          cmd.wont_match regexify(%{[System.Environment]::})
+        end
       end
 
-      it "sets the GEM_HOME environment variable" do
-        config[:root_path] = "/r"
+      describe "for powershell shells on windows os types" do
 
-        cmd.must_match regexify(
-          %{GEM_HOME="/r/chef-client-zero-gems" }, :partial_line)
-      end
+        before do
+          platform.stubs(:shell_type).returns("powershell")
+          platform.stubs(:os_type).returns("windows")
+          config[:ruby_bindir] = "\\r\\bin"
+        end
 
-      it "sets the GEM_PATH environment variable" do
-        config[:root_path] = "/r"
+        let(:base) { "$env:TEMP\\kitchen\\" }
+        let(:custom_base) { "\\a\\b\\" }
+        let(:custom_root) { "\\a\\b" }
 
-        cmd.must_match regexify(
-          %{GEM_PATH="/r/chef-client-zero-gems" }, :partial_line)
-      end
+        common_shell_specs
+        common_old_shell_specs
 
-      it "sets the GEM_CACHE environment variable" do
-        config[:root_path] = "/r"
+        it "calls ruby from :ruby_bindir" do
+          config[:root_path] = "\\x"
 
-        cmd.must_match regexify(
-          %{GEM_CACHE="/r/chef-client-zero-gems/cache" }, :partial_line)
+          cmd.must_match regexify(
+            "\\r\\bin\\ruby.exe \\x\\chef-client-zero.rb ", :partial_line)
+        end
+
+        it "sets the CHEF_REPO_PATH environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:CHEF_REPO_PATH = "\\r"})
+        end
+
+        it "sets the GEM_HOME environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:GEM_HOME = "\\r\\chef-client-zero-gems"})
+        end
+
+        it "sets the GEM_PATH environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:GEM_PATH = "\\r\\chef-client-zero-gems"})
+        end
+
+        it "sets the GEM_CACHE environment variable" do
+          config[:root_path] = "\\r"
+
+          cmd.must_match regexify(
+            %{$env:GEM_CACHE = "\\r\\chef-client-zero-gems\\cache"})
+        end
+
+        it "reloads PATH for older chef omnibus packages" do
+          cmd.must_match regexify("$env:PATH = " +
+            %{[System.Environment]::GetEnvironmentVariable("PATH","Machine")})
+        end
       end
     end
   end