test-kitchen 1.3.1 → 1.4.0.beta.1

data/spec/kitchen/provisioner/chef_solo_spec.rb

@@ -25,17 +25,20 @@ describe Kitchen::Provisioner::ChefSolo do
 
   let(:logged_output)   { StringIO.new }
   let(:logger)          { Logger.new(logged_output) }
+  let(:platform)        { stub(:os_type => nil) }
+  let(:suite)           { stub(:name => "fries") }
 
   let(:config) do
     { :test_base_path => "/b", :kitchen_root => "/r", :log_level => :info }
   end
 
-  let(:suite) do
-    stub(:name => "fries")
-  end
-
   let(:instance) do
-    stub(:name => "coolbeans", :logger => logger, :suite => suite)
+    stub(
+      :name => "coolbeans",
+      :logger => logger,
+      :suite => suite,
+      :platform => platform
+    )
   end
 
   let(:provisioner) do
@@ -44,14 +47,31 @@ describe Kitchen::Provisioner::ChefSolo do
 
   describe "default config" do
 
-    it "sets :solo_rb to an empty Hash" do
-      provisioner[:solo_rb].must_equal Hash.new
+    describe "for unix operating systems" do
+
+      before { platform.stubs(:os_type).returns("unix") }
+
+      it "sets :chef_solo_path to a path using :chef_omnibus_root" do
+        config[:chef_omnibus_root] = "/nice/place"
+
+        provisioner[:chef_solo_path].must_equal "/nice/place/bin/chef-solo"
+      end
     end
 
-    it "sets :chef_solo_path to a path using :chef_omnibus_root" do
-      config[:chef_omnibus_root] = "/nice/place"
+    describe "for windows operating systems" do
+
+      before { platform.stubs(:os_type).returns("windows") }
 
-      provisioner[:chef_solo_path].must_equal "/nice/place/bin/chef-solo"
+      it "sets :chef_solo_path to a path using :chef_omnibus_root" do
+        config[:chef_omnibus_root] = "$env:systemdrive\\nice\\place"
+
+        provisioner[:chef_solo_path].
+          must_equal "$env:systemdrive\\nice\\place\\bin\\chef-solo.bat"
+      end
+    end
+
+    it "sets :solo_rb to an empty Hash" do
+      provisioner[:solo_rb].must_equal Hash.new
     end
   end
 
@@ -97,64 +117,104 @@ describe Kitchen::Provisioner::ChefSolo do
 
       describe "defaults" do
 
-        before { provisioner.create_sandbox }
-
-        it "sets node_name to the instance name" do
-          file.must_include %{node_name "#{instance.name}"}
+        # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+        def self.common_solo_rb_specs
+          it "sets node_name to the instance name" do
+            file.must_include %{node_name "#{instance.name}"}
+          end
+
+          it "sets checksum_path" do
+            file.must_include %{checksum_path "#{base}checksums"}
+          end
+
+          it "sets file_backup_path" do
+            file.must_include %{file_backup_path "#{base}backup"}
+          end
+
+          it "sets cookbook_path" do
+            file.must_include %{cookbook_path } +
+              %{["#{base}cookbooks", "#{base}site-cookbooks"]}
+          end
+
+          it "sets data_bag_path" do
+            file.must_include %{data_bag_path "#{base}data_bags"}
+          end
+
+          it "sets environment_path" do
+            file.must_include %{environment_path "#{base}environments"}
+          end
+
+          it "sets node_path" do
+            file.must_include %{node_path "#{base}nodes"}
+          end
+
+          it "sets role_path" do
+            file.must_include %{role_path "#{base}roles"}
+          end
+
+          it "sets client_path" do
+            file.must_include %{client_path "#{base}clients"}
+          end
+
+          it "sets user_path" do
+            file.must_include %{user_path "#{base}users"}
+          end
+
+          it "sets validation_key" do
+            file.must_include %{validation_key "#{base}validation.pem"}
+          end
+
+          it "sets client_key" do
+            file.must_include %{client_key "#{base}client.pem"}
+          end
+
+          it "sets chef_server_url" do
+            file.must_include %{chef_server_url "http://127.0.0.1:8889"}
+          end
+
+          it "sets encrypted_data_bag_secret" do
+            file.must_include %{encrypted_data_bag_secret } +
+              %{"#{base}encrypted_data_bag_secret"}
+          end
         end
+        # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
-        it "sets checksum_path" do
-          file.must_include %{checksum_path "/tmp/kitchen/checksums"}
-        end
+        describe "for unix os types" do
 
-        it "sets file_backup_path" do
-          file.must_include %{file_backup_path "/tmp/kitchen/backup"}
-        end
+          before do
+            platform.stubs(:os_type).returns("unix")
+            provisioner.create_sandbox
+          end
 
-        it "sets cookbook_path" do
-          file.must_include %{cookbook_path } +
-            %{["/tmp/kitchen/cookbooks", "/tmp/kitchen/site-cookbooks"]}
-        end
+          let(:base) { "/tmp/kitchen/" }
 
-        it "sets data_bag_path" do
-          file.must_include %{data_bag_path "/tmp/kitchen/data_bags"}
+          common_solo_rb_specs
         end
 
-        it "sets environment_path" do
-          file.must_include %{environment_path "/tmp/kitchen/environments"}
-        end
+        describe "for windows os types with full path" do
 
-        it "sets node_path" do
-          file.must_include %{node_path "/tmp/kitchen/nodes"}
-        end
+          before do
+            platform.stubs(:os_type).returns("windows")
+            config[:root_path] = "\\a\\b"
+            provisioner.create_sandbox
+          end
 
-        it "sets role_path" do
-          file.must_include %{role_path "/tmp/kitchen/roles"}
-        end
-
-        it "sets client_path" do
-          file.must_include %{client_path "/tmp/kitchen/clients"}
-        end
+          let(:base) { "\\\\a\\\\b\\\\" }
 
-        it "sets user_path" do
-          file.must_include %{user_path "/tmp/kitchen/users"}
+          common_solo_rb_specs
         end
 
-        it "sets validation_key" do
-          file.must_include %{validation_key "/tmp/kitchen/validation.pem"}
-        end
+        describe "for windows os types with $env:TEMP prefixed paths" do
 
-        it "sets client_key" do
-          file.must_include %{client_key "/tmp/kitchen/client.pem"}
-        end
+          before do
+            platform.stubs(:os_type).returns("windows")
+            config[:root_path] = "$env:TEMP\\a"
+            provisioner.create_sandbox
+          end
 
-        it "sets chef_server_url" do
-          file.must_include %{chef_server_url "http://127.0.0.1:8889"}
-        end
+          let(:base) { "\#{ENV['TEMP']}\\\\a\\\\" }
 
-        it "sets encrypted_data_bag_secret" do
-          file.must_include %{encrypted_data_bag_secret } +
-            %{"/tmp/kitchen/encrypted_data_bag_secret"}
+          common_solo_rb_specs
         end
       end
 
@@ -171,7 +231,7 @@ describe Kitchen::Provisioner::ChefSolo do
         file.must_include %{client_key "lol"}
       end
 
-      it " supports adding new configuration" do
+      it "supports adding new configuration" do
         config[:solo_rb] = {
           :dark_secret => "golang"
         }
@@ -222,81 +282,224 @@ describe Kitchen::Provisioner::ChefSolo do
     def sandbox_path(path)
       Pathname.new(provisioner.sandbox_path).join(path)
     end
-
   end
 
   describe "#run_command" do
 
     let(:cmd) { provisioner.run_command }
 
-    it "uses bourne shell" do
-      cmd.must_match(/\Ash -c '$/)
-      cmd.must_match(/'\Z/)
-    end
+    describe "for bourne shells" do
 
-    it "uses sudo for chef-solo when configured" do
-      config[:chef_omnibus_root] = "/c"
-      config[:sudo] = true
+      before { platform.stubs(:shell_type).returns("bourne") }
 
-      cmd.must_match regexify("sudo -E /c/bin/chef-solo ", :partial_line)
-    end
+      it "uses bourne shell" do
+        cmd.must_match(/\Ash -c '$/)
+        cmd.must_match(/'\Z/)
+      end
 
-    it "does not use sudo for chef-solo when configured" do
-      config[:chef_omnibus_root] = "/c"
-      config[:sudo] = false
+      it "ends with a single quote" do
+        cmd.must_match(/'\Z/)
+      end
 
-      cmd.must_match regexify("chef-solo ", :partial_line)
-      cmd.wont_match regexify("sudo -E /c/bin/chef-solo ", :partial_line)
-    end
+      it "exports http_proxy & HTTP_PROXY when :http_proxy is set" do
+        config[:http_proxy] = "http://proxy"
 
-    it "sets config flag on chef-solo" do
-      cmd.must_match regexify(" --config /tmp/kitchen/solo.rb", :partial_line)
-    end
+        cmd.lines.to_a[1..2].must_equal([
+          %{http_proxy="http://proxy"; export http_proxy\n},
+          %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n}
+        ])
+      end
 
-    it "sets config flag for custom root_path" do
-      config[:root_path] = "/a/b"
+      it "exports https_proxy & HTTPS_PROXY when :https_proxy is set" do
+        config[:https_proxy] = "https://proxy"
 
-      cmd.must_match regexify(" --config /a/b/solo.rb", :partial_line)
-    end
+        cmd.lines.to_a[1..2].must_equal([
+          %{https_proxy="https://proxy"; export https_proxy\n},
+          %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+        ])
+      end
 
-    it "sets json attributes flag on chef-solo" do
-      cmd.must_match regexify(
-        " --json-attributes /tmp/kitchen/dna.json", :partial_line)
-    end
+      it "exports all http proxy variables when both are set" do
+        config[:http_proxy] = "http://proxy"
+        config[:https_proxy] = "https://proxy"
 
-    it "sets json attribtes flag for custom root_path" do
-      config[:root_path] = "/booyah"
+        cmd.lines.to_a[1..4].must_equal([
+          %{http_proxy="http://proxy"; export http_proxy\n},
+          %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n},
+          %{https_proxy="https://proxy"; export https_proxy\n},
+          %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+        ])
+      end
 
-      cmd.must_match regexify(
-        " --json-attributes /booyah/dna.json", :partial_line)
-    end
+      it "does no powershell PATH reloading for older chef omnibus packages" do
+        cmd.wont_match regexify(%{[System.Environment]::})
+      end
 
-    it "sets log level flag on chef-solo to auto by default" do
-      cmd.must_match regexify(" --log_level auto", :partial_line)
-    end
+      it "uses sudo for chef-solo when configured" do
+        config[:chef_omnibus_root] = "/c"
+        config[:sudo] = true
 
-    it "set log level flag for custom level" do
-      config[:log_level] = :extreme
+        cmd.must_match regexify("sudo -E /c/bin/chef-solo ", :partial_line)
+      end
 
-      cmd.must_match regexify(" --log_level extreme", :partial_line)
-    end
+      it "does not use sudo for chef-solo when configured" do
+        config[:chef_omnibus_root] = "/c"
+        config[:sudo] = false
 
-    it "sets force formatter flag on chef-solo" do
-      cmd.must_match regexify(" --force-formatter", :partial_line)
-    end
+        cmd.must_match regexify("chef-solo ", :partial_line)
+        cmd.wont_match regexify("sudo -E /c/bin/chef-solo ", :partial_line)
+      end
 
-    it "sets no color flag on chef-solo" do
-      cmd.must_match regexify(" --no-color", :partial_line)
-    end
+      it "sets config flag on chef-solo" do
+        cmd.must_match regexify(" --config /tmp/kitchen/solo.rb", :partial_line)
+      end
+
+      it "sets config flag for custom root_path" do
+        config[:root_path] = "/a/b"
+
+        cmd.must_match regexify(" --config /a/b/solo.rb", :partial_line)
+      end
+
+      it "sets json attributes flag on chef-solo" do
+        cmd.must_match regexify(
+          " --json-attributes /tmp/kitchen/dna.json", :partial_line)
+      end
+
+      it "sets json attribtes flag for custom root_path" do
+        config[:root_path] = "/booyah"
 
-    it "does not set logfile flag by default" do
-      cmd.wont_match regexify(" --logfile ", :partial_line)
+        cmd.must_match regexify(
+          " --json-attributes /booyah/dna.json", :partial_line)
+      end
+
+      it "sets log level flag on chef-solo to auto by default" do
+        cmd.must_match regexify(" --log_level auto", :partial_line)
+      end
+
+      it "set log level flag for custom level" do
+        config[:log_level] = :extreme
+
+        cmd.must_match regexify(" --log_level extreme", :partial_line)
+      end
+
+      it "sets force formatter flag on chef-solo" do
+        cmd.must_match regexify(" --force-formatter", :partial_line)
+      end
+
+      it "sets no color flag on chef-solo" do
+        cmd.must_match regexify(" --no-color", :partial_line)
+      end
+
+      it "does not set logfile flag by default" do
+        cmd.wont_match regexify(" --logfile ", :partial_line)
+      end
+
+      it "sets logfile flag for custom value" do
+        config[:log_file] = "/a/out.log"
+
+        cmd.must_match regexify(" --logfile /a/out.log", :partial_line)
+      end
     end
 
-    it "sets logfile flag for custom value" do
-      config[:log_file] = "/a/out.log"
+    describe "for powershell shells on windows os types" do
+
+      before do
+        platform.stubs(:shell_type).returns("powershell")
+        platform.stubs(:os_type).returns("windows")
+      end
+
+      it "exports http_proxy & HTTP_PROXY when :http_proxy is set" do
+        config[:http_proxy] = "http://proxy"
+
+        cmd.lines.to_a[0..1].must_equal([
+          %{$env:http_proxy = "http://proxy"\n},
+          %{$env:HTTP_PROXY = "http://proxy"\n}
+        ])
+      end
+
+      it "exports https_proxy & HTTPS_PROXY when :https_proxy is set" do
+        config[:https_proxy] = "https://proxy"
+
+        cmd.lines.to_a[0..1].must_equal([
+          %{$env:https_proxy = "https://proxy"\n},
+          %{$env:HTTPS_PROXY = "https://proxy"\n}
+        ])
+      end
+
+      it "exports all http proxy variables when both are set" do
+        config[:http_proxy] = "http://proxy"
+        config[:https_proxy] = "https://proxy"
+
+        cmd.lines.to_a[0..3].must_equal([
+          %{$env:http_proxy = "http://proxy"\n},
+          %{$env:HTTP_PROXY = "http://proxy"\n},
+          %{$env:https_proxy = "https://proxy"\n},
+          %{$env:HTTPS_PROXY = "https://proxy"\n}
+        ])
+      end
+
+      it "reloads PATH for older chef omnibus packages" do
+        cmd.must_match regexify("$env:PATH = " +
+          %{[System.Environment]::GetEnvironmentVariable("PATH","Machine")})
+      end
+
+      it "calls the chef-solo command from :chef_solo_path" do
+        config[:chef_solo_path] = "\\r\\chef-solo.bat"
+
+        cmd.must_match regexify("& \\r\\chef-solo.bat ", :partial_line)
+      end
+
+      it "sets config flag on chef-solo" do
+        cmd.must_match regexify(
+          " --config $env:TEMP\\kitchen\\solo.rb", :partial_line)
+      end
+
+      it "sets config flag for custom root_path" do
+        config[:root_path] = "\\a\\b"
+
+        cmd.must_match regexify(
+          " --config \\a\\b\\solo.rb", :partial_line)
+      end
+
+      it "sets json attributes flag on chef-solo" do
+        cmd.must_match regexify(
+          " --json-attributes $env:TEMP\\kitchen\\dna.json", :partial_line)
+      end
+
+      it "sets json attribtes flag for custom root_path" do
+        config[:root_path] = "\\booyah"
+
+        cmd.must_match regexify(
+          " --json-attributes \\booyah\\dna.json", :partial_line)
+      end
 
-      cmd.must_match regexify(" --logfile /a/out.log", :partial_line)
+      it "sets log level flag on chef-solo to auto by default" do
+        cmd.must_match regexify(" --log_level auto", :partial_line)
+      end
+
+      it "set log level flag for custom level" do
+        config[:log_level] = :extreme
+
+        cmd.must_match regexify(" --log_level extreme", :partial_line)
+      end
+
+      it "sets force formatter flag on chef-solo" do
+        cmd.must_match regexify(" --force-formatter", :partial_line)
+      end
+
+      it "sets no color flag on chef-solo" do
+        cmd.must_match regexify(" --no-color", :partial_line)
+      end
+
+      it "does not set logfile flag by default" do
+        cmd.wont_match regexify(" --logfile ", :partial_line)
+      end
+
+      it "sets logfile flag for custom value" do
+        config[:log_file] = "\\a\\out.log"
+
+        cmd.must_match regexify(" --logfile \\a\\out.log", :partial_line)
+      end
     end
   end