taglib-ruby 1.1.0 → 1.1.1

data/test/unicode_filename_test.rb

@@ -1,22 +1,22 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 require 'fileutils'
 
 class TestUnicodeFilename < Test::Unit::TestCase
-  SRC_FILE = "test/data/vorbis.oga"
+  SRC_FILE = 'test/data/vorbis.oga'
   # That's "hello-" followed by "ni hao" in UTF-8
-  DST_FILE = "test/data/hello-\xE4\xBD\xA0\xE5\xA5\xBD.oga"
+  DST_FILE = "test/data/hello-\xE4\xBD\xA0\xE5\xA5\xBD.oga".dup # mutable
 
-  context "TagLib::FileRef" do
+  context 'TagLib::FileRef' do
     setup do
-      if HAVE_ENCODING
-        DST_FILE.force_encoding('UTF-8')
-      end
+      DST_FILE.force_encoding('UTF-8') if HAVE_ENCODING
       FileUtils.cp SRC_FILE, DST_FILE
       @fileref = TagLib::FileRef.new(DST_FILE, false)
       @tag = @fileref.tag
     end
 
-    should "be possible to read" do
+    should 'be possible to read' do
       assert_not_nil @tag
       assert_equal 'Title', @tag.title
     end

data/test/vorbis_file_test.rb

@@ -1,34 +1,36 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class TestVorbisFile < Test::Unit::TestCase
-  context "The vorbis.oga file" do
+  context 'The vorbis.oga file' do
     setup do
-      @file = TagLib::Ogg::Vorbis::File.new("test/data/vorbis.oga")
+      @file = TagLib::Ogg::Vorbis::File.new('test/data/vorbis.oga')
     end
 
-    should "have a tag" do
+    should 'have a tag' do
       tag = @file.tag
       assert_not_nil tag
       assert_equal TagLib::Ogg::XiphComment, tag.class
     end
 
-    context "audio properties" do
+    context 'audio properties' do
       setup do
         @properties = @file.audio_properties
       end
 
-      should "exist" do
+      should 'exist' do
         assert_not_nil @properties
       end
 
-      should "contain basic information" do
+      should 'contain basic information' do
         assert_equal 0, @properties.length_in_seconds # file is short
-        assert_equal 371, @properties.bitrate
+        assert_includes [371, 76], @properties.bitrate
         assert_equal 44100, @properties.sample_rate
         assert_equal 2, @properties.channels
       end
 
-      should "contain vorbis-specific information" do
+      should 'contain vorbis-specific information' do
         assert_equal 0, @properties.vorbis_version
         assert_equal 0, @properties.bitrate_maximum
         assert_equal 64000, @properties.bitrate_nominal
@@ -42,13 +44,13 @@ class TestVorbisFile < Test::Unit::TestCase
     end
   end
 
-  context "TagLib::Ogg::Vorbis::File" do
-    should "have open method" do
+  context 'TagLib::Ogg::Vorbis::File' do
+    should 'have open method' do
       title = nil
-      TagLib::Ogg::Vorbis::File.open("test/data/vorbis.oga", false) do |file|
+      TagLib::Ogg::Vorbis::File.open('test/data/vorbis.oga', false) do |file|
         title = file.tag.title
       end
-      assert_equal "Title", title
+      assert_equal 'Title', title
     end
   end
 end

data/test/vorbis_tag_test.rb

@@ -1,118 +1,120 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class TestVorbisTag < Test::Unit::TestCase
-  context "The vorbis.oga file tag" do
+  context 'The vorbis.oga file tag' do
     setup do
-      @file = TagLib::Ogg::Vorbis::File.new("test/data/vorbis.oga")
+      @file = TagLib::Ogg::Vorbis::File.new('test/data/vorbis.oga')
       @tag = @file.tag
     end
 
-    should "contain basic tag information" do
-      assert_equal "Title", @tag.title
-      assert_equal "Artist", @tag.artist
-      assert_equal "Album", @tag.album
+    should 'contain basic tag information' do
+      assert_equal 'Title', @tag.title
+      assert_equal 'Artist', @tag.artist
+      assert_equal 'Album', @tag.album
       # Use DESCRIPTION if it exists, otherwise COMMENT.
-      assert_equal "Test file", @tag.comment
-      assert_equal "Pop", @tag.genre
+      assert_equal 'Test file', @tag.comment
+      assert_equal 'Pop', @tag.genre
       assert_equal 2011, @tag.year
       assert_equal 7, @tag.track
       assert_equal false, @tag.empty?
     end
 
-    should "have contains? method" do
+    should 'have contains? method' do
       assert @tag.contains?('TITLE')
       assert !@tag.contains?('DOESNTEXIST')
     end
 
-    should "have field_count" do
+    should 'have field_count' do
       assert_equal 18, @tag.field_count
     end
 
-    should "have vendor_id" do
-      assert_equal "Xiph.Org libVorbis I 20101101 (Schaufenugget)", @tag.vendor_id
+    should 'have vendor_id' do
+      assert_equal 'Xiph.Org libVorbis I 20101101 (Schaufenugget)', @tag.vendor_id
     end
 
-    context "fields" do
+    context 'fields' do
       setup do
         @fields = @tag.field_list_map
       end
 
-      should "exist" do
+      should 'exist' do
         assert_not_nil @fields
       end
 
-      should "be usable as a Hash" do
-        assert_equal ["Title"], @fields['TITLE']
+      should 'be usable as a Hash' do
+        assert_equal ['Title'], @fields['TITLE']
         assert_nil @fields['DOESNTEXIST']
       end
 
-      should "be able to return more than one value for a key" do
-        assert_equal ["A", "B"], @fields['MULTIPLE']
+      should 'be able to return more than one value for a key' do
+        assert_equal %w[A B], @fields['MULTIPLE']
       end
     end
 
-    should "support add_field with replace" do
-      @tag.add_field('TITLE', "New Title")
-      assert_equal ["New Title"], @tag.field_list_map['TITLE']
+    should 'support add_field with replace' do
+      @tag.add_field('TITLE', 'New Title')
+      assert_equal ['New Title'], @tag.field_list_map['TITLE']
     end
 
-    should "support add_field without replace" do
+    should 'support add_field without replace' do
       replace = false
-      @tag.add_field('TITLE', "Additional Title", replace)
-      assert_equal ["Title", "Additional Title"], @tag.field_list_map['TITLE']
+      @tag.add_field('TITLE', 'Additional Title', replace)
+      assert_equal ['Title', 'Additional Title'], @tag.field_list_map['TITLE']
     end
 
-    should "support remove_fields" do
+    should 'support remove_fields' do
       assert @tag.contains?('MULTIPLE')
       @tag.remove_fields('MULTIPLE')
       refute @tag.contains?('MULTIPLE')
     end
 
-    should "support remove_all_fields" do
+    should 'support remove_all_fields' do
       refute_equal 0, @tag.field_count
-      @tag.remove_all_fields()
+      @tag.remove_all_fields
       # remove_all_fields() do not remove pictures
       assert_equal 1, @tag.field_count
     end
 
-    should "have pictures" do
+    should 'have pictures' do
       refute_empty @tag.picture_list
     end
 
-    context "first picture" do
+    context 'first picture' do
       setup do
         @picture = @tag.picture_list.first
       end
 
-      should "be a TagLib::FLAC::Picture," do
+      should 'be a TagLib::FLAC::Picture,' do
         assert_equal TagLib::FLAC::Picture, @picture.class
       end
 
-      should "have meta-data" do
+      should 'have meta-data' do
         assert_equal TagLib::FLAC::Picture::FrontCover, @picture.type
-        assert_equal "image/jpeg", @picture.mime_type
-        assert_equal "Globe", @picture.description
+        assert_equal 'image/jpeg', @picture.mime_type
+        assert_equal 'Globe', @picture.description
         assert_equal 90, @picture.width
         assert_equal 90, @picture.height
         assert_equal 24, @picture.color_depth
         assert_equal 0, @picture.num_colors
       end
 
-      should "have data" do
-        picture_data = File.open("test/data/globe_east_90.jpg", 'rb'){ |f| f.read }
+      should 'have data' do
+        picture_data = File.open('test/data/globe_east_90.jpg', 'rb') { |f| f.read }
         assert_equal picture_data, @picture.data
       end
     end
 
-    should "support removing a picture" do
+    should 'support removing a picture' do
       refute_empty @tag.picture_list
       @tag.remove_picture(@tag.picture_list.first)
       assert_empty @tag.picture_list
     end
 
-    should "support removing all pictures" do
+    should 'support removing all pictures' do
       refute_empty @tag.picture_list
-      @tag.remove_all_pictures()
+      @tag.remove_all_pictures
       assert_empty @tag.picture_list
     end
 
@@ -122,12 +124,12 @@ class TestVorbisTag < Test::Unit::TestCase
     end
   end
 
-  context "The XiphComment class" do
-    should "support check_key" do
-      refute TagLib::Ogg::XiphComment::check_key("")
-      refute TagLib::Ogg::XiphComment::check_key("something=")
-      refute TagLib::Ogg::XiphComment::check_key("something~")
-      assert TagLib::Ogg::XiphComment::check_key("something")
+  context 'The XiphComment class' do
+    should 'support check_key' do
+      refute TagLib::Ogg::XiphComment.check_key('')
+      refute TagLib::Ogg::XiphComment.check_key('something=')
+      refute TagLib::Ogg::XiphComment.check_key('something~')
+      assert TagLib::Ogg::XiphComment.check_key('something')
     end
   end
 end

data/test/wav_examples_test.rb

@@ -1,42 +1,34 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class WAVExamples < Test::Unit::TestCase
+  DATA_FILE_PREFIX = 'test/data/wav-'
 
-  DATA_FILE_PREFIX = "test/data/wav-"
-
-  context "TagLib::RIFF::WAV::File" do
-
-    should "Run TagLib::RIFF::WAV::File examples" do
-
-
+  context 'TagLib::RIFF::WAV::File' do
+    should 'Run TagLib::RIFF::WAV::File examples' do
       # Reading the title
-
       title = TagLib::RIFF::WAV::File.open("#{DATA_FILE_PREFIX}sample.wav") do |file|
         file.tag.title
       end
 
       # Reading WAV-specific audio properties
-
       TagLib::RIFF::WAV::File.open("#{DATA_FILE_PREFIX}sample.wav") do |file|
-        file.audio_properties.sample_rate  #=>  8
+        file.audio_properties.sample_rate #=>  8
       end
 
       # Saving ID3v2 cover-art to disk
-
       TagLib::RIFF::WAV::File.open("#{DATA_FILE_PREFIX}sample.wav") do |file|
         id3v2_tag = file.tag
         cover = id3v2_tag.frame_list('APIC').first
         ext = cover.mime_type.rpartition('/')[2]
-        File.open("#{DATA_FILE_PREFIX}cover-art.#{ext}", "wb") { |f| f.write cover.picture }
+        File.open("#{DATA_FILE_PREFIX}cover-art.#{ext}", 'wb') { |f| f.write cover.picture }
       end
 
-
       # checks
-      assert_equal "WAV Dummy Track Title", title
+      assert_equal 'WAV Dummy Track Title', title
       assert_equal true, File.exist?("#{DATA_FILE_PREFIX}cover-art.jpeg")
       FileUtils.rm("#{DATA_FILE_PREFIX}cover-art.jpeg")
     end
-
   end
-
 end

data/test/wav_file_test.rb

@@ -1,29 +1,30 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class WAVFileTest < Test::Unit::TestCase
+  SAMPLE_FILE = 'test/data/wav-sample.wav'
+  PICTURE_FILE = 'test/data/globe_east_540.jpg'
 
-  SAMPLE_FILE = "test/data/wav-sample.wav"
-  PICTURE_FILE = "test/data/globe_east_540.jpg"
-
-  context "TagLib::RIFF::WAV::File" do
+  context 'TagLib::RIFF::WAV::File' do
     setup do
       @file = TagLib::RIFF::WAV::File.new(SAMPLE_FILE)
     end
 
-    should "open" do
+    should 'open' do
       assert_not_nil @file
     end
 
-    context "audio properties" do
+    context 'audio properties' do
       setup do
         @properties = @file.audio_properties
       end
 
-      should "exist" do
+      should 'exist' do
         assert_not_nil @properties
       end
 
-      should "contain basic information" do
+      should 'contain basic information' do
         assert_equal 0, @properties.length_in_seconds
         assert_equal 698, @properties.length_in_milliseconds
         assert_equal 88, @properties.bitrate
@@ -31,59 +32,59 @@ class WAVFileTest < Test::Unit::TestCase
         assert_equal 1, @properties.channels
       end
 
-      should "contain WAV-specific information" do
+      should 'contain WAV-specific information' do
         assert_equal 8, @properties.bits_per_sample
         assert_equal TagLib::RIFF::WAV::FORMAT_PCM, @properties.format
       end
     end
 
-    context "ID3V2 tag" do
+    context 'ID3V2 tag' do
       setup do
         @tag = @file.tag
       end
 
-      should "exist" do
+      should 'exist' do
         assert @file.id3v2_tag?
         assert_not_nil @tag
         assert_equal TagLib::ID3v2::Tag, @tag.class
       end
 
-      should "not have an Info tag" do
+      should 'not have an Info tag' do
         refute @file.info_tag?
       end
 
-      should "contain basic tag information" do
-        assert_equal "WAV Dummy Track Title", @tag.title
-        assert_equal "WAV Dummy Artist Name", @tag.artist
-        assert_equal "WAV Dummy Album Title", @tag.album
-        assert_equal "WAV Dummy Comment", @tag.comment
-        assert_equal "Jazz", @tag.genre
+      should 'contain basic tag information' do
+        assert_equal 'WAV Dummy Track Title', @tag.title
+        assert_equal 'WAV Dummy Artist Name', @tag.artist
+        assert_equal 'WAV Dummy Album Title', @tag.album
+        assert_equal 'WAV Dummy Comment', @tag.comment
+        assert_equal 'Jazz', @tag.genre
         assert_equal 2014, @tag.year
         assert_equal 5, @tag.track
         assert_equal false, @tag.empty?
       end
 
-      context "APIC frame" do
+      context 'APIC frame' do
         setup do
           @picture_data = File.open(PICTURE_FILE, 'rb') { |f| f.read }
           @apic = @tag.frame_list('APIC').first
         end
 
-        should "exist" do
+        should 'exist' do
           assert_not_nil @apic
           assert_equal TagLib::ID3v2::AttachedPictureFrame, @apic.class
         end
 
-        should "have a type" do
+        should 'have a type' do
           assert_equal TagLib::ID3v2::AttachedPictureFrame::FrontCover, @apic.type
         end
 
-        should "have a mime type" do
-          assert_equal "image/jpeg", @apic.mime_type
+        should 'have a mime type' do
+          assert_equal 'image/jpeg', @apic.mime_type
         end
 
-        should "have picture bytes" do
-          assert_equal 61649, @apic.picture.size
+        should 'have picture bytes' do
+          assert_equal 61_649, @apic.picture.size
           assert_equal @picture_data, @apic.picture
         end
       end
@@ -95,14 +96,13 @@ class WAVFileTest < Test::Unit::TestCase
     end
   end
 
-  context "TagLib::RIFF::WAV::File.open" do
-    should "have open method" do
+  context 'TagLib::RIFF::WAV::File.open' do
+    should 'have open method' do
       title = nil
       TagLib::RIFF::WAV::File.open(SAMPLE_FILE, false) do |file|
         title = file.tag.title
       end
-      assert_equal "WAV Dummy Track Title", title
+      assert_equal 'WAV Dummy Track Title', title
     end
   end
-
 end

data/test/wav_file_write_test.rb

@@ -1,27 +1,26 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class WAVFileWriteTest < Test::Unit::TestCase
+  SAMPLE_FILE = 'test/data/wav-sample.wav'
+  OUTPUT_FILE = 'test/data/_output.wav'
+  PICTURE_FILE = 'test/data/globe_east_90.jpg'
 
-  SAMPLE_FILE = "test/data/wav-sample.wav"
-  OUTPUT_FILE = "test/data/_output.wav"
-  PICTURE_FILE = "test/data/globe_east_90.jpg"
-
-  def reloaded
-    TagLib::RIFF::WAV::File.open(OUTPUT_FILE, false) do |file|
-      yield file
-    end
+  def reloaded(&block)
+    TagLib::RIFF::WAV::File.open(OUTPUT_FILE, false, &block)
   end
 
-  context "TagLib::RIFF::WAV::File" do
+  context 'TagLib::RIFF::WAV::File' do
     setup do
       FileUtils.cp SAMPLE_FILE, OUTPUT_FILE
       @file = TagLib::RIFF::WAV::File.new(OUTPUT_FILE, false)
     end
 
-    should "be able to save the title" do
+    should 'be able to save the title' do
       tag = @file.tag
       assert_not_nil tag
-      tag.title = "New Title"
+      tag.title = 'New Title'
       success = @file.save
       assert success
       @file.close
@@ -30,14 +29,14 @@ class WAVFileWriteTest < Test::Unit::TestCase
       written_title = reloaded do |file|
         file.tag.title
       end
-      assert_equal "New Title", written_title
+      assert_equal 'New Title', written_title
     end
 
-    should "have one picture frame" do
+    should 'have one picture frame' do
       assert_equal 2, @file.tag.frame_list('APIC').size
     end
 
-    should "be able to remove all picture frames" do
+    should 'be able to remove all picture frames' do
       @file.tag.remove_frames('APIC')
       success = @file.save
       assert success
@@ -49,12 +48,12 @@ class WAVFileWriteTest < Test::Unit::TestCase
       end
     end
 
-    should "be able to add a picture frame" do
+    should 'be able to add a picture frame' do
       picture_data = File.open(PICTURE_FILE, 'rb') { |f| f.read }
 
       apic = TagLib::ID3v2::AttachedPictureFrame.new
-      apic.mime_type = "image/jpeg"
-      apic.description = "desc"
+      apic.mime_type = 'image/jpeg'
+      apic.description = 'desc'
       apic.text_encoding = TagLib::String::UTF8
       apic.picture = picture_data
       apic.type = TagLib::ID3v2::AttachedPictureFrame::BackCover
@@ -70,9 +69,9 @@ class WAVFileWriteTest < Test::Unit::TestCase
       end
 
       reloaded do |file|
-        written_apic = file.tag.frame_list("APIC")[2]
-        assert_equal "image/jpeg", written_apic.mime_type
-        assert_equal "desc", written_apic.description
+        written_apic = file.tag.frame_list('APIC')[2]
+        assert_equal 'image/jpeg', written_apic.mime_type
+        assert_equal 'desc', written_apic.description
         assert_equal picture_data, written_apic.picture
       end
     end
@@ -86,18 +85,18 @@ class WAVFileWriteTest < Test::Unit::TestCase
     end
   end
 
-  context "TagLib::RIFF::WAV::File.strip" do
+  context 'TagLib::RIFF::WAV::File.strip' do
     setup do
       FileUtils.cp SAMPLE_FILE, OUTPUT_FILE
       @file = TagLib::RIFF::WAV::File.new(OUTPUT_FILE)
     end
 
-    should "update the file immediately" do
+    should 'update the file immediately' do
       assert @file.id3v2_tag?
 
       @file.strip(TagLib::RIFF::WAV::File::ID3v2)
 
-      reloaded do |file|
+      reloaded do |_file|
         refute @file.id3v2_tag?
       end
     end