taglib-ruby 1.1.0 → 1.1.1

data/test/mp4_file_test.rb

@@ -1,62 +1,64 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class MP4FileTest < Test::Unit::TestCase
-  context "TagLib::MP4::File" do
+  context 'TagLib::MP4::File' do
     setup do
-      @file = TagLib::MP4::File.new("test/data/mp4.m4a")
+      @file = TagLib::MP4::File.new('test/data/mp4.m4a')
       @tag = @file.tag
     end
 
-    should "have an MP4 tag" do
+    should 'have an MP4 tag' do
       assert @file.mp4_tag?
       refute_nil @tag
     end
 
-    should "contain basic tag information" do
-      assert_equal "Title", @tag.title
-      assert_equal "Artist", @tag.artist
-      assert_equal "Album", @tag.album
-      assert_equal "Comment", @tag.comment
-      assert_equal "Pop", @tag.genre
+    should 'contain basic tag information' do
+      assert_equal 'Title', @tag.title
+      assert_equal 'Artist', @tag.artist
+      assert_equal 'Album', @tag.album
+      assert_equal 'Comment', @tag.comment
+      assert_equal 'Pop', @tag.genre
       assert_equal 2011, @tag.year
       assert_equal 7, @tag.track
 
       assert_equal false, @tag.empty?
     end
 
-    should "support testing for the presence of items" do
-      refute @tag.contains "unknown"
-      assert @tag.contains "trkn"
+    should 'support testing for the presence of items' do
+      refute @tag.contains 'unknown'
+      assert @tag.contains 'trkn'
     end
 
-    should "support accessing items" do
-      refute @tag["unkn"].valid?
+    should 'support accessing items' do
+      refute @tag['unkn'].valid?
 
-      assert @tag["trkn"].valid?
+      assert @tag['trkn'].valid?
       assert_equal 7, @tag.track
     end
 
-    should "support editing items" do
-      @tag["trkn"] = TagLib::MP4::Item.from_int(1)
+    should 'support editing items' do
+      @tag['trkn'] = TagLib::MP4::Item.from_int(1)
       assert_equal 1, @tag.track
     end
 
-    should "support removing items" do
-      assert @tag.contains "trkn"
-      @tag.remove_item("trkn")
-      refute @tag.contains "trkn"
+    should 'support removing items' do
+      assert @tag.contains 'trkn'
+      @tag.remove_item('trkn')
+      refute @tag.contains 'trkn'
     end
 
-    context "audio properties" do
+    context 'audio properties' do
       setup do
         @properties = @file.audio_properties
       end
 
-      should "exist" do
+      should 'exist' do
         assert_not_nil @properties
       end
 
-      should "contain basic information" do
+      should 'contain basic information' do
         assert_equal 1, @properties.length_in_seconds
         assert_equal 55, @properties.bitrate
         assert_equal 44100, @properties.sample_rate
@@ -64,7 +66,7 @@ class MP4FileTest < Test::Unit::TestCase
         assert_equal 2, @properties.channels
       end
 
-      should "contain mp4-specific information" do
+      should 'contain mp4-specific information' do
         assert_equal 16, @properties.bits_per_sample
         assert_equal false, @properties.encrypted?
         assert_equal TagLib::MP4::Properties::AAC, @properties.codec
@@ -76,5 +78,4 @@ class MP4FileTest < Test::Unit::TestCase
       @file = nil
     end
   end
-
 end

data/test/mp4_file_write_test.rb

@@ -1,27 +1,26 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class MP4FileWriteTest < Test::Unit::TestCase
+  SAMPLE_FILE = 'test/data/mp4.m4a'
+  OUTPUT_FILE = 'test/data/output.m4a'
+  PICTURE_FILE = 'test/data/globe_east_540.jpg'
 
-  SAMPLE_FILE = "test/data/mp4.m4a"
-  OUTPUT_FILE = "test/data/output.m4a"
-  PICTURE_FILE = "test/data/globe_east_540.jpg"
-
-  def reloaded
-    TagLib::MP4::File.open(OUTPUT_FILE, false) do |file|
-      yield file
-    end
+  def reloaded(&block)
+    TagLib::MP4::File.open(OUTPUT_FILE, false, &block)
   end
 
-  context "TagLib::MP4::File" do
+  context 'TagLib::MP4::File' do
     setup do
       FileUtils.cp SAMPLE_FILE, OUTPUT_FILE
       @file = TagLib::MP4::File.new(OUTPUT_FILE, false)
     end
 
-    should "be able to save the title" do
+    should 'be able to save the title' do
       tag = @file.tag
       assert_not_nil tag
-      tag.title = "New Title"
+      tag.title = 'New Title'
       success = @file.save
       assert success
       @file.close
@@ -30,10 +29,10 @@ class MP4FileWriteTest < Test::Unit::TestCase
       written_title = reloaded do |file|
         file.tag.title
       end
-      assert_equal "New Title", written_title
+      assert_equal 'New Title', written_title
     end
 
-    should "be able to add and save new cover art" do
+    should 'be able to add and save new cover art' do
       item_map = @file.tag.item_map
       cover_art_list = item_map['covr'].to_cover_art_list
       assert_equal 1, cover_art_list.size

data/test/mp4_items_test.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 require 'set'
 
@@ -7,55 +8,55 @@ class MP4ItemsTest < Test::Unit::TestCase
 
   context "The mp4.m4a file's items" do
     setup do
-      @file = TagLib::MP4::File.new("test/data/mp4.m4a")
+      @file = TagLib::MP4::File.new('test/data/mp4.m4a')
       @tag = @file.tag
       @item_map = @file.tag.item_map
       @item_keys = [
-        "covr", "#{ITUNES_LEADER}nam", "#{ITUNES_LEADER}ART", "#{ITUNES_LEADER}alb",
+        'covr', "#{ITUNES_LEADER}nam", "#{ITUNES_LEADER}ART", "#{ITUNES_LEADER}alb",
         "#{ITUNES_LEADER}cmt", "#{ITUNES_LEADER}gen", "#{ITUNES_LEADER}day",
-        "trkn", "#{ITUNES_LEADER}too", "#{ITUNES_LEADER}cpy"
+        'trkn', "#{ITUNES_LEADER}too", "#{ITUNES_LEADER}cpy"
       ]
     end
 
-    context "item_map" do
-      should "exist" do
+    context 'item_map' do
+      should 'exist' do
         assert_not_nil @item_map
       end
 
-      should "not be empty" do
+      should 'not be empty' do
         assert_equal false, @item_map.empty?
       end
 
-      should "contain 10 items" do
+      should 'contain 10 items' do
         assert_equal @item_keys.count, @item_map.size
       end
 
-      should "have keys" do
-        assert_equal true, @item_map.contains("trkn")
+      should 'have keys' do
+        assert_equal true, @item_map.contains('trkn')
         assert_equal true, @item_map.has_key?("#{ITUNES_LEADER}too")
         assert_equal true, @item_map.include?("#{ITUNES_LEADER}cpy")
-        assert_equal false, @item_map.include?("none such key")
+        assert_equal false, @item_map.include?('none such key')
       end
 
-      should "look up keys" do
-        assert_nil @item_map["none such key"]
-        assert_equal ["Title"], @item_map["#{ITUNES_LEADER}nam"].to_string_list
+      should 'look up keys' do
+        assert_nil @item_map['none such key']
+        assert_equal ['Title'], @item_map["#{ITUNES_LEADER}nam"].to_string_list
       end
 
-      should "be clearable" do
+      should 'be clearable' do
         assert_equal 10, @item_map.size
         comment = @item_map["#{ITUNES_LEADER}cmt"]
         @item_map.clear
         assert_equal true, @item_map.empty?
         begin
           comment.to_string_list
-          flunk("Should have raised ObjectPreviouslyDeleted.")
-        rescue => e
-          assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+          flunk('Should have raised ObjectPreviouslyDeleted.')
+        rescue StandardError => e
+          assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
         end
       end
 
-      should "be convertible to an array" do
+      should 'be convertible to an array' do
         array = @item_map.to_a
         assert_equal 10, array.count
         array.each do |object|
@@ -67,150 +68,149 @@ class MP4ItemsTest < Test::Unit::TestCase
         end
       end
 
-      should "be convertible to a hash" do
+      should 'be convertible to a hash' do
         hsh = @item_map.to_h
         assert_equal Set.new(hsh.keys), Set.new(@item_keys)
       end
     end
 
-    should "be removable" do
+    should 'be removable' do
       assert_equal 10, @item_map.size
       title = @item_map["#{ITUNES_LEADER}nam"]
       @item_map.erase("#{ITUNES_LEADER}nam")
       assert_equal 9, @item_map.size
       begin
         title.to_string_list
-        flunk("Should have raised ObjectPreviouslyDeleted.")
-      rescue => e
-        assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+        flunk('Should have raised ObjectPreviouslyDeleted.')
+      rescue StandardError => e
+        assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
       end
     end
 
-    should "reflect edition of items from the tag" do
-      assert @tag.contains "trkn"
-      track = @item_map["trkn"]
+    should 'reflect edition of items from the tag' do
+      assert @tag.contains 'trkn'
+      track = @item_map['trkn']
 
-      @tag["trkn"] = TagLib::MP4::Item.from_int(1)
+      @tag['trkn'] = TagLib::MP4::Item.from_int(1)
 
       begin
         track.to_int_pair[0]
-        flunk("Should have raised ObjectPreviouslyDeleted.")
-      rescue => e
-        assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+        flunk('Should have raised ObjectPreviouslyDeleted.')
+      rescue StandardError => e
+        assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
       end
     end
 
-    should "reflect removal of items from the tag" do
-      assert @tag.contains "trkn"
-      track = @item_map["trkn"]
+    should 'reflect removal of items from the tag' do
+      assert @tag.contains 'trkn'
+      track = @item_map['trkn']
 
-      @tag.remove_item("trkn")
-      refute @item_map.contains "trkn"
+      @tag.remove_item('trkn')
+      refute @item_map.contains 'trkn'
 
       begin
         track.to_int_pair[0]
-        flunk("Should have raised ObjectPreviouslyDeleted.")
-      rescue => e
-        assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+        flunk('Should have raised ObjectPreviouslyDeleted.')
+      rescue StandardError => e
+        assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
       end
     end
 
-    context "inserting items" do
-      should "insert a new item" do
+    context 'inserting items' do
+      should 'insert a new item' do
         new_title = TagLib::MP4::Item.from_string_list(['new title'])
         @item_map.insert("#{ITUNES_LEADER}nam", new_title)
-        new_title = nil
         GC.start
         assert_equal ['new title'], @item_map["#{ITUNES_LEADER}nam"].to_string_list
       end
 
-      should "unlink items that get replaced" do
+      should 'unlink items that get replaced' do
         title = @item_map["#{ITUNES_LEADER}nam"]
         @item_map.insert("#{ITUNES_LEADER}nam", TagLib::MP4::Item.from_int(1))
         begin
           title.to_string_list
-          flunk("Should have raised ObjectPreviouslyDeleted.")
-        rescue => e
-          assert_equal "ObjectPreviouslyDeleted", e.class.to_s
+          flunk('Should have raised ObjectPreviouslyDeleted.')
+        rescue StandardError => e
+          assert_equal 'ObjectPreviouslyDeleted', e.class.to_s
         end
       end
     end
 
-    context "TagLib::MP4::Item" do
-      should "be creatable from a boolean" do
+    context 'TagLib::MP4::Item' do
+      should 'be creatable from a boolean' do
         item = TagLib::MP4::Item.from_bool(false)
         assert_equal TagLib::MP4::Item, item.class
         assert_equal false, item.to_bool
       end
 
-      should "be creatable from a byte" do
+      should 'be creatable from a byte' do
         item = TagLib::MP4::Item.from_byte(123)
         assert_equal TagLib::MP4::Item, item.class
         assert_equal 123, item.to_byte
       end
 
-      should "be creatable from an unsigned int" do
-        item = TagLib::MP4::Item.from_int(12346)
+      should 'be creatable from an unsigned int' do
+        item = TagLib::MP4::Item.from_int(12_346)
         assert_equal TagLib::MP4::Item, item.class
-        assert_equal 12346, item.to_uint
+        assert_equal 12_346, item.to_uint
       end
 
-      should "be creatable from an int" do
+      should 'be creatable from an int' do
         item = TagLib::MP4::Item.from_int(-42)
         assert_equal TagLib::MP4::Item, item.class
-        assert_equal -42, item.to_int
+        assert_equal(-42, item.to_int)
       end
 
-      should "be creatable from a long long" do
-        item = TagLib::MP4::Item.from_long_long(1234567890)
+      should 'be creatable from a long long' do
+        item = TagLib::MP4::Item.from_long_long(1_234_567_890)
         assert_equal TagLib::MP4::Item, item.class
-        assert_equal 1234567890, item.to_long_long
+        assert_equal 1_234_567_890, item.to_long_long
       end
 
-      context ".from_int_pair" do
-        should "be creatable from a pair of ints" do
+      context '.from_int_pair' do
+        should 'be creatable from a pair of ints' do
           item = TagLib::MP4::Item.from_int_pair([123, 456])
           assert_equal TagLib::MP4::Item, item.class
           assert_equal [123, 456], item.to_int_pair
         end
 
-        should "raise an error when passed something other than an Array" do
+        should 'raise an error when passed something other than an Array' do
           begin
             TagLib::MP4::Item.from_int_pair(1)
-            flunk("Should have raised ArgumentError.")
-          rescue => e
-            assert_equal "ArgumentError", e.class.to_s
+            flunk('Should have raised ArgumentError.')
+          rescue StandardError => e
+            assert_equal 'ArgumentError', e.class.to_s
           end
         end
 
-        should "raise an error when passed an Array with more than two elements" do
+        should 'raise an error when passed an Array with more than two elements' do
           begin
             TagLib::MP4::Item.from_int_pair([1, 2, 3])
-            flunk("Should have raised ArgumentError.")
-          rescue => e
-            assert_equal "ArgumentError", e.class.to_s
+            flunk('Should have raised ArgumentError.')
+          rescue StandardError => e
+            assert_equal 'ArgumentError', e.class.to_s
           end
         end
 
-        should "raise an error when passed an Array with less than two elements" do
+        should 'raise an error when passed an Array with less than two elements' do
           begin
             TagLib::MP4::Item.from_int_pair([1])
-            flunk("Should have raised ArgumentError.")
-          rescue => e
-            assert_equal "ArgumentError", e.class.to_s
+            flunk('Should have raised ArgumentError.')
+          rescue StandardError => e
+            assert_equal 'ArgumentError', e.class.to_s
           end
         end
       end
 
-      context "created from an array of strings" do
-        should "interpreted as strings with an encoding" do
-          item = TagLib::MP4::Item.from_string_list(["héllo"])
+      context 'created from an array of strings' do
+        should 'interpreted as strings with an encoding' do
+          item = TagLib::MP4::Item.from_string_list(['héllo'])
           assert_equal TagLib::MP4::Item, item.class
-          assert_equal ["héllo"], item.to_string_list
+          assert_equal ['héllo'], item.to_string_list
         end
       end
 
-      should "be creatable from a CoverArt list" do
+      should 'be creatable from a CoverArt list' do
         cover_art = TagLib::MP4::CoverArt.new(TagLib::MP4::CoverArt::JPEG, 'foo')
         item = TagLib::MP4::Item.from_cover_art_list([cover_art])
         assert_equal TagLib::MP4::Item, item.class
@@ -220,8 +220,8 @@ class MP4ItemsTest < Test::Unit::TestCase
       end
     end
 
-    context "TagLib::MP4::CoverArt" do
-      should "be creatable from a string" do
+    context 'TagLib::MP4::CoverArt' do
+      should 'be creatable from a string' do
         cover_art = TagLib::MP4::CoverArt.new(TagLib::MP4::CoverArt::JPEG, 'foo')
         assert_equal TagLib::MP4::CoverArt::JPEG, cover_art.format
         assert_equal 'foo', cover_art.data
@@ -233,5 +233,4 @@ class MP4ItemsTest < Test::Unit::TestCase
       @file = nil
     end
   end
-
 end

data/test/mpeg_file_test.rb

@@ -1,29 +1,31 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class TestMPEGFile < Test::Unit::TestCase
-  context "The crash.mp3 file" do
+  context 'The crash.mp3 file' do
     setup do
       read_properties = true
-      @file = TagLib::MPEG::File.new("test/data/crash.mp3", read_properties)
+      @file = TagLib::MPEG::File.new('test/data/crash.mp3', read_properties)
     end
 
-    should "have a basic tag" do
+    should 'have a basic tag' do
       tag = @file.tag
       assert_not_nil tag
       assert_equal TagLib::Tag, tag.class
       assert tag.empty?
     end
 
-    context "audio properties" do
+    context 'audio properties' do
       setup do
         @properties = @file.audio_properties
       end
 
-      should "be MPEG audio properties" do
+      should 'be MPEG audio properties' do
         assert_equal TagLib::MPEG::Properties, @properties.class
       end
 
-      should "contain information" do
+      should 'contain information' do
         assert_equal 2, @properties.length_in_seconds
         assert_equal 2299, @properties.length_in_milliseconds
         assert_equal 157, @properties.bitrate
@@ -37,25 +39,25 @@ class TestMPEGFile < Test::Unit::TestCase
         assert_equal true, @properties.original?
       end
 
-      context "Xing header" do
+      context 'Xing header' do
         setup do
           @xing_header = @properties.xing_header
         end
 
-        should "exist" do
+        should 'exist' do
           assert_not_nil @xing_header
         end
 
-        should "contain information" do
+        should 'contain information' do
           assert @xing_header.valid?
           assert_equal 88, @xing_header.total_frames
-          assert_equal 45140, @xing_header.total_size
+          assert_equal 45_140, @xing_header.total_size
           assert_equal TagLib::MPEG::XingHeader::Xing, @xing_header.type
         end
       end
     end
 
-    should "have no tag" do
+    should 'have no tag' do
       refute @file.id3v1_tag?
       refute @file.id3v2_tag?
       refute @file.ape_tag?
@@ -67,29 +69,29 @@ class TestMPEGFile < Test::Unit::TestCase
     end
   end
 
-  context "The id3v1.mp3 file" do
+  context 'The id3v1.mp3 file' do
     setup do
       read_properties = true
-      @file = TagLib::MPEG::File.new("test/data/id3v1.mp3", read_properties)
+      @file = TagLib::MPEG::File.new('test/data/id3v1.mp3', read_properties)
     end
 
-    should "have a basic tag" do
+    should 'have a basic tag' do
       tag = @file.tag
       assert_not_nil tag
       assert_equal TagLib::Tag, tag.class
       refute tag.empty?
     end
 
-    context "audio properties" do
+    context 'audio properties' do
       setup do
         @properties = @file.audio_properties
       end
 
-      should "be MPEG audio properties" do
+      should 'be MPEG audio properties' do
         assert_equal TagLib::MPEG::Properties, @properties.class
       end
 
-      should "contain information" do
+      should 'contain information' do
         assert_equal 0, @properties.length_in_seconds
         assert_equal 261, @properties.length_in_milliseconds
         assert_equal 141, @properties.bitrate
@@ -103,16 +105,16 @@ class TestMPEGFile < Test::Unit::TestCase
         assert_equal true, @properties.original?
       end
 
-      context "Xing header" do
+      context 'Xing header' do
         setup do
           @xing_header = @properties.xing_header
         end
 
-        should "exist" do
+        should 'exist' do
           assert_not_nil @xing_header
         end
 
-        should "contain information" do
+        should 'contain information' do
           assert @xing_header.valid?
           assert_equal 10, @xing_header.total_frames
           assert_equal 4596, @xing_header.total_size
@@ -121,17 +123,17 @@ class TestMPEGFile < Test::Unit::TestCase
       end
     end
 
-    context "tag" do
+    context 'tag' do
       setup do
         @tag = @file.tag
       end
 
-      should "exist" do
+      should 'exist' do
         refute_nil @tag
         assert_equal TagLib::Tag, @tag.class
       end
 
-      should "have basic properties" do
+      should 'have basic properties' do
         refute @tag.empty?
 
         assert_equal 'Title', @tag.title
@@ -144,12 +146,12 @@ class TestMPEGFile < Test::Unit::TestCase
       end
     end
 
-    context "ID3V1 tag" do
+    context 'ID3V1 tag' do
       setup do
         @tag = @file.id3v1_tag(false)
       end
 
-      should "exist" do
+      should 'exist' do
         assert @file.id3v1_tag?
         refute @file.id3v2_tag?
         refute @file.ape_tag?
@@ -158,7 +160,7 @@ class TestMPEGFile < Test::Unit::TestCase
         assert_equal TagLib::ID3v1::Tag, @tag.class
       end
 
-      should "have basic properties" do
+      should 'have basic properties' do
         refute @tag.empty?
 
         assert_equal 'Title', @tag.title
@@ -177,13 +179,13 @@ class TestMPEGFile < Test::Unit::TestCase
     end
   end
 
-  context "TagLib::MPEG::File" do
-    should "have open method" do
+  context 'TagLib::MPEG::File' do
+    should 'have open method' do
       title = nil
-      TagLib::MPEG::File.open("test/data/sample.mp3", false) do |file|
+      TagLib::MPEG::File.open('test/data/sample.mp3', false) do |file|
         title = file.tag.title
       end
-      assert_equal "Dummy Title", title
+      assert_equal 'Dummy Title', title
     end
   end
 end

data/test/tag_test.rb

@@ -1,13 +1,15 @@
+# frozen-string-literal: true
+
 require File.join(File.dirname(__FILE__), 'helper')
 
 class TestTag < Test::Unit::TestCase
-  context "The sample.mp3 file" do
+  context 'The sample.mp3 file' do
     setup do
-      @fileref = TagLib::FileRef.new("test/data/sample.mp3", false)
+      @fileref = TagLib::FileRef.new('test/data/sample.mp3', false)
       @tag = @fileref.tag
     end
 
-    should "have basic tag information" do
+    should 'have basic tag information' do
       assert_equal 'Dummy Title', @tag.title
       assert_equal 'Dummy Artist', @tag.artist
       assert_equal 'Dummy Album', @tag.album