sufia 7.3.0.rc3 → 7.3.0

data/app/assets/javascripts/sufia/relationships/table_row.es6

@@ -1,79 +0,0 @@
-export class RelationshipsTableRow {
-  /**
-   * Inititializes a new table row class
-   * @param {jQuery} $table the table which this row is related to
-   */
-  constructor($table){
-    this.table = $table;
-    this.element = null;
-  }
-
-  /**
-   * The title element
-   * @returns {jQuery} the title element
-   */
-  get title() { return this.element.find("a.title:first"); }
-
-  /**
-   * The input field
-   * @returns {jQuery} the input field
-   */
-  get input() { return this.element.find("input.related_works_ids:first"); }
-
-  /**
-   * The "Add" button
-   * @returns {jQuery} the add button element
-   */
-  get addButton() { return this.element.find(".btn-add-row"); }
-
-  /**
-   * The "Remove" button
-   * @returns {jQuery} the remove button element
-   */
-  get removeButton() { return this.element.find(".btn-remove-row"); }
-
-  /**
-   * The "Edit" button
-   * @returns {jQuery} the edit button element
-   */
-  get editButton() { return this.element.find("a.edit:first"); }
-
-  /**
-   * Clone the row, set the element in this instance of the class, and reset the proper styles for this row. Insert
-   * this new row before the row passed in.. leaving the passed in row styled as-is, the caller of this method is responsible
-   * for properly handling adjustment to the passed in row
-   * @param {jQuery} $row the row to be cloned
-   */
-  clone($row){
-    this.element = $row.clone();
-    this.addButton.addClass("hidden");
-    this.removeButton.removeClass("hidden");
-    this.element.insertBefore($row);
-  }
-
-  /**
-   * Make an ajax call to the supplied url.
-   * After a row is cloned, this method could be called to refresh the row with more details (title, appropriate links, etc)
-   * based on the details returned from the server.
-   * @param {String} query_url the url to be called for querying details from the server
-   */
-  callAjaxQuery(query_url) {
-    let $this = this;
-    $.getJSON(query_url, function (data) {
-      // Set the cloned input to have the proper name and value for posting the
-      // form to the server, and hide it.
-      $this.input.removeClass("new-form-control")
-        .addClass("hidden")
-        .val(data.id);
-
-      // Set the linkified title and show.
-      $this.title.text(data.title[0])
-        .attr("href", query_url)
-        .removeClass("hidden");
-
-      // Set the edit button link and show.
-      $this.editButton.attr("href", query_url + "/edit")
-        .removeClass("hidden");
-    });
-  }
-}

data/app/views/curation_concerns/base/_form_parent_work_relationships.html.erb

@@ -1,43 +0,0 @@
-<div class="form-group multi_value optional managed">
-
-  <table class="table table-striped related-files relationships-ajax-enabled"
-         data-query-url="<%= polymorphic_path([main_app, :curation_concerns, curation_concern.model_name.singular], id: '$id') %>">
-    <thead>
-    <tr>
-      <th>Parent Work</th>
-      <th>Actions</th>
-    </tr>
-  </thead>
-    <tbody>
-
-    <% f.object.in_work_members.each do |member| %>
-        <tr>
-          <td>
-            <%= link_to member.title.first, [main_app, member] %>
-            <input class="string multi_value optional form-control related_works_ids form-control multi-text-field hidden" value="<%= member.id %>" id="work_in_works_ids" aria-labelledby="work_in_works_ids_label" name="<%= f.object.model_name.param_key %>[in_works_ids][]" type="text">
-          </td>
-          <td>
-            <div class="child-actions">
-              <%= link_to "Edit", [main_app, :edit, member], target: "_blank", class: 'btn btn-default' %>
-              <a class="btn btn-danger btn-remove-row">Remove</a>
-            </div>
-          </td>
-        </tr>
-    <% end %>
-    <tr class="new-row">
-      <td>
-        <a href="" class="title hidden"></a>
-        <%= render "find_work_widget", f: f, id_name: 'work_parent_members_ids', id_type: 'in_works_ids', user_email: current_user.email, id: f.object.model.id %>
-        <div class="message has-warning hidden"></div>
-      </td>
-      <td>
-        <div class="child-actions">
-          <a href="" class="edit hidden btn btn-default" target="_blank">Edit</a>
-          <a class="btn btn-danger btn-remove-row hidden">Remove</a>
-          <a class="btn btn-primary btn-add-row">Add</a>
-        </div>
-      </td>
-    </tr>
-    </tbody>
-  </table>
-</div>

data/app/views/records/edit_fields/_in_works_ids.html.erb

@@ -1,59 +0,0 @@
-<%# Form UI behavior code and details;
-Code:
-  app/assets/javascripts/sufia/relationships
-CSS:
-  table.relationships-ajax-enabled : Used by sufia JS app as selector to wire up the UI functionality
-  tr.new-row : The basic template row for cloning when user clicks "Add"
-  .btn-remove-row : Button to remove its parent TR from the table
-  .btn-add-row : Button to clone its parent TR and inject a new row into the table
-  input.new-form-control : Input field for client client side validation and additional features
-  .message.has-warning : Used to display UI errors related to input values and server errors
-HTML Properties:
-  table:
-    data-query-url : URL base to append newly added work ID to for querying details (title, href)
-%>
-<% if f.object.class.multiple? key %>
-  <div class="form-group multi_value optional work_in_works_ids managed">
-    <table class="table table-striped related-files relationships-ajax-enabled"
-           data-query-url="<%=polymorphic_path([main_app, :curation_concerns, curation_concern.model_name.singular], id: '$id') %>">
-      <thead>
-        <tr>
-          <th>Parent Work</th>
-          <th>Actions</th>
-        </tr>
-      </thead>
-      <tbody>
-        <% curation_concern.in_works.each do |parent| %>
-          <tr>
-            <td>
-              <%= link_to "#{parent.title.first}", polymorphic_path([main_app, :curation_concerns, curation_concern.model_name.singular], id: parent.id) %>
-              <input class="string multi_value optional form-control related_works_ids form-control multi-text-field hidden" name="<%= curation_concern.model_name.param_key %>[in_works_ids][]" value="<%= parent.id %>" id="work_in_works_ids" aria-labelledby="work_in_works_ids_label" type="text">
-            </td>
-            <td>
-              <div class="child-actions">
-                <%= link_to "Edit", edit_polymorphic_path([main_app, :curation_concerns, curation_concern.model_name.singular], id: parent.id), target: "_blank", class: 'btn btn-default' %>
-                <a class="btn btn-danger btn-remove-row">Remove</a>
-              </div>
-            </td>
-          </tr>
-        <% end %>
-        <tr class="new-row">
-          <td>
-            <a href="" class="title hidden"></a>
-            <input class="new-form-control string multi_value optional related_works_ids form-control multi-text-field" name="<%= curation_concern.model_name.param_key %>[in_works_ids][]" value="" aria-labelledby="work_in_works_ids_label" type="text">
-            <div class="message has-warning hidden"></div>
-          </td>
-          <td>
-            <div class="child-actions">
-              <a href="" class="edit hidden btn btn-default" target="_blank">Edit</a>
-              <a class="btn btn-danger btn-remove-row hidden">Remove</a>
-              <a class="btn btn-primary btn-add-row">Add</a>
-            </div>
-          </td>
-        </tr>
-      </tbody>
-    </table>
-  </div>
-<% else %>
-  <%= f.input key, required: f.object.required?(key) %>
-<% end %>

data/spec/javascripts/helpers/test_responses.js

@@ -1,13 +0,0 @@
-var TestResponses = {
-  relationships_table: {
-    query_url_success: {
-        id: "parent5678",
-        title: ["Parent"]
-    },
-    ajax_add_success:{},
-    ajax_remove_success:{},
-    ajax_error: {
-      responseText: "Error"
-    },
-  }
-}

data/spec/javascripts/relationships_table_spec.js.coffee

@@ -1,83 +0,0 @@
-describe 'RelationshipsTable', ->
-  control = require('sufia/relationships/table')
-  form = null
-  element = null
-  btn_remove = null
-  btn_add = null
-  btn_edit = null
-  input = null
-  message = null
-  test_fixtures = TestFixtures
-  test_responses = TestResponses
-  deferred_ajax = null
-
-  beforeEach ->
-    form = $(test_fixtures.relationships_table.html)
-    element = form.find("table")
-    btn_remove = element.find('.btn-remove-row')
-    btn_add = element.find('.btn-add-row')
-    btn_edit = element.find('.edit')
-    input = element.find('.new-form-control')
-    message = element.find('.message')
-    target = new control.RelationshipsTable(element)
-    jasmine.Ajax.install()
-    deferred_ajax = new jQuery.Deferred()
-    spyOn($,'ajax').and.returnValue(deferred_ajax)
-    spyOn($,'getJSON').and.callFake((url, success) ->
-      success(test_responses.relationships_table.query_url_success))
-
-  afterEach ->
-    jasmine.Ajax.uninstall()
-
-  describe 'when adding/removing a row', ->
-    # the new-row is properly rendered
-    it 'only displays one new row with an add button visible', ->
-      expect(btn_remove.hasClass("hidden")).toBeTruthy()
-      expect(btn_edit.hasClass("hidden")).toBeTruthy()
-      expect(btn_add.hasClass("hidden")).toBeFalsy()
-
-    it 'clicks add with a valid id', ->
-      input.val(test_fixtures.relationships_table.parent_id)
-      btn_add.click()
-      deferred_ajax.resolve(test_responses.relationships_table.ajax_add_success)
-      expect(message.hasClass("hidden")).toBeTruthy()
-      expect(element.find("tbody tr").length).toEqual(2)
-
-    it 'clicks add with an invalid id', ->
-      input.val('invalid')
-      btn_add.click()
-      deferred_ajax.reject(test_responses.relationships_table.ajax_error)
-      expect(message.hasClass("hidden")).toBeFalsy()
-      expect(element.find("tbody tr").length).toEqual(1)
-
-    it 'clicks add without an id', ->
-      expect(message.hasClass("hidden")).toBeTruthy()
-      btn_add.click()
-      expect(message.hasClass("hidden")).toBeFalsy()
-      expect(message.text()).toContain("ID cannot be empty")
-      expect(element.find("tbody tr").length).toEqual(1)
-
-    it 'clicks remove to remove a work', ->
-      input.val(test_fixtures.relationships_table.parent_id)
-      btn_add.click()
-      deferred_ajax.resolve(test_responses.relationships_table.ajax_add_success)
-      expect(element.find("tbody tr").length).toEqual(2)
-      parent_row = element.find("tbody tr:first")
-      parent_delete = parent_row.find(".btn-remove-row")
-      parent_delete.click()
-      deferred_ajax.resolve(test_responses.relationships_table.ajax_remove_success)
-      expect(element.find("tbody tr").length).toEqual(1)
-
-    it 'clicks add with a duplicate id', ->
-      input.val(test_fixtures.relationships_table.parent_id)
-      btn_add.click()
-      deferred_ajax.resolve(test_responses.relationships_table.ajax_add_success)
-      expect(element.find("tbody tr").length).toEqual(2)
-      input = element.find("tbody tr:nth-child(2) .new-form-control")
-      input.val(test_fixtures.relationships_table.parent_id)
-      btn_add = element.find("tbody tr:nth-child(2) .btn-add-row")
-      btn_add.click()
-      message = element.find("tbody tr:nth-child(2) .message")
-      expect(element.find("tbody tr").length).toEqual(2)
-      expect(message.hasClass("hidden")).toBeFalsy()
-      expect(message.text()).toContain("Work is already related")

data/spec/views/curation_concerns/base/_form_parent_work_relationships.html.erb_spec.rb

@@ -1,114 +0,0 @@
-require 'spec_helper'
-
-describe "curation_concerns/base/_form_parent_work_relationships.html.erb", type: :view do
-  let(:work) do
-    stub_model(GenericWork, id: '456', title: ["MyWork"])
-  end
-
-  let(:work_2) do
-    stub_model(GenericWork, id: '567', title: ["Parent Work"])
-  end
-
-  let(:ability) { double }
-
-  let(:form) do
-    Sufia::Forms::WorkForm.new(work, ability)
-  end
-
-  let(:f) { double }
-
-  let(:page) do
-    render
-    Capybara::Node::Simple.new(rendered)
-  end
-
-  before do
-    view.lookup_context.view_paths.push 'app/views/curation_concerns'
-    allow(view).to receive(:params).and_return(id: work.id)
-    allow(view).to receive(:curation_concern).and_return(work)
-    allow(view).to receive(:f).and_return(f)
-    allow(f).to receive(:object).and_return(form)
-    allow(controller).to receive(:current_user).and_return(stub_model(User))
-    stub_template '_find_work_widget.html.erb' => "<input value=''/>"
-    assign(:form, form)
-  end
-
-  context "When editing a work" do
-    context "and no parent works are present" do
-      before do
-        allow(work).to receive(:in_works).and_return([])
-      end
-      it "has 1 empty parent work input" do
-        expect(page).to have_selector("input[value='']", count: 1)
-      end
-
-      it "will not display the remove button in the actions" do
-        expect(page).to have_selector(".btn-remove-row", visible: false)
-      end
-
-      it "will display the add button in the actions" do
-        expect(page).to have_selector(".btn-add-row", visible: true, count: 1)
-      end
-    end
-    context "When 1 parent work is present" do
-      let(:work_2) do
-        stub_model(GenericWork, id: '567', title: ["Test Parent Work"])
-      end
-
-      before do
-        allow(work).to receive(:in_works).and_return([work_2])
-      end
-      it "has 1 empty parent work input with add button" do
-        expect(page).to have_selector("input[value='']", count: 1)
-        expect(page).to have_selector(".btn-add-row", visible: true, count: 1)
-      end
-
-      it "has an input box that is filled in with the parent id" do
-        expect(page).to have_selector("input[value='#{work_2.id}']", count: 1)
-      end
-
-      it "generates a link for the parents first title" do
-        expect(page).to have_link("Test Parent Work")
-      end
-
-      it "has an edit and remove button" do
-        within ".old-row" do
-          expect(page).to have_selector(".btn-remove-row", visible: true, count: 1)
-          expect(page).to have_selector(".btn-edit-row", visible: true, count: 1)
-        end
-      end
-    end
-    context "When multiple parent works are present" do
-      let(:work_2) do
-        stub_model(GenericWork, id: '567', title: ["Test Parent Work"])
-      end
-      let(:work_3) do
-        stub_model(GenericWork, id: '789', title: ["Test Parent Work 2"])
-      end
-      before do
-        allow(work).to receive(:in_works).and_return([work_2, work_3])
-      end
-      it "has 1 empty parent work input with add button" do
-        expect(page).to have_selector("input[value='']", count: 1)
-        expect(page).to have_selector(".btn-add-row", visible: true, count: 1)
-      end
-
-      it "has an input box that is filled in with the parent ids" do
-        expect(page).to have_selector("input[value='#{work_2.id}']", count: 1)
-        expect(page).to have_selector("input[value='#{work_3.id}']", count: 1)
-      end
-
-      it "generates a link for the parents first title" do
-        expect(page).to have_link("Test Parent Work")
-        expect(page).to have_link("Test Parent Work 2")
-      end
-
-      it "has an edit and remove button" do
-        within ".old-row" do
-          expect(page).to have_selector(".btn-remove-row", visible: true, count: 2)
-          expect(page).to have_selector(".btn-edit-row", visible: true, count: 2)
-        end
-      end
-    end
-  end
-end

data/spec/views/records/edit_fields/_in_works_ids.html.erb_spec.rb

@@ -1,113 +0,0 @@
-require 'spec_helper'
-
-describe "records/edit_fields/_in_works_ids.html.erb", type: :view do
-  let(:work) do
-    stub_model(GenericWork, id: '456', title: ["MyWork"])
-  end
-
-  let(:work_2) do
-    stub_model(GenericWork, id: '567', title: ["Child Work"])
-  end
-
-  let(:ability) { double }
-
-  let(:form) do
-    CurationConcerns::GenericWorkForm.new(work, ability)
-  end
-
-  let(:f) { double(object: form) }
-
-  let(:page) do
-    render
-    Capybara::Node::Simple.new(rendered)
-  end
-
-  before do
-    view.lookup_context.view_paths.push 'app/views/curation_concerns'
-    allow(::ActiveFedora::Base).to receive(:find).and_return(work_2)
-    allow(view).to receive(:curation_concern).and_return(work)
-    allow(view).to receive(:f).and_return(f)
-    allow(view).to receive(:key).and_return(:in_works_ids)
-    allow(controller).to receive(:current_user).and_return(stub_model(User))
-    assign(:form, form)
-  end
-
-  context "When editing a work" do
-    context "and no parents are present" do
-      before do
-        allow(work).to receive(:in_works).and_return([])
-      end
-      it "has 1 empty parent work input" do
-        expect(page).to have_selector("input[value='']", count: 1)
-      end
-
-      it "does not display the remove button in the actions" do
-        expect(page).to have_selector(".btn-remove-row", visible: false)
-      end
-
-      it "displays the add button in the actions" do
-        expect(page).to have_selector(".btn-add-row", visible: true, count: 1)
-      end
-    end
-    context "When 1 parent work is present" do
-      let(:work_2) do
-        stub_model(GenericWork, id: '567', title: ["Test Parent Work"])
-      end
-
-      before do
-        allow(work).to receive(:in_works).and_return([work_2])
-      end
-      it "has 1 empty parent work input with add button" do
-        expect(page).to have_selector("input[value='']", count: 1)
-        expect(page).to have_selector(".btn-add-row", visible: true, count: 1)
-      end
-
-      it "has an input box that is filled in with the parent id" do
-        expect(page).to have_selector("input[value='#{work_2.id}']", count: 1)
-      end
-
-      it "generates a link for the parents first title" do
-        expect(page).to have_link("Test Parent Work")
-      end
-
-      it "has an edit and remove button" do
-        within ".old-row" do
-          expect(page).to have_selector(".btn-remove-row", visible: true, count: 1)
-          expect(page).to have_selector(".btn-edit-row", visible: true, count: 1)
-        end
-      end
-    end
-    context "When multiple parent works are present" do
-      let(:work_2) do
-        stub_model(GenericWork, id: '567', title: ["Test Parent Work"])
-      end
-      let(:work_3) do
-        stub_model(GenericWork, id: '789', title: ["Test Parent Work 2"])
-      end
-      before do
-        allow(work).to receive(:in_works).and_return([work_2, work_3])
-      end
-      it "has 1 empty parent work input with add button" do
-        expect(page).to have_selector("input[value='']", count: 1)
-        expect(page).to have_selector(".btn-add-row", visible: true, count: 1)
-      end
-
-      it "has an input box that is filled in with the parent ids" do
-        expect(page).to have_selector("input[value='#{work_2.id}']", count: 1)
-        expect(page).to have_selector("input[value='#{work_3.id}']", count: 1)
-      end
-
-      it "generates a link for the parents first title" do
-        expect(page).to have_link("Test Parent Work")
-        expect(page).to have_link("Test Parent Work 2")
-      end
-
-      it "has an edit and remove button" do
-        within ".old-row" do
-          expect(page).to have_selector(".btn-remove-row", visible: true, count: 2)
-          expect(page).to have_selector(".btn-edit-row", visible: true, count: 2)
-        end
-      end
-    end
-  end
-end