sufia 7.3.0.rc3 → 7.3.0

data/spec/views/sufia/admin/admin_sets/_form_visibility.html.erb_spec.rb

@@ -2,11 +2,13 @@ require 'spec_helper'
 
 RSpec.describe 'sufia/admin/admin_sets/_form_visibility.html.erb', type: :view do
   let(:admin_set) { create(:admin_set) }
-  let(:permission_template) { Sufia::PermissionTemplate.find_or_create_by(admin_set_id: admin_set.id) }
+  let(:permission_template) { create(:permission_template, admin_set_id: admin_set.id) }
+
   before do
     @form = Sufia::Forms::AdminSetForm.new(admin_set, permission_template)
     render
   end
+
   it "has the release form" do
     expect(rendered).to have_selector('#visibility input[type=radio][name="sufia_permission_template[release_period]"][value=now]')
     expect(rendered).to have_selector('#visibility input[type=radio][name="sufia_permission_template[release_period]"][value=fixed]')

data/spec/views/sufia/admin/admin_sets/show.html.erb_spec.rb

@@ -0,0 +1,59 @@
+describe "sufia/admin/admin_sets/show.html.erb", type: :view do
+  let(:solr_document) { SolrDocument.new(admin_set.to_solr) }
+  let(:ability) { double }
+  let(:presenter) { Sufia::AdminSetPresenter.new(solr_document, ability) }
+  let(:blacklight_config) { CatalogController.blacklight_config }
+  let(:blacklight_configuration_context) do
+    Blacklight::Configuration::Context.new(controller)
+  end
+  before do
+    allow(view).to receive(:blacklight_config).and_return(blacklight_config)
+    allow(view).to receive(:blacklight_configuration_context).and_return(blacklight_configuration_context)
+
+    # Stub route because view specs don't handle engine routes
+    allow(view).to receive(:edit_admin_admin_set_path).and_return("/admin/admin_sets/123/edit")
+    allow(view).to receive(:admin_admin_set_path).and_return("/admin/admin_sets/123")
+
+    stub_template '_collection_description.html.erb' => ''
+    stub_template '_show_descriptions.erb' => ''
+    stub_template '_sort_and_per_page.html.erb' => 'sort and per page'
+    stub_template '_document_list.html.erb' => 'document list'
+    stub_template '_paginate.html.erb' => 'paginate'
+
+    assign(:presenter, presenter)
+  end
+
+  context "with non-empty admin set" do
+    let(:admin_set) { build(:admin_set, id: '123') }
+    let(:work) { build(:work, title: ['Example Work Title']) }
+    before do
+      admin_set.members = [work]
+      admin_set.save!
+      render
+    end
+    it "displays a disabled delete button" do
+      expect(rendered).to have_selector(:css, "a.btn-danger.disabled")
+    end
+  end
+
+  context "with empty admin set" do
+    let(:admin_set) { build(:admin_set, id: '345') }
+    before do
+      render
+    end
+    it "displays an enabled delete button" do
+      expect(rendered).to have_selector(:css, "a.btn-danger")
+      expect(rendered).not_to have_selector(:css, "a.btn-danger.disabled")
+    end
+  end
+
+  context "with default admin set" do
+    let(:admin_set) { build(:admin_set, id: AdminSet::DEFAULT_ID) }
+    before do
+      render
+    end
+    it "displays a disabled delete button" do
+      expect(rendered).to have_selector(:css, "a.btn-danger.disabled")
+    end
+  end
+end

data/sufia.gemspec

@@ -19,11 +19,12 @@ Gem::Specification.new do |spec|
   spec.license       = 'Apache2'
 
   spec.add_dependency 'hydra-works', '~> 0.16'
-  spec.add_dependency 'curation_concerns', '~> 1.7.5'
+  spec.add_dependency 'curation_concerns', '~> 1.7.6'
   spec.add_dependency 'hydra-head', '>= 10.4.0'
   spec.add_dependency 'hydra-batch-edit', '~> 2.0'
   spec.add_dependency 'browse-everything', '>= 0.10.3'
-  spec.add_dependency 'blacklight', '~> 6.6'
+  # Workaround for https://github.com/projecthydra-labs/hyrax/issues/546
+  spec.add_dependency 'blacklight', '~> 6.6', '< 6.8.0'
   spec.add_dependency 'blacklight-gallery', '~> 0.7'
   spec.add_dependency 'tinymce-rails', '~> 4.1'
   spec.add_dependency 'tinymce-rails-imageupload', '~> 4.0.16.beta'

data/template.rb

@@ -1,4 +1,4 @@
-gem 'sufia', '7.3.0.rc3'
+gem 'sufia', '7.3.0'
 
 run 'bundle install'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sufia
 version: !ruby/object:Gem::Version
-  version: 7.3.0.rc3
+  version: 7.3.0
 platform: ruby
 authors:
 - Justin Coyne
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-02 00:00:00.000000000 Z
+date: 2017-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hydra-works
@@ -34,14 +34,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.5
+        version: 1.7.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.5
+        version: 1.7.6
 - !ruby/object:Gem::Dependency
   name: hydra-head
   requirement: !ruby/object:Gem::Requirement
@@ -91,6 +91,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 6.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -98,6 +101,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 6.8.0
 - !ruby/object:Gem::Dependency
   name: blacklight-gallery
   requirement: !ruby/object:Gem::Requirement
@@ -708,6 +714,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- app/actors/sufia/actors/attach_members_actor.rb
 - app/actors/sufia/apply_permission_template_actor.rb
 - app/actors/sufia/create_with_files_actor.rb
 - app/actors/sufia/create_with_remote_files_actor.rb
@@ -737,8 +744,10 @@ files:
 - app/assets/javascripts/sufia/batch_edit.js
 - app/assets/javascripts/sufia/batch_select_all.js
 - app/assets/javascripts/sufia/browse_everything.js
+- app/assets/javascripts/sufia/content_blocks.js
 - app/assets/javascripts/sufia/dashboard_actions.js
-- app/assets/javascripts/sufia/editor.js
+- app/assets/javascripts/sufia/editor.es6
+- app/assets/javascripts/sufia/editor/admin_set_widget.es6
 - app/assets/javascripts/sufia/facets.js
 - app/assets/javascripts/sufia/featured_researcher.js
 - app/assets/javascripts/sufia/featured_works.js
@@ -758,8 +767,10 @@ files:
 - app/assets/javascripts/sufia/permissions/user_controls.es6
 - app/assets/javascripts/sufia/proxy_rights.js
 - app/assets/javascripts/sufia/relationships.js
-- app/assets/javascripts/sufia/relationships/table.es6
-- app/assets/javascripts/sufia/relationships/table_row.es6
+- app/assets/javascripts/sufia/relationships/control.es6
+- app/assets/javascripts/sufia/relationships/registry.es6
+- app/assets/javascripts/sufia/relationships/registry_entry.es6
+- app/assets/javascripts/sufia/relationships/work.es6
 - app/assets/javascripts/sufia/save_work.es6
 - app/assets/javascripts/sufia/save_work/checklist_item.es6
 - app/assets/javascripts/sufia/save_work/deposit_agreement.es6
@@ -918,6 +929,7 @@ files:
 - app/mailers/sufia/contact_mailer.rb
 - app/models/batch_upload_item.rb
 - app/models/concerns/sufia/ability.rb
+- app/models/concerns/sufia/admin_set_behavior.rb
 - app/models/concerns/sufia/content_block_behavior.rb
 - app/models/concerns/sufia/file_set_behavior.rb
 - app/models/concerns/sufia/proxy_deposit.rb
@@ -956,6 +968,7 @@ files:
 - app/models/user_stat.rb
 - app/models/work_view_stat.rb
 - app/presenters/sufia/admin_dashboard_presenter.rb
+- app/presenters/sufia/admin_set_options_presenter.rb
 - app/presenters/sufia/admin_set_presenter.rb
 - app/presenters/sufia/admin_stats_presenter.rb
 - app/presenters/sufia/collection_presenter.rb
@@ -1086,7 +1099,6 @@ files:
 - app/views/curation_concerns/base/_form_child_work_relationships.html.erb
 - app/views/curation_concerns/base/_form_files.html.erb
 - app/views/curation_concerns/base/_form_metadata.html.erb
-- app/views/curation_concerns/base/_form_parent_work_relationships.html.erb
 - app/views/curation_concerns/base/_form_progress.html.erb
 - app/views/curation_concerns/base/_form_relationships.html.erb
 - app/views/curation_concerns/base/_form_share.html.erb
@@ -1179,7 +1191,6 @@ files:
 - app/views/records/edit_fields/_based_near.html.erb
 - app/views/records/edit_fields/_default.html.erb
 - app/views/records/edit_fields/_description.html.erb
-- app/views/records/edit_fields/_in_works_ids.html.erb
 - app/views/records/edit_fields/_language.html.erb
 - app/views/records/edit_fields/_resource_type.html.erb
 - app/views/records/edit_fields/_rights.html.erb
@@ -1282,6 +1293,7 @@ files:
 - app/views/users/show.html.erb
 - config/features.rb
 - config/initializers/curation_concern_events.rb
+- config/initializers/monkey_patch_admin_set.rb
 - config/locales/simple_form.en.yml
 - config/locales/sufia.en.yml
 - config/routes.rb
@@ -1313,6 +1325,7 @@ files:
 - db/migrate/20161021175854_create_permission_template.rb
 - db/migrate/20161021180154_create_permission_template_access.rb
 - db/migrate/20161116222307_add_release_to_permission_templates.rb
+- db/migrate/20170317141521_permission_template_change_column_workflow_name.rb
 - lib/generators/sufia/arkivo_api_generator.rb
 - lib/generators/sufia/assets_generator.rb
 - lib/generators/sufia/config_generator.rb
@@ -1373,6 +1386,7 @@ files:
 - solr/config/xslt/example_rss.xsl
 - solr/config/xslt/luke.xsl
 - spec/.gitignore
+- spec/actors/sufia/actors/attach_members_actor_spec.rb
 - spec/actors/sufia/apply_permission_template_actor_spec.rb
 - spec/actors/sufia/create_with_files_actor_spec.rb
 - spec/actors/sufia/create_with_remote_files_actor_spec.rb
@@ -1506,9 +1520,8 @@ files:
 - spec/javascripts/helpers/jasmine-ajax.js
 - spec/javascripts/helpers/jasmine-jquery.js
 - spec/javascripts/helpers/test_fixtures.js.coffee
-- spec/javascripts/helpers/test_responses.js
 - spec/javascripts/jasmine_spec.rb
-- spec/javascripts/relationships_table_spec.js.coffee
+- spec/javascripts/relationships_control_spec.js.coffee
 - spec/javascripts/required_field_spec.js
 - spec/javascripts/save_work_spec.js
 - spec/javascripts/support/jasmine.yml
@@ -1543,6 +1556,7 @@ files:
 - spec/lib/sufia/resource_sync/source_description_writer_spec.rb
 - spec/lib/sufia/zotero/config_spec.rb
 - spec/lib/sufia/zotero_spec.rb
+- spec/models/admin_set_spec.rb
 - spec/models/collection_spec.rb
 - spec/models/content_block_spec.rb
 - spec/models/featured_work_list_spec.rb
@@ -1564,6 +1578,7 @@ files:
 - spec/models/user_spec.rb
 - spec/models/work_view_stat_spec.rb
 - spec/presenters/sufia/admin_dashboard_presenter_spec.rb
+- spec/presenters/sufia/admin_set_options_presenter_spec.rb
 - spec/presenters/sufia/admin_set_presenter_spec.rb
 - spec/presenters/sufia/admin_stats_presenter_spec.rb
 - spec/presenters/sufia/collection_presenter_spec.rb
@@ -1653,7 +1668,6 @@ files:
 - spec/views/curation_concerns/base/_find_work_widget.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form_child_work_relationships.html.erb_spec.rb
-- spec/views/curation_concerns/base/_form_parent_work_relationships.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form_progress.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form_relationships.html.erb_spec.rb
 - spec/views/curation_concerns/base/_items.html.erb_spec.rb
@@ -1679,7 +1693,6 @@ files:
 - spec/views/my/facet.html.erb_spec.rb
 - spec/views/records/edit_fields/_based_near.html.erb_spec.rb
 - spec/views/records/edit_fields/_description.html.erb_spec.rb
-- spec/views/records/edit_fields/_in_works_ids.html.erb_spec.rb
 - spec/views/records/edit_fields/_language.html.erb_spec.rb
 - spec/views/records/edit_fields/_subject.html.erb_spec.rb
 - spec/views/shared/select_work_type_modal.html.erb_spec.rb
@@ -1688,6 +1701,7 @@ files:
 - spec/views/sufia/admin/admin_sets/_form_participants.html.erb_spec.rb
 - spec/views/sufia/admin/admin_sets/_form_visibility.html.erb_spec.rb
 - spec/views/sufia/admin/admin_sets/index.html.erb_spec.rb
+- spec/views/sufia/admin/admin_sets/show.html.erb_spec.rb
 - spec/views/sufia/admin/features/index.html.erb_spec.rb
 - spec/views/sufia/admin/stats/show.html.erb_spec.rb
 - spec/views/sufia/batch_uploads/_form.html.erb_spec.rb
@@ -1736,9 +1750,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.10
@@ -1748,6 +1762,7 @@ summary: Sufia was originally extracted from ScholarSphere developed by Penn Sta
   University. It's now used and maintained by an active community of adopters.
 test_files:
 - spec/.gitignore
+- spec/actors/sufia/actors/attach_members_actor_spec.rb
 - spec/actors/sufia/apply_permission_template_actor_spec.rb
 - spec/actors/sufia/create_with_files_actor_spec.rb
 - spec/actors/sufia/create_with_remote_files_actor_spec.rb
@@ -1881,9 +1896,8 @@ test_files:
 - spec/javascripts/helpers/jasmine-ajax.js
 - spec/javascripts/helpers/jasmine-jquery.js
 - spec/javascripts/helpers/test_fixtures.js.coffee
-- spec/javascripts/helpers/test_responses.js
 - spec/javascripts/jasmine_spec.rb
-- spec/javascripts/relationships_table_spec.js.coffee
+- spec/javascripts/relationships_control_spec.js.coffee
 - spec/javascripts/required_field_spec.js
 - spec/javascripts/save_work_spec.js
 - spec/javascripts/support/jasmine.yml
@@ -1918,6 +1932,7 @@ test_files:
 - spec/lib/sufia/resource_sync/source_description_writer_spec.rb
 - spec/lib/sufia/zotero/config_spec.rb
 - spec/lib/sufia/zotero_spec.rb
+- spec/models/admin_set_spec.rb
 - spec/models/collection_spec.rb
 - spec/models/content_block_spec.rb
 - spec/models/featured_work_list_spec.rb
@@ -1939,6 +1954,7 @@ test_files:
 - spec/models/user_spec.rb
 - spec/models/work_view_stat_spec.rb
 - spec/presenters/sufia/admin_dashboard_presenter_spec.rb
+- spec/presenters/sufia/admin_set_options_presenter_spec.rb
 - spec/presenters/sufia/admin_set_presenter_spec.rb
 - spec/presenters/sufia/admin_stats_presenter_spec.rb
 - spec/presenters/sufia/collection_presenter_spec.rb
@@ -2028,7 +2044,6 @@ test_files:
 - spec/views/curation_concerns/base/_find_work_widget.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form_child_work_relationships.html.erb_spec.rb
-- spec/views/curation_concerns/base/_form_parent_work_relationships.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form_progress.html.erb_spec.rb
 - spec/views/curation_concerns/base/_form_relationships.html.erb_spec.rb
 - spec/views/curation_concerns/base/_items.html.erb_spec.rb
@@ -2054,7 +2069,6 @@ test_files:
 - spec/views/my/facet.html.erb_spec.rb
 - spec/views/records/edit_fields/_based_near.html.erb_spec.rb
 - spec/views/records/edit_fields/_description.html.erb_spec.rb
-- spec/views/records/edit_fields/_in_works_ids.html.erb_spec.rb
 - spec/views/records/edit_fields/_language.html.erb_spec.rb
 - spec/views/records/edit_fields/_subject.html.erb_spec.rb
 - spec/views/shared/select_work_type_modal.html.erb_spec.rb
@@ -2063,6 +2077,7 @@ test_files:
 - spec/views/sufia/admin/admin_sets/_form_participants.html.erb_spec.rb
 - spec/views/sufia/admin/admin_sets/_form_visibility.html.erb_spec.rb
 - spec/views/sufia/admin/admin_sets/index.html.erb_spec.rb
+- spec/views/sufia/admin/admin_sets/show.html.erb_spec.rb
 - spec/views/sufia/admin/features/index.html.erb_spec.rb
 - spec/views/sufia/admin/stats/show.html.erb_spec.rb
 - spec/views/sufia/batch_uploads/_form.html.erb_spec.rb

data/app/assets/javascripts/sufia/relationships/table.es6

@@ -1,206 +0,0 @@
-import { RelationshipsTableRow } from './table_row'
-
-export class RelationshipsTable {
-
-  /**
-   * Initializes the class in the context of an individual table element
-   * @param {jQuery} element the table element that this class represents
-   */
-  constructor(element) {
-    this.$element = element;
-    this.form_action = this.$element.parents("form").attr("action");
-    this.query_url = this.$element.data('query-url');
-    this.existing_related_works_values = this.$element.find("input.related_works_ids:not(.new-form-control)").map(function(i, e){ return e.value; });
-
-    // TODO: Fall back to just cloning rows and removing rows for form posting
-    if (!this.query_url)
-      return;
-
-    this.bindAddButton();
-    this.bindRemoveButton();
-    this.bindKeyEvents();
-  }
-
-  /**
-   * Handle click events by the "Add" button in the table, setting a warning
-   * message if the input is empty or calling the server to handle the request
-   */
-  bindAddButton() {
-    let $this = this;
-
-    $this.$element.on("click", ".btn-add-row", function(event) {
-      let $row = $(this).parents("tr:first");
-      let $input = $row.find("input.new-form-control");
-
-      // Display an error when the input field is empty, or if the work ID is already related,
-      // otherwise clone the row and set appropriate styles
-      if ($input.val() == "") {
-        $this.setWarningMessage($row, "ID cannot be empty.");
-      } else if ($.inArray($input.val(), $this.existing_related_works_values) > -1) {
-        $this.setWarningMessage($row, "Work is already related.");
-      } else {
-
-        let query_url = $this.query_url.replace('$id', $input.val());
-        $this.hideWarningMessage($row);
-        $this.callAjax({
-          row: $row,
-          table: $this.$element,
-          input: $input,
-          url: $this.form_action,
-          query_url: query_url,
-          on_error: $this.handleError,
-          on_success: $this.handleAddRowSuccess
-        });
-      }
-    });
-  }
-
-  /**
-   * Find and fire off the click event for the "Add" button
-   * @param {jQuery} $row the row containing the add button to click
-   */
-  clickAddbutton($row) {
-    $row.find(".btn-add-row").click();
-  }
-
-  /**
-   * Handle click events by the "Remove" buttons in the table, and calling the
-   * server to handle the request
-   */
-  bindRemoveButton() {
-    let $this = this;
-
-    $this.$element.on("click", ".btn-remove-row", function(event) {
-      let $row = $(this).parents("tr:first");
-      let $input = $row.find("input.related_works_ids:first");
-
-      // Track which input is attemping to be removed, to provide an easy way
-      // for the ajax call to exclude it when making the call to the server
-      $input.addClass("removing");
-      $this.callAjax({
-        row: $row,
-        table: $this.$element,
-        input: $input,
-        url: $this.form_action,
-        on_error: $this.handleError,
-        on_success: $this.handleRemoveRowSuccess
-      });
-    });
-  }
-
-  /**
-   * Handle keyup and keypress events at the form level to prevent the ENTER key
-   * from submitting the form. ENTER key within a relationships table should
-   * click the "Add" button instead. ESC key should clear the input and hide the
-   * error message.
-   */
-  bindKeyEvents() {
-    let $this = this;
-    let $form = this.$element.parents("form");
-
-    $form.on("keyup keypress", "input.related_works_ids", function(event) {
-      let $row = $(this).parents("tr:first");
-      let key_code = event.keyCode || event.which;
-
-      // ENTER key was pressed, wait for keyup to click the Add button
-      if (key_code === 13) {
-        if (event.type == "keyup") {
-          $this.clickAddbutton($row);
-        }
-        event.preventDefault();
-        return false;
-      }
-
-      // ESC key was pressed, clear the input field and hide the error
-      if (key_code === 27 && event.type == "keyup") {
-        $(this).val("");
-        $this.hideWarningMessage($row);
-      }
-    });
-  }
-
-  /**
-   * Set the warning message related to the appropriate row in the table
-   * @param {jQuery} $row the row containing the warning message to display
-   * @param {String} message the warning message text to set
-   */
-  setWarningMessage($row, message) {
-    $row.find(".message.has-warning").text(message).removeClass("hidden");
-  }
-
-  /**
-   * Hide the warning message on the appropriate row
-   * @param {jQuery} $row the row containing the warning message to hide
-   */
-  hideWarningMessage($row){
-    $row.find(".message").addClass("hidden");
-  }
-
-  /**
-   * Call the server, then call the appropriate callbacks to handle success and errors
-   * @param {Object} args the table, row, input, url, and callbacks
-   */
-  callAjax(args) {
-    let $this = this;
-    // Send only the IDs in this table that aren't in the midst of being "removed"
-    let data = args.table.find("input.related_works_ids:not('.removing')").serialize();
-    $.ajax({
-        type: 'patch',
-        url: args.url,
-        dataType: 'json',
-        data: data
-      })
-      .done(function(json) {
-        args.on_success($this, args, json);
-      })
-      .fail(function(jqxhr, status, err) {
-        args.on_error($this, args, jqxhr, status, err);
-      });
-  }
-
-  /**
-   * Set a warning message to alert the user on an error
-   * @param {jQuery} $this the RelationshipsTable class instance
-   * @param {Object} args the table, row, input, url, and callbacks
-   * @param {Object} jqxhr the jQuery XHR response object
-   * @param {String} status the HTTP error status
-   * @param {String} err the HTTP error
-   */
-  handleError($this, args, jqxhr, status, err) {
-    args.row.find('input.removing').removeClass('removing');
-    let message = jqxhr.statusText;
-    if(jqxhr.responseJSON){
-      message = jqxhr.responseJSON.description;
-    }
-    $this.setWarningMessage(args.row, message);
-  }
-
-  /**
-   * Remove the row when the API returns this type of success
-   * @param {jQuery} $this the RelationshipsTable class instance
-   * @param {Object} args the table, row, input, url, and callbacks
-   * @param {String} json the returned JSON string
-   */
-  handleRemoveRowSuccess($this, args, json) {
-    args.row.remove();
-  }
-
-  /**
-   * Add a new row to the table, query the server for details about the work to
-   * set the title and link for the new work that was added. Hide the input
-   * field and display the title and edit button
-   * @param {jQuery} $this the RelationshipsTable class instance
-   * @param {Object} args the table, row, input, url, and callbacks
-   * @param {String} json the returned JSON string
-   */
-  handleAddRowSuccess($this, args, json) {
-    let new_row = new RelationshipsTableRow(args.table);
-    new_row.clone(args.row);
-    new_row.callAjaxQuery(args.query_url);
-
-    // finally, empty the "add" row input value
-    args.row.find("input.new-form-control").val("");
-    // synch the related_works_values to include the new work relationship
-    $this.existing_related_works_values = $this.$element.find("input.related_works_ids:not(.new-form-control)").map(function(i, e){ return e.value; });
-  }
-}