sufia 6.0.0 → 6.1.0

data/spec/javascripts/jasmine_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+# Run the jasmine tests by running the jasmine:ci rake command and capturing the output
+#   The spec will fail if any jasmine tests fails
+#
+#   If you have a jasmine syntax error the test will fail since there will not be zero failures
+#
+#   If you add a new jasmine test by adding a file to spec/javascripts/*spec.js* make sure the
+#   number of test run increments or you may have a syntax error inside your jasmine test
+#
+describe "Jasmine" do
+  it "expects all jasmine tests to pass" do
+    load_rake_environment ["#{jasmine_path}/lib/jasmine/tasks/jasmine.rake"]
+    jasmine_out = run_task 'jasmine:ci'
+    unless jasmine_out.include?  "0 failures"
+      puts "\n\n************************  Jasmine Output *************"
+      puts jasmine_out
+      puts "************************  Jasmine Output *************\n\n"
+    else
+      js_specs_count = Dir['spec/javascripts/**/*_spec.js*'].count
+      puts "#{jasmine_out.match(/\n(.+) specs/)[1]} jasmine specs run (in #{js_specs_count} jasmine test files)"
+    end
+    expect(jasmine_out).to include "0 failures"
+    expect(jasmine_out).to_not include "\n0 specs"
+  end
+
+end
+
+def jasmine_path
+  Gem.loaded_specs['jasmine'].full_gem_path
+end

data/spec/javascripts/notify_update_link_spec.js

@@ -0,0 +1,8 @@
+describe("notify update link", function() {
+    it("clicks the link", function(){
+        setFixtures('<div id="notify_update_link"></div>')
+        spyEvent = spyOnEvent('#notify_update_link', 'click');
+        notify_update_link();
+        expect(spyEvent).toHaveBeenTriggered();
+    });
+});

data/spec/javascripts/single_use_link_spec.js.coffee

@@ -0,0 +1,23 @@
+describe "single use link", ->
+
+    # call ajax to get a link
+    it "calls for the expected link", ->
+      # set up mock and response
+      resp = responseText: "/single_use_linkabc123"
+      options = {
+                  headers:
+                    Accept: 'application/javascript'
+                  type: 'get'
+                  url: "#{window.location.protocol}//#{window.location.host}/single_use_link/generate_show/abc123"
+                  async: false
+                }
+      se = spyOn($, "ajax").and.returnValue resp
+
+      # get the single use link
+      result = getSingleUse "copy_link_abc123"
+
+      #verify the result
+      expect(result).toEqual "#{window.location.protocol}//#{window.location.host}/single_use_linkabc123"
+
+      # verify the options sent to the ajax call
+      expect(se).toHaveBeenCalledWith(options)

data/spec/javascripts/support/jasmine.yml

@@ -0,0 +1,124 @@
+# src_files
+#
+# Return an array of filepaths relative to src_dir to include before jasmine specs.
+# Default: []
+#
+# EXAMPLE:
+#
+# src_files:
+#   - lib/source1.js
+#   - lib/source2.js
+#   - dist/**/*.js
+#
+src_files:
+  - assets/application.js
+
+# stylesheets
+#
+# Return an array of stylesheet filepaths relative to src_dir to include before jasmine specs.
+# Default: []
+#
+# EXAMPLE:
+#
+# stylesheets:
+#   - css/style.css
+#   - stylesheets/*.css
+#
+stylesheets:
+  - assets/application.css
+
+# helpers
+#
+# Return an array of filepaths relative to spec_dir to include before jasmine specs.
+# Default: ["helpers/**/*.js"]
+#
+# EXAMPLE:
+#
+# helpers:
+#   - helpers/**/*.js
+#
+helpers:
+  - 'helpers/**/*.js'
+
+# spec_files
+#
+# Return an array of filepaths relative to spec_dir to include.
+# Default: ["**/*[sS]pec.js"]
+#
+# EXAMPLE:
+#
+# spec_files:
+#   - **/*[sS]pec.js
+#
+spec_files:
+  - '**/*[sS]pec.js*'
+
+# src_dir
+#
+# Source directory path. Your src_files must be returned relative to this path. Will use root if left blank.
+# Default: project root
+#
+# EXAMPLE:
+#
+# src_dir: public
+#
+src_dir:
+
+# spec_dir
+#
+# Spec directory path. Your spec_files must be returned relative to this path.
+# Default: spec/javascripts
+#
+# EXAMPLE:
+#
+# spec_dir: spec/javascripts
+#
+spec_dir:
+
+# spec_helper
+#
+# Ruby file that Jasmine server will require before starting.
+# Returned relative to your root path
+# Default spec/javascripts/support/jasmine_helper.rb
+#
+# EXAMPLE:
+#
+# spec_helper: spec/javascripts/support/jasmine_helper.rb
+#
+spec_helper: spec/javascripts/support/jasmine_helper.rb
+
+# boot_dir
+#
+# Boot directory path. Your boot_files must be returned relative to this path.
+# Default: Built in boot file
+#
+# EXAMPLE:
+#
+# boot_dir: spec/javascripts/support/boot
+#
+boot_dir:
+
+# boot_files
+#
+# Return an array of filepaths relative to boot_dir to include in order to boot Jasmine
+# Default: Built in boot file
+#
+# EXAMPLE
+#
+# boot_files:
+#   - '**/*.js'
+#
+boot_files:
+
+# rack_options
+#
+# Extra options to be passed to the rack server
+# by default, Port and AccessLog are passed.
+#
+# This is an advanced options, and left empty by default
+#
+# EXAMPLE
+#
+# rack_options:
+#   server: 'thin'
+

data/spec/javascripts/support/jasmine_helper.rb

@@ -0,0 +1,15 @@
+#Use this file to set/override Jasmine configuration options
+#You can remove it if you don't need it.
+#This file is loaded *after* jasmine.yml is interpreted.
+#
+#Example: using a different boot file.
+#Jasmine.configure do |config|
+#   config.boot_dir = '/absolute/path/to/boot_dir'
+#   config.boot_files = lambda { ['/absolute/path/to/boot_dir/file.js'] }
+#end
+#
+#Example: prevent PhantomJS auto install, uses PhantomJS already on your path.
+#Jasmine.configure do |config|
+#   config.prevent_phantom_js_auto_install = true
+#end
+#

data/spec/javascripts/terms_of_service_spec.js.coffee

@@ -0,0 +1,32 @@
+describe "terms of service", ->
+    beforeEach ->
+        # setup a simple form with a checkbox and a button tomimic the upload forms
+        setFixtures  '<input id="check" type="checkbox" data-activate="activate-submit"><input><div id="div1" class="activate-container" data-toggle="tooltip"><button type="submit" class="activate-submit"></button></div>'
+
+        # call all the Blacklight.onLoad functions
+        Blacklight.activate()
+
+
+    # no submit button unless activate-submit is checked
+    it "submit is disabled by default", ->
+        expect($('.activate-submit')).toBeDisabled()
+
+    # shows tooltip until active-submit is checked
+    it "shows the tooltip by defualt", ->
+        se = spyOn $.fn, 'tooltip' # spy on tooltip call
+        $('.activate-container').trigger('mousemove')
+        expect(se).toHaveBeenCalledWith 'show'
+
+    describe "when checked", ->
+        # agree to the terms of service
+        beforeEach ->
+            $('#check').trigger('click')
+
+        it "activates submit when clicked", ->
+            expect($('.activate-submit')).not.toBeDisabled()
+
+        it "does not show the tooltip after checked", ->
+            se = spyOn $.fn, 'tooltip' # spy on tooltip call
+            $('.activate-container').trigger('mousemove')
+            expect(se).toHaveBeenCalledWith 'hide'
+

data/spec/javascripts/toggle_icon_spec.js

@@ -0,0 +1,11 @@
+
+describe("toggle icon", function() {
+    it("toggles the caret", function(){
+        setFixtures('<div id="icon" class="caret"></div>')
+        toggle_icon($("#icon"));
+        expect($("#icon")).toHaveClass("caret up")
+        toggle_icon($("#icon"));
+        expect($("#icon")).not.toHaveClass("caret up")
+        expect($("#icon")).toHaveClass("caret")
+    });
+});

data/spec/jobs/active_fedora_id_based_job_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
 describe ActiveFedoraIdBasedJob do
-  let (:user) {FactoryGirl.find_or_create(:jill)}
-  let (:file) {GenericFile.new.tap do |gf|
+  let(:user) { FactoryGirl.find_or_create(:jill) }
+  let(:file) { GenericFile.new.tap do |gf|
                   gf.apply_depositor_metadata(user)
                   gf.save!
-                end}
+               end }
 
   it "finds object" do
     job = ActiveFedoraIdBasedJob.new(file.id)

data/spec/jobs/import_url_job_spec.rb

@@ -51,10 +51,8 @@ describe ImportUrlJob do
 
   context "when the file has a virus" do
     before do
-      s1 = double('content deposit event')
       allow(ContentDepositEventJob).to receive(:new).with(generic_file.id, 'jilluser@example.com').never
 
-      s2 = double('characterize')
       allow(CharacterizeJob).to receive(:new).with(generic_file.id).never
     end
     it "should abort if virus check fails" do

data/spec/lib/sufia/arkivo/actor_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+
+describe Sufia::Arkivo::Actor do
+  before do
+    # Don't test characterization on these items; it breaks TravisCI
+    allow_any_instance_of(GenericFile).to receive(:characterize)
+  end
+
+  subject { described_class.new(user, item) }
+
+  let(:user) { FactoryGirl.find_or_create(:archivist) }
+  let(:item) { JSON.parse(FactoryGirl.json(:post_item)) }
+
+  describe 'Tempfile monkey-patches' do
+    subject { Tempfile.new('foo') }
+
+    it { is_expected.to respond_to(:original_filename) }
+    it { is_expected.to respond_to(:original_filename=) }
+    it { is_expected.to respond_to(:content_type) }
+    it { is_expected.to respond_to(:content_type=) }
+  end
+
+  describe '#create_file_from_item' do
+    it { is_expected.to respond_to(:create_file_from_item) }
+
+    it 'creates a batch for loading metadata' do
+      expect { subject.create_file_from_item }.to change { Batch.count }.by(1)
+    end
+
+    it 'instantiates an actor' do
+      expect(Sufia::GenericFile::Actor).to receive(:new).once.and_call_original
+      subject.create_file_from_item
+    end
+
+    it 'creates initial metadata' do
+      expect_any_instance_of(Sufia::GenericFile::Actor).to receive(:create_metadata).once
+      subject.create_file_from_item
+    end
+
+    it 'stores a checksum' do
+      gf = subject.create_file_from_item
+      expect(gf.arkivo_checksum).to eq item['file']['md5']
+    end
+
+    it 'calls create_content' do
+      expect_any_instance_of(Sufia::GenericFile::Actor).to receive(:create_content).once
+      subject.create_file_from_item
+    end
+
+    it 'extracts a file from the item' do
+      gf = subject.create_file_from_item
+      expect(gf.content.content).to eq "arkivo\n"
+    end
+
+    it 'batch applies metadata' do
+      gf = subject.create_file_from_item
+      # TODO: Figure out why this is needed if the Resque job is running synchronously
+      reloaded = gf.reload
+      expect(reloaded.title).to eq Array(item['metadata']['title'])
+    end
+
+    it 'returns a GF instance' do
+      expect(subject.create_file_from_item).to be_instance_of(GenericFile)
+    end
+  end
+
+  describe '#update_file_from_item' do
+    let(:item) { JSON.parse(FactoryGirl.json(:put_item)) }
+    let(:title) { ['ZZZZZ'] }
+    let(:description) { ['This is rather lengthy.'] }
+    let(:checksum) { 'abc123' }
+    let(:gf) do
+      GenericFile.create(title: title, description: description) do |f|
+        f.apply_depositor_metadata(user.user_key)
+        f.arkivo_checksum = checksum
+      end
+    end
+
+    it { is_expected.to respond_to(:update_file_from_item) }
+
+    it 'instantiates an actor' do
+      expect(Sufia::GenericFile::Actor).to receive(:new).once.and_call_original
+      subject.update_file_from_item(gf)
+    end
+
+    describe '#reset_metadata' do
+      it 'changes the title' do
+        # For some reason, "expect to change from to" wasn't working here
+        expect(gf.title).to eq title
+        subject.update_file_from_item(gf)
+        expect(gf.title).to eq Array(item['metadata']['title'])
+      end
+
+      it 'wipes out the description' do
+        # For some reason, "expect to change from to" wasn't working here
+        expect(gf.description).to eq description
+        subject.update_file_from_item(gf)
+        expect(gf.description).to eq []
+      end
+    end
+
+    it 'changes the arkivo checksum' do
+      expect {
+        subject.update_file_from_item(gf)
+      }.to change { gf.arkivo_checksum }.from(checksum).to(item['file']['md5'])
+    end
+
+    it 'calls update_content' do
+      expect_any_instance_of(Sufia::GenericFile::Actor).to receive(:update_content).once
+      subject.update_file_from_item(gf)
+    end
+
+    it 'extracts a file from the item' do
+      expect {
+        subject.update_file_from_item(gf)
+      }.to change { gf.content.content }.to("# HEADER\n\nThis is a paragraph!\n")
+    end
+
+    it 'returns a GF instance' do
+      expect(subject.update_file_from_item(gf)).to be_instance_of(GenericFile)
+    end
+  end
+
+  describe '#destroy_file' do
+    let(:gf) do
+      GenericFile.create do |f|
+        f.apply_depositor_metadata(user.user_key)
+      end
+    end
+
+    it { is_expected.to respond_to(:destroy_file) }
+
+    it 'deletes the file' do
+      expect {
+        subject.destroy_file(gf)
+      }.to change { gf.destroyed? }.from(nil).to(true)
+    end
+  end
+end

data/spec/lib/sufia/arkivo/create_subscription_job_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe Sufia::Arkivo::CreateSubscriptionJob do
+  let(:user) { FactoryGirl.find_or_create(:archivist) }
+
+  subject { described_class.new(user.user_key) }
+
+  context 'with a bogus user' do
+    before { allow(User).to receive(:find_by_user_key) { nil } }
+    it 'raises because user not found' do
+      expect { subject.run }.to raise_error(Sufia::Arkivo::SubscriptionError, 'User not found')
+    end
+  end
+
+  context 'without an arkivo token' do
+    before { allow_any_instance_of(User).to receive(:arkivo_token) { nil } }
+    it 'raises because user lacks arkivo token' do
+      expect { subject.run }.to raise_error(Sufia::Arkivo::SubscriptionError, 'User does not have an Arkivo token')
+    end
+  end
+
+  context 'without a zotero userid' do
+    it 'raises because user did not oauth' do
+      expect { subject.run }.to raise_error(Sufia::Arkivo::SubscriptionError, 'User has not yet connected with Zotero')
+    end
+  end
+
+  context 'with an existing subscription' do
+    before do
+      allow_any_instance_of(User).to receive(:zotero_userid) { '45352' }
+      allow_any_instance_of(User).to receive(:arkivo_subscription) { 'http://localhost/foo/bar' }
+    end
+
+    it 'raises because user already has subscription' do
+      expect { subject.run }.to raise_error(Sufia::Arkivo::SubscriptionError, 'User already has a subscription')
+    end
+  end
+
+  context 'when expected to succeed' do
+    before do
+      allow_any_instance_of(User).to receive(:zotero_userid) { '45352' }
+      allow(subject).to receive(:post_to_api) { response }
+    end
+
+    let(:response) { double('response', headers: { 'Location' => subscription_uri }) }
+    let(:subscription_uri) { '/api/subscription/abcxyz1234' }
+
+    it 'stores a subscription URL for possible later invalidation' do
+      expect(user.arkivo_subscription).to be_blank
+      subject.run
+      expect(user.reload.arkivo_subscription).to eq subscription_uri
+    end
+  end
+end