sufia 3.7.2 → 4.0.0.beta1

data/spec/features/browse_dashboard_files_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe "Browse Dashboard files" do
 
   before do
-    find_or_create_file_fixtures
+    @fixtures = find_or_create_file_fixtures
     sign_in :user_with_fixtures
   end
 
@@ -18,14 +18,13 @@ describe "Browse Dashboard files" do
 
   it "should allow you to browse facets" do
     # TODO: fix more facets link!
-    pending "Until more facets link is fixed..."
-    visit '/'
+    click_link "dashboard"
     click_link "more Subjects"
     click_link "consectetur"
-    #page.should have_content "1 - 5 of 5"
-    click_link "Test Document MP3.mp3"
-    page.should have_content "Download"
-    page.should_not have_content "Edit"
+    within("#document_#{@fixtures[1].noid}") do
+      click_link "Test Document MP3.mp3"
+    end
+    page.should have_content "File Details"
   end
 
   it "should allow me to edit files (from the fixtures)" do

data/spec/features/browse_files_spec.rb

@@ -4,26 +4,29 @@ describe "Browse files" do
 
   before(:all) do
     @fixtures = find_or_create_file_fixtures
+    @fixtures[0].tag = "key"
     (1..25).each do |i|
       @fixtures[0].tag << i
     end
     @fixtures[0].save
   end
 
+  before do
+    visit '/'
+    fill_in "search-field-header", with: "key"
+    click_button "search-submit-header"
+    click_link "more Keywords"
+  end
+
   describe "when not logged in" do
     it "should let us browse some of the fixtures" do
-      visit '/'
-      click_link "more Keywords"
       click_link "18"
-      page.should have_content "1 Search Results"
+      page.should have_content "Search Results"
       click_link @fixtures[0].title[0]
       page.should have_content "Download"
       page.should_not have_content "Edit"
     end
     it "should allow you to click next" do
-      # TODO: fix more facets link!
-      visit '/'
-      click_link "more Keywords"
       first(:link, 'Next').click
       page.should have_content "5"
       page.should_not have_content "11"

data/spec/features/cloud_upload_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe "Selecting files to import from cloud providers" do
+
+  before do
+    sign_in :user
+  end
+
+  it "should have a Cloud file picker using browse-everything" do
+    click_link "upload"
+    click_link "Cloud Providers"
+    page.should have_content "Browse cloud files"
+    page.should have_content "Submit selected files"
+    page.should have_content "0 items selected"
+    click_button 'Browse cloud files'
+  end
+
+end

data/spec/features/single_use_links_spec.rb

@@ -6,10 +6,9 @@ describe "Create and use single-use links" do
   include Sufia::Engine.routes.url_helpers
 
   before do
-    user = User.find_by_email('jilluser@example.com') || FactoryGirl.create(:user)
+    user = FactoryGirl.find_or_create(:jill)
     
-    login_as(user, :scope => :user)
-
+    login_as(user)
     
     @file = GenericFile.new
     @file.add_file(File.open(fixture_path + '/world.png'), 'content', 'world.png')

data/spec/helpers/content_block_helper_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe ContentBlockHelper do
+  let(:content_block) { FactoryGirl.create(:content_block, value: "<p>foo bar</p>") }
+
+  subject { helper.editable_content_block(content_block) }
+
+  context "for someone" do
+    context "with access" do
+      before do
+        expect(helper).to receive(:can?).with(:update, content_block).and_return(true)
+      end
+      let(:node) { Capybara::Node::Simple.new(subject) }
+      it "should show the preview and the form" do
+        expect(node).to have_selector "button[data-target='#edit_content_block_1'][data-behavior='reveal-editor']"
+        expect(node).to have_selector "form#edit_content_block_1[action='#{sufia.content_block_path(content_block)}']"
+        expect(subject).to be_html_safe
+      end
+    end
+  end
+
+  context "anonymous" do
+    before do
+      expect(helper).to receive(:can?).with(:update, content_block).and_return(false)
+    end
+    it "should show the content" do
+      expect(subject).to eq '<p>foo bar</p>'
+      expect(subject).to be_html_safe
+    end
+  end
+end

data/spec/helpers/generic_file_helper_spec.rb

@@ -3,12 +3,12 @@ require 'spec_helper'
 describe GenericFileHelper do
   it "draws add button" do
     helper.add_field(:test).should == 
-      "<button class=\"adder btn\" id=\"additional_test_submit\" name=\"additional_test\">+<span class=\"accessible-hidden\">add another test</span></button>"
+      "<button class=\"adder btn\" id=\"additional_test_submit\" name=\"additional_test\">+<span class=\"sr-only\">add another test</span></button>"
   end
 
   it "draws subtract button" do
     helper.subtract_field(:test).should == 
-      "<button class=\"remover btn\" id=\"additional_test_submit\" name=\"additional_test\">-<span class=\"accessible-hidden\">add another test</span></button>"
+      "<button class=\"remover btn\" id=\"additional_test_submit\" name=\"additional_test\">-<span class=\"sr-only\">add another test</span></button>"
   end
 
   it "draws help_icon" do
@@ -20,7 +20,7 @@ describe GenericFileHelper do
     a.attr('data-original-title').should == "Keyword"
     a.attr('id').should == "generic_file_tag_help"
     i = a.children.first
-    i.attr('class').should == 'icon-question-sign icon-large'
+    i.attr('class').should == 'glyphicon glyphicon-question-sign icon-large'
   end
 
 end

data/spec/helpers/sufia_helper_spec.rb

@@ -1,95 +1,27 @@
 require 'spec_helper'
 
 describe SufiaHelper do
-  describe "link_to_profile" do
-    it "should use User#to_params" do
-      u = User.new
-      u.stub(:user_key).and_return('justin@example.com')
-      User.should_receive(:find_by_user_key).with('justin@example.com').and_return(u)
-      helper.link_to_profile('justin@example.com').should == "<a href=\"/users/justin@example-dot-com\">justin@example.com</a>"
-    end
-  end
 
-  describe "link_back_to_catalog" do
-    let(:query_params)  {{:q => "query", :f => "facets", :per_page => "10", :page => "2", :controller=>'catalog'}}
-    let(:dashboard_query_params) {{ :page => "2", :controller=>'dashboard'}}
+  describe "#link_to_facet_list" do
+    before { helper.stub(blacklight_config: CatalogController.blacklight_config) }
 
-    it "should build a link tag to catalog using session[:search] for query params" do
-      helper.stub(:current_search_session).and_return double(:query_params => query_params)
-      tag = helper.link_back_to_catalog
-      tag.should =~ /q=query/
-      tag.should =~ /f=facets/
-      tag.should =~ /per_page=10/
-      tag.should =~ /page=2/
-    end
+    context "with values" do
+      subject { helper.link_to_facet_list(['car', 'truck'], 'vehicle_type') }
 
-    it "should build a link tag to bookmarks using session[:search] for query params" do
-      helper.stub(:current_search_session).and_return double(:query_params => dashboard_query_params)
-      tag = helper.link_back_to_catalog(route_set: sufia)
-      tag.should =~ /Back to Search/
-      tag.should =~ /\/dashboard\/page\/2/
-    end
-  end
-
-  describe "number_of_deposits" do
-    let(:conn) { ActiveFedora::SolrService.instance.conn }
-    before do
-      # More than 10 times, because the pagination threshold is 10
-      12.times do |t|
-        conn.add  :id => "199#{t}", Solrizer.solr_name('depositor', :stored_searchable) => user.user_key
-      end
-      conn.commit
-    end
-    after do
-      12.times do |t|
-        conn.delete_by_id "199#{t}"
+      it "should join the values" do
+        car_link = root_path(f: {'vehicle_type_sim' => ['car']})
+        truck_link = root_path(f: {'vehicle_type_sim' => ['truck']})
+        expect(subject).to eq "<a href=\"#{car_link}\">car</a>, <a href=\"#{truck_link}\">truck</a>"
+        expect(subject).to be_html_safe
       end
-      conn.commit
-    end
-
-    let(:user) { double(user_key: 'justin') }
-
-    it "should return the correct number" do
-      expect(number_of_deposits(user)).to eq 12
     end
-  end
 
-  describe "selected facet" do
-    let(:blacklight_config) { Blacklight::Configuration.new }
-
-    before(:each) do
-      helper.stub(:blacklight_config).and_return blacklight_config
-      helper.stub(:url_for).and_return('http://example.com')
-    end
+    context "without values" do
+      subject { helper.link_to_facet_list([], 'vehicle_type') }
 
-
-    describe "render_selected_facet_value" do
-      it "be html_safe and not have the remove link" do
-        item = double("item", :value=>'two', :hits=>9)
-        ret_val = helper.render_facet_value("one", item)
-        doc = Nokogiri::HTML(ret_val)
-        filter = doc.xpath("//a[@class='facet_select']")
-        filter.text.should == item.value
-        ret_val.should be_html_safe
-      end
-      it "use facet_display_value" do
-        item = double("item", :value=>'two', :hits=>9)
-        helper.stub(:facet_display_value).and_return('four')
-        ret_val = helper.render_facet_value("one", item)
-        doc = Nokogiri::HTML(ret_val)
-        filter = doc.xpath("//a[@class='facet_select']")
-        filter.text.should == 'four'
+      it "should show the default text" do
+        expect(subject).to eq "No value entered"
       end
-      it "use facet_display_value for dashboard" do
-        params[:controller] = "dashboard"
-        item = double("item", :value=>'two', :hits=>9)
-        helper.stub(:facet_display_value).and_return('four')
-        ret_val = helper.render_facet_value("one", item)
-        doc = Nokogiri::HTML(ret_val)
-        filter = doc.xpath("//a[@class='facet_select']")
-        filter.text.should == 'four'
-      end
-
     end
   end
 end

data/spec/helpers/trophy_helper_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe TrophyHelper do
+  describe "#display_trophy_link" do
+    let(:user) { FactoryGirl.create(:user) }
+    let(:noid) { '9999' }
+
+    let(:text_attributes) { '[data-add-text="Highlight File on Profile"][data-remove-text="Unhighlight File"]' }
+    let(:url_attribute) { "[data-url=\"/users/#{user.to_param}/trophy?file_id=9999\"]" }
+
+    context "when there is no trophy" do
+      it "should have a link for highlighting" do
+        out = helper.display_trophy_link(user, noid) { |text| "foo #{text} bar" } 
+        node = Capybara::Node::Simple.new(out)
+        expect(node).to have_selector("a.trophy-class.trophy-off#{text_attributes}#{url_attribute}")
+        expect(node).to have_link 'foo Highlight File on Profile bar', href: '#'
+      end
+    end
+
+    context "when there is a trophy" do
+      before do
+        user.trophies.create(generic_file_id: noid)
+      end
+
+      it "should have a link for highlighting" do
+        out = helper.display_trophy_link(user, noid) { |text| "foo #{text} bar" } 
+        node = Capybara::Node::Simple.new(out)
+        expect(node).to have_selector("a.trophy-class.trophy-on#{text_attributes}#{url_attribute}")
+        expect(node).to have_link 'foo Unhighlight File bar', href: '#'
+      end
+
+      it "should allow removerow to be passed" do
+        out = helper.display_trophy_link(user, noid, data: {removerow: true}) { |text| "foo #{text} bar" } 
+        node = Capybara::Node::Simple.new(out)
+        expect(node).to have_selector("a.trophy-class.trophy-on[data-removerow=\"true\"]#{text_attributes}#{url_attribute}")
+      end
+    end
+  end
+end

data/spec/jobs/import_url_job_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe ImportUrlJob do
-  let(:user) { FactoryGirl.find_or_create(:user) }
+  let(:user) { FactoryGirl.find_or_create(:jill) }
 
   let(:generic_file) do
     GenericFile.new.tap do |f|

data/spec/jobs/ingest_local_file_job_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe IngestLocalFileJob do
-  let(:user) { FactoryGirl.find_or_create(:user) }
+  let(:user) { FactoryGirl.find_or_create(:jill) }
 
   let (:generic_file) do
     GenericFile.new.tap { |f| f.apply_depositor_metadata(user); f.save }

data/spec/lib/sufia/usage_statistics_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe Sufia::UsageStatistics do
+  before do
+    token = OAuth2::AccessToken.new(nil, nil)
+    allow(subject).to receive(:token).and_return(token)
+  end
+
+  it 'responds to :config' do
+    expect(subject).to respond_to(:config)
+  end
+
+  it 'reads its config from a yaml file' do
+    expect(subject.config.keys.sort).to eql ['app_name', 'app_version', 'client_email', 'privkey_path', 'privkey_secret']
+  end
+
+  it 'responds to :user' do
+    expect(subject).to respond_to(:user)
+  end
+
+  it 'instantiates a user' do
+    expect(subject.user).to be_a(Legato::User)
+  end
+
+  it 'responds to :profile' do
+    expect(subject).to respond_to(:profile)
+  end
+
+  describe 'querying' do
+    before do
+      profile = Legato::Management::Profile.new({"id" => 12345, "name" => "Profile 1", "accountId" => "12345", "webPropertyId" => "UA-12345-2", "timezone" => "America/Chicago"}, subject.user)
+      allow(subject).to receive(:profile).and_return(profile)
+    end
+
+    let(:query) { Sufia::UsageStatistics.profile.pageview }
+
+    it 'returns a query object' do
+      expect(query).to be_a(Legato::Query)
+    end
+
+    describe 'results' do
+      before(:all) do
+        @system_timezone = ENV['TZ']
+        ENV['TZ'] = 'UTC'
+      end
+
+      after(:all) do
+        ENV['TZ'] = @system_timezone
+      end
+
+      # Mock and stub Google Analytics results
+      before do
+        @mock_query = double('query')
+        allow(@mock_query).to receive(:collection).and_return([
+            OpenStruct.new(date: '2014-01-01', pageviews: 4),
+            OpenStruct.new(date: '2014-01-02', pageviews: 8),
+            OpenStruct.new(date: '2014-01-03', pageviews: 6),
+            OpenStruct.new(date: '2014-01-04', pageviews: 10),
+            OpenStruct.new(date: '2014-01-05', pageviews: 2)])
+        allow(@mock_query).to receive(:map).and_return(@mock_query.collection.map(&:marshal_dump))
+        allow(Sufia::UsageStatistics.profile).to receive(:pageview).and_return(@mock_query)
+      end
+
+      let(:results) { @mock_query }
+
+      it 'converts results to json' do
+        expect(subject.as_flot_json(results)).to eql('[[1388534400000,4],[1388620800000,8],[1388707200000,6],[1388793600000,10],[1388880000000,2]]')
+      end
+
+      it 'calculates total page views' do
+        expect(subject.total_pageviews(results)).to eql(30)
+      end
+    end
+  end
+end

data/spec/models/ability_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+require 'cancan/matchers'
+
+describe Sufia::Ability do
+
+
+  describe "a user with no roles" do
+    let(:user) { nil }
+    subject { Ability.new(user) }
+    it { should_not be_able_to(:create, GenericFile) }
+    it { should_not be_able_to(:create, TinymceAsset) }
+    it { should_not be_able_to(:update, ContentBlock) }
+  end
+
+  describe "a registered user" do
+    let(:user) { FactoryGirl.create(:user) }
+    subject { Ability.new(user) }
+    it { should be_able_to(:create, GenericFile) }
+    it { should_not be_able_to(:create, TinymceAsset) }
+    it { should_not be_able_to(:update, ContentBlock) }
+  end
+
+  describe "a user in the admin group" do
+    let(:user) { FactoryGirl.create(:user) }
+    before { user.stub(groups: ['admin', 'registered']) }
+    subject { Ability.new(user) }
+    it { should be_able_to(:create, GenericFile) }
+    it { should be_able_to(:create, TinymceAsset) }
+    it { should be_able_to(:update, ContentBlock) }
+  end
+end

data/spec/models/active_fedora_pid_based_job_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe ActiveFedoraPidBasedJob do
-  let (:user) {FactoryGirl.find_or_create(:user)}
+  let (:user) {FactoryGirl.find_or_create(:jill)}
   let (:file) {GenericFile.new.tap do |gf|
                   gf.apply_depositor_metadata(user)
                   gf.save!