sufia 3.7.2 → 4.0.0.beta1

data/spec/controllers/featured_works_controller_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe FeaturedWorksController do
+  describe "#create" do
+    before do
+      sign_in FactoryGirl.create(:user)
+      expect(controller).to receive(:authorize!).with(:create, FeaturedWork).and_return(true)
+    end
+
+    context "when there are no featured works" do
+      it "should create one" do
+        expect {
+          post :create, id: '1234abcd', format: :json
+        }.to change { FeaturedWork.count}.by(1)
+        expect(response).to be_successful
+      end
+    end
+
+    context "when there are 5 featured works" do
+      before do
+        5.times do |n|
+          FeaturedWork.create(generic_file_id:n.to_s)
+        end
+      end
+      it "should not create another" do
+        expect {
+          post :create, id: '1234abcd', format: :json
+        }.to_not change { FeaturedWork.count}
+        expect(response.status).to eq 422
+      end
+    end
+  end
+
+  describe "#destroy" do
+
+    let!(:featured_work) { FactoryGirl.create(:featured_work, generic_file_id: '1234abcd') }
+
+    before do
+      sign_in FactoryGirl.create(:user)
+      expect(controller).to receive(:authorize!).with(:destroy, FeaturedWork).and_return(true)
+    end
+
+    it "should remove it" do
+      expect {
+        delete :destroy, id: '1234abcd', format: :json
+      }.to change { FeaturedWork.count}.by(-1)
+      expect(response.status).to eq 204
+    end
+  end
+end

data/spec/controllers/generic_files_controller_spec.rb

@@ -3,17 +3,19 @@ require 'spec_helper'
 describe GenericFilesController do
   before do
     controller.stub(:has_access?).and_return(true)
-    @user = FactoryGirl.find_or_create(:user)
+    @user = FactoryGirl.find_or_create(:jill)
     sign_in @user
     User.any_instance.stub(:groups).and_return([])
     controller.stub(:clear_session_user) ## Don't clear out the authenticated session
   end
+
   describe "#create" do
     before do
       @file_count = GenericFile.count
       @mock = GenericFile.new({:pid => 'test:123'})
       GenericFile.stub(:new).and_return(@mock)
     end
+
     after do
       GenericFile.unstub(:new)
       Batch.find("sample:batch_id").delete rescue
@@ -117,7 +119,23 @@ describe GenericFilesController do
       response.body.should include("Error occurred while creating generic file.")
     end
   end
-
+  
+  describe "#create with browse-everything" do
+    before do
+      GenericFile.delete_all
+      @json_from_browse_everything = {"0"=>{"url"=>"https://dl.dropbox.com/fake/filepicker-demo.txt.txt", "expires"=>"2014-03-31T20:37:36.214Z", "file_name"=>"filepicker-demo.txt.txt"}, "1"=>{"url"=>"https://dl.dropbox.com/fake/Getting%20Started.pdf", "expires"=>"2014-03-31T20:37:36.731Z", "file_name"=>"Getting+Started.pdf"}}
+    end
+    it "should ingest files from provide URLs" do
+      ImportUrlJob.should_receive(:new).twice {"ImportJob"}
+      Sufia.queue.should_receive(:push).with("ImportJob").twice
+      lambda { post :create, selected_files: @json_from_browse_everything, :batch_id => "sample:batch_id"}.should change(GenericFile, :count).by(2)
+      created_files = GenericFile.all
+      ["https://dl.dropbox.com/fake/Getting%20Started.pdf", "https://dl.dropbox.com/fake/filepicker-demo.txt.txt"].each do |url|
+        created_files.map {|f| f.import_url}.should include(url)  
+      end
+    end    
+  end
+  
   describe "#create with local_file" do
     let (:mock_url) {"http://example.com"}
     before do
@@ -170,7 +188,6 @@ describe GenericFilesController do
         lambda { post :create, local_file: ["world.png", "import"], batch_id: "xw42n7934"}.should change(GenericFile, :count).by(4)
         response.should redirect_to Sufia::Engine.routes.url_helpers.batch_edit_path('xw42n7934')
         # These files should have been moved out of the upload directory
-        File.exist?("#{@mock_upload_directory}/import/files/Example.ogg").should be_false
         File.exist?("#{@mock_upload_directory}/import/files/icons.zip").should be_false
         File.exist?("#{@mock_upload_directory}/import/metadata/dublin_core_rdf_descMetadata.nt").should be_false
         File.exist?("#{@mock_upload_directory}/world.png").should be_false
@@ -216,7 +233,7 @@ describe GenericFilesController do
       @generic_file = GenericFile.new
       @generic_file.apply_depositor_metadata(@user)
       @generic_file.save
-      @user = FactoryGirl.find_or_create(:user)
+      @user = FactoryGirl.find_or_create(:jill)
       sign_in @user
     end
     after do
@@ -235,6 +252,54 @@ describe GenericFilesController do
     end
   end
 
+  describe 'stats' do
+    before do
+      @generic_file = GenericFile.new.tap do |gf|
+        gf.apply_depositor_metadata(@user)
+        gf.save
+      end
+    end
+
+    after do
+      @generic_file.destroy
+    end
+
+    context 'when user has access to file' do
+      before do
+        sign_in @user
+        mock_query = double('query')
+        allow(mock_query).to receive(:for_path).and_return([
+            OpenStruct.new(date: '2014-01-01', pageviews: 4),
+            OpenStruct.new(date: '2014-01-02', pageviews: 8),
+            OpenStruct.new(date: '2014-01-03', pageviews: 6),
+            OpenStruct.new(date: '2014-01-04', pageviews: 10),
+            OpenStruct.new(date: '2014-01-05', pageviews: 2)])
+        allow(mock_query).to receive(:map).and_return(mock_query.for_path.map(&:marshal_dump))
+        profile = double('profile')
+        allow(profile).to receive(:pageview).and_return(mock_query)
+        allow(Sufia::UsageStatistics).to receive(:profile).and_return(profile)
+       end
+
+      it 'renders the stats view' do
+        get :stats, id: @generic_file.noid
+        expect(response).to be_success
+        expect(response).to render_template(:stats)
+      end
+    end
+
+    context 'when user lacks access to file' do
+      before do
+        @archivist = FactoryGirl.find_or_create(:archivist)
+        sign_in @archivist
+      end
+
+      it 'redirects to root_url' do
+        get :stats, id: @generic_file.pid
+        expect(response).to redirect_to(Sufia::Engine.routes.url_helpers.root_path)
+      end
+    end
+  end
+
   describe "update" do
     before do
       @generic_file = GenericFile.new
@@ -249,7 +314,7 @@ describe GenericFilesController do
       s1 = double('one')
       ContentUpdateEventJob.should_receive(:new).with(@generic_file.pid, 'jilluser@example.com').and_return(s1)
       Sufia.queue.should_receive(:push).with(s1).once
-      @user = FactoryGirl.find_or_create(:user)
+      @user = FactoryGirl.find_or_create(:jill)
       sign_in @user
       post :update, :id=>@generic_file.pid, :generic_file=>{:title=>'new_title', :tag=>[''], :permissions=>{:new_user_name=>{'archivist1'=>'edit'}}}
       @user.delete
@@ -262,7 +327,7 @@ describe GenericFilesController do
       s2 = double('one')
       CharacterizeJob.should_receive(:new).with(@generic_file.pid).and_return(s2)
       Sufia.queue.should_receive(:push).with(s2).once
-      @user = FactoryGirl.find_or_create(:user)
+      @user = FactoryGirl.find_or_create(:jill)
       sign_in @user
 
       file = fixture_file_upload('/world.png','image/png')
@@ -271,7 +336,7 @@ describe GenericFilesController do
     end
 
     it "should change mime type when restoring a revision with a different mime type" do
-      @user = FactoryGirl.find_or_create(:user)
+      @user = FactoryGirl.find_or_create(:jill)
       sign_in @user
 
       file = fixture_file_upload('/world.png','image/png')
@@ -301,7 +366,7 @@ describe GenericFilesController do
     end
 
     it "should record what user added a new version" do
-      @user = FactoryGirl.find_or_create(:user)
+      @user = FactoryGirl.find_or_create(:jill)
       sign_in @user
 
       file = fixture_file_upload('/world.png','image/png')
@@ -378,7 +443,7 @@ describe GenericFilesController do
       CharacterizeJob.should_receive(:new).with(@generic_file.pid).and_return(s2)
       Sufia.queue.should_receive(:push).with(s2).once
       GenericFile.stub(:save).and_return({})
-      @user = FactoryGirl.find_or_create(:user)
+      @user = FactoryGirl.find_or_create(:jill)
       sign_in @user
       file = fixture_file_upload('/world.png','image/png')
       post :update, :id=>@generic_file.pid, :filedata=>file, :Filename=>"The world", :generic_file=>{:tag=>[''],  :permissions=>{:new_user_name=>{'archivist1'=>'edit'}}}

data/spec/controllers/mailbox_controller_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe MailboxController do
   before(:each) do
-    @user = FactoryGirl.find_or_create(:user)
+    @user = FactoryGirl.find_or_create(:jill)
     @another_user = FactoryGirl.find_or_create(:archivist)
     @message = "Test Message"
     @subject = "Test Subject"

data/spec/controllers/pages_controller_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe PagesController do
+  let (:page_name) {"about_page"}
+  context "content exists" do
+    describe "GET #show" do
+      let(:page) { ContentBlock.create!(name: page_name, value: "foo bar") }
+
+      it "should update the node" do
+        get :show, id: page.name
+        expect(response).to be_successful
+        expect(assigns[:page]).to eq page
+      end
+    end
+  end
+  context "content does not exist" do
+    describe "GET #show" do
+      it "should create the node" do
+        get :show, id: "about_page"
+        expect(response).to be_successful
+        expect(assigns[:page]).not_to be_nil
+      end
+    end
+  end
+end

data/spec/controllers/single_use_links_controller_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe SingleUseLinksController do
   before(:all) do
-    @user = FactoryGirl.find_or_create(:user)
+    @user = FactoryGirl.find_or_create(:jill)
     @file = GenericFile.new
     @file.add_file(File.open(fixture_path + '/world.png'), 'content', 'world.png')
     @file.apply_depositor_metadata(@user)

data/spec/controllers/single_use_links_viewer_controller_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe SingleUseLinksViewerController do
   before(:all) do
-    @user = FactoryGirl.find_or_create(:user)
+    @user = FactoryGirl.find_or_create(:jill)
     @file = GenericFile.new
     @file.add_file(File.open(fixture_path + '/world.png'), 'content', 'world.png')
     @file.apply_depositor_metadata(@user)

data/spec/controllers/tinymce_assets_controller_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe TinymceAssetsController do
+  let(:file) { fixture_file_upload('/world.png','image/png') }
+
+  context "when logged in" do
+    let(:user) { FactoryGirl.create(:user) }
+    before { sign_in user }
+
+    context "as a user who can upload" do
+      before { expect(controller).to receive(:authorize!).with(:create, TinymceAsset).and_return(true) }
+
+      it "should upload the file" do
+        expect {
+          post :create, file: file
+          expect(response).to be_successful
+        }.to change{ TinymceAsset.count }.by(1)
+
+        json = JSON.parse(response.body)
+        expect(json).to eq({"image"=>{"url"=>"/uploads/tinymce_asset/file/1/world.png"}})
+      end
+    end
+
+    context "as a user who can't upload" do
+      it "should redirect to root path" do
+        post :create, file: file
+        expect(response).to redirect_to root_path
+      end
+    end
+  end
+
+  context "when not logged in" do
+    it "should redirect to root path" do
+      post :create, file: file
+      expect(response).to redirect_to main_app.new_user_session_path
+
+    end
+  end
+end

data/spec/controllers/users_controller_spec.rb

@@ -2,18 +2,13 @@ require 'spec_helper'
 
 describe UsersController do
   before(:each) do
-    @user = FactoryGirl.find_or_create(:user)
+    @user = FactoryGirl.find_or_create(:jill)
     @another_user = FactoryGirl.find_or_create(:archivist)
     sign_in @user
     User.any_instance.stub(:groups).and_return([])
     controller.stub(:clear_session_user) ## Don't clear out the authenticated session
   end
-  after(:all) do
-    @user = FactoryGirl.find(:user) rescue
-    @user.delete if @user
-    @another_user = FactoryGirl.find(:archivist) rescue
-    @another_user.delete if @user
-  end
+
   describe "#show" do
     it "show the user profile if user exists" do
       get :show, id: @user.user_key
@@ -88,7 +83,7 @@ describe UsersController do
         @u2.save
       end
       it "uses the base query" do
-        u3 = FactoryGirl.find_or_create(:user)
+        u3 = FactoryGirl.find_or_create(:jill)
         controller.stub(:base_query).and_return(['email == "jilluser@example.com"'])
         get :index
         assigns[:users].should include(u3)

data/spec/factories/content_blocks.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :content_block do |cb|
+  end
+end

data/spec/factories/featured_works.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :featured_work do |u|
+  end
+end

data/spec/factories/generic_files.rb

@@ -1,46 +1,53 @@
 FactoryGirl.define do
-
-  factory :fixture, :class => GenericFile do
-    factory :public_pdf do
-      ignore do
-        pid "sufia:fixture-pdf"
-      end
-      initialize_with { new(pid: pid) }
-      read_groups ["public"]
-      resource_type "Dissertation"
-      subject %w"lorem ipsum dolor sit amet"
-      before(:create) do |gf|
-        gf.apply_depositor_metadata "archivist1@example.com"
-        gf.title = "Fake Document Title"
-        gf.label = "fake_document.pdf"
-      end
+  factory :generic_file do
+    ignore do
+      depositor "archivist1@example.com"
     end
-    factory :public_mp3 do
-      ignore do
-        pid "sufia:fixture-mp3"
-      end
-      initialize_with { new(pid: pid) }
-      subject %w"consectetur adipisicing elit"
-      before(:create) do |gf|
-        gf.apply_depositor_metadata "archivist1@example.com"
-        gf.inner_object.pid = "sufia:fixture-mp3"
-        gf.label = "Test Document MP3.mp3"
-      end
-      read_groups ["public"]
+    before(:create) do |gf, evaluator|
+      gf.apply_depositor_metadata evaluator.depositor
     end
-    factory :public_wav do
-      ignore do
-        pid "sufia:fixture-wav"
+
+    factory :fixture do
+      factory :public_pdf do
+        ignore do
+          pid "sufia:fixture-pdf"
+        end
+        initialize_with { new(pid: pid) }
+        read_groups ["public"]
+        resource_type "Dissertation"
+        subject %w"lorem ipsum dolor sit amet"
+        before(:create) do |gf|
+          gf.apply_depositor_metadata "archivist1@example.com"
+          gf.title = "Fake Document Title"
+          gf.label = "fake_document.pdf"
+        end
       end
-      initialize_with { new(pid: pid) }
-      resource_type ["Audio", "Dataset"]
-      read_groups ["public"]
-      subject %w"sed do eiusmod tempor incididunt ut labore"
-      before(:create) do |gf|
-        gf.apply_depositor_metadata "archivist1@example.com"
-        gf.label = "Fake Wav File.wav"
+      factory :public_mp3 do
+        ignore do
+          pid "sufia:fixture-mp3"
+        end
+        initialize_with { new(pid: pid) }
+        subject %w"consectetur adipisicing elit"
+        before(:create) do |gf|
+          gf.apply_depositor_metadata "archivist1@example.com"
+          gf.inner_object.pid = "sufia:fixture-mp3"
+          gf.label = "Test Document MP3.mp3"
+        end
+        read_groups ["public"]
+      end
+      factory :public_wav do
+        ignore do
+          pid "sufia:fixture-wav"
+        end
+        initialize_with { new(pid: pid) }
+        resource_type ["Audio", "Dataset"]
+        read_groups ["public"]
+        subject %w"sed do eiusmod tempor incididunt ut labore"
+        before(:create) do |gf|
+          gf.apply_depositor_metadata "archivist1@example.com"
+          gf.label = "Fake Wav File.wav"
+        end
       end
     end
   end
-
-end
+end

data/spec/factories/users.rb

@@ -1,26 +1,26 @@
 FactoryGirl.define do
-  factory :user, :class => User do |u|
-    email 'jilluser@example.com'
+  factory :user do
+    sequence(:email) { |n| "user#{n}@example.com" }
     password 'password'
-  end
 
-  factory :archivist, aliases: [:user_with_fixtures], :class => User do |u|
-    email 'archivist1@example.com'
-    password 'password'
-  end
+    factory :jill do
+      email 'jilluser@example.com'
+    end
 
-  factory :user_with_mail, :class => User do |u|
-    email 'archivist2@example.com'
-    password 'password'
-    after(:create) do |user|
-      message = '<span class="batchid ui-helper-hidden">fake_batch_noid</span>You\'ve got mail.'
-      User.batchuser().send_message(user, message, "Sample notification.")
+    factory :archivist, aliases: [:user_with_fixtures] do
+      email 'archivist1@example.com'
     end
-  end
 
-  factory :curator, :class => User do |u|
-    email 'curator1@example.com'
-    password 'password'
+    factory :user_with_mail do
+      email 'archivist2@example.com'
+      after(:create) do |user|
+        message = '<span class="batchid ui-helper-hidden">fake_batch_noid</span>You\'ve got mail.'
+        User.batchuser().send_message(user, message, "Sample notification.")
+      end
+    end
+
+    factory :curator do
+      email 'curator1@example.com'
+    end
   end
 end
-