stripe 3.3.2 → 3.4.1

data/test/stripe/webhook_test.rb

@@ -1,14 +1,16 @@
-require File.expand_path('../../test_helper', __FILE__)
+require File.expand_path("../../test_helper", __FILE__)
 
 module Stripe
   class WebhookTest < Test::Unit::TestCase
-    EVENT_PAYLOAD = '''{
-  "id": "evt_test_webhook",
-  "object": "event"
-}'''
-    SECRET = 'whsec_test_secret'
+    EVENT_PAYLOAD = <<-PAYLOAD.freeze
+      {
+        "id": "evt_test_webhook",
+        "object": "event"
+      }
+    PAYLOAD
+    SECRET = "whsec_test_secret".freeze
 
-    def generate_header(opts={})
+    def generate_header(opts = {})
       opts[:timestamp] ||= Time.now.to_i
       opts[:payload] ||= EVENT_PAYLOAD
       opts[:secret] ||= SECRET
@@ -21,19 +23,19 @@ module Stripe
       should "return an Event instance from a valid JSON payload and valid signature header" do
         header = generate_header
         event = Stripe::Webhook.construct_event(EVENT_PAYLOAD, header, SECRET)
-        assert event.kind_of?(Stripe::Event)
+        assert event.is_a?(Stripe::Event)
       end
 
       should "raise a JSON::ParserError from an invalid JSON payload" do
         assert_raises JSON::ParserError do
-          payload = 'this is not valid JSON'
+          payload = "this is not valid JSON"
           header = generate_header(payload: payload)
           Stripe::Webhook.construct_event(payload, header, SECRET)
         end
       end
 
       should "raise a SignatureVerificationError from a valid JSON payload and an invalid signature header" do
-        header = 'bad_header'
+        header = "bad_header"
         assert_raises Stripe::SignatureVerificationError do
           Stripe::Webhook.construct_event(EVENT_PAYLOAD, header, SECRET)
         end
@@ -44,23 +46,23 @@ module Stripe
       should "raise a SignatureVerificationError when the header does not have the expected format" do
         header = 'i\'m not even a real signature header'
         e = assert_raises(Stripe::SignatureVerificationError) do
-          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, 'secret')
+          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, "secret")
         end
         assert_match("Unable to extract timestamp and signatures from header", e.message)
       end
 
       should "raise a SignatureVerificationError when there are no signatures with the expected scheme" do
-        header = generate_header(scheme: 'v0')
+        header = generate_header(scheme: "v0")
         e = assert_raises(Stripe::SignatureVerificationError) do
-          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, 'secret')
+          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, "secret")
         end
         assert_match("No signatures found with expected scheme", e.message)
       end
 
       should "raise a SignatureVerificationError when there are no valid signatures for the payload" do
-        header = generate_header(signature: 'bad_signature')
+        header = generate_header(signature: "bad_signature")
         e = assert_raises(Stripe::SignatureVerificationError) do
-          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, 'secret')
+          Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, "secret")
         end
         assert_match("No signatures found matching the expected signature for payload", e.message)
       end
@@ -84,7 +86,7 @@ module Stripe
       end
 
       should "return true when the header contains a valid signature and the timestamp is off but no tolerance is provided" do
-        header = generate_header(timestamp: 12345)
+        header = generate_header(timestamp: 12_345)
         assert(Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, SECRET))
       end
     end

data/test/stripe_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../test_helper', __FILE__)
+require File.expand_path("../test_helper", __FILE__)
 
 class StripeTest < Test::Unit::TestCase
   should "warn that #refresh_from is deprecated" do
@@ -6,8 +6,8 @@ class StripeTest < Test::Unit::TestCase
     $stderr = StringIO.new
     begin
       Stripe.uri_encode({})
-      message = "NOTE: Stripe.uri_encode is deprecated; use " +
-        "Stripe::Util#encode_parameters instead"
+      message = "NOTE: Stripe.uri_encode is deprecated; use " \
+                "Stripe::Util#encode_parameters instead"
       assert_match Regexp.new(message), $stderr.string
     ensure
       $stderr = old_stderr
@@ -25,7 +25,7 @@ class StripeTest < Test::Unit::TestCase
       assert_equal({
         name: "MyAwesomePlugin",
         url: "https://myawesomeplugin.info",
-        version: "1.2.34"
+        version: "1.2.34",
       }, Stripe.app_info)
     ensure
       Stripe.app_info = old

data/test/test_data.rb

@@ -2,57 +2,57 @@ module Stripe
   module TestData
     def make_error(type, message)
       {
-        :error => {
-          :type => type,
-          :message => message,
-        }
+        error: {
+          type: type,
+          message: message,
+        },
       }
     end
 
     def make_invalid_api_key_error
       {
-        :error => {
-          :type => "invalid_request_error",
-          :message => "Invalid API Key provided: invalid"
-        }
+        error: {
+          type: "invalid_request_error",
+          message: "Invalid API Key provided: invalid",
+        },
       }
     end
 
     def make_invalid_exp_year_error
       {
-        :error => {
-          :code => "invalid_expiry_year",
-          :param => "exp_year",
-          :type => "card_error",
-          :message => "Your card's expiration year is invalid"
-        }
+        error: {
+          code: "invalid_expiry_year",
+          param: "exp_year",
+          type: "card_error",
+          message: "Your card's expiration year is invalid",
+        },
       }
     end
 
     def make_missing_id_error
       {
-        :error => {
-          :param => "id",
-          :type => "invalid_request_error",
-          :message => "Missing id"
-        }
+        error: {
+          param: "id",
+          type: "invalid_request_error",
+          message: "Missing id",
+        },
       }
     end
 
     def make_rate_limit_error
       {
-        :error => {
-          :type => "invalid_request_error",
-          :message => "Too many requests in a period of time."
-        }
+        error: {
+          type: "invalid_request_error",
+          message: "Too many requests in a period of time.",
+        },
       }
     end
 
     def make_api_error
       {
-        :error => {
-          :type => "api_error"
-        }
+        error: {
+          type: "api_error",
+        },
       }
     end
   end

data/test/test_helper.rb

@@ -1,17 +1,17 @@
-require 'stripe'
-require 'test/unit'
-require 'mocha/setup'
-require 'stringio'
-require 'shoulda/context'
+require "stripe"
+require "test/unit"
+require "mocha/setup"
+require "stringio"
+require "shoulda/context"
 require "timecop"
-require 'webmock/test_unit'
+require "webmock/test_unit"
 
 PROJECT_ROOT = File.expand_path("../../", __FILE__)
 
-require File.expand_path('../test_data', __FILE__)
+require File.expand_path("../test_data", __FILE__)
 
-MOCK_MINIMUM_VERSION = "0.1.12"
-MOCK_PORT = ENV["STRIPE_MOCK_PORT"] || 12111
+MOCK_MINIMUM_VERSION = "0.2.0".freeze
+MOCK_PORT = ENV["STRIPE_MOCK_PORT"] || 12_111
 
 # Disable all real network connections except those that are outgoing to
 # stripe-mock.
@@ -22,9 +22,9 @@ WebMock.disable_net_connect!(allow: "localhost:#{MOCK_PORT}")
 # they should fix the problem.
 begin
   resp = Faraday.get("http://localhost:#{MOCK_PORT}/")
-  version = resp.headers['Stripe-Mock-Version']
+  version = resp.headers["Stripe-Mock-Version"]
   if version != "master" &&
-      Gem::Version.new(version) < Gem::Version.new(MOCK_MINIMUM_VERSION)
+     Gem::Version.new(version) < Gem::Version.new(MOCK_MINIMUM_VERSION)
     abort("Your version of stripe-mock (#{version}) is too old. The minimum " \
       "version to run this test suite is #{MOCK_MINIMUM_VERSION}. Please " \
       "see its repository for upgrade instructions.")
@@ -34,23 +34,27 @@ rescue Faraday::ConnectionFailed
     "it running? Please see README for setup instructions.")
 end
 
-class Test::Unit::TestCase
-  include Stripe::TestData
-  include Mocha
+module Test
+  module Unit
+    class TestCase
+      include Stripe::TestData
+      include Mocha
 
-  setup do
-    Stripe.api_key = "sk_test_123"
-    Stripe.api_base = "http://localhost:#{MOCK_PORT}"
-    stub_connect
-  end
+      setup do
+        Stripe.api_key = "sk_test_123"
+        Stripe.api_base = "http://localhost:#{MOCK_PORT}"
+        stub_connect
+      end
 
-  teardown do
-    Stripe.api_key = nil
-  end
+      teardown do
+        Stripe.api_key = nil
+      end
 
-  private
+      private
 
-  def stub_connect
-    stub_request(:any, /^#{Stripe.connect_base}/).to_return(:body => "{}")
+      def stub_connect
+        stub_request(:any, /^#{Stripe.connect_base}/).to_return(body: "{}")
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.4.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-20 00:00:00.000000000 Z
+date: 2017-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.10'
 description: Stripe is the easiest way to accept payments online.  See https://stripe.com
   for details.
 email: support@stripe.com
@@ -35,6 +35,8 @@ files:
 - ".gitattributes"
 - ".github/ISSUE_TEMPLATE.md"
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CONTRIBUTORS
 - Gemfile
@@ -112,8 +114,6 @@ files:
 - test/stripe/application_fee_test.rb
 - test/stripe/balance_test.rb
 - test/stripe/bank_account_test.rb
-- test/stripe/bitcoin_receiver_test.rb
-- test/stripe/bitcoin_transaction_test.rb
 - test/stripe/charge_test.rb
 - test/stripe/country_spec_test.rb
 - test/stripe/coupon_test.rb
@@ -134,7 +134,6 @@ files:
 - test/stripe/payout_test.rb
 - test/stripe/plan_test.rb
 - test/stripe/product_test.rb
-- test/stripe/recipient_card_test.rb
 - test/stripe/recipient_test.rb
 - test/stripe/refund_test.rb
 - test/stripe/reversal_test.rb
@@ -187,8 +186,6 @@ test_files:
 - test/stripe/application_fee_test.rb
 - test/stripe/balance_test.rb
 - test/stripe/bank_account_test.rb
-- test/stripe/bitcoin_receiver_test.rb
-- test/stripe/bitcoin_transaction_test.rb
 - test/stripe/charge_test.rb
 - test/stripe/country_spec_test.rb
 - test/stripe/coupon_test.rb
@@ -209,7 +206,6 @@ test_files:
 - test/stripe/payout_test.rb
 - test/stripe/plan_test.rb
 - test/stripe/product_test.rb
-- test/stripe/recipient_card_test.rb
 - test/stripe/recipient_test.rb
 - test/stripe/refund_test.rb
 - test/stripe/reversal_test.rb

data/test/stripe/bitcoin_receiver_test.rb

@@ -1,67 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-module Stripe
-  class BitcoinReceiverTest < Test::Unit::TestCase
-    should "be listable" do
-      receivers = Stripe::BitcoinReceiver.list
-      assert_requested :get, "#{Stripe.api_base}/v1/bitcoin/receivers"
-      assert receivers.data.kind_of?(Array)
-      assert receivers.first.kind_of?(Stripe::BitcoinReceiver)
-    end
-
-    should "be retrievable" do
-      receiver = Stripe::BitcoinReceiver.retrieve("btcrcv_123")
-      assert_requested :get,
-        "#{Stripe.api_base}/v1/bitcoin/receivers/btcrcv_123"
-      assert receiver.kind_of?(Stripe::BitcoinReceiver)
-    end
-
-    should "be creatable" do
-      receiver = Stripe::BitcoinReceiver.create(amount: 100, currency: "USD")
-      assert_requested :post, "#{Stripe.api_base}/v1/bitcoin/receivers"
-      assert receiver.kind_of?(Stripe::BitcoinReceiver)
-    end
-
-    should "be saveable" do
-      receiver = Stripe::BitcoinReceiver.retrieve("btcrcv_123")
-      receiver.metadata['key'] = 'value'
-      receiver.save
-      assert_requested :post,
-        "#{Stripe.api_base}/v1/bitcoin/receivers/#{receiver.id}"
-    end
-
-    should "be updateable" do
-      receiver = Stripe::BitcoinReceiver.update("btcrcv_123", metadata: { key: 'value' })
-      assert_requested :post,
-        "#{Stripe.api_base}/v1/bitcoin/receivers/btcrcv_123"
-      assert receiver.kind_of?(Stripe::BitcoinReceiver)
-    end
-
-    should "be deletable" do
-      receiver = Stripe::BitcoinReceiver.retrieve("btcrcv_123")
-      receiver = receiver.delete
-      assert_requested :delete,
-        "#{Stripe.api_base}/v1/bitcoin/receivers/#{receiver.id}"
-      assert receiver.kind_of?(Stripe::BitcoinReceiver)
-    end
-
-    context "#resource_url" do
-      should "return a customer URL" do
-        receiver = Stripe::BitcoinReceiver.construct_from(
-          customer: "cus_123",
-          id: "btcrcv_123",
-        )
-        assert_equal "/v1/customers/cus_123/sources/btcrcv_123",
-          receiver.resource_url
-      end
-
-      should "return an absolute URL" do
-        receiver = Stripe::BitcoinReceiver.construct_from(
-          id: "btcrcv_123",
-        )
-        assert_equal "/v1/bitcoin/receivers/btcrcv_123",
-          receiver.resource_url
-      end
-    end
-  end
-end

data/test/stripe/bitcoin_transaction_test.rb

@@ -1,19 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-module Stripe
-  class BitcoinTransactionTest < Test::Unit::TestCase
-    should "be listable" do
-      transactions = Stripe::BitcoinTransaction.list
-      assert_requested :get, "#{Stripe.api_base}/v1/bitcoin/transactions"
-      assert transactions.data.kind_of?(Array)
-      assert transactions.first.kind_of?(Stripe::BitcoinTransaction)
-    end
-
-    should "be retrievable" do
-      transaction = Stripe::BitcoinTransaction.retrieve("btctxn_123")
-      assert_requested :get,
-        "#{Stripe.api_base}/v1/bitcoin/transactions/btctxn_123"
-      assert transaction.kind_of?(Stripe::BitcoinTransaction)
-    end
-  end
-end

data/test/stripe/recipient_card_test.rb

@@ -1,44 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-module Stripe
-  class RecipientCardTest < Test::Unit::TestCase
-    setup do
-      @recipient = Stripe::Recipient.retrieve("rp_123")
-    end
-
-    should "be listable" do
-      cards = @recipient.cards.list
-      assert cards.data.kind_of?(Array)
-      assert cards.data[0].kind_of?(Stripe::Card)
-    end
-
-    should "be creatable" do
-      card = @recipient.cards.create(
-        card: "tok_123"
-      )
-      assert_requested :post, "#{Stripe.api_base}/v1/recipients/#{@recipient.id}/cards"
-      assert card.kind_of?(Stripe::Card)
-    end
-
-    should "be deletable" do
-      card = Stripe::Card.construct_from({
-        id: "card_123",
-        recipient: @recipient.id
-      })
-      card = card.delete
-      assert_requested :delete, "#{Stripe.api_base}/v1/recipients/#{@recipient.id}/cards/card_123"
-      assert card.kind_of?(Stripe::Card)
-    end
-
-    should "be saveable" do
-      card = Stripe::Card.construct_from({
-        id: "card_123",
-        metadata: {},
-        recipient: @recipient.id
-      })
-      card.metadata['key'] = 'value'
-      card.save
-      assert_requested :post, "#{Stripe.api_base}/v1/recipients/#{@recipient.id}/cards/card_123"
-    end
-  end
-end