stripe 3.3.2 → 3.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7556ff46c0830dc8802c25c59273daac90b0529a
-  data.tar.gz: 3fcb48558368c256fa0dd205b8c3590740e72bdb
+  metadata.gz: ce403b39d687753c9cf663b0288dfa87c0d42587
+  data.tar.gz: c070e94e6a67f23ba5c0cdcc4f20cf8b48003a56
 SHA512:
-  metadata.gz: 6df92106f55a4e3e55f61a64637fc3b6f348fcc1cf3d492c08cf490b1d6a205d646d0657eeabaf4ee09e7a7d46916c6a532d8e137c9a80b4a737d6bde20e61f9
-  data.tar.gz: b19388725051c6a8164712111d47af59556b3bf9a11047d26ec53ceec1e59611d2b3006d7f8a9be52de6d7f42cad0617fd81a29dcdebbf75ed290d850f5e5905
+  metadata.gz: ae59948a1870bddb75f90057936a65903157625ee4dc42d00b72aad628d0dbe0ee92e81a9dbe9efd55c12b57a7b5dd7f7988fdb282862a8fcd204c927574148a
+  data.tar.gz: 45fd78747f6151a4fa74b64c0bdf6f89e6d68fc9735e1a694fa75c0df46812032b41ac82589bff93ae6fb68022d57089c420ff929ab202a9699d287679b650ab

data/.gitignore

@@ -3,3 +3,4 @@
 .rvmrc
 Gemfile.lock
 tags
+/.bundle/

data/.rubocop.yml

@@ -0,0 +1,20 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  DisplayCopNames: true
+  TargetRubyVersion: 2.0
+
+Layout/CaseIndentation:
+  EnforcedStyle: end
+
+Layout/IndentArray:
+  EnforcedStyle: consistent
+
+Layout/IndentHash:
+  EnforcedStyle: consistent
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/TrailingCommaInLiteral:
+  EnforcedStyleForMultiline: consistent_comma

data/.rubocop_todo.yml

@@ -0,0 +1,62 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-09-27 21:19:01 +0200 using RuboCop version 0.50.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 18
+Metrics/AbcSize:
+  Max: 49
+
+# Offense count: 22
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 461
+
+# Offense count: 8
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 581
+
+# Offense count: 8
+Metrics/CyclomaticComplexity:
+  Max: 13
+
+# Offense count: 216
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 312
+
+# Offense count: 29
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 47
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 423
+
+# Offense count: 6
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 7
+
+# Offense count: 5
+Metrics/PerceivedComplexity:
+  Max: 11
+  Exclude:
+    - 'lib/stripe/stripe_object.rb'
+
+# Offense count: 2
+Style/ClassVars:
+  Exclude:
+    - 'lib/stripe/stripe_object.rb'
+    - 'test/stripe/api_resource_test.rb'
+
+# Offense count: 51
+Style/Documentation:
+  Enabled: false

data/.travis.yml

@@ -16,7 +16,7 @@ sudo: false
 
 env:
   global:
-    - STRIPE_MOCK_VERSION=0.1.12
+    - STRIPE_MOCK_VERSION=0.2.0
 
 cache:
   directories:

data/Gemfile

@@ -3,29 +3,36 @@ source "https://rubygems.org"
 gemspec
 
 group :development do
-  gem 'mocha', '~> 0.13.2'
-  gem 'rake'
-  gem 'shoulda-context'
-  gem 'test-unit'
-  gem 'timecop'
-  gem 'webmock'
+  gem "mocha", "~> 0.13.2"
+  gem "rake"
+  gem "shoulda-context"
+  gem "test-unit"
+  gem "timecop"
+  gem "webmock"
+
+  # Rubocop changes pretty quickly: new cops get added and old cops change
+  # names or go into new namespaces. This is a library and we don't have
+  # `Gemfile.lock` checked in, so to prevent good builds from suddenly going
+  # bad, pin to a specific version number here. Try to keep this relatively
+  # up-to-date, but it's not the end of the world if it's not.
+  gem "rubocop", "0.50.0"
 
   # Rack 2.0+ requires Ruby >= 2.2.2 which is problematic for the test suite on
   # older Ruby versions. Check Ruby the version here and put a maximum
   # constraint on Rack if necessary.
-  if RUBY_VERSION >= '2.2.2'
+  if RUBY_VERSION >= "2.2.2"
     gem "rack", ">= 1.5"
   else
-    gem "rack", ">= 1.5", "< 2.0"
+    gem "rack", ">= 1.5", "< 2.0" # rubocop:disable Bundler/DuplicatedGem
   end
 
   platforms :mri do
     # to avoid problems, bring Byebug in on just versions of Ruby under which
     # it's known to work well
-    if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.0.0')
-      gem 'byebug'
-      gem 'pry'
-      gem 'pry-byebug'
+    if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new("2.0.0")
+      gem "byebug"
+      gem "pry"
+      gem "pry-byebug"
     end
   end
 end

data/History.txt

@@ -1,3 +1,13 @@
+=== 3.4.1 2017-10-05
+
+* [#586] Log query strings as well as form bodies with STRIPE_LOG
+* [#588] Require minimum Faraday 0.10 for bug fix in parameter encoding
+
+=== 3.4.0 2017-09-20
+
+* Mark legacy Bitcoin API as deprecated, and remove corresponding tests
+* Mark recipients API as deprecated, and remove recipient card tests
+
 === 3.3.2 2017-09-20
 
 * Correct minimum required Ruby version in gemspec (it's 2.0.0)

data/README.md

@@ -174,7 +174,7 @@ instructions for installing via Homebrew and other methods):
 
 Run all tests:
 
-    bundle exec rake
+    bundle exec rake test
 
 Run a single test suite:
 
@@ -184,6 +184,10 @@ Run a single test:
 
     bundle exec ruby -Ilib/ test/stripe/util_test.rb -n /should.convert.names.to.symbols/
 
+Run the linter:
+
+    bundle exec rake rubocop
+
 Update bundled CA certificates from the [Mozilla cURL release][curl]:
 
     bundle exec rake update_certs

data/Rakefile

@@ -1,17 +1,20 @@
-require 'rake/testtask'
+require "rake/testtask"
+require "rubocop/rake_task"
 
-task :default => [:test]
+task default: %i[test rubocop]
 
 Rake::TestTask.new do |t|
-  t.pattern = './test/**/*_test.rb'
+  t.pattern = "./test/**/*_test.rb"
 end
 
+RuboCop::RakeTask.new
+
 desc "Update bundled certs"
 task :update_certs do
   require "faraday"
 
   fetch_file "https://curl.haxx.se/ca/cacert.pem",
-    File.expand_path("../lib/data/ca-certificates.crt", __FILE__)
+             File.expand_path("../lib/data/ca-certificates.crt", __FILE__)
 end
 
 #
@@ -19,7 +22,7 @@ end
 #
 
 def fetch_file(url, dest)
-  File.open(dest, 'w') do |file|
+  File.open(dest, "w") do |file|
     resp = Faraday.get(url)
     unless resp.status == 200
       abort("bad response when fetching: #{url}\n" \

data/VERSION

@@ -1 +1 @@
-3.3.2
+3.4.1

data/bin/stripe-console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require 'irb'
-require 'irb/completion'
+require "irb"
+require "irb/completion"
 
 require "#{File.dirname(__FILE__)}/../lib/stripe"
 

data/lib/stripe.rb

@@ -1,88 +1,89 @@
 # Stripe Ruby bindings
 # API spec at https://stripe.com/docs/api
-require 'cgi'
-require 'logger'
-require 'openssl'
-require 'rbconfig'
-require 'set'
-require 'socket'
+require "cgi"
+require "logger"
+require "openssl"
+require "rbconfig"
+require "securerandom"
+require "set"
+require "socket"
 
-require 'faraday'
-require 'json'
+require "faraday"
+require "json"
 
 # Version
-require 'stripe/version'
+require "stripe/version"
 
 # API operations
-require 'stripe/api_operations/create'
-require 'stripe/api_operations/save'
-require 'stripe/api_operations/delete'
-require 'stripe/api_operations/list'
-require 'stripe/api_operations/request'
+require "stripe/api_operations/create"
+require "stripe/api_operations/save"
+require "stripe/api_operations/delete"
+require "stripe/api_operations/list"
+require "stripe/api_operations/request"
 
 # API resource support classes
-require 'stripe/errors'
-require 'stripe/util'
-require 'stripe/stripe_client'
-require 'stripe/stripe_object'
-require 'stripe/stripe_response'
-require 'stripe/list_object'
-require 'stripe/api_resource'
-require 'stripe/singleton_api_resource'
-require 'stripe/webhook'
+require "stripe/errors"
+require "stripe/util"
+require "stripe/stripe_client"
+require "stripe/stripe_object"
+require "stripe/stripe_response"
+require "stripe/list_object"
+require "stripe/api_resource"
+require "stripe/singleton_api_resource"
+require "stripe/webhook"
 
 # Named API resources
-require 'stripe/account'
-require 'stripe/alipay_account'
-require 'stripe/apple_pay_domain'
-require 'stripe/application_fee'
-require 'stripe/application_fee_refund'
-require 'stripe/balance'
-require 'stripe/balance_transaction'
-require 'stripe/bank_account'
-require 'stripe/bitcoin_receiver'
-require 'stripe/bitcoin_transaction'
-require 'stripe/card'
-require 'stripe/charge'
-require 'stripe/country_spec'
-require 'stripe/coupon'
-require 'stripe/customer'
-require 'stripe/dispute'
-require 'stripe/ephemeral_key'
-require 'stripe/event'
-require 'stripe/file_upload'
-require 'stripe/invoice'
-require 'stripe/invoice_item'
-require 'stripe/invoice_line_item'
-require 'stripe/login_link'
-require 'stripe/order'
-require 'stripe/order_return'
-require 'stripe/payout'
-require 'stripe/plan'
-require 'stripe/product'
-require 'stripe/recipient'
-require 'stripe/recipient_transfer'
-require 'stripe/refund'
-require 'stripe/reversal'
-require 'stripe/sku'
-require 'stripe/source'
-require 'stripe/subscription'
-require 'stripe/subscription_item'
-require 'stripe/three_d_secure'
-require 'stripe/token'
-require 'stripe/transfer'
+require "stripe/account"
+require "stripe/alipay_account"
+require "stripe/apple_pay_domain"
+require "stripe/application_fee"
+require "stripe/application_fee_refund"
+require "stripe/balance"
+require "stripe/balance_transaction"
+require "stripe/bank_account"
+require "stripe/bitcoin_receiver"
+require "stripe/bitcoin_transaction"
+require "stripe/card"
+require "stripe/charge"
+require "stripe/country_spec"
+require "stripe/coupon"
+require "stripe/customer"
+require "stripe/dispute"
+require "stripe/ephemeral_key"
+require "stripe/event"
+require "stripe/file_upload"
+require "stripe/invoice"
+require "stripe/invoice_item"
+require "stripe/invoice_line_item"
+require "stripe/login_link"
+require "stripe/order"
+require "stripe/order_return"
+require "stripe/payout"
+require "stripe/plan"
+require "stripe/product"
+require "stripe/recipient"
+require "stripe/recipient_transfer"
+require "stripe/refund"
+require "stripe/reversal"
+require "stripe/sku"
+require "stripe/source"
+require "stripe/subscription"
+require "stripe/subscription_item"
+require "stripe/three_d_secure"
+require "stripe/token"
+require "stripe/transfer"
 
 # OAuth
-require 'stripe/oauth'
+require "stripe/oauth"
 
 module Stripe
-  DEFAULT_CA_BUNDLE_PATH = File.dirname(__FILE__) + '/data/ca-certificates.crt'
+  DEFAULT_CA_BUNDLE_PATH = File.dirname(__FILE__) + "/data/ca-certificates.crt"
 
   @app_info = nil
 
-  @api_base = 'https://api.stripe.com'
-  @connect_base = 'https://connect.stripe.com'
-  @uploads_base = 'https://uploads.stripe.com'
+  @api_base = "https://api.stripe.com"
+  @connect_base = "https://connect.stripe.com"
+  @uploads_base = "https://uploads.stripe.com"
 
   @log_level = nil
   @logger = nil
@@ -170,7 +171,7 @@ module Stripe
       val = LEVEL_INFO
     end
 
-    if val != nil && ![LEVEL_DEBUG, LEVEL_ERROR, LEVEL_INFO].include?(val)
+    if !val.nil? && ![LEVEL_DEBUG, LEVEL_ERROR, LEVEL_INFO].include?(val)
       raise ArgumentError, "log_level should only be set to `nil`, `debug` or `info`"
     end
     @log_level = val
@@ -212,18 +213,15 @@ module Stripe
     }
   end
 
-  private
-
   # DEPRECATED. Use `Util#encode_parameters` instead.
   def self.uri_encode(params)
     Util.encode_parameters(params)
   end
+  private_class_method :uri_encode
   class << self
     extend Gem::Deprecate
-    deprecate :uri_encode, "Stripe::Util#encode_parameters", 2016, 01
+    deprecate :uri_encode, "Stripe::Util#encode_parameters", 2016, 1
   end
 end
 
-unless ENV["STRIPE_LOG"].nil?
-  Stripe.log_level = ENV["STRIPE_LOG"]
-end
+Stripe.log_level = ENV["STRIPE_LOG"] unless ENV["STRIPE_LOG"].nil?

data/lib/stripe/account.rb

@@ -6,7 +6,7 @@ module Stripe
     include Stripe::APIOperations::Delete
     include Stripe::APIOperations::Save
 
-    OBJECT_NAME = 'account'
+    OBJECT_NAME = "account".freeze
 
     save_nested_resource :external_account
 
@@ -15,7 +15,7 @@ module Stripe
     deprecate :bank_account=, "#external_account=", 2017, 8
 
     def resource_url
-      if self['id']
+      if self["id"]
         super
       else
         "/v1/account"
@@ -23,13 +23,13 @@ module Stripe
     end
 
     # @override To make id optional
-    def self.retrieve(id=ARGUMENT_NOT_PROVIDED, opts={})
+    def self.retrieve(id = ARGUMENT_NOT_PROVIDED, opts = {})
       id = id.equal?(ARGUMENT_NOT_PROVIDED) ? nil : Util.check_string_argument!(id)
 
       # Account used to be a singleton, where this method's signature was
       # `(opts={})`. For the sake of not breaking folks who pass in an OAuth
       # key in opts, let's lurkily string match for it.
-      if opts == {} && id.is_a?(String) && id.start_with?('sk_')
+      if opts == {} && id.is_a?(String) && id.start_with?("sk_")
         # `super` properly assumes a String opts is the apiKey and normalizes as expected.
         opts = id
         id = nil
@@ -37,9 +37,9 @@ module Stripe
       super(id, opts)
     end
 
-    def reject(params={}, opts={})
+    def reject(params = {}, opts = {})
       opts = Util.normalize_opts(opts)
-      resp, opts = request(:post, resource_url + '/reject', params, opts)
+      resp, opts = request(:post, resource_url + "/reject", params, opts)
       initialize_from(resp.data, opts)
     end
 
@@ -70,9 +70,9 @@ module Stripe
       serialize_params_account(self, super)
     end
 
-    def serialize_params_account(obj, update_hash)
-      if entity = @values[:legal_entity]
-        if owners = entity[:additional_owners]
+    def serialize_params_account(_obj, update_hash)
+      if (entity = @values[:legal_entity])
+        if (owners = entity[:additional_owners])
           entity_update = update_hash[:legal_entity] ||= {}
           entity_update[:additional_owners] =
             serialize_additional_owners(entity, owners)
@@ -86,17 +86,17 @@ module Stripe
     end
 
     def legal_entity
-      self['legal_entity']
+      self["legal_entity"]
     end
 
     def legal_entity=(_)
-      raise NoMethodError.new('Overridding legal_entity can cause serious issues. Instead, set the individual fields of legal_entity like blah.legal_entity.first_name = \'Blah\'')
+      raise NoMethodError, 'Overridding legal_entity can cause serious issues. Instead, set the individual fields of legal_entity like blah.legal_entity.first_name = \'Blah\''
     end
 
-    def deauthorize(client_id=nil, opts={})
+    def deauthorize(client_id = nil, opts = {})
       params = {
         client_id: client_id,
-        stripe_user_id: self.id,
+        stripe_user_id: id,
       }
       OAuth.deauthorize(params, opts)
     end
@@ -111,9 +111,7 @@ module Stripe
         # url params provide no mechanism for deleting an item in an array,
         # just overwriting the whole array or adding new items. So let's not
         # allow deleting without a full overwrite until we have a solution.
-        raise ArgumentError.new(
-          "You cannot delete an item from an array, you must instead set a new array"
-        )
+        raise ArgumentError, "You cannot delete an item from an array, you must instead set a new array"
       end
 
       update_hash = {}
@@ -127,7 +125,7 @@ module Stripe
 
         if update != {} && (!original_value ||
           update != legal_entity.serialize_params_value(original_value[i], nil, false, true))
-            update_hash[i.to_s] = update
+          update_hash[i.to_s] = update
         end
       end
       update_hash