stripe 17.0.1 → 19.0.0

data/lib/stripe/stripe_client.rb

@@ -68,6 +68,12 @@ module Stripe
 
       parsed = JSON.parse(payload, symbolize_names: true)
 
+      if parsed[:object] == "event"
+        raise ArgumentError,
+              "You passed a webhook payload to StripeClient#parse_event_notification, which " \
+              "expects an event notification. Use Webhook.construct_event instead."
+      end
+
       cls = Util.event_notification_classes.fetch(parsed[:type], Stripe::Events::UnknownEventNotification)
 
       cls.new(parsed, self)

data/lib/stripe/stripe_object.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "bigdecimal"
+
 module Stripe
   class StripeObject
     include Enumerable
@@ -155,6 +157,9 @@ module Stripe
       values.each do |k, v|
         add_accessors([k], values) unless metaclass.method_defined?(k.to_sym)
         @values[k] = convert_value_with_inner_types(k, v, opts)
+        if self.class.field_encodings[k.to_sym] == :decimal_string && @values[k].is_a?(String)
+          @values[k] = BigDecimal(@values[k])
+        end
         dirty_value!(@values[k]) if dirty
         @unsaved_values.add(k)
       end
@@ -171,7 +176,19 @@ module Stripe
     end
 
     def [](key)
-      @values[key.to_sym]
+      key_sym = key.to_sym
+      return @values[key_sym] if @values.key?(key_sym)
+
+      # super specific one-off case to help users debug this property disappearing
+      # see also: https://go/j/DEVSDK-2835
+      if is_a?(Invoice) && key_sym == :payment_intent
+        raise KeyError,
+              "The 'payment_intent' attribute is no longer available on Invoice objects. " \
+              "See the docs for more details: https://docs.stripe.com/changelog/basil/2025-03-31/" \
+              "add-support-for-multiple-partial-payments-on-invoices#why-is-this-a-breaking-change"
+      end
+
+      nil
     end
 
     def []=(key, value)
@@ -432,6 +449,23 @@ module Stripe
       begin
         super
       rescue NoMethodError => e
+        # super specific one-off case to help users debug this property disappearing
+        # see also: https://go/j/DEVSDK-2835
+        if is_a?(Invoice) && name == :payment_intent
+          raise NoMethodError,
+                "\n\n" \
+                "-----------------\n " \
+                "BREAKING CHANGE \n" \
+                "-----------------\n" \
+                "The 'payment_intent' attribute is no longer available on Invoice objects.\n\n" \
+                "See the docs for more details:\n" \
+                "https://docs.stripe.com/changelog/basil/2025-03-31/" \
+                "add-support-for-multiple-partial-payments-on-invoices#why-is-this-a-breaking-change\n" \
+                "-----------------\n " \
+                "BREAKING CHANGE \n" \
+                "-----------------" \
+        end
+
         # If we notice the accessed name of our set of transient values we can
         # give the user a slightly more helpful error message. If not, just
         # raise right away.
@@ -650,5 +684,9 @@ module Stripe
     def self.field_remappings
       @field_remappings ||= {}
     end
+
+    def self.field_encodings
+      @field_encodings ||= {}
+    end
   end
 end

data/lib/stripe/util.rb

@@ -4,19 +4,22 @@ require "cgi"
 
 module Stripe
   module Util
-    LEGAL_FIRST_CHARACTER = /[a-zA-Z_]/.freeze
-    LEGAL_VARIABLE_CHARACTER = /[a-zA-Z0-9_]/.freeze
-
-    def self.objects_to_ids(obj)
+    def self.objects_to_ids(obj, serialize_empty: false)
       case obj
       when APIResource
         obj.id
       when Hash
         res = {}
-        obj.each { |k, v| res[k] = objects_to_ids(v) unless v.nil? }
+        obj.each do |k, v|
+          if !v.nil?
+            res[k] = objects_to_ids(v, serialize_empty: serialize_empty)
+          elsif serialize_empty
+            res[k] = nil
+          end
+        end
         res
       when Array
-        obj.map { |v| objects_to_ids(v) }
+        obj.map { |v| objects_to_ids(v, serialize_empty: serialize_empty) }
       else
         obj
       end
@@ -275,11 +278,8 @@ module Stripe
         elsif elem.is_a?(Array)
           result += flatten_params_array(elem, api_mode, calculated_key)
         else
-          result << if api_mode == :v2
-                      [calculated_key, elem]
-                    else
-                      ["#{calculated_key}[#{i}]", elem]
-                    end
+          # Always use indexed format for arrays
+          result << ["#{calculated_key}[#{i}]", elem]
         end
       end
       result
@@ -326,9 +326,7 @@ module Stripe
     # Return false for strings that are invalid variable names
     # Does NOT expect there to be a preceding '@' for instance variables
     def self.valid_variable_name?(key)
-      return false if key.empty? || key[0] !~ LEGAL_FIRST_CHARACTER
-
-      key[1..].chars.all? { |char| char =~ LEGAL_VARIABLE_CHARACTER }
+      key.match?(/\A[a-zA-Z_]\w*\z/)
     end
 
     def self.check_string_argument!(key)

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "17.0.1"
+  VERSION = "19.0.0"
 end

data/lib/stripe/webhook.rb

@@ -18,6 +18,13 @@ module Stripe
       # doesn't GC symbols. It also decreases the likelihood that we receive a
       # bad payload that fails to parse and throws an exception.
       data = JSON.parse(payload, symbolize_names: true)
+
+      if data[:object] == "v2.core.event"
+        raise ArgumentError,
+              "You passed an event notification to Webhook.construct_event, which expects " \
+              "a webhook payload. Use StripeClient#parse_event_notification instead."
+      end
+
       Event.construct_from(data, {}, nil, :v1, APIRequestor.active_requestor)
     end
 

data/lib/stripe.rb

@@ -2,7 +2,7 @@
 
 # Stripe Ruby bindings
 # API spec at https://stripe.com/docs/api
-require "cgi"
+require "cgi/escape"
 require "json"
 require "logger"
 require "net/http"