stockboy 0.7.0 → 0.7.1

data/spec/stockboy/providers/http_spec.rb

@@ -93,22 +93,13 @@ module Stockboy
         provider.username = "username"
         provider.password = "password"
 
-        allow(HTTPI).to receive(:request) { response }
+        expect(HTTPI).to receive(:request) { response }
         expect_any_instance_of(HTTPI::Auth::Config).to receive(:basic).with("username", "password")
 
         provider.data.should == '{"success":true}'
       end
     end
 
-    describe "#client" do
-      it "yields a generic HTTP interface" do
-        provider.client do |http|
-          http.should respond_to :get
-          http.should respond_to :post
-        end
-      end
-    end
-
   end
 end
 

data/spec/stockboy/providers/imap/search_options_spec.rb

@@ -28,8 +28,19 @@ module Stockboy::Providers
 
       DATE_OPTIONS.each do |date_option_symbol, date_option_imap|
         it "converts #{date_option_imap.inspect} to IMAP date option" do
-          options(date_option_symbol => Time.new(2012, 12, 12))
-            .to_imap.should == [date_option_imap, "12-DEC-2012"]
+          options(date_option_symbol => TIME_FORMATS.first)
+          .to_imap.should == [date_option_imap, "12-DEC-2012"]
+        end
+      end
+
+      TIME_FORMATS = [ t = Time.new(2012, 12, 12),
+                       t.to_i,
+                       t.to_s ]
+
+      TIME_FORMATS.each do |time|
+        it "converts #{time.class} to IMAP date option" do
+          options(since: time)
+          .to_imap.should == ["SINCE", "12-DEC-2012"]
         end
       end
 

data/spec/stockboy/providers/imap_spec.rb

@@ -57,14 +57,92 @@ module Stockboy
     end
 
     describe "#data" do
+      let(:imap) { double("Net::IMAP") }
+      let(:provider) { described_class.new(host: 'h', username: 'u', password: 'p') }
+      subject(:data) { provider.data }
+      before { allow(provider).to receive(:client).and_yield imap }
 
       context "with no messages found" do
-        it "should be nil" do
-          allow(provider).to receive(:fetch_imap_message_keys).and_return []
-          provider.data.should be_nil
+        before { mock_imap_search [] => [] }
+        it { should be_nil }
+      end
+
+      context "with a found message" do
+        let(:rfc_email) { File.read(fixture_path "email/csv_attachment.eml") }
+        before { mock_imap_search [] => [1] and mock_imap_fetch 1 => rfc_email }
+        it { should match "LAST_NAME,FIRST_NAME" }
+
+        context "validating correct filename string" do
+          before { provider.attachment = "daily_report.csv" }
+          it { should match "LAST_NAME,FIRST_NAME" }
+        end
+
+        context "validating incorrect filename string" do
+          before { provider.attachment = "wrong_report.csv" }
+          it { should be_nil }
+        end
+
+        context "validating correct filename pattern" do
+          before { provider.attachment = /^daily.*\.csv$/ }
+          it { should match "LAST_NAME,FIRST_NAME" }
+        end
+
+        context "validating incorrect filename pattern" do
+          before { provider.attachment = /^wrong.*\.csv$/ }
+          it { should be_nil }
+        end
+
+        context "validating correct smaller size" do
+          before { provider.smaller_than = 2048 }
+          it { should match "LAST_NAME,FIRST_NAME" }
+        end
+
+        context "validating incorrect smaller size" do
+          before { provider.smaller_than = 10 }
+          it { should be_nil }
         end
+
+        context "validating correct larger size" do
+          before { provider.larger_than = 10 }
+          it { should match "LAST_NAME,FIRST_NAME" }
+        end
+
+        context "validating correct larger size" do
+          before { provider.larger_than = 2048 }
+          it { should be_nil }
+        end
+
       end
 
+      context "with a found message since time" do
+        let(:rfc_email) { File.read fixture_path('email/csv_attachment.eml') }
+        before {
+          provider.since = Time.new(2014, 1, 31)
+          mock_imap_search ["SINCE", "31-JAN-2014"] => [1]
+          mock_imap_fetch 1 => rfc_email
+        }
+        it { should match "LAST_NAME,FIRST_NAME" }
+
+        context "without ActiveSupport" do
+          before { allow_any_instance_of(DateTime).to receive(:respond_to?).with(:getutc) { false } }
+          it { should match "LAST_NAME,FIRST_NAME" }
+        end
+      end
+
+      def mock_imap_search(searches)
+        searches.each do |search_keys, found_keys|
+          sort_args = ['DATE'], search_keys, 'UTF-8'
+          expect(imap).to receive(:sort).with(*sort_args).and_return found_keys
+        end
+      end
+
+      def mock_imap_fetch(list)
+        list.each do |key, email|
+          expect(imap).to receive(:fetch).with(key, 'RFC822').and_return [
+            double("Net::IMAP::FetchData", attr: {'RFC822' => email})
+          ]
+        end
+      end
     end
 
     describe "#delete_data" do
@@ -74,11 +152,11 @@ module Stockboy
         expect { provider.delete_data }.to raise_error Stockboy::OutOfSequence
       end
 
-      it "should call delete on the matching message" do
+      it "should call delete on the message key" do
         allow(provider).to receive(:client).and_yield(imap)
         allow(provider).to receive(:search) { [5] }
 
-        provider.matching_message
+        provider.message_key
 
         expect(imap).to receive(:uid_store).with(5, "+FLAGS", [:Deleted])
         expect(imap).to receive(:expunge)

data/spec/stockboy/providers/soap_spec.rb

@@ -69,7 +69,7 @@ module Stockboy
 
     describe "#data" do
       let(:xml_success_fixture) do
-        File.read(RSpec.configuration.fixture_path.join "soap/get_list/success.xml")
+        File.read(fixture_path "soap/get_list/success.xml")
       end
 
       let(:provider) do

data/spec/stockboy/reader_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+require 'stockboy/reader'
+
+class BookReader < Stockboy::Reader
+  def parse(data)
+    data
+  end
+end
+
+class BathroomReader < Stockboy::Reader
+end
+
+module Stockboy
+  describe Reader do
+
+    describe "#initialize" do
+      subject(:reader) { BookReader.new(encoding: 'ISO-8859-1') }
+      its(:encoding) { should == 'ISO-8859-1' }
+    end
+
+    it "warns of a missing subclass implementation" do
+      expect { BathroomReader.new.parse(double) }.to raise_error NoMethodError
+    end
+
+  end
+end

data/spec/stockboy/readers/spreadsheet_spec.rb

@@ -43,7 +43,7 @@ module Stockboy
     end
 
     describe "#parse" do
-      let(:content) { File.read(RSpec.configuration.fixture_path.join(fixture_file)) }
+      let(:content) { File.read(fixture_path fixture_file) }
 
       context "with an XLS file" do
         let(:fixture_file) { 'spreadsheets/test_data.xls' }

data/spec/stockboy/readers/xml_spec.rb

@@ -42,7 +42,7 @@ module Stockboy
 
     describe "#parse" do
 
-      let(:xml_file)    { RSpec.configuration.fixture_path.join "xml/body.xml" }
+      let(:xml_file)    { fixture_path "xml/body.xml" }
       let(:xml_string)  { File.read(xml_file) }
       let(:elements)    { ['MultiNamespacedEntryResponse', 'history', 'case'] }
       let(:output_keys) { ['logTime', 'logType', 'logText'] }

data/spec/stockboy/translations_spec.rb

@@ -41,6 +41,31 @@ module Stockboy
       end
     end
 
+    describe ".translator_for" do
+      it "returns a translator for a registered proc" do
+        Translations.register :test, ->(i){ i.message.upcase }
+        tr = Translations.translator_for(:message, :test)
+        tr.call(double message: "no!").should == "NO!"
+      end
+
+      it "returns a translator for a registered class" do
+        Translations.register :test, Translations::Integer
+        tr = Translations.translator_for :id, :test
+        tr.call(double id: "42").should == 42
+      end
+
+      it "returns a translator for a registered instance" do
+        Translations.register :test, Translations::Integer.new(:id)
+        tr = Translations.translator_for :anything, :test
+        tr.call(double id: "42").should == 42
+      end
+
+      it "returns a no-op for unrecognized translators" do
+        tr = Translations.translator_for :id, :fail
+        tr.call(double id: "42").should == "42"
+      end
+    end
+
     describe ".find" do
       it "returns a callable translator" do
         callable = ->(i){ i.upcase }

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: stockboy
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Andrew Vit
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-21 00:00:00.000000000 Z
+date: 2014-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: roo
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.12.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.12.2
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: httpi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 description: Supports importing data over various transports with key-value remapping
@@ -116,10 +116,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
-- .yardopts
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- ".yardopts"
 - CHANGELOG.md
 - Gemfile
 - Guardfile
@@ -177,6 +177,7 @@ files:
 - lib/stockboy/translator.rb
 - lib/stockboy/version.rb
 - spec/fixtures/.gitkeep
+- spec/fixtures/email/csv_attachment.eml
 - spec/fixtures/files/a_garbage.csv
 - spec/fixtures/files/test_data-20120101.csv
 - spec/fixtures/files/test_data-20120202.csv
@@ -208,6 +209,7 @@ files:
 - spec/stockboy/providers/imap_spec.rb
 - spec/stockboy/providers/soap_spec.rb
 - spec/stockboy/providers_spec.rb
+- spec/stockboy/reader_spec.rb
 - spec/stockboy/readers/csv_spec.rb
 - spec/stockboy/readers/fixed_width_spec.rb
 - spec/stockboy/readers/spreadsheet_spec.rb
@@ -241,22 +243,23 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: stockboy
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Multi-source data normalization library
 test_files:
 - spec/fixtures/.gitkeep
+- spec/fixtures/email/csv_attachment.eml
 - spec/fixtures/files/a_garbage.csv
 - spec/fixtures/files/test_data-20120101.csv
 - spec/fixtures/files/test_data-20120202.csv
@@ -288,6 +291,7 @@ test_files:
 - spec/stockboy/providers/imap_spec.rb
 - spec/stockboy/providers/soap_spec.rb
 - spec/stockboy/providers_spec.rb
+- spec/stockboy/reader_spec.rb
 - spec/stockboy/readers/csv_spec.rb
 - spec/stockboy/readers/fixed_width_spec.rb
 - spec/stockboy/readers/spreadsheet_spec.rb