stockboy 0.7.0 → 0.7.1

data/lib/stockboy/providers/imap/search_options.rb

@@ -97,7 +97,7 @@ module Stockboy::Providers
       when Numeric
         Time.at(value).strftime('%v')
       when String
-        value =~ VMS_DATE ? value : Date.parse(value).strftime('%v')
+        value =~ VMS_DATE ? value : Date.parse(value).strftime('%v').upcase!
       end
       pair
     end

data/lib/stockboy/providers/soap.rb

@@ -147,8 +147,8 @@ module Stockboy::Providers
     #
     def client
       @client ||= Savon.client(client_options)
-      return @client unless block_given?
-      yield @client
+      yield @client if block_given?
+      @client
     end
 
     private
@@ -159,6 +159,7 @@ module Stockboy::Providers
       elsif endpoint
         {endpoint: endpoint}
       end
+      opts[:logger] = logger
       opts[:convert_response_tags_to] = ->(tag) { string_pool(tag) }
       opts[:namespace] = namespace if namespace
       opts[:namespaces] = namespaces if namespaces

data/lib/stockboy/railtie.rb

@@ -17,6 +17,7 @@ class Railtie < Rails::Railtie
 
   initializer "stockboy.configure_rails_initialization" do
     Stockboy.configure do |config|
+      config.logger = Rails.logger
       config.template_load_paths = [Rails.root.join('config/stockboy_jobs')]
     end
 

data/lib/stockboy/reader.rb

@@ -24,6 +24,8 @@ module Stockboy
   class Reader
     extend Stockboy::DSL
 
+    attr_reader :encoding
+
     # Initialize a new reader
     #
     # @param [Hash] opts

data/lib/stockboy/readers/spreadsheet.rb

@@ -99,6 +99,7 @@ module Stockboy::Readers
       Tempfile.open(tmp_name, Stockboy.configuration.tmp_dir) do |file|
         file.binmode
         file.write content
+        file.fsync
         table = Roo::Spreadsheet.open(file.path, @roo_options)
         table.default_sheet = sheet_number(table, @sheet)
         table.header_line = @header_line if @header_line

data/lib/stockboy/registry.rb

@@ -39,14 +39,10 @@ module Stockboy
     end
 
     def build(key, options, block)
-      case key
-      when Symbol
-        find(key).new(options, &block)
-      when Class
-        key.new(options, &block)
-      else
-        key
-      end
+      options = [options] unless options.is_a? Array
+      key = find(key) if key.is_a? Symbol
+      key = key.new(*options, &block) if key.is_a? Class
+      key
     end
 
   end

data/lib/stockboy/version.rb

@@ -1,3 +1,3 @@
 module Stockboy
-  VERSION = "0.7.0"
+  VERSION = "0.7.1"
 end

data/spec/fixtures/email/csv_attachment.eml

@@ -0,0 +1,20 @@
+Date: Fri, 21 Mar 2014 12:34:56 -0700 (PDT)
+From: The Server <server@example.com>
+To: The App <app@example.com>
+Subject: Daily Report
+Content-Type: multipart/mixed; boundary="----=_Part_Boundary_"
+
+------=_Part_Boundary_
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: quoted-printable
+
+Here's the daily report.=20
+
+------=_Part_Boundary_
+Content-Type: text/csv; name="daily_report.csv"
+Content-Disposition: attachment; filename="daily_report.csv"
+
+LAST_NAME,FIRST_NAME
+Dent,Arthur
+Ford,Prefect
+------=_Part_Boundary_--

data/spec/spec_helper.rb

@@ -1,8 +1,23 @@
-if $DEBUG && !ENV['CI']
+if ENV['CI']
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+end
+
+if ENV['COVERAGE']
+  require 'simplecov'
+  SimpleCov.start do
+    add_filter "/spec/"
+    add_group "Providers", "/providers/"
+    add_group "Readers", "/readers/"
+    add_group "Translations", "/translations/"
+  end
+end
+
+if ENV['DEBUG']
   require 'pry'
-  require 'pry-debugger'
 end
 
+
 require 'ostruct'
 require 'savon'
 require 'savon/mock/spec_helper'
@@ -23,6 +38,13 @@ RSpec.configure do |config|
     end
   end
 
+  module Helpers
+    def fixture_path(*args)
+      RSpec.configuration.fixture_path.join(*args)
+    end
+  end
+
+  config.include Helpers
 end
 
 # VCR.configure do |c|

data/spec/stockboy/configurator_spec.rb

@@ -42,6 +42,15 @@ module Stockboy
       end
     end
 
+    describe "#repeat" do
+      it "registers an enumerator block" do
+        expect { subject.repeat }.to raise_error ArgumentError
+        subject.repeat do |output, provider|
+          output << provider
+        end
+      end
+    end
+
     describe "#reader" do
       before do
         Readers.register(:csv, reader_class)
@@ -123,25 +132,67 @@ module Stockboy
         end
         subject.config[:filters][:pass].call(42).should == true
       end
+
+      context "with a class" do
+        class TestFilter
+          attr_reader :args, :block
+          def initialize(*args, &block)
+            @args, @block = args, block
+          end
+        end
+        before { Filters.register :test, TestFilter }
+
+        it "passes arguments to a registered class symbol" do
+          subject.filter :pass, :test, 42
+          subject.config[:filters][:pass].args.should == [42]
+        end
+
+        it "passes a block to a registered class symbol" do
+          subject.filter :pass, :test do 42 end
+          subject.config[:filters][:pass].block[].should == 42
+        end
+
+        it "passes arguments to a given class" do
+          subject.filter :pass, TestFilter, 42
+          subject.config[:filters][:pass].args.should == [42]
+        end
+
+        it "uses an instance directly" do
+          subject.filter :pass, TestFilter.new(42)
+          subject.config[:filters][:pass].args.should == [42]
+        end
+      end
+
     end
 
     describe "#to_job" do
       before do
         Providers.register :test_prov, provider_class
         Readers.register :test_read, reader_class
-      end
-
-      it "returns a Job instance" do
         subject.provider :test_prov
         subject.reader :test_read
         subject.attributes &proc{}
+      end
 
+      it "returns a Job instance" do
         job = subject.to_job
         job.should be_a(Job)
         job.provider.should be_a(provider_class)
         job.reader.should be_a(reader_class)
         job.attributes.should be_a(AttributeMap)
       end
+
+      context "with a repeat block" do
+        before do
+          subject.repeat do |i, o| end
+        end
+
+        it "adds a repeater to the provider" do
+          job = subject.to_job
+          job.provider.should be_a ProviderRepeater
+          job.provider.base_provider.should be_a provider_class
+        end
+      end
     end
 
   end

data/spec/stockboy/filter_spec.rb

@@ -9,6 +9,9 @@ class FishFilter < Stockboy::Filter
   end
 end
 
+class CoffeeFilter < Stockboy::Filter
+end
+
 module Stockboy
   describe Filter do
 
@@ -37,5 +40,9 @@ module Stockboy
       end
     end
 
+    it "warns of a missing subclass implementation" do
+      expect { CoffeeFilter.new.call(double, double) }.to raise_error NoMethodError
+    end
+
   end
 end

data/spec/stockboy/job_spec.rb

@@ -17,16 +17,18 @@ class TestReader
     @parse = opts[:parse] || []
   end
   def parse(data)
-    @parse
+    @parse.respond_to?(:call) ? @parse.call(data) : @parse
   end
 end
 
 module Stockboy
   describe Job do
-    let(:jobs_path) { RSpec.configuration.fixture_path.join('jobs') }
+    let(:jobs_path) { fixture_path "jobs" }
     let(:provider)  { provider_double }
     let(:reader)    { reader_double }
 
+    subject(:job) { described_class.new }
+
     let(:job_template) {
       <<-END.gsub(/^ {6}/,'')
       provider :ftp do
@@ -112,6 +114,25 @@ module Stockboy
       end
     end
 
+    describe "#attributes=" do
+
+      before do
+        job.attributes = AttributeMap.new do first_name end
+        job.all_records << double
+      end
+
+      it "replaces the attribute map" do
+        job.attributes = AttributeMap.new do last_name end
+        job.attributes.map(&:to).should == [:last_name]
+      end
+
+      it "resets the job" do
+        job.attributes = AttributeMap.new do last_name end
+        job.all_records.should be_empty
+      end
+
+    end
+
     describe "#process" do
       let(:attribute_map) { AttributeMap.new { name } }
 
@@ -171,6 +192,24 @@ module Stockboy
         job.filters = {alpha: proc{ |r| r.name =~ /A/ }, beta: proc{ |r| r.name =~ /B/ }}
         job.records.should == {alpha: [], beta: []}
       end
+
+      context "with a repeating provider" do
+        let(:repeater) {
+          ProviderRepeater.new(provider) do |inputs|
+            1.upto 3 do |i|
+              inputs << provider_double(data: [{"name" => i}])
+            end
+          end
+        }
+        let(:noop_reader) { reader_double(parse: ->(data) { data }) }
+        let(:job) { Job.new(provider: repeater, reader: noop_reader, attributes: attribute_map) }
+
+        it "it loads all records into a set" do
+          job.process
+          job.all_records.size.should == 3
+        end
+      end
+
     end
 
     describe "#record_counts" do
@@ -237,6 +276,16 @@ module Stockboy
 
     end
 
+    describe "#triggers=" do
+
+      it "replaces existing triggers" do
+        job.triggers = {breakfast: double}
+        job.triggers = {lunch: double}
+        job.triggers.keys.should == [:lunch]
+      end
+
+    end
+
     describe "#method_missing" do
 
       subject(:job) { Job.new(triggers: {cleanup: proc{|_|}})}
@@ -252,6 +301,20 @@ module Stockboy
 
     end
 
+    describe "#inspect" do
+      let(:job) { Job.new(provider: provider_double, reader: reader_double) }
+      subject { job.inspect }
+
+      it "is not extraordinarily long" do
+        should start_with "#<Stockboy::Job"
+        should include "provider=TestProvider"
+        should include "reader=TestReader"
+        should include "attributes=[]"
+        should include "filters=[]"
+        should include "record_counts={}"
+      end
+    end
+
     def provider_double(opts={})
       TestProvider.new(opts)
     end

data/spec/stockboy/provider_repeater_spec.rb

@@ -28,7 +28,7 @@ module Stockboy
 
       it "yields each data set" do
         calls = []
-        repeater.data { |data| calls << data[-1] }
+        repeater.data { |data| calls << data.split(",").last }
         calls.should == ["1", "2", "3"]
       end
 

data/spec/stockboy/provider_spec.rb

@@ -50,5 +50,26 @@ module Stockboy
       end
     end
 
+    describe "#reload" do
+      subject(:provider) { ProviderSubclass.new(foo: true) }
+
+      it "clears and reloads the data" do
+        data = provider.data
+        expect(provider).to receive(:fetch_data).once.and_call_original
+        provider.reload.should == data
+      end
+    end
+
+    describe "#inspect" do
+      subject(:provider) { ProviderSubclass.new(foo: true) }
+      subject { provider.inspect }
+
+      it "is not extraordinarily long" do
+        should start_with "#<ProviderSubclass"
+        should include "data_size="
+        should include "errors="
+        should_not include "@data"
+      end
+    end
   end
 end

data/spec/stockboy/providers/file_spec.rb

@@ -33,24 +33,31 @@ module Stockboy
     end
 
     describe "#matching_file" do
-      subject(:provider) do
-        Providers::File.new do |f|
-          f.file_dir = RSpec.configuration.fixture_path.join("files")
+      let(:provider) { Providers::File.new(file_dir: fixture_path("files")) }
+      subject(:matching_file) { provider.matching_file }
+
+      context "with a matching string" do
+        before { provider.file_name = "test_data-*" }
+        it "returns the full path to the matching file name" do
+          should end_with "fixtures/files/test_data-20120202.csv"
+        end
+      end
+
+      context "with a matching regex" do
+        before { provider.file_name = /^test_data-\d+/ }
+        it "returns the full path to the matching file name" do
+          should end_with "fixtures/files/test_data-20120202.csv"
         end
       end
 
-      it "returns the full path to the matching file name" do
-        provider.file_name = "test_data-*"
-        provider.matching_file.should end_with "fixtures/files/test_data-20120202.csv"
+      context "with an unmatched string" do
+        before { provider.file_name = "missing" }
+        it { should be_nil }
       end
     end
 
     describe "#data" do
-      subject(:provider) do
-        Providers::File.new do |f|
-          f.file_dir = RSpec.configuration.fixture_path.join("files")
-        end
-      end
+      subject(:provider) { Providers::File.new(file_dir: fixture_path("files")) }
 
       it "fails with an error if the file doesn't exist" do
         provider.file_name = "missing-file.csv"
@@ -75,25 +82,38 @@ module Stockboy
         provider.data.should == "2012-02-02\n"
       end
 
-      context "with :since validation" do
+      context "metadata validation" do
+        before { provider.file_name = '*.csv' }
         let(:recently)  { Time.now - 60 }
         let(:last_week) { Time.now - 86400 }
 
-        it "skips old files" do
+        it "skips old files with :since" do
           expect_any_instance_of(::File).to receive(:mtime).and_return last_week
-          provider.file_name = '*.csv'
           provider.since = recently
-
           provider.data.should be_nil
           provider.errors.first.should == "no new files since #{recently}"
         end
+
+        it "skips large files with :file_smaller" do
+          expect_any_instance_of(::File).to receive(:size).and_return 1001
+          provider.file_smaller = 1000
+          provider.data.should be_nil
+          provider.errors.first.should == "file size larger than 1000"
+        end
+
+        it "skips small files with :file_larger" do
+          expect_any_instance_of(::File).to receive(:size).and_return 999
+          provider.file_larger = 1000
+          provider.data.should be_nil
+          provider.errors.first.should == "file size smaller than 1000"
+        end
       end
     end
 
     describe ".delete_data" do
-      let(:target)       { ::Tempfile.new(['delete', '.csv']) }
-      let(:target_dir)   { File.dirname(target) }
-      let(:pick_same)    { ->(best, this) { this == target.path ? this : best } }
+      let(:target)     { ::Tempfile.new(['delete', '.csv']) }
+      let(:target_dir) { File.dirname(target) }
+      let(:pick_same)  { ->(best, this) { this == target.path ? this : best } }
 
       subject(:provider) do
         Providers::File.new(file_name: 'delete*.csv', file_dir: target_dir, pick: pick_same)