stanford-mods 2.6.4 → 3.1.0

data/spec/name_spec.rb

@@ -3,7 +3,7 @@ describe "name/author concepts" do
   let(:mods_start) { "<mods xmlns=\"#{Mods::MODS_NS}\">" }
   let(:mods_end) { "</mods>" }
 
-  context "main_author_w_date" do
+  context "sw_main_author" do
     let(:plain_no_role) { "<name><namePart>plain_no_role</namePart></name>" }
     let(:plain_creator_code) { "<name>
                               <namePart>plain_creator_code</namePart>
@@ -60,77 +60,72 @@ describe "name/author concepts" do
     context "marcrelator role Creator" do
       it "finds role with roleTerm type text" do
         smods_rec.from_str(mods_start + plain_creator_text + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_creator_text')
+        expect(smods_rec.sw_main_author).to eq('plain_creator_text')
       end
       it "finds role with roleTerm type code" do
         smods_rec.from_str(mods_start + plain_creator_code + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_creator_code')
+        expect(smods_rec.sw_main_author).to eq('plain_creator_code')
       end
       it "skips names when role isn't marcrelator authority" do
         smods_rec.from_str(mods_start + plain_creator_non_mr + mods_end)
-        expect(smods_rec.main_author_w_date).to be_nil
+        expect(smods_rec.sw_main_author).to be_nil
       end
       it "skips names without roles in favor of marcrelator role of 'Creator'" do
         smods_rec.from_str(mods_start + personal_no_role + plain_creator_text + other_no_role + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_creator_text')
+        expect(smods_rec.sw_main_author).to eq('plain_creator_text')
         smods_rec.from_str(mods_start + corp_no_role + plain_creator_code + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_creator_code')
+        expect(smods_rec.sw_main_author).to eq('plain_creator_code')
       end
       it "does not care about name type" do
         smods_rec.from_str(mods_start + personal_creator_code + corp_creator_text + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('personal_creator_code')
+        expect(smods_rec.sw_main_author).to eq('personal_creator_code')
         smods_rec.from_str(mods_start + personal_no_role + corp_creator_text + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('corp_creator_text')
+        expect(smods_rec.sw_main_author).to eq('corp_creator_text')
       end
     end # marcrelator role Creator
 
     context "marcrelator role Author" do
       it "finds role with roleTerm type text" do
         smods_rec.from_str(mods_start + plain_author_text + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_author_text')
+        expect(smods_rec.sw_main_author).to eq('plain_author_text')
       end
       it "finds role with roleTerm type code" do
         smods_rec.from_str(mods_start + plain_author_code + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_author_code')
+        expect(smods_rec.sw_main_author).to eq('plain_author_code')
       end
       it "skips names when role isn't marcrelator authority" do
         smods_rec.from_str(mods_start + plain_author_non_mr + mods_end)
-        expect(smods_rec.main_author_w_date).to be_nil
+        expect(smods_rec.sw_main_author).to be_nil
       end
       it "skips names without roles in favor of marcrelator role of 'Author'" do
         smods_rec.from_str(mods_start + personal_no_role + plain_author_text + other_no_role + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_author_text')
+        expect(smods_rec.sw_main_author).to eq('plain_author_text')
         smods_rec.from_str(mods_start + corp_no_role + personal_no_role + plain_author_code + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('plain_author_code')
+        expect(smods_rec.sw_main_author).to eq('plain_author_code')
       end
       it "doesn't care about name type" do
         smods_rec.from_str(mods_start + personal_author_text + corp_author_code + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('personal_author_text')
+        expect(smods_rec.sw_main_author).to eq('personal_author_text')
         smods_rec.from_str(mods_start + personal_no_role + corp_author_code + mods_end)
-        expect(smods_rec.main_author_w_date).to eq('corp_author_code')
+        expect(smods_rec.sw_main_author).to eq('corp_author_code')
       end
     end # marcrelator role Author
 
-    it "is a String" do
-      smods_rec.from_str(mods_start + personal_author_text + corp_creator_text + mods_end)
-      expect(smods_rec.main_author_w_date).to be_an_instance_of(String)
-    end
-
     it "takes first name with marcrelator role of 'Creator' or 'Author'" do
       smods_rec.from_str(mods_start + personal_author_text + corp_creator_text + mods_end)
-      expect(smods_rec.main_author_w_date).to eq('personal_author_text')
+      expect(smods_rec.sw_main_author).to eq('personal_author_text')
       smods_rec.from_str(mods_start + corp_creator_text + personal_creator_code + mods_end)
-      expect(smods_rec.main_author_w_date).to eq('corp_creator_text')
+      expect(smods_rec.sw_main_author).to eq('corp_creator_text')
     end
 
     it "takes the first name without a role if there are no instances of marcrelator role 'Creator' or 'Actor'" do
       smods_rec.from_str(mods_start + plain_author_non_mr + personal_other_role + personal_no_role + plain_no_role + mods_end)
-      expect(smods_rec.main_author_w_date).to eq('personal_no_role')
+      expect(smods_rec.sw_main_author).to eq('personal_no_role')
     end
 
     it "nil if there is no name with marcrelator role of 'Creator' or 'Author' and no name without a role" do
       smods_rec.from_str(mods_start + plain_author_non_mr + personal_other_role + mods_end)
-      expect(smods_rec.main_author_w_date).to be_nil
+      expect(smods_rec.sw_main_author).to be_nil
     end
 
     it "uses the display name if it is present" do
@@ -148,7 +143,7 @@ describe "name/author concepts" do
             </name>
           </mods>"
       smods_rec.from_str(m)
-      expect(smods_rec.main_author_w_date).to eq('q')
+      expect(smods_rec.sw_main_author).to eq('q')
     end
     it "includes dates, when available" do
       m = "<mods xmlns=\"#{Mods::MODS_NS}\">
@@ -158,7 +153,7 @@ describe "name/author concepts" do
             </name>
           </mods>"
       smods_rec.from_str(m)
-      expect(smods_rec.main_author_w_date).to eq('personal, 1984-')
+      expect(smods_rec.sw_main_author).to eq('personal, 1984-')
       m = "<mods xmlns=\"#{Mods::MODS_NS}\">
             <name>
               <namePart>plain</namePart>
@@ -166,7 +161,7 @@ describe "name/author concepts" do
             </name>
           </mods>"
       smods_rec.from_str(m)
-      expect(smods_rec.main_author_w_date).to eq('plain, 1954-')
+      expect(smods_rec.sw_main_author).to eq('plain, 1954-')
       m = "<mods xmlns=\"#{Mods::MODS_NS}\">
             <name type='corporate'>
               <namePart>corporate</namePart>
@@ -174,9 +169,9 @@ describe "name/author concepts" do
             </name>
           </mods>"
       smods_rec.from_str(m)
-      expect(smods_rec.main_author_w_date).to eq('corporate, 1990-')
+      expect(smods_rec.sw_main_author).to eq('corporate, 1990-')
     end
-  end # main_author_w_date
+  end
 
   context "additional_authors_w_dates" do
     let(:addl_authors) do
@@ -209,14 +204,14 @@ describe "name/author concepts" do
             </name>
           </mods>"
       smods_rec.from_str(m)
-      smods_rec.additional_authors_w_dates
+      smods_rec.sw_addl_authors
     end
     it "is an Array of Strings" do
       expect(addl_authors).to be_an_instance_of(Array)
       expect(addl_authors.first).to be_an_instance_of(String)
     end
     it "does not include main author" do
-      expect(addl_authors).not_to include(smods_rec.main_author_w_date)
+      expect(addl_authors).not_to include(smods_rec.sw_main_author)
     end
     it "includes personal authors that are not main author" do
       expect(addl_authors).to include('Crusty The Clown, 1990-')
@@ -240,203 +235,4 @@ describe "name/author concepts" do
       expect(addl_authors.find { |a| a =~ Regexp.new('lithographer') }).to be_nil
     end
   end # additional_authors_w_dates
-
-  context '#non_collector_person_authors' do
-    let(:name) { 'Hermione Grainger' }
-    let(:name2) { 'Ron Weasley' }
-    context 'has personal names that are not collectors' do
-      it 'only non-collector persons' do
-        name_snippet =
-          <<-EOF
-            <name type="personal">
-              <namePart>#{name}</namePart>
-              <role>
-                <roleTerm type="code" authority="marcrelator">cre</roleTerm>
-              </role>
-            </name>
-            <name type="personal">
-              <namePart>#{name2}</namePart>
-              <role>
-                <roleTerm type="code" authority="marcrelator">con</roleTerm>
-              </role>
-            </name>
-          EOF
-        smods_rec.from_str(mods_start + name_snippet + mods_end)
-        expect(smods_rec.non_collector_person_authors).to include(name, name2)
-      end
-      it 'some collectors, some non-collectors' do
-        name_snippet =
-          <<-EOF
-            <name type="personal">
-              <namePart>#{name}</namePart>
-              <role>
-                <roleTerm type="code" authority="marcrelator">cre</roleTerm>
-              </role>
-            </name>
-            <name type="personal">
-              <namePart>#{name2}</namePart>
-              <role>
-                <roleTerm type="code" authority="marcrelator">col</roleTerm>
-              </role>
-            </name>
-          EOF
-        smods_rec.from_str(mods_start + name_snippet + mods_end)
-        expect(smods_rec.non_collector_person_authors).to eq [name]
-      end
-    end
-
-    it 'nil if only collectors' do
-      name_snippet =
-        <<-EOF
-          <name type="personal">
-            <namePart>#{name}</namePart>
-            <role>
-              <roleTerm type="code" authority="marcrelator">col</roleTerm>
-            </role>
-          </name>
-          <name type="personal">
-            <namePart>Ron Weasley</namePart>
-            <role>
-              <roleTerm type="code" authority="marcrelator">col</roleTerm>
-            </role>
-          </name>
-        EOF
-      smods_rec.from_str(mods_start + name_snippet + mods_end)
-      expect(smods_rec.non_collector_person_authors).to eq nil
-    end
-    it 'no role present' do
-      name_snippet =
-        <<-EOF
-          <name type="personal" usage="primary">
-            <namePart>#{name}</namePart>
-          </name>
-        EOF
-      smods_rec.from_str(mods_start + name_snippet + mods_end)
-      expect(smods_rec.non_collector_person_authors).to eq nil
-    end
-  end
-
-  context '#collectors_w_dates' do
-    let(:collector_name) { 'Dr. Seuss' }
-    context 'valueURI for roleTerm' do
-      it 'roleTerm has value' do
-        name_snippet =
-          <<-EOF
-            <name type="personal">
-              <namePart>#{collector_name}</namePart>
-              <role>
-                <roleTerm type="text" authority="marcrelator" authorityURI="http://id.loc.gov/vocabulary/relators" valueURI="http://id.loc.gov/vocabulary/relators/col">Collector</roleTerm>
-              </role>
-            </name>
-          EOF
-        smods_rec.from_str(mods_start + name_snippet + mods_end)
-        expect(smods_rec.collectors_w_dates).to eq [collector_name]
-      end
-      it 'empty roleTerm' do
-        name_snippet =
-          <<-EOF
-            <name type="personal">
-              <namePart>#{collector_name}</namePart>
-              <role>
-                <roleTerm authority="marcrelator" authorityURI="http://id.loc.gov/vocabulary/relators" valueURI="http://id.loc.gov/vocabulary/relators/col" />
-              </role>
-            </name>
-          EOF
-        smods_rec.from_str(mods_start + name_snippet + mods_end)
-        expect(smods_rec.collectors_w_dates).to eq [collector_name]
-      end
-    end
-
-    context 'no valueURI for roleTerm' do
-      it 'collector marc relator code' do
-        name_snippet =
-          <<-EOF
-            <name type="personal">
-              <namePart>#{collector_name}</namePart>
-              <role>
-                <roleTerm type="code" authority="marcrelator">col</roleTerm>
-              </role>
-            </name>
-          EOF
-        smods_rec.from_str(mods_start + name_snippet + mods_end)
-        expect(smods_rec.collectors_w_dates).to eq [collector_name]
-      end
-      it 'collector marc relator text' do
-        name_snippet =
-          <<-EOF
-            <name type="personal">
-              <namePart>#{collector_name}</namePart>
-              <role>
-                <roleTerm type="text" authority="marcrelator">Collector</roleTerm>
-              </role>
-            </name>
-          EOF
-        smods_rec.from_str(mods_start + name_snippet + mods_end)
-        expect(smods_rec.collectors_w_dates).to eq [collector_name]
-      end
-    end
-
-    it 'does not include non-collectors' do
-      name_snippet =
-        <<-EOF
-          <name type="personal">
-            <namePart>#{collector_name}</namePart>
-            <role>
-              <roleTerm type="text" authority="marcrelator">Collector</roleTerm>
-            </role>
-          </name>
-          <name type="personal">
-            <namePart>Freddy</namePart>
-            <role>
-              <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
-            </role>
-          </name>
-        EOF
-      smods_rec.from_str(mods_start + name_snippet + mods_end)
-      expect(smods_rec.collectors_w_dates).to eq [collector_name]
-    end
-    it 'multiple collectors' do
-      addl_name = 'Feigenbaum, Edward A.'
-      name_snippet =
-        <<-EOF
-          <name type="personal">
-            <namePart>#{collector_name}</namePart>
-            <role>
-              <roleTerm type="text" authority="marcrelator">Collector</roleTerm>
-            </role>
-          </name>
-          <name type="personal">
-            <namePart>#{addl_name}</namePart>
-            <role>
-              <roleTerm type='code' authority='marcrelator'>col</roleTerm>
-            </role>
-          </name>
-        EOF
-      smods_rec.from_str(mods_start + name_snippet + mods_end)
-      expect(smods_rec.collectors_w_dates).to include(collector_name, addl_name)
-    end
-    it 'nil if no collectors' do
-      name_snippet =
-        <<-EOF
-          <name type="personal">
-            <namePart>Freddy</namePart>
-            <role>
-              <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
-            </role>
-          </name>
-        EOF
-      smods_rec.from_str(mods_start + name_snippet + mods_end)
-      expect(smods_rec.collectors_w_dates).to eq nil
-    end
-    it 'no role present' do
-      name_snippet =
-        <<-EOF
-          <name type="personal" usage="primary">
-            <namePart>Nobody</namePart>
-          </name>
-        EOF
-      smods_rec.from_str(mods_start + name_snippet + mods_end)
-      expect(smods_rec.collectors_w_dates).to eq nil
-    end
-  end
 end