stacker_bee 2.1.1.pre252 → 2.1.1.pre263

data/spec/units/stacker_bee/middleware/base_spec.rb

@@ -13,20 +13,20 @@ describe StackerBee::Middleware::Base do
   let(:subclass) { Class.new(described_class, &subclass_body) }
   let(:subclass_body) { proc {} }
 
-  describe "#call" do
+  describe '#call' do
     before do
       middleware.call env
     end
 
     def self.it_calls_its_app_with_the_env
-      it "calls its app with the env" do
+      it 'calls its app with the env' do
         app.should have_received(:call).with(env)
       end
     end
 
     it_calls_its_app_with_the_env
 
-    context "when overriding #before" do
+    context 'when overriding #before' do
       let(:subclass_body) do
         proc do
           def before(env)
@@ -37,12 +37,12 @@ describe StackerBee::Middleware::Base do
 
       it_calls_its_app_with_the_env
 
-      it "runs the before hook" do
+      it 'runs the before hook' do
         env.before_was_run.should be_true
       end
     end
 
-    context "when overriding #after" do
+    context 'when overriding #after' do
       let(:subclass_body) do
         proc do
           def after(env)
@@ -53,12 +53,12 @@ describe StackerBee::Middleware::Base do
 
       it_calls_its_app_with_the_env
 
-      it "runs the after hook" do
+      it 'runs the after hook' do
         env.after_was_run.should be_true
       end
     end
 
-    context "when overriding #content_types" do
+    context 'when overriding #content_types' do
       let(:subclass_body) do
         proc do
           def after(env)
@@ -73,22 +73,22 @@ describe StackerBee::Middleware::Base do
 
       it_calls_its_app_with_the_env
 
-      context "when it matches the content type" do
+      context 'when it matches the content type' do
         let(:content_type) { 'text/html; uft-8' }
-        it "runs the after hook" do
+        it 'runs the after hook' do
           env.after_was_run.should be_true
         end
       end
 
       context "when it doesn't match the content type" do
         let(:content_type) { 'text/javascript; uft-8' }
-        it "runs the after hook" do
+        it 'runs the after hook' do
           env.after_was_run.should be_nil
         end
       end
     end
 
-    context "when overriding #params" do
+    context 'when overriding #params' do
       let(:subclass_body) do
         proc do
           def transform_params(params)
@@ -97,17 +97,17 @@ describe StackerBee::Middleware::Base do
         end
       end
 
-      it "changes the params" do
+      it 'changes the params' do
         env.request.params[:params_merged?].should be_true
       end
     end
   end
 
-  describe "#endpoint_name_for" do
+  describe '#endpoint_name_for' do
     let(:endpoint_name) { double }
     let(:normalized_endpoint_name) { double }
 
-    it "delegates to its app" do
+    it 'delegates to its app' do
       app.should_receive(:endpoint_name_for)
         .with(endpoint_name)
         .and_return(normalized_endpoint_name)
@@ -117,10 +117,10 @@ describe StackerBee::Middleware::Base do
     end
   end
 
-  describe "#matches_content_type?" do
-    describe "by default" do
+  describe '#matches_content_type?' do
+    describe 'by default' do
       before { env.response.content_type = '$8^02(324' }
-      it "matches anything" do
+      it 'matches anything' do
         middleware.matches_content_type?(env).should be_true
       end
     end

data/spec/units/stacker_bee/middleware/cloudstack_api_spec.rb

@@ -7,31 +7,31 @@ describe StackerBee::Middleware::CloudStackAPI do
       path: path
     )
   end
-  let(:middleware) { described_class.new(api_key: "API-KEY", params: {}) }
+  let(:middleware) { described_class.new(api_key: 'API-KEY', params: {}) }
   let(:path) { nil }
 
   before do
     middleware.before(env)
   end
 
-  describe "request" do
+  describe 'request' do
     subject { env.request }
 
-    context "when the path is not set" do
+    context 'when the path is not set' do
       let(:path) { nil }
       its(:path) { should == described_class::DEFAULT_PATH }
     end
 
-    context "when the path is already set" do
-      let(:path) { "already set"  }
+    context 'when the path is already set' do
+      let(:path) { 'already set'  }
       its(:path) { should == path }
     end
   end
 
-  describe "params" do
+  describe 'params' do
     subject { env.request.params }
-    its([:api_key])  { should eq "API-KEY" }
-    its([:response]) { should eq "json" }
-    its([:command])  { should eq "endpoint-name" }
+    its([:api_key])  { should eq 'API-KEY' }
+    its([:response]) { should eq 'json' }
+    its([:command])  { should eq 'endpoint-name' }
   end
 end

data/spec/units/stacker_bee/middleware/console_access_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe StackerBee::Middleware::ConsoleAccess do
   let(:env) do
@@ -8,15 +8,15 @@ describe StackerBee::Middleware::ConsoleAccess do
   let(:middleware) { described_class.new(app: app) }
   let(:app) { double(:app) }
 
-  context "when it matches the endpoint" do
+  context 'when it matches the endpoint' do
     let(:endpoint_name) { described_class::ENDPOINT }
 
-    it "adds its path to the env" do
+    it 'adds its path to the env' do
       middleware.before(env)
       env.request.path.should == described_class::PATH
     end
 
-    it "adds cmd to the parameters" do
+    it 'adds cmd to the parameters' do
       env.request.params.should_not include described_class::PARAMS
     end
   end
@@ -35,22 +35,22 @@ describe StackerBee::Middleware::ConsoleAccess do
     end
   end
 
-  it "matches html content typtes" do
-    middleware.content_types.should =~ "text/html; charset=utf-8"
+  it 'matches html content typtes' do
+    middleware.content_types.should =~ 'text/html; charset=utf-8'
   end
 
-  describe "#endpoint_name_for" do
-    context "given names it reponds to" do
+  describe '#endpoint_name_for' do
+    context 'given names it reponds to' do
       %w(consoleAccess console_access CONSOLEACCESS).each do |name|
         subject { middleware.endpoint_name_for(name) }
         it { should eq described_class::ENDPOINT }
       end
     end
 
-    context "for other names" do
+    context 'for other names' do
       before { app.stub :endpoint_name_for, &:upcase }
 
-      it "delegates for other names" do
+      it 'delegates for other names' do
         middleware.endpoint_name_for('other-name').should == 'OTHER-NAME'
       end
     end

data/spec/units/stacker_bee/middleware/dictionary_flattener_spec.rb

@@ -3,20 +3,20 @@ require 'spec_helper'
 describe StackerBee::Middleware::DictionaryFlattener do
   let(:lb)               { described_class::LB }
   let(:rb)               { described_class::RB }
-  let(:string)           { "cool[0].name%21" }
+  let(:string)           { 'cool[0].name%21' }
   let(:tokenized_string) { "cool#{lb}0#{rb}.name%21" }
 
-  describe ".detokenize" do
+  describe '.detokenize' do
     subject { described_class.detokenize(tokenized_string) }
     it { should eq string  }
   end
 
-  describe ".tokenize" do
+  describe '.tokenize' do
     subject { described_class.tokenize(string) }
     it { should eq tokenized_string  }
   end
 
-  describe ".new" do
+  describe '.new' do
     subject { described_class.new.transform_params(params) }
 
     def param(number)
@@ -24,38 +24,38 @@ describe StackerBee::Middleware::DictionaryFlattener do
     end
 
     let(:params) do
-      { "time" => "long ago",
-        "rebels" => {
-          "r2"      => "d2",
-          "blank"   => "",
-          "falsey"  => "false",
-          "false"   => false,
-          "droid"   => true } }
+      { 'time' => 'long ago',
+        'rebels' => {
+          'r2'      => 'd2',
+          'blank'   => '',
+          'falsey'  => 'false',
+          'false'   => false,
+          'droid'   => true } }
     end
 
-    it "flattens objects in the manner that cloudstack expects" do
-      subject["#{param(0)}.name"].should eq "r2"
-      subject["#{param(0)}.key"].should eq "r2"
-      subject["#{param(0)}.value"].should eq "d2"
+    it 'flattens objects in the manner that cloudstack expects' do
+      subject["#{param(0)}.name"].should eq 'r2'
+      subject["#{param(0)}.key"].should eq 'r2'
+      subject["#{param(0)}.value"].should eq 'd2'
     end
 
-    it "does not flatten empty hashes" do
+    it 'does not flatten empty hashes' do
       subject.should_not have_key "#{param(2)}.name"
     end
 
-    it "handles true booleans" do
-      subject["#{param(1)}.name"].should eq "droid"
+    it 'handles true booleans' do
+      subject["#{param(1)}.name"].should eq 'droid'
       subject["#{param(1)}.value"].should be_true
     end
 
-    it "removes original map params" do
-      subject.should_not have_key "rebels"
+    it 'removes original map params' do
+      subject.should_not have_key 'rebels'
     end
 
-    it "doesnt send false to CloudStack" do
+    it 'doesnt send false to CloudStack' do
       # This assumption is based on CloudStack UI behavior
       subject.values.should_not include false
-      subject.values.should_not include "false"
+      subject.values.should_not include 'false'
     end
   end
 end

data/spec/units/stacker_bee/middleware/endpoint_normalizer_spec.rb

@@ -12,15 +12,15 @@ describe StackerBee::Middleware::EndpointNormalizer do
     let(:api) { {} }
     let(:endpoint_name) { :some_endpoint }
 
-    describe "#endpoint_name_for" do
+    describe '#endpoint_name_for' do
       before { app.stub :endpoint_name_for, &:upcase }
 
-      it "delegates to its app" do
+      it 'delegates to its app' do
         middleware.endpoint_name_for('some-name').should == 'SOME-NAME'
       end
     end
 
-    describe "#before" do
+    describe '#before' do
       before { app.stub endpoint_name_for: nil }
 
       it "doesn't set the endpoint to nil", :regression do
@@ -30,5 +30,5 @@ describe StackerBee::Middleware::EndpointNormalizer do
     end
   end
 
-  context "when it matches an endpoint"
+  context 'when it matches an endpoint'
 end

data/spec/units/stacker_bee/middleware/error_message_spec.rb

@@ -12,22 +12,22 @@ describe StackerBee::Middleware::ErrorMessage do
     end
   end
   let(:body) { { errortext: message } }
-  let(:message) { "Unable to execute API command deployvirtualmachine " }
+  let(:message) { 'Unable to execute API command deployvirtualmachine ' }
   let(:is_success?) { true }
 
   it "doesn't apply to HTML responses" do
-    middleware.content_types.should_not match("text/html; charset=utf-8")
+    middleware.content_types.should_not match('text/html; charset=utf-8')
   end
-  it "applies to JSON responses" do
-    middleware.content_types.should match("text/javascript; charset=utf-8")
+  it 'applies to JSON responses' do
+    middleware.content_types.should match('text/javascript; charset=utf-8')
   end
 
-  context "given an error" do
+  context 'given an error' do
     let(:is_success?) { false }
     its(:error) { should eq message }
   end
 
-  context "given a success" do
+  context 'given a success' do
     let(:is_success?) { true }
     its(:error) { should be_nil }
   end

data/spec/units/stacker_bee/middleware/format_keys_spec.rb

@@ -10,9 +10,9 @@ describe StackerBee::Middleware::FormatKeys do
     }
   end
 
-  it { should have_key "symbol" }
+  it { should have_key 'symbol' }
   it { should_not have_key :symbol  }
 
-  it { should have_key "keyCase" }
+  it { should have_key 'keyCase' }
   it { should_not have_key :key_case }
 end

data/spec/units/stacker_bee/middleware/format_values_spec.rb

@@ -10,6 +10,6 @@ describe StackerBee::Middleware::FormatValues do
     }
   end
 
-  its([:single]) { should eq "1" }
-  its([:list])   { should eq "1,2,3" }
+  its([:single]) { should eq '1' }
+  its([:list])   { should eq '1,2,3' }
 end

data/spec/units/stacker_bee/middleware/http_status_spec.rb

@@ -13,7 +13,7 @@ describe StackerBee::Middleware::HTTPStatus do
   end
   let(:body) { { errorcode: http_status } }
 
-  context "given an error" do
+  context 'given an error' do
     let(:http_status) { 431 }
     let(:success?) { false }
 
@@ -21,7 +21,7 @@ describe StackerBee::Middleware::HTTPStatus do
     it { should_not be_success }
   end
 
-  context "given a success" do
+  context 'given a success' do
     let(:http_status) { 200 }
     let(:success?) { true }
 

data/spec/units/stacker_bee/middleware/log_response_spec.rb

@@ -1,18 +1,18 @@
 require 'spec_helper'
 describe StackerBee::Middleware::LogResponse do
-  describe "after" do
+  describe 'after' do
     let(:logger) { FakeLogger.new }
 
     let(:env) do
       env = StackerBee::Middleware::Environment.new(logger: logger)
-      env.raw_response = { body: "some body" }
-      env.request.params = { "command" => "some command" }
-      env.request.path = "some/path"
+      env.raw_response = { body: 'some body' }
+      env.request.params = { 'command' => 'some command' }
+      env.request.path = 'some/path'
       env
     end
 
-    shared_examples_for "all logs" do
-      it "logs the details" do
+    shared_examples_for 'all logs' do
+      it 'logs the details' do
         logger.logs.length.should eq 1
         logger.logs.last[:request_path].should eq env.request.path
         logger.logs.last[:params].should eq env.request.params.to_a
@@ -20,30 +20,30 @@ describe StackerBee::Middleware::LogResponse do
       end
     end
 
-    context "error response" do
+    context 'error response' do
       before do
         env.response.success = false
-        env.response.error = "invalid request"
+        env.response.error = 'invalid request'
         subject.after(env)
       end
 
-      it_should_behave_like "all logs"
-      it "should have logged the details" do
+      it_should_behave_like 'all logs'
+      it 'should have logged the details' do
         logger.logs.last[:short_message].should eq \
-          "some command failed: invalid request"
+          'some command failed: invalid request'
       end
     end
 
-    context "success response" do
+    context 'success response' do
       before do
         env.response.success = true
         subject.after(env)
       end
 
-      it_should_behave_like "all logs"
-      it "should have logged the details" do
+      it_should_behave_like 'all logs'
+      it 'should have logged the details' do
         logger.logs.length.should eq 1
-        logger.logs.last[:short_message].should eq "some command"
+        logger.logs.last[:short_message].should eq 'some command'
       end
 
     end

data/spec/units/stacker_bee/middleware/remove_empty_strings_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 # TODO: does this really need to work with nested hashes?
 describe StackerBee::Middleware::RemoveEmptyStrings do
@@ -40,15 +40,15 @@ describe StackerBee::Middleware::RemoveEmptyStrings do
     middleware.call(env)
   end
 
-  it "removes empty strings from the input" do
+  it 'removes empty strings from the input' do
     params.keys.should =~ [:ok1, :ok2, :ok3, :ok4, :nested]
   end
 
-  it "removes empty strings nested in hashes" do
+  it 'removes empty strings nested in hashes' do
     params[:nested].keys.should =~ [:ok1, :ok2, :ok3, :ok4, :nested]
   end
 
-  it "removes empty strings deeply nested in hashes" do
+  it 'removes empty strings deeply nested in hashes' do
     params[:nested][:nested].keys.should =~ [:ok1, :ok2, :ok3, :ok4]
   end
 end

data/spec/units/stacker_bee/middleware/remove_nils_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe StackerBee::Middleware::RemoveNils do
-  it "removes pairs with nil values from the params" do
+  it 'removes pairs with nil values from the params' do
     subject.transform_params(something: 'something', nothing: nil)
       .should eq something: 'something'
   end

data/spec/units/stacker_bee/rash_spec.rb

@@ -1,38 +1,38 @@
-require "spec_helper"
+require 'spec_helper'
 
-shared_examples_for "a Rash" do |mapping|
+shared_examples_for 'a Rash' do |mapping|
   mapping.each_pair { |key, value| its([key]) { should == value } }
 end
 
 describe StackerBee::Rash do
   subject { rash }
 
-  let(:wiz) { [{ "aB_C" => "abc" }, { "X_yZ" => "xyz" }] }
+  let(:wiz) { [{ 'aB_C' => 'abc' }, { 'X_yZ' => 'xyz' }] }
   let(:ziz) do
     {
-      "M-om" => {
-        "kI_d" => 2
+      'M-om' => {
+        'kI_d' => 2
       }
     }
   end
   let(:hash) do
     {
-      "foo"  => "foo",
-      "b_iz" => "biz",
-      "WiZ"  => wiz,
+      'foo'  => 'foo',
+      'b_iz' => 'biz',
+      'WiZ'  => wiz,
       :ziz   => ziz
     }
   end
   let(:similar_hash) do
     hash.dup.tap do |loud|
-      value = loud.delete "foo"
-      loud["FOO"] = value
+      value = loud.delete 'foo'
+      loud['FOO'] = value
     end
   end
-  let(:dissimilar_hash) { hash.dup.tap { |loud| loud.delete "foo" } }
+  let(:dissimilar_hash) { hash.dup.tap { |loud| loud.delete 'foo' } }
   let(:rash) { described_class.new(hash) }
 
-  it { should include "FOO" }
+  it { should include 'FOO' }
 
   it { should == subject }
   it { should == subject.dup }
@@ -41,47 +41,47 @@ describe StackerBee::Rash do
   it { should == similar_hash }
   it { should_not == dissimilar_hash }
 
-  it_behaves_like "a Rash",
-                  "FOO"  => "foo",
-                  :foo   => "foo",
-                  "foo"  => "foo",
-                  "f_oo" => "foo",
-                  "BIZ"  => "biz",
-                  :biz   => "biz",
-                  "biz"  => "biz",
-                  "b_iz" => "biz"
+  it_behaves_like 'a Rash',
+                  'FOO'  => 'foo',
+                  :foo   => 'foo',
+                  'foo'  => 'foo',
+                  'f_oo' => 'foo',
+                  'BIZ'  => 'biz',
+                  :biz   => 'biz',
+                  'biz'  => 'biz',
+                  'b_iz' => 'biz'
 
-  context "enumerable value" do
-    subject { rash["wiz"].first }
-    it_behaves_like "a Rash", "ab_c" => "abc"
+  context 'enumerable value' do
+    subject { rash['wiz'].first }
+    it_behaves_like 'a Rash', 'ab_c' => 'abc'
   end
 
-  context "nested hash value" do
-    subject { rash["ziz"] }
-    it_behaves_like "a Rash", "mom" => { "kid" => 2 }
+  context 'nested hash value' do
+    subject { rash['ziz'] }
+    it_behaves_like 'a Rash', 'mom' => { 'kid' => 2 }
 
-    context "deeply nested hash value" do
-      subject { rash["ziz"]["mom"] }
-      it_behaves_like "a Rash", "kid" => 2
+    context 'deeply nested hash value' do
+      subject { rash['ziz']['mom'] }
+      it_behaves_like 'a Rash', 'kid' => 2
     end
   end
 
-  describe "#select" do
-    subject { rash.select { |key, value| value.is_a? String } }
+  describe '#select' do
+    subject { rash.select { |_, value| value.is_a? String } }
     it { should be_a described_class }
-    it { should include "FOO" }
-    it { should_not include "WIZ" }
+    it { should include 'FOO' }
+    it { should_not include 'WIZ' }
   end
 
-  describe "#reject" do
-    subject { rash.reject { |key, value| value.is_a? String } }
+  describe '#reject' do
+    subject { rash.reject { |_, value| value.is_a? String } }
     it { should be_a described_class }
-    it { should include "WIZ" }
-    it { should_not include "FOO" }
+    it { should include 'WIZ' }
+    it { should_not include 'FOO' }
   end
 
-  describe "#values_at" do
-    subject { rash.values_at "FOO", "WIZ", "WRONG" }
-    it { should == ["foo", wiz, nil] }
+  describe '#values_at' do
+    subject { rash.values_at 'FOO', 'WIZ', 'WRONG' }
+    it { should == ['foo', wiz, nil] }
   end
 end

data/spec/units/stacker_bee/request_error_spec.rb

@@ -1,23 +1,23 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "An error occuring" do
+describe 'An error occuring' do
   let(:env)      { double(response: response) }
   let(:response) { double(status: status, error: error_text) }
-  let(:error_text) { "There was an error!" }
+  let(:error_text) { 'There was an error!' }
   let(:status)   { 431 }
 
-  describe StackerBee::RequestError, ".for" do
+  describe StackerBee::RequestError, '.for' do
     subject { described_class.for(env) }
 
-    context "HTTP status in the 400s" do
+    context 'HTTP status in the 400s' do
       let(:status) { 431 }
       it { should be_a StackerBee::ClientError }
     end
-    context "HTTP status in the 500s" do
+    context 'HTTP status in the 500s' do
       let(:status) { 500 }
       it { should be_a StackerBee::ServerError }
     end
-    context "HTTP status > 599" do
+    context 'HTTP status > 599' do
       let(:status) { 999 }
       it { should be_a StackerBee::RequestError }
     end