stacker_bee 2.1.1.pre252 → 2.1.1.pre263

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MjU3MzAwMzBhYzg3NWE5YzQ4ZTYyMzllMzU4MjdlNjk2MjI3ZTA2Yg==
+    NGZiMGQ0YTBhNmNhMjAzM2FhOWE1NWRjMmM0MWYxNjBlNjYzMmQwZg==
   data.tar.gz: !binary |-
-    YmU0NGU2MmUxNDllYzRmMzI4MmE0NGU1ZThhMWYwNDUwYTQ5M2Y5Mw==
+    NmMwOWM4YjdkYTk1NDJhODgzNTM4Yjg3MmIzNzcxMDg4MTA3ZWE1MQ==
 SHA512:
   metadata.gz: !binary |-
-    NzA1M2IwZGZkZWU4YTVlMDAyMmRlZmY0NTM0YWRmNzM1YWZmODI2NGQ2Yzdm
-    ZGUyYjgxMjFjNmEyNTExZDhiMTAyNjE2ZGU0NWU0M2M0ZTI5ZjYzYjUxN2M3
-    ODljNjZhY2Y1Y2JmNzkyNDc2Yzg1NGRiODBiNTMxZTE3MzBjNTk=
+    N2M0M2IxZTAwMTA0NzMzMDNhMTQxNjg5OWViNWM4YzVlM2E4MWYzODNmYThi
+    YmYzMzljMGI0Y2FjYzQ4MDVlNTJlNDJjYWNiMzhlODRkY2ZhYzM5MzVhMjFk
+    ODNmNmE2YTIwZTRhN2VkZWQ0NGQ5MTAxYTYyNTIwMTY3YWZlMWI=
   data.tar.gz: !binary |-
-    MzFhMDM2ZGRhYmI1ZWE2ZTA2NmE4ZGYyYTZmZGQzYzcyZjFlMWM2NTYyZWY0
-    ZjI1ODdiMDMzMGJkN2RmMTEwZjIzZTE2MzkyYzk4MGNiNjAyOTU1ZDYyZDBi
-    YzhhZGYwZWY5MTJlZGYyN2YwNzgxMDdkOTE4YTM1YzI0M2ZlYzk=
+    NGZkOWNiMjUzODU1YTI3MjFlOTdjYzVjNjgzN2NiMDMzYTk4ZGZkMWYyY2Qy
+    YzE3ZjU5YmM0ZTFjZDYyOTg3Y2Y1YTM4Mzk4NmFiZWIxNWI2ZWIxYTUwNzQ3
+    YTAyMmVlODU5ODNjNTQ0MjZjNTIxMWM2OTU4YjVkYjRhZWQ3ODU=

data/.rubocop.yml

@@ -6,8 +6,5 @@ Documentation:
 DoubleNegation:
   Enabled: false
 
-StringLiterals:
-  Enabled: false
-
 Encoding:
   Enabled: false

data/Rakefile

@@ -5,4 +5,4 @@ require 'rubocop/rake_task'
 task default: [:spec, :rubocop]
 
 RSpec::Core::RakeTask.new
-Rubocop::RakeTask.new
+RuboCop::RakeTask.new

data/bin/stacker_bee

@@ -1,6 +1,6 @@
 #! /usr/bin/env ruby
 
-$LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
+$LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 
 require 'optparse'
 require 'stacker_bee'
@@ -9,7 +9,7 @@ require 'yaml'
 require 'irb'
 require 'irb/completion'
 
-cli_title = "StackerBee CloudStack REPL"
+cli_title = 'StackerBee CloudStack REPL'
 
 command  = File.basename(__FILE__)
 options  = {}
@@ -21,27 +21,27 @@ optparse = OptionParser.new do |opts|
     Example: #{command} -u http://localhost:8080 -a MY_API_KEY -s MY_SECRET_KEY
   BANNER
 
-  config_help = "StackerBee configuration file, formatted as YAML"
+  config_help = 'StackerBee configuration file, formatted as YAML'
   opts.on('-c', '--config=/PATH/TO/CONFIG.yml', config_help) do |config|
     options[:config] = config
   end
-  opts.on('-a', '--api_key=API_KEY', "CloudStack API Key") do |key|
+  opts.on('-a', '--api_key=API_KEY', 'CloudStack API Key') do |key|
     options[:api_key] = key
   end
-  opts.on('-s', '--secret_key=SECRET_KEY', "CloudStack Secret Key") do |key|
+  opts.on('-s', '--secret_key=SECRET_KEY', 'CloudStack Secret Key') do |key|
     options[:secret_key] = key
   end
-  opts.on('-u', '--url=URL', "CloudStack URL") do |url|
+  opts.on('-u', '--url=URL', 'CloudStack URL') do |url|
     options[:url] = url
   end
-  opts.on('-v', '--[no-]verbose', 'Run verbosely') do |v|
+  opts.on('-v', '--[no-]verbose', 'Run verbosely') do
     verbose = true
   end
   opts.on('-h', '--help', 'Display this screen') do
     puts opts
 
     puts
-    puts "Example config file:"
+    puts 'Example config file:'
     puts
     puts "url: 'http://127.0.0.1:1234/client/api'"
     puts "api_key: 'MY_KEY-MY_KEY-MY_KEY'"
@@ -59,8 +59,8 @@ begin
   end
   unless options.keys.include?(:config) ||
     ([:api_key, :secret_key, :url] - options.keys).empty?
-    puts "Please specify a config file or all of the following: " \
-         "--api_key, --secret_key and --url"
+    puts 'Please specify a config file or all of the following: ' \
+         '--api_key, --secret_key and --url'
     exit
   end
 rescue OptionParser::InvalidOption, OptionParser::MissingArgument

data/lib/stacker_bee/api.rb

@@ -1,5 +1,5 @@
-require "multi_json"
-require "stacker_bee/utilities"
+require 'multi_json'
+require 'stacker_bee/utilities'
 
 module StackerBee
   class API
@@ -35,8 +35,8 @@ module StackerBee
     end
 
     def apis_by_endpoint(response)
-      response["listapisresponse"]["api"].each_with_object({}) do |api, memo|
-        memo[uncase(api["name"])] = api
+      response['listapisresponse']['api'].each_with_object({}) do |api, memo|
+        memo[uncase(api['name'])] = api
       end
     end
   end

data/lib/stacker_bee/client.rb

@@ -1,27 +1,27 @@
-require "forwardable"
-require "stacker_bee/builder"
-require "stacker_bee/configuration"
-require "stacker_bee/api"
-require "stacker_bee/connection"
-require "stacker_bee/middleware/environment"
-require "stacker_bee/middleware/base"
-require "stacker_bee/middleware/adapter"
-require "stacker_bee/middleware/endpoint_normalizer"
-require "stacker_bee/middleware/remove_empty_strings"
-require "stacker_bee/middleware/cloud_stack_api"
-require "stacker_bee/middleware/dictionary_flattener"
-require "stacker_bee/middleware/remove_nils"
-require "stacker_bee/middleware/format_keys"
-require "stacker_bee/middleware/format_values"
-require "stacker_bee/middleware/json_body"
-require "stacker_bee/middleware/de_namespace"
-require "stacker_bee/middleware/rashify_response"
-require "stacker_bee/middleware/clean_response"
-require "stacker_bee/middleware/raise_on_http_error"
-require "stacker_bee/middleware/http_status"
-require "stacker_bee/middleware/console_access"
-require "stacker_bee/middleware/error_message"
-require "stacker_bee/middleware/log_response"
+require 'forwardable'
+require 'stacker_bee/builder'
+require 'stacker_bee/configuration'
+require 'stacker_bee/api'
+require 'stacker_bee/connection'
+require 'stacker_bee/middleware/environment'
+require 'stacker_bee/middleware/base'
+require 'stacker_bee/middleware/adapter'
+require 'stacker_bee/middleware/endpoint_normalizer'
+require 'stacker_bee/middleware/remove_empty_strings'
+require 'stacker_bee/middleware/cloud_stack_api'
+require 'stacker_bee/middleware/dictionary_flattener'
+require 'stacker_bee/middleware/remove_nils'
+require 'stacker_bee/middleware/format_keys'
+require 'stacker_bee/middleware/format_values'
+require 'stacker_bee/middleware/json_body'
+require 'stacker_bee/middleware/de_namespace'
+require 'stacker_bee/middleware/rashify_response'
+require 'stacker_bee/middleware/clean_response'
+require 'stacker_bee/middleware/raise_on_http_error'
+require 'stacker_bee/middleware/http_status'
+require 'stacker_bee/middleware/console_access'
+require 'stacker_bee/middleware/error_message'
+require 'stacker_bee/middleware/log_response'
 
 # rubocop:disable ClassLength
 module StackerBee

data/lib/stacker_bee/configuration.rb

@@ -10,19 +10,25 @@ module StackerBee
       :api_key,
       :middlewares,
       :faraday_middlewares,
-      :logger
+      :logger,
+      :config
     ]
 
     def initialize(attrs = nil)
       @attributes = attrs || {}
-      @attributes.each_pair do |key, value|
-        next if key == :config
-        unless ATTRIBUTES.include?(key)
-          fail NoAttributeError, "No attribute defined: '#{key}'"
-        end
-      end
+      validate_attributes
     end
 
+    def validate_attributes
+      unknown_attributes = @attributes.keys - ATTRIBUTES
+      return if unknown_attributes.empty?
+
+      attribute_list = unknown_attributes.join(', ')
+      message = "No configuration attribute exists: #{attribute_list}"
+      fail NoAttributeError, message
+    end
+    private :validate_attributes
+
     def ssl_verify?
       attribute :ssl_verify, true
     end

data/lib/stacker_bee/connection.rb

@@ -1,7 +1,7 @@
-require "faraday"
-require "uri"
-require "stacker_bee/http_middleware/signed_query"
-require "stacker_bee/http_middleware/detokenizer"
+require 'faraday'
+require 'uri'
+require 'stacker_bee/http_middleware/signed_query'
+require 'stacker_bee/http_middleware/detokenizer'
 
 module StackerBee
   class ConnectionError < StandardError
@@ -15,7 +15,7 @@ module StackerBee
 
       uri = URI.parse(configuration.url)
       uri.path = ''
-      fail ConnectionError, "no protocol specified" unless uri.scheme
+      fail ConnectionError, 'no protocol specified' unless uri.scheme
 
       initialize_faraday(
         url: uri.to_s,

data/lib/stacker_bee/http_middleware/detokenizer.rb

@@ -1,5 +1,5 @@
-require "faraday"
-require "base64"
+require 'faraday'
+require 'base64'
 
 module StackerBee
   module HTTPMiddleware

data/lib/stacker_bee/http_middleware/signed_query.rb

@@ -1,12 +1,12 @@
-require "faraday"
-require "base64"
+require 'faraday'
+require 'base64'
 
 module StackerBee
   module HTTPMiddleware
     class SignedQuery < Faraday::Middleware
       def initialize(app, key)
         @key = key
-        fail "Key cannot be nil" unless @key
+        fail 'Key cannot be nil' unless @key
         super app
       end
 

data/lib/stacker_bee/middleware/adapter.rb

@@ -5,7 +5,7 @@ module StackerBee
         params = env.request.params.to_a.sort
         env.raw_response = connection.get(env.request.path, params)
         env.response.content_type =
-          env.raw_response.env[:response_headers]["content-type"]
+          env.raw_response.env[:response_headers]['content-type']
         env.response.body = env.raw_response.body
       end
 

data/lib/stacker_bee/middleware/base.rb

@@ -18,7 +18,7 @@ module StackerBee
         env.request.params = transform_params(env.request.params)
       end
 
-      def after(env)
+      def after(_env)
       end
 
       def transform_params(params)

data/lib/stacker_bee/middleware/clean_response.rb

@@ -18,11 +18,11 @@ module StackerBee
       end
 
       def contains_count?(body)
-        body.size == 2 && body.key?("count")
+        body.size == 2 && body.key?('count')
       end
 
       def remove_count(body)
-        body.reject { |key, val| key == "count" }.values.first
+        body.reject { |key, _| key == 'count' }.values.first
       end
 
       def single_hash?(body)

data/lib/stacker_bee/middleware/cloud_stack_api.rb

@@ -1,8 +1,8 @@
 module StackerBee
   module Middleware
     class CloudStackAPI < Base
-      RESPONSE_TYPE = "json"
-      DEFAULT_PATH  = "/client/api/"
+      RESPONSE_TYPE = 'json'
+      DEFAULT_PATH  = '/client/api/'
 
       def before(env)
         env.request.params.merge!(

data/lib/stacker_bee/middleware/dictionary_flattener.rb

@@ -1,8 +1,8 @@
 module StackerBee
   module Middleware
     class DictionaryFlattener < Base
-      LB = "SBLEFTBRACKET"
-      RB = "SBRIGHTBRACKET"
+      LB = 'SBLEFTBRACKET'
+      RB = 'SBRIGHTBRACKET'
 
       # TODO: should the tokenizing be separate from the flattener?
       # it could be a middleware that finds [] in the keys and replaces them
@@ -38,7 +38,7 @@ module StackerBee
 
       # TODO: isn't this done with the RemoveEmptyStrings middleware?
       def remove_falseish(hash)
-        hash.reject { |_, v| v == "" || v =~ /false/i || !v }
+        hash.reject { |_, v| v == '' || v =~ /false/i || !v }
       end
     end
   end

data/lib/stacker_bee/middleware/endpoint_normalizer.rb

@@ -8,10 +8,10 @@ module StackerBee
 
       def endpoint_name_for(name)
         # TODO: shouldn't this be in the base endpoint?
-        fail "API required" unless api
+        fail 'API required' unless api
         endpoint_description = api[name]
         if endpoint_description
-          endpoint_description.fetch("name")
+          endpoint_description.fetch('name')
         else
           super
         end

data/lib/stacker_bee/middleware/error_message.rb

@@ -2,9 +2,9 @@ module StackerBee
   module Middleware
     class ErrorMessage < Base
       def after(env)
-        unless env.response.success?
-          env.response.error = env.response.body[:errortext]
-        end
+        return if env.response.success?
+
+        env.response.error = env.response.body[:errortext]
       end
 
       def content_types

data/lib/stacker_bee/middleware/log_response.rb

@@ -4,7 +4,7 @@ module StackerBee
       def after(env)
         return unless env.logger
         params = env.request.params.to_a.sort
-        command = params.find { |key, _| key == "command" }.last
+        command = params.find { |key, _| key == 'command' }.last
 
         log(env, params, command)
       end

data/lib/stacker_bee/middleware/raise_on_http_error.rb

@@ -1,4 +1,4 @@
-require "stacker_bee/request_error"
+require 'stacker_bee/request_error'
 
 module StackerBee
   module Middleware

data/lib/stacker_bee/middleware/remove_nils.rb

@@ -2,7 +2,7 @@ module StackerBee
   module Middleware
     class RemoveNils < Base
       def transform_params(params)
-        params.reject { |key, val| val.nil? }
+        params.reject { |_, val| val.nil? }
       end
     end
   end

data/lib/stacker_bee/rash.rb

@@ -1,5 +1,5 @@
-require "forwardable"
-require "stacker_bee/utilities"
+require 'forwardable'
+require 'stacker_bee/utilities'
 
 module StackerBee
   class Rash
@@ -78,7 +78,7 @@ module StackerBee
     end
 
     def convert_key(key)
-      key.kind_of?(Numeric) ? key : uncase(key)
+      key.is_a?(Numeric) ? key : uncase(key)
     end
 
     def convert_value(value)

data/lib/stacker_bee/version.rb

@@ -1,3 +1,3 @@
 module StackerBee
-  VERSION = "2.1.1"
+  VERSION = '2.1.1'
 end

data/lib/stacker_bee.rb

@@ -1,2 +1,2 @@
-require_relative "stacker_bee/version"
-require_relative "stacker_bee/client"
+require_relative 'stacker_bee/version'
+require_relative 'stacker_bee/client'

data/spec/integration/configure_middleware_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
-describe "Configuring middlewares" do
+describe 'Configuring middlewares' do
   let(:configuration) do
     {
-      url:                 "http://garbagestring",
-      api_key:             "HI!",
-      secret_key:          "SECRET",
+      url:                 'http://garbagestring',
+      api_key:             'HI!',
+      secret_key:          'SECRET',
       faraday_middlewares: faraday_middlewares,
       middlewares:         middlewares
     }
@@ -19,21 +19,21 @@ describe "Configuring middlewares" do
 
   let(:body) do
     proc do
-      def call(env)
-        fail "MiddlewareUsed"
+      def call(_env)
+        fail 'MiddlewareUsed'
       end
     end
   end
 
   def self.it_uses_the_middleware
-    it "uses the middle ware" do
+    it 'uses the middle ware' do
       expect { subject.list_virtual_machines }
-        .to raise_exception "MiddlewareUsed"
+        .to raise_exception 'MiddlewareUsed'
     end
   end
 
   def self.it_configures_a_faraday_middleware
-    describe "a Faraday middleware" do
+    describe 'a Faraday middleware' do
       let(:faraday_middlewares) do
         ->(faraday) { faraday.use faraday_middleware_class }
       end
@@ -43,7 +43,7 @@ describe "Configuring middlewares" do
   end
 
   def self.it_configures_a_middleware
-    describe "a StackerBee middleware" do
+    describe 'a StackerBee middleware' do
       let(:middlewares) do
         ->(builder) { builder.use middleware_class }
       end
@@ -51,7 +51,7 @@ describe "Configuring middlewares" do
     end
   end
 
-  describe "via StackerBee::Client.configuration=" do
+  describe 'via StackerBee::Client.configuration=' do
     subject { StackerBee::Client.new }
     before  { StackerBee::Client.configuration = configuration }
 
@@ -59,7 +59,7 @@ describe "Configuring middlewares" do
     it_configures_a_faraday_middleware
   end
 
-  describe "via the Client initializer" do
+  describe 'via the Client initializer' do
     subject { StackerBee::Client.new(configuration) }
 
     it_configures_a_middleware

data/spec/integration/console_spec.rb

@@ -1,9 +1,9 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "A request sent to CloudStack for console access", :vcr do
+describe 'A request sent to CloudStack for console access', :vcr do
   subject(:console_access) { client.console_access(vm: vm) }
 
-  let(:vm) { "36f9c08b-f17a-4d0e-ac9b-d45ce2d34fcd" }
+  let(:vm) { '36f9c08b-f17a-4d0e-ac9b-d45ce2d34fcd' }
   let(:client) { StackerBee::Client.new(config_hash) }
   let(:config_hash) do
     {
@@ -13,7 +13,7 @@ describe "A request sent to CloudStack for console access", :vcr do
     }
   end
 
-  it "returns html for console access" do
+  it 'returns html for console access' do
     expect(console_access).to match(/<html>.*<frame src=.*<\/html>/)
   end
 end