sproutcore 1.9.2 → 1.10.0.rc.1

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/border_frame_test.js

@@ -0,0 +1,174 @@
+// ==========================================================================
+// Project:   Showcase
+// Copyright: ©2012 7x7 Software, Inc.
+// License:   Licensed under MIT license
+// ==========================================================================
+/*global module, test, same*/
+
+var view;
+module("SC.View#borderFrame", {
+  setup: function () {
+    SC.run(function () {
+      view = SC.View.create({
+        layout: { width: 100, height: 100 }
+      });
+    });
+  },
+
+  teardown: function () {
+    view.destroy();
+    view = null;
+  }
+});
+
+test("The borderFrame property of the view should include the borders from the layout.", function () {
+  var borderFrame,
+    frame;
+
+  // No borders.
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 0, y: 0, width: 100, height: 100 }, "The frame without borders is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame without borders is");
+
+  // Right 5px border.
+  SC.run(function () {
+    view.adjust('borderRight', 5);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 0, y: 0, width: 95, height: 100 }, "The frame with 5px right border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border is");
+
+  // Top 10px border.
+  SC.run(function () {
+    view.adjust('borderTop', 10);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 0, y: 10, width: 95, height: 90 }, "The frame with 5px right border & 10px top border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border & 10px top border is");
+
+  // Left 15px border.
+  SC.run(function () {
+    view.adjust('borderLeft', 15);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 15, y: 10, width: 80, height: 90 }, "The frame with 5px right border & 10px top border & 15px left border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border & 10px top border & 15px left border is");
+
+  // Bottom 20px border.
+  SC.run(function () {
+    view.adjust('borderBottom', 20);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 15, y: 10, width: 80, height: 70 }, "The frame with 5px right border & 10px top border & 15px left border & 20px bottom border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border & 10px top border & 15px left border & 20px bottom border is");
+
+  // 25px border.
+  SC.run(function () {
+    view.set('layout', { width: 100, height: 100, border: 25 });
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 25, y: 25, width: 50, height: 50 }, "The frame with 25px border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 25px border is");
+
+});
+
+
+test("The borderFrame property of the view should be correct for view with useStaticLayout.", function () {
+  var borderFrame,
+    frame,
+    pane;
+
+  view.set('useStaticLayout', true);
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, null, "The frame with useStaticLayout true is");
+  same(borderFrame, null, "The borderFrame with useStaticLayout true is");
+
+  SC.run(function () {
+    pane = SC.Pane.create({
+      childViews: [view]
+    }).append();
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 0, y: 0, width: 100, height: 100 }, "The frame with useStaticLayout true after rendering is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with useStaticLayout true after rendering is");
+
+  // Right 5px border.
+  SC.run(function () {
+    view.adjust('borderRight', 5);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 0, y: 0, width: 95, height: 100 }, "The frame with 5px right border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border is");
+
+  // Top 10px border.
+  SC.run(function () {
+    view.adjust('borderTop', 10);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 0, y: 10, width: 95, height: 90 }, "The frame with 5px right border & 10px top border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border & 10px top border is");
+
+  // Left 15px border.
+  SC.run(function () {
+    view.adjust('borderLeft', 15);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 15, y: 10, width: 80, height: 90 }, "The frame with 5px right border & 10px top border & 15px left border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border & 10px top border & 15px left border is");
+
+  // Bottom 20px border.
+  SC.run(function () {
+    view.adjust('borderBottom', 20);
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 15, y: 10, width: 80, height: 70 }, "The frame with 5px right border & 10px top border & 15px left border & 20px bottom border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 5px right border & 10px top border & 15px left border & 20px bottom border is");
+
+  // 25px border.
+  SC.run(function () {
+    view.set('layout', { width: 100, height: 100, border: 25 });
+  });
+
+  frame = view.get('frame');
+  borderFrame = view.get('borderFrame');
+
+  same(frame, { x: 25, y: 25, width: 50, height: 50 }, "The frame with 25px border is");
+  same(borderFrame, { x: 0, y: 0, width: 100, height: 100 }, "The borderFrame with 25px border is");
+
+  pane.destroy();
+});

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/build.js

@@ -3,57 +3,59 @@
 // Copyright: ©2006-2011 Apple Inc. and contributors.
 // License:   Licensed under MIT license (see license.js)
 // ==========================================================================
-/*global module test equals context ok same */
+/*global module test ok */
 
 var buildableView, parent;
 module('SC.Buildable', {
-  setup: function() {
+  setup: function () {
     parent = SC.View.create();
     buildableView = SC.View.create({
-      buildIn: function() {
+      buildIn: function () {
         this.called_any = YES;
         this.called_buildIn = YES;
       },
-      
-      resetBuild: function() {
+
+      resetBuild: function () {
         this.called_any = YES;
         this.called_resetBuild = YES;
       },
-      
-      buildOut: function() {
+
+      buildOut: function () {
         this.called_any = YES;
         this.called_buildOut = YES;
       },
-      
-      buildOutDidCancel: function() {
+
+      buildOutDidCancel: function () {
         this.called_any = YES;
         this.called_buildOutDidCancel = YES;
       },
-      
-      buildInDidCancel: function() {
+
+      buildInDidCancel: function () {
         this.called_any = YES;
         this.called_buildInDidCancel = YES;
       }
     });
   },
-  
-  teardown: function() {
+
+  teardown: function () {
+    parent.destroy();
+    buildableView.destroy();
   }
 });
 
-test("resetBuildState calls resetBuild", function(){
+test("resetBuildState calls resetBuild", function (){
   ok(!buildableView.called_any, "Nothing should have happened yet.");
   buildableView.resetBuildState();
   ok(buildableView.called_resetBuild, "reset should have been called");
 });
 
-test("changing parent view calls resetBuild", function() {
+test("changing parent view calls resetBuild", function () {
   ok(!buildableView.called_any, "Nothing should have happened yet.");
   parent.appendChild(buildableView);
   ok(buildableView.called_resetBuild, "reset should have been called");
 });
 
-test("buildInToView starts build in", function() {
+test("buildInToView starts build in", function () {
   buildableView.willBuildInToView(parent);
   ok(!buildableView.isBuildingIn, "Should not be building in yet.");
   buildableView.buildInToView(parent);
@@ -61,24 +63,24 @@ test("buildInToView starts build in", function() {
   ok(buildableView.called_buildIn, "Build in should have been called.");
 });
 
-test("buildOutFromView starts build out", function() {
+test("buildOutFromView starts build out", function () {
   buildableView.willBuildInToView(parent);
   buildableView.buildInToView(parent);
   buildableView.buildInDidFinish(); // hack this in here, because our implementations above purposefully don't.
-  
+
   ok(!buildableView.isBuildingOut, "Should not yet be building out.");
   buildableView.buildOutFromView(parent);
   ok(buildableView.isBuildingOut, "View should now be building out.");
 });
 
-test("resetBuildState cancels buildOut", function() {
+test("resetBuildState cancels buildOut", function () {
   buildableView.willBuildInToView(parent);
   buildableView.buildInToView(parent);
   buildableView.buildInDidFinish(); // hack this in here, because our implementations above purposefully don't.
 
   buildableView.buildOutFromView(parent);
   ok(buildableView.isBuildingOut, "View should now be building out.");
-  
+
   buildableView.resetBuildState(parent);
   ok(!buildableView.isBuildingOut, "View should no longer be building out.");
   ok(buildableView.called_buildOutDidCancel, "Cancel ought to have been called.");

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/childViewLayout_test.js

@@ -0,0 +1,27 @@
+// ==========================================================================
+// Project:   SproutCore - JavaScript Application Framework
+// Copyright: ©2013 7x7 Software, Inc.
+// License:   Licensed under MIT license (see license.js)
+// ==========================================================================
+
+/*global module, test, equals, ok */
+
+var view;
+
+/** Test the SC.View states. */
+module("SC.View:childViewLayout", {
+
+  setup: function () {
+    view = SC.View.create();
+  },
+
+  teardown: function () {
+    view.destroy();
+    view = null;
+  }
+
+});
+
+test("", function () {
+
+});

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/clippingFrame.js

@@ -22,9 +22,10 @@ module("SC.View#clippingFrame", {
     a = pane.childViews[0];
     aa = a.childViews[0];
   },
-  
-  teardown: function() { 
+
+  teardown: function() {
     pane.remove();
+    pane.destroy();
     pane = a = aa = null ;
     SC.RunLoop.end();
     clearHtmlbody();
@@ -47,7 +48,7 @@ test("clippingFrame === frame w/ 0 offset if not partially hidden", function() {
 
 test("cuts off top of frame", function() {
   var result, expected;
-  
+
   a.adjust('top', -50);
   result = a.get('clippingFrame'); expected = a.get('frame');
   expected.x = 0 ; expected.y = 50 ; expected.height = 50 ;
@@ -60,7 +61,7 @@ test("cuts off top of frame", function() {
 
 test("cuts off bottom of frame", function() {
   var result, expected;
-  
+
   a.adjust('top', 150);
   result = a.get('clippingFrame'); expected = a.get('frame');
   expected.x = 0 ; expected.y = 0 ; expected.height = 50 ;
@@ -73,7 +74,7 @@ test("cuts off bottom of frame", function() {
 
 test("cuts off left of frame", function() {
   var result, expected;
-  
+
   a.adjust('left', -50);
   result = a.get('clippingFrame'); expected = a.get('frame');
   expected.y = 0 ; expected.x = 50 ; expected.width = 50 ;
@@ -86,7 +87,7 @@ test("cuts off left of frame", function() {
 
 test("cuts off right of frame", function() {
   var result, expected;
-  
+
   a.adjust('left', 150);
   result = a.get('clippingFrame'); expected = a.get('frame');
   expected.y = 0 ; expected.x = 0 ; expected.width = 50 ;
@@ -99,19 +100,19 @@ test("cuts off right of frame", function() {
 
 test("notifies receiver and each child if parent clipping frame changes", function() {
   var callCount = 0;
-  
+
   // setup observers
   function observer() { callCount++; }
   a.addObserver('clippingFrame', observer);
   aa.addObserver('clippingFrame', observer);
-  
+
   // now, adjust layout of child so that clipping frame will change...
   a.adjust('top', -50);
-  
+
   // IMPORTANT:  If this test fails because the callCount is > 2 it means that
   // when you set the layout, the frame is getting invalidated more than once.
   // This should not happen.  If this is the case, fix the view code so that
-  // it does not invalidate frame more than once before you change this 
+  // it does not invalidate frame more than once before you change this
   // number.
   equals(callCount, 2, 'should invoke observer on child and nested child');
 });

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/convertFrames.js

@@ -9,8 +9,8 @@
 
 // ..........................................................
 // COMMON SETUP CODE
-// 
-var pane, a, b, aa, aaa, bb, f ; 
+//
+var pane, a, b, aa, aaa, bb, f ;
 var A_LEFT = 10, A_TOP = 10, B_LEFT = 100, B_TOP = 100;
 
 function setupFrameViews() {
@@ -30,19 +30,20 @@ function setupFrameViews() {
       .childView(SC.View.design()
         .layout({ top: B_TOP, left: B_LEFT, width: 10, height: 10 })))
     .create();
-        
+
   a = pane.childViews[0];
   b = pane.childViews[1];
   aa = a.childViews[0];
   aaa = aa.childViews[0];
   bb = b.childViews[0];
-  
+
   f = { x: 10, y: 10, width: 10, height: 10 };
   pane.append();
 }
 
 function teardownFrameViews() {
   pane.remove() ;
+  pane.destroy();
   pane = a = aa = aaa = b = bb = null ;
   clearHtmlbody();
 }

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/createChildViews.js

@@ -50,6 +50,8 @@ test("should not error when there is a dud view name in childViews list.", funct
   var v = SC.View.create({
     childViews: [
       'nonExistantClassName',       // string - should NOT be called
+      null,                       // null - should NOT be called
+      '',                         // empty string - should NOT be called
       'customClassName'          // string - should be called
     ],
     // this should be used for the 'customClassName' item above
@@ -65,6 +67,7 @@ test("should not error when there is a dud view name in childViews list.", funct
 
   // createChildViews() is called automatically during create.
   same(called, [2], 'called createChildView for correct children');
+  equals(v.getPath('childViews.length'), 1, "The childViews array should not contain any invalid childViews after creation.");
 });
 
 test("should not throw error when there is an extra space in the childViews list", function() {
@@ -121,12 +124,13 @@ test("should set newView.page to receiver.page unless custom attr is passed", fu
   equals(v.get('page'), myPage, 'v.page == custom page');
 });
 
-test("should not change isVisibleInWindow property on views that do not have visibility support", function() {
-  var coreView = SC.CoreView.extend({});
+// CoreView has basic visibility support based on state now.
+// test("should not change isVisibleInWindow property on views that do not have visibility support", function() {
+//   var coreView = SC.CoreView.extend({});
 
-  SC.run(function() { view.set('isVisible', NO); });
-  var v = view.createChildView(coreView);
+//   SC.run(function() { view.set('isVisible', NO); });
+//   var v = view.createChildView(coreView);
 
-  ok(v.get('isVisibleInWindow'), "SC.CoreView instance always has isVisibleInWindow set to NO");
-});
+//   ok(v.get('isVisibleInWindow'), "SC.CoreView instance always has isVisibleInWindow set to NO");
+// });