sproutcore 1.9.2 → 1.10.0.rc.1

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/system/theme.js

@@ -15,19 +15,19 @@ module("SC.Theme", {
     // make and register Ace
     Ace = SC.Theme.create({
       name: 'ace',
-      "classNames": ["ace"]
+      classNames: ["ace"]
     });
     SC.Theme.addTheme(Ace);
-    
+
     // Dark
     Dark = Ace.subtheme("dark");
-    
+
     // Capsule
     Capsule = Ace.subtheme("capsule");
   },
-  
+
   teardown: function() {
-    
+
   }
 });
 
@@ -36,7 +36,7 @@ function themeIs(themeInstance, shouldBe, classNames) {
   ok(themeInstance === shouldBe, "Correct theme");
   if (!themeInstance) return;
 
-  var isOk = same(themeInstance.classNames, SC.Set.create(classNames), "Correct class names.");
+  var isOk = same(themeInstance.classNames, classNames, "Correct class names.");
 }
 
 test("Calling SC.Theme.find finds proper theme.", function(){
@@ -72,7 +72,7 @@ test("Calling find on a subtheme instance finds the proper theme.", function(){
   themeIs(capsule.baseTheme, Capsule, ["ace", "capsule"]);
 
   // and now we are testing said specialization
-  themeIs(capsule, capsule, ["ace", "dark", "capsule"]);
+  themeIs(capsule, capsule, ["ace", "capsule", "dark"]);
 });
 
 

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/main_pane.js

@@ -11,9 +11,9 @@
 
 // ..........................................................
 // BASE TESTS
-// 
-// These tests exercise the API.  See below for tests that cover edge 
-// conditions.  If you find a bug, we recommend that you add a test in the 
+//
+// These tests exercise the API.  See below for tests that cover edge
+// conditions.  If you find a bug, we recommend that you add a test in the
 // edge case section.
 
 (function() {
@@ -28,6 +28,7 @@
 
     teardown: function() {
       pane.remove();
+      pane.destroy();
     }
   });
 

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/pane/append_remove.js

@@ -39,6 +39,9 @@ test("adding to document for first time - appendTo(elem)", function() {
   equals(layer.parentNode, elem, 'layer should belong to parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 test("adding to document for first time - appendTo(string)", function() {
@@ -53,6 +56,9 @@ test("adding to document for first time - appendTo(string)", function() {
   equals(layer.parentNode, jQuery("#appendtest")[0], 'layer should belong to parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 test("adding to document for first time - appendTo(jquery)", function() {
@@ -67,6 +73,9 @@ test("adding to document for first time - appendTo(jquery)", function() {
   equals(layer.parentNode, jQuery("#appendtest")[0], 'layer should belong to parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 test("adding to document for first time - prependTo(elem)", function() {
@@ -84,6 +93,9 @@ test("adding to document for first time - prependTo(elem)", function() {
   equals(layer.parentNode, elem, 'layer should belong to parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 test("adding to document for first time - prependTo(string)", function() {
@@ -98,6 +110,9 @@ test("adding to document for first time - prependTo(string)", function() {
   equals(layer.parentNode, jQuery("#appendtest")[0], 'layer should belong to parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 test("adding to document for first time - prependTo(jquery)", function() {
@@ -112,6 +127,9 @@ test("adding to document for first time - prependTo(jquery)", function() {
   equals(layer.parentNode, jQuery("#appendtest")[0], 'layer should belong to parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 
@@ -127,22 +145,9 @@ test("adding a pane twice should have no effect", function() {
   pane.append();
   pane.append();
   equals(cnt, 1, 'should only append once');
-});
-
-test("readding pane", function() {
-  var pane = SC.Pane.create();
-  var elem1 = Q$('body').get(0), elem2 = Q$('#appendtest').get(0);
-  ok(elem1 && elem2, 'precond - has elem1 && elem2: elem1=%@ elem2=%@'.fmt(elem1, elem2));
-
-  pane.appendTo(elem1);
-  var layer = pane.get('layer');
-  ok(layer, 'has layer');
-  equals(layer.parentNode, elem1, 'layer belongs to parent');
 
-  pane.appendTo(elem2);
-  equals(layer.parentNode, elem2, 'layer moved to new parent');
-  ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
-  ok(pane.rootResponder, 'should have rootResponder');
+  // Clean up.
+  pane.destroy();
 });
 
 test("adding/remove/adding pane", function() {
@@ -163,6 +168,9 @@ test("adding/remove/adding pane", function() {
   equals(layer.parentNode, elem2, 'layer moved to new parent');
   ok(pane.get('isVisibleInWindow'), 'isVisibleInWindow should  = YES');
   ok(pane.rootResponder, 'should have rootResponder');
+
+  // Clean up.
+  pane.destroy();
 });
 
 test("removeFromParent throws an exception", function() {
@@ -179,6 +187,9 @@ test("removeFromParent throws an exception", function() {
   }
 
   ok(exceptionCaught, "trying to call removeFromParent on a pane throws an exception");
+
+  // Clean up.
+  pane.destroy();
 });
 
 // ..........................................................
@@ -198,6 +209,9 @@ test("removes pane from DOM", function() {
   pane.remove();
   ok(layer.parentNode !== elem, 'layer no longer belongs to parent');
   ok(!pane.get('isVisibleInWindow'), 'isVisibleInWindow is NO');
+
+  // Clean up.
+  pane.destroy();
 });
 
 
@@ -220,5 +234,7 @@ test("updates frame and clippingFrame when loading MainPane", function() {
   equals(pane.get('frame').width, w, 'frame width should have changed');
   equals(pane.get('clippingFrame').width, w, 'clippingFrame width should have changed');
 
+  // Clean up.
+  pane.destroy();
 });
 

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/pane/child_view.js

@@ -4,9 +4,12 @@
 //            ©2008-2011 Apple Inc. All rights reserved.
 // License:   Licensed under MIT license (see license.js)
 // ==========================================================================
+/*global ok, equals, expect, test, module*/
+
+
 module("SC.Pane - childViews");
 
-test("SC.Pane should not attempt to recompute visibility on child views that do not have visibility support", function() {
+test("SC.Pane should not attempt to recompute visibility on child views that do not have visibility support", function () {
   var pane = SC.Pane.create({
     childViews: ['noVisibility'],
 
@@ -18,9 +21,51 @@ test("SC.Pane should not attempt to recompute visibility on child views that do
 
   try {
     pane.append();
-  } catch(e) {
+  } catch (e) {
     errored = YES;
   }
 
   ok(!errored, "appending a pane with child views without visibility does not result in an error");
+  pane.remove();
+
+  // Clean up.
+  pane.destroy();
+});
+
+test("SC.Pane should only render once when appended.", function () {
+  var pane = SC.Pane.create({
+    childViews: ['child'],
+
+    paneValue: null,
+
+    render: function () {
+      ok(true, 'Render was called once on pane.');
+    },
+
+    child: SC.View.extend({
+      childValueBinding: SC.Binding.oneWay('.pane.paneValue').transform(
+        function (paneValue) {
+          equals(paneValue, 'bar', "Bound value should be set once to 'bar'");
+
+          return paneValue;
+        }),
+      render: function () {
+        ok(true, 'Render was called once on child.');
+      }
+    })
+  });
+
+  SC.run(function () {
+    pane.append();
+
+    pane.set('paneValue', 'foo');
+    pane.set('paneValue', 'bar');
+  });
+
+  pane.remove();
+
+  expect(3);
+
+  // Clean up.
+  pane.destroy();
 });

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/pane/firstResponder.js

@@ -14,35 +14,36 @@ CommonSetup = {
     });
     view0 = pane.childViews[0];
     view1 = pane.childViews[1];
-    
+
     pane.append(); // make visible so it will have root responder
     r = pane.get('rootResponder');
     ok(r, 'has root responder');
   },
   teardown: function() {
     pane.remove();
+    pane.destroy();
     pane = r = view0 = view1 = null ;
   }
 };
 
 // ..........................................................
 // makeFirstResponder()
-// 
+//
 module("SC.Pane#makeFirstResponder", CommonSetup);
 
 test("make firstResponder from null, not keyPane", function() {
   var okCount = 0, badCount = 0;
   view0.didBecomeFirstResponder = function() { okCount ++; };
-  
+
   view0.willBecomeKeyResponderFrom = view0.didBecomeKeyResponderFrom =
     function() { badCount ++; };
-    
+
   pane.makeFirstResponder(view0);
   equals(okCount, 1, 'should invoke didBecomeFirstResponder callbacks');
   equals(badCount, 0, 'should not invoke ..BecomeKeyResponder callbacks');
-  
+
   equals(pane.get('firstResponder'), view0, 'should set firstResponder to view');
-  
+
   ok(view0.get('isFirstResponder'), 'should set view.isFirstResponder to YES');
   ok(!view0.get('isKeyResponder'), 'should not set view.isKeyResponder');
 });
@@ -50,99 +51,99 @@ test("make firstResponder from null, not keyPane", function() {
 
 test("make firstResponder from null, is keyPane", function() {
   var okCount = 0 ;
-  view0.didBecomeFirstResponder = 
+  view0.didBecomeFirstResponder =
   view0.willBecomeKeyResponderFrom = view0.didBecomeKeyResponderFrom =
     function() { okCount++; };
 
   pane.becomeKeyPane();
   pane.makeFirstResponder(view0);
   equals(okCount, 3, 'should invoke didBecomeFirstResponder + KeyResponder callbacks');
-  
+
   equals(pane.get('firstResponder'), view0, 'should set firstResponder to view');
-  
+
   ok(view0.get('isFirstResponder'), 'should set view.isFirstResponder to YES');
   ok(view0.get('isKeyResponder'), 'should set view.isKeyResponder');
 });
 
 
 test("make firstResponder from other view, not keyPane", function() {
-  
+
   // preliminary setup
   pane.makeFirstResponder(view1);
   equals(pane.get('firstResponder'), view1, 'precond - view1 is firstResponder');
-  
+
   var okCount = 0, badCount = 0;
   view0.didBecomeFirstResponder = function() { okCount ++; };
   view1.willLoseFirstResponder = function() { okCount ++; };
-  
+
   view0.willBecomeKeyResponderFrom = view0.didBecomeKeyResponderFrom =
     function() { badCount ++; };
   view1.willLoseKeyResponderTo = view0.didLoseKeyResponderTo =
     function() { badCount ++; };
-    
+
   pane.makeFirstResponder(view0);
   equals(okCount, 2, 'should invoke ..BecomeFirstResponder callbacks');
   equals(badCount, 0, 'should not invoke ..BecomeKeyResponder callbacks');
-  
+
   equals(pane.get('firstResponder'), view0, 'should set firstResponder to view');
-  
+
   ok(view0.get('isFirstResponder'), 'should set view.isFirstResponder to YES');
   ok(!view0.get('isKeyResponder'), 'should not set view.isKeyResponder');
-  
+
   ok(!view1.get('isFirstResponder'), 'view1.isFirstResponder should now be set to NO');
-  
+
 });
 
 
 test("make firstResponder from other view, as keyPane", function() {
-  
+
   // preliminary setup
   pane.becomeKeyPane();
   pane.makeFirstResponder(view1);
   equals(pane.get('firstResponder'), view1, 'precond - view1 is firstResponder');
   ok(view1.get('isFirstResponder'), 'precond - view1.isFirstResponder should be YES');
   ok(view1.get('isKeyResponder'), 'precond - view1.isFirstResponder should be YES');
-  
+
   var okCount = 0 ;
-  view0.didBecomeFirstResponder = view1.willLoseFirstResponder = 
+  view0.didBecomeFirstResponder = view1.willLoseFirstResponder =
   view0.willBecomeKeyResponderFrom = view0.didBecomeKeyResponderFrom =
   view1.willLoseKeyResponderTo = view1.didLoseKeyResponderTo =
     function() { okCount ++; };
-    
+
   pane.makeFirstResponder(view0);
   equals(okCount, 6, 'should invoke FirstResponder + KeyResponder callbacks on both views');
-  
+
   equals(pane.get('firstResponder'), view0, 'should set firstResponder to view');
-  
+
   ok(view0.get('isFirstResponder'), 'should set view.isFirstResponder to YES');
   ok(view0.get('isKeyResponder'), 'should set view.isKeyResponder');
-  
+
   ok(!view1.get('isFirstResponder'), 'view1.isFirstResponder should now be set to NO');
   ok(!view1.get('isKeyResponder'), 'view1.isFirstResponder should now be set to NO');
-  
+
 });
 
 
 test("makeFirstResponder(view) when view is already first responder", function() {
-  
+
   // preliminary setup
   pane.becomeKeyPane();
   pane.makeFirstResponder(view0);
   equals(pane.get('firstResponder'), view0, 'precond - view0 is firstResponder');
   ok(view0.get('isFirstResponder'), 'precond - view0.isFirstResponder should be YES');
   ok(view0.get('isKeyResponder'), 'precond - view0.isFirstResponder should be YES');
-  
+
   var callCount = 0 ;
-  view0.didBecomeFirstResponder = view0.willLoseFirstResponder = 
+  view0.didBecomeFirstResponder = view0.willLoseFirstResponder =
   view0.willBecomeKeyResponderFrom = view0.didBecomeKeyResponderFrom =
   view0.willLoseKeyResponderTo = view0.didLoseKeyResponderTo =
     function() { callCount ++; };
-    
+
   pane.makeFirstResponder(view0);
   equals(callCount, 0, 'should invoke no FirstResponder + KeyResponder callbacks on view');
-  
+
   equals(pane.get('firstResponder'), view0, 'should keep firstResponder to view');
   ok(view0.get('isFirstResponder'), 'should keep view.isFirstResponder to YES');
   ok(view0.get('isKeyResponder'), 'should keep view.isKeyResponder');
-  
+
 });

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/pane/keyPane.js

@@ -14,25 +14,26 @@ CommonSetup = {
     });
     view = pane.childViews[0];
     pane.makeFirstResponder(view);
-    
+
     pane.append(); // make visible so it will have root responder
     r = pane.get('rootResponder');
     ok(r, 'has root responder');
   },
   teardown: function() {
     pane.remove();
+    pane.destroy();
     pane = r = view = null ;
   }
 };
 
 // ..........................................................
 // becomeKeyPane()
-// 
+//
 module("SC.Pane#becomeKeyPane", CommonSetup);
 
 test("should become keyPane if not already keyPane", function() {
   ok(r.get('keyPane') !== pane, 'precond - pane is not currently key');
-  
+
   pane.becomeKeyPane();
   equals(r.get('keyPane'), pane, 'pane should be keyPane');
   equals(pane.get('isKeyPane'), YES, 'isKeyPane should be set to YES');
@@ -40,7 +41,7 @@ test("should become keyPane if not already keyPane", function() {
 
 test("should do nothing if acceptsKeyPane is NO", function() {
   ok(r.get('keyPane') !== pane, 'precond - pane is not currently key');
-  
+
   pane.acceptsKeyPane = NO ;
   pane.becomeKeyPane();
   ok(r.get('keyPane') !== pane, 'pane should not be keyPane');
@@ -49,13 +50,13 @@ test("should do nothing if acceptsKeyPane is NO", function() {
 
 test("should invoke willBecomeKeyPane & didBecomeKeyPane", function() {
   var callCount = 0 ;
-  pane.willBecomeKeyPaneFrom = pane.didBecomeKeyPaneFrom = function() { 
-    callCount++; 
+  pane.willBecomeKeyPaneFrom = pane.didBecomeKeyPaneFrom = function() {
+    callCount++;
   };
-  
+
   pane.becomeKeyPane();
   equals(callCount, 2, 'should invoke both callbacks');
-  
+
   callCount = 0;
   pane.becomeKeyPane();
   equals(callCount, 0, 'should not invoke callbacks if already key pane');
@@ -63,12 +64,12 @@ test("should invoke willBecomeKeyPane & didBecomeKeyPane", function() {
 
 test("should invoke callbacks and update isKeyResponder state on firstResponder", function() {
   var callCount = 0;
-  view.willBecomeKeyResponderFrom = view.didBecomeKeyResponderFrom = 
+  view.willBecomeKeyResponderFrom = view.didBecomeKeyResponderFrom =
     function() { callCount++; };
-  
+
   equals(view.get('isKeyResponder'), NO, 'precond - view is not keyResponder');
   equals(view.get('isFirstResponder'), YES, 'precond - view is firstResponder');
-  
+
   pane.becomeKeyPane();
   equals(callCount, 2, 'should invoke both callbacks');
   equals(view.get('isKeyResponder'), YES, 'should be keyResponder');
@@ -76,24 +77,24 @@ test("should invoke callbacks and update isKeyResponder state on firstResponder"
 
 // ..........................................................
 // resignKeyPane()
-// 
+//
 module("SC.Pane#resignKeyPane", CommonSetup);
 
 test("should resign keyPane if keyPane", function() {
   pane.becomeKeyPane();
   ok(r.get('keyPane') === pane, 'precond - pane is currently key');
-  
+
   pane.resignKeyPane();
   ok(r.get('keyPane') !== pane, 'pane should NOT be keyPane');
   equals(pane.get('isKeyPane'), NO, 'isKeyPane should be set to NO');
 });
 
-// technically this shouldn't happen, but someone could screw up and change 
+// technically this shouldn't happen, but someone could screw up and change
 // acceptsKeyPane to NO once the pane has already become key
 test("should still resign if acceptsKeyPane is NO", function() {
   pane.becomeKeyPane();
   ok(r.get('keyPane') === pane, 'precond - pane is currently key');
-  
+
   pane.acceptsKeyPane = NO ;
   pane.resignKeyPane();
   ok(r.get('keyPane') !== pane, 'pane should NOT be keyPane');
@@ -105,13 +106,13 @@ test("should invoke willLoseKeyPaneTo & didLoseKeyPaneTo", function() {
   ok(r.get('keyPane') === pane, 'precond - pane is currently key');
 
   var callCount = 0 ;
-  pane.willLoseKeyPaneTo = pane.didLoseKeyPaneTo = function() { 
-    callCount++; 
+  pane.willLoseKeyPaneTo = pane.didLoseKeyPaneTo = function() {
+    callCount++;
   };
-  
+
   pane.resignKeyPane();
   equals(callCount, 2, 'should invoke both callbacks');
-  
+
   callCount = 0;
   pane.resignKeyPane();
   equals(callCount, 0, 'should not invoke callbacks if already key pane');
@@ -119,13 +120,13 @@ test("should invoke willLoseKeyPaneTo & didLoseKeyPaneTo", function() {
 
 test("should invoke callbacks and update isKeyResponder state on firstResponder", function() {
   var callCount = 0;
-  view.willLoseKeyResponderTo = view.didLoseKeyResponderTo = 
+  view.willLoseKeyResponderTo = view.didLoseKeyResponderTo =
     function() { callCount++; };
-  
+
   pane.becomeKeyPane();
   equals(view.get('isKeyResponder'), YES, 'precond - view is keyResponder');
   equals(view.get('isFirstResponder'), YES, 'precond - view is firstResponder');
-  
+
   pane.resignKeyPane();
   equals(callCount, 2, 'should invoke both callbacks');
   equals(view.get('isKeyResponder'), NO, 'should be keyResponder');