sproutcore 1.10.3.1 → 1.11.0.rc1

data/lib/frameworks/sproutcore/frameworks/routing/system/routes.js

@@ -246,19 +246,24 @@ SC.routes = SC.Object.create(
         value = crumbs.route + crumbs.params;
       }
 
-      if (!SC.empty(value) || (this._location && this._location !== value)) {
-        encodedValue = encodeURI(value);
-
-        if (this.usesHistory) {
-          if (encodedValue.length > 0) {
-            encodedValue = '/' + encodedValue;
+      // Only update the browser if this event triggered from within the app, rather
+      // than from the browser back or forward buttons.
+      if (!this._exogenous) {
+        if (!SC.empty(value) || (this._location && this._location !== value)) {
+          encodedValue = encodeURI(value);
+
+          if (this.usesHistory) {
+            if (encodedValue.length > 0) {
+              encodedValue = '/' + encodedValue;
+            }
+            window.history.pushState(null, null, this.get('baseURI') + encodedValue);
+          } else {
+            window.location.hash = encodedValue;
           }
-          window.history.pushState(null, null, this.get('baseURI') + encodedValue);
-        } else {
-          window.location.hash = encodedValue;
         }
       }
 
+      // Cache locally.
       this._location = value;
     }
 
@@ -310,6 +315,10 @@ SC.routes = SC.Object.create(
     if it supports the hashchange event, or by our timer if not.
   */
   hashChange: function(event) {
+    // Mark this location change as coming from the browser, which therefore doesn't
+    // need to be updated.
+    this._exogenous = YES;
+
     var loc = window.location.hash;
 
     // Remove the '#' prefix
@@ -325,10 +334,16 @@ SC.routes = SC.Object.create(
         this.set('location', loc);
       }, this);
     }
-    this._skipRoute = false;
+
+    this._skipRoute = NO;
+    this._exogenous = NO;
   },
 
   popState: function(event) {
+    // Mark this location change as coming from the browser, which therefore doesn't
+    // need to be updated.
+    this._exogenous = YES;
+
     var base = this.get('baseURI'),
         loc = document.location.href;
 
@@ -343,7 +358,9 @@ SC.routes = SC.Object.create(
         }, this);
       }
     }
-    this._skipRoute = false;
+
+    this._skipRoute = NO;
+    this._exogenous = NO;
   },
 
   /**

data/lib/frameworks/sproutcore/frameworks/routing/tests/system/routes.js

@@ -441,3 +441,29 @@ test('deparam outputs object from string', function() {
     { query: 'test', numItems: 5, size: 'small' },
     'deparam works with params only string');
 });
+
+
+// For this module, we're going to replace the route's inner plumbing with a test
+// version. Fragile. Apologies.
+var _extractLocation = SC.routes._extractLocation;
+module("Browser events", {
+  teardown: function() {
+    // Reset the innards.
+    SC.routes._extractLocation = _extractLocation;
+  }
+});
+
+test("Internal flag is properly set for browser events.", function() {
+  var runCount = 0;
+  SC.routes._extractLocation = function() {
+    runCount++;
+    ok(this._exogenous, "Internal flag reflects that location is being updated by the browser.");
+  }
+  
+  SC.routes.hashChange();
+  if (runCount === 0) ok(false, "Internal plumbing method '_extractLocation' failed to fire as expected.");
+  
+  runCount = 0;
+  SC.routes.popState();
+  if (runCount === 0) ok(false, "Internal plumbing method '_extractLocation' failed to fire as expected.");
+});

data/lib/frameworks/sproutcore/frameworks/runtime/core.js

@@ -4,7 +4,7 @@
 //            Portions ©2008-2011 Apple Inc. All rights reserved.
 // License:   Licensed under MIT license (see license.js)
 // ==========================================================================
-/*global jQuery, require, console */
+/*global require, console */
 
 // These commands are used by the build tools to control load order.  On the
 // client side these are a no-op.
@@ -39,7 +39,7 @@ window.SproutCore = window.SproutCore || SC;
 // rest of the methods go into the mixin defined below.
 
 /**
-  @version Edge
+  @version 1.11.0.rc1
   @namespace
 
   All SproutCore methods and functions are defined
@@ -48,18 +48,15 @@ window.SproutCore = window.SproutCore || SC;
 
   You can also use the shorthand "SC" instead of "SproutCore".
 
-  SproutCore-Base is a framework that provides core functions for SproutCore
+  SproutCore-runtime is a framework that provides core functions for SproutCore
   including cross-platform functions, support for property observing and
   objects.  It's focus is on small size and performance.  You can use this
   in place of or along-side other cross-platform libraries such as jQuery or
   Prototype.
-
-  The core Base framework is based on the jQuery API with a number of
-  performance optimizations.
 */
 SC = window.SC; // This is dumb but necessary for jsdoc to get it right
 
-SC.VERSION = '1.10.3';
+SC.VERSION = '1.11.0.rc1';
 
 /**
   @private
@@ -77,10 +74,9 @@ SC.VERSION = '1.10.3';
   @returns {Object} the target object.
   @static
 */
-SC._baseMixin = function (override) {
-  var args = Array.prototype.slice.call(arguments, 1),
-  // copy reference to target object
-      target = args[0] || {},
+SC._baseMixin = function (override, args) {
+  // Copy reference to target object
+  var target = args[0] || {},
       idx = 1,
       length = args.length,
       options, copy, key;
@@ -119,9 +115,12 @@ SC._baseMixin = function (override) {
   @static
 */
 SC.mixin = function () {
-  var args = Array.prototype.slice.call(arguments);
-  args.unshift(true);
-  return SC._baseMixin.apply(this, args);
+  // Accessing `arguments.length` is just a Number and doesn't materialize the `arguments` object, which is costly.
+  // TODO: Add macro to build tools for this.
+  var args = new Array(arguments.length); // Array.prototype.slice.call(arguments)
+  for (var i = 0, len = args.length; i < len; i++) { args[i] = arguments[i]; }
+
+  return SC._baseMixin(true, args);
 };
 
 /**
@@ -137,9 +136,12 @@ SC.mixin = function () {
   @static
 */
 SC.supplement = function () {
-  var args = Array.prototype.slice.call(arguments);
-  args.unshift(false);
-  return SC._baseMixin.apply(this, args);
+  // Accessing `arguments.length` is just a Number and doesn't materialize the `arguments` object which is costly.
+  // TODO: Add macro to build tools for this.
+  var args = new Array(arguments.length); // Array.prototype.slice.call(arguments)
+  for (var i = 0, len = args.length; i < len; i++) { args[i] = arguments[i]; }
+
+  return SC._baseMixin(false, args);
 };
 
 /**
@@ -200,11 +202,9 @@ SC.mixin(/** @scope window.SC.prototype */ {
             SC.T_ERROR: A SproutCore SC.Error object <br>
   */
   typeOf: function (item) {
-    if (item === undefined) return SC.T_UNDEFINED;
-    if (item === null) return SC.T_NULL;
-
-    var nativeType = jQuery.type(item);
+    var nativeType = SC._nativeTypeOf(item);
 
+    // Translate it into an SC type.
     if (nativeType === "function") {
       return item.isClass ? SC.T_CLASS : SC.T_FUNCTION;
     } else if (nativeType === "object") {
@@ -224,6 +224,33 @@ SC.mixin(/** @scope window.SC.prototype */ {
 
     return nativeType;
   },
+  // Inlined from jQuery.type to avoid dependency.
+  _nativeTypeOf: function(item) {
+    if (item === undefined) return SC.T_UNDEFINED;
+    if (item === null) return SC.T_NULL;
+
+    var nativeType = typeof item,
+        toString;
+    if (nativeType === "object" || nativeType === "function") {
+      toString = SC._nativeToString.call(item);
+      return SC._nativeTypeHash[toString] || "object";
+    } else {
+      return nativeType;
+    }
+  } ,
+  // Inlined from jQuery's class2type to avoid dependency.
+  _nativeTypeHash: {
+    "[object Boolean]": "boolean",
+    "[object Number]": "number",
+    "[object String]": "string",
+    "[object Function]": "function",
+    "[object Array]": "array",
+    "[object Date]": "date",
+    "[object RegExp]": "regexp",
+    "[object Object]": "object"
+  },
+  // Inlined from jQuery to avoid dependency.
+  _nativeToString: Object.prototype.toString,
 
   /**
     Returns YES if the passed value is null or undefined.  This avoids errors
@@ -268,7 +295,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
     if (!obj || obj.setInterval) { return false; }
     if (Array.isArray && Array.isArray(obj)) { return true; }
     if (obj.objectAt) { return true; }
-    if (obj.length !== undefined && jQuery.type(obj) === "object") { return true; }
+    if (obj.length !== undefined && SC._nativeTypeOf(obj) === "object") { return true; }
 
     return false;
   },
@@ -329,6 +356,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
   _numberGuids: [],
   _stringGuids: {},
   _keyCache: {},
+  _uuid: 0,
 
   /**"
     Returns a unique GUID for the object.  If the object does not yet have
@@ -353,7 +381,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
       cache = this._guidCaches[type];
       ret   = cache[obj];
       if (!ret) {
-        ret        = "st" + (jQuery.uuid++);
+        ret        = "st" + (SC._uuid++);
         cache[obj] = ret;
       }
       return ret;
@@ -399,7 +427,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
     @returns {String} the guid
   */
   generateGuid: function (obj, prefix) {
-    var ret = (prefix + (jQuery.uuid++));
+    var ret = (prefix + (SC._uuid++));
     if (obj) obj[this.guidKey] = ret;
     return ret;
   },
@@ -621,7 +649,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
       if (object.clone)      return object.clone();
     }
 
-    switch (jQuery.type(object)) {
+    switch (SC._nativeTypeOf(object)) {
     case "array":
       ret = object.slice();
 
@@ -696,6 +724,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
     @returns {Array} array with [object, property] if found or null
   */
   tupleForPropertyPath: function (path, root) {
+    /* jshint eqnull:true */
     // if passed nothing, return nothing.
     if (path == null) return null;
 

data/lib/frameworks/sproutcore/frameworks/runtime/ext/array.js

@@ -31,13 +31,7 @@ SC.mixin(Array.prototype,
       this.splice.apply(this, args);
     }
 
-    // Both arrayContentDidChange and enumerableContentDidChange will invoke
-    // "this.notifyPropertyChange('[]')". To prevent multiple notifications
-    // these calls are made as grouped property changes.
-    this.beginPropertyChanges();
     this.arrayContentDidChange(idx, amt, len);
-    this.enumerableContentDidChange(idx, amt, len - amt);
-    this.endPropertyChanges();
 
     return this;
   },

data/lib/frameworks/sproutcore/frameworks/runtime/ext/number.js

@@ -0,0 +1,36 @@
+// ==========================================================================
+// Project:   SproutCore - JavaScript Application Framework
+// Copyright: ©2006-2011 Strobe Inc. and contributors.
+//            Portions ©2008-2011 Apple Inc. All rights reserved.
+// License:   Licensed under MIT license (see license.js)
+// ==========================================================================
+
+SC.supplement(Number.prototype, {
+
+  /**
+   * Returns the ordinal associated for the current number:
+   *
+   * eg: 1 => 'st', 2 => 'nd'
+   *
+   *
+   * If the current Locale exists (which it almost always does except for in
+   * testing) we try and delegate to it. Otherwise we use this inner anonymous
+   * function (to prevent further mucking with the prototype)
+   *
+   */
+  ordinal: function () {
+    // FAST PATH: If we have a localization, use its ordinals.
+    if (SC.Locale) {
+      return SC.Locale.currentLocale.ordinalForNumber(this);
+    }
+
+    // Otherwise, fall back on a basic (en) implementation (e.g. in testing, or as
+    // the datetime framework only requires the runtime framework).
+    var d = this % 10;
+    return (~~(this % 100 / 10) === 1) ? 'th' :
+      (d === 1) ? 'st' :
+        (d === 2) ? 'nd' :
+          (d === 3) ? 'rd' : 'th';
+  }
+
+});

data/lib/frameworks/sproutcore/frameworks/runtime/ext/window.js

@@ -0,0 +1,25 @@
+/**
+  Polyfills!
+*/
+
+// window.performance
+(function() {
+  // TODO: Include polyfill for node.js
+  if (window && typeof window.performance === 'undefined') {
+    window.performance = {};
+  }
+
+  if (window && !window.performance.now) {
+    var initTimestamp;
+    if (window.performance.timing && window.performance.timing.navigationStart) {
+      initTimestamp = window.performance.timing.navigationStart;
+    } else {
+      window.performance.timing = {};
+      initTimestamp = window.performance.timing.navigationStart = Date.now ? Date.now() : (new Date()).getTime();
+    }
+    window.performance.now = function() {
+      var now = Date.now ? Date.now() : (new Date()).getTime();
+      return now - initTimestamp;
+    };
+  }
+})();

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/array.js

@@ -37,7 +37,7 @@ SC.CoreArray = /** @lends SC.Array.prototype */ {
 
     Before mutating the underlying data structure, you must call
     this.arrayContentWillChange(). After the mutation is complete, you must
-    call arrayContentDidChange() and enumerableContentDidChange().
+    call arrayContentDidChange().
 
     NOTE: JavaScript arrays already implement SC.Array and automatically call
     the correct callbacks.
@@ -193,7 +193,7 @@ SC.CoreArray = /** @lends SC.Array.prototype */ {
     var loc = this.get('length') || 0;
     while (--loc >= 0) {
       var curObject = this.objectAt(loc);
-      if (curObject == obj) this.removeAt(loc);
+      if (curObject === obj) this.removeAt(loc);
     }
     return this;
   },
@@ -604,7 +604,7 @@ SC.CoreArray = /** @lends SC.Array.prototype */ {
       }
     }
 
-    this.notifyPropertyChange('[]');
+    this.enumerableContentDidChange(start, addedCount, addedCount - removedCount);
     this.endPropertyChanges();
 
     return this;

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/enumerable.js

@@ -557,7 +557,7 @@ SC.Enumerable = /** @scope SC.Enumerable.prototype */{
 
     @param {Function} callback the callback to execute
     @param {Object} target the target object to use
-    @returns {Array} A filtered array.
+    @returns {Boolean} YES
   */
   some: function (callback, target) {
     if (typeof callback !== "function") throw new TypeError();

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/observable.js

@@ -9,13 +9,16 @@ sc_require('ext/function');
 sc_require('private/observer_set');
 sc_require('private/chain_observer');
 
+//@if(debug)
 /**
-  Set to YES to have all observing activity logged to the SC.Logger.  This
-  should be used for debugging only.
+  Set to YES to have all observing activity logged to the console.
+
+  This is only available in debug mode.
 
   @type Boolean
 */
-SC.LOG_OBSERVERS = NO;
+SC.LOG_OBSERVERS = false;
+//@endif
 
 SC.OBSERVES_HANDLER_ADD = 0;
 SC.OBSERVES_HANDLER_REMOVE = 1;
@@ -136,7 +139,67 @@ SC.OBSERVES_HANDLER_REMOVE = 1;
 
   @since SproutCore 1.0
 */
-SC.Observable = /** @scope SC.Observable.prototype */{
+SC.Observable = /** @scope SC.Observable.prototype */ {
+
+  //@if(debug)
+  /* BEGIN DEBUG ONLY PROPERTIES AND METHODS */
+
+  /**
+    Allows you to inspect a property for changes. Whenever the named property
+    changes, a log will be printed to the console. This (along with removeProbe)
+    are convenience methods meant for debugging purposes.
+
+    @param {String} key The name of the property you want probed for changes
+  */
+  addProbe: function (key) { this.addObserver(key, SC.logChange); },
+
+  /**
+    Stops a running probe from observing changes to the observer.
+
+    @param {String} key The name of the property you want probed for changes
+  */
+  removeProbe: function (key) { this.removeObserver(key, SC.logChange); },
+
+  /**
+    Logs the named properties to the console.
+
+    @param {String...} propertyNames one or more property names
+  */
+  logProperty: function () {
+    var props = SC.$A(arguments),
+        prop, propsLen, idx;
+    for (idx = 0, propsLen = props.length; idx < propsLen; idx++) {
+      prop = props[idx];
+      console.log('%@:%@: '.fmt(SC.guidFor(this), prop), this.get(prop));
+    }
+  },
+
+  /* END DEBUG ONLY PROPERTIES AND METHODS */
+  //@endif
+
+  /** @private Property cache. */
+  _kvo_cache: null,
+
+  /** @private Whether properties of the object will be cacheable. Becomes true if any one computed property is .cacheable() */
+  _kvo_cacheable: false,
+
+  /** @private Cache of dependepents for a property. */
+  _kvo_cachedep: null,
+
+  /** @private */
+  _kvo_changeLevel: 0,
+
+  /** @private */
+  _kvo_changes: null,
+
+  /** @private */
+  _kvo_cloned: null,
+
+  /** @private */
+  _kvo_revision: 0,
+
+  /** @private */
+  _observableInited: false,
 
   /**
     Walk like that ol' duck
@@ -363,7 +426,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     @returns {SC.Observable}
   */
   beginPropertyChanges: function () {
-    this._kvo_changeLevel = (this._kvo_changeLevel || 0) + 1;
+    this._kvo_changeLevel = this._kvo_changeLevel + 1;
     return this;
   },
 
@@ -427,10 +490,13 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     @returns {SC.Observable}
   */
   propertyDidChange: function (key, value, _keepCache) {
-    this._kvo_revision = (this._kvo_revision || 0) + 1;
-    var level = this._kvo_changeLevel || 0,
-        cachedep, idx, dfunc, func,
-        log = SC.LOG_OBSERVERS && (this.LOG_OBSERVING !== NO);
+    this._kvo_revision = this._kvo_revision + 1;
+    var level = this._kvo_changeLevel,
+        cachedep, idx, dfunc, func;
+
+    //@if(debug)
+    var log = SC.LOG_OBSERVERS && (this.LOG_OBSERVING !== NO);
+    //@endif
 
     // If any dependent keys contain this property in their path,
     // invalidate the cache of the computed property and re-setup chain with
@@ -487,7 +553,9 @@ SC.Observable = /** @scope SC.Observable.prototype */{
       changes.add(key);
 
       if (suspended) {
-        if (log) SC.Logger.log("%@%@: will not notify observers because observing is suspended".fmt(SC.KVO_SPACES, this));
+        //@if(debug)
+        if (log) console.log("%@%@: will not notify observers because observing is suspended".fmt(SC.KVO_SPACES, this));
+        //@endif
         SC.Observers.objectHasPendingChanges(this);
       }
 
@@ -829,6 +897,8 @@ SC.Observable = /** @scope SC.Observable.prototype */{
         // if observers have not been cloned yet, do so now
         observers = this._kvo_for(kvoKey);
         observers.remove(target, method);
+
+        // Remove the key when no members remain.
         if (observers.getMembers().length === 0) {
           this._kvo_for('_kvo_observed_keys', SC.CoreSet).remove(key);
         }
@@ -1098,21 +1168,23 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
     SC.Observers.flush(this); // hookup as many observers as possible.
 
-    var log = SC.LOG_OBSERVERS && this.LOG_OBSERVING !== NO,
-        observers, changes, dependents, starObservers, idx, keys, rev,
+    var observers, changes, dependents, starObservers, idx, keys, rev,
         members, membersLength, member, memberLoc, target, method, loc, func,
         context, spaces, cache;
 
+    //@if(debug)
+    var log = SC.LOG_OBSERVERS && this.LOG_OBSERVING !== NO;
     if (log) {
       spaces = SC.KVO_SPACES = (SC.KVO_SPACES || '') + '  ';
-      SC.Logger.log('%@%@: notifying observers after change to key "%@"'.fmt(spaces, this, key));
+      console.log('%@%@: notifying observers after change to key "%@"'.fmt(spaces, this, key));
     }
+    //@endif
 
     // Get any starObservers -- they will be notified of all changes.
     starObservers =  this['_kvo_observers_*'];
 
     // prevent notifications from being sent until complete
-    this._kvo_changeLevel = (this._kvo_changeLevel || 0) + 1;
+    this._kvo_changeLevel = this._kvo_changeLevel + 1;
 
     // keep sending notifications as long as there are changes
     while (((changes = this._kvo_changes) && (changes.length > 0)) || key) {
@@ -1146,9 +1218,11 @@ SC.Observable = /** @scope SC.Observable.prototype */{
           // for each dependent key, add to set of changes.  Also, if key
           // value is a cacheable property, clear the cached value...
           if (keys && (loc = keys.length)) {
+            //@if(debug)
             if (log) {
-              SC.Logger.log("%@...including dependent keys for %@: %@".fmt(spaces, key, keys));
+              console.log("%@...including dependent keys for %@: %@".fmt(spaces, key, keys));
             }
+            //@endif
             cache = this._kvo_cache;
             if (!cache) cache = this._kvo_cache = {};
             while (--loc >= 0) {
@@ -1186,14 +1260,16 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
             if (member[3] === rev) continue; // skip notified items.
 
-            if (!member[1]) SC.Logger.log(member);
+            if (!member[1]) console.log(member);
 
             target = member[0] || this;
             method = member[1];
             context = member[2];
             member[3] = rev;
 
-            if (log) SC.Logger.log('%@...firing observer on %@ for key "%@"'.fmt(spaces, target, key));
+            //@if(debug)
+            if (log) console.log('%@...firing observer on %@ for key "%@"'.fmt(spaces, target, key));
+            //@endif
             if (context !== undefined) {
               method.call(target, this, key, null, context, rev);
             } else {
@@ -1214,7 +1290,9 @@ SC.Observable = /** @scope SC.Observable.prototype */{
             member = members[memberLoc];
             method = this[member]; // try to find observer function
             if (method) {
-              if (log) SC.Logger.log('%@...firing local observer %@.%@ for key "%@"'.fmt(spaces, this, member, key));
+              //@if(debug)
+              if (log) console.log('%@...firing local observer %@.%@ for key "%@"'.fmt(spaces, this, member, key));
+              //@endif
               method.call(this, this, key, null, rev);
             }
           }
@@ -1232,7 +1310,9 @@ SC.Observable = /** @scope SC.Observable.prototype */{
             method = member[1];
             context = member[2];
 
-            if (log) SC.Logger.log('%@...firing * observer on %@ for key "%@"'.fmt(spaces, target, key));
+            //@if(debug)
+            if (log) console.log('%@...firing * observer on %@ for key "%@"'.fmt(spaces, target, key));
+            //@endif
             if (context !== undefined) {
               method.call(target, this, key, null, context, rev);
             } else {
@@ -1243,7 +1323,9 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
         // if there is a default property observer, call that also
         if (this.propertyObserver) {
-          if (log) SC.Logger.log('%@...firing %@.propertyObserver for key "%@"'.fmt(spaces, this, key));
+          //@if(debug)
+          if (log) console.log('%@...firing %@.propertyObserver for key "%@"'.fmt(spaces, this, key));
+          //@endif
           this.propertyObserver(this, key, null, rev);
         }
       } // while(changes.length>0)
@@ -1259,7 +1341,9 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     // done with loop, reduce change level so that future sets can resume
     this._kvo_changeLevel = (this._kvo_changeLevel || 1) - 1;
 
+    //@if(debug)
     if (log) SC.KVO_SPACES = spaces.slice(0, -2);
+    //@endif
 
     return YES; // finished successfully
   },
@@ -1312,21 +1396,53 @@ SC.Observable = /** @scope SC.Observable.prototype */{
   },
 
   /**
-    didChangeFor allows you to determine if a property has changed since the
-    last time the method was called. You must pass a unique context as the
-    first parameter (so didChangeFor can identify which method is calling it),
-    followed by a list of keys that should be checked for changes.
-
-    For example, in your render method you might pass the following context:
-    if (this.didChangeFor('render','height','width')) {
-       // Only render if changed
-    }
+    didChangeFor is a very important method which allows you to tell whether
+    a property or properties have changed.
 
-    In your view's update method, you might instead pass 'update':
+    The key to using didChangeFor is to pass a unique string as the first argument,
+    which signals, "Has anything changed since the last time this was called with
+    this unique key?" The string can be anything you want, as long as it's unique
+    and stays the same from call to call.
 
-    if (this.didChangeFor('update', 'height', 'width')) {
-      // Only update height and width properties
-    }
+    After the key argument, you can pass as many property arguments as you like;
+    didChangeFor will only return `true` if any of those properties have changed
+    since the last call.
+
+    For example, in your view's update method, you might want to gate DOM changes
+    (generally a slow operation) on whether the root values have changed. You might
+    ask the following:
+
+        if (this.didChangeFor('updateOnDisplayValue', 'displayValue')) {
+          // Update the DOM.
+        }
+
+    In another method on the same view, you might send an event if that same value
+    has changed:
+
+        if (this.didChangeFor('otherMethodDisplayValue', 'displayValue')) {
+          // Send a statechart action.
+        }
+
+    Each call will correctly return whether the property has changed since the last
+    time displayDidChange was called *with that key*. The following sequence of calls
+    will return the following values:
+
+      - this.set('displayValue', 'value1');
+      - this.didChangeFor('updateOnDisplayValue', 'displayValue');
+      > true;
+      - this.didChangeFor('updateOnDisplayValue', 'displayValue');
+      > false;
+      - this.didChangeFor('otherMethodDisplayValue', 'displayValue');
+      > true;
+      - this.set('displayValue', 'value2');
+      - this.didChangeFor('updateOnDisplayValue', 'displayValue');
+      > true;
+      - this.didChangeFor('updateOnDisplayValue', 'displayValue');
+      > false;
+      - this.didChangeFor('updateOnDisplayValue', 'displayValue');
+      > false;
+      - this.didChangeFor('otherMethodDisplayValue', 'displayValue');
+      > false;
 
     This method works by comparing property revision counts. Every time a
     property changes, an internal counter is incremented. When didChangeFor is
@@ -1353,7 +1469,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
     // prepare too loop!
     ret = false;
-    currentRevision = this._kvo_revision || 0;
+    currentRevision = this._kvo_revision;
     idx = arguments.length;
     while (--idx >= 1) {  // NB: loop only to 1 to ignore context arg.
       key = arguments[idx];
@@ -1548,44 +1664,16 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     return this;
   },
 
-  /**
-    Allows you to inspect a property for changes. Whenever the named property
-    changes, a log will be printed to the console. This (along with removeProbe)
-    are convenience methods meant for debugging purposes.
-
-    @param {String} key The name of the property you want probed for changes
-  */
-  addProbe: function (key) { this.addObserver(key, SC.logChange); },
-
-  /**
-    Stops a running probe from observing changes to the observer.
-
-    @param {String} key The name of the property you want probed for changes
-  */
-  removeProbe: function (key) { this.removeObserver(key, SC.logChange); },
-
-  /**
-    Logs the named properties to the SC.Logger.
-
-    @param {String...} propertyNames one or more property names
-  */
-  logProperty: function () {
-    var props = SC.$A(arguments),
-        prop, propsLen, idx;
-    for (idx = 0, propsLen = props.length; idx < propsLen; idx++) {
-      prop = props[idx];
-      SC.Logger.log('%@:%@: '.fmt(SC.guidFor(this), prop), this.get(prop));
-    }
-  },
-
   propertyRevision: 1
 
 };
 
-/** @private used by addProbe/removeProbe */
+//@if(debug)
+/** @private used by addProbe/removeProbe. Debug mode only. */
 SC.logChange = function logChange(target, key, value) {
-  SC.Logger.log("CHANGE: %@[%@] => %@".fmt(target, key, target.get(key)));
+  console.log("CHANGE: %@[%@] => %@".fmt(target, key, target.get(key)));
 };
+//@endif
 
 /**
   Retrieves a property from an object, using get() if the
@@ -1595,6 +1683,7 @@ SC.logChange = function logChange(target, key, value) {
   @param  {String}  key the property to retrieve
 */
 SC.mixin(SC, {
+
   get: function (object, key) {
     if (!object) return undefined;
     if (key === undefined) return this[object];
@@ -1616,6 +1705,7 @@ SC.mixin(SC, {
     }
     return SC.objectForPropertyPath(path, object);
   }
+
 });
 
 // Make all Array's observable