sproutcore 1.10.3.1 → 1.11.0.rc1

data/lib/frameworks/sproutcore/frameworks/desktop/tests/views/link_view_test.js

@@ -0,0 +1,136 @@
+// ==========================================================================
+// Project:   SproutCore
+// Copyright: ©2014 7x7 Software, Inc.
+// License:   Licensed under MIT license
+// ==========================================================================
+/*global module, test, equals, ok, start, stop */
+
+var linkView,
+  pane;
+
+
+module("SC.LinkView", {
+
+  setup: function () {
+    linkView = SC.LinkView.create();
+    pane = SC.Pane.create({
+      childViews: [linkView],
+      layout: { width: 400, height: 400 }
+    });
+  },
+
+  teardown: function () {
+    pane.destroy();
+    linkView = pane = null;
+  }
+
+});
+
+test("The view renders as expected: Default values", function () {
+  pane.append();
+
+  var layer = linkView.get('layer');
+
+  // body: ""
+  // fileName: null
+  // escapeHTML: true
+  // href: '#'
+  // language: null
+  // ping: null
+  // rel: null
+  // target: '_blank'
+  // type: null
+  equals(layer.innerText, "", "The innerText of the layer is");
+  if (SC.platform.a.download) { equals(layer.download, "", "The download attribute of the layer is"); }
+  equals(layer.href, document.URL + "#", "The href attribute of the layer is");
+  equals(layer.hreflang, SC.Locale.currentLocale.language, "The hreflang attribute of the layer is");
+  equals(layer.ping, "", "The ping attribute of the layer is");
+  equals(layer.rel, "", "The rel attribute of the layer is");
+  equals(layer.target, "_blank", "The target attribute of the layer is");
+  equals(layer.type, "", "The type attribute of the layer is");
+});
+
+test("The view renders as expected: Custom values", function () {
+  // Customize the link view.
+  linkView.set('body', '<div>ABC</div>');
+  linkView.set('fileName', 'ABC.txt');
+  linkView.set('href', 'http://bogus-site.com/files/abc.txt');
+  linkView.set('language', 'fr');
+  linkView.set('ping', ['http://logback.com/?clicked=file']);
+  linkView.set('rel', ['author']);
+  linkView.set('target', '_self');
+  linkView.set('type', 'text/plain');
+
+  pane.append();
+
+  var layer = linkView.get('layer');
+
+  equals(layer.innerText, "<div>ABC</div>", "The innerText of the layer is");
+  if (SC.platform.a.download) { equals(layer.download, "ABC.txt", "The download attribute of the layer is"); }
+  equals(layer.href, "http://bogus-site.com/files/abc.txt", "The href attribute of the layer is");
+  equals(layer.hreflang, 'fr', "The hreflang attribute of the layer is");
+  if (SC.platform.a.ping) { equals(layer.ping, "http://logback.com/?clicked=file", "The ping attribute of the layer is"); }
+  equals(layer.rel, "author", "The rel attribute of the layer is");
+  equals(layer.target, "_self", "The target attribute of the layer is");
+  equals(layer.type, "text/plain", "The type attribute of the layer is");
+});
+
+test("The view renders as expected: Unescaped body", function () {
+  // Customize the link view.
+  linkView.set('escapeHTML', false);
+  linkView.set('body', '<div>ABC</div>');
+
+  pane.append();
+
+  var layer = linkView.get('layer');
+
+  equals(layer.innerHTML, "<div>ABC</div>", "The innerHTML of the layer is");
+  equals(layer.innerText.trimRight(), "ABC", "The innerText of the layer is");
+});
+
+test("The view updates as expected: Custom values", function () {
+  // Customize the link view.
+  linkView.set('body', '<div>ABC</div>');
+  linkView.set('fileName', 'ABC.txt');
+  linkView.set('href', 'http://bogus-site.com/files/abc.txt');
+  linkView.set('language', 'fr');
+  linkView.set('ping', ['http://logback.com/?clicked=file']);
+  linkView.set('rel', ['author']);
+  linkView.set('target', '_self');
+  linkView.set('type', 'text/plain');
+
+  pane.append();
+
+  var layer = linkView.get('layer');
+
+  equals(layer.innerText, "<div>ABC</div>", "The innerText of the layer is");
+  if (SC.platform.a.download) { equals(layer.download, "ABC.txt", "The download attribute of the layer is"); }
+  equals(layer.href, "http://bogus-site.com/files/abc.txt", "The href attribute of the layer is");
+  equals(layer.hreflang, 'fr', "The hreflang attribute of the layer is");
+  if (SC.platform.a.ping) { equals(layer.ping, "http://logback.com/?clicked=file", "The ping attribute of the layer is"); }
+  equals(layer.rel, "author", "The rel attribute of the layer is");
+  equals(layer.target, "_self", "The target attribute of the layer is");
+  equals(layer.type, "text/plain", "The type attribute of the layer is");
+
+  SC.run(function () {
+    linkView.set('body', '<div>DEF</div>');
+    linkView.set('fileName', 'DEF.js');
+    linkView.set('href', 'http://bogus-site.com/files/def.js');
+    linkView.set('language', 'es');
+    linkView.set('ping', ['https://logback.com/?clicked=file']);
+    linkView.set('rel', ['sidebar']);
+    linkView.set('target', '_blank');
+    linkView.set('type', 'text/javascript');
+  });
+
+  equals(layer.innerText, "<div>DEF</div>", "The innerText of the layer is now");
+  if (SC.platform.a.download) { equals(layer.download, "DEF.js", "The download attribute of the layer is now"); }
+  equals(layer.href, "http://bogus-site.com/files/def.js", "The href attribute of the layer is now");
+  equals(layer.hreflang, 'es', "The hreflang attribute of the layer is now");
+
+  // Some properties don't result in re-rendering and aren't updated for performance reasons.
+  if (SC.platform.a.ping) { equals(layer.ping, "http://logback.com/?clicked=file", "The ping attribute of the layer is still"); }
+  equals(layer.rel, "author", "The rel attribute of the layer is still");
+  equals(layer.target, "_self", "The target attribute of the layer is still");
+  equals(layer.type, "text/plain", "The type attribute of the layer is still");
+});

data/lib/frameworks/sproutcore/frameworks/desktop/tests/views/list/contentIndexesInRect.js

@@ -0,0 +1,77 @@
+// ==========================================================================
+// Project:   SproutCore
+// Copyright: ©2014 7x7 Software, Inc.
+// License:   Licensed under MIT license (see license.js)
+// ==========================================================================
+/*global module, test, same, ok, equals*/
+
+
+var content, view;
+
+module("SC.ListView.contentIndexesInRect", {
+  setup: function () {
+    content = "1 2 3 4 5 6 7 8 9 0".w().map(function (x) {
+      return SC.Object.create({ value: x });
+    }, this);
+
+    SC.run(function() {
+      view = SC.ListView.create({
+        content: content,
+        rowSize: 50
+      });
+    });
+  },
+
+  teardown: function () {
+    view.destroy();
+    content = view = null;
+  }
+});
+
+test("contentIndexesInRect: rowSize of 50; no custom row sizes; no rowSpacing", function () {
+
+  var rect = { x: 0, y: 0, height: 60, width: 100 },
+      indexes = view.contentIndexesInRect(rect),
+      expectedIndexes = SC.IndexSet.create(0, 2);
+
+  ok(indexes.isEqual(expectedIndexes), "Content indexes [0, 1] are within { y: 0, height: 60 }.");
+
+  rect = { x: 0, y: 0, height: 110, width: 100 };
+  indexes = view.contentIndexesInRect(rect);
+  expectedIndexes = SC.IndexSet.create(0, 3);
+
+  ok(indexes.isEqual(expectedIndexes), "Content indexes [0, 1, 2] are within { y: 0, height: 110 }.");
+
+  rect = { x: 0, y: 60, height: 60, width: 100 };
+  indexes = view.contentIndexesInRect(rect);
+  expectedIndexes = SC.IndexSet.create(1, 2);
+
+  ok(indexes.isEqual(expectedIndexes), "Content indexes [1, 2] are within { y: 60, height: 60 }.");
+
+});
+
+test("contentIndexesInRect: rowSize of 50; no custom row sizes; rowSpacing: 50", function () {
+
+  view.set('rowSpacing', 50);
+
+  var rect = { x: 0, y: 0, height: 60, width: 100 },
+      indexes = view.contentIndexesInRect(rect),
+      expectedIndexes = SC.IndexSet.create(0, 1);
+
+  ok(indexes.isEqual(expectedIndexes), "Content indexes [0] is within { y: 0, height: 60 }.");
+
+  rect = { x: 0, y: 0, height: 110, width: 100 };
+  indexes = view.contentIndexesInRect(rect);
+  expectedIndexes = SC.IndexSet.create(0, 2);
+
+  ok(indexes.isEqual(expectedIndexes), "Content indexes [0, 1] are within { y: 0, height: 110 }.");
+
+  rect = { x: 0, y: 60, height: 60, width: 100 };
+  indexes = view.contentIndexesInRect(rect);
+  expectedIndexes = SC.IndexSet.create(1, 1);
+
+  ok(indexes.isEqual(expectedIndexes), "Content indexes [1] is within { y: 60, height: 60 }.");
+
+});
+
+test("TODO contentIndexesInRect: custom row sizes");

data/lib/frameworks/sproutcore/frameworks/desktop/tests/views/list/drag_and_drop.js

@@ -51,6 +51,22 @@ var pane = SC.ControlTestPane.design()
         this._didCallDragEnded = true;
       }
     })
+  }))
+  .add("empty", SC.ScrollView.design({
+    borderStyle: SC.BORDER_NONE,
+    layout: { left: 0, right: 0, top: 0, height: 300 },
+    hasHorizontalScroller: NO,
+    contentView: SC.ListView.design({
+      contentValueKey: "title",
+      contentCheckboxKey: "isDone",
+      contentUnreadCountKey: "unread",
+      rowHeight: 20,
+      _didCallDragEnded: false,
+      dragEnded: function() {
+        sc_super();
+        this._didCallDragEnded = true;
+      }
+    })
   }));
 
 
@@ -59,21 +75,23 @@ module("SC.ListView - drag and drop", pane.standardSetup());
 test("drag on default list view", function() {
   var ev,
     itemView,
+    frame,
     layer,
     listView = pane.view("basic").get('contentView');
 
   itemView = listView.itemViewForContentIndex(0);
+  frame = itemView.get('frame');
   layer = itemView.get('layer');
-  ev = SC.Event.simulateEvent(layer, 'mousedown');
+  ev = SC.Event.simulateEvent(layer, 'mousedown', { pageX: frame.x, pageY: frame.y });
   SC.Event.trigger(layer, 'mousedown', [ev]);
 
-  ev = SC.Event.simulateEvent(layer, 'mousemove');
+  ev = SC.Event.simulateEvent(layer, 'mousemove', { pageX: frame.x, pageY: frame.y });
   SC.Event.trigger(layer, 'mousemove', [ev]);
 
   equals(listView.get('dragContent'), null, 'dragContent should not be set, because the default implementation should prevent dragging');
 
   // Clean up
-  ev = SC.Event.simulateEvent(layer, 'mouseup');
+  ev = SC.Event.simulateEvent(layer, 'mouseup', { pageX: frame.x, pageY: frame.y });
   SC.Event.trigger(layer, 'mouseup', [ev]);
 });
 
@@ -81,6 +99,7 @@ test("drag on default list view", function() {
 test("drag on list view with SC.DROP_ON support", function() {
   var ev,
     itemView,
+    frame,
     layer,
     listView = pane.view("basic").get('contentView');
 
@@ -95,7 +114,8 @@ test("drag on list view with SC.DROP_ON support", function() {
 
   itemView = listView.itemViewForContentIndex(0);
   layer = itemView.get('layer');
-  ev = SC.Event.simulateEvent(layer, 'mousedown');
+  frame = itemView.get('frame');
+  ev = SC.Event.simulateEvent(layer, 'mousedown', { pageX: frame.x, pageY: frame.y });
   SC.Event.trigger(layer, 'mousedown', [ev]);
 
   var f = function() {
@@ -103,7 +123,7 @@ test("drag on list view with SC.DROP_ON support", function() {
       point;
 
     SC.RunLoop.begin();
-    ev = SC.Event.simulateEvent(layer, 'mousemove');
+    ev = SC.Event.simulateEvent(layer, 'mousemove', { pageX: frame.x, pageY: frame.y });
     SC.Event.trigger(layer, 'mousemove', [ev]);
 
     equals(listView.get('dragContent').content, listView.get('content'), "dragContent.content should be equal to the ListView's content");
@@ -140,7 +160,7 @@ test("drag on list view with SC.DROP_ON support", function() {
     ok(!itemView2.$().hasClass('drop-target'), "second list item should not add drop-target class");
 
     // Clean up
-    ev = SC.Event.simulateEvent(layer, 'mouseup');
+    ev = SC.Event.simulateEvent(layer, 'mouseup', { pageX: point.x + 1, pageY: point.y + 1 });
     SC.Event.trigger(layer, 'mouseup', [ev]);
 
     window.start();
@@ -154,13 +174,15 @@ test("insertion point when drag on list view", function() {
   var ev,
     itemView,
     layer,
+    frame,
     listView = pane.view("basic").get('contentView');
 
   listView.set('canReorderContent', YES);
 
   itemView = listView.itemViewForContentIndex(0);
+  frame = itemView.get('frame');
   layer = itemView.get('layer');
-  ev = SC.Event.simulateEvent(layer, 'mousedown');
+  ev = SC.Event.simulateEvent(layer, 'mousedown', { pageX: frame.x, pageY: frame.y });
   SC.Event.trigger(layer, 'mousedown', [ev]);
 
   var f = function() {
@@ -168,7 +190,7 @@ test("insertion point when drag on list view", function() {
       point;
 
     SC.RunLoop.begin();
-    ev = SC.Event.simulateEvent(layer, 'mousemove');
+    ev = SC.Event.simulateEvent(layer, 'mousemove', { pageX: frame.x, pageY: frame.y });
     SC.Event.trigger(layer, 'mousemove', [ev]);
 
     // Drag over 2nd item
@@ -179,13 +201,15 @@ test("insertion point when drag on list view", function() {
     ev = SC.Event.simulateEvent(layer, 'mousemove', { pageX: point.x + 1, pageY: point.y + 1 });
     SC.Event.trigger(layer, 'mousemove', [ev]);
 
-    ok(listView._insertionPointView, "An insertion point should have been added");
+    ok(listView._sc_insertionPointView, "An insertion point should have been added");
+
+    equals(listView._sc_insertionPointView.get('layout').top, 20, "The drag having been over item 2, the insertion point should be located at the top of item 2");
 
     // Clean up
-    ev = SC.Event.simulateEvent(layer, 'mouseup');
+    ev = SC.Event.simulateEvent(layer, 'mouseup', { pageX: point.x + 1, pageY: point.y + 1 });
     SC.Event.trigger(layer, 'mouseup', [ev]);
 
-    equals(listView._insertionPointView, null, "The insertion point should have been destroyed");
+    equals(listView._sc_insertionPointView, null, "The insertion point should have been destroyed");
 
     window.start();
   };
@@ -197,14 +221,16 @@ test("insertion point when drag on list view", function() {
 test("insertion point when cancel drag on list view", function() {
   var ev,
     itemView,
+    frame,
     layer,
     listView = pane.view("basic").get('contentView');
 
   listView.set('canReorderContent', YES);
 
   itemView = listView.itemViewForContentIndex(0);
+  frame = itemView.get('frame');
   layer = itemView.get('layer');
-  ev = SC.Event.simulateEvent(layer, 'mousedown');
+  ev = SC.Event.simulateEvent(layer, 'mousedown', { pageX: frame.x, pageY: frame.y });
   SC.Event.trigger(layer, 'mousedown', [ev]);
 
   var f = function() {
@@ -212,7 +238,7 @@ test("insertion point when cancel drag on list view", function() {
       point;
 
     SC.RunLoop.begin();
-    ev = SC.Event.simulateEvent(layer, 'mousemove');
+    ev = SC.Event.simulateEvent(layer, 'mousemove', { pageX: frame.x, pageY: frame.y });
     SC.Event.trigger(layer, 'mousemove', [ev]);
 
     // Drag over 2nd item
@@ -223,13 +249,13 @@ test("insertion point when cancel drag on list view", function() {
     ev = SC.Event.simulateEvent(layer, 'mousemove', { pageX: point.x + 1, pageY: point.y + 1 });
     SC.Event.trigger(layer, 'mousemove', [ev]);
 
-    ok(listView._insertionPointView, "An insertion point should have been added");
+    ok(listView._sc_insertionPointView, "An insertion point should have been added");
 
     // cancel drag
     ev = SC.Event.simulateEvent(layer, 'keydown', { keyCode: 27 });
     SC.Event.trigger(layer, 'keydown', [ev]);
 
-    equals(listView._insertionPointView, null, "The insertion point should have been destroyed");
+    equals(listView._sc_insertionPointView, null, "The insertion point should have been destroyed");
     equals(listView._didCallDragEnded, true, "dragEnded should have been call");
 
     window.start();
@@ -239,6 +265,17 @@ test("insertion point when cancel drag on list view", function() {
   setTimeout(f, 200);
 });
 
+test("insertion point on empty list", function() {
+  var listView = pane.view('empty').get('contentView'),
+      didError = NO;
 
+  try {
+    SC.run(function() {
+      listView.showInsertionPoint(null, SC.DRAG_MOVE);
+    });
+  } catch (e) {
+    didError = YES;
+  }
 
-
+  ok(!didError, "An insertion point was added onto no item view without incident.");
+});

data/lib/frameworks/sproutcore/frameworks/desktop/tests/views/list/layoutForContentIndex.js

@@ -0,0 +1,41 @@
+// ==========================================================================
+// Project:   SproutCore
+// Copyright: ©2014 7x7 Software, Inc.
+// License:   Licensed under MIT license (see license.js)
+// ==========================================================================
+/*global module, test, same, ok, equals*/
+
+
+var content, view;
+
+module("SC.ListView.layoutForContentIndex", {
+  setup: function () {
+    content = "1 2 3 4 5 6 7 8 9 0".w().map(function (x) {
+      return SC.Object.create({ value: x });
+    }, this);
+
+    view = SC.ListView.create({
+      content: content,
+      rowSize: 50
+    });
+  },
+
+  teardown: function () {
+    view.destroy();
+    content = view = null;
+  }
+});
+
+test("Expected layout objects for each content index in vertical mode.", function () {
+  for (var i = 0, len = content.length; i < len; i++) {
+    same(view.layoutForContentIndex(i), { left: 0, right: 0, height: 50, top: i * 50 }, "The layout object at index %@ should be".fmt(i));
+  }
+});
+
+test("Expected layout objects for each content index in horizontal mode.", function () {
+  view.set('layoutDirection', SC.LAYOUT_HORIZONTAL);
+
+  for (var i = 0, len = content.length; i < len; i++) {
+    same(view.layoutForContentIndex(i), { top: 0, bottom: 0, width: 50, left: i * 50 }, "The layout object at index %@ should be".fmt(i));
+  }
+});

data/lib/frameworks/sproutcore/frameworks/desktop/tests/views/list/rowDelegate.js

@@ -9,23 +9,23 @@ var view, del, content;
 module("SC.ListView.rowDelegate", {
   setup: function() {
     del = SC.Object.create(SC.CollectionRowDelegate);
-    
+
     // fake empty array that implements delegate
     content = SC.Object.create(SC.CollectionRowDelegate, SC.Array, SC.Freezable, {
-      
+
       isFrozen: YES,
-      
+
       length: 0,
-      
+
       objectAt: function(idx) { return undefined; }
     });
-    
+
   }
 });
 
 // ..........................................................
 // BASIC CONFIGURATION
-// 
+//
 
 test("no delegate and no content", function() {
   view = SC.ListView.create();
@@ -61,18 +61,18 @@ test("with delegate and content is delegate", function() {
 
 // ..........................................................
 // CHANGING PROPERTIES
-// 
+//
 
 test("modifying delegate and content", function() {
   var callCount = 0 ;
-  
+
   view = SC.ListView.create();
   view.addObserver('rowDelegate', function() { callCount++; });
-  
+
   equals(view.get('delegate'), null, 'precond - delegate should be null');
   equals(view.get('content'), null, 'precond - content should be null');
   equals(view.get('rowDelegate'), view, 'default row delegate should view');
-  
+
   // test setting content
   callCount=0;
   SC.run(function() { view.set('content', content); });
@@ -96,41 +96,41 @@ test("modifying delegate and content", function() {
   SC.run(function() { view.set('delegate', null); });
   ok(callCount>0, 'rowDelegate should change when setting delegate');
   equals(view.get('rowDelegate'), view, 'rowDelegate should go back to view when delegate and content cleared or do not implement');
-  
+
 });
 
 // ..........................................................
 // NOTIFICATIONS
-// 
+//
 
 test("changing the rowHeight should invalidate all row heights", function() {
   var indexes = null;
   view = SC.ListView.create({
     content:  '1 2 3 4 5'.w(), // provide some content
     delegate: del,
-    
+
     // override for testing
-    rowHeightDidChangeForIndexes: function(passed) {
+    rowSizeDidChangeForIndexes: function(passed) {
       indexes = passed;
     }
   });
-  
+
   indexes = null;
   del.set('rowHeight', 30);
-  same(indexes, SC.IndexSet.create(0,5), 'changing row height should call rowHeightDidChangeForIndexes(0..5)');
-  
+  same(indexes, SC.IndexSet.create(0,5), 'changing row height should call rowSizeDidChangeForIndexes(0..5)');
+
   // remove del and try again to verify that it stops tracking changes
   view.set('delegate', null);
   indexes = null;
   del.set('rowHeight', 23);
   equals(indexes, null, 'once delegate is removed changed rowHeight should not impact anything');
-  
+
   // change row height on the view without a delegate to verify new observers
   // are setup.
   indexes = null;
   view.set('rowHeight', 14);
-  same(indexes, SC.IndexSet.create(0,5), 'changing row height should call rowHeightDidChangeForIndexes(0..5)');
-  
+  same(indexes, SC.IndexSet.create(0,5), 'changing row height should call rowSizeDidChangeForIndexes(0..5)');
+
 });
 
 
@@ -139,13 +139,13 @@ test("changing the customRowHeightIndexes should invalidate impacted row heights
   view = SC.ListView.create({
     content:  '1 2 3 4 5'.w(), // provide some content
     delegate: del,
-    
+
     // override for testing
-    rowHeightDidChangeForIndexes: function(passed) {
+    rowSizeDidChangeForIndexes: function(passed) {
       indexes = passed;
     }
   });
-  
+
   // try changing the index set
   indexes = null;
   var set = SC.IndexSet.create(2,2);
@@ -156,7 +156,7 @@ test("changing the customRowHeightIndexes should invalidate impacted row heights
   indexes = null ;
   set.add(1,3);
   same(indexes, set, 'modifying index set should invalidate all old and new indexes');
-  
+
   // changing to a new set
   indexes =null ;
   var set2 = SC.IndexSet.create(0,1);
@@ -179,5 +179,5 @@ test("changing the customRowHeightIndexes should invalidate impacted row heights
   indexes = null ;
   del.set('customRowHeightIndexes', set);
   equals(indexes, null, 'modifying delegate once removed should not change view');
-  
+
 });