spree_backend 3.0.5 → 3.0.6

data/spec/features/admin/orders/payments_spec.rb

@@ -0,0 +1,229 @@
+require 'spec_helper'
+
+describe 'Payments', type: :feature, js: true do
+  stub_authorization!
+
+  context "with a pre-existing payment" do
+
+    let!(:payment) do
+      create(:payment,
+        order:          order,
+        amount:         order.outstanding_balance,
+        payment_method: create(:credit_card_payment_method),
+        state:          state
+      )
+    end
+
+    let(:order) { create(:completed_order_with_totals, number: 'R100', line_items_count: 5) }
+    let(:state) { 'checkout' }
+
+    before do
+      visit spree.edit_admin_order_path(order)
+      click_link 'Payments'
+    end
+
+    def refresh_page
+      visit current_path
+    end
+
+    # Regression tests for #1453
+    context 'with a check payment' do
+      let(:order) { create(:completed_order_with_totals, number: 'R100') }
+      let!(:payment) do
+        create(:payment,
+          order:          order,
+          amount:         order.outstanding_balance,
+          payment_method: create(:check_payment_method)  # Check
+        )
+      end
+
+      it 'capturing a check payment from a new order' do
+        click_icon(:capture)
+        expect(page).not_to have_content('Cannot perform requested operation')
+        expect(page).to have_content('Payment Updated')
+      end
+
+      it 'voids a check payment from a new order' do
+        click_icon(:void)
+        expect(page).to have_content('Payment Updated')
+      end
+    end
+
+    it 'should list all captures for a payment' do
+      capture_amount = order.outstanding_balance/2 * 100
+      payment.capture!(capture_amount)
+
+      visit spree.admin_order_payment_path(order, payment)
+      expect(page).to have_content 'Capture events'
+      within '#capture_events' do
+        within_row(1) do
+          expect(page).to have_content(capture_amount / 100)
+        end
+      end
+    end
+
+    it 'lists and create payments for an order', js: true do
+      within_row(1) do
+        expect(column_text(3)).to eq('$150.00')
+        expect(column_text(4)).to eq('Credit Card')
+        expect(column_text(6)).to eq('checkout')
+      end
+
+      click_icon :void
+      expect(find('#payment_status').text).to eq('balance due')
+      expect(page).to have_content('Payment Updated')
+
+      within_row(1) do
+        expect(column_text(3)).to eq('$150.00')
+        expect(column_text(4)).to eq('Credit Card')
+        expect(column_text(6)).to eq('void')
+      end
+
+      click_on 'New Payment'
+      expect(page).to have_content('New Payment')
+      click_button 'Update'
+      expect(page).to have_content('successfully created!')
+
+      click_icon(:capture)
+      expect(find('#payment_status').text).to eq('paid')
+
+      expect(page).not_to have_selector('#new_payment_section')
+    end
+
+    # Regression test for #1269
+    it 'cannot create a payment for an order with no payment methods' do
+      Spree::PaymentMethod.delete_all
+      order.payments.delete_all
+
+      click_on 'New Payment'
+      expect(page).to have_content('You cannot create a payment for an order without any payment methods defined.')
+      expect(page).to have_content('Please define some payment methods first.')
+    end
+
+    %w[checkout pending].each do |state|
+      context "payment is #{state.inspect}", js: true do
+        let(:state) { state }
+
+        it 'allows the amount to be edited by clicking on the edit button then saving' do
+          within_row(1) do
+            click_icon(:edit)
+            fill_in('amount', with: '$1')
+            click_icon(:save)
+            expect(page).to have_selector('td.amount span', text: '$1.00')
+            expect(payment.reload.amount).to eq(1.00)
+          end
+        end
+
+        it 'allows the amount to be edited by clicking on the amount then saving' do
+          within_row(1) do
+            find('td.amount span').click
+            fill_in('amount', with: '$1.01')
+            click_icon(:save)
+            expect(page).to have_selector('td.amount span', text: '$1.01')
+            expect(payment.reload.amount).to eq(1.01)
+          end
+        end
+
+        it 'allows the amount change to be cancelled by clicking on the cancel button' do
+          within_row(1) do
+            click_icon(:edit)
+
+            # Can't use fill_in here, as under poltergeist that will unfocus (and
+            # thus submit) the field under poltergeist
+            find('td.amount input').click
+            page.execute_script("$('td.amount input').val('$1')")
+
+            click_icon(:cancel)
+            expect(page).to have_selector('td.amount span', text: '$150.00')
+            expect(payment.reload.amount).to eq(150.00)
+          end
+        end
+
+        it 'displays an error when the amount is invalid' do
+          within_row(1) do
+            click_icon(:edit)
+            fill_in('amount', with: 'invalid')
+            click_icon(:save)
+            expect(find('td.amount input').value).to eq('invalid')
+            expect(payment.reload.amount).to eq(150.00)
+          end
+          expect(page).to have_selector('.alert-error', text: 'Invalid resource. Please fix errors and try again.')
+        end
+      end
+    end
+
+    context 'payment is completed' do
+      let(:state) { 'completed' }
+
+      it 'does not allow the amount to be edited' do
+        within_row(1) do
+          expect(page).not_to have_selector('.fa-edit')
+          expect(page).not_to have_selector('td.amount span')
+        end
+      end
+    end
+  end
+
+  context "with no prior payments" do
+    let(:order) { create(:order_with_line_items, line_items_count: 1) }
+    let!(:payment_method) { create(:credit_card_payment_method) }
+
+    # Regression tests for #4129
+    context "with a credit card payment method" do
+      before do
+        visit spree.admin_order_payments_path(order)
+      end
+
+      it "is able to create a new credit card payment with valid information" do
+        fill_in "Card Number", with: "4111 1111 1111 1111"
+        fill_in "Name", with: "Test User"
+        fill_in "Expiration", with: "09 / #{Time.now.year + 1}"
+        fill_in "Card Code", with: "007"
+        # Regression test for #4277
+        sleep(1)
+        expect(find('.ccType', visible: false).value).to eq('visa')
+        click_button "Continue"
+        expect(page).to have_content("Payment has been successfully created!")
+      end
+
+      it "is unable to create a new payment with invalid information" do
+        click_button "Continue"
+        expect(page).to have_content("Payment could not be created.")
+        expect(page).to have_content("Number can't be blank")
+        expect(page).to have_content("Name can't be blank")
+        expect(page).to have_content("Verification Value can't be blank")
+        expect(page).to have_content("Month is not a number")
+        expect(page).to have_content("Year is not a number")
+      end
+    end
+
+    context "user existing card" do
+      let!(:cc) do
+        create(:credit_card, user_id: order.user_id, payment_method: payment_method, gateway_customer_profile_id: "BGS-RFRE")
+      end
+
+      before { visit spree.admin_order_payments_path(order) }
+
+      it "is able to reuse customer payment source" do
+        expect(find("#card_#{cc.id}")).to be_checked
+        click_button "Continue"
+        expect(page).to have_content("Payment has been successfully created!")
+      end
+    end
+
+    context "with a check" do
+      let!(:payment_method) { create(:check_payment_method) }
+
+      before do
+        visit spree.admin_order_payments_path(order.reload)
+      end
+
+      it "can successfully be created and captured" do
+        click_on 'Continue'
+        expect(page).to have_content("Payment has been successfully created!")
+        click_icon(:capture)
+        expect(page).to have_content("Payment Updated")
+      end
+    end
+  end
+end

data/spec/features/admin/orders/risk_analysis_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe 'Order Risk Analysis', type: :feature do
+  stub_authorization!
+
+  let!(:order) do
+    create(:completed_order_with_pending_payment)
+  end
+
+  def visit_order
+    visit spree.admin_path
+    click_link 'Orders'
+    within_row(1) do
+      click_link order.number
+    end
+  end
+
+  context "the order is considered risky" do
+    before do
+      allow_any_instance_of(Spree::Admin::BaseController).to receive_messages :try_spree_current_user => create(:user)
+
+      order.payments.first.update_column(:avs_response, 'X')
+      order.considered_risky!
+      visit_order
+    end
+
+    it "displays 'Risk Analysis' box" do
+      expect(page).to have_content 'Risk Analysis'
+    end
+
+    it "can be approved" do
+      click_button('Approve')
+      expect(page).to have_content 'Approver'
+      expect(page).to have_content 'Approved at'
+      expect(page).to have_content 'Status: complete'
+    end
+  end
+
+  context "the order is not considered risky" do
+    before do
+      visit_order
+    end
+
+    it "does not display 'Risk Analysis' box" do
+      expect(page).to_not have_content 'Risk Analysis'
+    end
+  end
+end

data/spec/features/admin/orders/shipments_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+describe "Shipments", type: :feature do
+  stub_authorization!
+
+  let!(:order) { create(:order_ready_to_ship, number: "R100", state: "complete", line_items_count: 5) }
+
+  # Regression test for #4025
+  context "a shipment without a shipping method" do
+    before do
+      order.shipments.each do |s|
+        # Deleting the shipping rates causes there to be no shipping methods
+        s.shipping_rates.delete_all
+      end
+    end
+
+    it "can still be displayed" do
+      expect { visit spree.edit_admin_order_path(order) }.not_to raise_error
+    end
+  end
+
+  context "shipping an order", js: true do
+    before(:each) do
+      visit spree.admin_orders_path
+      within_row(1) do
+        click_link "R100"
+      end
+    end
+
+    it "can ship a completed order" do
+      click_on "Ship"
+      wait_for_ajax
+
+      expect(page).to have_content("shipped package")
+      expect(order.reload.shipment_state).to eq("shipped")
+    end
+  end
+
+  context "moving variants between shipments", js: true do
+    let!(:la) { create(:stock_location, name: "LA") }
+    before(:each) do
+      visit spree.admin_orders_path
+      within_row(1) do
+        click_link "R100"
+      end
+    end
+
+    it "can move a variant to a new and to an existing shipment" do
+      expect(order.shipments.count).to eq(1)
+
+      within_row(1) { click_icon :split }
+      targetted_select2 'LA', from: '#s2id_item_stock_location'
+      click_icon :save
+      wait_for_ajax
+      expect(page.find("#shipment_#{order.shipments.first.id}")).to be_present
+
+      within_row(2) { click_icon :split }
+      targetted_select2 "LA(#{order.reload.shipments.last.number})", from: '#s2id_item_stock_location'
+      click_icon :save
+      wait_for_ajax
+      expect(page.find("#shipment_#{order.reload.shipments.last.id}")).to be_present
+    end
+  end
+end

data/spec/features/admin/orders/state_changes_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe "Order - State Changes", type: :feature do
+  stub_authorization!
+
+  let!(:order) { create(:order_with_line_items) }
+
+  context "for completed order" do
+    before do
+      order.next!
+      visit spree.admin_order_state_changes_path(order)
+    end
+    it 'are viewable' do
+      within_row(1) do
+        within('td:nth-child(1)') { expect(page).to have_content('Order') }
+        within('td:nth-child(2)') { expect(page).to have_content('Cart') }
+        within('td:nth-child(3)') { expect(page).to have_content('Address') }
+      end
+    end
+  end
+end

data/spec/features/admin/products/edit/images_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+
+describe "Product Images", type: :feature, js: true do
+  stub_authorization!
+
+  let(:file_path) { Rails.root + "../../spec/support/ror_ringer.jpeg" }
+
+  before do
+    # Ensure attachment style keys are symbolized before running all tests
+    # Otherwise this would result in this error:
+    # undefined method `processors' for \"48x48>\
+    Spree::Image.attachment_definitions[:attachment][:styles].symbolize_keys!
+  end
+
+  context "uploading, editing, and deleting an image" do
+    it "should allow an admin to upload and edit an image for a product" do
+      Spree::Image.attachment_definitions[:attachment].delete :storage
+
+      create(:product)
+
+      visit spree.admin_products_path
+      click_icon(:edit)
+      click_link "Images"
+      click_link "new_image_link"
+      attach_file('image_attachment', file_path)
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+
+      click_icon(:edit)
+      fill_in "image_alt", with: "ruby on rails t-shirt"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("ruby on rails t-shirt")
+
+      accept_alert do
+        click_icon :delete
+      end
+      expect(page).not_to have_content("ruby on rails t-shirt")
+    end
+  end
+
+  # Regression test for #2228
+  it "should see variant images" do
+    variant = create(:variant)
+    variant.images.create!(attachment: File.open(file_path))
+    visit spree.admin_product_images_path(variant.product)
+
+    expect(page).not_to have_content("No Images Found.")
+    within("table.table") do
+      expect(page).to have_content(variant.options_text)
+
+      #ensure no duplicate images are displayed
+      expect(page).to have_css("tbody tr", count: 1)
+
+      #ensure variant header is displayed
+      within("thead") do
+        expect(page.body).to have_content("Variant")
+      end
+
+      #ensure variant header is displayed
+      within("tbody") do
+        expect(page).to have_content("Size: S")
+      end
+    end
+  end
+
+  it "should not see variant column when product has no variants" do
+    product = create(:product)
+    product.images.create!(attachment: File.open(file_path))
+    visit spree.admin_product_images_path(product)
+
+    expect(page).not_to have_content("No Images Found.")
+    within("table.table") do
+      #ensure no duplicate images are displayed
+      expect(page).to have_css("tbody tr", count: 1)
+
+      #ensure variant header is not displayed
+      within("thead") do
+        expect(page).not_to have_content("Variant")
+      end
+
+      #ensure correct cell count
+      expect(page).to have_css("thead th", count: 3)
+    end
+  end
+end