spree_backend 3.0.5 → 3.0.6

data/spec/features/admin/products/properties_spec.rb

@@ -0,0 +1,140 @@
+require 'spec_helper'
+
+describe "Properties", type: :feature, js: true do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_products_path
+  end
+
+  context "Property index" do
+    before do
+      create(:property, name: 'shirt size', presentation: 'size')
+      create(:property, name: 'shirt fit', presentation: 'fit')
+      click_link "Products"
+      click_link "Properties"
+    end
+
+    context "listing product properties" do
+      it "should list the existing product properties" do
+        within_row(1) do
+          expect(column_text(1)).to eq("shirt size")
+          expect(column_text(2)).to eq("size")
+        end
+
+        within_row(2) do
+          expect(column_text(1)).to eq("shirt fit")
+          expect(column_text(2)).to eq("fit")
+        end
+      end
+    end
+
+    context "searching properties" do
+      it 'should list properties matching search query' do
+        click_on "Filter"
+        fill_in "q_name_cont", with: "size"
+        click_on 'Search'
+        
+        expect(page).to have_content("shirt size")
+        expect(page).not_to have_content("shirt fit")
+      end
+    end
+  end
+
+  context "creating a property" do
+    it "should allow an admin to create a new product property", js: true do
+      click_link "Products"
+      click_link "Properties"
+      click_link "new_property_link"
+      within('.content-header') { expect(page).to have_content("New Property") }
+
+      fill_in "property_name", with: "color of band"
+      fill_in "property_presentation", with: "color"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+  end
+
+  context "editing a property" do
+    before(:each) do
+      create(:property)
+      click_link "Products"
+      click_link "Properties"
+      within_row(1) { click_icon :edit }
+    end
+
+    it "should allow an admin to edit an existing product property" do
+      fill_in "property_name", with: "model 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("model 99")
+    end
+
+    it "should show validation errors" do
+      fill_in "property_name", with: ""
+      click_button "Update"
+      expect(page).to have_content("Name can't be blank")
+    end
+  end
+
+  context "linking a property to a product" do
+    before do
+      create(:product)
+      visit spree.admin_products_path
+      click_icon :edit
+      click_link "Properties"
+    end
+
+    # Regression test for #2279
+    it "successfully create and then remove product property" do
+      fill_in_property
+      # Sometimes the page doesn't load before the all check is done
+      # lazily finding the element gives the page 10 seconds
+      expect(page).to have_css("tbody#product_properties tr:nth-child(2)")
+      expect(all("tbody#product_properties tr").count).to eq(2)
+
+      delete_product_property
+
+      check_property_row_count(1)
+    end
+
+    # Regression test for #4466
+    it "successfully remove and create a product property at the same time" do
+      fill_in_property
+
+      fill_in "product_product_properties_attributes_1_property_name", with: "New Property"
+      fill_in "product_product_properties_attributes_1_value", with: "New Value"
+
+      delete_product_property
+
+      # Give fadeOut time to complete
+      expect(page).not_to have_selector("#product_product_properties_attributes_0_property_name")
+      expect(page).not_to have_selector("#product_product_properties_attributes_0_value")
+
+      click_button "Update"
+
+      expect(page).not_to have_content("Product is not found")
+
+      check_property_row_count(2)
+    end
+
+    def fill_in_property
+      fill_in "product_product_properties_attributes_0_property_name", with: "A Property"
+      fill_in "product_product_properties_attributes_0_value", with: "A Value"
+      click_button "Update"
+      click_link "Properties"
+    end
+
+    def delete_product_property
+      page.evaluate_script('window.confirm = function() { return true; }')
+      click_icon :delete
+      wait_for_ajax # delete action must finish before reloading
+    end
+
+    def check_property_row_count(expected_row_count)
+      click_link "Properties"
+      expect(page).to have_css("tbody#product_properties")
+      expect(all("tbody#product_properties tr").count).to eq(expected_row_count)
+    end
+  end
+end

data/spec/features/admin/products/prototypes_spec.rb

@@ -0,0 +1,112 @@
+require 'spec_helper'
+
+describe "Prototypes", type: :feature, js: true do
+  stub_authorization!
+
+  context "listing prototypes" do
+    it "should be able to list existing prototypes" do
+      create(:property, name: "model", presentation: "Model")
+      create(:property, name: "brand", presentation: "Brand")
+      create(:property, name: "shirt_fabric", presentation: "Fabric")
+      create(:property, name: "shirt_sleeve_length", presentation: "Sleeve")
+      create(:property, name: "mug_type", presentation: "Type")
+      create(:property, name: "bag_type", presentation: "Type")
+      create(:property, name: "manufacturer", presentation: "Manufacturer")
+      create(:property, name: "bag_size", presentation: "Size")
+      create(:property, name: "mug_size", presentation: "Size")
+      create(:property, name: "gender", presentation: "Gender")
+      create(:property, name: "shirt_fit", presentation: "Fit")
+      create(:property, name: "bag_material", presentation: "Material")
+      create(:property, name: "shirt_type", presentation: "Type")
+      p = create(:prototype, name: "Shirt")
+      %w( brand gender manufacturer model shirt_fabric shirt_fit shirt_sleeve_length shirt_type ).each do |prop|
+        p.properties << Spree::Property.find_by_name(prop)
+      end
+      p = create(:prototype, name: "Mug")
+      %w( mug_size mug_type ).each do |prop|
+        p.properties << Spree::Property.find_by_name(prop)
+      end
+      p = create(:prototype, name: "Bag")
+      %w( bag_type bag_material ).each do |prop|
+        p.properties << Spree::Property.find_by_name(prop)
+      end
+
+      visit spree.admin_path
+      click_link "Products"
+      click_link "Prototypes"
+
+      within_row(1) { expect(column_text(1)).to eq "Shirt" }
+      within_row(2) { expect(column_text(1)).to eq "Mug" }
+      within_row(3) { expect(column_text(1)).to eq "Bag" }
+    end
+  end
+
+  context "creating a prototype" do
+    it "should allow an admin to create a new product prototype" do
+      visit spree.admin_path
+      click_link "Products"
+      click_link "Prototypes"
+
+      click_link "new_prototype_link"
+      within('.content-header') do
+        expect(page).to have_content("New Prototype")
+      end
+      fill_in "prototype_name", with: "male shirts"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+      click_link "Products"
+      click_link "Prototypes"
+      within_row(1) { click_icon :edit }
+      fill_in "prototype_name", with: "Shirt 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("Shirt 99")
+    end
+  end
+
+  context "editing a prototype" do
+    it "should allow to empty its properties" do
+      model_property = create(:property, name: "model", presentation: "Model")
+      brand_property = create(:property, name: "brand", presentation: "Brand")
+
+      shirt_prototype = create(:prototype, name: "Shirt", properties: [])
+      %w( brand model ).each do |prop|
+        shirt_prototype.properties << Spree::Property.find_by_name(prop)
+      end
+
+      visit spree.admin_path
+      click_link "Products"
+      click_link "Prototypes"
+
+      click_icon :edit
+      property_ids = find_field("prototype_property_ids").value.map(&:to_i)
+      expect(property_ids).to match_array [model_property.id, brand_property.id]
+
+      unselect "Brand", from: "prototype_property_ids"
+      unselect "Model", from: "prototype_property_ids"
+
+      click_button 'Update'
+
+      click_icon :edit
+
+      expect(find_field("prototype_property_ids").value).to be_empty
+    end
+  end
+
+  it 'should be deletable', js: true do
+    shirt_prototype = create(:prototype, name: "Shirt", properties: [])
+    shirt_prototype.taxons << create(:taxon)
+
+    visit spree.admin_path
+    click_link "Products"
+    click_link "Prototypes"
+
+    within("#spree_prototype_#{shirt_prototype.id}") do
+      page.find('.delete-resource').click
+    end
+
+    page.evaluate_script('window.confirm = function() { return true; }')
+
+    expect(page).to have_content("Prototype \"#{shirt_prototype.name}\" has been successfully removed!")
+  end
+end

data/spec/features/admin/products/stock_management_spec.rb

@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+describe "Stock Management", type: :feature, js: true do
+  stub_authorization!
+
+  context "given a product with a variant and a stock location" do
+    let!(:stock_location) { create(:stock_location, name: 'Default') }
+    let!(:product) { create(:product, name: 'apache baseball cap', price: 10) }
+    let!(:variant) { product.master }
+
+    before do
+      stock_location.stock_item(variant).update_column(:count_on_hand, 10)
+      visit spree.stock_admin_product_path(product)
+    end
+
+    context "toggle backorderable for a variant's stock item" do
+      let(:backorderable) { find ".stock_item_backorderable" }
+
+      before do
+        expect(backorderable).to be_checked
+        backorderable.set(false)
+        wait_for_ajax
+      end
+
+      it "persists the value when page reload", js: true do
+        visit current_path
+        expect(backorderable).not_to be_checked
+      end
+    end
+
+    context "toggle track inventory for a variant's stock item" do
+      let(:track_inventory) { find ".track_inventory_checkbox" }
+
+      before do
+        expect(track_inventory).to be_checked
+        track_inventory.set(false)
+        wait_for_ajax
+      end
+
+      it "persists the value when page reloaded", js: true do
+        visit current_path
+        expect(track_inventory).not_to be_checked
+      end
+    end
+
+    # Regression test for #2896
+    # The regression was that unchecking the last checkbox caused a redirect
+    # to happen. By ensuring that we're still on an /admin/products URL, we
+    # assert that the redirect is *not* happening.
+    it "can toggle backorderable for the second variant stock item", js: true do
+      new_location = create(:stock_location, name: "Another Location")
+      visit current_url
+
+      new_location_backorderable = find "#stock_item_backorderable_#{new_location.id}"
+      new_location_backorderable.set(false)
+      wait_for_ajax
+
+      expect(page.current_url).to include("/admin/products")
+    end
+
+    it "can create a new stock movement", js: true do
+      fill_in "stock_movement_quantity", with: 5
+      select2 "default", from: "Stock Location"
+      click_button "Add Stock"
+
+      expect(page).to have_content('successfully created')
+
+      within(:css, '.stock_location_info table') do
+        expect(column_text(2)).to eq '15'
+      end
+    end
+
+    it "can create a new negative stock movement", js: true do
+      fill_in "stock_movement_quantity", with: -5
+      select2 "default", from: "Stock Location"
+      click_button "Add Stock"
+
+      expect(page).to have_content('successfully created')
+
+      within(:css, '.stock_location_info table') do
+        expect(column_text(2)).to eq '5'
+      end
+    end
+
+    context "with multiple variants" do
+      before do
+        variant = product.variants.create!(sku: 'SPREEC')
+        variant.stock_items.first.update_column(:count_on_hand, 30)
+        visit current_url
+      end
+
+      it "can create a new stock movement for the specified variant", js: true do
+        fill_in "stock_movement_quantity", with: 10
+        select2 "SPREEC", from: "Variant"
+        click_button "Add Stock"
+
+        expect(page).to have_content('successfully created')
+
+        within("#listing_product_stock tr", :text => "SPREEC") do
+          within("table") do
+            expect(column_text(2)).to eq '40'
+          end
+        end
+      end
+    end
+
+    # Regression test for #3304
+    context "with no stock location" do
+      before do
+        @product = create(:product, name: 'apache baseball cap', price: 10)
+        v = @product.variants.create!(sku: 'FOOBAR')
+        Spree::StockLocation.delete_all
+
+        visit spree.stock_admin_product_path(@product)
+      end
+
+      it "redirects to stock locations page" do
+        expect(page).to have_content(Spree.t(:stock_management_requires_a_stock_location))
+        expect(page.current_url).to include("admin/stock_locations")
+      end
+    end
+  end
+end

data/spec/features/admin/products/taxonomies_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe "Taxonomies", type: :feature, js: true do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_path
+    click_link "Products"
+  end
+
+  context "show" do
+    it "should display existing taxonomies" do
+      create(:taxonomy, name: 'Brand')
+      create(:taxonomy, name: 'Categories')
+      click_link "Taxonomies"
+      within_row(1) { expect(page).to have_content("Brand") }
+      within_row(2) { expect(page).to have_content("Categories") }
+    end
+  end
+
+  context "create" do
+    before(:each) do
+      click_link "Taxonomies"
+      click_link "admin_new_taxonomy_link"
+    end
+
+    it "should allow an admin to create a new taxonomy" do
+      expect(page).to have_content("New Taxonomy")
+      fill_in "taxonomy_name", with: "sports"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+
+    it "should display validation errors" do
+      fill_in "taxonomy_name", with: ""
+      click_button "Create"
+      expect(page).to have_content("can't be blank")
+    end
+  end
+
+  context "edit" do
+    it "should allow an admin to update an existing taxonomy" do
+      create(:taxonomy)
+      click_link "Taxonomies"
+      within_row(1) { click_icon :edit }
+      fill_in "taxonomy_name", with: "sports 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("sports 99")
+    end
+  end
+end

data/spec/features/admin/products/variant_spec.rb

@@ -0,0 +1,50 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe "Variants", type: :feature, js: true do
+  stub_authorization!
+
+  let(:product) { create(:product_with_option_types, price: "1.99", cost_price: "1.00", weight: "2.5", height: "3.0", width: "1.0", depth: "1.5") }
+
+  context "creating a new variant" do
+    it "should allow an admin to create a new variant" do
+      product.options.each do |option|
+        create(:option_value, option_type: option.option_type)
+      end
+
+      visit spree.admin_products_path
+      within_row(1) { click_icon :edit }
+      click_link "Variants"
+      click_on "Add One"
+      expect(find('input#variant_price').value).to eq("1.99")
+      expect(find('input#variant_cost_price').value).to eq("1.00")
+      expect(find('input#variant_weight').value).to eq("2.50")
+      expect(find('input#variant_height').value).to eq("3.00")
+      expect(find('input#variant_width').value).to eq("1.00")
+      expect(find('input#variant_depth').value).to eq("1.50")
+      expect(page).to have_select('variant[tax_category_id]')
+    end
+  end
+
+  context "listing variants" do
+    context "currency displaying" do
+      context "using Russian Rubles" do
+        before do
+          Spree::Config[:currency] = "RUB"
+        end
+
+        let!(:variant) do
+          create(:variant, product: product, price: 19.99)
+        end
+
+        # Regression test for #2737
+        context "uses руб as the currency symbol" do
+          it "on the products listing page" do
+            visit spree.admin_product_variants_path(product)
+            within_row(1) { expect(page).to have_content("19.99 ₽") }
+          end
+        end
+      end
+    end
+  end
+end