split 4.0.1 → 4.0.3

data/spec/dashboard/pagination_helpers_spec.rb

@@ -1,108 +1,110 @@
-require 'spec_helper'
-require 'split/dashboard/pagination_helpers'
+# frozen_string_literal: true
+
+require "spec_helper"
+require "split/dashboard/pagination_helpers"
 
 describe Split::DashboardPaginationHelpers do
   include Split::DashboardPaginationHelpers
 
-  let(:url) { '/split/' }
+  let(:url) { "/split/" }
 
-  describe '#pagination_per' do
-    context 'when params empty' do
+  describe "#pagination_per" do
+    context "when params empty" do
       let(:params) { Hash[] }
 
-      it 'returns the default (10)' do
+      it "returns the default (10)" do
         default_per_page = Split.configuration.dashboard_pagination_default_per_page
         expect(pagination_per).to eql default_per_page
         expect(pagination_per).to eql 10
       end
     end
 
-    context 'when params[:per] is 5' do
+    context "when params[:per] is 5" do
       let(:params) { Hash[per: 5] }
 
-      it 'returns 5' do
+      it "returns 5" do
         expect(pagination_per).to eql 5
       end
     end
   end
 
-  describe '#page_number' do
-    context 'when params empty' do
+  describe "#page_number" do
+    context "when params empty" do
       let(:params) { Hash[] }
 
-      it 'returns 1' do
+      it "returns 1" do
         expect(page_number).to eql 1
       end
     end
 
     context 'when params[:page] is "2"' do
-      let(:params) { Hash[page: '2'] }
+      let(:params) { Hash[page: "2"] }
 
-      it 'returns 2' do
+      it "returns 2" do
         expect(page_number).to eql 2
       end
     end
   end
 
-  describe '#paginated' do
+  describe "#paginated" do
     let(:collection) { (1..20).to_a }
-    let(:params) { Hash[per: '5', page: '3'] }
+    let(:params) { Hash[per: "5", page: "3"] }
 
     it { expect(paginated(collection)).to eql [11, 12, 13, 14, 15] }
   end
 
-  describe '#show_first_page_tag?' do
-    context 'when page is 1' do
+  describe "#show_first_page_tag?" do
+    context "when page is 1" do
       it { expect(show_first_page_tag?).to be false }
     end
 
-    context 'when page is 3' do
-      let(:params) { Hash[page: '3'] }
+    context "when page is 3" do
+      let(:params) { Hash[page: "3"] }
       it { expect(show_first_page_tag?).to be true }
     end
   end
 
-  describe '#first_page_tag' do
+  describe "#first_page_tag" do
     it { expect(first_page_tag).to eql '<a href="/split?page=1&per=10">1</a>' }
   end
 
-  describe '#show_first_ellipsis_tag?' do
-    context 'when page is 1' do
+  describe "#show_first_ellipsis_tag?" do
+    context "when page is 1" do
       it { expect(show_first_ellipsis_tag?).to be false }
     end
 
-    context 'when page is 4' do
-      let(:params) { Hash[page: '4'] }
+    context "when page is 4" do
+      let(:params) { Hash[page: "4"] }
       it { expect(show_first_ellipsis_tag?).to be true }
     end
   end
 
-  describe '#ellipsis_tag' do
-    it { expect(ellipsis_tag).to eql '<span>...</span>' }
+  describe "#ellipsis_tag" do
+    it { expect(ellipsis_tag).to eql "<span>...</span>" }
   end
 
-  describe '#show_prev_page_tag?' do
-    context 'when page is 1' do
+  describe "#show_prev_page_tag?" do
+    context "when page is 1" do
       it { expect(show_prev_page_tag?).to be false }
     end
 
-    context 'when page is 2' do
-      let(:params) { Hash[page: '2'] }
+    context "when page is 2" do
+      let(:params) { Hash[page: "2"] }
       it { expect(show_prev_page_tag?).to be true }
     end
   end
 
-  describe '#prev_page_tag' do
-    context 'when page is 2' do
-      let(:params) { Hash[page: '2'] }
+  describe "#prev_page_tag" do
+    context "when page is 2" do
+      let(:params) { Hash[page: "2"] }
 
       it do
         expect(prev_page_tag).to eql '<a href="/split?page=1&per=10">1</a>'
       end
     end
 
-    context 'when page is 3' do
-      let(:params) { Hash[page: '3'] }
+    context "when page is 3" do
+      let(:params) { Hash[page: "3"] }
 
       it do
         expect(prev_page_tag).to eql '<a href="/split?page=2&per=10">2</a>'
@@ -110,90 +112,90 @@ describe Split::DashboardPaginationHelpers do
     end
   end
 
-  describe '#show_prev_page_tag?' do
-    context 'when page is 1' do
+  describe "#show_prev_page_tag?" do
+    context "when page is 1" do
       it { expect(show_prev_page_tag?).to be false }
     end
 
-    context 'when page is 2' do
-      let(:params) { Hash[page: '2'] }
+    context "when page is 2" do
+      let(:params) { Hash[page: "2"] }
       it { expect(show_prev_page_tag?).to be true }
     end
   end
 
-  describe '#current_page_tag' do
-    context 'when page is 1' do
-      let(:params) { Hash[page: '1'] }
-      it { expect(current_page_tag).to eql '<span><b>1</b></span>' }
+  describe "#current_page_tag" do
+    context "when page is 1" do
+      let(:params) { Hash[page: "1"] }
+      it { expect(current_page_tag).to eql "<span><b>1</b></span>" }
     end
 
-    context 'when page is 2' do
-      let(:params) { Hash[page: '2'] }
-      it { expect(current_page_tag).to eql '<span><b>2</b></span>' }
+    context "when page is 2" do
+      let(:params) { Hash[page: "2"] }
+      it { expect(current_page_tag).to eql "<span><b>2</b></span>" }
     end
   end
 
-  describe '#show_next_page_tag?' do
-    context 'when page is 2' do
-      let(:params) { Hash[page: '2'] }
+  describe "#show_next_page_tag?" do
+    context "when page is 2" do
+      let(:params) { Hash[page: "2"] }
 
-      context 'when collection length is 20' do
+      context "when collection length is 20" do
         let(:collection) { (1..20).to_a }
         it { expect(show_next_page_tag?(collection)).to be false }
       end
 
-      context 'when collection length is 25' do
+      context "when collection length is 25" do
         let(:collection) { (1..25).to_a }
         it { expect(show_next_page_tag?(collection)).to be true }
       end
     end
   end
 
-  describe '#next_page_tag' do
-    context 'when page is 1' do
-      let(:params) { Hash[page: '1'] }
+  describe "#next_page_tag" do
+    context "when page is 1" do
+      let(:params) { Hash[page: "1"] }
       it { expect(next_page_tag).to eql '<a href="/split?page=2&per=10">2</a>' }
     end
 
-    context 'when page is 2' do
-      let(:params) { Hash[page: '2'] }
+    context "when page is 2" do
+      let(:params) { Hash[page: "2"] }
       it { expect(next_page_tag).to eql '<a href="/split?page=3&per=10">3</a>' }
     end
   end
 
-  describe '#total_pages' do
-    context 'when collection length is 30' do
+  describe "#total_pages" do
+    context "when collection length is 30" do
       let(:collection) { (1..30).to_a }
       it { expect(total_pages(collection)).to eql 3 }
     end
 
-    context 'when collection length is 35' do
+    context "when collection length is 35" do
       let(:collection) { (1..35).to_a }
       it { expect(total_pages(collection)).to eql 4 }
     end
   end
 
-  describe '#show_last_ellipsis_tag?' do
+  describe "#show_last_ellipsis_tag?" do
     let(:collection) { (1..30).to_a }
-    let(:params) { Hash[per: '5', page: '2'] }
+    let(:params) { Hash[per: "5", page: "2"] }
     it { expect(show_last_ellipsis_tag?(collection)).to be true }
   end
 
-  describe '#show_last_page_tag?' do
+  describe "#show_last_page_tag?" do
     let(:collection) { (1..30).to_a }
 
-    context 'when page is 5/6' do
-      let(:params) { Hash[per: '5', page: '5'] }
+    context "when page is 5/6" do
+      let(:params) { Hash[per: "5", page: "5"] }
       it { expect(show_last_page_tag?(collection)).to be false }
     end
 
-    context 'when page is 4/6' do
-      let(:params) { Hash[per: '5', page: '4'] }
+    context "when page is 4/6" do
+      let(:params) { Hash[per: "5", page: "4"] }
       it { expect(show_last_page_tag?(collection)).to be true }
     end
   end
 
-  describe '#last_page_tag' do
+  describe "#last_page_tag" do
     let(:collection) { (1..30).to_a }
     it { expect(last_page_tag(collection)).to eql '<a href="/split?page=3&per=10">3</a>' }
   end

data/spec/dashboard/paginator_spec.rb

@@ -1,34 +1,35 @@
 # frozen_string_literal: true
-require 'spec_helper'
-require 'split/dashboard/paginator'
+
+require "spec_helper"
+require "split/dashboard/paginator"
 
 describe Split::DashboardPaginator do
-  context 'when collection is 1..20' do
+  context "when collection is 1..20" do
     let(:collection) { (1..20).to_a }
 
-    context 'when per 5 for page' do
+    context "when per 5 for page" do
       let(:per) { 5 }
 
-      it 'when page number is 1 result is [1, 2, 3, 4, 5]' do
+      it "when page number is 1 result is [1, 2, 3, 4, 5]" do
         result = Split::DashboardPaginator.new(collection, 1, per).paginate
         expect(result).to eql [1, 2, 3, 4, 5]
       end
 
-      it 'when page number is 2 result is [6, 7, 8, 9, 10]' do
+      it "when page number is 2 result is [6, 7, 8, 9, 10]" do
         result = Split::DashboardPaginator.new(collection, 2, per).paginate
         expect(result).to eql [6, 7, 8, 9, 10]
       end
     end
 
-    context 'when per 10 for page' do
+    context "when per 10 for page" do
       let(:per) { 10 }
 
-      it 'when page number is 1 result is [1..10]' do
+      it "when page number is 1 result is [1..10]" do
         result = Split::DashboardPaginator.new(collection, 1, per).paginate
         expect(result).to eql [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
       end
 
-      it 'when page number is 2 result is [10..20]' do
+      it "when page number is 2 result is [10..20]" do
         result = Split::DashboardPaginator.new(collection, 2, per).paginate
         expect(result).to eql [11, 12, 13, 14, 15, 16, 17, 18, 19, 20]
       end

data/spec/dashboard_helpers_spec.rb

@@ -1,41 +1,42 @@
 # frozen_string_literal: true
-require 'spec_helper'
-require 'split/dashboard/helpers'
+
+require "spec_helper"
+require "split/dashboard/helpers"
 
 include Split::DashboardHelpers
 
 describe Split::DashboardHelpers do
-  describe 'confidence_level' do
-    it 'should handle very small numbers' do
-      expect(confidence_level(Complex(2e-18, -0.03))).to eq('Insufficient confidence')
+  describe "confidence_level" do
+    it "should handle very small numbers" do
+      expect(confidence_level(Complex(2e-18, -0.03))).to eq("Insufficient confidence")
     end
 
     it "should consider a z-score of 1.65 <= z < 1.96 as 90% confident" do
-      expect(confidence_level(1.65)).to eq('90% confidence')
-      expect(confidence_level(1.80)).to eq('90% confidence')
+      expect(confidence_level(1.65)).to eq("90% confidence")
+      expect(confidence_level(1.80)).to eq("90% confidence")
     end
 
     it "should consider a z-score of 1.96 <= z < 2.58 as 95% confident" do
-      expect(confidence_level(1.96)).to eq('95% confidence')
-      expect(confidence_level(2.00)).to eq('95% confidence')
+      expect(confidence_level(1.96)).to eq("95% confidence")
+      expect(confidence_level(2.00)).to eq("95% confidence")
     end
 
     it "should consider a z-score of z >= 2.58 as 99% confident" do
-      expect(confidence_level(2.58)).to eq('99% confidence')
-      expect(confidence_level(3.00)).to eq('99% confidence')
+      expect(confidence_level(2.58)).to eq("99% confidence")
+      expect(confidence_level(3.00)).to eq("99% confidence")
     end
 
-    describe '#round' do
-      it 'can round number strings' do
-        expect(round('3.1415')).to eq BigDecimal('3.14')
+    describe "#round" do
+      it "can round number strings" do
+        expect(round("3.1415")).to eq BigDecimal("3.14")
       end
 
-      it 'can round number strings for precsion' do
-        expect(round('3.1415', 1)).to eq BigDecimal('3.1')
+      it "can round number strings for precsion" do
+        expect(round("3.1415", 1)).to eq BigDecimal("3.1")
       end
 
-      it 'can handle invalid number strings' do
-        expect(round('N/A')).to be_zero
+      it "can handle invalid number strings" do
+        expect(round("N/A")).to be_zero
       end
     end
   end

data/spec/dashboard_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-require 'spec_helper'
-require 'rack/test'
-require 'split/dashboard'
+
+require "spec_helper"
+require "rack/test"
+require "split/dashboard"
 
 describe Split::Dashboard do
   include Rack::Test::Methods
@@ -9,8 +10,8 @@ describe Split::Dashboard do
   class TestDashboard < Split::Dashboard
     include Split::Helper
 
-    get '/my_experiment' do
-      ab_test(params[:experiment], 'blue', 'red')
+    get "/my_experiment" do
+      ab_test(params[:experiment], "blue", "red")
     end
   end
 
@@ -27,11 +28,11 @@ describe Split::Dashboard do
   }
 
   let(:experiment_with_goals) {
-    Split::ExperimentCatalog.find_or_create({"link_color" => ["goal_1", "goal_2"]}, "blue", "red")
+    Split::ExperimentCatalog.find_or_create({ "link_color" => ["goal_1", "goal_2"] }, "blue", "red")
   }
 
   let(:metric) {
-    Split::Metric.find_or_create(name: 'testmetric', experiments: [experiment, experiment_with_goals])
+    Split::Metric.find_or_create(name: "testmetric", experiments: [experiment, experiment_with_goals])
   }
 
   let(:red_link) { link("red") }
@@ -42,7 +43,7 @@ describe Split::Dashboard do
   end
 
   it "should respond to /" do
-    get '/'
+    get "/"
     expect(last_response).to be_ok
   end
 
@@ -54,33 +55,33 @@ describe Split::Dashboard do
     context "experiment without goals" do
       it "should display a Start button" do
         experiment
-        get '/'
-        expect(last_response.body).to include('Start')
+        get "/"
+        expect(last_response.body).to include("Start")
 
         post "/start?experiment=#{experiment.name}"
-        get '/'
-        expect(last_response.body).to include('Reset Data')
-        expect(last_response.body).not_to include('Metrics:')
+        get "/"
+        expect(last_response.body).to include("Reset Data")
+        expect(last_response.body).not_to include("Metrics:")
       end
     end
 
     context "experiment with metrics" do
       it "should display the names of associated metrics" do
         metric
-        get '/'
-        expect(last_response.body).to include('Metrics:testmetric')
+        get "/"
+        expect(last_response.body).to include("Metrics:testmetric")
       end
     end
 
     context "with goals" do
       it "should display a Start button" do
         experiment_with_goals
-        get '/'
-        expect(last_response.body).to include('Start')
+        get "/"
+        expect(last_response.body).to include("Start")
 
         post "/start?experiment=#{experiment.name}"
-        get '/'
-        expect(last_response.body).to include('Reset Data')
+        get "/"
+        expect(last_response.body).to include("Reset Data")
       end
     end
   end
@@ -88,7 +89,7 @@ describe Split::Dashboard do
   describe "force alternative" do
     context "initial version" do
       let!(:user) do
-        Split::User.new(@app, { experiment.name => 'red' })
+        Split::User.new(@app, { experiment.name => "red" })
       end
 
       before do
@@ -115,7 +116,7 @@ describe Split::Dashboard do
     context "incremented version" do
       let!(:user) do
         experiment.increment_version
-        Split::User.new(@app, { "#{experiment.name}:#{experiment.version}" => 'red' })
+        Split::User.new(@app, { "#{experiment.name}:#{experiment.version}" => "red" })
       end
 
       before do
@@ -134,28 +135,28 @@ describe Split::Dashboard do
 
   describe "index page" do
     context "with winner" do
-      before { experiment.winner = 'red' }
+      before { experiment.winner = "red" }
 
       it "displays `Reopen Experiment` button" do
-        get '/'
+        get "/"
 
-        expect(last_response.body).to include('Reopen Experiment')
+        expect(last_response.body).to include("Reopen Experiment")
       end
     end
 
     context "without winner" do
       it "should not display `Reopen Experiment` button" do
-        get '/'
+        get "/"
 
-        expect(last_response.body).to_not include('Reopen Experiment')
+        expect(last_response.body).to_not include("Reopen Experiment")
       end
     end
   end
 
   describe "reopen experiment" do
-    before { experiment.winner = 'red' }
+    before { experiment.winner = "red" }
 
-    it 'redirects' do
+    it "redirects" do
       post "/reopen?experiment=#{experiment.name}"
 
       expect(last_response).to be_redirect
@@ -170,7 +171,7 @@ describe Split::Dashboard do
     it "keeps existing stats" do
       red_link.participant_count = 5
       blue_link.participant_count = 7
-      experiment.winner = 'blue'
+      experiment.winner = "blue"
 
       post "/reopen?experiment=#{experiment.name}"
 
@@ -201,10 +202,41 @@ describe Split::Dashboard do
     end
   end
 
+  describe "initialize experiment" do
+    before do
+      Split.configuration.experiments = {
+        my_experiment: {
+          alternatives: [ "control", "alternative" ],
+        }
+      }
+    end
+
+    it "initializes the experiment when the experiment is given" do
+      expect(Split::ExperimentCatalog.find("my_experiment")).to be nil
+
+      post "/initialize_experiment", { experiment: "my_experiment" }
+
+      experiment = Split::ExperimentCatalog.find("my_experiment")
+      expect(experiment).to be_a(Split::Experiment)
+    end
+
+    it "does not attempt to intialize the experiment when empty experiment is given" do
+      post "/initialize_experiment", { experiment: "" }
+
+      expect(Split::ExperimentCatalog).to_not receive(:find_or_create)
+    end
+
+    it "does not attempt to intialize the experiment when no experiment is given" do
+      post "/initialize_experiment"
+
+      expect(Split::ExperimentCatalog).to_not receive(:find_or_create)
+    end
+  end
+
   it "should reset an experiment" do
     red_link.participant_count = 5
     blue_link.participant_count = 7
-    experiment.winner = 'blue'
+    experiment.winner = "blue"
 
     post "/reset?experiment=#{experiment.name}"
 
@@ -226,16 +258,16 @@ describe Split::Dashboard do
 
   it "should mark an alternative as the winner" do
     expect(experiment.winner).to be_nil
-    post "/experiment?experiment=#{experiment.name}", :alternative => 'red'
+    post "/experiment?experiment=#{experiment.name}", alternative: "red"
 
     expect(last_response).to be_redirect
-    expect(experiment.winner.name).to eq('red')
+    expect(experiment.winner.name).to eq("red")
   end
 
   it "should display the start date" do
     experiment.start
 
-    get '/'
+    get "/"
 
     expect(last_response.body).to include("<small>#{experiment.start_time.strftime('%Y-%m-%d')}</small>")
   end
@@ -243,8 +275,20 @@ describe Split::Dashboard do
   it "should handle experiments without a start date" do
     Split.redis.hdel(:experiment_start_times, experiment.name)
 
-    get '/'
+    get "/"
+
+    expect(last_response.body).to include("<small>Unknown</small>")
+  end
+
+  it "should be explode with experiments with invalid data" do
+    red_link.participant_count = 1
+    red_link.set_completed_count(10)
+
+    blue_link.participant_count = 3
+    blue_link.set_completed_count(2)
 
-    expect(last_response.body).to include('<small>Unknown</small>')
+    get "/"
+
+    expect(last_response).to be_ok
   end
 end