split 4.0.1 → 4.0.3

data/lib/split/configuration.rb

@@ -39,83 +39,83 @@ module Split
     def bots
       @bots ||= {
         # Indexers
-        'AdsBot-Google' => 'Google Adwords',
-        'Baidu' => 'Chinese search engine',
-        'Baiduspider' => 'Chinese search engine',
-        'bingbot' => 'Microsoft bing bot',
-        'Butterfly' => 'Topsy Labs',
-        'Gigabot' => 'Gigabot spider',
-        'Googlebot' => 'Google spider',
-        'MJ12bot' => 'Majestic-12 spider',
-        'msnbot' => 'Microsoft bot',
-        'rogerbot' => 'SeoMoz spider',
-        'PaperLiBot' => 'PaperLi is another content curation service',
-        'Slurp' => 'Yahoo spider',
-        'Sogou' => 'Chinese search engine',
-        'spider' => 'generic web spider',
-        'UnwindFetchor' => 'Gnip crawler',
-        'WordPress' => 'WordPress spider',
-        'YandexAccessibilityBot' => 'Yandex accessibility spider',
-        'YandexBot' => 'Yandex spider',
-        'YandexMobileBot' => 'Yandex mobile spider',
-        'ZIBB' => 'ZIBB spider',
+        "AdsBot-Google" => "Google Adwords",
+        "Baidu" => "Chinese search engine",
+        "Baiduspider" => "Chinese search engine",
+        "bingbot" => "Microsoft bing bot",
+        "Butterfly" => "Topsy Labs",
+        "Gigabot" => "Gigabot spider",
+        "Googlebot" => "Google spider",
+        "MJ12bot" => "Majestic-12 spider",
+        "msnbot" => "Microsoft bot",
+        "rogerbot" => "SeoMoz spider",
+        "PaperLiBot" => "PaperLi is another content curation service",
+        "Slurp" => "Yahoo spider",
+        "Sogou" => "Chinese search engine",
+        "spider" => "generic web spider",
+        "UnwindFetchor" => "Gnip crawler",
+        "WordPress" => "WordPress spider",
+        "YandexAccessibilityBot" => "Yandex accessibility spider",
+        "YandexBot" => "Yandex spider",
+        "YandexMobileBot" => "Yandex mobile spider",
+        "ZIBB" => "ZIBB spider",
 
         # HTTP libraries
-        'Apache-HttpClient' => 'Java http library',
-        'AppEngine-Google' => 'Google App Engine',
-        'curl' => 'curl unix CLI http client',
-        'ColdFusion' => 'ColdFusion http library',
-        'EventMachine HttpClient' => 'Ruby http library',
-        'Go http package' => 'Go http library',
-        'Go-http-client' => 'Go http library',
-        'Java' => 'Generic Java http library',
-        'libwww-perl' => 'Perl client-server library loved by script kids',
-        'lwp-trivial' => 'Another Perl library loved by script kids',
-        'Python-urllib' => 'Python http library',
-        'PycURL' => 'Python http library',
-        'Test Certificate Info' => 'C http library?',
-        'Typhoeus' => 'Ruby http library',
-        'Wget' => 'wget unix CLI http client',
+        "Apache-HttpClient" => "Java http library",
+        "AppEngine-Google" => "Google App Engine",
+        "curl" => "curl unix CLI http client",
+        "ColdFusion" => "ColdFusion http library",
+        "EventMachine HttpClient" => "Ruby http library",
+        "Go http package" => "Go http library",
+        "Go-http-client" => "Go http library",
+        "Java" => "Generic Java http library",
+        "libwww-perl" => "Perl client-server library loved by script kids",
+        "lwp-trivial" => "Another Perl library loved by script kids",
+        "Python-urllib" => "Python http library",
+        "PycURL" => "Python http library",
+        "Test Certificate Info" => "C http library?",
+        "Typhoeus" => "Ruby http library",
+        "Wget" => "wget unix CLI http client",
 
         # URL expanders / previewers
-        'awe.sm' => 'Awe.sm URL expander',
-        'bitlybot' => 'bit.ly bot',
-        'bot@linkfluence.net' => 'Linkfluence bot',
-        'facebookexternalhit' => 'facebook bot',
-        'Facebot' => 'Facebook crawler',
-        'Feedfetcher-Google' => 'Google Feedfetcher',
-        'https://developers.google.com/+/web/snippet' => 'Google+ Snippet Fetcher',
-        'LinkedInBot' => 'LinkedIn bot',
-        'LongURL' => 'URL expander service',
-        'NING' => 'NING - Yet Another Twitter Swarmer',
-        'Pinterestbot' => 'Pinterest Bot',
-        'redditbot' => 'Reddit Bot',
-        'ShortLinkTranslate' => 'Link shortener',
-        'Slackbot' => 'Slackbot link expander',
-        'TweetmemeBot' => 'TweetMeMe Crawler',
-        'Twitterbot' => 'Twitter URL expander',
-        'UnwindFetch' => 'Gnip URL expander',
-        'vkShare' => 'VKontake Sharer',
+        "awe.sm" => "Awe.sm URL expander",
+        "bitlybot" => "bit.ly bot",
+        "bot@linkfluence.net" => "Linkfluence bot",
+        "facebookexternalhit" => "facebook bot",
+        "Facebot" => "Facebook crawler",
+        "Feedfetcher-Google" => "Google Feedfetcher",
+        "https://developers.google.com/+/web/snippet" => "Google+ Snippet Fetcher",
+        "LinkedInBot" => "LinkedIn bot",
+        "LongURL" => "URL expander service",
+        "NING" => "NING - Yet Another Twitter Swarmer",
+        "Pinterestbot" => "Pinterest Bot",
+        "redditbot" => "Reddit Bot",
+        "ShortLinkTranslate" => "Link shortener",
+        "Slackbot" => "Slackbot link expander",
+        "TweetmemeBot" => "TweetMeMe Crawler",
+        "Twitterbot" => "Twitter URL expander",
+        "UnwindFetch" => "Gnip URL expander",
+        "vkShare" => "VKontake Sharer",
 
         # Uptime monitoring
-        'check_http' => 'Nagios monitor',
-        'GoogleStackdriverMonitoring' => 'Google Cloud monitor',
-        'NewRelicPinger' => 'NewRelic monitor',
-        'Panopta' => 'Monitoring service',
-        'Pingdom' => 'Pingdom monitoring',
-        'SiteUptime' => 'Site monitoring services',
-        'UptimeRobot' => 'Monitoring service',
+        "check_http" => "Nagios monitor",
+        "GoogleStackdriverMonitoring" => "Google Cloud monitor",
+        "NewRelicPinger" => "NewRelic monitor",
+        "Panopta" => "Monitoring service",
+        "Pingdom" => "Pingdom monitoring",
+        "SiteUptime" => "Site monitoring services",
+        "UptimeRobot" => "Monitoring service",
 
         # ???
-        'DigitalPersona Fingerprint Software' => 'HP Fingerprint scanner',
-        'ShowyouBot' => 'Showyou iOS app spider',
-        'ZyBorg' => 'Zyborg? Hmmm....',
-        'ELB-HealthChecker' => 'ELB Health Check'
+        "DigitalPersona Fingerprint Software" => "HP Fingerprint scanner",
+        "ShowyouBot" => "Showyou iOS app spider",
+        "ZyBorg" => "Zyborg? Hmmm....",
+        "ELB-HealthChecker" => "ELB Health Check"
       }
     end
 
-    def experiments= experiments
-      raise InvalidExperimentsFormatError.new('Experiments must be a Hash') unless experiments.respond_to?(:keys)
+    def experiments=(experiments)
+      raise InvalidExperimentsFormatError.new("Experiments must be a Hash") unless experiments.respond_to?(:keys)
       @experiments = experiments
     end
 
@@ -157,8 +157,8 @@ module Split
 
       @experiments.each do |experiment_name, settings|
         alternatives = if (alts = value_for(settings, :alternatives))
-                         normalize_alternatives(alts)
-                       end
+          normalize_alternatives(alts)
+        end
 
         experiment_data = {
           alternatives: alternatives,
@@ -213,14 +213,14 @@ module Split
 
     def initialize
       @ignore_ip_addresses = []
-      @ignore_filter = proc{ |request| is_robot? || is_ignored_ip_address? }
+      @ignore_filter = proc { |request| is_robot? || is_ignored_ip_address? }
       @db_failover = false
-      @db_failover_on_db_error = proc{|error|} # e.g. use Rails logger here
-      @on_experiment_reset = proc{|experiment|}
-      @on_experiment_delete = proc{|experiment|}
-      @on_before_experiment_reset = proc{|experiment|}
-      @on_before_experiment_delete = proc{|experiment|}
-      @on_experiment_winner_choose = proc{|experiment|}
+      @db_failover_on_db_error = proc { |error| } # e.g. use Rails logger here
+      @on_experiment_reset = proc { |experiment| }
+      @on_experiment_delete = proc { |experiment| }
+      @on_before_experiment_reset = proc { |experiment| }
+      @on_before_experiment_delete = proc { |experiment| }
+      @on_experiment_winner_choose = proc { |experiment| }
       @db_failover_allow_parameter_override = false
       @allow_multiple_experiments = false
       @enabled = true
@@ -232,20 +232,19 @@ module Split
       @include_rails_helper = true
       @beta_probability_simulations = 10000
       @winning_alternative_recalculation_interval = 60 * 60 * 24 # 1 day
-      @redis = ENV.fetch(ENV.fetch('REDIS_PROVIDER', 'REDIS_URL'), 'redis://localhost:6379')
+      @redis = ENV.fetch(ENV.fetch("REDIS_PROVIDER", "REDIS_URL"), "redis://localhost:6379")
       @dashboard_pagination_default_per_page = 10
     end
 
     private
-
-    def value_for(hash, key)
-      if hash.kind_of?(Hash)
-        hash.has_key?(key.to_s) ? hash[key.to_s] : hash[key.to_sym]
+      def value_for(hash, key)
+        if hash.kind_of?(Hash)
+          hash.has_key?(key.to_s) ? hash[key.to_s] : hash[key.to_sym]
+        end
       end
-    end
 
-    def escaped_bots
-      bots.map { |key, _| Regexp.escape(key) }
-    end
+      def escaped_bots
+        bots.map { |key, _| Regexp.escape(key) }
+      end
   end
 end

data/lib/split/dashboard/helpers.rb

@@ -7,11 +7,11 @@ module Split
     end
 
     def url(*path_parts)
-      [ path_prefix, path_parts ].join("/").squeeze('/')
+      [ path_prefix, path_parts ].join("/").squeeze("/")
     end
 
     def path_prefix
-      request.env['SCRIPT_NAME']
+      request.env["SCRIPT_NAME"]
     end
 
     def number_to_percentage(number, precision = 2)
@@ -32,15 +32,14 @@ module Split
       z = round(z_score.to_s.to_f, 3).abs
 
       if z >= 2.58
-        '99% confidence'
+        "99% confidence"
       elsif z >= 1.96
-        '95% confidence'
+        "95% confidence"
       elsif z >= 1.65
-        '90% confidence'
+        "90% confidence"
       else
-        'Insufficient confidence'
+        "Insufficient confidence"
       end
-
     end
   end
 end

data/lib/split/dashboard/pagination_helpers.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'split/dashboard/paginator'
+require "split/dashboard/paginator"
 
 module Split
   module DashboardPaginationHelpers
@@ -30,58 +30,57 @@ module Split
     end
 
     private
-
-    def show_first_page_tag?
-      page_number > 2
-    end
-
-    def first_page_tag
-      %Q(<a href="#{url.chop}?page=1&per=#{pagination_per}">1</a>)
-    end
-
-    def show_first_ellipsis_tag?
-      page_number >= 4
-    end
-
-    def ellipsis_tag
-      '<span>...</span>'
-    end
-
-    def show_prev_page_tag?
-      page_number > 1
-    end
-
-    def prev_page_tag
-      %Q(<a href="#{url.chop}?page=#{page_number - 1}&per=#{pagination_per}">#{page_number - 1}</a>)
-    end
-
-    def current_page_tag
-      "<span><b>#{page_number}</b></span>"
-    end
-
-    def show_next_page_tag?(collection)
-      (page_number * pagination_per) < collection.count
-    end
-
-    def next_page_tag
-      %Q(<a href="#{url.chop}?page=#{page_number + 1}&per=#{pagination_per}">#{page_number + 1}</a>)
-    end
-
-    def show_last_ellipsis_tag?(collection)
-      (total_pages(collection) - page_number) >= 3
-    end
-
-    def total_pages(collection)
-      collection.count / pagination_per + ((collection.count % pagination_per).zero? ? 0 : 1)
-    end
-
-    def show_last_page_tag?(collection)
-      page_number < (total_pages(collection) - 1)
-    end
-
-    def last_page_tag(collection)
-      total = total_pages(collection)
-      %Q(<a href="#{url.chop}?page=#{total}&per=#{pagination_per}">#{total}</a>)
-    end
+      def show_first_page_tag?
+        page_number > 2
+      end
+
+      def first_page_tag
+        %Q(<a href="#{url.chop}?page=1&per=#{pagination_per}">1</a>)
+      end
+
+      def show_first_ellipsis_tag?
+        page_number >= 4
+      end
+
+      def ellipsis_tag
+        "<span>...</span>"
+      end
+
+      def show_prev_page_tag?
+        page_number > 1
+      end
+
+      def prev_page_tag
+        %Q(<a href="#{url.chop}?page=#{page_number - 1}&per=#{pagination_per}">#{page_number - 1}</a>)
+      end
+
+      def current_page_tag
+        "<span><b>#{page_number}</b></span>"
+      end
+
+      def show_next_page_tag?(collection)
+        (page_number * pagination_per) < collection.count
+      end
+
+      def next_page_tag
+        %Q(<a href="#{url.chop}?page=#{page_number + 1}&per=#{pagination_per}">#{page_number + 1}</a>)
+      end
+
+      def show_last_ellipsis_tag?(collection)
+        (total_pages(collection) - page_number) >= 3
+      end
+
+      def total_pages(collection)
+        collection.count / pagination_per + ((collection.count % pagination_per).zero? ? 0 : 1)
+      end
+
+      def show_last_page_tag?(collection)
+        page_number < (total_pages(collection) - 1)
+      end
+
+      def last_page_tag(collection)
+        total = total_pages(collection)
+        %Q(<a href="#{url.chop}?page=#{total}&per=#{pagination_per}">#{total}</a>)
+      end
   end
 end

data/lib/split/dashboard/public/style.css

@@ -258,7 +258,7 @@ body {
   color: #408C48;
 }
 
-a.button, button, input[type="submit"] {
+.experiment a.button, .experiment button, .experiment input[type="submit"] {
   padding: 4px 10px;
   overflow: hidden;
   background: #d8dae0;
@@ -312,10 +312,13 @@ a.button.green:focus, button.green:focus, input[type="submit"].green:focus {
   background:#768E7A;
 }
 
-#filter, #clear-filter {
+.dashboard-controls input, .dashboard-controls select {
   padding: 10px;
 }
 
+.dashboard-controls-bottom {
+  margin-top: 10px;
+}
 
 .pagination {
   text-align: center;

data/lib/split/dashboard/views/_experiment.erb

@@ -16,7 +16,8 @@
   summary_texts = {}
   extra_columns.each do |column|
     extra_infos = experiment.alternatives.map(&:extra_info).select{|extra_info| extra_info && extra_info[column] }
-    if extra_infos[0][column].kind_of?(Numeric)
+
+    if extra_infos.length > 0 && extra_infos.all? { |extra_info| extra_info[column].kind_of?(Numeric) }
       summary_texts[column] = extra_infos.inject(0){|sum, extra_info| sum += extra_info[column]}
     else
       summary_texts[column] = "N/A"

data/lib/split/dashboard/views/index.erb

@@ -1,10 +1,12 @@
 <% if @experiments.any? %>
   <p class="intro">The list below contains all the registered experiments along with the number of test participants, completed and conversion rate currently in the system.</p>
 
-  <input type="text" placeholder="Begin typing to filter" id="filter" />
-  <input type="button" id="toggle-completed" value="Hide completed" />
-  <input type="button" id="toggle-active" value="Hide active" />
-  <input type="button" id="clear-filter" value="Clear filters" />
+  <div class="dashboard-controls">
+    <input type="text" placeholder="Begin typing to filter" id="filter" />
+    <input type="button" id="toggle-completed" value="Hide completed" />
+    <input type="button" id="toggle-active" value="Hide active" />
+    <input type="button" id="clear-filter" value="Clear filters" />
+  </div>
 
   <% paginated(@experiments).each do |experiment| %>
     <% if experiment.goals.empty? %>
@@ -24,3 +26,16 @@
   <p class="intro">No experiments have started yet, you need to define them in your code and introduce them to your users.</p>
   <p class="intro">Check out the <a href='https://github.com/splitrb/split#readme'>Readme</a> for more help getting started.</p>
 <% end %>
+
+<div class="dashboard-controls dashboard-controls-bottom">
+  <form action="<%= url "/initialize_experiment" %>" method='post'>
+    <label>Add unregistered experiment: </label>
+    <select name="experiment" id="experiment-select">
+      <option selected disabled>experiment</option>
+      <% @unintialized_experiments.sort.each do |experiment_name| %>
+          <option value="<%= experiment_name %>"><%= experiment_name %></option>
+      <% end %>
+    </select>
+    <input type="submit" id="register-experiment-btn" value="register experiment"/>
+  </form>
+<div>

data/lib/split/dashboard.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require 'sinatra/base'
-require 'split'
-require 'bigdecimal'
-require 'split/dashboard/helpers'
-require 'split/dashboard/pagination_helpers'
+require "sinatra/base"
+require "split"
+require "bigdecimal"
+require "split/dashboard/helpers"
+require "split/dashboard/pagination_helpers"
 
 module Split
   class Dashboard < Sinatra::Base
@@ -18,14 +18,15 @@ module Split
     helpers Split::DashboardHelpers
     helpers Split::DashboardPaginationHelpers
 
-    get '/' do
+    get "/" do
       # Display experiments without a winner at the top of the dashboard
       @experiments = Split::ExperimentCatalog.all_active_first
+      @unintialized_experiments = Split.configuration.experiments.keys - @experiments.map(&:name)
 
       @metrics = Split::Metric.all
 
       # Display Rails Environment mode (or Rack version if not using Rails)
-      if Object.const_defined?('Rails')
+      if Object.const_defined?("Rails") && Rails.respond_to?(:env)
         @current_env = Rails.env.titlecase
       else
         @current_env = "Rack: #{Rack.version}"
@@ -33,43 +34,48 @@ module Split
       erb :index
     end
 
-    post '/force_alternative' do
+    post "/initialize_experiment" do
+      Split::ExperimentCatalog.find_or_create(params[:experiment]) unless params[:experiment].nil? || params[:experiment].empty?
+      redirect url("/")
+    end
+
+    post "/force_alternative" do
       experiment = Split::ExperimentCatalog.find(params[:experiment])
       alternative = Split::Alternative.new(params[:alternative], experiment.name)
 
-      cookies = JSON.parse(request.cookies['split_override']) rescue {}
+      cookies = JSON.parse(request.cookies["split_override"]) rescue {}
       cookies[experiment.name] = alternative.name
-      response.set_cookie('split_override', { value: cookies.to_json, path: '/' })
+      response.set_cookie("split_override", { value: cookies.to_json, path: "/" })
 
-      redirect url('/')
+      redirect url("/")
     end
 
-    post '/experiment' do
+    post "/experiment" do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @alternative = Split::Alternative.new(params[:alternative], params[:experiment])
       @experiment.winner = @alternative.name
-      redirect url('/')
+      redirect url("/")
     end
 
-    post '/start' do
+    post "/start" do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.start
-      redirect url('/')
+      redirect url("/")
     end
 
-    post '/reset' do
+    post "/reset" do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.reset
-      redirect url('/')
+      redirect url("/")
     end
 
-    post '/reopen' do
+    post "/reopen" do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.reset_winner
-      redirect url('/')
+      redirect url("/")
     end
 
-    post '/update_cohorting' do
+    post "/update_cohorting" do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       case params[:cohorting_action].downcase
       when "enable"
@@ -77,13 +83,13 @@ module Split
       when "disable"
         @experiment.disable_cohorting
       end
-      redirect url('/')
+      redirect url("/")
     end
 
-    delete '/experiment' do
+    delete "/experiment" do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.delete
-      redirect url('/')
+      redirect url("/")
     end
   end
 end

data/lib/split/encapsulated_helper.rb

@@ -15,7 +15,6 @@ require "split/helper"
 #
 module Split
   module EncapsulatedHelper
-
     class ContextShim
       include Split::Helper
       public :ab_test, :ab_finished
@@ -34,10 +33,9 @@ module Split
     end
 
     private
-
-    # instantiate and memoize a context shim in case of multiple ab_test* calls
-    def split_context_shim
-      @split_context_shim ||= ContextShim.new(self)
-    end
+      # instantiate and memoize a context shim in case of multiple ab_test* calls
+      def split_context_shim
+        @split_context_shim ||= ContextShim.new(self)
+      end
   end
 end