spade-packager 0.1.0

data/spec/cli/unyank_spec.rb

@@ -0,0 +1,73 @@
+require "spec_helper"
+
+describe "spade unyank" do
+  let(:api_key) { "deadbeef" }
+  let(:creds)   { spade_dir("credentials") }
+
+  before do
+    goto_home
+    set_host
+    start_fake(FakeGemcutter.new(api_key))
+  end
+
+  context "with a good api key" do
+    before do
+      write_api_key(api_key)
+    end
+
+    it "unyanks a gem when sent with the right api key" do
+      spade "package", "yank", "core-test", "--undo", "-v", "1.4.3"
+
+      stdout.read.should include("Successfully unyanked gem: core-test (1.4.3)")
+    end
+
+    it "must unyank a valid gem" do
+      spade "package", "yank", "blahblah", "--undo", "-v", "0.0.1"
+
+      stdout.read.should include("This gem could not be found")
+    end
+
+    it "does not unyank and indexed gem" do
+      spade "package", "yank", "core-test", "--undo", "-v", "2.4.3"
+
+      stdout.read.should include("The version 2.4.3 is already indexed.")
+    end
+  end
+
+  it "shows rejection message if wrong api key is supplied" do
+    write_api_key("beefbeef")
+
+    spade "package", "yank", "core-test", "--undo", "-v", "1.4.3"
+
+    stdout.read.should include("One cannot simply walk into Mordor!")
+  end
+end
+
+describe "spade unyank with invalid api key" do
+  before do
+    cd(home)
+    env["HOME"] = home.to_s
+    env["RUBYGEMS_HOST"] = "http://localhost:9292"
+    write_api_key("beefbeef")
+  end
+
+  it "must require a version" do
+    spade "package", "yank", "core-test", "--undo"
+
+    stdout.read.should include("Version required")
+  end
+end
+
+describe "spade unyank without api key" do
+  before do
+    cd(home)
+    env["HOME"] = home.to_s
+    env["RUBYGEMS_HOST"] = "http://localhost:9292"
+  end
+
+  it "asks for login first if api key does not exist" do
+    spade "package", "yank", "core-test", "-v", "1.4.3", "--undo"
+
+    stdout.read.should include("Please login first with `spade login`")
+  end
+end

data/spec/cli/yank_spec.rb

@@ -0,0 +1,73 @@
+require "spec_helper"
+
+describe "spade yank" do
+  let(:api_key) { "deadbeef" }
+  let(:creds)   { spade_dir("credentials") }
+
+  before do
+    goto_home
+    set_host
+    start_fake(FakeGemcutter.new(api_key))
+  end
+
+  context "with a good api key" do
+    before do
+      write_api_key(api_key)
+    end
+
+    it "yanks a gem when sent with the right api key" do
+      spade "package", "yank", "core-test", "-v", "1.4.3"
+
+      stdout.read.should include("Successfully yanked gem: core-test (1.4.3)")
+    end
+
+    it "must yank a valid gem" do
+      spade "package", "yank", "blahblah", "-v", "0.0.1"
+
+      stdout.read.should include("This gem could not be found")
+    end
+
+    it "does not yank a yanked gem" do
+      spade "package", "yank", "core-test", "-v", "2.4.3"
+
+      stdout.read.should include("The version 2.4.3 has already been yanked.")
+    end
+  end
+
+  it "shows rejection message if wrong api key is supplied" do
+    write_api_key("beefbeef")
+
+    spade "package", "yank", "core-test", "-v", "1.4.3"
+
+    stdout.read.should include("One cannot simply walk into Mordor!")
+  end
+end
+
+describe "spade yank without api key" do
+  before do
+    cd(home)
+    env["HOME"] = home.to_s
+    env["RUBYGEMS_HOST"] = "http://localhost:9292"
+    write_api_key("beefbeef")
+  end
+
+  it "must require a version" do
+    spade "package", "yank", "core-test"
+
+    stdout.read.should include("Version required")
+  end
+end
+
+describe "spade yank without api key" do
+  before do
+    cd(home)
+    env["HOME"] = home.to_s
+    env["RUBYGEMS_HOST"] = "http://localhost:9292"
+  end
+
+  it "asks for login first if api key does not exist" do
+    spade "package", "yank", "core-test", "-v", "1.4.3"
+
+    stdout.read.should include("Please login first with `spade login`")
+  end
+end

data/spec/credentials_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Spade::Packager::Credentials do
+  def new_creds
+    Spade::Packager::Credentials.new
+  end
+
+  around do |example|
+    cd(home)
+    LibGems.send(:set_home, home)
+    example.call
+    LibGems.clear_paths
+  end
+
+  subject { new_creds }
+
+  it "saves the api key and email" do
+    subject.save("someone@example.com", "secrets")
+
+    new_creds.api_key.should == "secrets"
+    new_creds.email.should == "someone@example.com"
+  end
+end

data/spec/fixtures/core-test/bin/cot

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+# Placeholder for test, do not remove

data/spec/fixtures/core-test/lib/main.js

@@ -0,0 +1 @@
+// Placeholder for test, do not remove

data/spec/fixtures/core-test/tests/test.js

@@ -0,0 +1 @@
+// Placeholder for test, do not remove

data/spec/fixtures/package.json

@@ -0,0 +1,30 @@
+{
+  "name": "core-test",
+  "description": "Flexible testing library for JavaScript.",
+  "summary": "A fully featured asynchronous testing library for JavaScript, compatible with other frameworks.",
+  "keywords": ["javascript", "testing"],
+  "author": "Charles Jolley",
+  "homepage": "https://github.com/strobecorp/core-test",
+  "version": "0.4.3",
+  "licenses":     [{
+    "type":       "MIT",
+    "url":        "https://github.com/strobecorp/core-test/raw/master/LICENSE"
+  }],
+  "engines": ["browser", "all"],
+  "directories": {
+    "lib": "./lib",
+    "resources": "./resources",
+    "test": "./tests"
+  },
+  "main": "./lib/main",
+  "bin": {
+    "cot": "./bin/cot"
+  },
+  "dependencies": {
+    "ivory": "= 0.0.1",
+    "optparse": "= 1.0.1"
+  }
+}
+
+
+

data/spec/gauntlet_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+
+describe "spade build the gauntlet" do
+  before do
+    cd(home)
+    env["HOME"] = home.to_s
+    write_creds("user@example.com", "deadbeef")
+  end
+
+  {
+    "ivory"                => "0.0.1",
+    "jquery"               => "1.4.3",
+    "optparse"             => "1.0.1",
+    "web-file"             => "0.0.1",
+    "web-typed-array"      => "0.0.1",
+  }.each do |package, version|
+    it "builds a spade from #{package}" do
+      FileUtils.cp_r root.join("packages/#{package}"), package
+      cd package
+      spade "package", "build"
+
+      exit_status.should be_success
+      stdout.read.should include("Successfully built package: #{package}-#{version}.spd")
+      File.exist?(tmp.join(package, "#{package}-#{version}.spd"))
+    end
+  end
+end

data/spec/package_spec.rb

@@ -0,0 +1,267 @@
+require "spec_helper"
+
+describe Spade::Packager::Package, "#to_spec" do
+  let(:email) { "user@example.com" }
+
+  before do
+    cd(home)
+    FileUtils.mkdir_p(home("lib"))
+    FileUtils.mkdir_p(home("resources"))
+    FileUtils.mkdir_p(home("tests"))
+  end
+
+  subject do
+    package = Spade::Packager::Package.new(email)
+    package.json_path = fixtures("package.json")
+    if spec = package.to_spec
+      spec
+    else
+      puts "Errors: #{package.errors}"
+      nil
+    end
+  end
+
+  it "transforms the name" do
+    subject.name.should == "core-test"
+  end
+
+  it "transforms the version" do
+    subject.version.should == LibGems::Version.new("0.4.3")
+  end
+
+  it "transforms the author" do
+    subject.authors.should == ["Charles Jolley"]
+  end
+
+  it "transforms the email" do
+    subject.email.should == email
+  end
+
+  it "transforms the homepage" do
+    subject.homepage.should == "https://github.com/strobecorp/core-test"
+  end
+
+  it "transforms the description" do
+    subject.description.should == "Flexible testing library for JavaScript."
+  end
+
+  it "transforms the description" do
+    subject.summary.should == "A fully featured asynchronous testing library for JavaScript, compatible with other frameworks."
+  end
+
+  it "transforms the dependencies" do
+    subject.dependencies.map{|d| [d.name, d.requirement]}.should == [["ivory", "= 0.0.1"], ["optparse", "= 1.0.1"]]
+  end
+
+  it "packs metadata into requirements" do
+    metadata = JSON.parse(subject.requirements.first)
+    metadata["keywords"].should == %w[javascript testing]
+    metadata["licenses"].should == [
+      {"type" => "MIT",
+       "url"  => "https://github.com/strobecorp/core-test/raw/master/LICENSE"}
+    ]
+    metadata["engines"].should == ["browser", "all"]
+    metadata["main"].should == "./lib/main"
+    metadata["bin"].should == {"cot" => "./bin/cot"}
+  end
+
+  def expand_sort(files)
+    files.map { |f| File.expand_path(f) }.sort
+  end
+
+  it "expands paths from the directories" do
+    others     = ["tmp/blah.js", "tmp/whee.txt"]
+    files      = ["bin/cot", "lib/main.js", "lib/core.js", "lib/test.js", "package.json", "resources/additions.css", "resources/runner.css"]
+    test_files = ["tests/apis/core-test.js", "tests/system/test/assert-test.js"]
+
+    FileUtils.mkdir_p(["bin/", "resources/", "lib/", "tests/apis", "tests/system/test", "tmp/"])
+    FileUtils.touch(files + test_files + others)
+
+    expand_sort(subject.files).should == expand_sort(files + test_files)
+    expand_sort(subject.test_files).should == expand_sort(test_files)
+  end
+
+  it "hacks the file name to return .spd" do
+    subject.file_name.should == "core-test-0.4.3.spd"
+  end
+
+  it "sets the rubyforge_project to appease older versions of rubygems" do
+    subject.rubyforge_project.should == "spade"
+  end
+end
+
+describe Spade::Packager::Package, "#to_s" do
+  let(:email) { "user@example.com" }
+
+  subject do
+    package = Spade::Packager::Package.new
+    package.json_path = fixtures("package.json")
+    package.valid?
+    package
+  end
+
+  it "gives the name and version" do
+    subject.to_full_name.should == "core-test-0.4.3"
+  end
+end
+
+describe Spade::Packager::Package, "converting" do
+  before do
+    cd(home)
+  end
+
+  subject do
+    package = Spade::Packager::Package.new
+    package.spade = fixtures("core-test-0.4.3.spd")
+    package.as_json
+  end
+
+  it "can recreate the same package.json from the package" do
+    subject.should == JSON.parse(File.read(fixtures("package.json")))
+  end
+end
+
+describe Spade::Packager::Package, "validating" do
+  before do
+    cd(home)
+  end
+
+  subject { Spade::Packager::Package.new }
+
+  shared_examples_for "a good parser" do
+    it "had a problem parsing package.json" do
+      subject.should have_error("There was a problem parsing package.json")
+    end
+  end
+
+  context "with a blank file" do
+    before do
+      FileUtils.touch("package.json")
+      subject.json_path = "package.json"
+    end
+    it_should_behave_like "a good parser"
+  end
+
+  context "with bad json" do
+    before do
+      File.open("package.json", "w") do |f|
+        f.write "---bad json---"
+      end
+      subject.json_path = "package.json"
+    end
+    it_should_behave_like "a good parser"
+  end
+
+  context "json can't be read" do
+    before do
+      FileUtils.cp fixtures("package.json"), "."
+      FileUtils.chmod 0000, "package.json"
+      subject.json_path = "package.json"
+    end
+    it_should_behave_like "a good parser"
+  end
+
+  context "json can't be found" do
+    before do
+      subject.json_path = "package.json"
+    end
+    it_should_behave_like "a good parser"
+  end
+
+end
+
+describe Spade::Packager::Package, "validation errors" do
+  let(:email) { "user@example.com" }
+
+  before do
+    cd(home)
+    FileUtils.mkdir_p(home("lib"))
+    FileUtils.mkdir_p(home("tests"))
+  end
+
+  subject do
+    Spade::Packager::Package.new(email)
+  end
+
+  def write_package
+    path    = home("package.json")
+    package = JSON.parse(File.read(fixtures("package.json")))
+    yield package
+    File.open(path, "w") do |file|
+      file.write package.to_json
+    end
+    subject.json_path = path
+  end
+
+  %w[name description summary homepage author version directories].each do |field|
+    it "is invalid without a #{field} field" do
+      write_package do |package|
+        package.delete(field)
+      end
+
+      subject.should have_error("Package requires a '#{field}' field")
+    end
+
+    it "is invalid with a blank #{field} field" do
+      write_package do |package|
+        package[field] = ""
+      end
+
+      subject.should have_error("Package requires a '#{field}' field")
+    end
+  end
+
+  it "is invalid without a proper version number" do
+    write_package do |package|
+      package["version"] = "bad"
+    end
+
+    subject.should have_error("Malformed version number string bad")
+  end
+
+  it "is valid without specifying a test directory" do
+    write_package do |package|
+      package["directories"].delete("test")
+    end
+
+    subject.should be_valid
+    subject.to_spec.test_files.should == []
+  end
+
+  it "is valid and has files without specifying bin" do
+    write_package do |package|
+      package.delete("bin")
+    end
+
+    subject.should be_valid
+    subject.to_spec.files.should == ["package.json"]
+  end
+
+  %w[lib test].each do |dir|
+    it "is invalid without a #{dir} directory that exists" do
+      write_package do |package|
+        package["directories"][dir] = "nope"
+      end
+
+      subject.should have_error("'nope' specified for #{dir} directory, is not a directory")
+    end
+
+    it "is valid without a #{dir} directory that exists" do
+    FileUtils.mkdir_p(home("somewhere", "else"))
+      write_package do |package|
+        package["directories"][dir] = "./somewhere/else"
+      end
+
+      subject.should be_valid
+    end
+
+    it "is invalid if #{dir} points to a file" do
+      FileUtils.touch(home("somefile"))
+      write_package do |package|
+        package["directories"][dir] = "./somefile"
+      end
+
+      subject.should have_error("'./somefile' specified for #{dir} directory, is not a directory")
+    end
+  end
+end